Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24426 )
Change subject: IMPALA-14601: Support HBO for JoinNode cardinality ...................................................................... Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/24426/23/tests/query_test/test_hbo.py File tests/query_test/test_hbo.py: http://gerrit.cloudera.org:8080/#/c/24426/23/tests/query_test/test_hbo.py@62 PS23, Line 62: # To avoid the test being fragile, we only compare the cardinality lines. The join goldens this patch adds carry the distribution mode - 04:HASH JOIN [INNER JOIN, PARTITIONED] and 03:HASH JOIN [INNER JOIN, BROADCAST] in hbo-inner-join.test, [LEFT OUTER JOIN, BROADCAST] and [RIGHT OUTER JOIN, PARTITIONED] in hbo-outer-join.test - but the filter here keeps only lines containing 'cardinality', and the mode lines don't have it. Same for |--06:EXCHANGE [BROADCAST]. So a change that flipped every join in these files between broadcast and partitioned would still pass. That mode is downstream of HBO: the corrected cardinality feeds rhsDataSize in DistributedPlanner.createHashJoinFragment(), which is what computeJoinDistributionMode() compares. It looks worth pinning next to cardinality, maybe by also keeping lines that match the join/exchange distribution mode. Would you rather do that here or leave it for a follow-up? I am happy to pick it up if you prefer to keep this patch focused. -- To view, visit http://gerrit.cloudera.org:8080/24426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70b655ae7027d0d9eb8e9fae9ba2e1b7ad9876b4 Gerrit-Change-Number: 24426 Gerrit-PatchSet: 23 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 15:44:31 +0000 Gerrit-HasComments: Yes
