Todd Lipcon has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set ......................................................................
Patch Set 1: (2 comments) please add a unit test for this as well http://gerrit.cloudera.org:8080/#/c/5237/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: PS1, Line 596: columnsBitSet != null columnsBitSet is always non-NULL PS1, Line 597: sb.append("Column \'"); : sb.append(col.getName()); : sb.append("\' is not set"); : I think it's better to just not include it in the string, rather than include "not set" -- To view, visit http://gerrit.cloudera.org:8080/5237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: YanlongZheng <yan-long.zh...@outlook.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
