YanlongZheng has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5237/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: PS1, Line 597: return; : } : : > I think it's better to just not include it in the string, rather than inclu Currently we have two kinds of debug string: debug string and short debug string. If not include it, the outputs are like: (for example, key2 is not set) debug string: int key1=123, int key2=, int val1=456, ... short debug string: 123, , 456, ... Personally, I think these are better: debug string: int key1=234, int key2=(not set), int val1=456, ... short debug string: 123, (not set), 456, ... Could you please consider a little more and make the final decision? Then I will make the change. http://gerrit.cloudera.org:8080/#/c/5237/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: PS2, Line 596: { : return; : } Currently we have two kinds of debug string: debug string and short debug string. If not include any information, the outputs are like: (for example, key2 is not set) debug string: int key1=123, int key2=, int val1=456, ... short debug string: 123, , 456, ... Personally, I think these are better: debug string: int key1=234, int key2=(not set), int val1=456, ... short debug string: 123, (not set), 456, ... Could you please consider a little more and make the final decision? Then I will make the change. -- To view, visit http://gerrit.cloudera.org:8080/5237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: YanlongZheng <yan-long.zh...@outlook.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: YanlongZheng <yan-long.zh...@outlook.com> Gerrit-HasComments: Yes
