Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 )
Change subject: WIP: [metrics] Add metric severity level ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14630/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14630/1//COMMIT_MSG@26 PS1, Line 26: Additionally a configuration flag, `metrics_default_level`, was added with : a default value of `info` to drastically reduce the metrics shown by default. Haven't looked at the patch yet, but wanted to say that while configurable severity for metrics is useful, we should collect feedback from users to see whether there's consensus for reducing the metric volume by default. One option could be to introduce the severity level in one release, then change the default in the next after soliciting feedback. Or you could try to collect that feedback now. -- To view, visit http://gerrit.cloudera.org:8080/14630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa7d2323bb75700104c348a3ae859fc449e1715 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 05 Nov 2019 08:26:32 +0000 Gerrit-HasComments: Yes
