Hello Tidy Bot, Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14630 to look at the new patch set (#4). Change subject: [metrics] Add metric severity level ...................................................................... [metrics] Add metric severity level Kudu has somewhere around 200 metrics defined for the server and tablet entities. The result is a lot of useful information. However, it is also difficult to view and understand which metrics are important. Additionally, as the tablet count grows within the cluster the tablet level metrics eventually become overwhelming for users and metric collection tools. For example a server with 3777 live tablet replicas has json metrics over 58 MiB in size. Kudu already has the ability to filter metrics by type, attribute, name, etc. This patch adds the additional capability to filter by metric “severity level”. In order to do this, this patch introduces three metric severity levels: debug, info, and warn. These levels are defined similar to logging severity levels. See the `MetricLevel` documentation in `metrics.h` for a more detailed definition of each level. Additionally a configuration flag, `metrics_default_level`, was added with a default value of `debug` to include all metrics by default but allow users to configure the default to drastically reduce the metrics ouput. This patch takes a quick first pass at setting metric levels, overtime the level of metrics can be adjusted based on their demand. Change-Id: I5aa7d2323bb75700104c348a3ae859fc449e1715 Signed-off-by: Grant Henke <granthe...@apache.org> --- M docs/administration.adoc M src/kudu/clock/hybrid_clock.cc M src/kudu/clock/logical_clock.cc M src/kudu/clock/logical_clock.h M src/kudu/codegen/compilation_manager.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/log_metrics.cc M src/kudu/consensus/log_reader.cc M src/kudu/consensus/raft_consensus.cc M src/kudu/fs/block_manager_metrics.cc M src/kudu/fs/data_dirs.cc M src/kudu/fs/log_block_manager.cc M src/kudu/kserver/kserver.cc M src/kudu/kserver/kserver.h M src/kudu/master/location_cache.cc M src/kudu/master/sentry_client_metrics.cc M src/kudu/master/sentry_privileges_cache_metrics.cc M src/kudu/master/table_metrics.cc M src/kudu/master/ts_manager.cc M src/kudu/rpc/acceptor_pool.cc M src/kudu/rpc/protoc-gen-krpc.cc M src/kudu/rpc/reactor.cc M src/kudu/rpc/service_pool.cc M src/kudu/server/default_path_handlers.cc M src/kudu/server/glog_metrics.cc M src/kudu/server/tcmalloc_metrics.cc M src/kudu/tablet/tablet.cc M src/kudu/tablet/tablet_metrics.cc M src/kudu/tablet/tablet_replica.cc M src/kudu/tablet/tablet_replica_mm_ops.cc M src/kudu/tablet/transactions/transaction_tracker.cc M src/kudu/tserver/scanner_metrics.cc M src/kudu/tserver/scanners.cc M src/kudu/tserver/tablet_copy_client.cc M src/kudu/tserver/tablet_copy_source_session.cc M src/kudu/tserver/tablet_server-stress-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/util/block_cache_metrics.cc M src/kudu/util/file_cache_metrics.cc M src/kudu/util/maintenance_manager-test.cc M src/kudu/util/metrics-test.cc M src/kudu/util/metrics.cc M src/kudu/util/metrics.h M src/kudu/util/mt-metrics-test.cc M src/kudu/util/spinlock_profiling.cc M src/kudu/util/thread.cc M src/kudu/util/threadpool-test.cc M src/kudu/util/ttl_cache_test_metrics.cc 50 files changed, 598 insertions(+), 201 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/14630/4 -- To view, visit http://gerrit.cloudera.org:8080/14630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5aa7d2323bb75700104c348a3ae859fc449e1715 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)