Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 )
Change subject: [metrics] Add metric severity level ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14630/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14630/1//COMMIT_MSG@26 PS1, Line 26: Additionally a configuration flag, `metrics_default_level`, was added with : a default value of `info` to drastically reduce the metrics shown by default. > Haven't looked at the patch yet, but wanted to say that while configurable I am happy to decouple changing the default into a separate change. Ideally, it would be done before the next release to help alleviate pain we have seen from massive metrics output, but I will collect feedback and good metrics on the size impact before making that change. -- To view, visit http://gerrit.cloudera.org:8080/14630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa7d2323bb75700104c348a3ae859fc449e1715 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 05 Nov 2019 17:29:34 +0000 Gerrit-HasComments: Yes
