Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 )
Change subject: [metrics] Add metric severity level ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/master/sentry_client_metrics.cc File src/kudu/master/sentry_client_metrics.cc: http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/master/sentry_client_metrics.cc@29 PS3, Line 29: kudu::MetricLevel::kWarn); > shouldn't this and the one below be warn or at least info? Done http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/server/glog_metrics.cc File src/kudu/server/glog_metrics.cc: http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/server/glog_metrics.cc@28 PS3, Line 28: kudu::MetricLevel::kDebug); > do we need this to be info? Done http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/tablet/tablet_metrics.cc@307 PS3, Line 307: kudu::MetricLevel::kInfo); > should this be kInfo? Done http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/util/metrics-test.cc@961 PS3, Line 961: ASSERT_EQ(kEntityCount + 1, d.Size()); > wouldn't it be cleaner to increase kEntityCount by one and add +1 only in t Since kEntityCount is defined for the whole class I didn't change it. http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/14630/3/src/kudu/util/metrics.cc@295 PS3, Line 295: return MetricLevel::kDebug; > this and the WARNING message above should also be changed to kDebug until w Done -- To view, visit http://gerrit.cloudera.org:8080/14630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa7d2323bb75700104c348a3ae859fc449e1715 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 05 Nov 2019 20:32:09 +0000 Gerrit-HasComments: Yes
