Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14630 )
Change subject: [metrics] Add metric severity level ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/14630/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14630/4//COMMIT_MSG@34 PS4, Line 34: Signed-off-by: Grant Henke <granthe...@apache.org> > This is unusual, I think Weird, not sure how that got there. http://gerrit.cloudera.org:8080/#/c/14630/4/src/kudu/util/metrics.cc File src/kudu/util/metrics.cc: http://gerrit.cloudera.org:8080/#/c/14630/4/src/kudu/util/metrics.cc@292 PS4, Line 292: : LOG(WARNING) << "Unable to recognize the default metric level '" : << FLAGS_metrics_default_level << "', using debug as default."; : return MetricLevel::kDebug; : } : > This will probably be ignored and buried in logs. How could we add a valida I didn't think failing the server at startup was worth it just for a metric filter configuration. -- To view, visit http://gerrit.cloudera.org:8080/14630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa7d2323bb75700104c348a3ae859fc449e1715 Gerrit-Change-Number: 14630 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Wed, 06 Nov 2019 03:20:42 +0000 Gerrit-HasComments: Yes
