----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43879/#review120985 -----------------------------------------------------------
I like how the test feels much more readable than in earlier versions. However, I'm not sure why would we want this metric. I've been thinking about it and I cannot come up with a single use case in which I want to know how many times the allocator has run. I also don't see in the JIRA entry an use case for it. If you think of one you could add it there, if not, I don't think it makes sense to land this particular metric. src/master/allocator/mesos/hierarchical.hpp (line 286) <https://reviews.apache.org/r/43879/#comment182549> _s/in flight/queued/_ When I read _"in flight"_ I expect that the dispatch events are being executed, but after checking the code, one realizes they are just waiting. src/tests/hierarchical_allocator_tests.cpp (line 64) <https://reviews.apache.org/r/43879/#comment182544> Not used anywhere in the code. src/tests/hierarchical_allocator_tests.cpp (line 2395) <https://reviews.apache.org/r/43879/#comment182547> Not yours but we don't start function names with a capital letter and that threw me off for a while. I wasn't sure if a new object was being created every time. Do you think it makes sense to create a patch fixing that? - Alexander Rojas On Feb. 26, 2016, 6:03 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43879/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2016, 6:03 p.m.) > > > Review request for mesos, Alexander Rukletsov and Ben Mahler. > > > Bugs: MESOS-4718 > https://issues.apache.org/jira/browse/MESOS-4718 > > > Repository: mesos > > > Description > ------- > > Added allocator metrics for number of allocations made. > > > Diffs > ----- > > docs/monitoring.md 323d01d99456a71bd384faf186264e3fc4bf2207 > src/master/allocator/mesos/hierarchical.hpp > 3043888630b066505410d3b32c5b3f813cc458c1 > src/master/allocator/mesos/hierarchical.cpp > 5ef29f26ec8071f79c2f4f78dbe2bb0a613cc92d > src/tests/hierarchical_allocator_tests.cpp > 5f771f02db9bd098f3cd36730cd84bf2f5e87a33 > > Diff: https://reviews.apache.org/r/43879/diff/ > > > Testing > ------- > > make check (OS X) > > I confirmed that this does not lead to general performance regressions in the > allocator; this is partially expected since the added code only inserts > metrics in the allocator while the actual work is perform asynchronously. > These tests where performed with > `HierarchicalAllocator_BENCHMARK_Test.DeclineOffers` on an optimized build > under OS X using clang(trunk) as compiler. > > > Thanks, > > Benjamin Bannier > >
