grundprinzip commented on code in PR #38984:
URL: https://github.com/apache/spark/pull/38984#discussion_r1047178788
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -306,7 +312,10 @@ class SparkConnectPlanner(session: SparkSession) {
}
private def transformHint(rel: proto.Hint): LogicalPlan = {
- val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq
+ val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq.map {
+ case name: String => UnresolvedAttribute(name)
Review Comment:
In `transformUnresolvedExpression` we used the following notation
`UnresolvedAttribute.quotedString(name)` to have proper parsing of multi
level namsespace identifiers and generated column aliases like `sum(col1)`. I
think it makes sense to do the same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
