grundprinzip commented on code in PR #38984:
URL: https://github.com/apache/spark/pull/38984#discussion_r1047179670
##########
python/pyspark/sql/connect/column.py:
##########
@@ -18,26 +18,18 @@
from typing import get_args, TYPE_CHECKING, Callable, Any, Union, overload,
cast, Sequence
import json
-import decimal
-import datetime
-from pyspark.sql.types import TimestampType, DayTimeIntervalType, DataType,
DateType
+from pyspark.sql.types import DataType
import pyspark.sql.connect.proto as proto
-from pyspark.sql.connect.types import pyspark_types_to_proto_types
+from pyspark.sql.connect.types import pyspark_types_to_proto_types,
to_proto_literal
if TYPE_CHECKING:
from pyspark.sql.connect._typing import ColumnOrName, PrimitiveType
from pyspark.sql.connect.client import SparkConnectClient
import pyspark.sql.connect.proto as proto
-JVM_INT_MIN = -(1 << 31)
-JVM_INT_MAX = (1 << 31) - 1
-JVM_LONG_MIN = -(1 << 63)
-JVM_LONG_MAX = (1 << 63) - 1
-
-
Review Comment:
Why is all of this removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
