zhengruifeng commented on code in PR #38984:
URL: https://github.com/apache/spark/pull/38984#discussion_r1047918964


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -305,7 +305,11 @@ class SparkConnectPlanner(session: SparkSession) {
   }
 
   private def transformHint(rel: proto.Hint): LogicalPlan = {
-    val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq
+    val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq.map{
+      case name: String => UnresolvedAttribute(name)
+      case l: Long => l.toInt

Review Comment:
   after https://github.com/apache/spark/pull/39047, I think you can now create 
a literal int from the client side



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to