grundprinzip commented on code in PR #38984:
URL: https://github.com/apache/spark/pull/38984#discussion_r1047181152
##########
python/pyspark/sql/connect/types.py:
##########
@@ -41,6 +41,15 @@
BooleanType,
NullType,
)
+import decimal
Review Comment:
While I generally agree with the refactoring, I think it would be good to
split this into two PRs. One that does the refactoring and then this one.
Otherwise this just combines unrelated changes into one PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
