dengziming commented on code in PR #38984:
URL: https://github.com/apache/spark/pull/38984#discussion_r1047962586
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -306,7 +312,10 @@ class SparkConnectPlanner(session: SparkSession) {
}
private def transformHint(rel: proto.Hint): LogicalPlan = {
- val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq
+ val params = rel.getParametersList.asScala.map(toCatalystValue).toSeq.map {
+ case name: String => UnresolvedAttribute(name)
Review Comment:
Thank you for this suggestions, I change it to use
`UnresolvedAttribute.quotedString(name)` here too, however, I should clarify
that we don't support expression here, for example, `select /*+
REPARTITION(`user+1`) * from t` will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
