Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21649#discussion_r198722311 --- Diff: R/pkg/R/DataFrame.R --- @@ -3905,6 +3905,18 @@ setMethod("rollup", groupedData(sgd) }) +isTypeAllowed <- function(x) { --- End diff -- this is specific to hint types right? let's clarify that in the func name?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org