Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21649#discussion_r198913351 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -2370,6 +2370,15 @@ test_that("join(), crossJoin() and merge() on a DataFrame", { expect_true(any(grepl("BroadcastHashJoin", execution_plan_broadcast))) }) +test_that("test hint", { --- End diff -- The previous test with join broadcast hint is for test "join(), crossJoin() and merge() on a DataFrame". It seems to me that a simple sql hint test doesn't belong to that catalog. I guess it might be better to separate. What do you think?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org