Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21649#discussion_r198913230
--- Diff: R/pkg/R/DataFrame.R ---
@@ -3905,6 +3905,18 @@ setMethod("rollup",
groupedData(sgd)
})
+isTypeAllowed <- function(x) {
+ if (is.character(x)) {
+ TRUE
+ } else if (is.list(x)) {
--- End diff --
@felixcheung Thank you very much for your review! I don't think database
will use nested list for sql hints, but I can change the code to
```
isTypeAllowedForSqlHint <- function(x) {
if (is.character(x)) {
TRUE
} else if (is.list(x)) {
all(sapply(x, isTypeAllowedForSqlHint))
} else if (is.numeric(x)) {
TRUE
} else {
FALSE
}
}
```
Does this look good to you?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
