Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21649#discussion_r198722659 --- Diff: R/pkg/R/DataFrame.R --- @@ -3905,6 +3905,18 @@ setMethod("rollup", groupedData(sgd) }) +isTypeAllowed <- function(x) { + if (is.character(x)) { + TRUE + } else if (is.list(x)) { --- End diff -- how is `list` going to be used? for instance, do we need to recurse into to check the type of items in the list?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org