Hi Nicolas,
Thank you for finalizing the translation patch! I reviewed it
and found a couple more typos. So please fold the reviewers patch.
I am happy to set a positive review ...
Nicolas M. Thiery wrote:
On Wed, Jun 02, 2010 at 01:02:07PM +0200, Nicolas M. Thiery wrote:
I just (tentatively) finalized #8811, adding a couple notes about our
discussion, and fixing ReST issues here and there. Please review!
Please have a careful look at _test_reduced_word_of_translation. The
tests started to fail once translation_factors was fixed to *not*
return the same thing as c for affine type BC. So the code now use c
instead of translation_factors to get the smallest elements of the
weight lattice by which translations can be done, but am not 100% sure
this is correct.
... except for this issue. The translation factors give the smallest
translations in the alpha_i directions. In the _test_reduced_word_of_translation
you seem to be translating by c[i] * Lambda[i].
Cheers,
Anne
--
You received this message because you are subscribed to the Google Groups
"sage-combinat-devel" group.
To post to this group, send email to sage-combinat-de...@googlegroups.com.
To unsubscribe from this group, send email to
sage-combinat-devel+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sage-combinat-devel?hl=en.
