Alex, sorry, I didn't look through the whole patch carefully, and missed that matrix_gps/matrix_group.py and perm_gps/permgroup.py were actually patched...
Which Sage are you using? (in my case it is 4.3.1, on Debian Linux x86), and with gap-4.4.12, as well as with the original 4.3.1's gap-4.4.10, I get, sage: g=GL(2,3) sage: sorted([x.values() for x in g.irreducible_characters()]) [[1, 1, 1, 1, 1, 1, 1, 1], [1, 1, 1, 1, 1, -1, -1, -1], [2, -1, 2, -1, 2, 0, 0, 0], [2, 1, -2, -1, 0, -zeta8^3 - zeta8, zeta8^3 + zeta8, 0], [2, 1, -2, -1, 0, zeta8^3 + zeta8, -zeta8^3 - zeta8, 0], [3, 0, 3, 0, -1, 1, 1, -1], [3, 0, 3, 0, -1, -1, -1, 1], [4, -1, -4, 1, 0, 0, 0, 0]]) does not work as expected by your patch - this is perhaps due to zeta8 appearing there. Actually, my Sage does not know what zeta8 is: sage: zeta8 --------------------------------------------------------------------------- NameError Traceback (most recent call last) /usr/local/src/sage/sage-4.3.1/<ipython console> in <module>() NameError: name 'zeta8' is not defined any ideas? Dima On Jan 26, 6:58 pm, Alex Ghitza <aghi...@gmail.com> wrote: > On Tue, 26 Jan 2010 02:42:14 -0800 (PST), Dima Pasechnik <dimp...@gmail.com> > wrote: > > my objection is that in order for your patch not to break things, you > > also have to patch > > irreducible_characters() > > in > > matrix_gps/matrix_group.py > > and > > perm_gps/permgroup.py > > (and perhaps in other places I might have missed) > > And the patch at #8065 does precisely that. Before submitting the > patch, I have also checked to see if there were other relevant places > (answer: no), and if tests pass (answer: yes, on my machine). > > If you just fix the doctest without fixing the underlying problem in > irreducible_characters(), then as soon as someone adds more doctests > that just iterate through irreducible_characters(), we are again prone > to breakage at upgrades, etc. > > Best, > Alex > > -- > Alex Ghitza -- Lecturer in Mathematics -- The University of Melbourne > -- Australia --http://www.ms.unimelb.edu.au/~aghitza/ -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
