On Thu, Oct 27, 2011 at 3:25 PM, Robert Bradshaw <rober...@math.washington.edu> wrote: > On Tue, Oct 25, 2011 at 11:44 AM, William Stein <wst...@gmail.com> wrote: >> On Tue, Oct 25, 2011 at 11:06 AM, leif <not.rea...@online.de> wrote: >>> On 25 Okt., 12:04, Jeroen Demeyer <jdeme...@cage.ugent.be> wrote: >>>> On 2011-10-25 09:51, Dan Drake wrote: >>>> > I think that would be a good idea, although if you're just running that >>>> > through sed, the exact patches applied would be different from the ones >>>> > on the trac server, which would cause some confusion. >>>> >>>> Very true, but I think that is only a minor annoyance. >>> >>> I wouldn't say it's minor, since all developers basing their work on >>> these patches on trac still have the problem until a ticket gets >>> merged. >>> >>> So checking for added trailing whitespace in patches uploaded to trac >>> would IMHO be a task for the patchbot. >> >> Even better, it could be done by a trac pluging itself (at the moment >> when it matters most), not the patchbot, which may or may not run >> later. > > +1 > > Ideally, when you upload a patch it would do a bunch of checks and > present to you a "fixed" file with the option of downloading it or > replacing the original file right there.
An even better option would be a "submit patch to trac" command, which could take as set of patches from your queue, clean them up, optionally run a bunch of tests, and upload them (updating the description to the current set and any dependencies). - Robert -- To post to this group, send an email to sage-devel@googlegroups.com To unsubscribe from this group, send an email to sage-devel+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sage-devel URL: http://www.sagemath.org
