Re: Possible issue in reserveStoreInventory service
Thanks Giulio, Much appreciated. I will proceed soon with a minor enhancement on use of use-cache with filter-by-date. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Jul 4, 2021 at 9:05 PM Giulio Speri - MpStyle Srl < giulio.sp...@mpstyle.it> wrote: > Hi Suraj, > > I attached a patch for the service to the ticket. > I also did some considerations in the comment section and I would > appreciate it if you could share your thoughts on it. > > Thank you in advance, > Giulio > > Il giorno mer 23 giu 2021 alle ore 20:21 Giulio Speri - MpStyle Srl < > giulio.sp...@mpstyle.it> ha scritto: > > > Hi Suraj, > > > > ticket created: OFBIZ-12264. > > I'll soon start working on a patch. > > > > Regards, > > Giulio > > > > Il giorno mer 23 giu 2021 alle ore 09:20 Giulio Speri - MpStyle Srl < > > giulio.sp...@mpstyle.it> ha scritto: > > > >> HI Suraj, > >> > >> thanks. I will proceed with the Jira ticket. > >> > >> Giulio > >> > >> Il giorno mer 23 giu 2021 alle ore 06:24 Suraj Khurana < > >> suraj.khur...@hotwax.co> ha scritto: > >> > >>> Hello Giulio, > >>> > >>> Thanks for pointing that out. A Jira perfectly fits here. > >>> > >>> -- > >>> Best Regards, > >>> Suraj Khurana > >>> Senior Technical Consultant > >>> > >>> > >>> On Wed, Jun 23, 2021 at 5:32 AM Giulio Speri - MpStyle Srl < > >>> giulio.sp...@mpstyle.it> wrote: > >>> > >>> > Hello everyone, > >>> > > >>> > I hope you are all doing well. > >>> > I write because today I faced an unexpected behaviour in one of our > >>> > ecommerce applications, during creation of an order and related > >>> inventory > >>> > reservation. > >>> > > >>> > The ProductStore is set up to reserve inventory from more than one > >>> > facility, so the flag oneInventoryFacility is set to N. > >>> > The we have 8 different facilities configured (each with a specific > >>> > sequence num from 1 to 8) in the entity ProductStoreFacility. > >>> > > >>> > Due to customer requests I had to disable 6 out of 8 facilities > >>> associated > >>> > with the store, so basically only facilities with (sequence) numbers > 1 > >>> and > >>> > 2 are left. To achieve this I set the thruDate on the other six > >>> records. > >>> > > >>> > After that, an order came in with a variant product that had only 1 > >>> > quantity left available in one of the disabled facilities and 0 in > >>> both the > >>> > two facilities left enabled, but despite this the system reserved > >>> inventory > >>> > from the disabled facility: I wouldn't expect that. > >>> > > >>> > The service responsible for the reservation is *reserveStoreInventory > >>> *that > >>> > in our ofbiz version (13.07.03) is minilang and is implemented in > >>> > ProductStoreServices.xml: I checked that service and I noticed that > >>> when > >>> > the ProductStore is set to multi facility (oneInventoryFacility to N) > >>> and > >>> > the list of productStoreFacility records are retrieved, they are not > >>> > filtered by date, and this lead to a "bad" reservation. > >>> > I took a look also at the current revision of ofbiz and the code > >>> (groovy > >>> > script) is basically the same, so the issue is present there also. > >>> > > >>> > Is this a real issue/bug or this behaviour was intended to act this > >>> way? > >>> > > >>> > If this is an issue I can open a Jira Ticket, add more details and > >>> start > >>> > working on a patch for both versions. > >>> > > >>> > What do you think about it? > >>> > > >>> > Thank you in advance for your attention. > >>> > > >>> > Best regards, > >>> > Giulio > >>> > > >>> > > >>> > > >>> > > >>> > -- > >>> > Giulio Speri > >>> > > >>> > > >>> > *Mp Styl**e Srl* > >>> > via Antonio Meucci, 37 > >>> > 41019 Limidi di Soliera (MO) > >>> > T 059/684916 > >>> > M 334/3779851 > >>> > > >>> > www.mpstyle.it > >>> > > >>> > >> > >> > >> -- > >> Giulio Speri > >> > >> > >> *Mp Styl**e Srl* > >> via Antonio Meucci, 37 > >> 41019 Limidi di Soliera (MO) > >> T 059/684916 > >> M 334/3779851 > >> > >> www.mpstyle.it > >> > >> > >> > > > > -- > > Giulio Speri > > > > > > *Mp Styl**e Srl* > > via Antonio Meucci, 37 > > 41019 Limidi di Soliera (MO) > > T 059/684916 > > M 334/3779851 > > > > www.mpstyle.it > > > > > > > > -- > Giulio Speri > > > *Mp Styl**e Srl* > via Antonio Meucci, 37 > 41019 Limidi di Soliera (MO) > T 059/684916 > M 334/3779851 > > www.mpstyle.it >
Re: Possible issue in reserveStoreInventory service
Hello Giulio, Thanks for pointing that out. A Jira perfectly fits here. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jun 23, 2021 at 5:32 AM Giulio Speri - MpStyle Srl < giulio.sp...@mpstyle.it> wrote: > Hello everyone, > > I hope you are all doing well. > I write because today I faced an unexpected behaviour in one of our > ecommerce applications, during creation of an order and related inventory > reservation. > > The ProductStore is set up to reserve inventory from more than one > facility, so the flag oneInventoryFacility is set to N. > The we have 8 different facilities configured (each with a specific > sequence num from 1 to 8) in the entity ProductStoreFacility. > > Due to customer requests I had to disable 6 out of 8 facilities associated > with the store, so basically only facilities with (sequence) numbers 1 and > 2 are left. To achieve this I set the thruDate on the other six records. > > After that, an order came in with a variant product that had only 1 > quantity left available in one of the disabled facilities and 0 in both the > two facilities left enabled, but despite this the system reserved inventory > from the disabled facility: I wouldn't expect that. > > The service responsible for the reservation is *reserveStoreInventory *that > in our ofbiz version (13.07.03) is minilang and is implemented in > ProductStoreServices.xml: I checked that service and I noticed that when > the ProductStore is set to multi facility (oneInventoryFacility to N) and > the list of productStoreFacility records are retrieved, they are not > filtered by date, and this lead to a "bad" reservation. > I took a look also at the current revision of ofbiz and the code (groovy > script) is basically the same, so the issue is present there also. > > Is this a real issue/bug or this behaviour was intended to act this way? > > If this is an issue I can open a Jira Ticket, add more details and start > working on a patch for both versions. > > What do you think about it? > > Thank you in advance for your attention. > > Best regards, > Giulio > > > > > -- > Giulio Speri > > > *Mp Styl**e Srl* > via Antonio Meucci, 37 > 41019 Limidi di Soliera (MO) > T 059/684916 > M 334/3779851 > > www.mpstyle.it >
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Mar 19, 2021 at 1:43 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > +1 > > Jacopo > > On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato > wrote: > > > > This is the vote thread (second attempt) to release a new bug fix > > release for the > > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will > > supersede all the previous releases from the same branch. > > > > The release files can be downloaded from here: > > https://dist.apache.org/repos/dist/dev/ofbiz/ > > > > and are: > > * apache-ofbiz-17.12.06.zip > > * KEYS: text file with keys > > * apache-ofbiz-17.12.06.zip.asc: the detached signature file > > * apache-ofbiz-17.12.06.zip.sha512: checksum file > > > > Please download and test the zip file and its signatures (for > > instructions on testing the signatures see > > http://www.apache.org/info/verification.html). > > > > Vote: > > [ +1] release as Apache OFBiz 17.12.06 > > [ -1] do not release > > > > This vote will be open for 5 days. > > For more details about this process please read > > http://www.apache.org/foundation/voting.html >
Re: Welcome to Priya Sharma as new committer!
Congratulations Priya !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Mar 14, 2021 at 10:20 PM Swapnil Shah < swapnil.s...@hotwaxsystems.com> wrote: > Many Congratulations Priya !! > > Thanks, > Swapnil > > > -Original Message- > > From: Pawan Verma > > Sent: 11 March 2021 18:31 > > To: Dev list > > Subject: Welcome to Priya Sharma as new committer! > > > > The OFBiz PMC has invited Priya to become a new committer and we are > > pleased to announce that she has accepted the nomination. > > > > Welcome onboard Priya, more power to you! > > > > > > Pawan >
Re: Welcome to Martin Becker as new committer!
Many Congratulations, Martin !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Mar 3, 2021 at 2:00 PM Devanshu Vyas wrote: > Many Congratulations Martin! > > Thanks & Regards, > Devanshu Vyas. > > > On Wed, Mar 3, 2021 at 10:59 AM Pawan Verma wrote: > > > The OFBiz PMC has invited Martin to become a new committer and we are > > pleased to announce that he has accepted the nomination. > > > > Welcome onboard Martin! > > -- > > Thanks & Regards > > Pawan Verma > > ofbiz.apache.org > > >
Adding flexibility to condition-service in seca/eeca rules
Hello folks, Hope you are doing good. Recently we encountered a client's requirement which led us to have two separate condition-services with exact same code but opposite output. In one case true and false for another. We can enhance existing behaviour by having one more attribute in the seca/eeca rule. As currently by default, the result expected from condition-service is always true. We can provide its control to the developer. For eg. This boolean-field will illustrate the expected boolean result from the available conditionReply result field in the defined condition-service. In this manner we give more control to developers and reduce duplicacy of code. Please share your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: [OPTIONS] Java 11 and Java JDK origin
Hi, +1 for jdk11. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Feb 4, 2021 at 2:30 AM Eugen Stan wrote: > +1 for jdk11. > > We can focus on jdk17 once it's out. > The transition will probably require some work. > > jdk17 is attractive though in terms of language features and enhancements. > > We could use multiple JDK's to build OFBiz . > I can set this up in Jenkins or github actions with the community > consent / support. > > Well I kind of did it for jdk8 and jdk11 for both amd64 and arm64 with > docker images - > https://github.com/ieugen/ofbiz-framework/actions/runs/510286929 . > > But it's not official and would like to upstream it (hint hint). > > > Regards, > -- > Eugen Stan > +40720 898 747 / netdava.com >
Re: Welcome Girish Vasmatkar as new PMC member
Many Congratulations Girish !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Jan 29, 2021 at 11:28 AM Deepak Dixit wrote: > Welcome aboard Girish!! > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Thu, Jan 28, 2021 at 10:10 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has invited Girish Vasmatkar to become member of the > > committee and we are glad to announce he has accepted the nomination. > > > > On behalf of the OFBiz PMC, welcome Girish! > > > > >
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.05 - Second attempt
+1. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Jan 4, 2021 at 4:12 PM Deepak Dixit wrote: > +1 > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Mon, Jan 4, 2021 at 4:05 PM Nicola Mazzoni > wrote: > > > +1 > > > > Il giorno lun 4 gen 2021 alle ore 11:32 Jacopo Cappellato < > > jacopo.cappell...@gmail.com> ha scritto: > > > > > This is the vote thread (second attempt) to release a new bug fix > release > > > for the release17.12 branch. This new release, "Apache OFBiz 17.12.05" > > will > > > supersede all the previous releases from the same branch. > > > > > > Please consider that this may be the last release in the 17.12 series > and > > > in the future releases will be published from the newer series, which > is > > > 18.12. > > > > > > The release files can be downloaded from here: > > > > > > https://dist.apache.org/repos/dist/dev/ofbiz/ > > > > > > and are: > > > > > > * apache-ofbiz-17.12.05.zip > > > * KEYS: text file with keys > > > * apache-ofbiz-17.12.05.zip.asc: the detached signature file > > > * apache-ofbiz-17.12.05.zip.sha512: checksum file > > > > > > Please download and test the zip file and its signatures (for > > instructions > > > on testing the signatures see > > http://www.apache.org/info/verification.html > > > ). > > > > > > Please cast your vote: > > > > > > [ +1] release Apache OFBiz 17.12.05 > > > [ -1] do not release > > > > > > This vote will be open for 5 days. > > > > > > > > > -- > > Nicola Mazzoni > > > > > > *Mp Styl**e Srl* > > via Meucci, 37 > > 41019 Limidi di Soliera (MO) > > T 059/684916 > > M 347/9905529 > > > > www.mpstyle.it > > >
Re: Welcome to Daniel Watford as new committer!
Congrats Daniel. Welcome aboard !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Jan 3, 2021 at 2:30 AM Sharan F wrote: > Congratulations and welcome Daniel! > > Thanks > Sharan > > > On Thu, 31 Dec 2020, 17:20 Jacopo Cappellato, > > wrote: > > > The OFBiz PMC has invited Daniel to become a new committer and we are > > pleased to announce that he has accepted the nomination. > > > > Welcome onboard Daniel! > > > > Jacopo > > >
Re: Kickoff Meeting - Apache OFBiz Tutorial Project
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Dec 9, 2020 at 1:09 PM Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Hello Tutorial Project Volunteers, > > First of all thank you so much for showing interest in volunteering the > Apache OFBiz Tutorial Project. > > With this email I want to propose an online meeting to kickoff the project. > This meeting will help us in knowing each other. After this meeting we will > continue doing offline communication on email, OFBiz mailing list, Slack > Channel to make progress with our work. We can surely plan online meetings > in future as well as and when needed. This way the community will also be > updated all the time. > > It's a great opportunity for all of us to learn from each other and to also > prepare some robust content for OFBiz developers/users/evaluators. What > we'll generate will be a next level set of tutorials and guides for the > community and will be a proven asset for the project. > > How about meeting on this Friday 1:00 PM GMT? Does this day and time work > for all of you? Please confirm your availability and we'll go from there. > > Available: +1 > May be: 0 > Not Available: -1 > > Kind regards, > Pranay Pandey > https://ofbiz.apache.org/ >
Re: Checkstyle "Utility classes should not have a public or default constructor." error message
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Nov 12, 2020 at 12:03 AM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > Checkstyle returns 222 occurrences of the message "Utility classes should > not have a public or default constructor." > > This is due to > https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor > > I don't think we need to follow the "prevents calls from subclass" > suggestion there > > I rather suggest to comment out the related class in checkstyle.xml: > > ie > > If nobody is against, I'll do so in a week > > Then should remain only 280 errors and hopefully most will be easy to fix. > At least they will be easier to spot... > > Jacques > >
Re: OFBiz as OMS Session: Pre-Orders and its Management
Thanks for the update Devanshu. Looking forward to it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Oct 26, 2020 at 5:03 PM Devanshu Vyas wrote: > Hello, > > In continuation of our ongoing discussion on OFBiz as an open-source OMS, > we are organizing a series of videos sessions where we will discuss the > feasibility of it. > *Tomorrow, 27th October 2020 at 4 PM IST,* we will start a new topic in the > series, i.e. Pre-Orders and its management. > > Here is the link to the meeting: > > https://us04web.zoom.us/j/73082376558?pwd=ODRTbXU1RWZtbzkycnVhT2RISFZjZz09 > > > We hope to see you there. > > Thanks & Regards, > Devanshu Vyas. >
Re: Service or job which applies recurring fee to customer
Hi Madhu, Ideally you should try to make it consistent, meaning the same currency UOM to product(price) and billing account. There is currently not any job available OOTB, but yes can be incorporated as per customer requirement. For that, 'convertUom' service is already available which will be helpful. HTH. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Oct 21, 2020 at 11:35 AM Madhu Mohan wrote: > Is there any service or job which will run periodically and looks for uom, > applies the charge based on product(price) to billing account? > Please let me know. > Thanks in advance. > > >
UPDATE: OFBiz code linting issues
Hello team, Sometimes back, we introduced sonar and checkstyle linting tools integrated with OFBiz. We as a community are serious not only about features being introduced in OFBiz but also code quality being added in the repo. So we started correcting issues identified by the linting tool (checkstyle) and there were nearly ~*40,000* of those in the whole codebase. Slowly we keep on discussing it on different mail threads and move towards conclusions and fix those into the code base. We also incorporated a pre-push commit hook to ensure that no new issues are being introduced by committers. I am glad to announce that we have fixed around *99%* of these issues successfully. Kudos to everyone involved in this effort !! -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: Welcome Mridul Pathak as new PMC member!!
Many Congratulations Mridul !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Sep 21, 2020 at 11:26 AM Aditya Sharma wrote: > Felicitations Mridul! Welcome aboard. > > Thanks and Regards, > Aditya Sharma > > On Fri, Sep 18, 2020 at 12:55 PM Ashish Vijaywargiya > wrote: > > > The OFBiz PMC has invited Mridul Pathak to become a member of the > committee > > and we are glad to announce that he has accepted the nomination. > > > > On behalf of the OFBiz PMC, welcome on board Mridul! > > >
Re: Welcome Swapnil Shah as new PMC member!!
Many Congratulations Swapnil !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Sep 21, 2020 at 11:22 AM Aditya Sharma wrote: > Felicitations Swapnil! Welcome aboard. > > Thanks and Regards, > Aditya Sharma > > On Fri, Sep 18, 2020 at 12:56 PM Ashish Vijaywargiya > wrote: > > > The OFBiz PMC has invited Swapnil Shah to become a member of the > committee > > and we are glad to announce that he has accepted the nomination. > > > > On behalf of the OFBiz PMC, welcome on board Swapnil! > > >
Re: [ofbiz-framework] branch trunk updated: Improved: Updated tasks.checkstyleMain.maxErrors to 751. ~(-1250)
Hello Jacques, You were always there on this journey and supported it. Thanks a lot. :) -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Sep 4, 2020 at 3:22 PM Jacques Le Roux wrote: > Le 04/09/2020 à 09:01, sur...@apache.org a écrit : > > This is an automated email from the ASF dual-hosted git repository. > > > > surajk pushed a commit to branch trunk > > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git > > > > > > The following commit(s) were added to refs/heads/trunk by this push: > > new f180878 Improved: Updated tasks.checkstyleMain.maxErrors to > 751. ~(-1250) > > Even if not already 0 ;), this is a great achievement, thanks Suraj! > > Jacques > >
Re: buildbot failure in on ofbizTrunkFrameworkPlugins
Thanks Girish. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Sep 2, 2020 at 11:44 AM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Hi Jacques/Akash - > > I have taken care of it with my latest commit > - 310a2a58eff7cb203e4f7b25b78be23ea856aa79 > Checkstyle count stays @ 2007 > > Best, > Girish > > On Tue, Sep 1, 2020 at 10:20 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi Akash, > > > > Please either fix the checkstyle issue or increase to 2008 > > > > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins > > > > TIA > > > > Jacques > > > > Le 01/09/2020 à 13:41, build...@apache.org a écrit : > > > The Buildbot has detected a new failure on builder > > ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are > > available at: > > > > > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1733 > > > > > > Buildbot URL: https://ci.apache.org/ > > > > > > Buildslave for this Build: asf946_ubuntu > > > > > > Build Reason: The AnyBranchScheduler scheduler named > > 'onTrunkPluginsCommit' triggered this build > > > Build Source Stamp: [branch trunk] > > 6a7136ada4d38698a3497002e65cfc1980e4954c > > > Blamelist: Akash Jain ,Suraj Khurana < > > suraj.khur...@hotwax.co> > > > > > > BUILD FAILED: failed check > > > > > > Sincerely, > > > -The Buildbot > > > > > > > > > > > >
Re: JsLanguageFilesMappingCreator.java
Thanks Jacques for taking care of it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Aug 27, 2020 at 10:44 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Suraj, > > Pushed with slight changes > > Jacques > > Le 27/08/2020 à 13:37, Jacques Le Roux a écrit : > > Sure I'll, it's long ago but I still remember the difficulties ;) > > > > Jacques > > > > Le 27/08/2020 à 12:59, Suraj Khurana a écrit : > >> Thanks Jacques. > >> > >> I have attached a patch at > https://issues.apache.org/jira/browse/OFBIZ-11926 > >> Could you please review it? > >> > >> TIA. > >> > >> -- > >> Best Regards, > >> Suraj Khurana > >> Senior Technical Consultant > >> > >> > >> On Thu, Aug 27, 2020 at 3:38 PM Jacques Le Roux < > >> jacques.le.r...@les7arts.com> wrote: > >> > >>> James, > >>> > >>> Seems you are not concerned. Because with OFBIZ-11958 you created > >>> JsLanguageFilesMappingTransform.java. > >>> And it's not, and does not need to be, generated by > >>> JsLanguageFilesMappingCreator::createJsLanguageFileMapping > >>> > >>> If you agree you need to put an ASL2 header in it. > >>> And I'll revert > >>> > https://github.com/apache/ofbiz-framework/commit/707acc7d2744c32519aab67e78b8e0e293cb01d6/ > >>> > >>> TIA > >>> > >>> Jacques > >>> > >>> Le 27/08/2020 à 11:54, Jacques Le Roux a écrit : > >>>> Hi James, Suraj, > >>>> > >>>> As it's documented inside > >>> JsLanguageFilesMappingCreator::createJsLanguageFileMapping is used by > the > >>> createJsLanguageFileMapping service to "create > >>>> or update JsLanguageFilesMapping.java and JsLanguageFilesMapping.ftl > >>> files." > >>>> This happens when we update the languages used by some JavaScript > >>> plugins, notably those: > >>>> "/common/common-theme/webapp/js/jquery/ui/i18n/" > >>>> "/common/common-theme/webapp/js/jquery/plugins/datejs/" > >>>> "/common/common-theme/webapp/js/jquery/plugins/validate/localization/" > >>>> "/common/common-theme/webapp/js/jquery/plugins/datetimepicker/i18n/" > >>>> "/common/common-theme/webapp/js/jquery/plugins/select2/js/i18n/" > >>>> > >>>> We then must manually run the createJsLanguageFileMapping service. > >>>> > >>>> So we should not modify JsLanguageFilesMapping.java and > >>> JsLanguageFilesMapping.ftl but modify > >>>> JsLanguageFilesMappingCreator::createJsLanguageFileMapping in order to > >>> correctly generate them. > >>>> You both have recently modified JsLanguageFilesMapping.java or/and > >>> JsLanguageFilesMapping.ftl. > >>>> Please review your changes in order to incorporate them into > >>> JsLanguageFilesMappingCreator::createJsLanguageFileMapping > >>>> TIA > >>>> > >>>> Jacques > >>>> >
Re: JsLanguageFilesMappingCreator.java
Thanks Jacques. I have attached a patch at https://issues.apache.org/jira/browse/OFBIZ-11926 Could you please review it? TIA. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Aug 27, 2020 at 3:38 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > James, > > Seems you are not concerned. Because with OFBIZ-11958 you created > JsLanguageFilesMappingTransform.java. > And it's not, and does not need to be, generated by > JsLanguageFilesMappingCreator::createJsLanguageFileMapping > > If you agree you need to put an ASL2 header in it. > And I'll revert > https://github.com/apache/ofbiz-framework/commit/707acc7d2744c32519aab67e78b8e0e293cb01d6/ > > TIA > > Jacques > > Le 27/08/2020 à 11:54, Jacques Le Roux a écrit : > > Hi James, Suraj, > > > > As it's documented inside > JsLanguageFilesMappingCreator::createJsLanguageFileMapping is used by the > createJsLanguageFileMapping service to "create > > or update JsLanguageFilesMapping.java and JsLanguageFilesMapping.ftl > files." > > > > This happens when we update the languages used by some JavaScript > plugins, notably those: > > > > "/common/common-theme/webapp/js/jquery/ui/i18n/" > > "/common/common-theme/webapp/js/jquery/plugins/datejs/" > > "/common/common-theme/webapp/js/jquery/plugins/validate/localization/" > > "/common/common-theme/webapp/js/jquery/plugins/datetimepicker/i18n/" > > "/common/common-theme/webapp/js/jquery/plugins/select2/js/i18n/" > > > > We then must manually run the createJsLanguageFileMapping service. > > > > So we should not modify JsLanguageFilesMapping.java and > JsLanguageFilesMapping.ftl but modify > > JsLanguageFilesMappingCreator::createJsLanguageFileMapping in order to > correctly generate them. > > > > You both have recently modified JsLanguageFilesMapping.java or/and > JsLanguageFilesMapping.ftl. > > Please review your changes in order to incorporate them into > JsLanguageFilesMappingCreator::createJsLanguageFileMapping > > > > TIA > > > > Jacques > > >
Re: Welcome to Devanshu Vyas as new committer!
Many Congratulations Devanshu !! -- Best Regards, Suraj Khurana Senior Technical Consultant HotWax Commerce On Wed, Aug 19, 2020 at 2:32 PM Pawan Verma wrote: > The OFBiz PMC has invited Devanshu Vyas to become a new committer and we > are happy to announce that he has accepted this role. > > Some of the reasons for inviting Devanshu Vyas include: > > - He is invested in the OFBiz project and has been a member for many years > - He is taking an initiative towards improving the system > - He has functional experience in various areas of the framework > - He enjoys working with the community and collaborating with others > > Please join me in welcoming and congratulating Devanshu! > > Cheers > Pawan Verma > ofbiz.apache.org >
Re: buildbot exception in on ofbizTrunkFrameworkPlugins
All good on the local machine. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Aug 3, 2020 at 10:15 AM wrote: > The Buildbot has detected a build exception on builder > ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are > available at: > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1581 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: asf945_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkPluginsCommit' triggered this build > Build Source Stamp: [branch trunk] b65d9c94df18ab57357111ee6365287f40fd1282 > Blamelist: Suraj Khurana > > BUILD FAILED: exception build upload test-results part 1 > > Sincerely, > -The Buildbot > > > >
Re: ParameterNumber checkstyle rule
Thanks Jacques. 10 looks good to me as well. I have created a Jira and uploaded patch for this: https://issues.apache.org/jira/browse/OFBIZ-11931 -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Jul 30, 2020 at 2:10 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > 10? > > Le 29/07/2020 à 17:53, Suraj Khurana a écrit : > > Hello team, > > > > Currently there are around 175 issues due parameter count in java methods > > > > Its default value is 7 [1], we should decide this configuration for > > checkstyle. In current code, there are some methods having around 20 > > parameters (addOrIncreaseItem). > > > > [1]: > > > https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheck.html > > > > Please share your thoughts on this. > > > > -- > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > >
Re: MethodLength checkstyle rule
Thanks Jacques, I think we can go with 500, I have uploaded the patch on the ticket (OFBIZ-11915). -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Jul 30, 2020 at 2:06 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Suraj, > > Has I had no ideas about the best length, I was to suggest to add the 2 > number (150+945) and to divide the total by 2. > > This gives us around 550, I'd have suggested 500, but 450 is fine with me. > > Thanks > > Jacques > > Le 29/07/2020 à 19:47, Suraj Khurana a écrit : > > Hello team, > > > > Any thoughts on this, IMO we can make it to 450 or something, it's quite > > readable by then. > > Please suggest. > > > > -- > > > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > > > > > On Sun, Jul 26, 2020 at 9:12 PM Suraj Khurana > > wrote: > > > >> Hello team, > >> > >> Currently there are around 200 issues due method length. > >> > >> Its default value is 150, we need to decide this configuration. In > current > >> code, maximum method length I noticed is of 945 lines > >> (createOrder#OrderServices.java) > >> > >> I have created OFBIZ-11915 for this, we can continue this effort as per > >> conclusions drawn in this thread. > >> > >> Please share your thoughts on this. > >> -- > >> Best Regards, > >> Suraj Khurana > >> SENIOR TECHNICAL CONSULTANT > >> mobile: +91 9669750002 > >> email: suraj.khur...@hotwax.co > >> *www.hotwax.co <http://www.hotwax.co/>* > >> >
Re: MethodLength checkstyle rule
Hello team, Any thoughts on this, IMO we can make it to 450 or something, it's quite readable by then. Please suggest. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Jul 26, 2020 at 9:12 PM Suraj Khurana wrote: > Hello team, > > Currently there are around 200 issues due method length. > > Its default value is 150, we need to decide this configuration. In current > code, maximum method length I noticed is of 945 lines > (createOrder#OrderServices.java) > > I have created OFBIZ-11915 for this, we can continue this effort as per > conclusions drawn in this thread. > > Please share your thoughts on this. > -- > Best Regards, > Suraj Khurana > SENIOR TECHNICAL CONSULTANT > mobile: +91 9669750002 > email: suraj.khur...@hotwax.co > *www.hotwax.co <http://www.hotwax.co/>* >
ParameterNumber checkstyle rule
Hello team, Currently there are around 175 issues due parameter count in java methods Its default value is 7 [1], we should decide this configuration for checkstyle. In current code, there are some methods having around 20 parameters (addOrIncreaseItem). [1]: https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheck.html Please share your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: Single line statements - checkstyle
Thanks everyone. This was done a few days ago. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 18, 2020 at 1:56 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 14/07/2020 à 10:15, Jacques Le Roux a écrit : > > My conclusion is that could be discussed again and I for one I'm not > against changing this rule for 2 reasons: > > > > 1. We can't use our current formatter to do it right > > 2. With a single line statement there are less chances to confuse > and fall in the error-prone form mentioned above > > > > Another option would be to find a way to improve our formatter to do the > right thing (ie add braces when splitting). > > We discussed the point 1 with Suraj in Slack. It's actually possible in > both IntelliJ > > > https://www.jetbrains.com/help/resharper/Braces_for_Single_Line_Statements.html > > https://stackoverflow.com/questions/55248370/intellij-checkstyle-plugin-reformat > > and Eclipse > > > https://stackoverflow.com/questions/3704308/how-to-make-eclipse-automatically-add-braces-to-an-if-statement > > I don't know for IntelliJ, but in Eclipse it's not a formatting option but > a clean-up option. > And when you clean-up you can't select a block of code, it's all the file > or nothing. > There are then more changes and some are unwanted. > > So I agree with Suraj and Pritam, let's do that. There would be anyway so > much changes to do by hand that it's not rational! > > Jacques > >
Re: Welcome Pawan Verma as new PMC member
Many congratulations, Pawan ! -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Pawan Verma to become member of the committee > and we are glad to announce that he has accepted the nomination. > > On behalf of the OFBiz PMC, welcome on board Pawan! > >
MethodLength checkstyle rule
Hello team, Currently there are around 200 issues due method length. Its default value is 150, we need to decide this configuration. In current code, maximum method length I noticed is of 945 lines (createOrder#OrderServices.java) I have created OFBIZ-11915 for this, we can continue this effort as per conclusions drawn in this thread. Please share your thoughts on this. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>*
Re: buildbot exception in on ofbizTrunkFrameworkPlugins
Hey Jacques, I have attached a patch for this existing issue on OFBIZ-11553, it works for me. Please check and go ahead if it looks good to you as well. HTH. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 25, 2020 at 7:59 PM Suraj Khurana wrote: > On my local, I am facing same one test failure > (testCreateOrderServiceProduct) and as you mentioned in OFBIZ-11553, it > is working fine with ofbiz -test component=order --test > suitename=shoppingcarttests --test case=configurableServiceOrder-test. > > -- > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Sat, Jul 25, 2020 at 7:40 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Ha no, we get the same 3 new errors than I locally: >> >> I reverted push from OFBIZ-11487 before it becomes confusing... >> >> Thanks to Pawan's comment in OFBIZ-11553 I'm considering to look again at >> the remaining failure. Things get confusing when errors/failures mix... >> >> Jacques >> >> Le 25/07/2020 à 14:41, Suraj Khurana a écrit : >> > Thanks Jacques for confirming. >> > >> > -- >> > Best Regards, >> > Suraj Khurana >> > Senior Technical Consultant >> > >> > >> > On Sat, Jul 25, 2020 at 5:40 PM Jacques Le Roux < >> > jacques.le.r...@les7arts.com> wrote: >> > >> >> Hi Suraj, >> >> >> >> It's only about (not) uploading the result file. I tested locally, we >> have >> >> still the pending failure error from OFBIZ-11553. >> >> I got 3 others errors I believe are only Windows related (slow files >> >> handling there) >> >> >> >> So it's OK, we will see with my next push... >> >> >> >> Jacques >> >> >> >> Le 25/07/2020 à 12:26, Suraj Khurana a écrit : >> >>> Hello team, >> >>> >> >>> Everything looks ok on the local machine with testIntegration. >> >>> I checked with "./gradlew cleanAll loadAll testIntegration". >> >>> >> >>> -- >> >>> Best Regards, >> >>> Suraj Khurana >> >>> Senior Technical Consultant >> >>> >> >>> >> >>> On Sat, Jul 25, 2020 at 2:06 PM wrote: >> >>> >> >>>> The Buildbot has detected a build exception on builder >> >>>> ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details >> >> are >> >>>> available at: >> >>>> >> >> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1567 >> >>>> Buildbot URL: https://ci.apache.org/ >> >>>> >> >>>> Buildslave for this Build: asf945_ubuntu >> >>>> >> >>>> Build Reason: The AnyBranchScheduler scheduler named >> >>>> 'onTrunkPluginsCommit' triggered this build >> >>>> Build Source Stamp: [branch trunk] >> >> 4b88493e1bfd1a0e33bc1a1568ed1e1ba34a254a >> >>>> Blamelist: Suraj Khurana >> >>>> >> >>>> BUILD FAILED: exception javadoc upload test-results part 1 >> >>>> >> >>>> Sincerely, >> >>>>-The Buildbot >> >>>> >> >>>> >> >>>> >> >>>> >> >
Re: buildbot exception in on ofbizTrunkFrameworkPlugins
On my local, I am facing same one test failure (testCreateOrderServiceProduct) and as you mentioned in OFBIZ-11553, it is working fine with ofbiz -test component=order --test suitename=shoppingcarttests --test case=configurableServiceOrder-test. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 25, 2020 at 7:40 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Ha no, we get the same 3 new errors than I locally: > > I reverted push from OFBIZ-11487 before it becomes confusing... > > Thanks to Pawan's comment in OFBIZ-11553 I'm considering to look again at > the remaining failure. Things get confusing when errors/failures mix... > > Jacques > > Le 25/07/2020 à 14:41, Suraj Khurana a écrit : > > Thanks Jacques for confirming. > > > > -- > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > > > > > On Sat, Jul 25, 2020 at 5:40 PM Jacques Le Roux < > > jacques.le.r...@les7arts.com> wrote: > > > >> Hi Suraj, > >> > >> It's only about (not) uploading the result file. I tested locally, we > have > >> still the pending failure error from OFBIZ-11553. > >> I got 3 others errors I believe are only Windows related (slow files > >> handling there) > >> > >> So it's OK, we will see with my next push... > >> > >> Jacques > >> > >> Le 25/07/2020 à 12:26, Suraj Khurana a écrit : > >>> Hello team, > >>> > >>> Everything looks ok on the local machine with testIntegration. > >>> I checked with "./gradlew cleanAll loadAll testIntegration". > >>> > >>> -- > >>> Best Regards, > >>> Suraj Khurana > >>> Senior Technical Consultant > >>> > >>> > >>> On Sat, Jul 25, 2020 at 2:06 PM wrote: > >>> > >>>> The Buildbot has detected a build exception on builder > >>>> ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details > >> are > >>>> available at: > >>>> > >> https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1567 > >>>> Buildbot URL: https://ci.apache.org/ > >>>> > >>>> Buildslave for this Build: asf945_ubuntu > >>>> > >>>> Build Reason: The AnyBranchScheduler scheduler named > >>>> 'onTrunkPluginsCommit' triggered this build > >>>> Build Source Stamp: [branch trunk] > >> 4b88493e1bfd1a0e33bc1a1568ed1e1ba34a254a > >>>> Blamelist: Suraj Khurana > >>>> > >>>> BUILD FAILED: exception javadoc upload test-results part 1 > >>>> > >>>> Sincerely, > >>>>-The Buildbot > >>>> > >>>> > >>>> > >>>> >
Re: buildbot exception in on ofbizTrunkFrameworkPlugins
Thanks Jacques for confirming. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 25, 2020 at 5:40 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Suraj, > > It's only about (not) uploading the result file. I tested locally, we have > still the pending failure error from OFBIZ-11553. > I got 3 others errors I believe are only Windows related (slow files > handling there) > > So it's OK, we will see with my next push... > > Jacques > > Le 25/07/2020 à 12:26, Suraj Khurana a écrit : > > Hello team, > > > > Everything looks ok on the local machine with testIntegration. > > I checked with "./gradlew cleanAll loadAll testIntegration". > > > > -- > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > > > > > On Sat, Jul 25, 2020 at 2:06 PM wrote: > > > >> The Buildbot has detected a build exception on builder > >> ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details > are > >> available at: > >> > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1567 > >> > >> Buildbot URL: https://ci.apache.org/ > >> > >> Buildslave for this Build: asf945_ubuntu > >> > >> Build Reason: The AnyBranchScheduler scheduler named > >> 'onTrunkPluginsCommit' triggered this build > >> Build Source Stamp: [branch trunk] > 4b88493e1bfd1a0e33bc1a1568ed1e1ba34a254a > >> Blamelist: Suraj Khurana > >> > >> BUILD FAILED: exception javadoc upload test-results part 1 > >> > >> Sincerely, > >> -The Buildbot > >> > >> > >> > >> >
Re: buildbot exception in on ofbizTrunkFrameworkPlugins
Hello team, Everything looks ok on the local machine with testIntegration. I checked with "./gradlew cleanAll loadAll testIntegration". -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 25, 2020 at 2:06 PM wrote: > The Buildbot has detected a build exception on builder > ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are > available at: > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1567 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: asf945_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkPluginsCommit' triggered this build > Build Source Stamp: [branch trunk] 4b88493e1bfd1a0e33bc1a1568ed1e1ba34a254a > Blamelist: Suraj Khurana > > BUILD FAILED: exception javadoc upload test-results part 1 > > Sincerely, > -The Buildbot > > > >
Re: Checkstyle line wrapping Indentation
Yes, no changes required. Thanks !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jul 22, 2020 at 8:14 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > It works as expected in 4.2 when using our formatter in Eclipse. > Since the checkstyle was based on the formatter, that should not be changed > > Jacques > > Le 22/07/2020 à 14:16, Jacques Le Roux a écrit : > > I had a doubt too, this is always confusing. > > > > I'll test formatting in Eclipse... > > > > Jacques > > > > Le 22/07/2020 à 12:56, Suraj Khurana a écrit : > >> Hello team, > >> > >> I further checked oracle docs [1] and maybe this is the reason for this. > >> See 4.2 in this pdf. > >> > >> [1]: https://www.oracle.com/technetwork/java/codeconventions-150003.pdf > >> > >> -- > >> Best Regards, > >> Suraj Khurana > >> Senior Technical Consultant > >> > >> > >> On Tue, Jul 21, 2020 at 10:52 PM Jacques Le Roux < > >> jacques.le.r...@les7arts.com> wrote: > >> > >>> +1 reading the link > >>> > >>> Thanks Suraj! > >>> > >>> Le 21/07/2020 à 14:21, Pritam Kute a écrit : > >>>> Good catch Suraj. +1 for having it as 4 instead of 8. > >>>> > >>>> Kind Regards, > >>>> -- > >>>> Pritam Kute > >>>> > >>>> > >>>> On Tue, Jul 21, 2020 at 5:26 PM Suraj Khurana < > suraj.khur...@hotwax.co> > >>>> wrote: > >>>> > >>>>> Hello folks, > >>>>> > >>>>> In checkstyle.xml, we have set lineWrappingIndentation value to 8. I > >>>>> Propose we should make it 4 instead which is default. [1] > >>>>> > >>>>> Is there any specific reason for setting it to 8? Please advise. > >>>>> > >>>>> [1]: > >>>>> > >>>>> > >>> > https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.html > >>>>> -- > >>>>> Best Regards, > >>>>> Suraj Khurana > >>>>> Senior Technical Consultant > >>>>> >
Re: Checkstyle line wrapping Indentation
Hello team, I further checked oracle docs [1] and maybe this is the reason for this. See 4.2 in this pdf. [1]: https://www.oracle.com/technetwork/java/codeconventions-150003.pdf -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jul 21, 2020 at 10:52 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 reading the link > > Thanks Suraj! > > Le 21/07/2020 à 14:21, Pritam Kute a écrit : > > Good catch Suraj. +1 for having it as 4 instead of 8. > > > > Kind Regards, > > -- > > Pritam Kute > > > > > > On Tue, Jul 21, 2020 at 5:26 PM Suraj Khurana > > wrote: > > > >> Hello folks, > >> > >> In checkstyle.xml, we have set lineWrappingIndentation value to 8. I > >> Propose we should make it 4 instead which is default. [1] > >> > >> Is there any specific reason for setting it to 8? Please advise. > >> > >> [1]: > >> > >> > https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.html > >> > >> -- > >> Best Regards, > >> Suraj Khurana > >> Senior Technical Consultant > >> >
Checkstyle line wrapping Indentation
Hello folks, In checkstyle.xml, we have set lineWrappingIndentation value to 8. I Propose we should make it 4 instead which is default. [1] Is there any specific reason for setting it to 8? Please advise. [1]: https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.html -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: Ordering Decimals
Hi, +1 to have some products in demo data with decimal quantity configuration. Also, if we agree for product store level configuration, it should be entertaining in a similar manner as we have done for requireInventory (Check service isStoreInventoryRequiredInline). Means, giving priority to product level configuration and then store level. HTH. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jul 21, 2020 at 11:44 AM Pritam Kute wrote: > I think its a good idea to have orderDecimalQuantity set to N for the > products in demo data. What I have noticed in demo data is there is no > practical product data available for which we can set this flag to Y. IMO, > we can add one or two demo products that can be ordered in > decimal quantities. > > For the product store level flag, we can modify the field description in > entity definition to convey the message to the user to set the flag to Y > for a global setting. If it is set to Y then the user may not need to set > the flag at each product level. > > Kind Regards, > -- > Pritam Kute > > > On Mon, Jul 20, 2020 at 10:48 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Hi, > > > > In OFBiz, OOTB you can order decimals of products. For instance you may > > want to sell half pizza. That is an user decision. The user may want to > > allow > > decimals by store or by product as shown in > > > > > > > https://github.com/apache/ofbiz-framework/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/product/product/ProductWorker.java#L1204 > > > > We though should not be able to order a part of finished product like > > "Tiny Chrome Widget" (try 3.5 as mini is 3). You may notice that we have > an > > issue in trunk and R18: see OFBIZ-11899. It works in stable demo and R17 > > locally. > > > > We should set orderDecimalQuantity to false for all products data of > > FINISHED_GOOD, SERVICE, AGGREGATED, MARKETING_PKG_AUTO, DIGITAL_GOOD, > > ASSET_USAGE, etc. as can be seen in ProductSeedData.xml. Anyway it should > > be set on a product basis. > > > > I think it's worth to do. Because it's demo data and would show to > > correctly set things. For a store which sells only not splittable > products > > (which I > > guess is most of the time when using OFBiz ecommerce) then it's possible > > to set the same at the store level. > > > > What do you think? > > > > Jacques > > > > >
Re: Welcome Suraj Khurana as new PMC member
Thanks everyone for your wishes. It's always a pleasure and delightful experience to become a part of OFBiz community. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Jul 12, 2020 at 4:18 PM Sharan Foga wrote: > Congratulations Suraj! > > Thanks > Sharan > > On 2020/07/04 11:52:15, Jacques Le Roux > wrote: > > The OFBiz PMC has invited Suraj Khurana to become member of the > committee and we are glad to announce that he has accepted the nomination. > > > > On behalf of the OFBiz PMC, welcome on board Suraj! > > > > >
Re: [ofbiz-site] branch master updated: Fixed: OFBiz API Reference link does not work for Documentation/API Reference section(OFBIZ-11888)
Ahh !! it is due to that php2html.sh thing. Thanks !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Jul 17, 2020 at 3:34 PM Pawan Verma wrote: > Hi Suraj, > > We can't use your suggested solution in ofbiz-site as it has its working > pattern. Please refer README.md for more details. > -- > Thanks & Regards > Pawan Verma > Technical Consultant > *HotWax Systems* > *Enterprise open source experts* > http://www.hotwaxsystems.com > > > On Fri, Jul 17, 2020 at 2:49 PM Suraj Khurana > wrote: > > > Hi Pawan, > > > > IMO, instead of copying this to every file, we should create a new file > > apiReference.html or something similar so that changes are easy to manage > > in future. > > Infact if footer contents are the same, we should be creating a > > footer.html. > > WDYT? > > > > -- > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > > > > > On Fri, Jul 17, 2020 at 2:16 PM wrote: > > > > > This is an automated email from the ASF dual-hosted git repository. > > > > > > pawan pushed a commit to branch master > > > in repository https://gitbox.apache.org/repos/asf/ofbiz-site.git > > > > > > > > > The following commit(s) were added to refs/heads/master by this push: > > > new 7d999ef Fixed: OFBiz API Reference link does not work for > > > Documentation/API Reference section(OFBIZ-11888) > > > new 901b5cc Merge branch 'master' of > > > https://gitbox.apache.org/repos/asf/ofbiz-site > > > 7d999ef <https://gitbox.apache.org/repos/asf/ofbiz-site7d999ef> is > > > described below > > > > > > commit 7d999ef755dc84aa6adc6fc9ddd87708a962bdea > > > Author: Pawan Verma > > > AuthorDate: Fri Jul 17 14:15:58 2020 +0530 > > > > > > Fixed: OFBiz API Reference link does not work for Documentation/API > > > Reference section(OFBIZ-11888) > > > > > > Added new Trunk, Next and Stable API Documentation section. > > > > > > Thanks, Jacques, Pritam, Devanshu, Olivier for the review. > > > --- > > > 404.html | 14 +- > > > about-ofbiz.html | 14 +- > > > business-users.html| 14 +- > > > developers.html| 14 +- > > > download.html | 14 +- > > > faqs.html | 14 +- > > > getting-involved.html | 14 +- > > > index.html | 14 +- > > > mailing-lists.html | 14 +- > > > ofbiz-demos.html | 14 +- > > > release-notes-12.04.06.html| 14 +- > > > release-notes-13.07.01.html| 14 +- > > > release-notes-13.07.02.html| 14 +- > > > release-notes-13.07.03.html| 14 +- > > > release-notes-16.11.01.html| 14 +- > > > release-notes-16.11.02.html| 14 +- > > > release-notes-16.11.03.html| 14 +- > > > release-notes-16.11.04.html| 14 +- > > > release-notes-16.11.05.html| 14 +- > > > release-notes-16.11.06.html| 14 +- > > > release-notes-16.11.07.html| 14 +- > > > release-notes-17.12.01.html| 14 +- > > > release-notes-17.12.03.html| 14 +- > > > release-notes-17.12.04.html| 14 +- > > > security.html | 14 +- > > > service-providers.html | 14 +- > > > source-repositories.html | 14 +- > > > template/region/header.tpl.php | 14 +- > > > user-stories.html | 14 +- > > > 29 files changed, 377 insertions(+), 29 deletions(-) > > > > > > diff --git a/404.html b/404.html > > > index b83e089..bf3a06a 100644 > > > --- a/404.html > > > +++ b/404.html > > > @@ -65,7 +65,19 @@ > > > > > target="external" class="">User Documentation > > > > > target="external" class="">Technical Documentation > > > > > class="">Wiki > > > - > > class="last">API Reference > > > +
Re: [ofbiz-site] branch master updated: Fixed: OFBiz API Reference link does not work for Documentation/API Reference section(OFBIZ-11888)
Hi Pawan, IMO, instead of copying this to every file, we should create a new file apiReference.html or something similar so that changes are easy to manage in future. Infact if footer contents are the same, we should be creating a footer.html. WDYT? -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Jul 17, 2020 at 2:16 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > pawan pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/ofbiz-site.git > > > The following commit(s) were added to refs/heads/master by this push: > new 7d999ef Fixed: OFBiz API Reference link does not work for > Documentation/API Reference section(OFBIZ-11888) > new 901b5cc Merge branch 'master' of > https://gitbox.apache.org/repos/asf/ofbiz-site > 7d999ef <https://gitbox.apache.org/repos/asf/ofbiz-site7d999ef> is > described below > > commit 7d999ef755dc84aa6adc6fc9ddd87708a962bdea > Author: Pawan Verma > AuthorDate: Fri Jul 17 14:15:58 2020 +0530 > > Fixed: OFBiz API Reference link does not work for Documentation/API > Reference section(OFBIZ-11888) > > Added new Trunk, Next and Stable API Documentation section. > > Thanks, Jacques, Pritam, Devanshu, Olivier for the review. > --- > 404.html | 14 +- > about-ofbiz.html | 14 +- > business-users.html| 14 +- > developers.html| 14 +- > download.html | 14 +- > faqs.html | 14 +- > getting-involved.html | 14 +- > index.html | 14 +- > mailing-lists.html | 14 +- > ofbiz-demos.html | 14 +- > release-notes-12.04.06.html| 14 +- > release-notes-13.07.01.html| 14 +- > release-notes-13.07.02.html| 14 +- > release-notes-13.07.03.html| 14 +- > release-notes-16.11.01.html| 14 +- > release-notes-16.11.02.html| 14 +- > release-notes-16.11.03.html| 14 +- > release-notes-16.11.04.html| 14 +- > release-notes-16.11.05.html| 14 +- > release-notes-16.11.06.html| 14 +- > release-notes-16.11.07.html| 14 +- > release-notes-17.12.01.html| 14 +- > release-notes-17.12.03.html| 14 +- > release-notes-17.12.04.html| 14 +- > security.html | 14 +- > service-providers.html | 14 +- > source-repositories.html | 14 +- > template/region/header.tpl.php | 14 +- > user-stories.html | 14 +- > 29 files changed, 377 insertions(+), 29 deletions(-) > > diff --git a/404.html b/404.html > index b83e089..bf3a06a 100644 > --- a/404.html > +++ b/404.html > @@ -65,7 +65,19 @@ > target="external" class="">User Documentation > target="external" class="">Technical Documentation > class="">Wiki > - class="last">API Reference > +API Reference > + > + > + target="external">Trunk API > + > + > + target="external">Release 17.12 API > + > + > + Next > Release API > + > + > + > > > Community > diff --git a/about-ofbiz.html b/about-ofbiz.html > index d487007..aaafea4 100644 > --- a/about-ofbiz.html > +++ b/about-ofbiz.html > @@ -65,7 +65,19 @@ > target="external" class="">User Documentation > target="external" class="">Technical Documentation > class="">Wiki > - class="last">API Reference > +API Reference > + > + > + target="external">Trunk API > + > + > + target="external">Release 17.12 API > + > + > + Next > Release API > +
Single line statements - checkstyle
Hello team, I have created a ticket https://issues.apache.org/jira/browse/OFBIZ-11886 to allow single line statements during checkstyle, I hope we are fine with this. For this, we need to add a module to allow single line statements: == == Let me know your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: [ofbiz-framework] 01/02: Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)
Hello Pawan,
Yes, I was trying a few IDE options that might have added this.
Thanks for bringing this to my attention.
Removed at rev#c5f9697e35e676cf5afa6e14dc3f420030961924
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Tue, Jul 7, 2020 at 4:24 PM Pawan Verma
wrote:
> Hi Suraj,
>
> Is it intentional to use SuppressWarnings("checkstyle:LineLength")?
> --
> Thanks & Regards
> Pawan Verma
> Technical Consultant
> *HotWax Systems*
> *Enterprise open source experts*
> http://www.hotwaxsystems.com
>
>
> On Tue, Jul 7, 2020 at 3:13 PM wrote:
>
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > surajk pushed a commit to branch trunk
> > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
> >
> > commit fc6b8a6ca301c074dedffd45543e68aeb437065a
> > Author: Suraj Khurana
> > AuthorDate: Tue Jul 7 15:08:17 2020 +0530
> >
> > Improved: Corrected remaining ', is not followed by whitespace'
> > checkstyle errors in framework component.
> > (OFBIZ-11805)
> > ---
> > .../java/org/apache/ofbiz/base/util/UtilMisc.java | 2 +-
> > .../container/CrossSubdomainSessionValve.java | 2 +-
> > .../java/org/apache/ofbiz/common/FindServices.java | 4 +-
> > .../apache/ofbiz/common/image/ImageTransform.java | 2 +-
> > .../apache/ofbiz/common/login/LoginServices.java | 82
> > +++---
> > .../org/apache/ofbiz/entity/model/ModelEntity.java | 2 +-
> > .../ofbiz/entity/model/ModelEntityChecker.java | 2 +-
> > .../org/apache/ofbiz/entity/model/ModelReader.java | 2 +-
> > .../apache/ofbiz/entity/model/ModelViewEntity.java | 2 +-
> > .../org/apache/ofbiz/entity/util/EntityUtil.java | 6 +-
> > .../java/org/apache/ofbiz/security/Security.java | 2 +-
> > .../ofbiz/webapp/control/RequestHandler.java | 2 +-
> > .../webtools/artifactinfo/ServiceArtifactInfo.java | 4 +-
> > 13 files changed, 56 insertions(+), 58 deletions(-)
> >
> > diff --git
> > a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilMisc.java
> > b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilMisc.java
> > index 3588be4..f0934c3 100644
> > ---
> a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilMisc.java
> > +++
> b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilMisc.java
> > @@ -605,7 +605,7 @@ public final class UtilMisc {
> > }
> >
> > /** List of domains or IP addresses to be checked to prevent Host
> > Header Injection,
> > - * no spaces after commas,no wildcard, can be extended of course...
> > + * no spaces after commas, no wildcard, can be extended of course...
> > * @return List of domains or IP addresses to be checked to prevent
> > Host Header Injection,
> > */
> > public static List getHostHeadersAllowed() {
> > diff --git
> >
> a/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java
> >
> b/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java
> > index cc30aac..8afde01 100644
> > ---
> >
> a/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java
> > +++
> >
> b/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CrossSubdomainSessionValve.java
> > @@ -116,7 +116,7 @@ public class CrossSubdomainSessionValve extends
> > ValveBase {
> > MessageBytes value = mimeHeaders.getValue(i);
> > if (value.indexOf(cookie.getName()) >= 0) {
> > String newCookieValue = request.getContext().
> > -
> > getCookieProcessor().generateHeader(newCookie,request);
> > +
> > getCookieProcessor().generateHeader(newCookie, request);
> > if (Debug.verboseOn())
> >
> Debug.logVerbose("CrossSubdomainSessionValve:
> > old Set-Cookie value: " + value.toString(),
> > MODULE);
> > diff --git
> >
> a/framework/common/src/main/java/org/apache/ofbiz/common/FindServices.java
> >
> b/framework/common/src/main/java/org/apache/ofbiz/common/FindServices.java
> > index 8efc0bf..5da39db 100644
> > ---
> >
> a/framework/common/src/main/java/org/apache/ofbiz/common/FindServices.java
> > +++
> >
> b/framework/common/src/main/java/org/apache/ofbiz/common/FindServices.java
> > @@ -487,7 +487,7 @@ public class FindServices {
> > }
>
Re: Welcome Aditya Sharma as new PMC member
Many congratulations, Aditya Sharma !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Jul 6, 2020 at 12:08 PM Devanshu Vyas wrote: > Many Congratulations Aditya! > > Thanks & Regards, > Devanshu Vyas. > > > On Sun, Jul 5, 2020 at 10:24 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has invited Aditya Sharma to become member of the committee > > and we are glad to announce that he has accepted the nomination. > > > > On behalf of the OFBiz PMC, welcome on board Aditya! > > > > >
Re: Welcome Arun Patidar as new PMC member
Many congratulations, Arun Patidar !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Jul 6, 2020 at 12:30 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Arun Patidar to become member of the committee > and we are glad to announce that he has accepted the nomination. > > On behalf of the OFBiz PMC, welcome on board Arun! > >
Re: Add CHANGELOG.md file
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jun 17, 2020 at 5:08 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 > > I believe it would be better done manually with a community consensus. > > Could someone probes me wrong? > > Jacques > > Le 17/06/2020 à 07:52, Deepak Dixit a écrit : > > Hi Dev, > > > > As we have already moved to git for the version control system, I propose > > to add a changelog file to maintain the changelogs[1]. > > What is a changelog? > > > > A changelog is a file which contains a curated, chronologically ordered > > list of notable changes for each version of a project. > > Why keep a changelog? > > > > To make it easier for users and contributors to see precisely what > notable > > changes have been made between each release (or version) of the project. > > Who needs a changelog? > > > > People do. Whether consumers or developers, the end users of software are > > human beings who care about what's in the software. When the software > > changes, people want to know why and how. > > > > We can have our own process to generate changelog, It may be either > manual > > entries, or some tool or using git log. We can discuss this > independently. > > > > https://keepachangelog.com/en/1.0.0/ > > > > Thanks & Regards > > -- > > Deepak Dixit > > ofbiz.apache.org > >
Re: buildbot failure in on ofbizTrunkFrameworkPlugins
Hello team, As Jacques confirms in the very next commit, this was due to a checkstyle issue introduced. I would like to request all contributors to please run './gradlew check' before creating PR's. TIA. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jun 16, 2020 at 4:38 PM wrote: > The Buildbot has detected a new failure on builder > ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full details are > available at: > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1494 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: asf946_ubuntu > > Build Reason: downstream > Build Source Stamp: [branch trunk] a3059c097dfd2f2ce85ba6eb90ac41f2556b1a91 > Blamelist: Priya Sharma > > BUILD FAILED: failed check > > Sincerely, > -The Buildbot > > > >
Re: [PROPOSAL] First Data Payment Gateway Integration
+1 Nicolas. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Jun 15, 2020 at 8:23 PM Nicolas Malin wrote: > Hi Pritam, > > My preference go to move all gateway to plugin, to keep OFBiz framework > slim and the connector quality high. > > If all third payment gateway are in plugin system, we are sure that the > framework contains correct standard call in function process, and we 're > not tempted (to go fast) to introduce bad hook to support a specific > case needed by the gateway. > > That being said, your proposal to introduce this gateway payment are > welcome :) > > Nicolas > > On 15/06/2020 15:15, Pritam Kute wrote: > > Hello Devs, > > > > I hope everyone is safe and well. > > > > Apache OFBiz has OOTB integrations for most of the widely used payment > > gateways around the world. > > > > We are working on integrating First Data Payment Gateway for one of the > > websites. The First Data payment gateway is quite popular and comes in > the > > list of top payment gateways around the globe We would like to > contribute > > the basic payment gateway integration of First Data into Apache OFBiz. We > > would like to know your thoughts on this. > > > > We would also like your opinion on contributing the gateway code in > > applications/accounting component vs a separate plugin. > > > > After approval from the community, we will create detailed tickets in > JIRA > > and contribute the patch accordingly. > > > > Thanks! > > > > Kind Regards, > > -- > > Pritam Kute > > >
Re: IMPROVEMENT: Checkstyle formatting issues
Thanks everyone for your inputs. Here [1] is the ticket created for the same. [1] : https://issues.apache.org/jira/browse/OFBIZ-11805 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jun 3, 2020 at 7:55 PM Mridul Pathak < mridul.pat...@hotwaxsystems.com> wrote: > +1 > > Thanks. > -- > Mridul Pathak > > > > On 30-May-2020, at 9:55 PM, Suraj Khurana > wrote: > > > > Hello Devs, > > > > Hope you are doing good !! > > > > Currently, there are many checkstyle issues in code base which are due to > > formatting best practices, like indentation, using spaces before/after > > symbols etc. > > > > We can solve many thousands of such issues by correcting all such > > occurrences. Please share your thoughts on this. > > > > A known thing is that we will lose the last history of such codebase > while > > doing this re-factoring. > > > > Any other ideas to solve the problem are most welcome. > > -- > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > >
Re: IMPROVEMENT: Checkstyle formatting issues
Hello Michael, Just the very last commit on that particular line that we check while annotating. Nothing else. As Jacques mentioned most of the time the history can be rebuilt with blame using lines around. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Mon, Jun 1, 2020 at 2:43 PM Michael Brohl wrote: > Hi Suraj, > > +1 for the refactoring in general. What history do we lose while > refactoring? > > Thanks, > > Michael > > > Am 30.05.20 um 18:25 schrieb Suraj Khurana: > > Hello Devs, > > > > Hope you are doing good !! > > > > Currently, there are many checkstyle issues in code base which are due to > > formatting best practices, like indentation, using spaces before/after > > symbols etc. > > > > We can solve many thousands of such issues by correcting all such > > occurrences. Please share your thoughts on this. > > > > A known thing is that we will lose the last history of such codebase > while > > doing this re-factoring. > > > > Any other ideas to solve the problem are most welcome. > > -- > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > > >
Re: Removal of Price information from Pick Sheet Report
Hello Pawan, IMO, this label is confusing/misleading, this is order pick list or basically order details for warehouse manager to keep as a copy with himself. It will be always on each order level on the create picklist page. So that before creating a picklist he can check/select which orders to pick. Actual pick sheet (used by picker) is something available under manage picklist i.e. after picklist is created, which tells picker which item to pick from which location, no further order details. Am I missing something? -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Mon, Jun 1, 2020 at 3:09 PM Pawan Verma wrote: > Hello Devs, > > While working on OFBIZ-11781, issue of the distorted currency symbol. > Pierre asked: Are we confident that prices and currency symbols are a > requirement for a pick sheet? > > The important information for picket is Item, quantity, and location. > Pickers really don't need the unit price, subtotal, or other price-related > information. > > Should we remove the unit price and subtotal information from a pick sheet > report? Or should we fix OFBIZ-11781 only? > > Your suggestions are appreciated! > -- > Thanks & Regards > Pawan Verma > Technical Consultant > *HotWax Systems* > *Enterprise open source experts* > http://www.hotwaxsystems.com >
Re: Github PR template
Thanks Jacques. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 31, 2020 at 1:21 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Done also in R17 and R18, it can still be improved if necessary > > I removed a "ecomify-OFBIZ-11468_Convert_ShipmentReceiptServices-squashed" > branch that I pushed by mistake in ofbiz-framework.git > > Jacques > > Le 31/05/2020 à 05:55, Aditya Sharma a écrit : > > +1 > > > > Thanks and Regards, > > Aditya Sharma > > > > On Sat, May 30, 2020 at 10:43 PM Suraj Khurana > > wrote: > > > >> Hello team, > >> > >> IMO, we should imply these changes to plugins repository as well. > >> > >> -- > >> Best Regards, > >> Suraj Khurana > >> Senior Technical Consultant > >> > >> > >> On Sat, May 30, 2020 at 1:29 PM Suraj Khurana > >> wrote: > >> > >>> This is awesome. > >>> > >>> Thanks everyone involved in this effort. > >>> > >>> -- > >>> > >>> Best Regards, > >>> Suraj Khurana > >>> Senior Technical Consultant > >>> > >>> > >>> On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < > >>> jacques.le.r...@les7arts.com> wrote: > >>> > >>>> Le 28/05/2020 à 07:45, Aditya Sharma a écrit : > >>>>> I think this might not be a problem until you got to change it;) > >>>> Thanks Aditya, > >>>> > >>>> Actually I simply forgot to commit from my Linux VM :) > >>>> > >>>> > >>>> > >> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 > >>>> Jacques > >>>> > >>>> >
Re: Github PR template
Hello team, IMO, we should imply these changes to plugins repository as well. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 30, 2020 at 1:29 PM Suraj Khurana wrote: > This is awesome. > > Thanks everyone involved in this effort. > > -- > > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Le 28/05/2020 à 07:45, Aditya Sharma a écrit : >> > I think this might not be a problem until you got to change it;) >> >> Thanks Aditya, >> >> Actually I simply forgot to commit from my Linux VM :) >> >> >> https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 >> >> Jacques >> >>
IMPROVEMENT: Checkstyle formatting issues
Hello Devs, Hope you are doing good !! Currently, there are many checkstyle issues in code base which are due to formatting best practices, like indentation, using spaces before/after symbols etc. We can solve many thousands of such issues by correcting all such occurrences. Please share your thoughts on this. A known thing is that we will lose the last history of such codebase while doing this re-factoring. Any other ideas to solve the problem are most welcome. -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: Github PR template
This is awesome. Thanks everyone involved in this effort. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 28/05/2020 à 07:45, Aditya Sharma a écrit : > > I think this might not be a problem until you got to change it;) > > Thanks Aditya, > > Actually I simply forgot to commit from my Linux VM :) > > > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0 > > Jacques > >
Re: LineLength for checkstyle
Thanks Jacques. Using this I think we would also be able to configure like, hey don't check for services java files, they don't have default constructors ;) -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Tue, May 26, 2020 at 10:57 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi All, > > I agree with Daniel and Suraj. Do we would set a rule to 2000 to not let > the same default (2000). > > We should also decide for the exceptions, wrote (eg following[1] and [2]) > and note them in OFBIZ-11740. > > Pierre, see OFBIZ-11740 > > [1] > https://stackoverflow.com/questions/48000117/how-to-add-exceptions-in-a-checkstyle-config > [2] https://checkstyle.sourceforge.io/config_filters.html > > Jacques > > Le 26/05/2020 à 08:11, Suraj Khurana a écrit : > > +1 for setting rule. Also we can think of some configured values instead > of > > 2000 (default). may be we should set it to 3000 instead. > > > > And then as Daniel mentioned, work on refactoring those offending source > > files where possible. > > > > -- > > > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > > > > > On Mon, May 25, 2020 at 8:49 PM Carsten Schinzer < > > cars...@dcs-verkaufssysteme.de> wrote: > > > >> +1 for setting the max lines rule > >> > >>> Am 25.05.2020 um 17:05 schrieb Daniel Watford : > >>> > >>> Hi Jacques, > >>> > >>> I would vote for setting an explicit rule to have the max line length > set > >>> at 2000 lines and then work on refactoring those offending source files > >>> where possible. > >>> > >>> If we find some files cannot be split up then I think we can add > >> exceptions > >>> to prevent the max line length rule from being applied to them. But > that > >>> should be done on a file by file basis. > >>> > >>> I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer. > >>> Work has been progressing slowly but development has slowed during the > >>> pandemic. I hope to get back on top of this soon. > >>> > >>> Thanks, > >>> > >>> Dan. > >>> > >>> On Mon, 25 May 2020 at 15:43, Jacques Le Roux < > >> jacques.le.r...@les7arts.com> > >>> wrote: > >>> > >>>> Hi All, > >>>> > >>>> Suraj rightly mentioned that we have no FileLength checkstyle rule and > >> the > >>>> max default is 2000 lines: > >>>> https://checkstyle.sourceforge.io/config_sizes.html#FileLength > >>>> > >>>> We have some very large Java files in trunk and few (19) are longer > than > >>>> 2000 lines. > >>>> The question is should we increase FileLength checkstyle rule to hide > >> the > >>>> issue or try to split those files? > >>>> > >>>> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for > >> that > >>>> Jacques > >>>> > >>>> https://checkstyle.sourceforge.io/config_sizes.html#FileLength > >>>> > >>>> Le 25/05/2020 à 15:09, Suraj Khurana a écrit : > >>>>> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208 > >>>>> > >>>>> -- > >>>>> Best Regards, > >>>>> Suraj Khurana > >>>>> Senior Technical Consultant > >>>>> > >>>>> > >>>>> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana < > suraj.khur...@hotwax.co > >>>>> wrote: > >>>>> > >>>>>> Thanks everyone, > >>>>>> > >>>>>> Here[1] is the ticket to track this improvement. > >>>>>> > >>>>>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737 > >>>>>> > >>>>>> -- > >>>>>> Best Regards, > >>>>>> Suraj Khurana > >>>>>> Senior Technical Consultant > >>>>>> > >>>>>> > >>>>>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz < > >>>>>> holivier.li...@ofbizextra.org> wrote: > >>>>>> > >>>>>>> +1 > >>>>>>> > >>>>>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit : > >>>>>>>> Hello Devs, > >>>>>>>> > >>>>>>>> Recently we are facing some checkstyle issues and one cause of it > is > >>>>>>>> LineLength property. > >>>>>>>> Currently we have set it to 120, I think we should make it to 150 > >>>>>>> instead. > >>>>>>>> It is pretty visible in 13/14 font sizes as well. > >>>>>>>> > >>>>>>>> Please share your thoughts on this. > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Best Regards, > >>>>>>>> Suraj Khurana > >>>>>>>> Senior Technical Consultant > >>>>>>>> > >>> > >>> -- > >>> Daniel Watford > >> >
Re: LineLength for checkstyle
+1 for setting rule. Also we can think of some configured values instead of 2000 (default). may be we should set it to 3000 instead. And then as Daniel mentioned, work on refactoring those offending source files where possible. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, May 25, 2020 at 8:49 PM Carsten Schinzer < cars...@dcs-verkaufssysteme.de> wrote: > +1 for setting the max lines rule > > > Am 25.05.2020 um 17:05 schrieb Daniel Watford : > > > > Hi Jacques, > > > > I would vote for setting an explicit rule to have the max line length set > > at 2000 lines and then work on refactoring those offending source files > > where possible. > > > > If we find some files cannot be split up then I think we can add > exceptions > > to prevent the max line length rule from being applied to them. But that > > should be done on a file by file basis. > > > > I still have OFBIZ-11456 on my todo list to refactor MacroFormRenderer. > > Work has been progressing slowly but development has slowed during the > > pandemic. I hope to get back on top of this soon. > > > > Thanks, > > > > Dan. > > > > On Mon, 25 May 2020 at 15:43, Jacques Le Roux < > jacques.le.r...@les7arts.com> > > wrote: > > > >> Hi All, > >> > >> Suraj rightly mentioned that we have no FileLength checkstyle rule and > the > >> max default is 2000 lines: > >> https://checkstyle.sourceforge.io/config_sizes.html#FileLength > >> > >> We have some very large Java files in trunk and few (19) are longer than > >> 2000 lines. > >> The question is should we increase FileLength checkstyle rule to hide > the > >> issue or try to split those files? > >> > >> I have created https://issues.apache.org/jira/browse/OFBIZ-11740 for > that > >> > >> Jacques > >> > >> https://checkstyle.sourceforge.io/config_sizes.html#FileLength > >> > >> Le 25/05/2020 à 15:09, Suraj Khurana a écrit : > >>> This is done in rev # d6ebef619349f809062641d1b558cacdec3da208 > >>> > >>> -- > >>> Best Regards, > >>> Suraj Khurana > >>> Senior Technical Consultant > >>> > >>> > >>> On Mon, May 25, 2020 at 2:16 PM Suraj Khurana > > >>> wrote: > >>> > >>>> Thanks everyone, > >>>> > >>>> Here[1] is the ticket to track this improvement. > >>>> > >>>> [1]: https://issues.apache.org/jira/browse/OFBIZ-11737 > >>>> > >>>> -- > >>>> Best Regards, > >>>> Suraj Khurana > >>>> Senior Technical Consultant > >>>> > >>>> > >>>> On Sun, May 24, 2020 at 1:58 PM Olivier Heintz < > >>>> holivier.li...@ofbizextra.org> wrote: > >>>> > >>>>> +1 > >>>>> > >>>>> Le 23/05/2020 à 17:29, Suraj Khurana a écrit : > >>>>>> Hello Devs, > >>>>>> > >>>>>> Recently we are facing some checkstyle issues and one cause of it is > >>>>>> LineLength property. > >>>>>> Currently we have set it to 120, I think we should make it to 150 > >>>>> instead. > >>>>>> It is pretty visible in 13/14 font sizes as well. > >>>>>> > >>>>>> Please share your thoughts on this. > >>>>>> > >>>>>> -- > >>>>>> Best Regards, > >>>>>> Suraj Khurana > >>>>>> Senior Technical Consultant > >>>>>> > >> > > > > > > -- > > Daniel Watford > >
Re: LineLength for checkstyle
This is done in rev # d6ebef619349f809062641d1b558cacdec3da208 -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, May 25, 2020 at 2:16 PM Suraj Khurana wrote: > Thanks everyone, > > Here[1] is the ticket to track this improvement. > > [1]: https://issues.apache.org/jira/browse/OFBIZ-11737 > > -- > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Sun, May 24, 2020 at 1:58 PM Olivier Heintz < > holivier.li...@ofbizextra.org> wrote: > >> +1 >> >> Le 23/05/2020 à 17:29, Suraj Khurana a écrit : >> > Hello Devs, >> > >> > Recently we are facing some checkstyle issues and one cause of it is >> > LineLength property. >> > Currently we have set it to 120, I think we should make it to 150 >> instead. >> > It is pretty visible in 13/14 font sizes as well. >> > >> > Please share your thoughts on this. >> > >> > -- >> > Best Regards, >> > Suraj Khurana >> > Senior Technical Consultant >> > >> >
Re: LineLength for checkstyle
Thanks everyone, Here[1] is the ticket to track this improvement. [1]: https://issues.apache.org/jira/browse/OFBIZ-11737 -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 24, 2020 at 1:58 PM Olivier Heintz < holivier.li...@ofbizextra.org> wrote: > +1 > > Le 23/05/2020 à 17:29, Suraj Khurana a écrit : > > Hello Devs, > > > > Recently we are facing some checkstyle issues and one cause of it is > > LineLength property. > > Currently we have set it to 120, I think we should make it to 150 > instead. > > It is pretty visible in 13/14 font sizes as well. > > > > Please share your thoughts on this. > > > > -- > > Best Regards, > > Suraj Khurana > > Senior Technical Consultant > > >
LineLength for checkstyle
Hello Devs, Recently we are facing some checkstyle issues and one cause of it is LineLength property. Currently we have set it to 120, I think we should make it to 150 instead. It is pretty visible in 13/14 font sizes as well. Please share your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: buildbot failure in on ofbizTrunkFrameworkPlugins
+1 Aditya If we can do that, that would be great. -- Suraj khurana On Sat 23 May, 2020, 6:55 PM Aditya Sharma, wrote: > Hi Jacques, > > I think *check styles* plugin is important for us and we should think of > introducing a pre-commit hook that checks only for the staged changes. This > will help developers to know about the lint issues before the commit > itself. > > Some reference I found that achieves the above case. Though I didn't try > any of these solutions. > > > https://ebaytech.berlin/checkstyle-on-changed-files-with-gradle-1619e49dbe4e > > https://stackoverflow.com/questions/43730901/is-there-a-way-to-run-checkstyle-on-only-files-that-have-changes-in-vcs > > https://ealebed.github.io/posts/2020/gradle-checkstyle-on-changed-files-only/ > > What do you think? > > Thanks and Regards, > Aditya Sharma > > On Sat, May 23, 2020 at 6:44 PM Pawan Verma > > wrote: > > > Hi Jacques, > > > > I care for the *checkstyle* issues but I also feel we should abandon it. > > > > -- > > Thanks & Regards > > Pawan Verma > > Technical Consultant > > *HotWax Systems* > > *Enterprise open source experts* > > http://www.hotwaxsystems.com > > > > > > On Sat, May 23, 2020 at 6:08 PM Jacques Le Roux < > > jacques.le.r...@les7arts.com> wrote: > > > > > Ha wait I confused w/ something else. > > > > > > Aas I said when starting this thread > > > > > > "this is a *checkstyle* issue. It's not clear to me why it > happened." > > > > > > Currently BuildBot makes erratic exceptions trying to pull. I have > > created > > > for that (and just updated) > > > https://issues.apache.org/jira/browse/INFRA-20303 > > > > > > So it's maybe not only your commit which increased the style errors... > > > > > > Unfortunately in this case, as it's then difficult to know form where > > > comes the errors (they can be cumulated commit after commit), the > easier > > > issue > > > is to set tasks.checkstyleMain.maxErrors to the last reported errors :/ > > > > > > Now I have also mentioned in the 1st msg of this thread: > > > > > > "Also I begin to wonder if the community really cares about > > > *checkstyle* issues..." > > > > > > I mean we could maybe abandon it since it seems I'm the only one to > > care... > > > > > > HTH > > > > > > Jacques > > > > > > Le 23/05/2020 à 14:23, Jacques Le Roux a écrit : > > > > Thanks Suraj! > > > > > > > > Jacques > > > > > > > > Le 23/05/2020 à 14:04, Suraj Khurana a écrit : > > > >> Hello team, > > > >> > > > >> All tests passed on my local machine. > > > >> > > > >> I used: ./gradlew testIntegration > > > >> > > > >> -- > > > >> Best Regards, > > > >> Suraj Khurana > > > >> Senior Technical Consultant > > > >> > > > >> > > > >> On Sat, May 23, 2020 at 5:17 PM wrote: > > > >> > > > >>> The Buildbot has detected a new failure on builder > > > >>> ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full > > > details are > > > >>> available at: > > > >>> > > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1396 > > > >>> > > > >>> Buildbot URL: https://ci.apache.org/ > > > >>> > > > >>> Buildslave for this Build: asf947_ubuntu > > > >>> > > > >>> Build Reason: downstream > > > >>> Build Source Stamp: [branch trunk] > > > 8bdb6c99856fd4ae17a95ccb0f661a256caaab13 > > > >>> Blamelist: Suraj Khurana < > > > 64310724+surajkhur...@users.noreply.github.com>,Suraj > > > >>> Khurana > > > >>> > > > >>> BUILD FAILED: failed shell_2 > > > >>> > > > >>> Sincerely, > > > >>> -The Buildbot > > > >>> > > > >>> > > > >>> > > > >>> > > > > > >
Re: buildbot failure in on ofbizTrunkFrameworkPlugins
Hello team, All tests passed on my local machine. I used: ./gradlew testIntegration -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 23, 2020 at 5:17 PM wrote: > The Buildbot has detected a new failure on builder > ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full details are > available at: > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1396 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: asf947_ubuntu > > Build Reason: downstream > Build Source Stamp: [branch trunk] 8bdb6c99856fd4ae17a95ccb0f661a256caaab13 > Blamelist: Suraj Khurana > <64310724+surajkhur...@users.noreply.github.com>,Suraj > Khurana > > BUILD FAILED: failed shell_2 > > Sincerely, > -The Buildbot > > > >
Re: Modify OFBiz commit message template
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 20, 2020 at 2:33 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > With Git IMO it's convenient (more information) to have the Jira number in > the title, eg: https://markmail.org/message/cyslglyoh5gf7l7t > > If nobody disagree I'd like to modify > > > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template > > We could have > > > > [Implemented | Improved | Fixed | Completed| Documented | Reverted]: [Jira > title | Free text] [(OFBIZ-)] > > [(OFBIZ-)] > > [More detailed explanation of what has been done and what the fix achieves, > sideeffects etc.] > > [Thanks:] [ for ... and for] > > > > But I would prefer: > > [Implemented | Improved | Fixed | Completed| Documented | Reverted]: [Jira > title | Free text] [(OFBIZ-)] > > [More detailed explanation of what has been done and what the fix achieves, > sideeffects etc.] > > [Thanks:] [ for ... and for] > > > Opinions? > > Thanks > > Jacques > >
Re: @deprecated No replacement
+1 to remove the "@deprecated No replacement" references. -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, May 22, 2020 at 1:03 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > We have 5, 8 years old, , "@deprecated No replacement" references in Java > code: > https://ofbiz.markmail.org/search/?q=%22%40deprecated+No+replacement%22 > > It seems they are all related to Minilang. I think we should either > remove the concerned methods. > > Or rather, easier, remove the "@deprecated No replacement" references > since anyway Minilang is deprecated as a whole. > > I'm for the later and will do so in a week if nobody is against. > > Jacques > >
Re: buildbot failure in on ofbizTrunkFramework
Hello team, This is done at rev #9913e566cc5c6c6258e5870137094f138a244489 -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 16, 2020 at 2:28 PM Suraj Khurana wrote: > I am looking into it. > > -- > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Sat, May 16, 2020 at 2:23 PM wrote: > >> The Buildbot has detected a new failure on builder ofbizTrunkFramework >> while building ofbiz-framework. Full details are available at: >> https://ci.apache.org/builders/ofbizTrunkFramework/builds/1488 >> >> Buildbot URL: https://ci.apache.org/ >> >> Buildslave for this Build: asf946_ubuntu >> >> Build Reason: The AnyBranchScheduler scheduler named >> 'onTrunkFrameworkCommit' triggered this build >> Build Source Stamp: [branch trunk] >> c7ae78d551574f81bef9d5ddbbf5aaa0a934dfe1 >> Blamelist: Suraj Khurana <64310724+surajkhur...@users.noreply.github.com> >> >> BUILD FAILED: failed shell_2 >> >> Sincerely, >> -The Buildbot >> >> >> >>
Re: buildbot failure in on ofbizTrunkFramework
I am looking into it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 16, 2020 at 2:23 PM wrote: > The Buildbot has detected a new failure on builder ofbizTrunkFramework > while building ofbiz-framework. Full details are available at: > https://ci.apache.org/builders/ofbizTrunkFramework/builds/1488 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: asf946_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkFrameworkCommit' triggered this build > Build Source Stamp: [branch trunk] c7ae78d551574f81bef9d5ddbbf5aaa0a934dfe1 > Blamelist: Suraj Khurana <64310724+surajkhur...@users.noreply.github.com> > > BUILD FAILED: failed shell_2 > > Sincerely, > -The Buildbot > > > >
XML to Groovy conversions
Hello team, Recently we are working on a major refactoring task of minilnag to groovy conversion, which is commendable. I would like to add following points to be taken into consideration while doing the exact changes in the service: - Check and think of possible conversion to entity-auto. - Handle service error responses, in xml usually we skip it. It would be great if while conversion if any service is called, its error response should be effectively handled. Like in a single line: serviceResult = run service: "createCustomer", with: parameters if (!ServiceUtil.isSuccess(serviceResult)) return error(serviceResult.errorMessage) - Avoid unnecessary declaration of variables and the same 'serviceResult' map can be re-used in case of multiple service calls inside the same service. IMO, these are very small best practices that can directly be taken care of while conversion, will improve code quality. Please share your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: buildbot exception in on ofbizTrunkFrameworkPlugins
Everything worked fine on the local box. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 13, 2020 at 6:00 PM wrote: > The Buildbot has detected a build exception on builder > ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full details are > available at: > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1350 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: asf947_ubuntu > > Build Reason: downstream > Build Source Stamp: [branch trunk] 2b0166410dcb7165ba4493400db690810e540554 > Blamelist: Suraj Khurana <64310724+surajkhur...@users.noreply.github.com> > > BUILD FAILED: exception shell_2 shell_3 upload_2 > > Sincerely, > -The Buildbot > > > >
Re: buildbot failure in on ofbizTrunkFramework
Hello team, I checked on my local box, working fine at my end. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 13, 2020 at 2:36 PM wrote: > The Buildbot has detected a new failure on builder ofbizTrunkFramework > while building ofbiz-framework. Full details are available at: > https://ci.apache.org/builders/ofbizTrunkFramework/builds/1470 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build: asf946_ubuntu > > Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkFrameworkCommit' triggered this build > Build Source Stamp: [branch trunk] ba04eda31a36db12bac6dd0f1607c91d31449e47 > Blamelist: Suraj Khurana > > BUILD FAILED: failed shell_2 > > Sincerely, > -The Buildbot > > > >
Re: buildbot failure in on ofbizTrunkFramework
Hello team, It is fixed under rev 0393ebe994def0e3958c0d78f6e590e68ccdef88, main cause was test data so added QuoteTestData.xml with proper cust request status fixes most of it. One interesting thing observed during this was if you override fromDate in entity-auto, default now timestamp doesn't set from entity-auto engine. I will take a deeper look into it to confirm, for now I have set default-value and it is working as expected. Thanks for reporting. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 6, 2020 at 11:50 AM Suraj Khurana wrote: > Hello Jacques, > > As per my findings, IMO it was due to custRequestId="9000" test data with > status 'CRQ_SUBMITTED'. > Changing it to CRQ_ACCEPTED fixed all CustRequest related test cases at my > local machine. > > I am looking out for more details and will take care of it at the earliest. > > Thanks !! > -- > Best Regards, > Suraj Khurana > SENIOR TECHNICAL CONSULTANT > mobile: +91 9669750002 > email: suraj.khur...@hotwax.co > *www.hotwax.co <http://www.hotwax.co/>* > > > On Wed, May 6, 2020 at 10:14 AM Suraj Khurana > wrote: > >> Hello Jacques, >> >> This service was committed at rev # >> edca9f22b03ecb5f7096652cf020ca3b52043962 and it is available in the latest >> trunk as well. >> Could you please confirm it once again? >> >> -- >> Best Regards, >> Suraj Khurana >> SENIOR TECHNICAL CONSULTANT >> mobile: +91 9669750002 >> email: suraj.khur...@hotwax.co >> *www.hotwax.co <http://www.hotwax.co/>* >> >> >> On Tue, May 5, 2020 at 9:07 PM Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >>> Hi Suraj, >>> >>> This is due to OFBIZ-11621, OFBIZ-11627, OFBIZ-11637 and OFBIZ-11624 >>> which are all conversion of CRUD simple services to entity-auto >>> >>> Notably checkStatusCustRequest service does not exist, it's only an >>> internal simple-method. >>> >>> Please revert in order to clear the integration tests issues. >>> >>> TIA >>> >>> Jacques >>> >>> Le 05/05/2020 à 11:08, Jacques Le Roux a écrit : >>> > Hi, >>> > >>> > I fixed 2 cases with (but not related to) OFBIZ-11620 >>> > >>> > Remains the 3 custrequesttests and testCreateTimeEntry failures in >>> both framework only and framework+plugins integration tests. >>> > >>> > Not sure when they appeared as things got blurred. >>> > >>> > Jacques >>> > >>> > Le 04/05/2020 à 19:28, Jacques Le Roux a écrit : >>> >> Hi, >>> >> >>> >> Missed that, I'm on it >>> >> >>> >> Jacques >>> >> >>> >> Le 29/04/2020 à 10:39, build...@apache.org a écrit : >>> >>> The Buildbot has detected a new failure on builder >>> ofbizTrunkFramework while building ofbiz-framework. Full details are >>> available at: >>> >>> https://ci.apache.org/builders/ofbizTrunkFramework/builds/1402 >>> >>> >>> >>> Buildbot URL: https://ci.apache.org/ >>> >>> >>> >>> Buildslave for this Build: asf947_ubuntu >>> >>> >>> >>> Build Reason: The AnyBranchScheduler scheduler named >>> 'onTrunkFrameworkCommit' triggered this build >>> >>> Build Source Stamp: [branch trunk] >>> 649614507bab6ff955e243a5858c1353150dfd42 >>> >>> Blamelist: Jacques Le Roux >>> >>> >>> >>> BUILD FAILED: failed shell_2 >>> >>> >>> >>> Sincerely, >>> >>> -The Buildbot >>> >>> >>> >>> >>> >>> >>> >>
Re: buildbot failure in on ofbizTrunkFramework
Hello Jacques, As per my findings, IMO it was due to custRequestId="9000" test data with status 'CRQ_SUBMITTED'. Changing it to CRQ_ACCEPTED fixed all CustRequest related test cases at my local machine. I am looking out for more details and will take care of it at the earliest. Thanks !! -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Wed, May 6, 2020 at 10:14 AM Suraj Khurana wrote: > Hello Jacques, > > This service was committed at rev # > edca9f22b03ecb5f7096652cf020ca3b52043962 and it is available in the latest > trunk as well. > Could you please confirm it once again? > > -- > Best Regards, > Suraj Khurana > SENIOR TECHNICAL CONSULTANT > mobile: +91 9669750002 > email: suraj.khur...@hotwax.co > *www.hotwax.co <http://www.hotwax.co/>* > > > On Tue, May 5, 2020 at 9:07 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >> Hi Suraj, >> >> This is due to OFBIZ-11621, OFBIZ-11627, OFBIZ-11637 and OFBIZ-11624 >> which are all conversion of CRUD simple services to entity-auto >> >> Notably checkStatusCustRequest service does not exist, it's only an >> internal simple-method. >> >> Please revert in order to clear the integration tests issues. >> >> TIA >> >> Jacques >> >> Le 05/05/2020 à 11:08, Jacques Le Roux a écrit : >> > Hi, >> > >> > I fixed 2 cases with (but not related to) OFBIZ-11620 >> > >> > Remains the 3 custrequesttests and testCreateTimeEntry failures in both >> framework only and framework+plugins integration tests. >> > >> > Not sure when they appeared as things got blurred. >> > >> > Jacques >> > >> > Le 04/05/2020 à 19:28, Jacques Le Roux a écrit : >> >> Hi, >> >> >> >> Missed that, I'm on it >> >> >> >> Jacques >> >> >> >> Le 29/04/2020 à 10:39, build...@apache.org a écrit : >> >>> The Buildbot has detected a new failure on builder >> ofbizTrunkFramework while building ofbiz-framework. Full details are >> available at: >> >>> https://ci.apache.org/builders/ofbizTrunkFramework/builds/1402 >> >>> >> >>> Buildbot URL: https://ci.apache.org/ >> >>> >> >>> Buildslave for this Build: asf947_ubuntu >> >>> >> >>> Build Reason: The AnyBranchScheduler scheduler named >> 'onTrunkFrameworkCommit' triggered this build >> >>> Build Source Stamp: [branch trunk] >> 649614507bab6ff955e243a5858c1353150dfd42 >> >>> Blamelist: Jacques Le Roux >> >>> >> >>> BUILD FAILED: failed shell_2 >> >>> >> >>> Sincerely, >> >>> -The Buildbot >> >>> >> >>> >> >>> >> >
Re: buildbot failure in on ofbizTrunkFramework
Hello Jacques, This service was committed at rev # edca9f22b03ecb5f7096652cf020ca3b52043962 and it is available in the latest trunk as well. Could you please confirm it once again? -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Tue, May 5, 2020 at 9:07 PM Jacques Le Roux wrote: > Hi Suraj, > > This is due to OFBIZ-11621, OFBIZ-11627, OFBIZ-11637 and OFBIZ-11624 which > are all conversion of CRUD simple services to entity-auto > > Notably checkStatusCustRequest service does not exist, it's only an > internal simple-method. > > Please revert in order to clear the integration tests issues. > > TIA > > Jacques > > Le 05/05/2020 à 11:08, Jacques Le Roux a écrit : > > Hi, > > > > I fixed 2 cases with (but not related to) OFBIZ-11620 > > > > Remains the 3 custrequesttests and testCreateTimeEntry failures in both > framework only and framework+plugins integration tests. > > > > Not sure when they appeared as things got blurred. > > > > Jacques > > > > Le 04/05/2020 à 19:28, Jacques Le Roux a écrit : > >> Hi, > >> > >> Missed that, I'm on it > >> > >> Jacques > >> > >> Le 29/04/2020 à 10:39, build...@apache.org a écrit : > >>> The Buildbot has detected a new failure on builder ofbizTrunkFramework > while building ofbiz-framework. Full details are available at: > >>> https://ci.apache.org/builders/ofbizTrunkFramework/builds/1402 > >>> > >>> Buildbot URL: https://ci.apache.org/ > >>> > >>> Buildslave for this Build: asf947_ubuntu > >>> > >>> Build Reason: The AnyBranchScheduler scheduler named > 'onTrunkFrameworkCommit' triggered this build > >>> Build Source Stamp: [branch trunk] > 649614507bab6ff955e243a5858c1353150dfd42 > >>> Blamelist: Jacques Le Roux > >>> > >>> BUILD FAILED: failed shell_2 > >>> > >>> Sincerely, > >>> -The Buildbot > >>> > >>> > >>> >
Re: [ofbiz-framework] branch trunk updated: Improved: Converted all ShipmentReceiptRole service from crud to entity-auto (#85)
Thanks Pawan. It is done in rev a92136c662b2a150274b7a9aaea2c3117488e599 -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Apr 30, 2020 at 9:54 PM Pawan Verma wrote: > Hi Suraj, > > You've missed to add default-entity-name for the entity-auto engine for the > above services. > > Could you please handle? > -- > Thanks & Regards > Pawan Verma > Technical Consultant > *HotWax Systems* > *Enterprise open source experts* > http://www.hotwaxsystems.com > > > On Thu, Apr 30, 2020 at 5:05 PM wrote: > > > This is an automated email from the ASF dual-hosted git repository. > > > > surajk pushed a commit to branch trunk > > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git > > > > > > The following commit(s) were added to refs/heads/trunk by this push: > > new e1a16aa Improved: Converted all ShipmentReceiptRole service > from > > crud to entity-auto (#85) > > e1a16aa is described below > > > > commit e1a16aa9fe4bacded92a0c4c34a0af7c02d0a325 > > Author: Suraj Khurana <64310724+surajkhur...@users.noreply.github.com> > > AuthorDate: Thu Apr 30 17:05:39 2020 +0530 > > > > Improved: Converted all ShipmentReceiptRole service from crud to > > entity-auto (#85) > > > > * Improved: Converted all ShipmentReceiptRole service from crud to > > entity-auto > > (OFBIZ-11614) > > --- > > .../shipment/receipt/ShipmentReceiptServices.xml | 15 > > --- > > applications/product/servicedef/services.xml | 2 +- > > applications/product/servicedef/services_shipment.xml | 18 > > ++ > > 3 files changed, 7 insertions(+), 28 deletions(-) > > > > diff --git > > > a/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml > > > b/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml > > index 2dade39..4334dc5 100644 > > --- > > > a/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml > > +++ > > > b/applications/product/minilang/shipment/receipt/ShipmentReceiptServices.xml > > @@ -63,21 +63,6 @@ under the License. > > > result-name="affectAccounting"/> > > > > > > - > short-description="Create a ShipmentReceipt Role"> > > - > value-field="newEntity"/> > > - > > - > > - > > - > > - > > - > > - > short-description="Remove a ShipmentReceipt Role"> > > - > value-field="lookupPKMap"/> > > - > > - > map="lookupPKMap" value-field="lookedUpValue"/> > > - > > - > > - > > > short-description="Receive Inventory in new Inventory Item(s)"> > > > > > > >
Re: Welcome Rishi Solanki as new PMC member
Many Congratulations, Rishi !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Apr 29, 2020 at 8:23 AM Ankush Upadhyay < ankush.upadh...@hotwaxsystems.com> wrote: > Many Congratulations Rishi!!! > > Kind Regards, > Ankush Upadhyay > Senior Technical Consultant > > *HotWax Systems* > *Enterprise open source experts* > cell: +91-8109201285 > office: 0731-409-3684 > http://www.hotwaxsystems.com > > > On Wed, Apr 29, 2020 at 12:37 AM Michael Brohl > wrote: > > > Congratulations, Rishi! Welcome on board. > > > > Best wishes, > > > > Michael > > > > > > Am 28.04.20 um 16:22 schrieb Jacopo Cappellato: > > > The OFBiz PMC has invited Rishi Solanki to become member of the > committee > > > and we are glad to announce that he has accepted the nomination. > > > > > > On behalf of the OFBiz PMC, welcome on board! > > > > > > > >
Re: service with entity engine= auto for invoke = read
Hello Vinay, Welcome to OFBiz. Here [1] is the document that can be helpful for you. It includes reference of performFind service as well. [1] https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide HTH. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT On Fri, Apr 17, 2020 at 3:19 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Vinay, > > Your message has been moderated. > > Please subscribe to the user ML for such questions and then use your email > client. > See why here http://ofbiz.apache.org/mailing-lists.html. > > You will get a better support, people can answer you on the ML. > The wider the audience the better the answers you might get. > > Also it's more work for moderators who have to accept your messages as > long as you have not subscribed. > I'll personally no longer accept them (other moderators still could). > > Thanks > > Jacques > > Le 16/04/2020 à 17:35, Vinay T M a écrit : > > Hi, > > I am new to ofbiz, my question is how to create service for read > operation(fetch all from database)? > > is it possible without writing additional java service ? > > please Help > > > > Reards, > > Vinay T M > >
Re: [ofbiz-framework] branch trunk updated: Improved: All the service level error messages for missing required field for party component. (OFBIZ-7735) Thanks Ratnesh Upadhyay for reporting and Kirti
Oops ! Thanks Pawan for taking care of this. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Apr 28, 2020 at 1:23 PM Pawan Verma wrote: > Hi Suraj, > > In this commit, we got unintentional '+' character > in applications/party/servicedef/services.xml file which was causing error > on the console. > > I've corrected it at f195e68. > -- > Thanks & Regards > Pawan Verma > ofbiz.apache.org > > > On Sat, Apr 25, 2020 at 7:07 PM wrote: > > > This is an automated email from the ASF dual-hosted git repository. > > > > surajk pushed a commit to branch trunk > > in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git > > > > > > The following commit(s) were added to refs/heads/trunk by this push: > > new d21bb75 Improved: All the service level error messages for > > missing required field for party component. (OFBIZ-7735) Thanks Ratnesh > > Upadhyay for reporting and Kirti Arora for providing the updated patch. > > d21bb75 is described below > > > > commit d21bb752f0b1e1691f67b3205fbcb84ddaccf28e > > Author: Suraj Khurana > > AuthorDate: Sat Apr 25 18:50:22 2020 +0530 > > > > Improved: All the service level error messages for missing required > > field for party component. > > (OFBIZ-7735) > > Thanks Ratnesh Upadhyay for reporting and Kirti Arora for providing > > the updated patch. > > --- > > applications/party/config/PartyErrorUiLabels.xml | 72 +++ > > applications/party/servicedef/services.xml | 228 > > +++ > > applications/party/servicedef/services_view.xml | 42 - > > 3 files changed, 297 insertions(+), 45 deletions(-) > > > > diff --git a/applications/party/config/PartyErrorUiLabels.xml > > b/applications/party/config/PartyErrorUiLabels.xml > > index b01c812..86db4ae 100644 > > --- a/applications/party/config/PartyErrorUiLabels.xml > > +++ b/applications/party/config/PartyErrorUiLabels.xml > > @@ -53,6 +53,78 @@ > > > > Required Field Missing : WorkEffort Type > > Id. > > > > + > > +Required Field Missing : > Address > > + > > + > > +Required Field Missing : ChildRole Type Id > > List > > + > > + > > +Required Field Missing : Contact Mech > > Id > > + > > + > > +Required Field Missing : Contact Mech > > Purpose Type Id > > + > > + > > +Required Field Missing : Contact Mech Type > > Id > > + > > + > > +Required Field Missing : Email > > Address > > + > > + > > +Required Field Missing : First Name > > + > > + > > +Required Field Missing : Last Name > > + > > + > > +Required Field Missing : Lookup > > Result > > + > > + > > +Required Field Missing : New User > > Login > > + > > + > > +Required Field Missing : Old Contact Mech > > Id > > + > > + > > +Required Field Missing : Organization Party > > Id > > + > > + > key="PartyRequiredFieldMissingParentOrganizationPartyIdList"> > > +Required Field Missing : Organization Party > > Id List > > + > > + > > +Required Field Missing : Party Id > > + > > + > > +Required Field Missing : Party Id > > From > > + > > + > > +Required Field Missing : Party Id > To > > + > > + > > +Required Field Missing : Party Invitation > > Id > > + > > + > > +Required Field Missing : Product Store > > Id > > + > > + > > +Required Field Missing : Related Party Id > > List > > + > > + > > +Required Field Missing : Role Type > Id > > + > > + > > +Required Field Missing : Status Id > > + > > + > > +Required Field Missing : Tel no. > > + > > + > > +Required Field Missing : User Login > > Id > > + > > + > > +Required Field Missing : Verify > Hash > > + > > > > Uploaded file data not found > > > > diff --git a/applications/party/servicedef/services.xml > > b/applications/party/servicedef/services.xml &
Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
Thanks Jacques for taking care of it.
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Mon, Apr 27, 2020 at 9:43 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> I don't remember if it was intentional, I think I missed them and will add
> them "right now"
>
> Thanks
>
> Le 27/04/2020 à 12:36, Suraj Khurana a écrit :
> > I meant, in the XML version we were sending note (Test note) and comments
> > (Test Comments) as well in serviceCtx, but in the converted version we
> are
> > not sending these fields.
> >
> > Tests will pass for sure, as they are not mandatory to send.
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
> >
> > On Mon, Apr 27, 2020 at 2:52 PM Jacques Le Roux <
> > jacques.le.r...@les7arts.com> wrote:
> >
> >> Hi Suraj,
> >>
> >> If you mean that there is no explanation but "Tests pass", as it's Svn
> we
> >> can still amend it, what would you suggest?
> >>
> >> Thanks
> >>
> >> Jacques
> >>
> >> Le 27/04/2020 à 08:47, Suraj Khurana a écrit :
> >>> Hello Jacques,
> >>>
> >>> I think we missed the note, comments field during conversion in this
> >> commit.
> >>> Is it intentional, or am I missing something?
> >>>
> >>> --
> >>> Best Regards,
> >>> Suraj Khurana
> >>> Senior Technical Consultant
> >>>
> >>> On Thu, Oct 3, 2019 at 5:00 PM wrote:
> >>>
> >>>> Author: jleroux
> >>>> Date: Thu Oct 3 11:30:28 2019
> >>>> New Revision: 1867927
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=1867927&view=rev
> >>>> Log:
> >>>> Improved: Convert testSendOrderChangeNotification to Groovy
> >>>> (OFBIZ-11233)
> >>>>
> >>>> Tests pass
> >>>>
> >>>> Modified:
> >>>>
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> >>>> Modified:
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> >>>> URL:
> >>>>
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml?rev=1867927&r1=1867926&r2=1867927&view=diff
> >>>>
> >>
> ==
> >>>> ---
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> >>>> (original)
> >>>> +++
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> >>>> Thu Oct 3 11:30:28 2019
> >>>> @@ -154,23 +154,4 @@ under the License.
> >>>>
> >>>>
> >>>>
> >>>> -
> >>>> - >>>> short-description="Sends order change confirmation mail"
> >>>> login-required="false">
> >>>> -
> >>>> -
> >>>> -
> >>>> -
> >>>> -
> >>>> -
> >>>> -
> >>>> -
> >>>> - >>>> in-map-name="serviceCtx">
> >>>> -
> >>>> -
> >>>> -
> >>>> -
> >>>> - >> field="serviceResult.emailType"
> >>>> value="PRDS_ODR_CHANGE" />
> >>>> -
> >>>> -
> >>>> -
> >>>>
> >>>> \ No newline at end of file
> >>>>
> >>>> Modified:
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> >>>> URL:
> >>>>
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy?rev=1867927&r1=1867926&r2=1867927&view=diff
> >>>>
> >>
> ==
> >>>> ---
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> >>>> (original)
> >>>> +++
> >>>>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> >>>> Thu Oct 3 11:30:28 2019
> >>>> @@ -212,4 +212,17 @@ class OrderTests extends OFBizTestCase {
> >>>>Map serviceResult =
> >>>> dispatcher.runSync('associatedRequirementWithRequestItem', serviceCtx)
> >>>>assert ServiceUtil.isSuccess(serviceResult)
> >>>>}
> >>>> +
> >>>> +void testSendOrderChangeNotification() {
> >>>> +Map serviceCtx = [
> >>>> + orderId: 'TEST_DEMO10090',
> >>>> + sendTo: 'test_em...@example.com',
> >>>> + userLogin:
> >>>> EntityQuery.use(delegator).from('UserLogin').where('userLoginId',
> >>>> 'system').cache().queryOne()
> >>>> +]
> >>>> +Map serviceResult =
> >>>> dispatcher.runSync('sendOrderChangeNotification', serviceCtx)
> >>>> +assert ServiceUtil.isSuccess(serviceResult)
> >>>> +assert serviceResult.emailType.equals("PRDS_ODR_CHANGE")
> >>>> +}
> >>>> +
> >>>> +
> >>>>}
> >>>>
> >>>>
> >>>>
>
Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
I meant, in the XML version we were sending note (Test note) and comments
(Test Comments) as well in serviceCtx, but in the converted version we are
not sending these fields.
Tests will pass for sure, as they are not mandatory to send.
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Mon, Apr 27, 2020 at 2:52 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Hi Suraj,
>
> If you mean that there is no explanation but "Tests pass", as it's Svn we
> can still amend it, what would you suggest?
>
> Thanks
>
> Jacques
>
> Le 27/04/2020 à 08:47, Suraj Khurana a écrit :
> > Hello Jacques,
> >
> > I think we missed the note, comments field during conversion in this
> commit.
> > Is it intentional, or am I missing something?
> >
> > --
> > Best Regards,
> > Suraj Khurana
> > Senior Technical Consultant
> >
> > On Thu, Oct 3, 2019 at 5:00 PM wrote:
> >
> >> Author: jleroux
> >> Date: Thu Oct 3 11:30:28 2019
> >> New Revision: 1867927
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1867927&view=rev
> >> Log:
> >> Improved: Convert testSendOrderChangeNotification to Groovy
> >> (OFBIZ-11233)
> >>
> >> Tests pass
> >>
> >> Modified:
> >>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> >>
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> >>
> >> Modified:
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml?rev=1867927&r1=1867926&r2=1867927&view=diff
> >>
> >>
> ==
> >> ---
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> >> (original)
> >> +++
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> >> Thu Oct 3 11:30:28 2019
> >> @@ -154,23 +154,4 @@ under the License.
> >>
> >>
> >>
> >> -
> >> - >> short-description="Sends order change confirmation mail"
> >> login-required="false">
> >> -
> >> -
> >> -
> >> -
> >> -
> >> -
> >> -
> >> -
> >> - >> in-map-name="serviceCtx">
> >> -
> >> -
> >> -
> >> -
> >> - field="serviceResult.emailType"
> >> value="PRDS_ODR_CHANGE" />
> >> -
> >> -
> >> -
> >>
> >> \ No newline at end of file
> >>
> >> Modified:
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> >> URL:
> >>
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy?rev=1867927&r1=1867926&r2=1867927&view=diff
> >>
> >>
> ==
> >> ---
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> >> (original)
> >> +++
> >>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> >> Thu Oct 3 11:30:28 2019
> >> @@ -212,4 +212,17 @@ class OrderTests extends OFBizTestCase {
> >> Map serviceResult =
> >> dispatcher.runSync('associatedRequirementWithRequestItem', serviceCtx)
> >> assert ServiceUtil.isSuccess(serviceResult)
> >> }
> >> +
> >> +void testSendOrderChangeNotification() {
> >> +Map serviceCtx = [
> >> + orderId: 'TEST_DEMO10090',
> >> + sendTo: 'test_em...@example.com',
> >> + userLogin:
> >> EntityQuery.use(delegator).from('UserLogin').where('userLoginId',
> >> 'system').cache().queryOne()
> >> +]
> >> +Map serviceResult =
> >> dispatcher.runSync('sendOrderChangeNotification', serviceCtx)
> >> +assert ServiceUtil.isSuccess(serviceResult)
> >> +assert serviceResult.emailType.equals("PRDS_ODR_CHANGE")
> >> +}
> >> +
> >> +
> >> }
> >>
> >>
> >>
>
Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
Hello Jacques,
I think we missed the note, comments field during conversion in this commit.
Is it intentional, or am I missing something?
--
Best Regards,
Suraj Khurana
Senior Technical Consultant
On Thu, Oct 3, 2019 at 5:00 PM wrote:
> Author: jleroux
> Date: Thu Oct 3 11:30:28 2019
> New Revision: 1867927
>
> URL: http://svn.apache.org/viewvc?rev=1867927&view=rev
> Log:
> Improved: Convert testSendOrderChangeNotification to Groovy
> (OFBIZ-11233)
>
> Tests pass
>
> Modified:
>
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
>
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
>
> Modified:
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml?rev=1867927&r1=1867926&r2=1867927&view=diff
>
> ==
> ---
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> (original)
> +++
> ofbiz/ofbiz-framework/trunk/applications/order/minilang/test/OrderTests.xml
> Thu Oct 3 11:30:28 2019
> @@ -154,23 +154,4 @@ under the License.
>
>
>
> -
> - short-description="Sends order change confirmation mail"
> login-required="false">
> -
> -
> -
> -
> -
> -
> -
> -
> - in-map-name="serviceCtx">
> -
> -
> -
> -
> - value="PRDS_ODR_CHANGE" />
> -
> -
> -
>
> \ No newline at end of file
>
> Modified:
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> URL:
> http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy?rev=1867927&r1=1867926&r2=1867927&view=diff
>
> ==
> ---
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> (original)
> +++
> ofbiz/ofbiz-framework/trunk/applications/order/src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy
> Thu Oct 3 11:30:28 2019
> @@ -212,4 +212,17 @@ class OrderTests extends OFBizTestCase {
> Map serviceResult =
> dispatcher.runSync('associatedRequirementWithRequestItem', serviceCtx)
> assert ServiceUtil.isSuccess(serviceResult)
> }
> +
> +void testSendOrderChangeNotification() {
> +Map serviceCtx = [
> + orderId: 'TEST_DEMO10090',
> + sendTo: 'test_em...@example.com',
> + userLogin:
> EntityQuery.use(delegator).from('UserLogin').where('userLoginId',
> 'system').cache().queryOne()
> +]
> +Map serviceResult =
> dispatcher.runSync('sendOrderChangeNotification', serviceCtx)
> +assert ServiceUtil.isSuccess(serviceResult)
> +assert serviceResult.emailType.equals("PRDS_ODR_CHANGE")
> +}
> +
> +
> }
>
>
>
Re: OFBiz-Shopify Integration
+1 for creating a new plugin. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Sun, Apr 26, 2020 at 10:00 AM Ritesh Kumar < ritesh.ku...@hotwaxsystems.com> wrote: > Hello team, > > Let me start by giving you heads up on Shopify. > > Shopify is a renowned eCommerce platform for building online retail > businesses. A large number of businesses are moving to the world of hosted > eCommerce platforms and Shopify seems to be, if not the best, one of the > best platforms available in the market today. Over a million merchants use > Shopify to run their businesses. They come in all sizes, from all around > the world, and each one is different. One can easily set up a store and go > online. > > Owing to such a large user base, there could be many merchants interested > in integrating their online sales with a powerful ERP system for the > backend processes such as order fulfilment, accounting, customer service, > etc. > > Shopify provides both REST and GraphQL APIs. APIs are richly documented. We > can further discuss the integration details. > > I do believe this integration will positively add to feature set already > available in OFBiz and can become a major adoption factor. > > Here are the references, > Shopify developer introduction > <https://shopify.dev/concepts/shopify-introduction> > Shopify storefront API <https://shopify.dev/docs/storefront-api> > > Please, let me know your thoughts on this. > > Best, > > -- > Ritesh Kumar >
Re: Default constructors in JAVA classes
Yes, there are few more classes are reported, they are: - BillingAccountWorker - FinAccountHelper - ConfigXMLReader - LoginWorker - ExpressionUiHelper - JobUtil - ServiceGroupReader - ExternalLoginKeysManager (Can be discussed) - JWTManager (Can be discussed) We can re-open and create tickets for these remaining classes, for sure we should think about Lombok integration. Some other usability issues reported by plugin are related to Constant Name: - Like 'resourceError' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$', this is throughout the framework, in all java classes. - Final Constants in all JAVA classes should be declared private instead of public, like MODULE. I think we can create improvement type tickets for these constant usability enhancements, if noone has any further concerns and we can improve them component wise. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Apr 26, 2020 at 6:01 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Suraj, > > Has QAPlug given you information about the classes still to change (of > course not services)? > > If yes, > > 1. we could reopen OFBIZ-7272; > 2. complete the work; > 3. and thought about Lombok integration in Gradle. > > Thanks > > Jacques > > Le 25/04/2020 à 09:58, Suraj Khurana a écrit : > > Yes, not much changes to be done after this information from Rishi. > > > > Thanks everyone. > > > > -- > > Best Regards, > > Suraj Khurana > > SENIOR TECHNICAL CONSULTANT > > mobile: +91 9669750002 > > email: suraj.khur...@hotwax.co > > *www.hotwax.co <http://www.hotwax.co/>* > > > > > > On Fri, Apr 24, 2020 at 3:22 PM Jacques Le Roux < > > jacques.le.r...@les7arts.com> wrote: > > > >> Oh indeed, completely forgot about that. So I guess there are not much > >> changes to do? > >> > >> Jacques > >> > >> Le 24/04/2020 à 09:43, Rishi Solanki a écrit : > >>> An effort already done for this cleanup - > >>> https://issues.apache.org/jira/browse/OFBIZ-7272 > >>> > >>> Agree with Girish, we should keep this change for Utility/Helper/Worker > >>> classes. And exclude services for sure, and if any specific event class > >> act > >>> as utility then we can consider it. > >>> > >>> Best Regards, > >>> -- > >>> Rishi Solanki > >>> *CTO, Mindpath Technology* > >>> Intelligent Solutions > >>> cell: +91-98932-87847 > >>> LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> > >>> > >>> > >>> On Thu, Apr 23, 2020 at 12:39 PM Jacques Le Roux < > >>> jacques.le.r...@les7arts.com> wrote: > >>> > >>>> Hi, > >>>> > >>>> It was mate, actually there was a missing word in my saying, I meant: > >>>> > >>>> I agree about changing only non idempotent classes in a 1st > >> approach. > >>>> That's obviously _NOT_ service and events, but could be also few > >>>> helper and worker classes. > >>>> > >>>> All the utility classes should be checked and non idempotent methods > (if > >>>> any) extracted > >>>> > >>>> To be clear: an idempotent class is a class which does not change the > >>>> state. For utilities That depends on its methods not on the class. > >>>> > >>>> I agree about steps by steps approach > >>>> > >>>> Jacques > >>>> > >>>> Le 23/04/2020 à 06:46, Girish Vasmatkar a écrit : > >>>>> Hi > >>>>> > >>>>> I am unsure if this needs to be extended or applied to the service > >>>> classes > >>>>> because even though the service classes do not appear to maintain > >> state, > >>>>> they conceptually relate to the business domain and hence are not a > >>>> worthy > >>>>> candidate. Moreover they are executed within a context and don't > >> qualify > >>>> as > >>>>> typical helper or utility classes. > >>>>> > >>>>> We should be all for this change but probably exempt service classes > >> from > >>>>> it and restrict this change to Helper/Utility classes. Also, it will > be > >>>>> helpful if we bring this about in phases. > >>>>> > >>>>> +1 for helper/utility classes. > >>>>> > >>>>> Best, > >>>>> Girish > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> On Wed, Apr 22, 2020 at 11:55 PM Jacques Le Roux < > >>>>> jacques.le.r...@les7arts.com> wrote: > >>>>> > >>>>>> Le 22/04/2020 à 19:58, Jacques Le Roux a écrit : > >>>>>>> I have still to read the articles an understand the Lombok project > >> and > >>>>>> how we could possibly use it > >>>>>> I'm thinking about https://projectlombok.org/setup/gradle but I > have > >> no > >>>>>> ideas yet to what it entails, someone knows? > >>>>>> > >>>>>> Jacques > >>>>>> > >>>>>> >
Re: Default constructors in JAVA classes
Yes, not much changes to be done after this information from Rishi. Thanks everyone. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Fri, Apr 24, 2020 at 3:22 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Oh indeed, completely forgot about that. So I guess there are not much > changes to do? > > Jacques > > Le 24/04/2020 à 09:43, Rishi Solanki a écrit : > > An effort already done for this cleanup - > > https://issues.apache.org/jira/browse/OFBIZ-7272 > > > > Agree with Girish, we should keep this change for Utility/Helper/Worker > > classes. And exclude services for sure, and if any specific event class > act > > as utility then we can consider it. > > > > Best Regards, > > -- > > Rishi Solanki > > *CTO, Mindpath Technology* > > Intelligent Solutions > > cell: +91-98932-87847 > > LinkedIn <https://www.linkedin.com/in/rishi-solanki-62271b7/> > > > > > > On Thu, Apr 23, 2020 at 12:39 PM Jacques Le Roux < > > jacques.le.r...@les7arts.com> wrote: > > > >> Hi, > >> > >> It was mate, actually there was a missing word in my saying, I meant: > >> > >> I agree about changing only non idempotent classes in a 1st > approach. > >> That's obviously _NOT_ service and events, but could be also few > >> helper and worker classes. > >> > >> All the utility classes should be checked and non idempotent methods (if > >> any) extracted > >> > >> To be clear: an idempotent class is a class which does not change the > >> state. For utilities That depends on its methods not on the class. > >> > >> I agree about steps by steps approach > >> > >> Jacques > >> > >> Le 23/04/2020 à 06:46, Girish Vasmatkar a écrit : > >>> Hi > >>> > >>> I am unsure if this needs to be extended or applied to the service > >> classes > >>> because even though the service classes do not appear to maintain > state, > >>> they conceptually relate to the business domain and hence are not a > >> worthy > >>> candidate. Moreover they are executed within a context and don't > qualify > >> as > >>> typical helper or utility classes. > >>> > >>> We should be all for this change but probably exempt service classes > from > >>> it and restrict this change to Helper/Utility classes. Also, it will be > >>> helpful if we bring this about in phases. > >>> > >>> +1 for helper/utility classes. > >>> > >>> Best, > >>> Girish > >>> > >>> > >>> > >>> > >>> On Wed, Apr 22, 2020 at 11:55 PM Jacques Le Roux < > >>> jacques.le.r...@les7arts.com> wrote: > >>> > >>>> Le 22/04/2020 à 19:58, Jacques Le Roux a écrit : > >>>>> I have still to read the articles an understand the Lombok project > and > >>>> how we could possibly use it > >>>> I'm thinking about https://projectlombok.org/setup/gradle but I have > no > >>>> ideas yet to what it entails, someone knows? > >>>> > >>>> Jacques > >>>> > >>>> >
Re: Valid Item Status for partial shipment
Yes. Adding up to this, in fact, OrderReadHelper.*getItemShippedQuantity* handles *cancelQuantity* effectively. So we can efficiently get desired results using these methods. HTH. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Apr 25, 2020 at 12:19 PM Mridul Pathak < mridul.pat...@hotwaxsystems.com> wrote: > The way order statuses works today seems to be fine, OrderReadHelper has > the necessary methods to get additional details for the order item. > > 1) If order item is partially shipped and remaining quantity is pending > you could get the shipped quantity from OrderReadHelper. Approved status > seems valid here. > > 2) If order item is partially shipped and remaining quantity is cancelled, > the cancelled quantity is stored in OrderItem.cancelQuantity. Again you > could get the shipped quantity and cancelled quantity from OrderReadHelper. > Completed status seems valid here. > > Thanks. > Mridul Pathak > > > > On 25-Apr-2020, at 10:57 AM, Mohammad Kathawala < > mohammad.kathaw...@hotwaxsystems.com> wrote: > > > > Hello Shikha, > > > > The statuses mentioned by you in all the scenarios seem correct to me and > > AFAIK it works in the same way in OFBiz. We can definitely improve it by > > adding a 'Partially Complete/Partially Fulfilled' status to an order item > > as mentioned by Pawan. > > > > Thanks & Regards > > Mohammad Kathawala > > > > On Tue, Apr 14, 2020 at 6:03 PM Suraj Khurana > > wrote: > > > >> Adding Dev ML. > >> > >> -- > >> Best Regards, > >> Suraj Khurana > >> Senior Technical Consultant > >> > >> On Tue, Apr 14, 2020 at 5:13 PM Shikha Jaiswal < > >> shikha.jais...@hotwaxsystems.com> wrote: > >> > >>> Hello team, > >>> > >>> From the business point of view, please share what should be the exact > >>> status of an item after approval, if it is being shipped partially. > >>> > >>> Suppose an order item is of 3 qty and all three are split down into > >>> separate ship groups and shipped one by one, what should be the ideal > >>> status on each following instances, as we maintain item status on > >> OrderItem > >>> level only, not specific to OISGA: > >>> > >>> - One item is shipped, two are pending. > >>> -- IMO, it should be Approved as there are still pending items, please > >>> confirm. > >>> > >>> - Two items are shipped, one is pending. > >>> -- IMO, it should be Approved as there are still pending items, please > >>> confirm. > >>> > >>> - Two items are shipped, one is canceled. > >>> -- IMO, it should be Completed as it is shipped or canceled, please > >>> confirm. > >>> > >>> OR > >>> > >>> - All three items are shipped > >>> -- IMO, it should be Completed as all items are shipped. > >>> > >>> Please let me know your thoughts on this. > >>> > >>> -- > >>> Thanks & Regards, > >>> Shikha Jaiswal > >>> Senior Enterprise Software Engineer > >>> > >> > >
Re: Welcome Swapnil M Mane as new PMC member
Congratulations Swapnil !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Apr 23, 2020 at 5:27 PM Pawan Verma wrote: > Congratulations Swapnil :) > -- > Thanks & Regards > Pawan Verma > ofbiz.apache.org > > > On Thu, Apr 23, 2020 at 5:25 PM Deepak Dixit wrote: > > > Welcome aboard Swapnil M. > > > > Thanks & Regards > > -- > > Deepak Dixit > > ofbiz.apache.org > > > > > > On Thu, Apr 23, 2020 at 5:02 PM Jacques Le Roux < > > jacques.le.r...@les7arts.com> wrote: > > > > > The OFBiz PMC has invited Swapnil M Mane to become member of the > > committee > > > and we are glad to announce that he has accepted the nomination. > > > > > > On behalf of the OFBiz PMC, welcome on board! > > > > > > > > >
Default constructors in JAVA classes
Hello team, While checking codebase using QAPlug [1], it is suggesting to 'Make sure that utility classes (classes that contain only static methods) do not have a public constructor' as an efficiency enhancement. According to it, all our services, events, helper, worker classes which are mostly in JAVA should be having a private constructor and must be defined as 'final' so that the JVM doesn't need to create a data object using that default constructor everytime and supplies which is time taking. Please let me know your thoughts on this. [1]: https://qaplug.com/ -- Best Regards, Suraj Khurana Senior Technical Consultant
Re: Welcome to Vasmatkar as new committer!
Congratulations Girish !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Apr 22, 2020 at 3:11 PM Ashish Vijaywargiya < ashish.vijaywarg...@hotwaxsystems.com> wrote: > Congrats Girish! > > -- > Kind Regards, > Ashish Vijaywargiya > Vice President of Operations > *HotWax Systems* > *Enterprise open source experts* > cell: +91-9893479711 > http://www.hotwaxsystems.com > > > > On Wed, Apr 22, 2020 at 3:09 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has invited Girish to become a new committer and we are > > pleased to announce that he has accepted. > > > > Girish is part of the community for near 2 years and has proposed several > > smart propositions notably related to security and GraphQL, but not only. > > > > Please join me in welcoming and congratulating Girish. > > > > Jacques > > > > > > >
Re: Welcome James Young as new PMC member
Congratulations James !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Apr 22, 2020 at 3:15 PM Ashish Vijaywargiya < ashish.vijaywarg...@hotwaxsystems.com> wrote: > Congrats James! > > -- > Kind Regards, > Ashish Vijaywargiya > Vice President of Operations > *HotWax Systems* > *Enterprise open source experts* > cell: +91-9893479711 > http://www.hotwaxsystems.com > > > > On Wed, Apr 22, 2020 at 2:08 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has invited James Young to become member of the committee > > and we are glad to announce that he has accepted the nomination. > > > > On behalf of the OFBiz PMC, welcome on board! > > > > >
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.03
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Apr 20, 2020 at 2:34 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread to release a new bug fix release for the > release17.12 branch. This new release, "Apache OFBiz 17.12.03" will > supersede the previous release from the same branch. > > The release files can be downloaded from here: > https://dist.apache.org/repos/dist/dev/ofbiz/ > and are: > * apache-ofbiz-17.12.03.zip > * KEYS: text file with keys > * apache-ofbiz-17.12.03.zip.asc: the detached signature file > * apache-ofbiz-17.12.03.zip.sha512: checksum file > > Please download and test the zip file and its signatures (for instructions > on testing the signatures see http://www.apache.org/info/verification.html > ). > > Vote: > [ +1] release as Apache OFBiz 17.12.03 > [ -1] do not release > > This vote will be open for 5 days. > > For more details about this process please refer to > http://www.apache.org/foundation/voting.html > > Best Regards, > > Jacopo >
Re: Valid Item Status for partial shipment
Adding Dev ML. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Apr 14, 2020 at 5:13 PM Shikha Jaiswal < shikha.jais...@hotwaxsystems.com> wrote: > Hello team, > > From the business point of view, please share what should be the exact > status of an item after approval, if it is being shipped partially. > > Suppose an order item is of 3 qty and all three are split down into > separate ship groups and shipped one by one, what should be the ideal > status on each following instances, as we maintain item status on OrderItem > level only, not specific to OISGA: > > - One item is shipped, two are pending. > -- IMO, it should be Approved as there are still pending items, please > confirm. > > - Two items are shipped, one is pending. > -- IMO, it should be Approved as there are still pending items, please > confirm. > > - Two items are shipped, one is canceled. > -- IMO, it should be Completed as it is shipped or canceled, please > confirm. > > OR > > - All three items are shipped > -- IMO, it should be Completed as all items are shipped. > > Please let me know your thoughts on this. > > -- > Thanks & Regards, > Shikha Jaiswal > Senior Enterprise Software Engineer >
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.02
+1 -- Best Regards, Suraj Khurana Senior technical Consultant On Fri, Apr 10, 2020 at 3:36 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread to release a new bug fix release for the > release17.12 branch. This new release, "Apache OFBiz 17.12.02" will > supersede the previous release from the same branch. > > The release files can be downloaded from here: > https://dist.apache.org/repos/dist/dev/ofbiz/ > and are: > * apache-ofbiz-17.12.02.zip > * KEYS: text file with keys > * apache-ofbiz-17.12.02.zip.asc: the detached signature file > * apache-ofbiz-17.12.02.zip.sha512: checksum file > > Please download and test the zip file and its signatures (for instructions > on testing the signatures see http://www.apache.org/info/verification.html > ). > > Vote: > [ +1] release as Apache OFBiz 17.12.02 > [ -1] do not release > > This vote will be open for 5 days. > > For more details about this process please refer to > http://www.apache.org/foundation/voting.html > > Best Regards, > > Jacopo >
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3
+1 -- Best Regards, Suraj Khurana www.hotwax.co On Thu, Feb 27, 2020 at 3:20 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread (3nd attempt) to release "Apache OFBiz 17.12.01": > this is the first release, containing the framework, applications and all > the plugins from the 17.12 release branches. > > The release files can be downloaded from here: > https://dist.apache.org/repos/dist/dev/ofbiz/ > > and are: > * apache-ofbiz-17.12.01.zip > * KEYS: text file with keys > * apache-ofbiz-17.12.01.zip.asc: the detached signature file > * apache-ofbiz-17.12.01.zip.sha512: checksum file > > Please download the zip file, build and test OFBiz and verify the signature > and checksum (for instructions on testing the signatures see > http://www.apache.org/info/verification.html). > > Vote: > > [ +1] release as Apache OFBiz 17.12.01 > [ -1] do not release > > This vote will be open for 5 days. > For more details about this process please read > http://www.apache.org/foundation/voting.html >
Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)
+1 to move these git notifications. We can use notificati...@ofbiz.apache.org for sure, at the same time, we can have a separate list, if required. -- Best Regards, Suraj Khurana www.hotwax.co On Thu, Feb 27, 2020 at 1:48 PM Swapnil M Mane wrote: > Hi team, > Should we move these Git notification to notificati...@ofbiz.apache.org > list [1] that we created in the past to avoid notification traffic on dev > list, thoughts? > > [1] https://s.apache.org/0jdhc > > > Best regards, > Swapnil M Mane, > ofbiz.apache.org > > > > On Wed, Feb 26, 2020 at 3:24 PM GitBox wrote: > > > PierreSmits commented on issue #1: Improved: widget-theme.xsd typos > > (OFBIZ-11421) > > URL: https://github.com/apache/ofbiz-site/pull/1#issuecomment-591338641 > > > > > >Done. > > > > > > This is an automated message from the Apache Git Service. > > To respond to the message, please log on to GitHub and use the > > URL above to go to the specific comment. > > > > For queries about this service, please contact Infrastructure at: > > us...@infra.apache.org > > > > > > With regards, > > Apache Git Services > > >
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #2
+1 for new thread. Thanks Michael for taking care of fixed version/s. -- Best Regards, Suraj Khurana On Wed, Feb 26, 2020 at 10:54 AM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Michael, > > Jacques > > Le 25/02/2020 à 23:06, Michael Brohl a écrit : > > I've changed all 17.12.02 fixes back to 17.12.01. > > > > Michael > > > > > > Am 25.02.20 um 13:22 schrieb Michael Brohl: > >> +1 > >> > >> I already have changed the fix versions to 17.12.02 for fixes after the > dist preparation and would take care of changing them back to 17.12.01 then. > >> > >> Thanks, > >> > >> Michael Brohl > >> > >> ecomify GmbH - www.ecomify.de > >> > >> Am 25.02.20 um 11:48 schrieb Jacopo Cappellato: > >>> Hi all! > >>> > >>> Considering that during the last weekend (because of the Community > Day) a > >>> series of bugs have been fixed in the 17.12 branch [*], I think it > would be > >>> a good idea to cancel this vote, prepare new release files and start a > new > >>> vote thread. Any objections? > >>> > >>> Jacopo > >>> > >>> > >>> [*] https://issues.apache.org/jira/projects/OFBIZ/versions/12347034 > >>> > >>> > >>> On Fri, Feb 21, 2020 at 9:24 AM Jacopo Cappellato < > >>> jacopo.cappell...@gmail.com> wrote: > >>> > >>>> This is the vote thread (2nd attempt) to release "Apache OFBiz > 17.12.01": > >>>> this is the first release, containing the framework, applications and > all > >>>> the plugins from the 17.12 release branches. > >>>> > >>>> The release files can be downloaded from here: > >>>> https://dist.apache.org/repos/dist/dev/ofbiz/ > >>>> > >>>> and are: > >>>> * apache-ofbiz-17.12.01.zip > >>>> * KEYS: text file with keys > >>>> * apache-ofbiz-17.12.01.zip.asc: the detached signature file > >>>> * apache-ofbiz-17.12.01.zip.sha512: checksum file > >>>> > >>>> Please download the zip file, build and test OFBiz and verify the > >>>> signature and checksum (for instructions on testing the signatures see > >>>> http://www.apache.org/info/verification.html). > >>>> > >>>> Vote: > >>>> > >>>> [ +1] release as Apache OFBiz 17.12.01 > >>>> [ -1] do not release > >>>> > >>>> This vote will be open for 4 days. > >>>> For more details about this process please read > >>>> http://www.apache.org/foundation/voting.html > >>>> > >>>> > >> > > >
Re: buildbot exception in on ofbizBranch17FrameworkPlugins
Hello Deepak,
Thanks for taking care of it. Much appreciated.
I think due to same indexes on patch and codebase, patch applied
successfully at different place than expected.
Also, performed build with same procedure on release18.12 and trunk where
everything went flawless, somehow I missed for release17.12.
Sorry for the inconvenience.
--
Best Regards,
Suraj Khurana
On Mon, Feb 24, 2020 at 1:00 AM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> Maybe this needs more explanation for the common good.
>
> The build Deepak used as reference was not at the origin of the issue.
>
> Actually it was
> https://ci.apache.org/builders/ofbizBranch17Framework/builds/407
>
> The reason that the issue also appeared in the build Deepak used as
> reference is because each commit in the framework chains a build in the
> FrameworkPlugins build.
>
> Actually the build above was not only for 1 commit but 4. Because, for
> performance reason, the time between 2 commits to be taken alone is 5
> minutes.
> That can be changed id needed.
>
> For more information please see
> https://svn.apache.org/repos/infra/infrastructure/buildbot/aegis/buildmaster/master1/projects/ofbiz.conf
> and Buildbot
> documentation
>
> HTH
>
> Jacques
>
> Le 23/02/2020 à 14:19, Michael Brohl a écrit :
> > Thanks Deepak,
> >
> > I missed the stdio link at the bottom.
> >
> > Regards,
> >
> > Michael
> >
> >
> > Am 23.02.20 um 14:00 schrieb Deepak Dixit:
> >> Hi Michael,
> >>
> >> Please see the details for failure
> >>
> https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466/steps/shell_1/logs/stdio
> >>
> >> I fixed these errors in commit
> >>
> https://github.com/apache/ofbiz-framework/commit/1a8903e1d529540238798ce234b39c8f45256cb1
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> ofbiz.apache.org
> >>
> >>
> >> On Sun, Feb 23, 2020 at 5:42 PM Michael Brohl >
> >> wrote:
> >>
> >>> Hi Deepak,
> >>>
> >>> the failures in the given buildbot link seem not to match with the
> build
> >>> erros shown below.
> >>>
> >>> Am I missing something or is something wrong with this report?
> >>>
> >>> Thanks,
> >>>
> >>> Michael Brohl
> >>>
> >>> ecomify GmbH - www.ecomify.de
> >>>
> >>>
> >>> Am 23.02.20 um 12:17 schrieb Deepak Dixit:
> >>>> Hi Dev,
> >>>>
> >>>>
> https://ci.apache.org/builders/ofbizBranch17FrameworkPlugins/builds/466
> >>>>
> >>>> Build failing for release 17.12, please be very careful while
> backporting
> >>>> changes to release branches, Please make sure you are
> >>>> verifying changes after merge/backport.
> >>>>
> >>>> Also please check the build boat failure notification, and before
> >>>> committing please run the testIntegration task on local box.
> >>>> ==
> >>>>
> >>>>
> >>>
> :compileJava/home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:452:
>
> >>>
> >>>> error: cannot find symbol
> >>>> .where("userLoginId", userLoginId)
> >>>> ^
> >>>> symbol: variable userLoginId
> >>>> location: class LoginServices
> >>>>
> >>>
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:450:
> >>>> error: cannot find symbol
> >>>> EntityQuery eq = EntityQuery.use(delegator)
> >>>>^
> >>>> symbol: variable delegator
> >>>> location: class LoginServices
> >>>>
> >>>
> /home/buildslave/slave/ofbizBranch17FrameworkPlugins/build/framework/common/src/main/java/org/apache/ofbiz/common/login/LoginServices.java:475:
> >>>> error: cannot find symbol
> >>>> GenericValue userLoginPwdHistToCreate =
> >>>> delegator.makeValue("UserLoginPasswordHistory",
> >>>> UtilMisc.toMap("userLoginId", userLoginId,"fromDate", nowTimestamp));
> >>>>
Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07
+1. Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT On Fri, Jan 31, 2020 at 1:07 PM Swapnil M Mane wrote: > +1 > > Best regards, > Swapnil M Mane, > ofbiz.apache.org > > > > On Thu, Jan 30, 2020 at 7:43 PM Jacopo Cappellato < > jacopo.cappell...@gmail.com> wrote: > > > This is the vote thread to release a new bug fix release for the > > release16.11 branch. This new release, "Apache OFBiz 16.11.07" will > > supersede all the previous releases from the same branch. > > Please consider that this may be the last release in the 16.11 series and > > in the future releases will be published from the newer series only. > > > > The release files can be downloaded from here: > > https://dist.apache.org/repos/dist/dev/ofbiz/ > > > > and are: > > * apache-ofbiz-16.11.07.zip > > * KEYS: text file with keys > > * apache-ofbiz-16.11.07.zip.asc: the detached signature file > > * apache-ofbiz-16.11.07.zip.sha512: checksum file > > > > Please download and test the zip file and its signatures (for > instructions > > on testing the signatures see > http://www.apache.org/info/verification.html > > ). > > > > Vote: > > [ +1] release as Apache OFBiz 16.11.07 > > [ -1] do not release > > > > This vote will be open for 5 days. > > For more details about this process refer to > > http://www.apache.org/foundation/voting.html > > > > Kind Regards, > > > > Jacopo > > >
Re: [VOTE] Do not release R17 and directly publish R18 instead.
-1 Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT On Mon, Jan 27, 2020 at 1:34 PM Deepak Dixit wrote: > -1 > > Kind Regards, > Deepak Dixit > > > On Sun, Jan 26, 2020 at 10:24 PM Martin Becker > wrote: > > > -1 > > > > Martin Becker > > > > > > > > > > On 2020/01/24 10:27:15, Jacques Le Roux wrote: > > > Hi,> > > > > > > R16 is now an old distribution and has almost reached its end of > > support. We can soon expect a last release but we need to think about the > > next to be > > > > released package> > > > > > > Some would prefer to release R17 before releasing R18, some would > prefer > > to bypass R17 release and directly publish R18 instead.> > > > > > > Vote:> > > > [ +1] Do not release R17 and directly publish R18 instead.> > > > [ -1] Release R17 before releasing R18> > > > > > > We had already 3 months to discuss without reaching a consensus, so > this > > vote will be only open for a week.> > > > > > > Note that it's not a formal vote to release R17 or R18, as that is > > another process documented at> > > > > > > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz > > > > > > > > > > Thank you for your attention> > > > > > > Jacques> > > > > > > > > > >
Re: Welcome to Olivier Heintz as new committer!
Many Congratulations, Olivier !! -- Best Regards, Suraj Khurana TECHNICAL CONSULTANT On Fri, Jan 17, 2020 at 6:04 PM Pawan Verma wrote: > Many congratulations Olivier!!! > -- > Thanks & Regards > Pawan Verma > Technical Consultant > *HotWax Systems* > *Enterprise open source experts* > http://www.hotwaxsystems.com > > > On Fri, Jan 17, 2020 at 3:01 PM Swapnil M Mane > wrote: > > > Many congratulations Olivier, welcome aboard!! > > > > Best regards, > > Swapnil M Mane, > > ofbiz.apache.org > > > > > > > > On Thu, Jan 16, 2020 at 7:53 PM Taher Alkhateeb > wrote: > > > > > The OFBiz PMC has invited Olivier Heintz to become a new committer and > > > we are happy to announce that he has accepted this role. > > > > > > Some of the reasons for inviting Olivier Heintz include: > > > > > > - He is invested in the OFBiz project and has been a member for many > > years > > > - He is taking an initiative towards improving the UI part of the > system > > > - He has functional experience in various areas of the framework > > > - He enjoys working with the community and collaborating with others > > > > > > Please join me in welcoming and congratulating Olivier! > > > > > > Cheers, > > > Taher Alkhateeb > > > > > >
Re: ContactNumber optional on service definition
Thanks everyone for your inputs. Here is a case, please check these services 'createUpdateCustomerAndShippingAddress', 'createUpdateBillingAddressAndPaymentMethod'. If we are calling these already available services without contactNumber, as per current flow they will nullify existing contactNumber available, as 'createUpdatePartyTelecomNumber' is being called inside them and if some contact details are found for specific purpose, which might be not passed in context, its gets nullified and customer important data is lost. Either we should fix this issue here, considering it from a generic problem, I would recommend to change the serviceDef and make it work like real situations, not likely to work as per data model flexibilities. Please share you thoughts on this. -- Best Regards, Suraj Khurana TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Mon, Dec 16, 2019 at 11:35 AM Rishi Solanki wrote: > After Michael and Jacques input, I would say no need to change the existing > behavior and in case required then it can be simply taking care by > overriding the service definition in custom project. > So my vote change now, no need to change ootb behavior. > > Best Regards, > -- > Rishi Solanki > *CTO, Mindpath Technology* > Intelligent Solutions > cell: +91-98932-87847 > http://www.mindpathtech.com > > > On Thu, Dec 12, 2019 at 9:21 PM Michael Brohl > wrote: > > > Hi Suraj, > > > > I don't see a reason why we should make this field mandatory. It's one > > of a few other fields in the table. > > > > It *could* be of value to remove the contactNumber, in case this part of > > the number is wrong and should not be displayed as long as it is fixed. > > Or the telecom number ist created and will be updated with the contact > > number later. > > > > The service is used in several other services, that could be a problem > too. > > > > I would not change this until there is a real problem with it being > empty. > > > > Regards, > > > > Michael > > > > > > Am 12.12.19 um 09:22 schrieb Jacques Le Roux: > > > Hi, > > > > > > I tend to agree, I see not reason to have it optional. Now I don't > > > know what it implies in term of related changes, notably for custom > > > projects... > > > > > > All in all I don't see a lot of positive doing so. Did you cross a > > > specific issue Suraj? > > > > > > Jacques > > > > > > Le 03/12/2019 à 16:42, Rishi Solanki a écrit : > > >> Hi Suraj, > > >> It seems writing this service just to wrap the create and update > > >> logic in > > >> one service. So it uses the same IN parameters and constraints as > inner > > >> services have. IMO, we can change the wrapper service behavior based > on > > >> business requirements and override it. > > >> > > >> +1 for changing it. > > >> > > >> Best Regards, > > >> -- > > >> Rishi Solanki > > >> *CTO, Mindpath Technology* > > >> Intelligent Solutions > > >> cell: +91-98932-87847 > > >> > > >> On Tue, Dec 3, 2019 at 8:17 PM Suraj Khurana > > > >> wrote: > > >> > > >>> Hello team, > > >>> > > >>> There is a service named 'createUpdatePartyTelecomNumber' in which > > >>> contactNumber field is optional on service definition. > > >>> From DB fields perspective it seems good to have it optional, > > >>> ideally I > > >>> think it should not. Whether you are creating or updating any party > > >>> telecom > > >>> details, contactNumber should be mandatory because that's the main > > >>> thing to > > >>> be created/updated. > > >>> > > >>> Please share your thoughts, am I missing something? > > >>> > > >>> -- > > >>> Best Regards, > > >>> Suraj Khurana > > >>> Technical Consultant > > >>> *HotWax Systems* > > >>> *Enterprise open source experts* > > >>> cell: 96697-50002 > > >>> http://www.hotwaxsystems.com > > >>> > > > > >
Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members
Many congratulations Gil and Mathieu !! -- Best Regards, Suraj Khurana Technical Consultant HotWax Systems On Wed, Dec 4, 2019 at 1:17 AM sharanf wrote: > Congratulations and welcome Gil and Mathieu! > > Thanks > Sharan > > On 2019-12-03 12:09, Deepak Dixit wrote: > > Welcome aboard! > > Many Many congrats Gil and Mathieu. > > > > Kind Regards, > > Deepak Dixit > > > > > > > > On Tue, Dec 3, 2019 at 3:56 PM Jacopo Cappellato < > > jacopo.cappell...@gmail.com> wrote: > > > >> The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become > >> members of the committee and we are glad to announce that they have > >> accepted the nomination. > >> > >> On behalf of the OFBiz PMC, welcome on board! > >> > >
ContactNumber optional on service definition
Hello team, There is a service named 'createUpdatePartyTelecomNumber' in which contactNumber field is optional on service definition. >From DB fields perspective it seems good to have it optional, ideally I think it should not. Whether you are creating or updating any party telecom details, contactNumber should be mandatory because that's the main thing to be created/updated. Please share your thoughts, am I missing something? -- Best Regards, Suraj Khurana Technical Consultant *HotWax Systems* *Enterprise open source experts* cell: 96697-50002 http://www.hotwaxsystems.com
