[gwt-contrib] Re: RR : Reimplement DevMode JavaScriptObject support (issue473801)
Another iteration of the patch that simplifies the cross-casting of JSO subtype arrays by upcasting all JSO subtype arrays to JavaScriptObject[]. This ensures that array object identity will be preserved, even after an "illegal" cast between incompatible array types. Changes to look at: - Added new rewriting pass RewriteJsoArrays - Methods with JsoSubtype[] parameters have their names mangled - Constructors have a synthetic disambiguator parameter added since we can't change the name. HostedModeClassRewriter.RewriterOracle has a new method to provide the disambiguating ordinal value for naming the type. - Callsites are updated as necessary. - Since this mangles method names or method signatures, I've introduced an @OriginalJsniSignature annotation, which this pass uses to override the reflectively-driven dispatchId assignment. DispatchClassInfo reads this annotation. - Factored out DebugAnalyzerAdapter out of RewriteJsoCasts to share debug logging with RewriteJsoArrays - Removed JsoSubtype array class literal handling in RewriteJsoCasts Unless we're willing to hijack System.arrayCopy() and Collection.toArray(), there's not a lot that can be done about making these work with a source array containing JSO wrappers that are incompatible with the destination array type. http://gwt-code-reviews.appspot.com/473801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Increase logging in JUnitShell and HtmlUnit to provide more diagnostic information during test f... (issue632802)
While you're in here, any chance you could do something more sane to JUnitHostImpl's failure mode when it can't deserialize an exception (this happens 100% of the time when testing with no metadata). http://gwt-code-reviews.appspot.com/632802/diff/1/2 File dev/core/src/com/google/gwt/dev/DevMode.java (right): http://gwt-code-reviews.appspot.com/632802/diff/1/2#newcode428 dev/core/src/com/google/gwt/dev/DevMode.java:428: getTopLogger().log(TreeLogger.ERROR, "Port " I have to agree.. what's the impetus to change having this just spit directly to stderr? http://gwt-code-reviews.appspot.com/632802/diff/1/5 File user/src/com/google/gwt/junit/RunStyleHtmlUnit.java (right): http://gwt-code-reviews.appspot.com/632802/diff/1/5#newcode92 user/src/com/google/gwt/junit/RunStyleHtmlUnit.java:92: } +1 Or else should we be serving up application/javascript these days? http://gwt-code-reviews.appspot.com/632802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8270 committed - Removed the appengine tools-api.jar, no longer needed with appEngine 1...
Revision: 8270 Author: amitman...@google.com Date: Wed Jun 16 16:16:10 2010 Log: Removed the appengine tools-api.jar, no longer needed with appEngine 1.3.4 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8270 Deleted: /trunk/bikeshed/war/temp-libs/appengine-tools-api.jar === --- /trunk/bikeshed/war/temp-libs/appengine-tools-api.jar Mon Jun 7 12:20:31 2010 +++ /dev/null File is too large to display a diff. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8269 committed - Improve wire format for primitive long values. Keep support for the p...
Revision: 8269
Author: r...@google.com
Date: Wed Jun 16 15:55:40 2010
Log: Improve wire format for primitive long values. Keep support for the
previous format in server-side code.
Review at http://gwt-code-reviews.appspot.com/626801
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8269
Modified:
/trunk/dev/core/super/com/google/gwt/lang/LongLib.java
/trunk/dev/core/test/com/google/gwt/lang/LongLibTest.java
/trunk/dev/core/test/com/google/gwt/lang/LongLibTestBase.java
/trunk/user/src/com/google/gwt/rpc/client/impl/CommandClientSerializationStreamReader.java
/trunk/user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java
/trunk/user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java
/trunk/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java
/trunk/user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java
/trunk/user/src/com/google/gwt/user/server/Base64Utils.java
/trunk/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
/trunk/user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java
/trunk/user/test/com/google/gwt/user/server/rpc/RPCTest.java
===
--- /trunk/dev/core/super/com/google/gwt/lang/LongLib.java Mon Jun 7
09:38:44 2010
+++ /trunk/dev/core/super/com/google/gwt/lang/LongLib.java Wed Jun 16
15:55:40 2010
@@ -30,7 +30,9 @@
}
private static LongEmul[] boxedValues;
-
+
+ private static boolean haveNonZero;
+
public static LongEmul add(LongEmul a, LongEmul b) {
int sum0 = getL(a) + getL(b);
int sum1 = getM(a) + getM(b) + (sum0 >> BITS);
@@ -42,12 +44,67 @@
public static LongEmul and(LongEmul a, LongEmul b) {
return create(getL(a) & getL(b), getM(a) & getM(b), getH(a) & getH(b));
}
+
+ /**
+ * Return an optionally single-quoted string containing a base-64 encoded
+ * version of the given long value.
+ */
+ public static String base64Emit(long value, boolean quote) {
+// Convert to ints early to avoid need for long ops
+int low = (int) (value & 0x);
+int high = (int) (value >> 32);
+
+StringBuilder sb = new StringBuilder();
+if (quote) {
+ sb.append('\'');
+}
+haveNonZero = false;
+base64Append(sb, (high >> 28) & 0xf); // bits 63 - 60
+base64Append(sb, (high >> 22) & 0x3f); // bits 59 - 54
+base64Append(sb, (high >> 16) & 0x3f); // bits 53 - 48
+base64Append(sb, (high >> 10) & 0x3f); // bits 47 - 42
+base64Append(sb, (high >> 4) & 0x3f); // bits 41 - 36
+int v = ((high & 0xf) << 2) | ((low >> 30) & 0x3);
+base64Append(sb, v); // bits 35 - 30
+base64Append(sb, (low >> 24) & 0x3f); // bits 29 - 24
+base64Append(sb, (low >> 18) & 0x3f); // bits 23 - 18
+base64Append(sb, (low >> 12) & 0x3f); // bits 17 - 12
+base64Append(sb, (low >> 6) & 0x3f); // bits 11 - 6
+haveNonZero = true; // always emit final digit
+base64Append(sb, low & 0x3f); // bits 5 - 0
+if (quote) {
+ sb.append('\'');
+}
+
+return sb.toString();
+ }
+
+ /**
+ * Parse a string containing a base-64 encoded version of a long value.
+ */
+ public static long base64Parse(String value) {
+int pos = 0;
+char first = value.charAt(pos++);
+int len = value.length();
+
+// Skip surrounding single quotes
+if (first == '\'') {
+ first = value.charAt(pos++);
+ len--;
+}
+long longVal = base64Value(first);
+while (pos < len) {
+ longVal <<= 6;
+ longVal |= base64Value(value.charAt(pos++));
+}
+return longVal;
+ }
/**
* Compare the receiver a to the argument b.
*
* @return 0 if they are the same, a positive value if the receiver is
- * greater, or a negative value if the argument is greater.
+ * greater, or a negative value if the argument is greater.
*/
public static int compare(LongEmul a, LongEmul b) {
int signA = sign(a);
@@ -76,7 +133,7 @@
public static LongEmul div(LongEmul a, LongEmul b) {
return divMod(a, b, false);
}
-
+
public static boolean eq(LongEmul a, LongEmul b) {
return getL(a) == getL(b) && getM(a) == getM(b) && getH(a) == getH(b);
}
@@ -130,7 +187,7 @@
return create(value);
}
-
+
/**
* Return a triple of ints { low, middle, high } that concatenate
bitwise to
* the given number.
@@ -142,7 +199,7 @@
a[2] = (int) ((l >> BITS01) & MASK_2);
return a;
}
-
+
public static boolean gt(LongEmul a, LongEmul b) {
int signa = getH(a) >> (BITS2 - 1);
int signb = getH(b) >> (BITS2 - 1);
@@ -222,7 +279,7 @@
int p2 = a2 * b0; // << 26
int p3 = a3 * b0; // << 39
int p4 = a4 * b0; // << 52
-
+
if (b1 != 0) {
p1 += a0 * b1;
p2 += a1 * b1;
@@ -395,56 +452,96 @@
}
return toDoubleHelper(a);
}
-
+
// Assumes Integer.MIN_VALUE
[gwt-contrib] Re: Increase logging in JUnitShell and HtmlUnit to provide more diagnostic information during test f... (issue632802)
Can you give details about what exactly you want to accomplish? http://gwt-code-reviews.appspot.com/632802/diff/1/2 File dev/core/src/com/google/gwt/dev/DevMode.java (right): http://gwt-code-reviews.appspot.com/632802/diff/1/2#newcode428 dev/core/src/com/google/gwt/dev/DevMode.java:428: getTopLogger().log(TreeLogger.ERROR, "Port " Isn't this already getting logged in the TreeLogger? Having it show up in the console is useful for something that fundamentally means the system can't operate at all. http://gwt-code-reviews.appspot.com/632802/diff/1/3 File dev/core/src/com/google/gwt/dev/DevModeBase.java (right): http://gwt-code-reviews.appspot.com/632802/diff/1/3#newcode1078 dev/core/src/com/google/gwt/dev/DevModeBase.java:1078: getTopLogger().log(TreeLogger.ERROR, "Failed to complete the doSlowStartup method"); This looks like there will be multiple log messages for one failure. Either doSlowStartup should do logging or the caller, but not both (unless you want to create a branch and pass that in). http://gwt-code-reviews.appspot.com/632802/diff/1/5 File user/src/com/google/gwt/junit/RunStyleHtmlUnit.java (right): http://gwt-code-reviews.appspot.com/632802/diff/1/5#newcode92 user/src/com/google/gwt/junit/RunStyleHtmlUnit.java:92: } Should we instead change HtmlUnit to be configurable about these warnings? This seems awfully fragile. http://gwt-code-reviews.appspot.com/632802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Increase logging in JUnitShell and HtmlUnit to provide more diagnostic information during test f... (issue632802)
Reviewers: scottb, jat, Lex, Description: Increase logging in JUnitShell and HtmlUnit to provide more diagnostic information during test failures. Please review this at http://gwt-code-reviews.appspot.com/632802/show Affected files: M dev/core/src/com/google/gwt/dev/DevMode.java M dev/core/src/com/google/gwt/dev/DevModeBase.java M dev/core/src/com/google/gwt/dev/shell/HostedModePluginObject.java M user/src/com/google/gwt/junit/RunStyleHtmlUnit.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
Wait. Seems like the last patch set is failing in web mode (on linux).. I'll have to look into that tomorrow. On Wed, Jun 16, 2010 at 11:15 PM, wrote: > Hopefully there will be no problems with this last patch. :) > > > http://gwt-code-reviews.appspot.com/612802/show > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Add useful hooks into GWT to allow other tools to parse and analyze Java code. (issue631801)
Reviewers: Lex, Description: Add useful hooks into GWT to allow other tools to parse and analyze Java code. Please review this at http://gwt-code-reviews.appspot.com/631801/show Affected files: M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/jjs/UnifiedAst.java A dev/core/test/com/google/gwt/dev/jjs/impl/AdditionalTypeProviderDelegateTest.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
Hopefully there will be no problems with this last patch. :) http://gwt-code-reviews.appspot.com/612802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8267 committed - earlier mirror fix only got the additive changes; here are the subtrac...
Revision: 8267
Author: gwt.mirror...@gmail.com
Date: Wed Jun 16 13:56:33 2010
Log: earlier mirror fix only got the additive changes; here are the
subtractives.
http://code.google.com/p/google-web-toolkit/source/detail?r=8267
Deleted:
/trunk/bikeshed/src/com/google/gwt/app/client/ListBoxPlacePickerView.java
/trunk/bikeshed/src/com/google/gwt/app/util
/trunk/bikeshed/src/com/google/gwt/bikeshed
/trunk/bikeshed/src/com/google/gwt/requestfactory/shared/SyncResult.java
/trunk/bikeshed/src/com/google/gwt/sample/bikeshed/stocks
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/ExpensesDataServlet.java
/trunk/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordEditActivity.java
/trunk/bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListActivity.java
/trunk/bikeshed/war/Stocks.html
/trunk/bikeshed/war/StocksMobile.html
/trunk/dev/core/test/com/google/gwt/dev/resource/impl/testdata/cpe1/com/google/gwt/user/client/empty
/trunk/dev/core/test/com/google/gwt/dev/resource/impl/testdata/cpe1/org/example/bar/server
/trunk/dev/core/test/com/google/gwt/dev/resource/impl/testdata/cpe2/org/example/bar/server
/trunk/doc/src/com
/trunk/plugins/npapi/extension
/trunk/plugins/webkit/oophm.pmdoc
/trunk/plugins/xpcom/prebuilt/extension/lib/Darwin-gcc3/ff2
/trunk/plugins/xpcom/prebuilt/extension/lib/WINNT_x86-msvc/ff2
/trunk/tools/soyc-vis/src
/trunk/user/src/com/google/gwt/uibinder/parsers
/trunk/user/src/com/google/gwt/uibinder/testing
/trunk/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/impl
/trunk/user/test/com/google/gwt/i18n/client/cldr
/trunk/user/test/com/google/gwt/resources/rebind
/trunk/user/test/com/google/gwt/uibinder/parsers
===
---
/trunk/bikeshed/src/com/google/gwt/app/client/ListBoxPlacePickerView.java
Fri May 28 04:09:54 2010
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
- * use this file except in compliance with the License. You may obtain a
copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
under
- * the License.
- */
-package com.google.gwt.app.client;
-
-import com.google.gwt.app.place.Place;
-import com.google.gwt.app.place.PlacePickerView;
-import com.google.gwt.event.logical.shared.ValueChangeEvent;
-import com.google.gwt.event.logical.shared.ValueChangeHandler;
-import com.google.gwt.event.shared.HandlerRegistration;
-import com.google.gwt.user.client.ui.ValueListBox;
-
-/**
- * Hacky ValueListBox based implementation of PlacePickerView, to be
replaced by
- * new data widget, or at least something less ugly.
- *
- * @param the type of places listed
- */
-public class ListBoxPlacePickerView extends
ValueListBox
-implements PlacePickerView {
- private HandlerRegistration handlerRegistration;
-
- /**
- * @return this view
- */
- public ListBoxPlacePickerView asWidget() {
-return this;
- }
-
- /**
- * Set the listener.
- */
- public void setListener(final PlacePickerView.Listener listener) {
-if (handlerRegistration != null) {
- handlerRegistration.removeHandler();
- handlerRegistration = null;
-}
-
-handlerRegistration = addValueChangeHandler(new
ValueChangeHandler() {
- public void onValueChange(ValueChangeEvent event) {
-listener.placePicked(event.getValue());
- }
-});
- }
-}
===
---
/trunk/bikeshed/src/com/google/gwt/requestfactory/shared/SyncResult.java
Fri May 28 08:44:36 2010
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
- * use this file except in compliance with the License. You may obtain a
copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
under
- * the License.
- */
-package com.google.gwt.requestfactory.shared;
-
-import com.google.gwt.valuestore.shared.Record;
-
-import java.util.Map;
-
-/**
- * Result per record of a SyncRequest.
- */
-public interface SyncResult {
- boolean hasViolations();
-
- Record getRecord();
-
- Map getViolations();
-}
===
---
/trunk/bikeshed/src/com/google/gwt/sample/expenses/server/ExpensesD
[gwt-contrib] Re: Improve wire format for primitive long values. Keep support for the previous format in server-s... (issue626801)
LGTM
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
On 2010/06/16 20:13:28, Dan Rice wrote:
Fields in the RPC stream are JS literals that get eval'ed by
ClientSerializationStreamReader.eval. The quotes make it a string
literal. I
can move the quoting login into the RPC code, the cost being spinning
up an
additional StringBuilder.
Ok, from FTF discussion we figured out they aren't needed on C->S
messages because the server is just doing a split, but S->C is processed
by an eval.
http://gwt-code-reviews.appspot.com/626801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Improve wire format for primitive long values. Keep support for the previous format in server-s... (issue626801)
http://gwt-code-reviews.appspot.com/626801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8266 committed - Removed PrintWriterManager from bikeshed and "inlined" its use in bike...
Revision: 8266
Author: amitman...@google.com
Date: Wed Jun 16 10:08:50 2010
Log: Removed PrintWriterManager from bikeshed and "inlined" its use in
bikeshed.
Review at http://gwt-code-reviews.appspot.com/627801
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8266
Deleted:
/trunk/bikeshed/src/com/google/gwt/user/rebind
Modified:
/trunk/bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java
/trunk/bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
===
---
/trunk/bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java
Wed Jun 16 08:14:54 2010
+++
/trunk/bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java
Wed Jun 16 10:08:50 2010
@@ -34,7 +34,6 @@
import com.google.gwt.user.client.ui.HasText;
import com.google.gwt.user.client.ui.TakesValue;
import com.google.gwt.user.rebind.ClassSourceFileComposerFactory;
-import com.google.gwt.user.rebind.PrintWriterManager;
import com.google.gwt.user.rebind.SourceWriter;
import com.google.gwt.valuestore.shared.Property;
@@ -120,15 +119,12 @@
interfaceType, logger);
String implName = getImplName(superinterfaceType);
String packageName = interfaceType.getPackage().getName();
-PrintWriterManager printWriters = new
PrintWriterManager(generatorContext,
-logger, packageName);
-PrintWriter out = printWriters.tryToMakePrintWriterFor(implName);
-
+
+PrintWriter out = generatorContext.tryCreate(logger, packageName,
implName);
// If an implementation already exists, we don't need to do any work
if (out != null) {
generateOnce(logger, generatorContext, out, interfaceType,
packageName,
implName, superinterfaceType);
- printWriters.commit();
}
return packageName + "." + implName;
@@ -190,6 +186,7 @@
sw.outdent();
sw.println("}");
+generatorContext.commit(logger, out);
}
private Collection getAccessibleMethods(JClassType classType) {
===
---
/trunk/bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
Wed Jun 16 08:14:54 2010
+++
/trunk/bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java
Wed Jun 16 10:08:50 2010
@@ -40,7 +40,6 @@
import com.google.gwt.requestfactory.shared.ServerOperation;
import com.google.gwt.requestfactory.shared.impl.RequestDataManager;
import com.google.gwt.user.rebind.ClassSourceFileComposerFactory;
-import com.google.gwt.user.rebind.PrintWriterManager;
import com.google.gwt.user.rebind.SourceWriter;
import com.google.gwt.valuestore.shared.Property;
import com.google.gwt.valuestore.shared.Record;
@@ -95,16 +94,15 @@
}
String packageName = interfaceType.getPackage().getName();
-PrintWriterManager printWriters = new
PrintWriterManager(generatorContext,
-logger, packageName);
+
// the replace protects against inner classes
String implName = interfaceType.getName().replace('.', '_') + "Impl";
-PrintWriter out = printWriters.tryToMakePrintWriterFor(implName);
+PrintWriter out = generatorContext.tryCreate(logger, packageName,
implName);
// If an implementation already exists, we don't need to do any work
if (out != null) {
- generateOnce(logger, generatorContext, printWriters, out,
interfaceType,
- packageName, implName);
+ generateOnce(logger, generatorContext, out, interfaceType,
packageName,
+ implName);
}
return packageName + "." + implName;
@@ -120,9 +118,8 @@
}
private void ensureRecordType(TreeLogger logger,
- GeneratorContext generatorContext, PrintWriterManager printWriters,
- String packageName, JClassType publicRecordType)
- throws UnableToCompleteException {
+ GeneratorContext generatorContext, String packageName,
+ JClassType publicRecordType) throws UnableToCompleteException {
TypeOracle typeOracle = generatorContext.getTypeOracle();
if
(!publicRecordType.isAssignableTo(typeOracle.findType(Record.class.getName(
{
@@ -134,8 +131,8 @@
}
String recordImplTypeName = publicRecordType.getName() + "Impl";
-PrintWriter pw =
printWriters.tryToMakePrintWriterFor(recordImplTypeName);
-
+PrintWriter pw = generatorContext.tryCreate(logger, packageName,
+recordImplTypeName);
if (pw != null) {
logger = logger.branch(TreeLogger.DEBUG, "Generating "
+ publicRecordType.getName());
@@ -215,15 +212,16 @@
sw.outdent();
sw.println("}");
+ generatorContext.commit(logger, pw);
}
generatedRecordTypes.add(publicRecordType);
}
private void generateOnce(TreeLogger logger,
- GeneratorContext generatorContext, PrintWriterManager printWriters,
- PrintWriter out, JClassType interfaceType, String packageName,
- String implName) throws UnableToCompleteExcep
[gwt-contrib] Re: Improve wire format for primitive long values. Keep support for the previous format in server-s... (issue626801)
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
Fields in the RPC stream are JS literals that get eval'ed by
ClientSerializationStreamReader.eval. The quotes make it a string
literal. I can move the quoting login into the RPC code, the cost being
spinning up an additional StringBuilder.
On 2010/06/16 19:27:00, jat wrote:
Why do we need quotes?
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode354
dev/core/super/com/google/gwt/lang/LongLib.java:354:
Fixed.
On 2010/06/16 19:27:00, jat wrote:
Spaces.
http://gwt-code-reviews.appspot.com/626801/diff/1/3
File dev/core/test/com/google/gwt/lang/LongLibTest.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/3#newcode451
dev/core/test/com/google/gwt/lang/LongLibTest.java:451:
Fixed.
On 2010/06/16 19:27:00, jat wrote:
Spaces.
http://gwt-code-reviews.appspot.com/626801/diff/1/3#newcode608
dev/core/test/com/google/gwt/lang/LongLibTest.java:608:
Fixed.
On 2010/06/16 19:27:00, jat wrote:
Spaces.
http://gwt-code-reviews.appspot.com/626801/diff/1/11
File
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
(right):
http://gwt-code-reviews.appspot.com/626801/diff/1/11#newcode437
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java:437:
+ SERIALIZATION_STREAM_VERSION_5 + " or "
I'm mostly concerned with the case that an existing (cached) client
tries to communicate with new server code.
On 2010/06/16 19:27:00, jat wrote:
This looks like it will get ugly if we start supporting a wider
version range.
I suggest having *_MIN_VERSION and *_MAX_VERSION and making sure the
client's
version is in the range instead.
Also, I am not positive we need to support multiple versions, since it
is
unlikely that the RPC signatures haven't changed at all while the
client was
recompiled with a new RPC wire format.
However, I think we may be doing things that make it more likely to do
this and
I don't think anything here is particularly expensive, so I am fine
with having
the server support multiple versions.
http://gwt-code-reviews.appspot.com/626801/diff/1/13
File user/test/com/google/gwt/user/server/rpc/RPCTest.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/13#newcode208
user/test/com/google/gwt/user/server/rpc/RPCTest.java:208: +
"|echo|J|1|2|3|4|1|5|'P7cuph2VDIQ'|";
In order for it to parse as a JS literal in
ClientSerializationStreamReader.eval.
On 2010/06/16 19:27:00, jat wrote:
Likewise here.
Why do we need quotes around the base64 value?
http://gwt-code-reviews.appspot.com/626801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Removed PrintWriterManager from bikeshed and "inlined" its use in bikeshed. (issue627801)
LGTM -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
I'm willing to live with that risk. It's already kind of crazily belts-and-suspenders to have all the redundant invocations of PanelTestBase via subclass. It would make more sense to just test Panel directly, and rely on subclasses that override the bits it tests to provide their own tests for their new code paths. But today isn't the day to change that. By that reasoning, since RootPanel just inherits the default behavior, it should be satisfied with the default coverage. http://gwt-code-reviews.appspot.com/612802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Removed PrintWriterManager from bikeshed and "inlined" its use in bikeshed. (issue627801)
Reviewers: Ray Ryan, Description: Removed PrintWriterManager from bikeshed and "inlined" its use in bikeshed. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/627801/show Affected files: M bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java M bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java D bikeshed/src/com/google/gwt/user/rebind/PrintWriterManager.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002
File user/test/com/google/gwt/user/client/ui/PanelTestBase.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002#newcode35
user/test/com/google/gwt/user/client/ui/PanelTestBase.java:35: public
void testClear() {
Should I place the equivalent tests to the RootPanelTest? If they are
found only here there is a small chance that some change might get into
RootPanel undetected?
On 2010/06/16 19:26:31, markovuksanovic wrote:
right :-)
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8265 committed - Moving this chang over from the IO branch (the other logging change ha...
Revision: 8265
Author: unn...@google.com
Date: Wed Jun 16 09:32:10 2010
Log: Moving this chang over from the IO branch (the other logging change
had to be moved first)
A clean move.
Review by: sp...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8265
Added:
/trunk/user/src/com/google/gwt/logging/client/LoggingPopup.java
Deleted:
/trunk/user/src/com/google/gwt/logging/client/BasicLoggingPopup.java
Modified:
/trunk/user/src/com/google/gwt/logging/Logging.gwt.xml
===
--- /dev/null
+++ /trunk/user/src/com/google/gwt/logging/client/LoggingPopup.java Wed Jun
16 09:32:10 2010
@@ -0,0 +1,195 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+
+package com.google.gwt.logging.client;
+
+import com.google.gwt.event.dom.client.ClickEvent;
+import com.google.gwt.event.dom.client.ClickHandler;
+import com.google.gwt.event.dom.client.HasAllMouseHandlers;
+import com.google.gwt.event.dom.client.MouseDownEvent;
+import com.google.gwt.event.dom.client.MouseDownHandler;
+import com.google.gwt.event.dom.client.MouseMoveEvent;
+import com.google.gwt.event.dom.client.MouseMoveHandler;
+import com.google.gwt.event.dom.client.MouseUpEvent;
+import com.google.gwt.event.dom.client.MouseUpHandler;
+import com.google.gwt.user.client.DOM;
+import com.google.gwt.user.client.ui.Button;
+import com.google.gwt.user.client.ui.HTML;
+import com.google.gwt.user.client.ui.HasHorizontalAlignment;
+import com.google.gwt.user.client.ui.HasVerticalAlignment;
+import com.google.gwt.user.client.ui.HorizontalPanel;
+import com.google.gwt.user.client.ui.PopupPanel;
+import com.google.gwt.user.client.ui.RootPanel;
+import com.google.gwt.user.client.ui.ScrollPanel;
+import com.google.gwt.user.client.ui.VerticalPanel;
+import com.google.gwt.user.client.ui.Widget;
+
+/**
+ * A simple popup to show log messages, which can be resized, minimized,
and
+ * dragged to a different location.
+ */
+public class LoggingPopup extends PopupPanel {
+
+ /**
+ * Handles the logic to track click-drag movements with the mouse
+ */
+ private abstract class MouseDragHandler implements MouseMoveHandler,
+ MouseUpHandler, MouseDownHandler {
+protected boolean dragging = false;
+protected Widget dragHandle;
+protected int dragStartX;
+protected int dragStartY;
+
+public MouseDragHandler(Widget dragHandle) {
+ this.dragHandle = dragHandle;
+ HasAllMouseHandlers hamh = (HasAllMouseHandlers) dragHandle;
+ hamh.addMouseDownHandler(this);
+ hamh.addMouseUpHandler(this);
+ hamh.addMouseMoveHandler(this);
+}
+
+public abstract void handleDrag(int absX, int absY);
+
+public void onMouseDown(MouseDownEvent event) {
+ dragging = true;
+ DOM.setCapture(dragHandle.getElement());
+ dragStartX = event.getClientX();
+ dragStartY = event.getClientY();
+ DOM.eventPreventDefault(DOM.eventGetCurrentEvent());
+}
+
+public void onMouseMove(MouseMoveEvent event) {
+ if (dragging) {
+handleDrag(event.getClientX() - dragStartX,
+event.getClientY() - dragStartY);
+dragStartX = event.getClientX();
+dragStartY = event.getClientY();
+ }
+}
+
+public void onMouseUp(MouseUpEvent event) {
+ dragging = false;
+ DOM.releaseCapture(dragHandle.getElement());
+}
+ }
+
+ private static class ScrollPanelWithMinSize extends ScrollPanel {
+private int minScrollPanelHeight = 100;
+private int minScrollPanelWidth = 100;
+private int scrollPanelHeight;
+private int scrollPanelWidth;
+
+public void incrementPixelSize(int width, int height) {
+ setPixelSize(scrollPanelWidth + width, scrollPanelHeight + height);
+}
+
+@Override
+public void setPixelSize(int width, int height) {
+ super.setPixelSize(scrollPanelWidth = Math.max(width,
minScrollPanelWidth),
+ scrollPanelHeight = Math.max(height, minScrollPanelHeight));
+}
+ }
+
+ private class WindowMoveHandler extends MouseDragHandler {
+public WindowMoveHandler(Widget dragHandle) {
+ super(dragHandle);
+}
+
+@Override
+public void handleDrag(int absX, int absY) {
+ Widget moveTarget = LoggingPopup.this;
+ RootPanel.get().setWidgetPosition(moveTarget,
+ moveTarget.getAbsoluteLeft() + absX,
+ moveTarget.getAbsoluteTop() + absY);
+}
+ }
+
+ private class WindowResi
[gwt-contrib] Re: Improve wire format for primitive long values. Keep support for the previous format in server-s... (issue626801)
LGTM with nits.
http://gwt-code-reviews.appspot.com/626801/diff/1/2
File dev/core/super/com/google/gwt/lang/LongLib.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode58
dev/core/super/com/google/gwt/lang/LongLib.java:58: sb.append('\'');
Why do we need quotes?
http://gwt-code-reviews.appspot.com/626801/diff/1/2#newcode354
dev/core/super/com/google/gwt/lang/LongLib.java:354:
Spaces.
http://gwt-code-reviews.appspot.com/626801/diff/1/3
File dev/core/test/com/google/gwt/lang/LongLibTest.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/3#newcode451
dev/core/test/com/google/gwt/lang/LongLibTest.java:451:
Spaces.
http://gwt-code-reviews.appspot.com/626801/diff/1/3#newcode608
dev/core/test/com/google/gwt/lang/LongLibTest.java:608:
Spaces.
http://gwt-code-reviews.appspot.com/626801/diff/1/11
File
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java
(right):
http://gwt-code-reviews.appspot.com/626801/diff/1/11#newcode437
user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java:437:
+ SERIALIZATION_STREAM_VERSION_5 + " or "
This looks like it will get ugly if we start supporting a wider version
range. I suggest having *_MIN_VERSION and *_MAX_VERSION and making sure
the client's version is in the range instead.
Also, I am not positive we need to support multiple versions, since it
is unlikely that the RPC signatures haven't changed at all while the
client was recompiled with a new RPC wire format.
However, I think we may be doing things that make it more likely to do
this and I don't think anything here is particularly expensive, so I am
fine with having the server support multiple versions.
http://gwt-code-reviews.appspot.com/626801/diff/1/13
File user/test/com/google/gwt/user/server/rpc/RPCTest.java (right):
http://gwt-code-reviews.appspot.com/626801/diff/1/13#newcode199
user/test/com/google/gwt/user/server/rpc/RPCTest.java:199: +
"|echo|J|1|2|3|4|1|5|1.985229328E9|-8.1985531201716224E16|";
Please expand this like the V4 request so the fields can be commented.
http://gwt-code-reviews.appspot.com/626801/diff/1/13#newcode208
user/test/com/google/gwt/user/server/rpc/RPCTest.java:208: +
"|echo|J|1|2|3|4|1|5|'P7cuph2VDIQ'|";
Likewise here.
Why do we need quotes around the base64 value?
http://gwt-code-reviews.appspot.com/626801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002
File user/test/com/google/gwt/user/client/ui/PanelTestBase.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002#newcode35
user/test/com/google/gwt/user/client/ui/PanelTestBase.java:35: public
void testClear() {
right :-)
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002
File user/test/com/google/gwt/user/client/ui/PanelTestBase.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/8001/9002#newcode35
user/test/com/google/gwt/user/client/ui/PanelTestBase.java:35: public
void testClear() {
Thanks for the move, but the intent was to have them run against each
panel subclass whose test extends this one, not to run the same test
over and over again against RootPanel. They should be using
createPanel()
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
I have moved the test to PanelTestBase class. I have also tried to subclass the RootPanelTest from the PanelTestClass but got the following error estcase: testAttachDetachOrder took 301.037 sec Caused an ERROR The browser did not complete the test method com.google.gwt.user.User.JUnit:com.google.gwt.user.client.ui.RootPanelTest.testAttachDetachOrder in 30ms. We have no results from: 127.0.1.1 / Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 Actual time elapsed: 301.034 seconds. com.google.gwt.junit.client.TimeoutException: The browser did not complete the test method com.google.gwt.user.User.JUnit:com.google.gwt.user.client.ui.RootPanelTest.testAttachDetachOrder in 30ms. We have no results from: 127.0.1.1 / Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1 Actual time elapsed: 301.034 seconds. at com.google.gwt.junit.JUnitShell.notDone(JUnitShell.java:1013) at com.google.gwt.junit.JUnitShell.runTestImpl(JUnitShell.java:1342) at com.google.gwt.junit.JUnitShell.runTestImpl(JUnitShell.java:1270) at com.google.gwt.junit.JUnitShell.runTest(JUnitShell.java:620) at com.google.gwt.junit.client.GWTTestCase.runTest(GWTTestCase.java:456) at com.google.gwt.junit.client.GWTTestCase.run(GWTTestCase.java:311) And all the tests after that failed. I used test.dev.htmlunit task. http://gwt-code-reviews.appspot.com/612802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Improve wire format for primitive long values. Keep support for the previous format in server-s... (issue626801)
Reviewers: jat, Description: Improve wire format for primitive long values. Keep support for the previous format in server-side code. Please review this at http://gwt-code-reviews.appspot.com/626801/show Affected files: M dev/core/super/com/google/gwt/lang/LongLib.java M dev/core/test/com/google/gwt/lang/LongLibTest.java M dev/core/test/com/google/gwt/lang/LongLibTestBase.java M user/src/com/google/gwt/rpc/client/impl/CommandClientSerializationStreamReader.java M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStream.java M user/src/com/google/gwt/user/client/rpc/impl/AbstractSerializationStreamWriter.java M user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamReader.java M user/src/com/google/gwt/user/client/rpc/impl/ClientSerializationStreamWriter.java M user/src/com/google/gwt/user/server/Base64Utils.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java M user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamWriter.java M user/test/com/google/gwt/user/server/rpc/RPCTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8264 committed - Deleted HasPages, HasValueMap, and ValueListBox since they are not bei...
Revision: 8264
Author: amitman...@google.com
Date: Wed Jun 16 08:40:15 2010
Log: Deleted HasPages, HasValueMap, and ValueListBox since they are not
being used.
Review at http://gwt-code-reviews.appspot.com/619802
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8264
Deleted:
/trunk/bikeshed/src/com/google/gwt/user/client/ui/HasPages.java
/trunk/bikeshed/src/com/google/gwt/user/client/ui/HasValueMap.java
/trunk/bikeshed/src/com/google/gwt/user/client/ui/ValueListBox.java
===
--- /trunk/bikeshed/src/com/google/gwt/user/client/ui/HasPages.java Fri
Apr 9 11:25:51 2010
+++ /dev/null
@@ -1,42 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
- * use this file except in compliance with the License. You may obtain a
copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
under
- * the License.
- */
-package com.google.gwt.user.client.ui;
-
-import com.google.gwt.event.shared.HandlerRegistration;
-
-/**
- * Implemented by objects that can be paged through.
- *
- * Note that there are no listeners for the numberOfPages property,
- * as that is not expected to be set by the user.
- */
-public interface HasPages {
- HandlerRegistration addPageChangeHandler(/* PageChangeHandler handler
*/);
-
- HandlerRegistration addPageSizeChangeHandler(/* PageSizeChangeHandler
handler */);
-
- int getCurrentPage();
-
- int getNumberOfPages();
-
- int getPageSize();
-
- void setCurrentPage(int page);
-
- void setNumberOfPages();
-
- void setPageSize(int size);
-}
===
--- /trunk/bikeshed/src/com/google/gwt/user/client/ui/HasValueMap.java Fri
Apr 9 11:25:51 2010
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
- * use this file except in compliance with the License. You may obtain a
copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
under
- * the License.
- */
-package com.google.gwt.user.client.ui;
-
-import java.util.Map;
-
-/**
- * Implemented by widgets that let the user pick from a set
- * of values.
- *
- * @param the value type
- */
-public interface HasValueMap {
- /**
- * @param values A map of acceptable values and their display strings
- */
- void setValues(Map values);
-}
===
--- /trunk/bikeshed/src/com/google/gwt/user/client/ui/ValueListBox.java Fri
May 28 04:09:54 2010
+++ /dev/null
@@ -1,111 +0,0 @@
-/*
- * Copyright 2010 Google Inc.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may
not
- * use this file except in compliance with the License. You may obtain a
copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations
under
- * the License.
- */
-package com.google.gwt.user.client.ui;
-
-import com.google.gwt.event.dom.client.ChangeEvent;
-import com.google.gwt.event.dom.client.ChangeHandler;
-import com.google.gwt.event.logical.shared.ValueChangeEvent;
-import com.google.gwt.event.logical.shared.ValueChangeHandler;
-import com.google.gwt.event.shared.HandlerRegistration;
-
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.Map;
-
-/**
- * A {...@link HasValue} variation on {...@link ListBox}.
- *
- * @param the value type
- */
-public class ValueListBox extends Composite implements HasValue,
-HasValueMap {
-
- private ArrayList indexToValue = new ArrayList();
- private Map valueToIndex = new HashMap();
-
- public ValueListBox() {
-initWidget(new ListBox(false));
- }
-
- public HandlerRegistration addValueChangeHandler(ValueChangeHandler
handler) {
-return addHandler(handler, ValueChangeEvent.getType());
- }
-
- public T getValue() {
-int selectedIndex = getListBox().getSelectedIndex();
-if (selectedIndex > -1) {
- return indexToValue.get(selectedIndex);
-}
-
-re
[gwt-contrib] Re: Deleted HasPages, HasValueMap, and ValueListBox since they are not being used. (issue619802)
LGTM http://gwt-code-reviews.appspot.com/619802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Deleted HasPages, HasValueMap, and ValueListBox since they are not being used. (issue619802)
Reviewers: Ray Ryan, Description: Deleted HasPages, HasValueMap, and ValueListBox since they are not being used. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/619802/show Affected files: D bikeshed/src/com/google/gwt/user/client/ui/HasPages.java D bikeshed/src/com/google/gwt/user/client/ui/HasValueMap.java D bikeshed/src/com/google/gwt/user/client/ui/ValueListBox.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8263 committed - Added a warning to the javadoc of each src file and to package.html in...
Revision: 8263 Author: amitman...@google.com Date: Wed Jun 16 08:14:54 2010 Log: Added a warning to the javadoc of each src file and to package.html in the app, requestfactory, and valuestore modules. Review at http://gwt-code-reviews.appspot.com/625801 Review by: rj...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=8263 Modified: /trunk/bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java /trunk/bikeshed/src/com/google/gwt/app/client/EditorSupport.java /trunk/bikeshed/src/com/google/gwt/app/client/NotificationMole.java /trunk/bikeshed/src/com/google/gwt/app/client/package.html /trunk/bikeshed/src/com/google/gwt/app/package.html /trunk/bikeshed/src/com/google/gwt/app/place/AbstractActivity.java /trunk/bikeshed/src/com/google/gwt/app/place/AbstractRecordEditActivity.java /trunk/bikeshed/src/com/google/gwt/app/place/AbstractRecordListActivity.java /trunk/bikeshed/src/com/google/gwt/app/place/Activity.java /trunk/bikeshed/src/com/google/gwt/app/place/ActivityManager.java /trunk/bikeshed/src/com/google/gwt/app/place/ActivityMapper.java /trunk/bikeshed/src/com/google/gwt/app/place/Place.java /trunk/bikeshed/src/com/google/gwt/app/place/PlaceChangeEvent.java /trunk/bikeshed/src/com/google/gwt/app/place/PlaceChangeRequestedEvent.java /trunk/bikeshed/src/com/google/gwt/app/place/PlaceController.java /trunk/bikeshed/src/com/google/gwt/app/place/PlacePicker.java /trunk/bikeshed/src/com/google/gwt/app/place/PlacePickerView.java /trunk/bikeshed/src/com/google/gwt/app/place/package.html /trunk/bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java /trunk/bikeshed/src/com/google/gwt/app/rebind/package.html /trunk/bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/client/impl/ClientRequestHelper.java /trunk/bikeshed/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java /trunk/bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java /trunk/bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java /trunk/bikeshed/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java /trunk/bikeshed/src/com/google/gwt/requestfactory/server/package.html /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/Id.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/Receiver.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/RecordListRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/RecordRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/RequestEvent.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/ServerOperation.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/ServerType.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/SyncRequest.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/Version.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/impl/RequestDataManager.java /trunk/bikeshed/src/com/google/gwt/requestfactory/shared/package.html /trunk/bikeshed/src/com/google/gwt/valuestore/client/DeltaValueStoreJsonImpl.java /trunk/bikeshed/src/com/google/gwt/valuestore/client/RecordKey.java /trunk/bikeshed/src/com/google/gwt/valuestore/client/SyncResultImpl.java /trunk/bikeshed/src/com/google/gwt/valuestore/client/ValueStoreJsonImpl.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/DeltaValueStore.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/Property.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/PropertyReference.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/Record.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/RecordChangedEvent.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/SyncResult.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/Value.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/ValueStore.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/WriteOperation.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordImpl.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordJsoImpl.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordSchema.java /trunk/bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordToTypeMap.java /trunk/bikeshed/src/com/google/gwt/val
[gwt-contrib] Re: Added a warning to the javadoc of each src file and to package.html in the app, requestfactory, ... (issue625801)
LGTM On Wed, Jun 16, 2010 at 10:57 AM, wrote: > Reviewers: Ray Ryan, > > Description: > Added a warning to the javadoc of each src file and to package.html in > the app, requestfactory, and valuestore modules. > > Review by: rj...@google.com > > Please review this at http://gwt-code-reviews.appspot.com/625801/show > > Affected files: > M bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java > M bikeshed/src/com/google/gwt/app/client/EditorSupport.java > M bikeshed/src/com/google/gwt/app/client/NotificationMole.java > M bikeshed/src/com/google/gwt/app/client/package.html > M bikeshed/src/com/google/gwt/app/package.html > M bikeshed/src/com/google/gwt/app/place/AbstractActivity.java > M bikeshed/src/com/google/gwt/app/place/AbstractRecordEditActivity.java > M bikeshed/src/com/google/gwt/app/place/AbstractRecordListActivity.java > M bikeshed/src/com/google/gwt/app/place/Activity.java > M bikeshed/src/com/google/gwt/app/place/ActivityManager.java > M bikeshed/src/com/google/gwt/app/place/ActivityMapper.java > M bikeshed/src/com/google/gwt/app/place/Place.java > M bikeshed/src/com/google/gwt/app/place/PlaceChangeEvent.java > M bikeshed/src/com/google/gwt/app/place/PlaceChangeRequestedEvent.java > M bikeshed/src/com/google/gwt/app/place/PlaceController.java > M bikeshed/src/com/google/gwt/app/place/PlacePicker.java > M bikeshed/src/com/google/gwt/app/place/PlacePickerView.java > M bikeshed/src/com/google/gwt/app/place/package.html > M bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java > M bikeshed/src/com/google/gwt/app/rebind/package.html > M > bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java > M > bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java > M > bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java > M > bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java > M > bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java > M > bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java > M > bikeshed/src/com/google/gwt/requestfactory/client/impl/ClientRequestHelper.java > M > bikeshed/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java > M > bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java > M > bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java > M > bikeshed/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java > M bikeshed/src/com/google/gwt/requestfactory/server/package.html > M bikeshed/src/com/google/gwt/requestfactory/shared/Id.java > M bikeshed/src/com/google/gwt/requestfactory/shared/Receiver.java > M bikeshed/src/com/google/gwt/requestfactory/shared/RecordListRequest.java > M bikeshed/src/com/google/gwt/requestfactory/shared/RecordRequest.java > M bikeshed/src/com/google/gwt/requestfactory/shared/RequestEvent.java > M bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java > M bikeshed/src/com/google/gwt/requestfactory/shared/ServerOperation.java > M bikeshed/src/com/google/gwt/requestfactory/shared/ServerType.java > M bikeshed/src/com/google/gwt/requestfactory/shared/SyncRequest.java > M bikeshed/src/com/google/gwt/requestfactory/shared/Version.java > M > bikeshed/src/com/google/gwt/requestfactory/shared/impl/RequestDataManager.java > M bikeshed/src/com/google/gwt/requestfactory/shared/package.html > M > bikeshed/src/com/google/gwt/valuestore/client/DeltaValueStoreJsonImpl.java > M bikeshed/src/com/google/gwt/valuestore/client/RecordKey.java > M bikeshed/src/com/google/gwt/valuestore/client/SyncResultImpl.java > M bikeshed/src/com/google/gwt/valuestore/client/ValueStoreJsonImpl.java > M bikeshed/src/com/google/gwt/valuestore/shared/DeltaValueStore.java > M bikeshed/src/com/google/gwt/valuestore/shared/Property.java > M bikeshed/src/com/google/gwt/valuestore/shared/PropertyReference.java > M bikeshed/src/com/google/gwt/valuestore/shared/Record.java > M bikeshed/src/com/google/gwt/valuestore/shared/RecordChangedEvent.java > M bikeshed/src/com/google/gwt/valuestore/shared/SyncResult.java > M bikeshed/src/com/google/gwt/valuestore/shared/Value.java > M bikeshed/src/com/google/gwt/valuestore/shared/ValueStore.java > M bikeshed/src/com/google/gwt/valuestore/shared/WriteOperation.java > M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordImpl.java > M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordJsoImpl.java > M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordSchema.java > M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordToTypeMap.java > M bikeshed/src/com/google/gwt/valuestore/shared/package.html > M bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java > M bikeshed/src/com/google/gwt/valuestore/ui/PropertyColumn.java > M bikeshed/src/com/google/gwt/valuestore/ui/PropertyView.java > M
[gwt-contrib] Added a warning to the javadoc of each src file and to package.html in the app, requestfactory, ... (issue625801)
Reviewers: Ray Ryan, Description: Added a warning to the javadoc of each src file and to package.html in the app, requestfactory, and valuestore modules. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/625801/show Affected files: M bikeshed/src/com/google/gwt/app/client/CellListPlacePickerView.java M bikeshed/src/com/google/gwt/app/client/EditorSupport.java M bikeshed/src/com/google/gwt/app/client/NotificationMole.java M bikeshed/src/com/google/gwt/app/client/package.html M bikeshed/src/com/google/gwt/app/package.html M bikeshed/src/com/google/gwt/app/place/AbstractActivity.java M bikeshed/src/com/google/gwt/app/place/AbstractRecordEditActivity.java M bikeshed/src/com/google/gwt/app/place/AbstractRecordListActivity.java M bikeshed/src/com/google/gwt/app/place/Activity.java M bikeshed/src/com/google/gwt/app/place/ActivityManager.java M bikeshed/src/com/google/gwt/app/place/ActivityMapper.java M bikeshed/src/com/google/gwt/app/place/Place.java M bikeshed/src/com/google/gwt/app/place/PlaceChangeEvent.java M bikeshed/src/com/google/gwt/app/place/PlaceChangeRequestedEvent.java M bikeshed/src/com/google/gwt/app/place/PlaceController.java M bikeshed/src/com/google/gwt/app/place/PlacePicker.java M bikeshed/src/com/google/gwt/app/place/PlacePickerView.java M bikeshed/src/com/google/gwt/app/place/package.html M bikeshed/src/com/google/gwt/app/rebind/EditorSupportGenerator.java M bikeshed/src/com/google/gwt/app/rebind/package.html M bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractDoubleRequest.java M bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractIntegerRequest.java M bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractJsonListRequest.java M bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractJsonObjectRequest.java M bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractLongRequest.java M bikeshed/src/com/google/gwt/requestfactory/client/impl/AbstractRequest.java M bikeshed/src/com/google/gwt/requestfactory/client/impl/ClientRequestHelper.java M bikeshed/src/com/google/gwt/requestfactory/client/impl/RequestFactoryJsonImpl.java M bikeshed/src/com/google/gwt/requestfactory/rebind/RequestFactoryGenerator.java M bikeshed/src/com/google/gwt/requestfactory/server/RequestFactoryServlet.java M bikeshed/src/com/google/gwt/requestfactory/server/SampleDataPopulator.java M bikeshed/src/com/google/gwt/requestfactory/server/package.html M bikeshed/src/com/google/gwt/requestfactory/shared/Id.java M bikeshed/src/com/google/gwt/requestfactory/shared/Receiver.java M bikeshed/src/com/google/gwt/requestfactory/shared/RecordListRequest.java M bikeshed/src/com/google/gwt/requestfactory/shared/RecordRequest.java M bikeshed/src/com/google/gwt/requestfactory/shared/RequestEvent.java M bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java M bikeshed/src/com/google/gwt/requestfactory/shared/ServerOperation.java M bikeshed/src/com/google/gwt/requestfactory/shared/ServerType.java M bikeshed/src/com/google/gwt/requestfactory/shared/SyncRequest.java M bikeshed/src/com/google/gwt/requestfactory/shared/Version.java M bikeshed/src/com/google/gwt/requestfactory/shared/impl/RequestDataManager.java M bikeshed/src/com/google/gwt/requestfactory/shared/package.html M bikeshed/src/com/google/gwt/valuestore/client/DeltaValueStoreJsonImpl.java M bikeshed/src/com/google/gwt/valuestore/client/RecordKey.java M bikeshed/src/com/google/gwt/valuestore/client/SyncResultImpl.java M bikeshed/src/com/google/gwt/valuestore/client/ValueStoreJsonImpl.java M bikeshed/src/com/google/gwt/valuestore/shared/DeltaValueStore.java M bikeshed/src/com/google/gwt/valuestore/shared/Property.java M bikeshed/src/com/google/gwt/valuestore/shared/PropertyReference.java M bikeshed/src/com/google/gwt/valuestore/shared/Record.java M bikeshed/src/com/google/gwt/valuestore/shared/RecordChangedEvent.java M bikeshed/src/com/google/gwt/valuestore/shared/SyncResult.java M bikeshed/src/com/google/gwt/valuestore/shared/Value.java M bikeshed/src/com/google/gwt/valuestore/shared/ValueStore.java M bikeshed/src/com/google/gwt/valuestore/shared/WriteOperation.java M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordImpl.java M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordJsoImpl.java M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordSchema.java M bikeshed/src/com/google/gwt/valuestore/shared/impl/RecordToTypeMap.java M bikeshed/src/com/google/gwt/valuestore/shared/package.html M bikeshed/src/com/google/gwt/valuestore/ui/AbstractRecordListView.java M bikeshed/src/com/google/gwt/valuestore/ui/PropertyColumn.java M bikeshed/src/com/google/gwt/valuestore/ui/PropertyView.java M bikeshed/src/com/google/gwt/valuestore/ui/RecordDetailsView.java M bikeshed/src/com/google/gwt/valuestore/ui/RecordEditView.ja
[gwt-contrib] Re: Fix for issue 516 (issue612802)
http://gwt-code-reviews.appspot.com/612802/diff/1/3
File user/test/com/google/gwt/user/client/ui/RootPanelTest.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/3#newcode51
user/test/com/google/gwt/user/client/ui/RootPanelTest.java:51: public
void testClearWithDomErasure() {
I misread it. I didn't notice that you were making a new root panel, not
using the default one.
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
http://gwt-code-reviews.appspot.com/612802/diff/1/2
File user/src/com/google/gwt/user/client/ui/Panel.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/2#newcode231
user/src/com/google/gwt/user/client/ui/Panel.java:231: private static
native void eraseDom(Element element) /*-{
I just didn't notice it is already available.
On 2010/06/16 16:37:47, Ray Ryan wrote:
There is really no need for this method, and also no need for it to be
native.
Why not just call this.getElement().setInnerHTML("") at the only call
site?
http://gwt-code-reviews.appspot.com/612802/diff/1/3
File user/test/com/google/gwt/user/client/ui/RootPanelTest.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/3#newcode33
user/test/com/google/gwt/user/client/ui/RootPanelTest.java:33: public
void testClear() {
Sure, will do that.
On 2010/06/16 16:37:47, Ray Ryan wrote:
These two new tests should be in PanelTestBase. Can you also try
making this
test extend that one? It's odd that it doesn't. I imagine there's a
good reason
but it might be an oversight. If it doesn't work, could you explain so
and why
in the RootPanelTest class doc? If there are one or two problem tests,
they
could be overridden to be no-ops.
http://gwt-code-reviews.appspot.com/612802/diff/1/3#newcode51
user/test/com/google/gwt/user/client/ui/RootPanelTest.java:51: public
void testClearWithDomErasure() {
I've run test.dev.htmlunit as well as test.web.htmlunit and the tests
passed. Why do you think this would destroy the tests?
On 2010/06/16 16:37:47, Ray Ryan wrote:
I'm very surprised that this doesn't destroy all downstream tests.
Have you run
the full suite?
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix for issue 516 (issue612802)
Can you make sure that contrib is cc'd in the issue settings?
http://gwt-code-reviews.appspot.com/612802/diff/1/2
File user/src/com/google/gwt/user/client/ui/Panel.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/2#newcode231
user/src/com/google/gwt/user/client/ui/Panel.java:231: private static
native void eraseDom(Element element) /*-{
There is really no need for this method, and also no need for it to be
native. Why not just call this.getElement().setInnerHTML("") at the only
call site?
http://gwt-code-reviews.appspot.com/612802/diff/1/3
File user/test/com/google/gwt/user/client/ui/RootPanelTest.java (right):
http://gwt-code-reviews.appspot.com/612802/diff/1/3#newcode33
user/test/com/google/gwt/user/client/ui/RootPanelTest.java:33: public
void testClear() {
These two new tests should be in PanelTestBase. Can you also try making
this test extend that one? It's odd that it doesn't. I imagine there's a
good reason but it might be an oversight. If it doesn't work, could you
explain so and why in the RootPanelTest class doc? If there are one or
two problem tests, they could be overridden to be no-ops.
http://gwt-code-reviews.appspot.com/612802/diff/1/3#newcode51
user/test/com/google/gwt/user/client/ui/RootPanelTest.java:51: public
void testClearWithDomErasure() {
I'm very surprised that this doesn't destroy all downstream tests. Have
you run the full suite?
http://gwt-code-reviews.appspot.com/612802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r8262 committed - Add missing properties files (required by 'ant test' of I18NSuite)...
Revision: 8262
Author: gwt.mirror...@gmail.com
Date: Wed Jun 16 05:48:57 2010
Log: Add missing properties files (required by 'ant test' of I18NSuite)
Review at http://gwt-code-reviews.appspot.com/620801
Review by: j...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=8262
Added:
/trunk/user/test_i18n_dollar/com/google/gwt/i18n/client/DateTimeFormatTestBase$MyMessages_de.properties
/trunk/user/test_i18n_dollar/com/google/gwt/i18n/client/DateTimeFormatTestBase$MyMessages_en.properties
===
--- /dev/null
+++
/trunk/user/test_i18n_dollar/com/google/gwt/i18n/client/DateTimeFormatTestBase$MyMessages_de.properties
Wed Jun 16 05:48:57 2010
@@ -0,0 +1,1 @@
+getCustomizedDate=Es ist {0,localdatetime,dMMMy}
===
--- /dev/null
+++
/trunk/user/test_i18n_dollar/com/google/gwt/i18n/client/DateTimeFormatTestBase$MyMessages_en.properties
Wed Jun 16 05:48:57 2010
@@ -0,0 +1,1 @@
+getCustomizedDate=It is {0,localdatetime,dMMMy}
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
