[gwt-contrib] Re: gwt rebranding

[Jens]

>
> Don't think my manager will change his mind because of re-branding. 
>

Re-branding should not convince your manager, it just underlines that GWT 
is not a "Google only" product anymore. 

-- J.

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Re: gwt rebranding

[Jens]

Different idea. Thats probably the most simple thing you can do.

-- J.

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Changes StackTraceDeobfuscator to abstract and provide vario...

[Brian Slesinsky]

Brian Slesinsky has posted comments on this change.

Change subject: Changes StackTraceDeobfuscator to abstract and provide  
various factory methods.

..


Patch Set 3: Code-Review+1

--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Re: gwt rebranding

[vitaly goji]

I tried to convince IT manager to use GWT for a project, but he told me 
that GWT has poor widgets library and lacks essential things like 
validation etc..
Don't think my manager will change his mind because of re-branding. 

In a 90's everyone was using Visual Basic. Check out how they got almost 
all market. 
Certainly not by asking developers and manages to gamble with third-party 
libraries. 
They simply provided developers with what they need to build apps 'out of 
the box'. 

And if you look at what is missing in GWT in comparison to POPULAR 
frameworks, you will see that it would not be too difficult to catch up.

On Friday, March 15, 2013 2:07:04 AM UTC-7, Daniel Kurka wrote:
>
> Crosspost from gwt-steering:
> https://groups.google.com/d/msg/gwt-steering/q9bSOldSBFU/ki5nQk39fJ8J
>
>
>
>
>
> GWT should rebrand
>
>
>

-- 
-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups 
"Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Changes StackTraceDeobfuscator to abstract and provide vario...

[Goktug Gokdogan]

Goktug Gokdogan has uploaded a new patch set (#3).

Change subject: Changes StackTraceDeobfuscator to abstract and provide  
various factory methods.

..

Changes StackTraceDeobfuscator to abstract and provide various factory  
methods.


This change will remove the need for extending StackTraceObfusctor most of  
the
time as in almost all scenarios it is extended to get the symbol map from  
jar

through the class loader (which makes sense).
Also a factory is provided to get the symbol map from the file system. For  
all
other cases, developers can construct the deobfuscator with a URL path or  
extend

the class to override openInputStream method.

Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Review-Link: https://gwt-review.googlesource.com/#/c/2270/
---
M user/src/com/google/gwt/core/server/impl/StackTraceDeobfuscator.java
M user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
2 files changed, 65 insertions(+), 50 deletions(-)


--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Changes StackTraceDeobfuscator to abstract and provide vario...

[Goktug Gokdogan]

Goktug Gokdogan has posted comments on this change.

Change subject: Changes StackTraceDeobfuscator to abstract and provide  
various factory methods.

..


Patch Set 2:

(4 comments)


File user/src/com/google/gwt/core/server/impl/StackTraceDeobfuscator.java
Line 65:   throw new MissingResourceException("Missing resource: "  
+ filePath, null, filePath);

(Decided not to go with FileNotFoundException.)


Line 86:   public static StackTraceDeobfuscator fromURL(final URL urlPath) {
I remember 'Url' was the suggested one but URL class itself was all upper  
case so I was in between. I'm changing it to fromUrl.



Line 89: return new URL(urlPath, fileName).openStream();
Hmm, I thought MissingResourceException was an IOException. I will change  
that.
I also agree the consistently throwing FileNotFoundException is going to be  
difficult. (Similarly, URL.openStream doesn't classify the IOException  
further.) Removing FileNotFoundException from javadoc.



Line 338:* @param fileName name of the symbol or source map file (not  
including a slash)
I was hesitated to add that. It looks like, it will just cause confusion.  
It is named as fileName instead of filePath anyway. Removing the extra info.



--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Changes StackTraceDeobfuscator to abstract and provide vario...

[Brian Slesinsky]

Brian Slesinsky has posted comments on this change.

Change subject: Changes StackTraceDeobfuscator to abstract and provide  
various factory methods.

..


Patch Set 2:

(2 comments)


File user/src/com/google/gwt/core/server/impl/StackTraceDeobfuscator.java
Line 89: return new URL(urlPath, fileName).openStream();
MissingResourceException is a RuntimeException, not an IOException. It  
shouldn't be used in openInputStream because it won't be caught at line 378  
like the others.


But I think you're right, it seems too difficult to consistently throw  
FileNotFoundException. Maybe we should just wrap the call to  
openInputStream (by itself) and catch IOException.



Line 338:* @param fileName name of the symbol or source map file (not  
including a slash)

I meant that the filename doesn't include any directories (not a path).


--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Changes StackTraceDeobfuscator to abstract and provide vario...

[Thomas Broyer]

Thomas Broyer has posted comments on this change.

Change subject: Changes StackTraceDeobfuscator to abstract and provide  
various factory methods.

..


Patch Set 2:

(3 comments)


File user/src/com/google/gwt/core/server/impl/StackTraceDeobfuscator.java
Line 86:   public static StackTraceDeobfuscator fromURL(final URL urlPath) {
AFAICT, we've been trying to move towards 'Url' lately; 'URL' are older  
APIs.



Line 89: return new URL(urlPath, fileName).openStream();
If you ask me, we should just remove the FileNotFoundException from the  
javadoc, as it's depend on how you load the data (which is not necessarily  
a "file"); and keep the MissingResourceException from above (assuming we're  
using it correctly, the javadoc is a bit light…)



Line 338:* @param fileName name of the symbol or source map file (not  
including a slash)

What does "not including a slash" means?


--
To view, visit https://gwt-review.googlesource.com/2270
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I562e052caef8da7f3434319cf11b8984bc347fe5
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Goktug Gokdogan 
Gerrit-Reviewer: Thomas Broyer 
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Re: Issue 7890 : ListBox: allow CSS class for options (issue1897803)

[t . broyer]

I'm still not convinced that this is an issue worth fixing (we don't
allow adding optgroups either; ListBox is a simple wrapper around a
select, with a simple API; if you want more, you can make a more complex
widget with a more complex API), but here are my comments anyway.

I'm not sure I agree with your approach either. Wouldn't it be
better/easier to just make addItem and insertItem return the
OptionElement? (or a façade around it) and possibly add a getter by
index too.
If the compiler does its job, it should detect when the façade object is
never actually used and optimize it out, so that those changes would
have absolutely no impact in code size on existing apps.


http://gwt-code-reviews.appspot.com/1897803/diff/1/user/src/com/google/gwt/user/client/ui/ListBox.java
File user/src/com/google/gwt/user/client/ui/ListBox.java (right):

http://gwt-code-reviews.appspot.com/1897803/diff/1/user/src/com/google/gwt/user/client/ui/ListBox.java#newcode235
user/src/com/google/gwt/user/client/ui/ListBox.java:235: public void
addStyledItem(String item, String value, String className) {
Why isn't there a addStyledItem with a Direction?

http://gwt-code-reviews.appspot.com/1897803/diff/1/user/src/com/google/gwt/user/client/ui/ListBox.java#newcode387
user/src/com/google/gwt/user/client/ui/ListBox.java:387: public void
insertItem(String item, Direction dir, String value, int index, String
styleName) {
Why aren't there insertStyledItem?

http://gwt-code-reviews.appspot.com/1897803/diff/1/user/test/com/google/gwt/user/client/ui/ListBoxTest.java
File user/test/com/google/gwt/user/client/ui/ListBoxTest.java (right):

http://gwt-code-reviews.appspot.com/1897803/diff/1/user/test/com/google/gwt/user/client/ui/ListBoxTest.java#newcode169
user/test/com/google/gwt/user/client/ui/ListBoxTest.java:169:
assertTrue(lb.toString().contains("styleA"));
Please use code similar to assertOptionText (i.e. which looks at the
Option rather than doing a toString)

http://gwt-code-reviews.appspot.com/1897803/

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[gwt-contrib] Change in gwt[master]: Remove early optimization from Precompile.

[Roberto Lublinerman]

Roberto Lublinerman has posted comments on this change.

Change subject: Remove early optimization from Precompile.
..


Patch Set 2:

Here are the numbers on two sets of 4 runs.

AVG Before: Pre: 267  Compile: 285   Total: 552
AVG After:   Pre: 238  Compile: 310   Total: 548

Not much savings (4 seconds on average). Comparing fastest runs the gains  
are 10 seconds.


The surprising part is that the serialized precompilation  
(precompilation.ser) is ~10% smaller with the patch.


I think the reason is related to an issue I found recently while debugging  
my latests change, and that is that some nodes, e.g. JMethodCall have  
targets that are not part of the AST.


The other finding is that if the optimization is left in the precompilation  
(as before this patch) the precompilation.ser file is different each time  
it is run (that is not the case after the patch). A reason for that maybe  
some iteration on a HashSet or HashMap. I'll have a look at that.


--
To view, visit https://gwt-review.googlesource.com/2280
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26bad5f14735a9283021b53edadc5bde1a659c45
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman 
Gerrit-Reviewer: Brian Slesinsky 
Gerrit-Reviewer: Ray Cromwell 
Gerrit-Reviewer: Roberto Lublinerman 
Gerrit-HasComments: No

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- 
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.

To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.