Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes jpackage changes looks good. - Marked as reviewed by almatvee (Reviewer). PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes `src/jdk.jdi/share/classes/com/sun/tools` changes look good. - Marked as reviewed by cjplummer (Reviewer). PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert old translation. Fix lang codes @dfuch Could I get a review from you as well? I believe this translation covers some of the files for your team. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:30:52 GMT, Weijun Wang wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert double quote as well
>
> src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
> line 75:
>
>> 73: "\u5DF2\u751F\u6210 {0} \u4F4D{1}\u5BC6\u94A5"},
>> //-genseckey
>> 74: {"key.algorithm.weak", "%1$s \u4F7F\u7528\u7684 %2$s
>> \u7B97\u6CD5\u88AB\u89C6\u4E3A\u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
>> 75: {"key.size.weak", "%1$s \u4F7F\u7528\u7684 %2$s
>> \u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
>
> The exact same "is considered a security risk" is sometimes translated into
> "被视为存在安全风险" and sometimes "存在安全风险". Either is OK for me but please be
> consistent. This is also shown in 5 other places in the same file.
I didn't do the translation myself so I'm not sure the best approach to resolve
this. I can manually replace these translations with one or the other. However,
it's determine which parts of the code translate to 被视为存在安全风险" or "存在安全风险". I
converted the unicode you highlighted above to characters, and I see where each
one is located. If I just replace all instances of "存在安全风险" and insert
"被视为存在安全风险" in unicode in its place, will it be OK?
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 23:12:58 GMT, Alexander Matveev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed trailing whitespace
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties
> line 51:
>
>> 49: error.msi-product-version-build-out-of-range=Build-Teil der Version muss
>> im Bereich [0, 65535] liegen
>> 50: error.msi-product-version-minor-out-of-range=Nebenversion muss im
>> Bereich [0, 255] liegen
>> 51: error.version-swap=Versionsinformationen f\u00FCr {0} konnten nicht
>> aktualisiert werden
>
> Why this was removed?
This line was added back to all locales as it was a regression from the
translation process.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Fri, 16 Dec 2022 00:17:15 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl >> line 2: >> >>> 1: >>> 2: >> xmlns="http://schemas.microsoft.com/wix/2006/localization"; Codepage="1252"> >> >> Why "de-de" was changed to "de"? > > Also not sure why this was changed in the translation. I'm reverting all > instances of these language codes. This has been reverted as it was a regression for all locales of MsiInstallerStrings.wxl - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v5]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert old translation. Fix lang codes - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/57c42206..29880af9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=03-04 Stats: 18 lines in 9 files changed: 6 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Fri, 16 Dec 2022 01:02:03 GMT, Damon Nguyen wrote: >> Looks like translation is done on files before JDK-8293462 was integrated >> (before Sep 26). See >> [commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0ff9745751d8375#diff-8bfeb61c827c2bc073c65cbf4137dbf8f7baa5f4f88e5d59785e985d9510577c) >> when I changed these two strings. For now it is better to revert them to >> original English version or figure out why translation is old. > > I'll revert it, investigate the cause for the extraction issue in this drop, > and try to have it translated by the next drop then. The translated text here has been reverted to its original English. The same has been done for its locales. - PR: https://git.openjdk.org/jdk20/pull/35
Re: RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions
On Thu, 15 Dec 2022 11:51:10 GMT, Serguei Spitsyn wrote:
> Now the `JvmtiVTMSTransitionDisabler` mechanism supports disabling VTMS
> transitions for all virtual threads only. It should also support disabling
> transitions for any specific virtual thread as well. This will improve
> scalability of the JVMTI functions operating on target virtual threads as the
> functions can be executed concurrently without blocking each other execution
> when target virtual threads are different.
> New constructor `JvmtiVTMSTransitionDisabler(jthread vthread)` is added which
> has jthread parameter of the target virtual thread.
>
> Testing:
> mach5 jobs are TBD (preliminary testing was completed):
>- all JVMTI, JDWP, JDI and JDB tests have to be run
>- Kitchensink
>- tier5
Seems logical though I'm not familiar with the existing mechanisms. A few minor
comments.
Thanks.
src/hotspot/share/classfile/javaClasses.cpp line 1745:
> 1743: int val = VTMS_transition_disable_count(java_thread);
> 1744:
> java_thread->int_field_put(_jvmti_VTMS_transition_disable_count_offset, val -
> 1);
> 1745: }
These are not thread-safe functions. What constraints exist for using these
methods safely?
Update: looks like they must be called with the lock held so we should assert
that.
Should also assert the count never goes negative (which I assume would be an
error?).
src/hotspot/share/prims/jvmtiThreadState.cpp line 252:
> 250: return; // JvmtiVTMSTransitionDisabler is no-op without virtual
> threads
> 251: }
> 252: if (Thread::current_or_null() == NULL) {
Nit: please use `nullptr` in new code
src/hotspot/share/prims/jvmtiThreadState.cpp line 273:
> 271: }
> 272: _is_SR = is_SR;
> 273: _vthread = NULL;
Nit: should initialize in init list
src/hotspot/share/prims/jvmtiThreadState.cpp line 298:
> 296: HandleMark hm(thread);
> 297: Handle vth = Handle(thread,
> JNIHandles::resolve_external_guard(_vthread));
> 298: if (!java_lang_VirtualThread::is_instance(vth())) {
How can this condition not be true? Should it be an assertion?
src/hotspot/share/prims/jvmtiThreadState.cpp line 304:
> 302:
> 303: ThreadBlockInVM tbivm(thread);
> 304: MonitorLocker ml(JvmtiVTMSTransition_lock,
> Mutex::_no_safepoint_check_flag);
Aside: this pattern looks very odd. Why not just lock with the safepoint check?
-
PR: https://git.openjdk.org/jdk/pull/11690
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Revert double quote as well The changes in the java.xml area look good to me. - Marked as reviewed by joehw (Reviewer). PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Fri, 16 Dec 2022 00:51:55 GMT, Alexander Matveev
wrote:
>> I'm not sure for the decisions of change in punctuation and for the missing
>> {1} as I didn't do the translation myself. Would this be better to be
>> reverted?
>
> Looks like translation is done on files before JDK-8293462 was integrated
> (before Sep 26). See
> [commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0ff9745751d8375#diff-8bfeb61c827c2bc073c65cbf4137dbf8f7baa5f4f88e5d59785e985d9510577c)
> when I changed these two strings. For now it is better to revert them to
> original English version or figure out why translation is old.
I'll revert it, investigate the cause for the extraction issue in this drop,
and try to have it translated by the next drop then.
>> Also not sure as it is what I received from the latest translation drop. If
>> this is incorrect, I can manually correct this here and for the other
>> locales for this file.
>
> Yes it needs to be correct. It was changed to _ja, etc with
> [commit](https://github.com/openjdk/jdk20/commit/543163a03b5f1af7a7e7af317a26eb8c5aa81c38#diff-afb8ea68d8b3e9be4bba1c417c82d2162eea9333a3157f05ef57c026af94eb3b).
> Which was done on Aug 10, 2022, so it seems message drop is based on old
> code.
This drop had some issues with the extraction which will be resolved. Some of
the changes are correct while some seem to be old. It seems these jpackage
files were are older? I can revert these changes for jpackage then.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Fri, 16 Dec 2022 00:24:26 GMT, Damon Nguyen wrote: >> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties >> line 37: >> >>> 35: >>> resource.post-app-image-script=\u30A2\u30D7\u30EA\u30B1\u30FC\u30B7\u30E7\u30F3\u30FB\u30A4\u30E1\u30FC\u30B8\u3092\u79FB\u5165\u3057\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8 >>> 36: >>> resource.post-msi-script=exe\u30A4\u30F3\u30B9\u30C8\u30FC\u30E9\u306Emsi\u30D5\u30A1\u30A4\u30EB\u304C\u4F5C\u6210\u3055\u308C\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8 >>> 37: resource.wxl-file-name=MsiInstallerStrings_en.wxl >> >> Why this was changed? > > Also not sure as it is what I received from the latest translation drop. If > this is incorrect, I can manually correct this here and for the other locales > for this file. Yes it needs to be correct. It was changed to _ja, etc with [commit](https://github.com/openjdk/jdk20/commit/543163a03b5f1af7a7e7af317a26eb8c5aa81c38#diff-afb8ea68d8b3e9be4bba1c417c82d2162eea9333a3157f05ef57c026af94eb3b). Which was done on Aug 10, 2022, so it seems message drop is based on old code. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Fri, 16 Dec 2022 00:15:51 GMT, Damon Nguyen wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties
>> line 82:
>>
>>> 80:
>>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in
>>> app-image-Verzeichnis ({0})
>>> 82: error.invalid-app-image=Fehler: app-image-Verzeichnis ({0}) wurde von
>>> einer anderen jpackage-Version generiert, oder .jpackage.xml ist nicht
>>> wohlgeformt
>>
>> error.invalid-app-image looks like old translation and missing "{1}". Also,
>> why () is used instead of ""?
>
> I'm not sure for the decisions of change in punctuation and for the missing
> {1} as I didn't do the translation myself. Would this be better to be
> reverted?
Looks like translation is done on files before JDK-8293462 was integrated
(before Sep 26). See
[commit](https://github.com/openjdk/jdk20/commit/1e222bccd3807c1be0d1d824e0ff9745751d8375#diff-8bfeb61c827c2bc073c65cbf4137dbf8f7baa5f4f88e5d59785e985d9510577c)
when I changed these two strings. For now it is better to revert them to
original English version or figure out why translation is old.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Thu, 15 Dec 2022 23:13:22 GMT, Alexander Matveev wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix https and changed URL back > > src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties > line 37: > >> 35: >> resource.post-app-image-script=\u30A2\u30D7\u30EA\u30B1\u30FC\u30B7\u30E7\u30F3\u30FB\u30A4\u30E1\u30FC\u30B8\u3092\u79FB\u5165\u3057\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8 >> 36: >> resource.post-msi-script=exe\u30A4\u30F3\u30B9\u30C8\u30FC\u30E9\u306Emsi\u30D5\u30A1\u30A4\u30EB\u304C\u4F5C\u6210\u3055\u308C\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8 >> 37: resource.wxl-file-name=MsiInstallerStrings_en.wxl > > Why this was changed? Also not sure as it is what I received from the latest translation drop. If this is incorrect, I can manually correct this here and for the other locales for this file. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Thu, 15 Dec 2022 22:57:31 GMT, Alexander Matveev
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix https and changed URL back
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties
> line 82:
>
>> 80:
>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in
>> app-image-Verzeichnis ({0})
>> 82: error.invalid-app-image=Fehler: app-image-Verzeichnis ({0}) wurde von
>> einer anderen jpackage-Version generiert, oder .jpackage.xml ist nicht
>> wohlgeformt
>
> error.invalid-app-image looks like old translation and missing "{1}". Also,
> why () is used instead of ""?
I'm not sure for the decisions of change in punctuation and for the missing {1}
as I didn't do the translation myself. Would this be better to be reverted?
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl
> line 2:
>
>> 1:
>> 2: > xmlns="http://schemas.microsoft.com/wix/2006/localization"; Codepage="1252">
>
> Why "de-de" was changed to "de"?
Also not sure why this was changed in the translation. I'm reverting all
instances of these language codes.
-
PR: https://git.openjdk.org/jdk20/pull/35
[jdk20] Integrated: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
On Thu, 15 Dec 2022 23:13:30 GMT, Daniel D. Daugherty wrote: > A batch of trivial fixes to ProblemList tests: > > [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList > gc/g1/TestVerifyGCType.java on linux and macosx > [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889) ProblemList > runtime/StackGuardPages/TestStackGuardPages.java on linux > [JDK-8298891](https://bugs.openjdk.org/browse/JDK-8298891) ProblemList > vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java > with ZGC > [JDK-8298892](https://bugs.openjdk.org/browse/JDK-8298892) > ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java > with ZGC This pull request has now been integrated. Changeset: c7d7e7e3 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk20/commit/c7d7e7e3be768b35447d65661ec328204aeb40e4 Stats: 4 lines in 2 files changed: 4 ins; 0 del; 0 mod 829: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx 8298889: ProblemList runtime/StackGuardPages/TestStackGuardPages.java on linux 8298891: ProblemList vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java with ZGC 8298892: ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java with ZGC Reviewed-by: bpb, lmesnik - PR: https://git.openjdk.org/jdk20/pull/42
Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
On Thu, 15 Dec 2022 23:22:15 GMT, Leonid Mesnik wrote: >> A batch of trivial fixes to ProblemList tests: >> >> [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList >> gc/g1/TestVerifyGCType.java on linux and macosx >> [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889) ProblemList >> runtime/StackGuardPages/TestStackGuardPages.java on linux >> [JDK-8298891](https://bugs.openjdk.org/browse/JDK-8298891) ProblemList >> vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java >> with ZGC >> [JDK-8298892](https://bugs.openjdk.org/browse/JDK-8298892) >> ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java >> with ZGC > > Marked as reviewed by lmesnik (Reviewer). @lmesnik - Thanks for the fast review! - PR: https://git.openjdk.org/jdk20/pull/42
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
src/java.base/share/classes/sun/security/tools/keytool/Resources_zh_CN.java
line 75:
> 73: "\u5DF2\u751F\u6210 {0} \u4F4D{1}\u5BC6\u94A5"},
> //-genseckey
> 74: {"key.algorithm.weak", "%1$s \u4F7F\u7528\u7684 %2$s
> \u7B97\u6CD5\u88AB\u89C6\u4E3A\u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
> 75: {"key.size.weak", "%1$s \u4F7F\u7528\u7684 %2$s
> \u5B58\u5728\u5B89\u5168\u98CE\u9669\u3002"},
The exact same "is considered a security risk" is sometimes translated into
"被视为存在安全风险" and sometimes "存在安全风险". Either is OK for me but please be
consistent. This is also shown in 5 other places in the same file.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
On Thu, 15 Dec 2022 23:19:51 GMT, Brian Burkhalter wrote: >> A batch of trivial fixes to ProblemList tests: >> >> [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList >> gc/g1/TestVerifyGCType.java on linux and macosx >> [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889) ProblemList >> runtime/StackGuardPages/TestStackGuardPages.java on linux >> [JDK-8298891](https://bugs.openjdk.org/browse/JDK-8298891) ProblemList >> vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java >> with ZGC >> [JDK-8298892](https://bugs.openjdk.org/browse/JDK-8298892) >> ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java >> with ZGC > > Marked as reviewed by bpb (Reviewer). @bplb - Thanks for the fast review! I'm now waiting for the bots to catch up... - PR: https://git.openjdk.org/jdk20/pull/42
Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
On Thu, 15 Dec 2022 23:13:30 GMT, Daniel D. Daugherty wrote: > A batch of trivial fixes to ProblemList tests: > > [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList > gc/g1/TestVerifyGCType.java on linux and macosx > [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889) ProblemList > runtime/StackGuardPages/TestStackGuardPages.java on linux > [JDK-8298891](https://bugs.openjdk.org/browse/JDK-8298891) ProblemList > vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java > with ZGC > [JDK-8298892](https://bugs.openjdk.org/browse/JDK-8298892) > ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java > with ZGC Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.org/jdk20/pull/42
Re: [jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
On Thu, 15 Dec 2022 23:13:30 GMT, Daniel D. Daugherty wrote: > A batch of trivial fixes to ProblemList tests: > > [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList > gc/g1/TestVerifyGCType.java on linux and macosx > [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889) ProblemList > runtime/StackGuardPages/TestStackGuardPages.java on linux > [JDK-8298891](https://bugs.openjdk.org/browse/JDK-8298891) ProblemList > vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java > with ZGC > [JDK-8298892](https://bugs.openjdk.org/browse/JDK-8298892) > ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java > with ZGC Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.org/jdk20/pull/42
[jdk20] RFR: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
A batch of trivial fixes to ProblemList tests: [JDK-829](https://bugs.openjdk.org/browse/JDK-829) ProblemList gc/g1/TestVerifyGCType.java on linux and macosx [JDK-8298889](https://bugs.openjdk.org/browse/JDK-8298889) ProblemList runtime/StackGuardPages/TestStackGuardPages.java on linux [JDK-8298891](https://bugs.openjdk.org/browse/JDK-8298891) ProblemList vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java with ZGC [JDK-8298892](https://bugs.openjdk.org/browse/JDK-8298892) ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java with ZGC - Commit messages: - 8298892: ProblemList vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java with ZGC - 8298891: ProblemList vmTestbase/nsk/monitoring/MemoryPoolMBean/isCollectionUsageThresholdExceeded/isexceeded002/TestDescription.java with ZGC - 8298889: ProblemList runtime/StackGuardPages/TestStackGuardPages.java on linux - 829: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx Changes: https://git.openjdk.org/jdk20/pull/42/files Webrev: https://webrevs.openjdk.org/?repo=jdk20&pr=42&range=00 Issue: https://bugs.openjdk.org/browse/JDK-829 Stats: 4 lines in 2 files changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk20/pull/42.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/42/head:pull/42 PR: https://git.openjdk.org/jdk20/pull/42
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix https and changed URL back
src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties
line 82:
> 80:
> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in
> app-image-Verzeichnis ({0})
> 82: error.invalid-app-image=Fehler: app-image-Verzeichnis ({0}) wurde von
> einer anderen jpackage-Version generiert, oder .jpackage.xml ist nicht
> wohlgeformt
error.invalid-app-image looks like old translation and missing "{1}". Also, why
() is used instead of ""?
src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_ja.properties
line 82:
> 80:
> 81: error.foreign-app-image=\u30A8\u30E9\u30FC:
> app-image\u30C7\u30A3\u30EC\u30AF\u30C8\u30EA({0})\u306B.jpackage.xml\u30D5\u30A1\u30A4\u30EB\u304C\u3042\u308A\u307E\u305B\u3093
> 82: error.invalid-app-image=\u30A8\u30E9\u30FC:
> app-image\u30C7\u30A3\u30EC\u30AF\u30C8\u30EA({0})\u306F\u5225\u306Ejpackage\u30D0\u30FC\u30B8\u30E7\u30F3\u307E\u305F\u306F\u4E0D\u6B63\u306A.jpackage.xml\u3067\u751F\u6210\u3055\u308C\u307E\u3057\u305F
Same as "de" translation.
src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_zh_CN.properties
line 82:
> 80:
> 81: error.foreign-app-image=\u9519\u8BEF\uFF1Aapp-image \u76EE\u5F55 ({0})
> \u4E2D\u7F3A\u5C11 .jpackage.xml \u6587\u4EF6
> 82: error.invalid-app-image=\u9519\u8BEF\uFF1A\u53E6\u4E00\u4E2A jpackage
> \u7248\u672C\u6216\u683C\u5F0F\u9519\u8BEF\u7684 .jpackage.xml
> \u751F\u6210\u4E86 app-image \u76EE\u5F55 ({0})
Same as "de" translation.
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl
line 2:
> 1:
> 2: xmlns="http://schemas.microsoft.com/wix/2006/localization"; Codepage="1252">
Why "de-de" was changed to "de"?
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_ja.wxl
line 2:
> 1:
> 2: xmlns="http://schemas.microsoft.com/wix/2006/localization"; Codepage="932">
Why "ja-jp" to "ja"?
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties
line 37:
> 35: resource.post-app-image-script=Auszuf\u00FChrendes Skript nach dem
> Auff\u00FCllen des Anwendungsimages
> 36: resource.post-msi-script=Auszuf\u00FChrendes Skript nach dem Erstellen
> der MSI-Datei f\u00FCr das EXE-Installationsprogramm
> 37: resource.wxl-file-name=MsiInstallerStrings_en.wxl
Why this was changed?
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties
line 37:
> 35:
> resource.post-app-image-script=\u30A2\u30D7\u30EA\u30B1\u30FC\u30B7\u30E7\u30F3\u30FB\u30A4\u30E1\u30FC\u30B8\u3092\u79FB\u5165\u3057\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8
> 36:
> resource.post-msi-script=exe\u30A4\u30F3\u30B9\u30C8\u30FC\u30E9\u306Emsi\u30D5\u30A1\u30A4\u30EB\u304C\u4F5C\u6210\u3055\u308C\u305F\u5F8C\u306B\u5B9F\u884C\u3059\u308B\u30B9\u30AF\u30EA\u30D7\u30C8
> 37: resource.wxl-file-name=MsiInstallerStrings_en.wxl
Why this was changed?
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties
line 37:
> 35:
> resource.post-app-image-script=\u8981\u5728\u586B\u5145\u5E94\u7528\u7A0B\u5E8F\u6620\u50CF\u4E4B\u540E\u8FD0\u884C\u7684\u811A\u672C
> 36: resource.post-msi-script=\u5728\u4E3A exe
> \u5B89\u88C5\u7A0B\u5E8F\u521B\u5EFA msi
> \u6587\u4EF6\u4E4B\u540E\u8981\u8FD0\u884C\u7684\u811A\u672C
> 37: resource.wxl-file-name=MsiInstallerStrings_en.wxl
Same as above.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_ja.wxl
line 15:
> 13:Id="ShortcutPromptDlgStartMenuShortcutControlLabel">スタート・メニューのショートカットの作成
> 14: [ProductName]セットアップ
> 15: Open with [ProductName]
Why it was removed in all translations, except English?
src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_de.properties
line 51:
> 49: error.msi-product-version-minor-out-of-range=Nebenversion muss im Bereich
> [0, 255] liegen
> 50: error.version-swap=Versionsinformationen f\u00FCr {0} konnten nicht
> aktualisiert werden
> 51: error.icon-swap=Failed to update icon for {0}
Why this was removed?
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
Marked as reviewed by naoto (Reviewer).
src/jdk.jdeps/share/classes/com/sun/tools/jdeprscan/resources/jdeprscan_de.properties
line 26:
> 24: #
> 25:
> 26: main.usage=Verwendung: jdeprscan [Optionen] '{dir|jar|class}'
> ...\n\nOptionen:\n--class-path PATH\n--for-removal\n
> --full-version\n -? -h --help\n -l--list\n--release {0}\n -v
> --verbose\n--version
Good catch!
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v4]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Revert double quote as well - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/09140a05..57c42206 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=02-03 Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: RFR: 8298241: Replace C-style casts with JavaThread::cast [v2]
On Thu, 15 Dec 2022 21:20:31 GMT, David Holmes wrote: >> This is a simple cleanup RFE to get rid of old-style C casts in relation to >> JavaThread. >> >> In many cases involving NULL/nullptr the cast could just be dropped. >> Sometimes a static cast is needed to disambiguate overloads. >> >> A couple of reinterpret_cast are needed when doing int/ptr conversion. >> >> static_cast is used for void* conversion. >> >> The other changes should be self explanatory. >> >> The changes in >> >> src/hotspot/os_cpu/bsd_aarch64/javaThread_bsd_aarch64.cpp >> src/hotspot/os_cpu/windows_aarch64/javaThread_windows_aarch64.cpp >> >> are a bit more extensive. That code was using an alias for `this` which is >> completely unnecessary (and the alias creation was using the cast). This >> could be factored out if thought necessary. >> >> I grep'd as best I could for the old C-style casts but can't be certain I >> got them all. >> >> Testing: >> - all builds in our tiers1-5 >> - local linux x64 product, slowdebug and fastdebug >> - GHA >> - Sanity testing tiers 1-3 >> Thanks. > > David Holmes has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed commented examle. Is it possible to add a test based on grep to prevent re-introduction of the unwanted C-style casts? - PR: https://git.openjdk.org/jdk/pull/11682
Integrated: 8298241: Replace C-style casts with JavaThread::cast
On Wed, 14 Dec 2022 22:22:48 GMT, David Holmes wrote: > This is a simple cleanup RFE to get rid of old-style C casts in relation to > JavaThread. > > In many cases involving NULL/nullptr the cast could just be dropped. > Sometimes a static cast is needed to disambiguate overloads. > > A couple of reinterpret_cast are needed when doing int/ptr conversion. > > static_cast is used for void* conversion. > > The other changes should be self explanatory. > > The changes in > > src/hotspot/os_cpu/bsd_aarch64/javaThread_bsd_aarch64.cpp > src/hotspot/os_cpu/windows_aarch64/javaThread_windows_aarch64.cpp > > are a bit more extensive. That code was using an alias for `this` which is > completely unnecessary (and the alias creation was using the cast). This > could be factored out if thought necessary. > > I grep'd as best I could for the old C-style casts but can't be certain I got > them all. > > Testing: > - all builds in our tiers1-5 > - local linux x64 product, slowdebug and fastdebug > - GHA > - Sanity testing tiers 1-3 > Thanks. This pull request has now been integrated. Changeset: 3cdbd878 Author:David Holmes URL: https://git.openjdk.org/jdk/commit/3cdbd878e68dc1131093137a7357710ad303ae8c Stats: 44 lines in 19 files changed: 0 ins; 11 del; 33 mod 8298241: Replace C-style casts with JavaThread::cast Reviewed-by: coleenp, stefank, sspitsyn - PR: https://git.openjdk.org/jdk/pull/11682
Re: RFR: 8298241: Replace C-style casts with JavaThread::cast [v2]
On Thu, 15 Dec 2022 07:07:26 GMT, Stefan Karlsson wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed commented examle.
>
> Marked as reviewed by stefank (Reviewer).
Thanks for the reviews @stefank and @sspitsyn !
> src/hotspot/share/runtime/frame.cpp line 1568:
>
>> 1566: }
>> 1567: }
>> 1568: // if (error) { tty->cr(); print_on(nullptr, tty); }
>
> This probably need the same cast as in print_frame_layout, to disambiguate
> the call.
Fixed
-
PR: https://git.openjdk.org/jdk/pull/11682
Re: RFR: 8298241: Replace C-style casts with JavaThread::cast [v2]
> This is a simple cleanup RFE to get rid of old-style C casts in relation to > JavaThread. > > In many cases involving NULL/nullptr the cast could just be dropped. > Sometimes a static cast is needed to disambiguate overloads. > > A couple of reinterpret_cast are needed when doing int/ptr conversion. > > static_cast is used for void* conversion. > > The other changes should be self explanatory. > > The changes in > > src/hotspot/os_cpu/bsd_aarch64/javaThread_bsd_aarch64.cpp > src/hotspot/os_cpu/windows_aarch64/javaThread_windows_aarch64.cpp > > are a bit more extensive. That code was using an alias for `this` which is > completely unnecessary (and the alias creation was using the cast). This > could be factored out if thought necessary. > > I grep'd as best I could for the old C-style casts but can't be certain I got > them all. > > Testing: > - all builds in our tiers1-5 > - local linux x64 product, slowdebug and fastdebug > - GHA > - Sanity testing tiers 1-3 > Thanks. David Holmes has updated the pull request incrementally with one additional commit since the last revision: Fixed commented examle. - Changes: - all: https://git.openjdk.org/jdk/pull/11682/files - new: https://git.openjdk.org/jdk/pull/11682/files/5641507a..34f2745d Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11682&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11682&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11682.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11682/head:pull/11682 PR: https://git.openjdk.org/jdk/pull/11682
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote: >> Open l10n drop >> All tests passed > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix https and changed URL back Thanks for the update, Damon. Looks good for this drop. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 18:52:45 GMT, Naoto Sato wrote: >> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed trailing whitespace > > src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps_de.properties > line 134: > >> 132: public.api.replacement.column.header=Vorgeschlagene Ersetzung >> 133: artifact.not.found=nicht gefunden >> 134: >> jdeps.wiki.url=https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool > > This seems to change backward. `openjdk.java.net` has changed to > `openjdk.org` Same issues are observed in other locales. This and the https->http differences seem to also be a part of the extraction issue. The resource generation files show "http" and "java.net", but I see differently on my local repo that I used for the extraction. I will run a new extraction job on a fresh repo/branch to see if this issue is reproducible and narrow down the source of the extraction issue. As discussed with Naoto, these are small edits, and they have been addressed in the latest PR. - PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v3]
> Open l10n drop > All tests passed Damon Nguyen has updated the pull request incrementally with one additional commit since the last revision: Fix https and changed URL back - Changes: - all: https://git.openjdk.org/jdk20/pull/35/files - new: https://git.openjdk.org/jdk20/pull/35/files/54d2ec5f..09140a05 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk20&pr=35&range=01-02 Stats: 15 lines in 15 files changed: 0 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jdk20/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk20 pull/35/head:pull/35 PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 02:45:48 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed trailing whitespace
Changes requested by naoto (Reviewer).
src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_de.properties
line 217:
> 215: javac.msg.usage.nonstandard.footer=Diese zus\u00E4tzlichen Optionen
> k\u00F6nnen jederzeit ohne vorherige Ank\u00FCndigung ge\u00E4ndert werden.
> 216:
> 217: javac.msg.bug=Im Compiler ({0}) ist eine Ausnahme aufgetreten. Erstellen
> Sie auf der Java-Seite zum Melden von Bugs (http://bugreport.java.com) einen
> Bugbericht, nachdem Sie die Bugdatenbank (http://bugs.java.com) auf Duplikate
> gepr\u00FCft haben. Geben Sie in Ihrem Bericht Ihr Programm, die folgende
> Diagnose und die Parameter an, die Sie dem Java-Compiler \u00FCbergeben
> haben. Vielen Dank.
How come `https` turned into `http`? I see these happening all over the places
other than this location as well.
src/jdk.jdeps/share/classes/com/sun/tools/jdeps/resources/jdeps_de.properties
line 134:
> 132: public.api.replacement.column.header=Vorgeschlagene Ersetzung
> 133: artifact.not.found=nicht gefunden
> 134:
> jdeps.wiki.url=https://wiki.openjdk.java.net/display/JDK8/Java+Dependency+Analysis+Tool
This seems to change backward. `openjdk.java.net` has changed to `openjdk.org`
Same issues are observed in other locales.
-
PR: https://git.openjdk.org/jdk20/pull/35
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 02:23:34 GMT, Damon Nguyen wrote: >> src/jdk.jlink/share/classes/jdk/tools/jmod/resources/jmod_de.properties line >> 26: >> >>> 24: # >>> 25: >>> 26: jmod.description=JMOD-Dateien erstellen und den Inhalt vorhandener >>> JMOD-Dateien auflisten >> >> `jlink.description` was added to `jmod.properties` in May 2022 (Which was >> before Alisen's drop for JDK19). Shouldn't this have been translated during >> the 19 drop in August, as opposed to showing up now? > > I see the date of [that PR](https://github.com/openjdk/jdk/pull/8772) as > well. Looks like it was integrated on May 19. > > I'm contacting Kate Gavin to determine why some translations seem to > sometimes be delayed. As you mentioned in the other comment, there are a few > instances where text was added between the last drop & this drop, but weren't > translated. > > And as you showed here, this should have been translated in the last drop > rather than this one, but showed up here. I need a response from Kate to > clarify when these translations are generated. I conversed with Kate and the problem seems to come from the extraction process. We went through the source files that were sent for translation as a zip, and some changes would be missing. We confirmed that everything in this zip was translated, so the issue was in the extraction to create the source files to send for translation. For example, the plugin.properties missing text didn't show in the source.zip but showed on my forked repo used in the extraction. I re-ran the extraction script but still did not see the new text in the generated zip. Kate thinks a similar issue occurred in the previous drop and this jmod.properties change wasn't captured in the extraction process. So now it is captured in this drop and translated here. It could be syncing or branch issues, but while working with Kate, I learned to better see what files are pulled from the extraction script. So for future drops, I can better check to make sure changes I expect to be translated will appear. - PR: https://git.openjdk.org/jdk20/pull/35
RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions
Now the `JvmtiVTMSTransitionDisabler` mechanism supports disabling VTMS transitions for all virtual threads only. It should also support disabling transitions for any specific virtual thread as well. This will improve scalability of the JVMTI functions operating on target virtual threads as the functions can be executed concurrently without blocking each other execution when target virtual threads are different. New constructor `JvmtiVTMSTransitionDisabler(jthread vthread)` is added which has jthread parameter of the target virtual thread. Testing: mach5 jobs are TBD: - all JVMTI, JDWP, JDI and JDB tests have to be run - Kitchensink - tier5 - Commit messages: - fix trailing white spaces in javaClasses.cpp and jvmtiThreadState.cpp - 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions Changes: https://git.openjdk.org/jdk/pull/11690/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11690&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298853 Stats: 161 lines in 7 files changed: 110 ins; 2 del; 49 mod Patch: https://git.openjdk.org/jdk/pull/11690.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11690/head:pull/11690 PR: https://git.openjdk.org/jdk/pull/11690
Re: [jdk20] RFR: 8298133: JDK 20 RDP1 L10n resource files update - msgdrop 10 [v2]
On Thu, 15 Dec 2022 01:13:32 GMT, Justin Lu wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/resources/plugins_zh_CN.properties >> line 188: >> >>> 186: main.plugin.module=\u63D2\u4EF6\u6A21\u5757 >>> 187: >>> 188: main.plugin.category=\u7C7B\u522B >> >> As Naoto pointed out, it looks like a trailing space was added by accident. >> This is also done in the ja version but for a different value. And no space >> was added for any value for the de version. It looks like the translation >> drop that Damon is receiving contains random changes. > > Additionally, there were changes made to plugins.properties in October that > were not translated in the translation drop In our discussion, Kate mentioned that some languages are double byte, so this extra space may be correct but she hasn't looked in detail yet. I looked through all of the changes and these two instances of trailing whitespaces were the only two. I removed the extra spaces to reduce the changes as it seems useless due to the previous version not having the whitespace. - PR: https://git.openjdk.org/jdk20/pull/35
Re: RFR: 8298701: Cleanup SA entries in ProblemList-zgc.txt.
On Tue, 13 Dec 2022 22:34:06 GMT, Chris Plummer wrote: > The following ProblemList-zgc.txt entries need a lot of cleanup. > > serviceability/sa/ClhsdbCDSCore.java 8268722 > macosx-x64 > serviceability/sa/ClhsdbFindPC.java#xcomp-core8268722,8284045 > macosx-x64,generic-all > serviceability/sa/ClhsdbFindPC.java#no-xcomp-core 8268722 > macosx-x64 > serviceability/sa/ClhsdbFindPC.java#xcomp-process 8276402 > generic-all > serviceability/sa/ClhsdbJstack.java#id0 8276402 > generic-all > serviceability/sa/ClhsdbPmap.java#core8268722 > macosx-x64 > serviceability/sa/ClhsdbPstack.java#core 8268722 > macosx-x64 > serviceability/sa/TestJmapCore.java > 8268722,8268283,8270202 macosx-x64,linux-aarch64,linux-x64 > serviceability/sa/TestJmapCoreMetaspace.java 8268722,8268636 > generic-all > > [JDK-8268722](https://bugs.openjdk.org/browse/JDK-8268722) entries can be > removed. It was closed as WNF. It doesn't really impact macosx-aarch64 (core > files are reasonably small there), and on macosx-x64 all these core file > tests are (probably indefinitely) problem listed for other reasons in the > main problem list, so no need to problem list them here with a closed CR. > > [JDK-8276402](https://bugs.openjdk.org/browse/JDK-8276402) has been closed as > dup of a bug that is now fixed. > > Lastly, TestJmapCore.java does fail on macosx-aarch64 due to > [JDK-8268283](https://bugs.openjdk.org/browse/JDK-8268283), so its problem > list entry needs to be updated to reflect that. Marked as reviewed by sspitsyn (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11658
Re: RFR: 8298241: Replace C-style casts with JavaThread::cast
On Wed, 14 Dec 2022 22:22:48 GMT, David Holmes wrote: > This is a simple cleanup RFE to get rid of old-style C casts in relation to > JavaThread. > > In many cases involving NULL/nullptr the cast could just be dropped. > Sometimes a static cast is needed to disambiguate overloads. > > A couple of reinterpret_cast are needed when doing int/ptr conversion. > > static_cast is used for void* conversion. > > The other changes should be self explanatory. > > The changes in > > src/hotspot/os_cpu/bsd_aarch64/javaThread_bsd_aarch64.cpp > src/hotspot/os_cpu/windows_aarch64/javaThread_windows_aarch64.cpp > > are a bit more extensive. That code was using an alias for `this` which is > completely unnecessary (and the alias creation was using the cast). This > could be factored out if thought necessary. > > I grep'd as best I could for the old C-style casts but can't be certain I got > them all. > > Testing: > - all builds in our tiers1-5 > - local linux x64 product, slowdebug and fastdebug > - GHA > - Sanity testing tiers 1-3 > Thanks. Looks good. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.org/jdk/pull/11682
