Change in vdsm[master]: daemon: autodisable cpu affinity on singlecore
gerrit-hooks has posted comments on this change. Change subject: daemon: autodisable cpu affinity on singlecore .. Patch Set 5: * #1279431::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279431::OK, public bug * Check Product::#1279431::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: daemon: autodisable cpu affinity on singlecore
Francesco Romani has posted comments on this change.
Change subject: daemon: autodisable cpu affinity on singlecore
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/48619/4//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-11-16 14:42:54 +0100
Line 4: Commit: Francesco Romani
Line 5: CommitDate: 2015-11-17 13:16:19 +0100
Line 6:
Line 7: daemon: autodisable cpu affinity on singlecore
> Lets use the term processor, one core can have multiple processors.
I know the terms the other way around - so this statement was on purpose.
We commonly read ("multicore processor") because a single processor unit (the
thing we put in the socket on the mainboard) is made up by multiple computing
cores (e.g. early athlon64 x2 or pentium 4s where two physical cores on one
package).
But I don't really mind, this is not commit message, not a paper for an
hardware journal, so I'll change.
Line 8:
Line 9: If VDSM runs on single-core hosts (E.g. VMs, QE boxes)
Line 10: there is no point in enabling cpu affinity, since
Line 11: we already reached the goal of running on just one CPU.
Line 5: CommitDate: 2015-11-17 13:16:19 +0100
Line 6:
Line 7: daemon: autodisable cpu affinity on singlecore
Line 8:
Line 9: If VDSM runs on single-core hosts (E.g. VMs, QE boxes)
> QE boxes are vms usually.
so will simplify
Line 10: there is no point in enabling cpu affinity, since
Line 11: we already reached the goal of running on just one CPU.
Line 12:
Line 13: Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
https://gerrit.ovirt.org/#/c/48619/4/vdsm/vdsm
File vdsm/vdsm:
Line 229: log.info('VDSM will run with cpu affinity: %s', cpu_set)
Line 230:
Line 231: # too early to use the facilities from caps.py
Line 232: if os.sysconf('SC_NPROCESSORS_ONLN') == 1:
Line 233: log.warning('Only one cpu detected: affinity disabled')
> This is correct for this case (run on second processor, having only one pro
Agreed, but I believe VDSM should explode on wrong config. This is more like a
courtesy to QE to speed up things rather than an attempt to detect wrong
settings.
So I don't see a real need for smarter logic in the future
Line 234: else:
Line 235: taskset.set(os.getpid(), cpu_set, all_tasks=True)
Line 236:
Line 237:
Line 231: # too early to use the facilities from caps.py
Line 232: if os.sysconf('SC_NPROCESSORS_ONLN') == 1:
Line 233: log.warning('Only one cpu detected: affinity disabled')
Line 234: else:
Line 235: taskset.set(os.getpid(), cpu_set, all_tasks=True)
> Please keep the early return style.
Done
Line 236:
Line 237:
Line 238: def main():
Line 239: __assertVdsmUser()
--
To view, visit https://gerrit.ovirt.org/48619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Collect stats from online cpu cores only
Roman Mohr has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 12: Verified+1 Verified by: 1) vdsClient -s 0 getVdsStats shows all cpu cores 2) disable cpu core 3: echo 0 > /sys/devices/system/cpu/cpu3/online 3) vdsClient -s 0 getVdsStats does no longer show cpu3 4) enable cpu core 3: echo 1 > /sys/devices/system/cpu/cpu3/online 5) repeatedly check getVdsStats until two samples are present 6) vdsClient -s 0 getVdsStats shows all cpu cores again -- To view, visit https://gerrit.ovirt.org/46269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo: report DHCP from configuration to avoid confusion a...
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP .. Patch Set 2: Verified+1 The extended test passed and manual testing, (described at https://gerrit.ovirt.org/48513) combining bridged and unbridged configuration with DHCP and static addressing, succeeded. All on Fedora 22. CI failures were not caused by this patch. -- To view, visit https://gerrit.ovirt.org/48846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo: report DHCP from configuration to avoid confusion a...
gerrit-hooks has posted comments on this change. Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP .. Patch Set 2: * #1279824::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279824::OK, public bug * Check Product::#1279824::OK, Correct classification oVirt * Check TM::#1279824::OK, correct target milestone ovirt-3.5.7 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/48846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo: report DHCP from configuration to avoid confusion a...
gerrit-hooks has posted comments on this change. Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP .. Patch Set 1: * #1279824::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279824::OK, public bug * Check Product::#1279824::OK, Correct classification oVirt * Check TM::#1279824::OK, correct target milestone ovirt-3.5.7 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/48846 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netinfo: report DHCP from configuration to avoid confusion a...
Hello Ido Barkan, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/48846
to review the following change.
Change subject: netinfo: report DHCP from configuration to avoid confusion
after stopping DHCP
..
netinfo: report DHCP from configuration to avoid confusion after stopping DHCP
Until now, after moving away from reporting DHCP based on ifcfg files, VDSM
relied on dhclient's lease files. Even after a network was reconfigured to
stop using DHCP and thus dhclient was stopped, DHCP would still be reported
from the still valid leases (which preserve the state of network configuration
as obtained from a DHCP server, to rebind later to the same address if
allowed).
Although I introduced this behaviour intentionally, VDSM must stop reporting
bootproto4 (in upstream, dhcpv4) for a network that is reverted to static
configuration (which is to be effective immediately not to confuse the engine
and the user).
The currently active network configuration is queried to find out if DHCPv4
is to be reported, or not. If a network is not configured, leases are
consulted again.
testSetupNetworksAddDelDhcp reverts from DHCP-configured network to static
configuration and checks that DHCP is no longer reported (indeed, netinfo
returns the configured values for networks, now).
Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599
Signed-off-by: Ondřej Svoboda
Reviewed-on: http://gerrit.ovirt.org/37617
Reviewed-by: Ido Barkan
Reviewed-by: Dan Kenigsberg
Bug-Url: https://bugzilla.redhat.com/1279824
---
M lib/vdsm/netinfo.py
M tests/functional/networkTests.py
2 files changed, 25 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/46/48846/1
diff --git a/lib/vdsm/netinfo.py b/lib/vdsm/netinfo.py
index 01f25c7..0896f56 100644
--- a/lib/vdsm/netinfo.py
+++ b/lib/vdsm/netinfo.py
@@ -540,7 +540,15 @@
in sorted(opts.iteritems(
-def _getNetInfo(iface, dhcp4, bridged, gateways, ipv6routes, ipaddrs):
+def _dhcp_used(iface, ifaces_with_active_leases, net_attrs):
+if net_attrs is None:
+return iface in ifaces_with_active_leases
+else:
+return net_attrs.get('bootproto') == 'dhcp'
+
+
+def _getNetInfo(iface, dhcp4, bridged, gateways, ipv6routes, ipaddrs,
+net_attrs):
'''Returns a dictionary of properties about the network's interface status.
Raises a KeyError if the iface does not exist.'''
data = {}
@@ -557,7 +565,8 @@
ipv4addr, ipv4netmask, ipv4addrs, ipv6addrs = getIpInfo(iface, ipaddrs)
data.update({'iface': iface, 'bridged': bridged,
'addr': ipv4addr, 'netmask': ipv4netmask,
- 'bootproto4': 'dhcp' if iface in dhcp4 else 'none',
+ 'bootproto4': 'dhcp' if _dhcp_used(
+ iface, dhcp4, net_attrs) else 'none',
'gateway': getgateway(gateways, iface),
'ipv4addrs': ipv4addrs,
'ipv6addrs': ipv6addrs,
@@ -700,6 +709,7 @@
def _libvirtNets2vdsm(nets, gateways=None, ipv6routes=None,
ipAddrs=None):
+running_config = RunningConfig()
dhcp4 = getDhclientIfaces(_DHCLIENT_LEASES_GLOBS)
if gateways is None:
gateways = getRoutes()
@@ -710,10 +720,12 @@
d = {}
for net, netAttr in nets.iteritems():
try:
+# Pass the iface if the net is _not_ bridged, the bridge otherwise
d[net] = _getNetInfo(netAttr.get('iface', net),
dhcp4,
netAttr['bridged'], gateways,
- ipv6routes, ipAddrs)
+ ipv6routes, ipAddrs,
+ running_config.networks.get(net, None))
except KeyError:
continue # Do not report missing libvirt networks.
return d
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index d369bde..0ecb4c7 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2137,6 +2137,16 @@
routes, rules = self.assertSourceRoutingConfiguration(
device_name, NETWORK_NAME)
+# Do not report DHCP from (typically still valid) leases
+network[NETWORK_NAME]['bootproto'] = 'none'
+status, msg = self.vdsm_net.setupNetworks(network, {},
+ NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+test_net = self.vdsm_net.netinfo.networks[NETWORK_NAME]
+self.assertEqual(test_net['bootproto4'], 'none')
+if bridged:
+self.assertEqual(test_net['cfg']['BOOTPROTO'], 'none')
+
network = {NETWORK_NAME: {'remove': True}}
Change in vdsm[master]: Remove vdsm/vdsm-logrotate.conf from .gitignore
gerrit-hooks has posted comments on this change. Change subject: Remove vdsm/vdsm-logrotate.conf from .gitignore .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6956455233a269a123b1cf264413d3e6125494e4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove vdsm/vdsm-logrotate.conf from .gitignore
Dan Kenigsberg has posted comments on this change. Change subject: Remove vdsm/vdsm-logrotate.conf from .gitignore .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6956455233a269a123b1cf264413d3e6125494e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Remove vdsm/vdsm-logrotate.conf from .gitignore
Dan Kenigsberg has submitted this change and it was merged. Change subject: Remove vdsm/vdsm-logrotate.conf from .gitignore .. Remove vdsm/vdsm-logrotate.conf from .gitignore vdsm/vdsm-logrotate.conf is no more generated, so removing it from .gitignore. Change-Id: I6956455233a269a123b1cf264413d3e6125494e4 Signed-off-by: Shmuel Melamud Reviewed-on: https://gerrit.ovirt.org/48629 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M .gitignore 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Shmuel Leib Melamud: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/48629 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6956455233a269a123b1cf264413d3e6125494e4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added fc23 repos to the automation scripts
Dan Kenigsberg has posted comments on this change. Change subject: Added fc23 repos to the automation scripts .. Patch Set 4: Code-Review-1 would you care to manually rebase -- To view, visit https://gerrit.ovirt.org/48180 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie64c291a55c8e5790effac48ae33c12b822a1259 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: David Caro Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: host stats: Collect stats from online cpu cores only
Nir Soffer has posted comments on this change. Change subject: host stats: Collect stats from online cpu cores only .. Patch Set 12: Ping -- To view, visit https://gerrit.ovirt.org/46269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9c247f9138e02a9230a0849a04cb2e1705e7fac Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Roman Mohr Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: Roman Mohr Gerrit-Reviewer: Roy Golan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: perform image deletion in task
Nir Soffer has posted comments on this change. Change subject: storage: perform image deletion in task .. Patch Set 3: Ping? -- To view, visit https://gerrit.ovirt.org/48477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e61d38439192d193f3f806e08661b61a65e7836 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Liron Aravot Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce cpuinfo module
Nir Soffer has posted comments on this change. Change subject: vdsm: introduce cpuinfo module .. Patch Set 13: This is much too big, please break to small focus patches. -- To view, visit https://gerrit.ovirt.org/46912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: introduce cpuinfo module
Nir Soffer has posted comments on this change. Change subject: vdsm: introduce cpuinfo module .. Patch Set 13: Code-Review-1 (1 comment) Partial review of cpuinfo module. https://gerrit.ovirt.org/#/c/46912/13/lib/vdsm/cpuarch.py File lib/vdsm/cpuarch.py: Line 49: def __init__(self, target_arch=None): Line 50: if not target_arch: Line 51: target_arch = current() Line 52: Line 53: super(UnsupportedArchitecture, self).__init__(target_arch) - The caller should give the architecture, no defaults and no magic. - No need to initialize the parent. - Implement __str__ to return helpful message instead of meaningless tuple of args Line 54: Line 55: Line 56: def arch_to_cpu_map(target_arch=None): Line 57: ''' -- To view, visit https://gerrit.ovirt.org/46912 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding python3 run for nosetests
Nir Soffer has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 10: (3 comments) https://gerrit.ovirt.org/#/c/48051/10/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 630: """ Line 631: Line 632: # Moving import here so that import utils over python3 will work. Once Line 633: # python3-cpopen will be available this import should return to top Line 634: from cpopen import CPopen We don't need cpopen on python 3. Why not use the compat trick to get Popen from either cpopen or subprocess? Line 635: Line 636: command = cmdutils.wrap_command(command, with_ioclass=ioclass, Line 637: ioclassdata=ioclassdata, with_nice=nice, Line 638: with_setsid=setsid, with_sudo=sudo, https://gerrit.ovirt.org/#/c/48051/10/tests/Makefile.am File tests/Makefile.am: Line 29 Line 30 Line 31 Line 32 Line 33 And add here _py2? I guess we are going to live with both py3 and py2 for long time, so lets make it more clear. Line 25: devices \ Line 26: integration \ Line 27: $(NULL) Line 28: Line 29: test_modules_python3 = \ Maybe _py3? Line 30:apiData.py \ Line 31:cmdutilsTests.py \ Line 32:concurrentTests.py \ Line 33:$(NULL) -- To view, visit https://gerrit.ovirt.org/48051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Adding python3 run for nosetests
Nir Soffer has posted comments on this change. Change subject: Adding python3 run for nosetests .. Patch Set 10: (3 comments) Seems that this needs rebase https://gerrit.ovirt.org/#/c/48051/10//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-11-15 10:31:10 +0200 Line 6: Line 7: Adding python3 run for nosetests Line 8: Line 9: This patch adds list of nosetests modules that makecheck will try to run makecheck -> make check Line 10: with python3. The initial work will allow to add more verified tests to Line 11: that list until covering all of them. Line 12: Changes in code are minimal - using configparser which contains same Line 13: implementation as python2 ConfigParser and use io.StringIO instead of Line 8: Line 9: This patch adds list of nosetests modules that makecheck will try to run Line 10: with python3. The initial work will allow to add more verified tests to Line 11: that list until covering all of them. Line 12: Changes in code are minimal - using configparser which contains same This is not in this patch now (merged) Line 13: implementation as python2 ConfigParser and use io.StringIO instead of Line 14: StringIO which are different in some attributes which are not in use in Line 15: this part of code. Line 16: Line 9: This patch adds list of nosetests modules that makecheck will try to run Line 10: with python3. The initial work will allow to add more verified tests to Line 11: that list until covering all of them. Line 12: Changes in code are minimal - using configparser which contains same Line 13: implementation as python2 ConfigParser and use io.StringIO instead of Separate StringIO change to another patch? Line 14: StringIO which are different in some attributes which are not in use in Line 15: this part of code. Line 16: Line 17: Change-Id: I83355cce2af9125e6f017017905056956cd17081 -- To view, visit https://gerrit.ovirt.org/48051 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83355cce2af9125e6f017017905056956cd17081 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: hsm : Do not resize on disconnectStorageServer
Nir Soffer has posted comments on this change. Change subject: hsm : Do not resize on disconnectStorageServer .. Patch Set 1: Francesco, are you waiting for something? -- To view, visit https://gerrit.ovirt.org/48705 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78e236a851b7a0e9ab8f3c86e180cc50fde4ad56 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Freddy Rolland Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: Remove unused setMetadata
Nir Soffer has posted comments on this change. Change subject: sd: Remove unused setMetadata .. Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/45613/8//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-11-18 11:43:56 +0200 Line 6: Line 7: sd: Remove unused setMetadata Line 8: Line 9: sd setMetadata have been added but never used. Can you point me to the commit that added it? (it may be in the rhev-3.0 branch). Line 10: Line 11: Therefore, not needed. Line 12: As a result, the backup directory for sd MD Line 13: creation and default values are also removed. -- To view, visit https://gerrit.ovirt.org/45613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
Arik Hadas has abandoned this change. Change subject: proposal for bz 1282239 .. Abandoned -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
gerrit-hooks has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sd: Remove unused setMetadata
Nir Soffer has posted comments on this change. Change subject: sd: Remove unused setMetadata .. Patch Set 8: Code-Review+1 Thanks for this cleanup! Vdsm feels less dirty now :-) Waiting for Piotr approval on the infra related changes. -- To view, visit https://gerrit.ovirt.org/45613 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
Nir Soffer has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 4: Thanks Arik, we will continue with this. -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Nir Soffer has submitted this change and it was merged. Change subject: gluster: Fixing connection when server is not one of the bricks .. gluster: Fixing connection when server is not one of the bricks When processing gluster connection info, volfileserver is set as provided by the admin and, using volume info, backup-volfile-servers option is set. However, there are use cases where gluster server and ovirt are configured differently regarding ip addresses and domain names. If volfileserver appears in volume info, it is removed in order to avoid mounting duplicate servers, otherwise, mounting duplicate servers is possible. Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Bug-Url: https://bugzilla.redhat.com/1278880 Signed-off-by: Ala Hino Reviewed-on: https://gerrit.ovirt.org/48308 Continuous-Integration: Jenkins CI Reviewed-by: Sahina Bose Reviewed-by: Nir Soffer --- M tests/storageServerTests.py M vdsm/storage/storageServer.py 2 files changed, 27 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Sahina Bose: Looks good to me, but someone else must approve Ala Hino: Verified -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
gerrit-hooks has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 10: * #1278880::Update tracker: OK * Set MODIFIED::bug 1278880#1278880OK -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
Nir Soffer has posted comments on this change. Change subject: gluster: Fixing connection when server is not one of the bricks .. Patch Set 9: Thanks Ala! Can you backport? -- To view, visit https://gerrit.ovirt.org/48308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Bala.FA Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Prasanna Kumar Kalever Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
Arik Hadas has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 4: Yeah that's another option. Currently VDSM does not know that it operates on metadata volume, if we break this assumption we can have metadata volume specific handling which is better in terms of performance indeed. So I'll leave it for you guys then. At least I can use this patch as a workaround that will allow me to continue to work on my things. -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move instance validation
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move instance validation .. Patch Set 7: Needs another review -- To view, visit https://gerrit.ovirt.org/46384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bb27df116553f14931e9760e5968f02bd7d523b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move instance validation
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move instance validation .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bb27df116553f14931e9760e5968f02bd7d523b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: remove files properly on the node
Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: Continuous-Integration+1 unrelated ERROR: Tests mkimage.mkFloppyFs creating an image and checking its content. -- To view, visit https://gerrit.ovirt.org/48841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab83b3fad7679f8f3f459b682860a95e08d6b1e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move volumePath and validation
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move volumePath and validation .. Patch Set 7: Needs another review -- To view, visit https://gerrit.ovirt.org/46383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b38519df298d6e7b9a4bba2642d615976e0ea04 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move volumePath and validation
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move volumePath and validation .. Patch Set 7: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/46383/7/vdsm/storage/volume.py File vdsm/storage/volume.py: Line 190: Line 191: @property Line 192: def volumePath(self): Line 193: if self._volumePath is None: Line 194: self.validateVolumePath() Validate function with side effect?! We need to clean this later. Line 195: return self._volumePath Line 196: Line 197: def getVolumePath(self): Line 198: """ Line 193: if self._volumePath is None: Line 194: self.validateVolumePath() Line 195: return self._volumePath Line 196: Line 197: def getVolumePath(self): Why do we need a java like getter when we have a property?! Need to fix this later. Lets add a TODO file for these cleanups. Can be nice task for for new people. Line 198: """ Line 199: Get the path of the volume file/link Line 200: """ Line 201: if not self._volumePath: -- To view, visit https://gerrit.ovirt.org/46383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b38519df298d6e7b9a4bba2642d615976e0ea04 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move imagePath and validation
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move imagePath and validation .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d03085f04c92c1be68be2c0873e0545d307bdfa Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move imagePath and validation
Nir Soffer has posted comments on this change. Change subject: VolumeMetadata: Move imagePath and validation .. Patch Set 7: Needs another review -- To view, visit https://gerrit.ovirt.org/46382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d03085f04c92c1be68be2c0873e0545d307bdfa Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetestlib: use a real metadata file for FileSD manifests
gerrit-hooks has posted comments on this change. Change subject: storagetestlib: use a real metadata file for FileSD manifests .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48695 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e09b3e2199c638452214de4c2e4dfd826b51242 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetestlib: use a real metadata file for FileSD manifests
Nir Soffer has submitted this change and it was merged. Change subject: storagetestlib: use a real metadata file for FileSD manifests .. storagetestlib: use a real metadata file for FileSD manifests When building a fake FileStorageDomainManifest place the metadata in the right place within the domain's file hierarchy (as opposed to keeping it in memory). This is needed since code in VolumeMetadata sometimes instantiates its controlling manifest and the metadata must be present in the proper place when testing this code. Change-Id: I1e09b3e2199c638452214de4c2e4dfd826b51242 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/48695 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M tests/storagetestlib.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/48695 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e09b3e2199c638452214de4c2e4dfd826b51242 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetestlib: use a real metadata file for FileSD manifests
Nir Soffer has posted comments on this change. Change subject: storagetestlib: use a real metadata file for FileSD manifests .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/48695 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1e09b3e2199c638452214de4c2e4dfd826b51242 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: v2v: add test for commit f8127d8
Nir Soffer has posted comments on this change.
Change subject: tests: v2v: add test for commit f8127d8
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/47367/7/tests/v2vTests.py
File tests/v2vTests.py:
Line 276: self.assertEquals(disk['dev'], 'sda')
Line 277: self.assertEquals(disk['alias'],
Line 278: '[datastore1] RHEL/RHEL_%s.vmdk' %
spec.name)
Line 279: self.assertIn('capacity', disk)
Line 280: self.assertIn('allocation', disk)
Can you separate this part (creating _assertVmMatchesSpec and
_assertVmDisksMatchSpec) to another patch?
I find it hard to understand these moves.
Line 281:
Line 282: def _assertVmMatchesSpec(self, vm, spec):
Line 283: self.assertEquals(vm['vmId'], spec.vmid)
Line 284: self.assertEquals(vm['memSize'], 2048)
--
To view, visit https://gerrit.ovirt.org/47367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38bd3c06df263bc208e1a8c8aa6c0081ebdc218d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Notice imageSyncVolumeChain errors
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Notice imageSyncVolumeChain errors .. Patch Set 2: * #1214342::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1214342::OK, public bug * Check Product::#1214342::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/45387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5447d06b6aade97f71a3b7d6d7c73f9699c307d0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Notice imageSyncVolumeChain errors
Nir Soffer has posted comments on this change. Change subject: Live Merge: Notice imageSyncVolumeChain errors .. Patch Set 1: Needs another review -- To view, visit https://gerrit.ovirt.org/45387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5447d06b6aade97f71a3b7d6d7c73f9699c307d0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Notice imageSyncVolumeChain errors
Nir Soffer has posted comments on this change. Change subject: Live Merge: Notice imageSyncVolumeChain errors .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/45387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5447d06b6aade97f71a3b7d6d7c73f9699c307d0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Drain pending bytes from ssl socket
Nir Soffer has posted comments on this change. Change subject: stomp: Drain pending bytes from ssl socket .. Patch Set 4: Verified+1 Verified on rhel7: - Create 2 vms from tempate - Start vms - Migrate couple of times - Stop - Remove -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea37c35c871ae286863c5d4403bcf71ac803da5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Drain pending bytes from ssl socket
Nir Soffer has posted comments on this change. Change subject: stomp: Drain pending bytes from ssl socket .. Patch Set 4: And also run the stompTests with both ssl and m2c. -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea37c35c871ae286863c5d4403bcf71ac803da5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: check operation result for vm nic hotunplug
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/48473/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2665: self._cleanupDrives(drive)
Line 2666:
Line 2667: return {'status': doneCode, 'vmList': self.status()}
Line 2668:
Line 2669: def _waitForDeviceRemoval(self, device):
This can be good point to add a test.
- Mock vm._dom so it will return fake fake xml from a list of xmls.
- call waitForDriveRemoval (this test should come before this patch)
- Mock the configuration so we timeout after 1 second
- Change the time.sleep(1) to get the sleep delay from the config - in a
separte patch before the test patch.
- Mock the sleep time to 0.1 seconds
- Test one xml without the device for testing the special case of quick removal
- The last xml in the list will be one without the device for testing
successful removal.
- The last xml will contain the device for testing timeut.
The only change needed to adapt to this patch is a rename and add tests for nic.
Line 2670: """
Line 2671: As stated in libvirt documentary, after detaching a device
using
Line 2672: virDomainDetachDeviceFlags, we need to verify that this
device
Line 2673: has actually been detached:
Line 2692: if utils.monotonic_time() > deadline:
Line 2693: raise HotunplugTimeout("Timeout detaching device
%s"
Line 2694:% device.name)
Line 2695:
Line 2696: def _is_device_attached(self, device):
This method is clumsy. When method starts with is, it should be about the
object (the vm), not about the argument.
What if we move it to the device?
device.is_attached_to(self._dom)
Should be in another patch, after this one, since it is not required to make
this reusable.
Line 2697: root = ET.fromstring(self._dom.XMLDesc(0))
Line 2698: return bool(root.findall(device.xpath))
Line 2699:
Line 2700: def _readPauseCode(self):
https://gerrit.ovirt.org/#/c/48473/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 425:
Line 426: @property
Line 427: def xpath(self):
Line 428: """
Line 429: Returns an xpath to the device in libvirt dom xml
an xpath?
Line 430: The path is relative to the root element"""
Line 431: source_key = {DISK_TYPE.FILE: 'file',
Line 432: DISK_TYPE.BLOCK: 'dev',
Line 433: DISK_TYPE.NETWORK: 'name'}
Line 426: @property
Line 427: def xpath(self):
Line 428: """
Line 429: Returns an xpath to the device in libvirt dom xml
Line 430: The path is relative to the root element"""
Use this format for docstrings:
"""
Text...
"""
Same for other modules.
Line 431: source_key = {DISK_TYPE.FILE: 'file',
Line 432: DISK_TYPE.BLOCK: 'dev',
Line 433: DISK_TYPE.NETWORK: 'name'}
Line 434: return "./devices/disk/source[@%s='%s']" \
--
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: check operation result for vm nic hotunplug
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 4: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug * Check Public Bug::#1199782::OK, public bug * Check Product::#1134256::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1199782::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Drain pending bytes from ssl socket
Nir Soffer has posted comments on this change. Change subject: stomp: Drain pending bytes from ssl socket .. Patch Set 4: This version reads all the pending bytes in the second read, instead of reading bufferSize bytes each time. This may decrease the amount of syscalls. -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea37c35c871ae286863c5d4403bcf71ac803da5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Drain pending bytes from ssl socket
gerrit-hooks has posted comments on this change. Change subject: stomp: Drain pending bytes from ssl socket .. Patch Set 4: * #1274670::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1274670::OK, public bug * Check Product::#1274670::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea37c35c871ae286863c5d4403bcf71ac803da5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: check operation result for vm nic hotunplug
Nir Soffer has posted comments on this change.
Change subject: vm: check operation result for vm nic hotunplug
..
Patch Set 3:
(4 comments)
Nice! but we must have tests before doing this refactoring.
https://gerrit.ovirt.org/#/c/48473/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2236: self.saveState()
Line 2237:
Line 2238: try:
Line 2239: self._dom.detachDevice(nicXml)
Line 2240: mac = nicParams['macAddr']
Why do we need this variable here?
Line 2241: self._waitForDeviceRemoval(nic)
Line 2242: except HotunplugTimeout as e:
Line 2243: self.log.error("%s", e)
Line 2244: return response.error('hotunplugNic', "%s" % e)
Line 2682: is true. Bug 1257280 opened for fixing the documentation.)
Line 2683: TODO: remove this comment when the documentation will be
fixed.
Line 2684:
Line 2685: :param device_name: Device name for logging purposes
Line 2686: :device_search_patch XPath query for the detached device
Please update - we get only one parameter now.
Line 2687: """
Line 2688: self.log.debug("Waiting for hotunplug to finish")
Line 2689: with utils.stopwatch("Hotunplug device %s" % device.name):
Line 2690: deadline = (utils.monotonic_time() +
https://gerrit.ovirt.org/#/c/48473/3/vdsm/virt/vmdevices/network.py
File vdsm/virt/vmdevices/network.py:
Line 184: else:
Line 185: raise Exception('Tried to detach a non host device: %s' %
(
Line 186: self.conf,))
Line 187:
Line 188: def get_device_path(self):
Lets call it xpath and make it a readonly property:
@property
def xpath(self):
return "./devices/interface/mac[@address='%s']" % self.macAddr
Now we can do this in client code:
isDeviceAttached(device):
return bool(root.findall(device.xpath))
Line 189: """
Line 190: Returns an xpath to the device in libvirt dom xml
Line 191: The path is relative to the root element"""
https://gerrit.ovirt.org/#/c/48473/3/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 422:
Line 423: if hasattr(self, 'specParams') and 'ioTune' in
self.specParams:
Line 424: self._validateIoTuneParams(self.specParams['ioTune'])
Line 425:
Line 426: def get_device_path(self):
Should be a property, see my comment in vmdevices/network.py
Line 427: """
Line 428: Returns an xpath to the device in libvirt dom xml
Line 429: The path is relative to the root element"""
Line 430: source_key = {DISK_TYPE.FILE: 'file',
--
To view, visit https://gerrit.ovirt.org/48473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: check operation result for vm nic hotunplug
Nir Soffer has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 3: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/48473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
Nir Soffer has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 4: Code-Review-2 (1 comment) https://gerrit.ovirt.org/#/c/48844/4/vdsm/storage/image.py File vdsm/storage/image.py: Line 238: # Build up the sorted parent -> child chain Line 239: while not srcVol.isShared(): Line 240: if srcVol.getFormat() == volume.COW_FORMAT: Line 241: if volume.name2type(qemuimg.info(srcVol.getVolumePath())['format']) == volume.RAW_FORMAT: Line 242: srcVol.setFormat(volume.RAW_FORMAT) We cannot do this in this flow. Image checking 5000 volumes, this will run qemu-img 5000 times. Repairing volume metadata must be explicit operation for single disk, and only fot metadata images. Line 243: seen.add(srcVol.volUUID) Line 244: Line 245: parentUUID = srcVol.getParent() Line 246: if parentUUID == volume.BLANK_UUID: -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: check operation result for vm nic hotunplug
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 3: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1134256::OK, public bug * Check Public Bug::#1199782::OK, public bug * Check Product::#1134256::OK, Correct product Red Hat Enterprise Virtualization Manager * Check Product::#1199782::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: logUtils: Process SimpleLogAdapter's context once
Nir Soffer has posted comments on this change. Change subject: logUtils: Process SimpleLogAdapter's context once .. Patch Set 4: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/48552 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I32bbafb6ef60d118e2341f081d036107406a43a4 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Arik Hadas has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Done -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test both ssl and m2c
Nir Soffer has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/48823/2/tests/stompTests.py File tests/stompTests.py: Line 55: @expandPermutations Line 56: class StompTests(TestCaseBase): Line 57: Line 58: @permutations([[size, impl] Line 59:for impl in ['ssl', 'm2c'] Use [None, 'ssl', 'm2c'] Line 60:for size in [1, 1024, 4096, 16384]]) Line 61: def test_echo(self, size, impl): Line 62: data = dummyTextGenerator(size) Line 63: sslctx = integration.get_context(impl) Line 59:for impl in ['ssl', 'm2c'] Line 60:for size in [1, 1024, 4096, 16384]]) Line 61: def test_echo(self, size, impl): Line 62: data = dummyTextGenerator(size) Line 63: sslctx = integration.get_context(impl) And: sslctx = integration.get_context(impl) if impl else None dispatcher = integration.get_dispatcher(impl) if impl else None Line 64: with MonkeyPatchScope([(protocoldetector, 'SSLHandshakeDispatcher', Line 65: integration.get_dispatcher(impl))]): Line 66: with constructAcceptor(self.log, sslctx, Line 67:_SampleBridge()) as acceptor: -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
gerrit-hooks has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test both ssl and m2c
Nir Soffer has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: (1 comment) Much nicer! but we need also to test no ssl. https://gerrit.ovirt.org/#/c/48823/2/tests/integration/__init__.py File tests/integration/__init__.py: Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: from . import m2chelper, sslhelper Can you import m2chelper if M2Crypto is not installed (e.g. on debian)? Line 21: from vdsm import m2cutils, sslutils Line 22: Line 23: Line 24: def get_context(impl): -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Arik, can you get jenkins to be happy with your patch, or explain the failures? -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Live Merge: Notice imageSyncVolumeChain errors
Adam Litke has posted comments on this change. Change subject: Live Merge: Notice imageSyncVolumeChain errors .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/45387 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5447d06b6aade97f71a3b7d6d7c73f9699c307d0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
gerrit-hooks has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: daemon: autodisable cpu affinity on singlecore
Nir Soffer has posted comments on this change.
Change subject: daemon: autodisable cpu affinity on singlecore
..
Patch Set 4: Code-Review-1
(4 comments)
https://gerrit.ovirt.org/#/c/48619/4//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-11-16 14:42:54 +0100
Line 4: Commit: Francesco Romani
Line 5: CommitDate: 2015-11-17 13:16:19 +0100
Line 6:
Line 7: daemon: autodisable cpu affinity on singlecore
Lets use the term processor, one core can have multiple processors.
Line 8:
Line 9: If VDSM runs on single-core hosts (E.g. VMs, QE boxes)
Line 10: there is no point in enabling cpu affinity, since
Line 11: we already reached the goal of running on just one CPU.
Line 5: CommitDate: 2015-11-17 13:16:19 +0100
Line 6:
Line 7: daemon: autodisable cpu affinity on singlecore
Line 8:
Line 9: If VDSM runs on single-core hosts (E.g. VMs, QE boxes)
QE boxes are vms usually.
Line 10: there is no point in enabling cpu affinity, since
Line 11: we already reached the goal of running on just one CPU.
Line 12:
Line 13: Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
https://gerrit.ovirt.org/#/c/48619/4/vdsm/vdsm
File vdsm/vdsm:
Line 229: log.info('VDSM will run with cpu affinity: %s', cpu_set)
Line 230:
Line 231: # too early to use the facilities from caps.py
Line 232: if os.sysconf('SC_NPROCESSORS_ONLN') == 1:
Line 233: log.warning('Only one cpu detected: affinity disabled')
This is correct for this case (run on second processor, having only one
processor). What about other configurations, like run on cpu 4, having only 4
processors (0,1,2,3)?
I think this is good enough for now, to unbreak the tests, but we should come
up with better error handling.
Line 234: else:
Line 235: taskset.set(os.getpid(), cpu_set, all_tasks=True)
Line 236:
Line 237:
Line 231: # too early to use the facilities from caps.py
Line 232: if os.sysconf('SC_NPROCESSORS_ONLN') == 1:
Line 233: log.warning('Only one cpu detected: affinity disabled')
Line 234: else:
Line 235: taskset.set(os.getpid(), cpu_set, all_tasks=True)
Please keep the early return style.
Line 236:
Line 237:
Line 238: def main():
Line 239: __assertVdsmUser()
--
To view, visit https://gerrit.ovirt.org/48619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move instance validation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move instance validation .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/46384 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bb27df116553f14931e9760e5968f02bd7d523b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move imagePath and validation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move imagePath and validation .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/46382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d03085f04c92c1be68be2c0873e0545d307bdfa Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: VolumeMetadata: Move volumePath and validation
gerrit-hooks has posted comments on this change. Change subject: VolumeMetadata: Move volumePath and validation .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/46383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b38519df298d6e7b9a4bba2642d615976e0ea04 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
gerrit-hooks has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
Arik Hadas has uploaded a new change for review. Change subject: proposal for bz 1282239 .. proposal for bz 1282239 Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Signed-off-by: Arik Hadas --- M vdsm/storage/image.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/48844/1 diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index 956c805..c12cea8 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -236,6 +236,9 @@ # Build up the sorted parent -> child chain while not srcVol.isShared(): +if srcVol.getFormat() == volume.COW_FORMAT and \ +volume.RAW_FORMAT == qemuimg.info(srcVol.getVolumePath)['format']: +srcVol.format = volume.RAW_FORMAT chain.insert(0, srcVol) seen.add(srcVol.volUUID) -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: proposal for bz 1282239
gerrit-hooks has posted comments on this change. Change subject: proposal for bz 1282239 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48844 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idace47c18673e250f3f612a20a15ae5c62565082 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test both ssl and m2c
Piotr Kliczewski has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: Interesting my pyflakes did not complain about it. Will fix the build as well. -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test both ssl and m2c
Piotr Kliczewski has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: Code-Review-1 still integration tests need fixing but stompTests are running OK. -1 for visibility -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Drain pending bytes from SSLConnection
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Drain pending bytes from SSLConnection .. Patch Set 3: Code-Review+2 Verified+1 Rebase only. Copying verification flag and score from previous patch set. -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea37c35c871ae286863c5d4403bcf71ac803da5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Drain pending bytes from SSLConnection
gerrit-hooks has posted comments on this change. Change subject: stomp: Drain pending bytes from SSLConnection .. Patch Set 3: * #1274670::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1274670::OK, public bug * Check Product::#1274670::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ea37c35c871ae286863c5d4403bcf71ac803da5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Test both ssl and m2c
gerrit-hooks has posted comments on this change. Change subject: tests: Test both ssl and m2c .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48823 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: remove files properly on the node
gerrit-hooks has posted comments on this change. Change subject: ifcfg: remove files properly on the node .. Patch Set 1: * #1283628::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1283628::OK, public bug * Check Product::#1283628::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48841 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab83b3fad7679f8f3f459b682860a95e08d6b1e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: remove files properly on the node
Dan Kenigsberg has uploaded a new change for review.
Change subject: ifcfg: remove files properly on the node
..
ifcfg: remove files properly on the node
Since change-id I02ae28c345 we are always persisting ifcfg files on the
node. This means that we should unpersist them on removal.
Change-Id: I2ab83b3fad7679f8f3f459b682860a95e08d6b1e
Bug-Url: https://bugzilla.redhat.com/1283628
Signed-off-by: Dan Kenigsberg
---
M vdsm/network/configurators/ifcfg.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/48841/1
diff --git a/vdsm/network/configurators/ifcfg.py
b/vdsm/network/configurators/ifcfg.py
index 0d41f36..b6a47af 100644
--- a/vdsm/network/configurators/ifcfg.py
+++ b/vdsm/network/configurators/ifcfg.py
@@ -389,7 +389,7 @@
logging.info("Rolling back configuration (restoring atomic backup)")
for confFilePath, content in self._backups.iteritems():
if content is None:
-utils.rmFile(confFilePath)
+self._removeFile(confFilePath)
logging.debug('Removing empty configuration backup %s',
confFilePath)
else:
--
To view, visit https://gerrit.ovirt.org/48841
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ab83b3fad7679f8f3f459b682860a95e08d6b1e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: v2v: add test for commit f8127d8
Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 7: ..and re-verified running the tests (actually checked they do the right thing, not just blindly observed the green OK) -- To view, visit https://gerrit.ovirt.org/47367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38bd3c06df263bc208e1a8c8aa6c0081ebdc218d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: v2v: add test for commit f8127d8
Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 7: Verified+1 simplified -- To view, visit https://gerrit.ovirt.org/47367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38bd3c06df263bc208e1a8c8aa6c0081ebdc218d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: better rollback
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: better rollback .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/46907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: better rollback
Dan Kenigsberg has submitted this change and it was merged. Change subject: hooks: ovs: better rollback .. hooks: ovs: better rollback Until now, OVS hook was not able to rollback after failed setup of non-OVS networks. Now it uses after_network_setup and after_network_setup_fail hook points to handle general rollback for all failures (both OVS and non-OVS). Before OVS setup we save initial OVS configuration to a temporary file via pickle. If an exception occurs during setupNetworks, API.py does the standard rollback. Then after_network_setup_fail is executed and runs setupNetworks with a special option _inOVSRollback which triggers OVS-only rollback. OVS-only rollback removes all OVS networks and recreates them according to configuration saved in the temprorary file. When everything is done, temporary file is removed. Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/46907 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M debian/vdsm-hook-ovs.install M vdsm.spec.in M vdsm_hooks/ovs/Makefile.am M vdsm_hooks/ovs/README A vdsm_hooks/ovs/ovs_after_network_setup.py A vdsm_hooks/ovs/ovs_after_network_setup_fail.py M vdsm_hooks/ovs/ovs_before_network_setup.py M vdsm_hooks/ovs/ovs_utils.py 8 files changed, 240 insertions(+), 94 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/46907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543 Gerrit-PatchSet: 18 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: better rollback
Dan Kenigsberg has posted comments on this change. Change subject: hooks: ovs: better rollback .. Patch Set 17: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/46907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: v2v: add test for commit f8127d8
gerrit-hooks has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38bd3c06df263bc208e1a8c8aa6c0081ebdc218d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: better rollback
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: better rollback .. Patch Set 17: Verified+1 Passed without a regression. Connectivity check is working. -- To view, visit https://gerrit.ovirt.org/46907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: v2v: add test for commit f8127d8
Francesco Romani has posted comments on this change. Change subject: tests: v2v: add test for commit f8127d8 .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/47367/6/tests/v2vTests.py File tests/v2vTests.py: Line 186: raise fake.Error(libvirt.VIR_ERR_INTERNAL_ERROR) Line 187: Line 188: # Cause vm 1 to fail, so it would not appear in results Line 189: vms[1].XMLDesc = internal_error Line 190: del specs[1] > Can we do this on the top were you define specs? "flat is better than nested" :) Let me try to simplify this, starting from where you suggested Line 191: return LibvirtMock(vms=vms) Line 192: Line 193: with MonkeyPatchScope([(libvirtconnection, 'open_connection', Line 194: _connect)]): -- To view, visit https://gerrit.ovirt.org/47367 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38bd3c06df263bc208e1a8c8aa6c0081ebdc218d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple
Petr Horáček has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: Verified+1 Passed functional networkTestsOVS.py without a regression -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks
Petr Horáček has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 12: Verified+1 Passed functional networkTestsOVS.py without a regression -- To view, visit https://gerrit.ovirt.org/46692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: daemon: autodisable cpu affinity on singlecore
Petr Horáček has posted comments on this change. Change subject: daemon: autodisable cpu affinity on singlecore .. Patch Set 4: Verified+1 Code-Review+1 Fixed: Command ['/usr/bin/taskset', '--all-tasks', '--pid', '--cpu-list', '1', '2088'] failed with rc=1 out=["pid 2088's current affinity list: 0"] err=["taskset: failed to set pid 2088's affinity: Invalid argument"] for me. -- To view, visit https://gerrit.ovirt.org/48619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0652189704cbce71d20ec809c9c26f081516758a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks
Petr Horáček has posted comments on this change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/46692/11/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File vdsm_hooks/ovs/ovs_before_network_setup_ip.py:
Line 113: with suppress(ipwrapper.IPRoute2Error): # device does not
exist
Line 114: ipwrapper.addrFlush(iface)
Line 115:
Line 116:
Line 117: def _drop_ip_config(iface):
> I don't understand, this is not what this function really does
it drops ip configuration if passed iface, what's wrong with it? the 'drop'?
Line 118: """Remove IP configuration of a new nic controlled by VDSM"""
Line 119: if os.path.exists(os.path.join('/sys/class/net', iface)):
Line 120: kill_dhclient(iface, family=4) # kill_dhclient flushes IP
Line 121: kill_dhclient(iface, family=6)
Line 133:
Line 134: ip_config_to_set = {}
Line 135: ip_config_to_remove = {}
Line 136:
Line 137: for net, attrs in nets.iteritems():
> what do you mean by newly attached nics?
nics which were not a part of the network before. for example if we attach a
new nic which was just standalone before. when we use ifcfg it creates ifcfg
config file and removes initial nic's ip by itself, here we have to do it
manually.
Line 138: if 'remove' in attrs: # if network was removed
Line 139: # remove network's IP configuration (running dhclient)
Line 140: ip_config = _gather_ip_config(init_nets[net])
Line 141: ip_config_to_remove[ip_config.top_dev] = ip_config
--
To view, visit https://gerrit.ovirt.org/46692
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Ido Barkan
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Francesco Romani has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Code-Review+2 Right, I missed (for completely silly reasons) to point out to check and fix this in review of Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Arik Hadas has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple
Petr Horáček has uploaded a new change for review.
Change subject: hooks: ovs: pass ip configuration as a namedtuple
..
hooks: ovs: pass ip configuration as a namedtuple
Signed-off-by: Petr Horáček
Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664
---
M vdsm_hooks/ovs/ovs_before_network_setup_ip.py
1 file changed, 37 insertions(+), 21 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/48830/1
diff --git a/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
b/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
index 90640a4..e8f5bce 100644
--- a/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
+++ b/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
@@ -17,6 +17,7 @@
#
# Refer to the README and COPYING files for full details of the license
#
+from collections import namedtuple
import sys
from vdsm import ipwrapper, sysctl
@@ -34,6 +35,9 @@
iproute2 = Iproute2()
+
+IPConfig = namedtuple('IPConfig', ['top_dev', 'ipv4', 'ipv6', 'port',
+ 'blocking_dhcp'])
def _get_ipv4_model(attrs):
@@ -61,9 +65,15 @@
hooking.log('failed to start dhclient%s on iface %s' % (family, iface))
-def _set_ip_config(iface, ipv4, ipv6, port, blockingdhcp):
+def _set_ip_config(ip_config):
+iface = ip_config.top_dev
+ipv4 = ip_config.ipv4
+ipv6 = ip_config.ipv6
+port = ip_config.port
+blocking_dhcp = ip_config.blocking_dhcp
+
net_dev = NetDevice(iface, iproute2, ipv4=ipv4, ipv6=ipv6,
-blockingdhcp=blockingdhcp)
+blockingdhcp=blocking_dhcp)
DynamicSourceRoute.addInterfaceTracking(net_dev)
ipwrapper.linkSet(iface, ['down'])
if ipv4.address:
@@ -83,13 +93,17 @@
ipwrapper.linkSet(port, ['up'])
ipwrapper.linkSet(iface, ['up'])
if ipv4.bootproto == 'dhcp':
-_run_dhclient(iface, blockingdhcp, ipv4.defaultRoute, 4)
+_run_dhclient(iface, blocking_dhcp, ipv4.defaultRoute, 4)
if ipv6.dhcpv6:
-_run_dhclient(iface, blockingdhcp, ipv6.defaultRoute, 6)
+_run_dhclient(iface, blocking_dhcp, ipv6.defaultRoute, 6)
iproute2._addSourceRoute(net_dev)
-def _remove_ip_config(iface, ipv4, ipv6):
+def _remove_ip_config(ip_config):
+iface = ip_config.top_dev
+ipv4 = ip_config.ipv4
+ipv6 = ip_config.ipv6
+
net_dev = NetDevice(iface, iproute2, ipv4=ipv4, ipv6=ipv6)
DynamicSourceRoute.addInterfaceTracking(net_dev)
DhcpClient(iface).shutdown()
@@ -100,28 +114,30 @@
def configure_ip(nets, init_nets):
+
+def _gather_ip_config(attrs):
+top_dev = net if 'vlan' in attrs else BRIDGE_NAME
+ipv4 = _get_ipv4_model(attrs)
+ipv6 = _get_ipv6_model(attrs)
+port = attrs.get('nic') or attrs.get('bonding')
+blocking_dhcp = 'blockingdhcp' in attrs
+return IPConfig(top_dev, ipv4, ipv6, port, blocking_dhcp)
+
ip_config_to_set = {}
ip_config_to_remove = {}
for net, attrs in nets.items():
if net in init_nets:
-init_attrs = init_nets[net]
-init_top_dev = net if 'vlan' in init_attrs else BRIDGE_NAME
-ipv4 = _get_ipv4_model(init_attrs)
-ipv6 = _get_ipv6_model(init_attrs)
-ip_config_to_remove[init_top_dev] = ipv4, ipv6
+init_ip_config = _gather_ip_config(init_nets[net])
+ip_config_to_remove[init_ip_config.top_dev] = init_ip_config
if 'remove' not in attrs:
-top_dev = net if 'vlan' in attrs else BRIDGE_NAME
-ipv4 = _get_ipv4_model(attrs)
-ipv6 = _get_ipv6_model(attrs)
-port = attrs.get('nic') or attrs.get('bonding')
-if ipv4 or ipv6:
-ip_config_to_set[top_dev] = (
-ipv4, ipv6, port, 'blockingdhcp' in attrs)
+ip_config = _gather_ip_config(attrs)
+if ip_config.ipv4 or ip_config.ipv6:
+ip_config_to_set[ip_config.top_dev] = ip_config
hooking.log('Remove IP configuration of: %s' % ip_config_to_remove)
hooking.log('Set IP configuration: %s' % ip_config_to_set)
-for iface, (ipv4, ipv6) in ip_config_to_remove.iteritems():
-_remove_ip_config(iface, ipv4, ipv6)
-for iface, (ipv4, ipv6, blockingdhcp, port) in ip_config_to_set.items():
-_set_ip_config(iface, ipv4, ipv6, blockingdhcp, port)
+for iface, ip_config in ip_config_to_remove.iteritems():
+_remove_ip_config(ip_config)
+for iface, ip_config in ip_config_to_set.items():
+_set_ip_config(ip_config)
--
To view, visit https://gerrit.ovirt.org/48830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lis
Change in vdsm[master]: net: ovs: remove initial nic ip, dont touch unchanged networks
gerrit-hooks has posted comments on this change. Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/46692 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9682c75cfb79f75b64cb8cb587fc3ed01cf15c8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple
gerrit-hooks has posted comments on this change. Change subject: hooks: ovs: pass ip configuration as a namedtuple .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48830 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: check operation result for vm nic hotunplug
Francesco Romani has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 2: Marcin, please address comments from Nir. In followup patches, we can make waitForDriveRemoval reusable and add tests for it. I can take care of this (albeit with fairly low prio due to other things preempting). -- To view, visit https://gerrit.ovirt.org/48473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d3b2c839cbb4733aecc8d5a0e9a1ae691e14ac3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: slow data read when connected from localhost
Piotr Kliczewski has posted comments on this change. Change subject: stomp: slow data read when connected from localhost .. Patch Set 2: Yes. Once the other patch is merged I will abandon this one. -- To view, visit https://gerrit.ovirt.org/48608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.conf: Add drop-in dir
Fabian Deutsch has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/48317/3/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 454: Line 455: config = configparser.ConfigParser() Line 456: set_defaults(config) Line 457: Line 458: def read_configs(pkgname, paths=["/usr/lib/", "/run/", "/etc/"]): This is how (roughly) config file reading should work for all our components, it would very much help to separate defaults/vendor presets from user changes, and it can improve the Node experience. Line 459: """This function is reading config files in a specific scheme Line 460: Line 461: The function reads - for one component - config files from several Line 462: locations and in addition it is also reading configuration snippets -- To view, visit https://gerrit.ovirt.org/48317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.conf: Add drop-in dir
gerrit-hooks has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 3: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check Product::#1279555::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48317 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm.conf: Add drop-in dir
Fabian Deutsch has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 2:
(1 comment)
Right, I'm also fine with that. Let me push aa patch with a more generic
function which illustrates how config file reading should be improved.
https://gerrit.ovirt.org/#/c/48317/2/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 455: config = ConfigParser.ConfigParser()
Line 456: set_defaults(config)
Line 457:
Line 458: # Read from teh config file first
Line 459: vdsmconf [os.path.join('@CONFDIR@', 'vdsm.conf')]
> s/teh/the
Doh - Yes, I'll fix it.
Line 460: config.read([os.path.join('@CONFDIR@', 'vdsm.conf')])
Line 461:
Line 462: # Also read files in the drop-in dir
Line 463: vdsmconfd = vdsmconf + '.d')
--
To view, visit https://gerrit.ovirt.org/48317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I707a1865e8d60dc4dcdc0e681b52c07c75f1c409
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fabian Deutsch
Gerrit-Reviewer: Fabian Deutsch
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: slow data read when connected from localhost
Nir Soffer has posted comments on this change. Change subject: stomp: slow data read when connected from localhost .. Patch Set 2: If we go with https://gerrit.ovirt.org/48803, we can abandon this one, right? -- To view, visit https://gerrit.ovirt.org/48608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Code-Review+2 Waiting for Francesco review. -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Arik Hadas has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Done -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
gerrit-hooks has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
