Change in vdsm[master]: sdc: Safer way to access storage domain manifest

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdc: Safer way to access storage domain manifest
..


Patch Set 4:

Ping.  This is needed for SDM.copy_data

-- 
To view, visit https://gerrit.ovirt.org/58879
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib274c58fc60f40a9f7396d6be05dfe9b461bc2c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rename execCmd and startCmd to run_cmd and start_cmd

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rename execCmd and startCmd to run_cmd and start_cmd
..


Patch Set 1:

Please do this change before creating startCmd.

-- 
To view, visit https://gerrit.ovirt.org/60280
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e271c07f204c405483c24b03b2792a25bf4256d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rename execCmd and startCmd to run_cmd and start_cmd

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rename execCmd and startCmd to run_cmd and start_cmd
..


Patch Set 1:

Looks nice, will review later.

-- 
To view, visit https://gerrit.ovirt.org/60280
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e271c07f204c405483c24b03b2792a25bf4256d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Unify getVolumeLease signature

[alitke]

Adam Litke has posted comments on this change.

Change subject: sd: Unify getVolumeLease signature
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85d3f754c266ce5296d2e52ec9bd544728723a94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

[alitke]

Adam Litke has posted comments on this change.

Change subject: sd: Move getVolumeLease to StorageDomainManifest
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60282
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60b35e9a41d73ecba741d6fb9f90cdaeb35b3e3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

[automation]

gerrit-hooks has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 5:

* #1344289::Update tracker: OK
* Set MODIFIED::bug 1344289#1344289OK

-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


verify_untrusted_volume: Only allow compat designated by config

Currently each host sets which qemuimg compat level is allowed.  Use
this setting also during volume verification until 0.10 and 1.1 can be
supported at the same time.

Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344289
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/60113
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M tests/storage_hsm_test.py
M vdsm/storage/hsm.py
2 files changed, 26 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Move getVolumeLease to StorageDomainManifest
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60282
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60b35e9a41d73ecba741d6fb9f90cdaeb35b3e3b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: sd: Move getVolumeLease to StorageDomainManifest
..

sd: Move getVolumeLease to StorageDomainManifest

We need to acquire volume leases from any host during data operations.
The method moved to the StorageDomainManifest subclasses.

Based on Adam patch: https://gerrit.ovirt.org/38622.

Change-Id: I60b35e9a41d73ecba741d6fb9f90cdaeb35b3e3b
Signed-off-by: Nir Soffer 
---
M tests/sdm_indirection_tests.py
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/sd.py
4 files changed, 39 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/60282/1

diff --git a/tests/sdm_indirection_tests.py b/tests/sdm_indirection_tests.py
index 686afb0..16e2291 100644
--- a/tests/sdm_indirection_tests.py
+++ b/tests/sdm_indirection_tests.py
@@ -229,6 +229,10 @@
 def acquireVolumeMetadataSlot(self, vol_name, slotSize):
 yield
 
+@recorded
+def getVolumeLease(self, imgUUID, volUUID):
+pass
+
 
 class FakeFileDomainManifest(FakeDomainManifest):
 def __init__(self):
@@ -253,6 +257,10 @@
 
 @recorded
 def getIdsFilePath(self):
+pass
+
+@recorded
+def getVolumeLease(self, imgUUID, volUUID):
 pass
 
 
@@ -703,6 +711,7 @@
 ['refreshDirTree', 0],
 ['refresh', 0],
 ['validateCreateVolumeParams', 3],
+['getVolumeLease', 2],
 ])
 def test_common_functions(self, fn, nargs):
 self.checker.check_method_call(fn, nargs)
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index d79697f..2b9ba06 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -797,6 +797,18 @@
 if preallocate == sc.SPARSE_VOL and volFormat == sc.RAW_FORMAT:
 raise se.IncorrectFormat(sc.type2name(volFormat))
 
+def getVolumeLease(self, imgUUID, volUUID):
+"""
+Return the volume lease (leasePath, leaseOffset)
+"""
+if self.hasVolumeLeases():
+# TODO: use the sanlock specific offset when present
+leaseSlot = self.produceVolume(imgUUID, volUUID).getMetaOffset()
+leaseOffset = ((leaseSlot + blockVolume.RESERVED_LEASES) *
+   self.logBlkSize * sd.LEASE_BLOCKS)
+return self.getLeasesFilePath(), leaseOffset
+return None, None
+
 
 class BlockStorageDomain(sd.StorageDomain):
 manifestClass = BlockStorageDomainManifest
@@ -1196,18 +1208,6 @@
 lvm.activateLVs(self.sdUUID, volUUIDs)
 vgDir = os.path.join("/dev", self.sdUUID)
 return self.createImageLinks(vgDir, imgUUID, volUUIDs)
-
-def getVolumeLease(self, imgUUID, volUUID):
-"""
-Return the volume lease (leasePath, leaseOffset)
-"""
-if self.hasVolumeLeases():
-# TODO: use the sanlock specific offset when present
-leaseSlot = self.produceVolume(imgUUID, volUUID).getMetaOffset()
-leaseOffset = ((leaseSlot + blockVolume.RESERVED_LEASES) *
-   self.logBlkSize * sd.LEASE_BLOCKS)
-return self.getLeasesFilePath(), leaseOffset
-return None, None
 
 def validateMasterMount(self):
 return mount.isMounted(self.getMasterDir())
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index d3e0c29..0515e70 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -324,6 +324,17 @@
 images.add(os.path.basename(i))
 return images
 
+def getVolumeLease(self, imgUUID, volUUID):
+"""
+Return the volume lease (leasePath, leaseOffset)
+"""
+if self.hasVolumeLeases():
+vol = self.produceVolume(imgUUID, volUUID)
+volumePath = vol.getVolumePath()
+leasePath = volumePath + LEASE_FILEEXT
+return leasePath, fileVolume.LEASE_FILEOFFSET
+return None, None
+
 
 class FileStorageDomain(sd.StorageDomain):
 manifestClass = FileStorageDomainManifest
@@ -463,17 +474,6 @@
 fileName = entry[filePrefixLen:]
 filesDict[fileName] = stats
 return filesDict
-
-def getVolumeLease(self, imgUUID, volUUID):
-"""
-Return the volume lease (leasePath, leaseOffset)
-"""
-if self.hasVolumeLeases():
-vol = self.produceVolume(imgUUID, volUUID)
-volumePath = vol.getVolumePath()
-leasePath = volumePath + LEASE_FILEEXT
-return leasePath, fileVolume.LEASE_FILEOFFSET
-return None, None
 
 def validate(self):
 """
diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py
index c2275a0..b935da9 100644
--- a/vdsm/storage/sd.py
+++ b/vdsm/storage/sd.py
@@ -411,6 +411,12 @@
 def hasVolumeLeases(self):
 return self._domainLock.supports_volume_leases
 
+def getVolumeLease(self, imgUUID, 

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

[alitke]

Adam Litke has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 4: Verified+1

(1 comment)

Verified with unit tests.

https://gerrit.ovirt.org/#/c/60113/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 1516: "qcow2 compat %r is not supported" % qemu_compat)
Line 1517: 
Line 1518: # Although we can handle both 0.1 and 1.1 compat qcow2 
files, we
Line 1519: # currently limit support to one or the other via the 
vdsm config.
Line 1520: # Once both are supported concurrently this check can be 
removed.
> Regarding amend, it seems to be an option only for upgrading an image. Down
The default setting is to require '0.10'.  For 4.0, 99% of users will be able 
to upload the most common images without issue.  For users who have been early 
adopters of 1.1 (by changing host config files) they will have another step... 
Either manually amend before uploading, change a host back to '0.10', or wait 
until 4.1.  I don't think we should make assumptions about the comparability of 
this compat string.
Line 1521: required_compat = config.get('irs', 'qcow2_compat')
Line 1522: if qemu_compat != required_compat:
Line 1523: raise se.ImageVerificationError(
Line 1524: "qcow2 compat %r not supported by this host" % 
qemu_compat)


-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Unify getVolumeLease signature

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sd: Unify getVolumeLease signature
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60281
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I85d3f754c266ce5296d2e52ec9bd544728723a94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Remove deathSignal usages in sync execCmd calls

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Remove deathSignal usages in sync execCmd calls
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5c39fd212429a9b123f4ef9f386db2e91330d0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Add docstrings about Executor parameters and behavior

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Add docstrings about Executor parameters and behavior
..


Patch Set 14: Verified+1

this change only touches docstrings. If jenkins is happy, so we are.

-- 
To view, visit https://gerrit.ovirt.org/57972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bda87cdead2f926cfb09664e87bdff1a87906dd
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rename execCmd and startCmd to run_cmd and start_cmd

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: rename execCmd and startCmd to run_cmd and start_cmd
..

rename execCmd and startCmd to run_cmd and start_cmd

Change-Id: I5e271c07f204c405483c24b03b2792a25bf4256d
Signed-off-by: Yaniv Bronhaim 
---
M contrib/repoplot
M lib/vdsm/commands.py
M lib/vdsm/hooks.py
M lib/vdsm/host/__init__.py
M lib/vdsm/network/api.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/ip/dhclient.py
M lib/vdsm/network/ipwrapper.py
M lib/vdsm/network/netconfpersistence.py
M lib/vdsm/network/ovs/driver/vsctl.py
M lib/vdsm/network/tc/_wrapper.py
M lib/vdsm/numa.py
M lib/vdsm/qemuimg.py
M lib/vdsm/storage/blkdiscard.py
M lib/vdsm/storage/clusterlock.py
M lib/vdsm/storage/curlImgWrap.py
M lib/vdsm/storage/devicemapper.py
M lib/vdsm/storage/fuser.py
M lib/vdsm/storage/hba.py
M lib/vdsm/storage/misc.py
M lib/vdsm/storage/mount.py
M lib/vdsm/taskset.py
M lib/vdsm/tool/configurators/certificates.py
M lib/vdsm/tool/configurators/multipath.py
M lib/vdsm/tool/configurators/passwd.py
M lib/vdsm/tool/configurators/sanlock.py
M lib/vdsm/tool/dummybr.py
M lib/vdsm/tool/restore_nets.py
M lib/vdsm/tool/service.py
M lib/vdsm/tool/transient.py
M lib/vdsm/tool/validate_ovirt_certs.py.in
M lib/vdsm/udevadm.py
M lib/vdsm/v2v.py
M lib/vdsm/virtsparsify.py
M tests/alignmentScanTests.py
M tests/capsTests.py
M tests/commands_test.py
M tests/functional/networkTests.py
M tests/functional/virtTests.py
M tests/iscsiTests.py
M tests/miscTests.py
M tests/mkimageTests.py
M tests/modprobe.py
M tests/mountTests.py
M tests/network/dhcp.py
M tests/network/firewall.py
M tests/network/nettestlib.py
M tests/network/ovsnettestlib.py
M tests/qemuimgTests.py
M tests/utilsTests.py
M tests/v2vTests.py
M vdsm/API.py
M vdsm/alignmentScan.py
M vdsm/gluster/api.py
M vdsm/gluster/cli.py
M vdsm/gluster/gfapi.py
M vdsm/gluster/storagedev.py
M vdsm/hooking.py
M vdsm/mkimage.py
M vdsm/storage/blockSD.py
M vdsm/storage/curl-img-wrap
M vdsm/storage/hsm.py
M vdsm/storage/iscsiadm.py
M vdsm/storage/lvm.py
M vdsm/storage/multipath.py
M vdsm/storage/storage_mailbox.py
M vdsm/supervdsm_api/udev.py
M vdsm/vdsm
M vdsm_hooks/ethtool_options/ethtool_options.py
M vdsm_hooks/extra_ipv4_addrs/extra_ipv4_addrs.py
M vdsm_hooks/fcoe/fcoe_before_network_setup.py
M vdsm_hooks/hostusb/after_vm_destroy.py
M vdsm_hooks/hostusb/before_vm_start.py
M vdsm_hooks/hugepages/before_vm_migrate_destination.py
M vdsm_hooks/hugepages/before_vm_start.py
M vdsm_hooks/openstacknet/openstacknet_utils.py
M vdsm_hooks/ovs/ovs_after_get_caps.py
M vdsm_hooks/ovs/ovs_before_network_setup.py
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
M vdsm_hooks/ovs/ovs_utils.py
M vdsm_hooks/promisc/after_vm_start.py
M vdsm_hooks/promisc/before_vm_destroy.py
M vdsm_hooks/scratchpad/before_vm_start.py
84 files changed, 273 insertions(+), 272 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/60280/1

diff --git a/contrib/repoplot b/contrib/repoplot
index c4dcc2b..eb6e738 100755
--- a/contrib/repoplot
+++ b/contrib/repoplot
@@ -211,10 +211,10 @@
 # the start of the command.
 #
 # d9633df0-5f67-442a-861b-91d417b046f5::DEBUG::2016-02-09
-# 12:37:59,885::utils::669::root::(execCmd) /usr/bin/taskset --cpu-list
+# 12:37:59,885::utils::669::root::(run_cmd) /usr/bin/taskset --cpu-list
 # 0-23 /usr/bin/nice -n 19 /usr/bin/ionice -c 3 /usr/bin/qemu-img
 # convert ...
-(add_qemuimg_copy, "::root::(execCmd)", "disk_commands"),
+(add_qemuimg_copy, "::root::(run_cmd)", "disk_commands"),
 
 # Match qemu-img convert used for copying images in 3.6. This matches
 # the end of the command.
@@ -275,7 +275,7 @@
 
 def add_command(commands, log):
 """
-Add commands start and stop events from execCmd calls
+Add commands start and stop events from run_cmd calls
 """
 if is_command_end(log):
 commands[log.thread].end(log.timestamp)
diff --git a/lib/vdsm/commands.py b/lib/vdsm/commands.py
index 6b734c7..188009a 100644
--- a/lib/vdsm/commands.py
+++ b/lib/vdsm/commands.py
@@ -40,12 +40,12 @@
 BUFFSIZE = 1024
 
 
-def execCmd(command, sudo=False, cwd=None, data=None, raw=False,
+def run_cmd(command, sudo=False, cwd=None, data=None, raw=False,
 printable=None, env=None, nice=None, ioclass=None,
 ioclassdata=None, setsid=False, execCmdLogger=logging.root,
 resetCpuAffinity=True):
 """
-Duplication of startCmd method without the use of deathSignal and sync
+Duplication of start_cmd method without the use of deathSignal and sync
 parameters. Using simple_exec_cmd will execute the command by popen
 in sync to the call and return outputs.
 
@@ -84,10 +84,10 @@
 return p.returncode, out, err
 
 
-def startCmd(command, sudo=False, cwd=None, data=None, raw=False,

Change in vdsm[master]: Using startCmd func for running async execution

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 46: resetCpuAffinity=True):
Line 47: """
Line 48: Duplication of startCmd method without the use of deathSignal and 
sync
Line 49: parameters. Using simple_exec_cmd will execute the command by popen
Line 50: in sync to the call and return outputs.
> None should use deathSignal, but even if we keep deathSignal, we cannot dup
why not?
im uploading the working version (modified the names in separate patch.. please 
take a look and advice, maybe I don't understand what duplication you are 
talking about)
Line 51: 
Line 52: This is partial work to keep the usage of asyncProc in v2v and
Line 53: imageSharing.
Line 54: """


-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Using startCmd func for running async execution

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 46: resetCpuAffinity=True):
Line 47: """
Line 48: Duplication of startCmd method without the use of deathSignal and 
sync
Line 49: parameters. Using simple_exec_cmd will execute the command by popen
Line 50: in sync to the call and return outputs.
> start can't be done similar for both start and run - one uses popen without
None should use deathSignal, but even if we keep deathSignal, we cannot 
duplicate the code like you did here.
Line 51: 
Line 52: This is partial work to keep the usage of asyncProc in v2v and
Line 53: imageSharing.
Line 54: """


Line 114: p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env,
Line 115:  deathSignal=deathSignal))
Line 116: if data is not None:
Line 117: p.stdin.write(data)
Line 118: p.stdin.flush()
> we use it in some tests
some tests can be deleted then.
Line 119: 
Line 120: return p
Line 121: 
Line 122: 


-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Using startCmd func for running async execution

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 46: resetCpuAffinity=True):
Line 47: """
Line 48: Duplication of startCmd method without the use of deathSignal and 
sync
Line 49: parameters. Using simple_exec_cmd will execute the command by popen
Line 50: in sync to the call and return outputs.
> We cannot duplicate code like this. We need to extract the common parts to 
start can't be done similar for both start and run - one uses popen without 
deathsignal the other cpopen. so its quite redundant to have common logic now
Line 51: 
Line 52: This is partial work to keep the usage of asyncProc in v2v and
Line 53: imageSharing.
Line 54: """


-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: fix VM.create return value

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: fix VM.create return value
..


Patch Set 1: Code-Review-1

still broken.

-- 
To view, visit https://gerrit.ovirt.org/60279
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I751da2f0b2148c208975ed0e022141b2f19ec60a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: fix VM.create parameters

[automation]

gerrit-hooks has posted comments on this change.

Change subject: schema: fix VM.create parameters
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: fix VM.create return value

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: schema: fix VM.create return value
..

schema: fix VM.create return value

Fix the return value of this verb to match what Engine 4.0.0 actually expects

Change-Id: I751da2f0b2148c208975ed0e022141b2f19ec60a
Signed-off-by: Francesco Romani 
---
M lib/api/vdsm-api.yml
M lib/api/vdsmapi.py
M tests/vdsmapi_test.py
A tests/vmcreate_retval.out
4 files changed, 256 insertions(+), 51 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/60279/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 19d05e7..23db06f 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -139,7 +139,7 @@
 added: '3.6'
 
 -   description: The type of path (BlockDeviceType)
-name: deviceType
+name: type
 type: *BlockDeviceType
 
 -   description: The current state of this path
@@ -2235,25 +2235,29 @@
 properties:
 -   description: The slot number on the PCI bus
 name: slot
-type: uint
+type: string
+datatype: uint
 
 -   description: The PCI domain
 name: domain
-type: uint
+type: string
+datatype: uint
 
 -   description: The PCI bus number
 name: bus
-type: uint
+type: string
+datatype: uint
 
 -   description: The device address type (always
 pci)
-name: addressType
+name: type
 type: *VmDeviceAddressType
 
 -   description: Function number on the PCI card
 that implements the device
 name: function
-type: uint
+type: string
+datatype: uint
 type: object
 
 VmDeviceIdeAddress: 
@@ -2366,37 +2370,44 @@
 description: Properties of a VM disk device.
 name: VmDiskDevice
 properties:
--   description: Indicates if writes are prohibited for the
+-   defaultvalue: none
+description: Indicates if writes are prohibited for the
 device
 name: readonly
-type: boolean
+type: string
+datatype: boolean
 
--   description: The size of the disk (in bytes)
+-   defaultvalue: none
+description: The size of the disk (in bytes)
 name: apparentsize
-type: uint
+type: string
+datatype: uint
 
--   defaultvalue: needs updating
+-   defaultvalue: none
 description: The UUID of the underlying Volume object
 name: volumeID
 type: *UUID
 
--   description: The drive index
+-   defaultvalue: none
+description: The drive index
 name: index
-type: int
+type: string
+datatype: int
 
--   defaultvalue: needs updating
+-   defaultvalue: none
 description: The filesystem path to the drive's volume
 name: path
 type: string
 
--   defaultvalue: needs updating
+-   defaultvalue: none
 description: List of network disk host info objects. At
 least one host is required if diskType is set to "network"
 name: hosts
 type:
 - *NetworkDiskHostInfo
 
--   description: The sequence of Volume objects needed to
+-   defaultvalue: none
+description: The sequence of Volume objects needed to
 construct the disk
 name: volumeChain
 type:
@@ -2416,7 +2427,8 @@
 description: If specified, this device is part of the
 boot sequence at the specified position
 name: bootOrder
-type: uint
+type: string
+datatype: uint
 
 -   description: The format used to store data on the backing
 storage
@@ -2426,7 +2438,8 @@
 -   description: The amount of underlying storage allocated
 (in bytes)
 name: truesize
-type: uint
+type: string
+datatype: uint
 
 -   defaultvalue: needs updating
 description: Indicates the device connection method exposed
@@ -2444,14 +2457,16 @@
 to vdsm for possible resolution (eg. allocating more
 space)
 name: propagateErrors
-type: boolean
+type: string
+datatype: boolean
 
 -   defaultvalue: needs updating
 description: Additional device parameters
 name: specParams
 type: *VmDiskDeviceSpecParams
 
--   description: Alias used to identify this device in commands
+ 

Change in vdsm[master]: Using startCmd func for running async execution

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: Using startCmd func for running async execution
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60237/1/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 114: p = AsyncProc(CPopen(command, close_fds=True, cwd=cwd, env=env,
Line 115:  deathSignal=deathSignal))
Line 116: if data is not None:
Line 117: p.stdin.write(data)
Line 118: p.stdin.flush()
> Do we have code using this? If not, better remove this. Code that want to w
we use it in some tests
Line 119: 
Line 120: return p
Line 121: 
Line 122: 


-- 
To view, visit https://gerrit.ovirt.org/60237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id38507a04a124918f3865cf011bbf5adc7bc31d5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Only allow compat designated by config

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: verify_untrusted_volume: Only allow compat designated by config
..


Patch Set 4: Code-Review+2

I talk with Adam and we agreed that this is good enough for 4.0, since 1.1. is 
not fully supported on this version.

On 4.1, we will introduce a new storage format, use 1.1 by default, and change 
the verification to allow any format supported by the domain.

-- 
To view, visit https://gerrit.ovirt.org/60113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: add simple tool to prettify python dumps

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: contrib: add simple tool to prettify python dumps
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60272/1//COMMIT_MSG
Commit Message:

Line 10: API logs.
Line 11: Python doesn't care about formatting, but us humans do.
Line 12: 
Line 13: Add a simple tool to reformat the dumps into something
Line 14: human-readable.
Can you show an example of this fancy format?
Line 15: 
Line 16: Change-Id: I3962648db542afb4297e7712c017ffa266c52424


-- 
To view, visit https://gerrit.ovirt.org/60272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3962648db542afb4297e7712c017ffa266c52424
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: add helper to read test data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: add helper to read test data
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/60271/1/tests/testlib.py
File tests/testlib.py:

Line 567: return wrapper
Line 568: 
Line 569: 
Line 570: def read_data(filename):
Line 571: test_path = os.path.realpath(__file__)
You are assuming that the test data is in the same directory as the tests, this 
is not a good idea. 

I think this part of the helper is not very useful - the only useful part is 
reading data from a path with one line, instead of the usual with open()... 
boilerplate.
Line 572: dir_name = os.path.dirname(test_path)
Line 573: path = os.path.join(dir_name, filename)
Line 574: with open(path) as src:


-- 
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69ac8e6c5a2cc113f7573771f90da1dce2bcb74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: fix VM.create

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: fix VM.create
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/59258/4/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

Line 6487
Line 6488
Line 6489
Line 6490
Line 6491
dropped by mistake, will be restored in the next upload.


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: add helper to read test data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: add helper to read test data
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69ac8e6c5a2cc113f7573771f90da1dce2bcb74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: add helper to read test data

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: add helper to read test data
..


Patch Set 1: Verified+1

verified while working on 59258

-- 
To view, visit https://gerrit.ovirt.org/60271
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id69ac8e6c5a2cc113f7573771f90da1dce2bcb74
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: add simple tool to prettify python dumps

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: contrib: add simple tool to prettify python dumps
..

contrib: add simple tool to prettify python dumps

We often need to feed log dumps into tests, like
API logs.
Python doesn't care about formatting, but us humans do.

Add a simple tool to reformat the dumps into something
human-readable.

Change-Id: I3962648db542afb4297e7712c017ffa266c52424
Signed-off-by: Francesco Romani 
---
A contrib/refmt
1 file changed, 32 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/60272/1

diff --git a/contrib/refmt b/contrib/refmt
new file mode 100644
index 000..311c94f
--- /dev/null
+++ b/contrib/refmt
@@ -0,0 +1,32 @@
+#!/usr/bin/python
+
+# helper script to prettify Vdsm parameter dumps from the logs.
+# useful to extract test data.
+# This tool is intended to make it easier for humans to read
+# the dump.
+#
+# PLEASE NOTE that this tool modifies the input files *in place*.
+#
+# The intended workflow is:
+# 1. scan the Vdsm logs to fetch the parameter/return type
+#dump you need
+# 2. copy the dump into a file, let's call it 'param.out'
+# 3. beautify the dump with
+#/path/to/refmt /path/to/param.out
+# 4. inspect the dump and use it as you wish.
+
+import pprint
+import sys
+
+
+def refmt(path):
+with open(path, 'rt') as src:
+data = src.read()
+obj = eval(data)
+with open(path, 'wt') as dst:
+dst.write(pprint.pformat(obj))
+
+
+if __name__ == '__main__':
+for arg in sys.argv[1:]:
+refmt(arg)


-- 
To view, visit https://gerrit.ovirt.org/60272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3962648db542afb4297e7712c017ffa266c52424
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

(4 comments)

https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt
File contrib/refmt:

Line 1: #!/usr/bin/python
> separate patch?
Done
Line 2: 
Line 3: # helper script to prettify Vdsm parameter dumps from the logs.
Line 4: # useful to extract test data.
Line 5: # This tool is intended to make it easier for humans to read


PS3, Line 8: data
> files
Done


PS3, Line 15: dump
> param.out
Done


https://gerrit.ovirt.org/#/c/59258/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS3, Line 4039: needs updating
> Do we want to update here?
we do, will take care of (some of) them still missing.


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59258/3/tests/testlib.py
File tests/testlib.py:

Line 566: raise exception
Line 567: return wrapper
Line 568: 
Line 569: 
Line 570: def read_data(filename):
> separate patch?
yes, better to split this further. Will do in the next upload.
Line 571: test_path = os.path.realpath(__file__)
Line 572: dir_name = os.path.dirname(test_path)
Line 573: path = os.path.join(dir_name, filename)
Line 574: with open(path) as src:


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

(4 comments)

https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt
File contrib/refmt:

Line 1: #!/usr/bin/python
separate patch?
Line 2: 
Line 3: # helper script to prettify Vdsm parameter dumps from the logs.
Line 4: # useful to extract test data.
Line 5: # This tool is intended to make it easier for humans to read


https://gerrit.ovirt.org/#/c/59258/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS3, Line 4039: needs updating
Do we want to update here?


https://gerrit.ovirt.org/#/c/59258/3/tests/testlib.py
File tests/testlib.py:

Line 566: raise exception
Line 567: return wrapper
Line 568: 
Line 569: 
Line 570: def read_data(filename):
separate patch?
Line 571: test_path = os.path.realpath(__file__)
Line 572: dir_name = os.path.dirname(test_path)
Line 573: path = os.path.join(dir_name, filename)
Line 574: with open(path) as src:


https://gerrit.ovirt.org/#/c/59258/3/tests/vdsmapi_test.py
File tests/vdsmapi_test.py:

PS3, Line 450: eval(read_data('vmcreate_args.out'))
I like it


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

(2 comments)

need to split the changes to the schema in a series. This patch will fix 
VM.create only.

https://gerrit.ovirt.org/#/c/59258/3/contrib/refmt
File contrib/refmt:

PS3, Line 8: data
files


PS3, Line 15: dump
param.out

for consistency with line 13


-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3:

Data always comes from oVirt Engine Version: 4.0.0.4-1.el7.centos

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: Log detailed output of virt-v2v
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:

Line 13: It would be cleaner to modify execCmd() to store the log output, but
Line 14: this can dangerous without the function being refactored first.
Line 15: Therefore we resort to a dirty hack with shell to redirect stderr to
Line 16: stdout and store everything in a log file. This hack should be cleaned
Line 17: once execCmd() is updated.
> I prefer this to be solved in the v2v tool or a helpr script that merges st
As I see it, there are two or three problems that sholdn't be mixed together!

1) virt-v2v is messy and should be fixed -- this is something we can't enforce. 
even if we get the patch in, it will take some time before the fixed version is 
available to everyone (u/s and d/s).

2) VDSM has no way to run a command (assynchronously) and merge stdout to 
stderr. This is the main issue here. It is a general feature that is not 
related to virt-v2v. It is something I belive should be fixed elsewhere. (And 
it would make sense to use such feature here even when virt-v2v was clean about 
traces.)

3) The actual logging. This is something that could in theory go to v2v.py, 
provided we have 2) working. But I would still prefer it to be somewhere else, 
because it's again a general feature (maybe as a wrapper around execCmd).
Line 18: 
Line 19: Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Line 20: Bug-Url: https://bugzilla.redhat.com/1350465


-- 
To view, visit https://gerrit.ovirt.org/59834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 3: Code-Review-1

still broken, as per previous patchset

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

[automation]

gerrit-hooks has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: schema: use datatype to silence inconsistencies

[fromani]

Francesco Romani has posted comments on this change.

Change subject: schema: use datatype to silence inconsistencies
..


Patch Set 2: Code-Review-1

WIP, still broken.

Data comes from oVirt Engine Version: 4.0.0.4-1.el7.centos

-- 
To view, visit https://gerrit.ovirt.org/59258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2650f221ae1e06fa11ee127d5c8fb94e7be0d900
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: supervdsm: expose systemd utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: supervdsm: expose systemd utilities
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: add image in metadata container

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: add image in metadata container
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59812
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90c29dc3981b7b5d9f6b274e09f7bd0e88453f70
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Enable tests watcher only if TIMEOUT set

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: Enable tests watcher only if TIMEOUT set
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60240
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c7f862770402ab05bd64e735123d63758c37ef0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add test for testing the timeout mechanism

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: Add test for testing the timeout mechanism
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia405789ccff21f58bdaafefe1dcefa98e5d5f933
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Terminate watcher when tests fail

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: Terminate watcher when tests fail
..


Patch Set 1: Code-Review+1

seen this on my box, nice fix

-- 
To view, visit https://gerrit.ovirt.org/60239
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief975ac59c8c3ec106c42c93d5cb2a2fd32b69c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[fromani]

Francesco Romani has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 11: Code-Review+1

nice improvement.

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Revert "spbackends: Remove StoragePoolDiskBackend"
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/60256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3df9b3d8ddf4b243b43d520bafa34117daaae2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: Revert "spbackends: Remove StoragePoolDiskBackend"
..


Revert "spbackends: Remove StoragePoolDiskBackend"

This reverts commit 6049cecd583997c34f98c78cbe318f0476315ff3.
That commit did not not properly handle creating new storage pools, and
needs to be reverted.

Change-Id: I1c3df9b3d8ddf4b243b43d520bafa34117daaae2
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/60256
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M lib/api/vdsm-api.yml
M lib/vdsm/rpc/bindingxmlrpc.py
M vdsm/API.py
M vdsm/storage/hsm.py
M vdsm/storage/spbackends.py
5 files changed, 239 insertions(+), 13 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/60256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c3df9b3d8ddf4b243b43d520bafa34117daaae2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Revert "spbackends: Remove StoragePoolDiskBackend"
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3df9b3d8ddf4b243b43d520bafa34117daaae2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 16: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 15

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: Revert "spbackends: Remove StoragePoolDiskBackend"
..


Patch Set 1: Verified+1

trivial git revert

-- 
To view, visit https://gerrit.ovirt.org/60256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3df9b3d8ddf4b243b43d520bafa34117daaae2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Revert "spbackends: Remove StoragePoolDiskBackend"
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60256
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c3df9b3d8ddf4b243b43d520bafa34117daaae2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Revert "spbackends: Remove StoragePoolDiskBackend"

[amureini]

Allon Mureinik has uploaded a new change for review.

Change subject: Revert "spbackends: Remove StoragePoolDiskBackend"
..

Revert "spbackends: Remove StoragePoolDiskBackend"

This reverts commit 6049cecd583997c34f98c78cbe318f0476315ff3.
That commit did not not properly handle creating new storage pools, and
needs to be reverted.

Change-Id: I1c3df9b3d8ddf4b243b43d520bafa34117daaae2
Signed-off-by: Allon Mureinik 
---
M lib/api/vdsm-api.yml
M lib/vdsm/rpc/bindingxmlrpc.py
M vdsm/API.py
M vdsm/storage/hsm.py
M vdsm/storage/spbackends.py
5 files changed, 239 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/60256/1

diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index de658b8..eeade4e 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -8256,7 +8256,9 @@
 name: masterVersion
 type: int
 
--   description: The Storage Domain statuses
+-   defaultvalue: null
+description: The Storage Domain statuses. If this argument is present
+the Storage Pool will use the memory backend (no metadata).
 name: domainDict
 added: '3.4'
 type: *StorageDomainStatusMap
diff --git a/lib/vdsm/rpc/bindingxmlrpc.py b/lib/vdsm/rpc/bindingxmlrpc.py
index f3eb288..1d31033 100644
--- a/lib/vdsm/rpc/bindingxmlrpc.py
+++ b/lib/vdsm/rpc/bindingxmlrpc.py
@@ -800,7 +800,7 @@
 return image.reconcileVolumeChain(leafUUID)
 
 def poolConnect(self, spUUID, hostID, scsiKey, msdUUID, masterVersion,
-domainsMap, options=None):
+domainsMap=None, options=None):
 pool = API.StoragePool(spUUID)
 return pool.connect(hostID, scsiKey, msdUUID, masterVersion,
 domainsMap)
diff --git a/vdsm/API.py b/vdsm/API.py
index 60fb7a2..fe9e429 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1114,7 +1114,7 @@
 
 # scsiKey not used
 def connect(self, hostID, scsiKey, masterSdUUID, masterVersion,
-domainDict):
+domainDict=None):
 return self._irs.connectStoragePool(
 self._UUID, hostID, masterSdUUID, masterVersion, domainDict)
 
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 55cb866..7d834c3 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -58,6 +58,7 @@
 
 import sp
 from spbackends import MAX_POOL_DESCRIPTION_SIZE, MAX_DOMAINS
+from spbackends import StoragePoolDiskBackend
 from spbackends import StoragePoolMemoryBackend
 import monitor
 import sd
@@ -948,14 +949,14 @@
 vars.task.getExclusiveLock(STORAGE, dom)
 
 pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng)
-pool.setBackend(StoragePoolMemoryBackend(pool))
+pool.setBackend(StoragePoolDiskBackend(pool))
 
 return pool.create(poolName, masterDom, domList, masterVersion,
leaseParams)
 
 @public
 def connectStoragePool(self, spUUID, hostID, msdUUID, masterVersion,
-   domainsMap, options=None):
+   domainsMap=None, options=None):
 """
 Connect a Host to a specific storage pool.
 
@@ -992,15 +993,21 @@
 "hostId=%s, newHostId=%s" % (pool.id, hostId))
 
 if domainsMap is None:
-raise se.InvalidParameterException("domainsMap", domainsMap)
-
-pool.getBackend().updateVersionAndDomains(
-masterVersion, domainsMap)
+if not isinstance(pool.getBackend(), StoragePoolDiskBackend):
+raise se.StoragePoolConnected('Cannot downgrade pool backend')
+else:
+if isinstance(pool.getBackend(), StoragePoolMemoryBackend):
+pool.getBackend().updateVersionAndDomains(
+masterVersion, domainsMap)
+else:
+# Live pool backend upgrade
+pool.setBackend(
+StoragePoolMemoryBackend(pool, masterVersion, domainsMap))
 
 pool.refresh(msdUUID, masterVersion)
 
 def _connectStoragePool(self, spUUID, hostID, msdUUID,
-masterVersion, domainsMap, options=None):
+masterVersion, domainsMap=None, options=None):
 misc.validateUUID(spUUID, 'spUUID')
 
 # TBD: To support multiple pool connection on single host,
@@ -1034,8 +1041,13 @@
 return True
 
 pool = sp.StoragePool(spUUID, self.domainMonitor, self.taskMng)
-pool.setBackend(
-StoragePoolMemoryBackend(pool, masterVersion, domainsMap))
+pool.backend = StoragePoolDiskBackend(pool)
+
+if domainsMap is None:
+pool.setBackend(StoragePoolDiskBackend(pool))
+else:
+pool.setBackend(
+StoragePoolMemoryBackend(pool, masterVersion, domainsMap))
 
  

Change in vdsm[master]: contrib: Simple jsonrpc client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 11: Verified+1

Verified by updating vdsm and checking that communication works. One vm was 
started to check basic functionality.

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[automation]

gerrit-hooks has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: simplified client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: simplified client
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: contrib: Simple jsonrpc client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Antoni Segura Puimedon 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Saggi Mizrahi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: move metadata handling into helpers

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vmxml: move metadata handling into helpers
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/57380
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb931f33ab83577ae6913ce8e99e6654a2183305
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: doc: add basic quickstart for containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: doc: add basic quickstart for containers
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder sampling initialization

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reorder sampling initialization
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59815
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77e9575ade075d21b36f72915e4d4f2bf5badf92
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: add image in metadata container

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: add image in metadata container
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59812
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90c29dc3981b7b5d9f6b274e09f7bd0e88453f70
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: kill _stubDependentInit()

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: kill _stubDependentInit()
..


Abandoned

squashed in 53820

-- 
To view, visit https://gerrit.ovirt.org/59818
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia3f4b19dbcdb5c736d71b53881098edf9a7f3714
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/52354/10/build-aux/Makefile.subs
File build-aux/Makefile.subs:

Line 28
Line 29
Line 30
Line 31
Line 32
> Will remove
TRUSTEDSTORE was not used in configure.ac and we can remove vdsmtsdir due to:

Directory not found: 
/home/pkliczewski/rpmbuild/BUILDROOT/vdsm-4.18.999-216.gitcf17c8b.fc23.x86_64/etc/pki/vdsm
Directory not found: 
/home/pkliczewski/rpmbuild/BUILDROOT/vdsm-4.18.999-216.gitcf17c8b.fc23.x86_64/etc/pki/vdsm/keys
Directory not found: 
/home/pkliczewski/rpmbuild/BUILDROOT/vdsm-4.18.999-216.gitcf17c8b.fc23.x86_64/etc/pki/vdsm/certs
Directory not found: 
/home/pkliczewski/rpmbuild/BUILDROOT/vdsm-4.18.999-216.gitcf17c8b.fc23.x86_64/etc/pki/vdsm/libvirt-spice
File not found: 
/home/pkliczewski/rpmbuild/BUILDROOT/vdsm-4.18.999-216.gitcf17c8b.fc23.x86_64/etc/pki/vdsm/keys/libvirt_password

we use it to prepare distribution directories.


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vmxml: metadata could be local variable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmxml: metadata could be local variable
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57379
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I623dfcdbea8a5ba0037982cf74b9dd916b76c9ea
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split out SLA settings from domDependentInit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: split out SLA settings from domDependentInit
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59813
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9907a428b00d5851ece0037acfcc1ad72442ae46
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: reorder sampling initialization

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reorder sampling initialization
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59815
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77e9575ade075d21b36f72915e4d4f2bf5badf92
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: split device init from domDependentInit

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: split device init from domDependentInit
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59814
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33b347889c930b4ae2fa183e7202ed0dd7b9da26
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add additional verbs
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9c63a05d8354676e68418b08593ea830b42a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: jsonrpcvdscli: add additional verbs
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/60248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9c63a05d8354676e68418b08593ea830b42a7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: add additional verbs
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57f9c63a05d8354676e68418b08593ea830b42a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: jsonrpcvdscli: add additional verbs

[stirabos]

Simone Tiraboschi has uploaded a new change for review.

Change subject: jsonrpcvdscli: add additional verbs
..

jsonrpcvdscli: add additional verbs

Add additional verbs required by the hosted-engine upgrade flow.

Change-Id: I57f9c63a05d8354676e68418b08593ea830b42a7
Signed-off-by: Simone Tiraboschi 
Reviewed-on: https://gerrit.ovirt.org/60054
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
(cherry picked from commit 17964b1ab0b442fec3466843a4ec05cab1ee2398)
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/60248/1

diff --git a/lib/vdsm/jsonrpcvdscli.py b/lib/vdsm/jsonrpcvdscli.py
index 10e3f8b..98f6f9c 100644
--- a/lib/vdsm/jsonrpcvdscli.py
+++ b/lib/vdsm/jsonrpcvdscli.py
@@ -54,6 +54,7 @@
 'disconnectStoragePool': 'StoragePool.disconnect',
 'disconnectStorageServer': 'StoragePool.disconnectStorageServer',
 'discoverSendTargets': 'ISCSIConnection.discoverSendTargets',
+'extendVolumeSize': 'Volume.extendSize',
 'formatStorageDomain': 'StorageDomain.format',
 'fullList': 'Host.getVMFullList',
 'getAllTasksStatuses': 'Host.getAllTasksStatuses',
@@ -66,6 +67,8 @@
 'getStorageDomainsList': 'Host.getStorageDomains',
 'getStorageDomainStats': 'StorageDomain.getStats',
 'getStoragePoolInfo': 'StoragePool.getInfo',
+'getTaskInfo': 'Task.getInfo',
+'getTaskStatus': 'Task.getStatus',
 'getVdsCapabilities': 'Host.getCapabilities',
 'getVdsHardwareInfo': 'Host.getHardwareInfo',
 'getVdsStats': 'Host.getStats',


-- 
To view, visit https://gerrit.ovirt.org/60248
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57f9c63a05d8354676e68418b08593ea830b42a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Simone Tiraboschi 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: wip: tests: change testing framework to pytest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: wip: tests: change testing framework to pytest
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/60217
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife527b9274c31a72b57da9b958a1dd2f9f1e5ea0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: utils: build cert paths in single place

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: utils: build cert paths in single place
..


Patch Set 10:

(4 comments)

https://gerrit.ovirt.org/#/c/52354/10//COMMIT_MSG
Commit Message:

Line 4: Commit: Piotr Kliczewski 
Line 5: CommitDate: 2016-07-05 16:08:19 +0200
Line 6: 
Line 7: utils: build cert paths in single place
Line 8: 
> Please describe the behavior change - we don't use the trusted store config
Done
Line 9: 
Line 10: Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b


https://gerrit.ovirt.org/#/c/52354/10/build-aux/Makefile.subs
File build-aux/Makefile.subs:

Line 28
Line 29
Line 30
Line 31
Line 32
> We probably need to remove vdsmtsdir (and TRUSTEDSTORE?) from configure.ac
Will remove


https://gerrit.ovirt.org/#/c/52354/10/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 154: EXT_KVM_2_OVIRT = '@LIBEXECDIR@/kvm2ovirt'
Line 155: EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@'
Line 156: 
Line 157: # location of the certificates
Line 158: PKI_DIR = os.path.join(SYSCONF_PATH, 'pki/vdsm')
> Use:
Done
Line 159: KEY_FILE = os.path.join(PKI_DIR, 'keys', 'vdsmkey.pem')
Line 160: CERT_FILE = os.path.join(PKI_DIR, 'certs', 'vdsmcert.pem')


https://gerrit.ovirt.org/#/c/52354/10/lib/vdsm/tool/configurators/libvirt.py
File lib/vdsm/tool/configurators/libvirt.py:

Line 28: from vdsm.tool.configfile import ConfigFile, ParserWrapper
Line 29: from vdsm.tool.validate_ovirt_certs import validate_ovirt_certs
Line 30: from vdsm import utils
Line 31: from vdsm import constants
Line 32: 
> Unrelated
Done
Line 33: 
Line 34: if utils.isOvirtNode():
Line 35: from ovirt.node.utils.fs import Config as NodeCfg
Line 36: 


-- 
To view, visit https://gerrit.ovirt.org/52354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yedidyah Bar David 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org