date:20120207

Title: [106912] trunk








Revision 106912
Author commit-qu...@webkit.org
Date 2012-02-07 00:18:40 -0800 (Tue, 07 Feb 2012)


Log Message
Migrate createObjectURL  revokeObjectURL to static (Class) methods.
https://bugs.webkit.org/show_bug.cgi?id=74386

Patch by Kaustubh Atrawalkar kaust...@motorola.com on 2012-02-07
Reviewed by David Levin.

Source/WebCore:

Test: fast/dom/DOMURL/check-instanceof-domurl-functions.html
Already Existing:
fast/files/revoke-blob-url.html
fast/dom/window-domurl-crash.html
fast/files/apply-blob-url-to-img.html
fast/files/create-blob-url-crash.html
fast/files/workers/inline-worker-via-blob-url.html

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::fileThread):
(WebCore):
(WebCore::ScriptExecutionContext::publicURLManager):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* html/DOMURL.cpp:
(WebCore):
(WebCore::DOMURL::createObjectURL): Changed to static.
(WebCore::DOMURL::revokeObjectURL): ditto.
* html/DOMURL.h:
(DOMURL):
(WebCore::DOMURL::create):
* html/DOMURL.idl:
* html/PublicURLManager.h: Added.
(WebCore):
(PublicURLManager):
(WebCore::PublicURLManager::create):
(WebCore::PublicURLManager::contextDestroyed):
(WebCore::PublicURLManager::blobURLs):
(WebCore::PublicURLManager::streamURLs):
* page/DOMWindow.cpp: Removed object initialization for DOMURL.
(WebCore):
* page/DOMWindow.h: ditto.
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:

LayoutTests:

Added test to check if createObjectURL  revokeObjectURL are static functions.

* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/html/DOMURL.cpp
trunk/Source/WebCore/html/DOMURL.h
trunk/Source/WebCore/html/DOMURL.idl
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/DOMWindow.h
trunk/Source/WebCore/page/DOMWindow.idl
trunk/Source/WebCore/workers/WorkerContext.cpp
trunk/Source/WebCore/workers/WorkerContext.h
trunk/Source/WebCore/workers/WorkerContext.idl


Added Paths

trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt
trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html
trunk/Source/WebCore/html/PublicURLManager.h




Diff

Modified: trunk/LayoutTests/ChangeLog (106911 => 106912)

--- trunk/LayoutTests/ChangeLog	2012-02-07 08:16:09 UTC (rev 106911)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 08:18:40 UTC (rev 106912)
@@ -1,3 +1,15 @@
+2012-02-07  Kaustubh Atrawalkar  kaust...@motorola.com
+
+Migrate createObjectURL  revokeObjectURL to static (Class) methods.
+https://bugs.webkit.org/show_bug.cgi?id=74386
+
+Reviewed by David Levin.
+
+Added test to check if createObjectURL  revokeObjectURL are static functions.
+
+* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Added.
+* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Added.
+
 2012-02-03  Vsevolod Vlasov  vse...@chromium.org
 
 http/tests/inspector/indexeddb/database-structure.html failing on chromium win/linux


Added: trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt (0 => 106912)

--- trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt	2012-02-07 08:18:40 UTC (rev 106912)
@@ -0,0 +1,15 @@
+Test instanceof functions and properties of webkitURL.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS 'createObjectURL' in webkitURL is true
+PASS 'revokeObjectURL' in webkitURL is true
+PASS url.createObjectURL is undefined.
+PASS url.revokeObjectURL is undefined.
+PASS window.webkitURL.createObjectURL is defined.
+PASS window.webkitURL.revokeObjectURL is defined.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html (0 => 106912)

--- trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html	2012-02-07 08:18:40 UTC (rev 106912)
@@ -0,0 +1,25 @@
+!DOCTYPE HTML
+html
+head
+script src=""
+/head
+body
+script
+description(Test instanceof functions and properties of webkitURL.);
+
+var url = "" webkitURL;
+
+shouldBeTrue('createObjectURL' in webkitURL);
+shouldBeTrue('revokeObjectURL' in webkitURL);
+
+shouldBeUndefined(url.createObjectURL);
+shouldBeUndefined(url.revokeObjectURL);
+
+shouldBeDefined(window.webkitURL.createObjectURL);
+shouldBeDefined(window.webkitURL.revokeObjectURL);
+
+

[webkit-changes] [106913] trunk/Source/WebCore

Title: [106913] trunk/Source/WebCore








Revision 106913
Author hara...@chromium.org
Date 2012-02-07 00:54:04 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed, rolling out r106862.
http://trac.webkit.org/changeset/106862
https://bugs.webkit.org/show_bug.cgi?id=77510

Mac build fails if we manually remove generated code

* DerivedSources.make:
* bindings/scripts/generate-bindings.pl:
(generateEmptyHeaderAndCpp):
* bindings/scripts/resolve-supplemental.pl:
* bindings/scripts/update-idl-needs-rebuild.pl: Removed.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/bindings/scripts/generate-bindings.pl
trunk/Source/WebCore/bindings/scripts/resolve-supplemental.pl


Removed Paths

trunk/Source/WebCore/bindings/scripts/update-idl-needs-rebuild.pl




Diff

Modified: trunk/Source/WebCore/ChangeLog (106912 => 106913)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 08:18:40 UTC (rev 106912)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 08:54:04 UTC (rev 106913)
@@ -1,3 +1,17 @@
+2012-02-07  Kentaro Hara  hara...@chromium.org
+
+Unreviewed, rolling out r106862.
+http://trac.webkit.org/changeset/106862
+https://bugs.webkit.org/show_bug.cgi?id=77510
+
+Mac build fails if we manually remove generated code
+
+* DerivedSources.make:
+* bindings/scripts/generate-bindings.pl:
+(generateEmptyHeaderAndCpp):
+* bindings/scripts/resolve-supplemental.pl:
+* bindings/scripts/update-idl-needs-rebuild.pl: Removed.
+
 2012-02-07  Kaustubh Atrawalkar  kaust...@motorola.com
 
 Migrate createObjectURL  revokeObjectURL to static (Class) methods.


Modified: trunk/Source/WebCore/DerivedSources.make (106912 => 106913)

--- trunk/Source/WebCore/DerivedSources.make	2012-02-07 08:18:40 UTC (rev 106912)
+++ trunk/Source/WebCore/DerivedSources.make	2012-02-07 08:54:04 UTC (rev 106913)
@@ -584,20 +584,15 @@
 DOM_CLASSES=$(basename $(notdir $(BINDING_IDLS)))
 
 JS_DOM_HEADERS=$(filter-out JSMediaQueryListListener.h JSEventListener.h JSEventTarget.h, $(DOM_CLASSES:%=JS%.h))
-JS_IDL_NEEDS_REBUILDS=$(JS_DOM_HEADERS:JS%.h=%.idl-needs-rebuild) _javascript_CallFrame.idl-needs-rebuild
 
 WEB_DOM_HEADERS :=
 ifeq ($(findstring BUILDING_WX,$(FEATURE_DEFINES)), BUILDING_WX)
 WEB_DOM_HEADERS := $(filter-out WebDOMXSLTProcessor.h WebDOMEventTarget.h, $(DOM_CLASSES:%=WebDOM%.h))
-CPP_IDL_NEEDS_REBUILDS=$(WEB_DOM_HEADERS:WebDOM%.h=%.idl-needs-rebuild)
 endif # BUILDING_WX
 
 all : \
 $(JS_DOM_HEADERS) \
-$(JS_IDL_NEEDS_REBUILDS) \
-\
 $(WEB_DOM_HEADERS) \
-$(CPP_IDL_NEEDS_REBUILDS) \
 \
 JSJavaScriptCallFrame.h \
 \
@@ -917,24 +912,23 @@
 
 JS_BINDINGS_SCRIPTS = $(GENERATE_SCRIPTS) bindings/scripts/CodeGeneratorJS.pm
 
-SUPPLEMENTAL_DEPENDENCY_FILE = ./supplemental.dep
+SUPPLEMENTAL_DEPENDENCY_FILE = ./supplemental_dependency.tmp
 IDL_FILES_TMP = ./idl_files.tmp
+ADDITIONAL_IDLS = $(WebCore)/inspector/_javascript_CallFrame.idl
 
 # The following two lines get a space character stored in a variable.
 # See http://blog.jgc.org/2007/06/escaping-comma-and-space-in-gnu-make.html.
 space :=
 space +=
 
-$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(RESOLVE_SUPPLEMENTAL_SCRIPTS) $(BINDING_IDLS) $(WebCore)/inspector/_javascript_CallFrame.idl
-	printf $(subst $(space),,$(patsubst %,%\n,$(BINDING_IDLS) $(WebCore)/inspector/_javascript_CallFrame.idl))  $(IDL_FILES_TMP)
-	$(call resolve_supplemental_script, $(RESOLVE_SUPPLEMENTAL_SCRIPTS)) --defines $(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@ --newBuildFlow
+$(SUPPLEMENTAL_DEPENDENCY_FILE) : $(RESOLVE_SUPPLEMENTAL_SCRIPTS) $(BINDING_IDLS) $(ADDITIONAL_IDLS)
+	printf $(subst $(space),,$(patsubst %,%\n,$(BINDING_IDLS) $(ADDITIONAL_IDLS)))  $(IDL_FILES_TMP)
+	$(call resolve_supplemental_script, $(RESOLVE_SUPPLEMENTAL_SCRIPTS)) --defines $(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT --idlFilesList $(IDL_FILES_TMP) --supplementalDependencyFile $@
 	rm -f $(IDL_FILES_TMP)
 
-%.idl-needs-rebuild : %.idl $(SUPPLEMENTAL_DEPENDENCY_FILE) $(WebCore)/bindings/scripts/update-idl-needs-rebuild.pl
-	perl $(WebCore)/bindings/scripts/update-idl-needs-rebuild.pl --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) --idlFile $
+JS%.h : %.idl $(JS_BINDINGS_SCRIPTS) $(SUPPLEMENTAL_DEPENDENCY_FILE)
+	$(call generator_script, $(JS_BINDINGS_SCRIPTS)) $(IDL_COMMON_ARGS) --defines $(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT --generator JS --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $
 
-JS%.h : %.idl-needs-rebuild $(JS_BINDINGS_SCRIPTS)
-	$(call generator_script, $(JS_BINDINGS_SCRIPTS)) $(IDL_COMMON_ARGS) --defines $(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT --generator JS --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) --idlNeedsRebuildFile $ --newBuildFlow
 
 # Inspector interfaces generator
 
@@

[webkit-changes] [106914] trunk

Title: [106914] trunk








Revision 106914
Author hara...@chromium.org
Date 2012-02-07 01:44:25 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed, rolling out r106912.
http://trac.webkit.org/changeset/106912
https://bugs.webkit.org/show_bug.cgi?id=77947

AppleWebKit build is broken (Requested by haraken on
#webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-07

Source/WebCore:

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
(WebCore):
* dom/ScriptExecutionContext.h:
(WebCore):
(ScriptExecutionContext):
* html/DOMURL.cpp:
(WebCore::DOMURL::DOMURL):
(WebCore):
(WebCore::DOMURL::~DOMURL):
(WebCore::DOMURL::contextDestroyed):
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::revokeObjectURL):
* html/DOMURL.h:
(WebCore::DOMURL::create):
(DOMURL):
* html/DOMURL.idl:
* html/PublicURLManager.h: Removed.
* page/DOMWindow.cpp:
(WebCore):
(WebCore::DOMWindow::webkitURL):
* page/DOMWindow.h:
(DOMWindow):
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore):
(WebCore::WorkerContext::webkitURL):
* workers/WorkerContext.h:
(WorkerContext):
* workers/WorkerContext.idl:

LayoutTests:

* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ScriptExecutionContext.cpp
trunk/Source/WebCore/dom/ScriptExecutionContext.h
trunk/Source/WebCore/html/DOMURL.cpp
trunk/Source/WebCore/html/DOMURL.h
trunk/Source/WebCore/html/DOMURL.idl
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/DOMWindow.h
trunk/Source/WebCore/page/DOMWindow.idl
trunk/Source/WebCore/workers/WorkerContext.cpp
trunk/Source/WebCore/workers/WorkerContext.h
trunk/Source/WebCore/workers/WorkerContext.idl


Removed Paths

trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt
trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html
trunk/Source/WebCore/html/PublicURLManager.h




Diff

Modified: trunk/LayoutTests/ChangeLog (106913 => 106914)

--- trunk/LayoutTests/ChangeLog	2012-02-07 08:54:04 UTC (rev 106913)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 09:44:25 UTC (rev 106914)
@@ -1,3 +1,15 @@
+2012-02-07  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r106912.
+http://trac.webkit.org/changeset/106912
+https://bugs.webkit.org/show_bug.cgi?id=77947
+
+AppleWebKit build is broken (Requested by haraken on
+#webkit).
+
+* fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt: Removed.
+* fast/dom/DOMURL/check-instanceof-domurl-functions.html: Removed.
+
 2012-02-07  Kaustubh Atrawalkar  kaust...@motorola.com
 
 Migrate createObjectURL  revokeObjectURL to static (Class) methods.


Deleted: trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt (106913 => 106914)

--- trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt	2012-02-07 08:54:04 UTC (rev 106913)
+++ trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions-expected.txt	2012-02-07 09:44:25 UTC (rev 106914)
@@ -1,15 +0,0 @@
-Test instanceof functions and properties of webkitURL.
-
-On success, you will see a series of PASS messages, followed by TEST COMPLETE.
-
-
-PASS 'createObjectURL' in webkitURL is true
-PASS 'revokeObjectURL' in webkitURL is true
-PASS url.createObjectURL is undefined.
-PASS url.revokeObjectURL is undefined.
-PASS window.webkitURL.createObjectURL is defined.
-PASS window.webkitURL.revokeObjectURL is defined.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-


Deleted: trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html (106913 => 106914)

--- trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html	2012-02-07 08:54:04 UTC (rev 106913)
+++ trunk/LayoutTests/fast/dom/DOMURL/check-instanceof-domurl-functions.html	2012-02-07 09:44:25 UTC (rev 106914)
@@ -1,25 +0,0 @@
-!DOCTYPE HTML
-html
-head
-script src=""
-/head
-body
-script
-description(Test instanceof functions and properties of webkitURL.);
-
-var url = "" webkitURL;
-
-shouldBeTrue('createObjectURL' in webkitURL);
-shouldBeTrue('revokeObjectURL' in webkitURL);
-
-shouldBeUndefined(url.createObjectURL);
-shouldBeUndefined(url.revokeObjectURL);
-
-shouldBeDefined(window.webkitURL.createObjectURL);
-shouldBeDefined(window.webkitURL.revokeObjectURL);
-
-
-/script
-script src=""
-/body
-/html


Modified: trunk/Source/WebCore/ChangeLog (106913 => 106914)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 08:54:04 UTC (rev 106913)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 09:44:25 UTC (rev 106914)
@@ -1,3 +1,43 @@
+2012-02-07  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r106912.
+http://trac.webkit.org/changeset/106912
+https://bugs.webkit.org/show_bug.cgi?id=77947
+
+

[webkit-changes] [106915] trunk/LayoutTests

Title: [106915] trunk/LayoutTests








Revision 106915
Author commit-qu...@webkit.org
Date 2012-02-07 02:22:44 -0800 (Tue, 07 Feb 2012)


Log Message
GTK  QT Rebaseline after r106912.
https://bugs.webkit.org/show_bug.cgi?id=77942

Patch by Kaustubh Atrawalkar kaust...@motorola.com on 2012-02-07
Reviewed by David Levin.

* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt
trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt
trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106914 => 106915)

--- trunk/LayoutTests/ChangeLog	2012-02-07 09:44:25 UTC (rev 106914)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 10:22:44 UTC (rev 106915)
@@ -1,3 +1,16 @@
+2012-02-07  Kaustubh Atrawalkar  kaust...@motorola.com
+
+GTK  QT Rebaseline after r106912.
+https://bugs.webkit.org/show_bug.cgi?id=77942
+
+Reviewed by David Levin.
+
+* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
+* platform/gtk/fast/js/global-constructors-expected.txt:
+* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
+* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
+* platform/qt/fast/js/global-constructors-expected.txt:
+
 2012-02-07  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r106912.


Modified: trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt (106914 => 106915)

--- trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt	2012-02-07 09:44:25 UTC (rev 106914)
+++ trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt	2012-02-07 10:22:44 UTC (rev 106915)
@@ -240,6 +240,7 @@
 Never found DOMParser
 Never found DOMSettableTokenList
 Never found DOMStringList
+Never found DOMURL
 Never found Document
 Never found DocumentFragment
 Never found DocumentType


Modified: trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt (106914 => 106915)

--- trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt	2012-02-07 09:44:25 UTC (rev 106914)
+++ trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt	2012-02-07 10:22:44 UTC (rev 106915)
@@ -333,6 +333,7 @@
 PASS XPathResult.toString() is '[object XPathResultConstructor]'
 PASS XSLTProcessor.toString() is '[object XSLTProcessorConstructor]'
 FAIL webkitPeerConnection.toString() should be [object webkitPeerConnectionConstructor]. Was [object PeerConnectionConstructor].
+FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt (106914 => 106915)

--- trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt	2012-02-07 09:44:25 UTC (rev 106914)
+++ trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt	2012-02-07 10:22:44 UTC (rev 106915)
@@ -61,6 +61,8 @@
 PASS (new inner.XPathEvaluator()).constructor.isInner is true
 PASS (new inner.XSLTProcessor()).isInner is true
 PASS (new inner.XSLTProcessor()).constructor.isInner is true
+PASS (new inner.webkitURL()).isInner is true
+PASS (new inner.webkitURL()).constructor.isInner is true
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt (106914 => 106915)

--- trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt	2012-02-07 09:44:25 UTC (rev 106914)
+++ trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt	2012-02-07 10:22:44 UTC (rev 106915)
@@ -240,6 +240,7 @@
 Never found DOMParser
 Never found DOMSettableTokenList
 Never found DOMStringList
+Never found DOMURL
 Never found Document
 Never found DocumentFragment
 Never found DocumentType


Modified: trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt (106914 => 106915)

--- trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt	2012-02-07 09:44:25 UTC (rev 106914)
+++ trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt	2012-02-07 10:22:44 UTC (rev 106915)
@@ -315,6 +315,7 @@
 PASS XPathException.toString() is '[object XPathExceptionConstructor]'
 PASS XPathResult.toString() is '[object XPathResultConstructor]'
 PASS

[webkit-changes] [106916] trunk/Source/WebCore

2012-02-07 Thread apavlov

Title: [106916] trunk/Source/WebCore








Revision 106916
Author apav...@chromium.org
Date 2012-02-07 02:29:57 -0800 (Tue, 07 Feb 2012)


Log Message
[CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent event) references a NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=77953

Reviewed by Andreas Kling.

* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106915 => 106916)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 10:22:44 UTC (rev 106915)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 10:29:57 UTC (rev 106916)
@@ -1,3 +1,13 @@
+2012-02-07  Alexander Pavlov  apav...@chromium.org
+
+[CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent event) references a NULL pointer
+https://bugs.webkit.org/show_bug.cgi?id=77953
+
+Reviewed by Andreas Kling.
+
+* page/EventHandler.cpp:
+(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):
+
 2012-02-07  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r106912.


Modified: trunk/Source/WebCore/page/EventHandler.cpp (106915 => 106916)

--- trunk/Source/WebCore/page/EventHandler.cpp	2012-02-07 10:22:44 UTC (rev 106915)
+++ trunk/Source/WebCore/page/EventHandler.cpp	2012-02-07 10:29:57 UTC (rev 106916)
@@ -3456,7 +3456,7 @@
 
 bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent event)
 {
-if (!m_frame-document()-settings()-isTouchEventEmulationEnabled())
+if (!m_frame || !m_frame-settings() || !m_frame-settings()-isTouchEventEmulationEnabled())
 return false;
 
 PlatformEvent::Type eventType = event.type();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106917] trunk/Source/WebCore

2012-02-07 Thread kenneth

Title: [106917] trunk/Source/WebCore








Revision 106917
Author kenn...@webkit.org
Date 2012-02-07 03:10:53 -0800 (Tue, 07 Feb 2012)


Log Message
[Inspector] Add the Nokia N9 user agent
https://bugs.webkit.org/show_bug.cgi?id=77949

Reviewed by Simon Hausmann.

* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SettingsScreen.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (106916 => 106917)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 10:29:57 UTC (rev 106916)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 11:10:53 UTC (rev 106917)
@@ -1,3 +1,13 @@
+2012-02-07  Kenneth Rohde Christiansen  kenn...@webkit.org
+
+[Inspector] Add the Nokia N9 user agent
+https://bugs.webkit.org/show_bug.cgi?id=77949
+
+Reviewed by Simon Hausmann.
+
+* inspector/front-end/SettingsScreen.js:
+(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
+
 2012-02-07  Alexander Pavlov  apav...@chromium.org
 
 [CRASH] bool EventHandler::dispatchSyntheticTouchEventIfEnabled(const PlatformMouseEvent event) references a NULL pointer


Modified: trunk/Source/WebCore/inspector/front-end/SettingsScreen.js (106916 => 106917)

--- trunk/Source/WebCore/inspector/front-end/SettingsScreen.js	2012-02-07 10:29:57 UTC (rev 106916)
+++ trunk/Source/WebCore/inspector/front-end/SettingsScreen.js	2012-02-07 11:10:53 UTC (rev 106917)
@@ -312,6 +312,8 @@
 [BlackBerry \u2014 PlayBook 2.0, Mozilla/5.0 (PlayBook; U; RIM Tablet OS 2.0.0; en-US) AppleWebKit/535.8+ (KHTML, like Gecko) Version/7.2.0.0 Safari/535.8+],
 [BlackBerry \u2014 9900, Mozilla/5.0 (BlackBerry; U; BlackBerry 9900; en-US) AppleWebKit/534.11+ (KHTML, like Gecko) Version/7.0.0.187 Mobile Safari/534.11+],
 
+[MeeGo \u2014 Nokia N9, Mozilla/5.0 (MeeGo; NokiaN9) AppleWebKit/534.13 (KHTML, like Gecko) NokiaBrowser/8.5.0 Mobile Safari/534.13],
+
 [WebInspector.UIString(Other...), Other]
 ];
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106920] trunk/Source

Title: [106920] trunk/Source








Revision 106920
Author commit-qu...@webkit.org
Date 2012-02-07 03:42:39 -0800 (Tue, 07 Feb 2012)


Log Message
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning michael.brun...@nokia.com on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

No new tests. (Not applicable)

Added OS-specific implementation for retrieving the free disk space.

* platform/FileSystem.h:
(WebCore):
* platform/qt/FileSystemQt.cpp:
(WebCore::getVolumeFreeSizeForPath):
(WebCore):

Source/WebKit2:

First part of the implementation. The next steps are the implementation
of the API for the Qt WebKit 2 port and the hybrid memory and disk cache.

* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::defaultDiskCacheDirectory):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::physicalMemorySizeInBytes):
(WebKit):
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/FileSystem.h
trunk/Source/WebCore/platform/qt/FileSystemQt.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.cpp
trunk/Source/WebKit2/Shared/WebProcessCreationParameters.h
trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp
trunk/Source/WebKit2/WebProcess/qt/WebProcessQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106919 => 106920)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 11:19:23 UTC (rev 106919)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 11:42:39 UTC (rev 106920)
@@ -1,3 +1,20 @@
+2012-02-07  Michael Brüning  michael.brun...@nokia.com
+
+[Qt][WK2] Compute and set cache capacities using the current CacheModel
+https://bugs.webkit.org/show_bug.cgi?id=73918
+
+Reviewed by Kenneth Rohde Christiansen.
+
+No new tests. (Not applicable)
+
+Added OS-specific implementation for retrieving the free disk space.
+
+* platform/FileSystem.h:
+(WebCore):
+* platform/qt/FileSystemQt.cpp:
+(WebCore::getVolumeFreeSizeForPath):
+(WebCore):
+
 2012-02-07  Kenneth Rohde Christiansen  kenn...@webkit.org
 
 [Inspector] Add the Nokia N9 user agent


Modified: trunk/Source/WebCore/platform/FileSystem.h (106919 => 106920)

--- trunk/Source/WebCore/platform/FileSystem.h	2012-02-07 11:19:23 UTC (rev 106919)
+++ trunk/Source/WebCore/platform/FileSystem.h	2012-02-07 11:42:39 UTC (rev 106920)
@@ -198,6 +198,8 @@
 String filenameToString(const char*);
 String filenameForDisplay(const String);
 CString applicationDirectoryPath();
+#endif
+#if PLATFORM(GTK) || PLATFORM(QT)
 uint64_t getVolumeFreeSizeForPath(const char*);
 #endif
 


Modified: trunk/Source/WebCore/platform/qt/FileSystemQt.cpp (106919 => 106920)

--- trunk/Source/WebCore/platform/qt/FileSystemQt.cpp	2012-02-07 11:19:23 UTC (rev 106919)
+++ trunk/Source/WebCore/platform/qt/FileSystemQt.cpp	2012-02-07 11:42:39 UTC (rev 106920)
@@ -39,6 +39,7 @@
 #include QFile
 #include QFileInfo
 #include QTemporaryFile
+#include sys/statvfs.h
 #include wtf/text/CString.h
 
 namespace WebCore {
@@ -190,6 +191,23 @@
 return -1;
 }
 
+uint64_t getVolumeFreeSizeForPath(const char* path)
+{
+#if defined(Q_OS_WIN)
+ULARGE_INTEGER freeBytesToCaller;
+BOOL result = GetDiskFreeSpaceExW((LPCWSTR)path, freeBytesToCaller, 0, 0);
+if (!result)
+return 0;
+return static_castuint64_tfreeBytesToCaller.QuadPart;
+#else
+struct statvfs volumeInfo;
+if (statvfs(path, volumeInfo))
+return 0;
+
+return static_castuint64_t(volumeInfo.f_bavail) * static_castuint64_t(volumeInfo.f_frsize);
+#endif
+}
+
 int writeToFile(PlatformFileHandle handle, const char* data, int length)
 {
 if (handle  handle-exists()  handle-isWritable())


Modified: trunk/Source/WebKit2/ChangeLog (106919 => 106920)

--- trunk/Source/WebKit2/ChangeLog	2012-02-07 11:19:23 UTC (rev 106919)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-07 11:42:39 UTC (rev 106920)
@@ -1,3 +1,28 @@
+2012-02-07  Michael Brüning  michael.brun...@nokia.com
+
+[Qt][WK2] Compute and set cache capacities using the current CacheModel
+https://bugs.webkit.org/show_bug.cgi?id=73918
+
+Reviewed by Kenneth Rohde Christiansen.
+
+First part of the implementation. The next steps are the implementation
+of the API for the Qt WebKit 2 port and the hybrid memory and disk cache.
+
+* Shared/WebProcessCreationParameters.cpp:
+(WebKit::WebProcessCreationParameters::encode):
+(WebKit::WebProcessCreationParameters::decode):
+* Shared/WebProcessCreationParameters.h:
+

[webkit-changes] [106922] trunk/LayoutTests

Title: [106922] trunk/LayoutTests








Revision 106922
Author commit-qu...@webkit.org
Date 2012-02-07 03:50:37 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed, rolling out r106915.
http://trac.webkit.org/changeset/106915
https://bugs.webkit.org/show_bug.cgi?id=77961

because 106912 was rolled out (Requested by Ossy on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-07

* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt
trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt
trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106921 => 106922)

--- trunk/LayoutTests/ChangeLog	2012-02-07 11:45:29 UTC (rev 106921)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 11:50:37 UTC (rev 106922)
@@ -1,3 +1,17 @@
+2012-02-07  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r106915.
+http://trac.webkit.org/changeset/106915
+https://bugs.webkit.org/show_bug.cgi?id=77961
+
+because 106912 was rolled out (Requested by Ossy on #webkit).
+
+* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
+* platform/gtk/fast/js/global-constructors-expected.txt:
+* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt:
+* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
+* platform/qt/fast/js/global-constructors-expected.txt:
+
 2012-02-05  Nikolas Zimmermann  nzimmerm...@rim.com
 
 Rewrite SVG tests to make extensive use of display() in repaint tests


Modified: trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt (106921 => 106922)

--- trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt	2012-02-07 11:45:29 UTC (rev 106921)
+++ trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-2-expected.txt	2012-02-07 11:50:37 UTC (rev 106922)
@@ -240,7 +240,6 @@
 Never found DOMParser
 Never found DOMSettableTokenList
 Never found DOMStringList
-Never found DOMURL
 Never found Document
 Never found DocumentFragment
 Never found DocumentType


Modified: trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt (106921 => 106922)

--- trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt	2012-02-07 11:45:29 UTC (rev 106921)
+++ trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt	2012-02-07 11:50:37 UTC (rev 106922)
@@ -333,7 +333,6 @@
 PASS XPathResult.toString() is '[object XPathResultConstructor]'
 PASS XSLTProcessor.toString() is '[object XSLTProcessorConstructor]'
 FAIL webkitPeerConnection.toString() should be [object webkitPeerConnectionConstructor]. Was [object PeerConnectionConstructor].
-FAIL webkitURL.toString() should be [object webkitURLConstructor]. Was [object DOMURLConstructor].
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt (106921 => 106922)

--- trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt	2012-02-07 11:45:29 UTC (rev 106921)
+++ trunk/LayoutTests/platform/qt/fast/dom/constructed-objects-prototypes-expected.txt	2012-02-07 11:50:37 UTC (rev 106922)
@@ -61,8 +61,6 @@
 PASS (new inner.XPathEvaluator()).constructor.isInner is true
 PASS (new inner.XSLTProcessor()).isInner is true
 PASS (new inner.XSLTProcessor()).constructor.isInner is true
-PASS (new inner.webkitURL()).isInner is true
-PASS (new inner.webkitURL()).constructor.isInner is true
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt (106921 => 106922)

--- trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt	2012-02-07 11:45:29 UTC (rev 106921)
+++ trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt	2012-02-07 11:50:37 UTC (rev 106922)
@@ -240,7 +240,6 @@
 Never found DOMParser
 Never found DOMSettableTokenList
 Never found DOMStringList
-Never found DOMURL
 Never found Document
 Never found DocumentFragment
 Never found DocumentType


Modified: trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt (106921 => 106922)

--- trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt	2012-02-07 11:45:29 UTC (rev 106921)
+++ trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt	2012-02-07 11:50:37 UTC (rev

[webkit-changes] [106925] trunk/Source/WebCore

2012-02-07 Thread kling

Title: [106925] trunk/Source/WebCore








Revision 106925
Author kl...@webkit.org
Date 2012-02-07 04:29:28 -0800 (Tue, 07 Feb 2012)


Log Message
REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark
http://webkit.org/b/77952

Reviewed by Andreas Kling.
Patch by Ryosuke Niwa.

The performance regression was caused by using ensureAttributeData() which forces the
regeneration of invalidated attributes (style and SVG animatable attributes.)
Added an ensureAttributeDataWithoutUpdate() helper that only ensures the presence
of ElementAttributeData, not the validity of its contents. Use that when grabbing
at an element's inline and attribute styles.

* dom/Element.h:
(Element):
(WebCore::Element::ensureAttributeDataWithoutUpdate):
* dom/StyledElement.h:
(WebCore::StyledElement::ensureInlineStyleDecl):
(WebCore::StyledElement::ensureAttributeStyle):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/StyledElement.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106924 => 106925)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 12:23:12 UTC (rev 106924)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 12:29:28 UTC (rev 106925)
@@ -1,3 +1,24 @@
+2012-02-07  Andreas Kling  awesomekl...@apple.com
+
+REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark
+http://webkit.org/b/77952
+
+Reviewed by Andreas Kling.
+Patch by Ryosuke Niwa.
+
+The performance regression was caused by using ensureAttributeData() which forces the
+regeneration of invalidated attributes (style and SVG animatable attributes.)
+Added an ensureAttributeDataWithoutUpdate() helper that only ensures the presence
+of ElementAttributeData, not the validity of its contents. Use that when grabbing
+at an element's inline and attribute styles.
+
+* dom/Element.h:
+(Element):
+(WebCore::Element::ensureAttributeDataWithoutUpdate):
+* dom/StyledElement.h:
+(WebCore::StyledElement::ensureInlineStyleDecl):
+(WebCore::StyledElement::ensureAttributeStyle):
+
 2012-02-07  Michael Brüning  michael.brun...@nokia.com
 
 [Qt][WK2] Compute and set cache capacities using the current CacheModel


Modified: trunk/Source/WebCore/dom/Element.h (106924 => 106925)

--- trunk/Source/WebCore/dom/Element.h	2012-02-07 12:23:12 UTC (rev 106924)
+++ trunk/Source/WebCore/dom/Element.h	2012-02-07 12:29:28 UTC (rev 106925)
@@ -242,6 +242,9 @@
 ElementAttributeData* attributeData() const { return m_attributeMap ? m_attributeMap-attributeData() : 0; }
 ElementAttributeData* ensureAttributeData() const { return ensureUpdatedAttributes()-attributeData(); }
 
+// FIXME: This method should be removed once AttributeData is moved to Element.
+ElementAttributeData* ensureAttributeDataWithoutUpdate() const { return ensureAttributeMap()-attributeData(); }
+
 void setAttributesFromElement(const Element);
 
 virtual void copyNonAttributeProperties(const Element* source);


Modified: trunk/Source/WebCore/dom/StyledElement.h (106924 => 106925)

--- trunk/Source/WebCore/dom/StyledElement.h	2012-02-07 12:23:12 UTC (rev 106924)
+++ trunk/Source/WebCore/dom/StyledElement.h	2012-02-07 12:29:28 UTC (rev 106925)
@@ -48,11 +48,11 @@
 void invalidateStyleAttribute();
 
 StylePropertySet* inlineStyleDecl() const { return attributeData() ? attributeData()-inlineStyleDecl() : 0; }
-StylePropertySet* ensureInlineStyleDecl() { return ensureAttributeData()-ensureInlineStyleDecl(this); }
+StylePropertySet* ensureInlineStyleDecl() { return ensureAttributeDataWithoutUpdate()-ensureInlineStyleDecl(this); }
 virtual CSSStyleDeclaration* style() OVERRIDE { return ensureInlineStyleDecl()-ensureCSSStyleDeclaration(); }
 
 StylePropertySet* attributeStyle() const { return attributeData() ? attributeData()-attributeStyle() : 0; }
-StylePropertySet* ensureAttributeStyle() { return ensureAttributeData()-ensureAttributeStyle(this); }
+StylePropertySet* ensureAttributeStyle() { return ensureAttributeDataWithoutUpdate()-ensureAttributeStyle(this); }
 
 const SpaceSplitString classNames() const;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106926] trunk/Source/WebCore

2012-02-07 Thread loislo

Title: [106926] trunk/Source/WebCore








Revision 106926
Author loi...@chromium.org
Date 2012-02-07 04:43:10 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed, rolling out r106909.
http://trac.webkit.org/changeset/106909
https://bugs.webkit.org/show_bug.cgi?id=77965

~20 tests are crashing on chromium win release bot. (Requested
by loislo on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-07

* html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::createShadowSubtree):
* html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::createShadowSubtree):
* html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::createShadowSubtree):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::createShadowSubtree):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLDetailsElement.cpp
trunk/Source/WebCore/html/HTMLKeygenElement.cpp
trunk/Source/WebCore/html/HTMLMeterElement.cpp
trunk/Source/WebCore/html/HTMLProgressElement.cpp
trunk/Source/WebCore/html/HTMLSummaryElement.cpp
trunk/Source/WebCore/html/HTMLTextAreaElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106925 => 106926)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 12:29:28 UTC (rev 106925)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 12:43:10 UTC (rev 106926)
@@ -1,3 +1,25 @@
+2012-02-07  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed, rolling out r106909.
+http://trac.webkit.org/changeset/106909
+https://bugs.webkit.org/show_bug.cgi?id=77965
+
+~20 tests are crashing on chromium win release bot. (Requested
+by loislo on #webkit).
+
+* html/HTMLDetailsElement.cpp:
+(WebCore::HTMLDetailsElement::createShadowSubtree):
+* html/HTMLKeygenElement.cpp:
+(WebCore::HTMLKeygenElement::HTMLKeygenElement):
+* html/HTMLMeterElement.cpp:
+(WebCore::HTMLMeterElement::createShadowSubtree):
+* html/HTMLProgressElement.cpp:
+(WebCore::HTMLProgressElement::createShadowSubtree):
+* html/HTMLSummaryElement.cpp:
+(WebCore::HTMLSummaryElement::createShadowSubtree):
+* html/HTMLTextAreaElement.cpp:
+(WebCore::HTMLTextAreaElement::createShadowSubtree):
+
 2012-02-07  Andreas Kling  awesomekl...@apple.com
 
 REGRESSION(r106819): ~28% or so performance regression on the ManInBlue HTML benchmark


Modified: trunk/Source/WebCore/html/HTMLDetailsElement.cpp (106925 => 106926)

--- trunk/Source/WebCore/html/HTMLDetailsElement.cpp	2012-02-07 12:29:28 UTC (rev 106925)
+++ trunk/Source/WebCore/html/HTMLDetailsElement.cpp	2012-02-07 12:43:10 UTC (rev 106926)
@@ -109,10 +109,8 @@
 void HTMLDetailsElement::createShadowSubtree()
 {
 ASSERT(!shadowRoot());
-
-RefPtrShadowRoot root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-root-appendChild(DetailsSummaryElement::create(document()), ASSERT_NO_EXCEPTION, true);
-root-appendChild(DetailsContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
+ensureShadowRoot()-appendChild(DetailsSummaryElement::create(document()), ASSERT_NO_EXCEPTION, true);
+ensureShadowRoot()-appendChild(DetailsContentElement::create(document()), ASSERT_NO_EXCEPTION, true);
 }
 
 Element* HTMLDetailsElement::findMainSummary() const


Modified: trunk/Source/WebCore/html/HTMLKeygenElement.cpp (106925 => 106926)

--- trunk/Source/WebCore/html/HTMLKeygenElement.cpp	2012-02-07 12:29:28 UTC (rev 106925)
+++ trunk/Source/WebCore/html/HTMLKeygenElement.cpp	2012-02-07 12:43:10 UTC (rev 106926)
@@ -85,9 +85,7 @@
 option-appendChild(Text::create(document, keys[i]), ec);
 }
 
-ASSERT(!shadowRoot());
-RefPtrShadowRoot root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-root-appendChild(select, ec);
+ensureShadowRoot()-appendChild(select, ec);
 }
 
 PassRefPtrHTMLKeygenElement HTMLKeygenElement::create(const QualifiedName tagName, Document* document, HTMLFormElement* form)


Modified: trunk/Source/WebCore/html/HTMLMeterElement.cpp (106925 => 106926)

--- trunk/Source/WebCore/html/HTMLMeterElement.cpp	2012-02-07 12:29:28 UTC (rev 106925)
+++ trunk/Source/WebCore/html/HTMLMeterElement.cpp	2012-02-07 12:43:10 UTC (rev 106926)
@@ -234,15 +234,11 @@
 
 void HTMLMeterElement::createShadowSubtree()
 {
-ASSERT(!shadowRoot());
-
 RefPtrMeterBarElement bar = MeterBarElement::create(document());
 m_value = MeterValueElement::create(document());
 ExceptionCode ec = 0;
 bar-appendChild(m_value, ec);
-
-RefPtrShadowRoot root = ShadowRoot::create(this, ASSERT_NO_EXCEPTION);
-root-appendChild(bar, ec);
+ensureShadowRoot()-appendChild(bar, ec);
 }
 
 } // namespace


Modified: trunk/Source/WebCore/html/HTMLProgressElement.cpp (106925 => 106926)

--- trunk/Source/WebCore/html/HTMLProgressElement.cpp	2012-02-07 12:29:28

[webkit-changes] [106927] trunk/LayoutTests

Title: [106927] trunk/LayoutTests








Revision 106927
Author o...@webkit.org
Date 2012-02-07 04:44:42 -0800 (Tue, 07 Feb 2012)


Log Message
[Qt] New svg/hittest tests introduced in r106882 fail
https://bugs.webkit.org/show_bug.cgi?id=77964

Patch by Ádám Kallai kallai.a...@stud.u-szeged.hu on 2012-02-07
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip failing tests until fix.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (106926 => 106927)

--- trunk/LayoutTests/ChangeLog	2012-02-07 12:43:10 UTC (rev 106926)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 12:44:42 UTC (rev 106927)
@@ -1,3 +1,12 @@
+2012-02-07  Ádám Kallai  kallai.a...@stud.u-szeged.hu
+
+[Qt] New svg/hittest tests introduced in r106882 fail
+https://bugs.webkit.org/show_bug.cgi?id=77964
+
+Reviewed by Csaba Osztrogonác.
+
+* platform/qt/Skipped: Skip failing tests until fix.
+
 2012-02-07  Philippe Normand  pnorm...@igalia.com
 
 Unreviewed, GTK svg rebaseline after r106918.


Modified: trunk/LayoutTests/platform/qt/Skipped (106926 => 106927)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-07 12:43:10 UTC (rev 106926)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-07 12:44:42 UTC (rev 106927)
@@ -1378,6 +1378,11 @@
 # https://bugs.webkit.org/show_bug.cgi?id=69511
 svg/as-image/svg-nested.html
 
+#[Qt] New svg/hittest tests introduced in r106882 fail
+#https://bugs.webkit.org/show_bug.cgi?id=77964
+svg/hittest/zero-length-round-cap-path.xhtml
+svg/hittest/zero-length-square-cap-path.xhtml
+
 # = #
 # Failing CSS Tests
 # = #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106928] trunk

2012-02-07 Thread yurys

Title: [106928] trunk








Revision 106928
Author yu...@chromium.org
Date 2012-02-07 04:52:48 -0800 (Tue, 07 Feb 2012)


Log Message
Web Inspector: don't mark object is queriable if it is only reachable by internal reference
https://bugs.webkit.org/show_bug.cgi?id=77877

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

LayoutTests:

* inspector/profiler/heap-snapshot.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/profiler/heap-snapshot.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js




Diff

Modified: trunk/LayoutTests/ChangeLog (106927 => 106928)

--- trunk/LayoutTests/ChangeLog	2012-02-07 12:44:42 UTC (rev 106927)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 12:52:48 UTC (rev 106928)
@@ -1,3 +1,12 @@
+2012-02-06  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: don't mark object is queriable if it is only reachable by internal reference
+https://bugs.webkit.org/show_bug.cgi?id=77877
+
+Reviewed by Pavel Feldman.
+
+* inspector/profiler/heap-snapshot.html:
+
 2012-02-07  Ádám Kallai  kallai.a...@stud.u-szeged.hu
 
 [Qt] New svg/hittest tests introduced in r106882 fail


Modified: trunk/LayoutTests/inspector/profiler/heap-snapshot.html (106927 => 106928)

--- trunk/LayoutTests/inspector/profiler/heap-snapshot.html	2012-02-07 12:44:42 UTC (rev 106927)
+++ trunk/LayoutTests/inspector/profiler/heap-snapshot.html	2012-02-07 12:52:48 UTC (rev 106928)
@@ -162,7 +162,7 @@
G: false,
H: false,
M: false,
-   N: true,
+   N: false,
DOMWindow: true
 };
 for (var nodes = snapshot._allNodes; nodes.hasNext(); nodes.next()) {


Modified: trunk/Source/WebCore/ChangeLog (106927 => 106928)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 12:44:42 UTC (rev 106927)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 12:52:48 UTC (rev 106928)
@@ -1,3 +1,13 @@
+2012-02-06  Yury Semikhatsky  yu...@chromium.org
+
+Web Inspector: don't mark object is queriable if it is only reachable by internal reference
+https://bugs.webkit.org/show_bug.cgi?id=77877
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/HeapSnapshot.js:
+(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
+
 2012-02-07  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r106909.


Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (106927 => 106928)

--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-02-07 12:44:42 UTC (rev 106927)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-02-07 12:52:48 UTC (rev 106928)
@@ -1129,14 +1129,14 @@
 for (var iter = node.edges; iter.hasNext(); iter.next()) {
 var edge = iter.edge;
 var node = edge.node;
-if (this._flags[node.nodeIndex])
+if (this._flags[node.nodeIndex]  flag)
 continue;
 if (edge.isHidden || edge.isInvisible)
 continue;
 var name = edge.name;
 if (!name)
 continue;
-if (edge.isInternal  name !== native)
+if (edge.isInternal)
 continue;
 list.push(node);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106929] trunk/Source/WebKit/chromium

Title: [106929] trunk/Source/WebKit/chromium








Revision 106929
Author commit-qu...@webkit.org
Date 2012-02-07 04:55:46 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-07

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (106928 => 106929)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-07 12:52:48 UTC (rev 106928)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-07 12:55:46 UTC (rev 106929)
@@ -1,3 +1,9 @@
+2012-02-07  Sheriff Bot  webkit.review@gmail.com
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2012-02-06  James Robinson  jam...@chromium.org
 
 [chromium] canvas demo is slow due to unnecessary resource cleanups


Modified: trunk/Source/WebKit/chromium/DEPS (106928 => 106929)

--- trunk/Source/WebKit/chromium/DEPS	2012-02-07 12:52:48 UTC (rev 106928)
+++ trunk/Source/WebKit/chromium/DEPS	2012-02-07 12:55:46 UTC (rev 106929)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '120680'
+  'chromium_rev': '120754'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106931] trunk/Source/WebCore

Title: [106931] trunk/Source/WebCore








Revision 106931
Author commit-qu...@webkit.org
Date 2012-02-07 05:41:30 -0800 (Tue, 07 Feb 2012)


Log Message
[Blackberry] Clean up Networkjob and Networkmanger: remove unused variables in release build and change some public functions into be private ones
https://bugs.webkit.org/show_bug.cgi?id=77926

Patch by Chris Guan chris.g...@torchmobile.com.cn on 2012-02-07
Reviewed by Rob Buis.

1. rename clientIsOk to isClientAvailable.
2. m_isRunning is only for an ASSERT in NetWorkManager, So move out from
release build but keep available in debug build.

No changes in behavior, so no new tests.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::NetworkJob):
(WebCore::NetworkJob::handleNotifyDataReceived):
(WebCore::NetworkJob::handleNotifyDataSent):
(WebCore::NetworkJob::handleNotifyClose):
(WebCore::NetworkJob::startNewJobWithRequest):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::sendMultipartResponseIfNeeded):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):
(WebCore::NetworkJob::isClientAvailable):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106930 => 106931)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 13:09:46 UTC (rev 106930)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 13:41:30 UTC (rev 106931)
@@ -1,3 +1,28 @@
+2012-02-07  Chris Guan  chris.g...@torchmobile.com.cn
+
+[Blackberry] Clean up Networkjob and Networkmanger: remove unused variables in release build and change some public functions into be private ones
+https://bugs.webkit.org/show_bug.cgi?id=77926
+
+Reviewed by Rob Buis.
+
+1. rename clientIsOk to isClientAvailable.
+2. m_isRunning is only for an ASSERT in NetWorkManager, So move out from
+release build but keep available in debug build.
+
+No changes in behavior, so no new tests.
+
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::NetworkJob):
+(WebCore::NetworkJob::handleNotifyDataReceived):
+(WebCore::NetworkJob::handleNotifyDataSent):
+(WebCore::NetworkJob::handleNotifyClose):
+(WebCore::NetworkJob::startNewJobWithRequest):
+(WebCore::NetworkJob::sendResponseIfNeeded):
+(WebCore::NetworkJob::sendMultipartResponseIfNeeded):
+* platform/network/blackberry/NetworkJob.h:
+(NetworkJob):
+(WebCore::NetworkJob::isClientAvailable):
+
 2012-02-06  Yury Semikhatsky  yu...@chromium.org
 
 Web Inspector: don't mark object is queriable if it is only reachable by internal reference


Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (106930 => 106931)

--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-02-07 13:09:46 UTC (rev 106930)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-02-07 13:41:30 UTC (rev 106931)
@@ -97,7 +97,9 @@
 , m_isAbout(false)
 , m_isFTP(false)
 , m_isFTPDir(true)
+#ifndef NDEBUG
 , m_isRunning(true) // Always started immediately after creation.
+#endif
 , m_cancelled(false)
 , m_statusReceived(false)
 , m_dataReceived(false)
@@ -379,7 +381,7 @@
 if (shouldSendClientData()) {
 sendResponseIfNeeded();
 sendMultipartResponseIfNeeded();
-if (clientIsOk()) {
+if (isClientAvailable()) {
 RecursionGuard guard(m_callingClient);
 m_handle-client()-didReceiveData(m_handle.get(), buf, len, len);
 }
@@ -404,7 +406,7 @@
 // Protect against reentrancy.
 updateDeferLoadingCount(1);
 
-if (clientIsOk()) {
+if (isClientAvailable()) {
 RecursionGuard guard(m_callingClient);
 m_handle-client()-didSendData(m_handle.get(), bytesSent, totalBytesToBeSent);
 }
@@ -422,8 +424,9 @@
 
 void NetworkJob::handleNotifyClose(int status)
 {
+#ifndef NDEBUG
 m_isRunning = false;
-
+#endif
 if (!m_cancelled) {
 if (!m_statusReceived) {
 // Connection failed before sending notifyStatusReceived: use generic NetworkError.
@@ -443,7 +446,7 @@
 m_extendedStatusCode = BlackBerry::Platform::FilterStream::StatusTooManyRedirects;
 
 sendResponseIfNeeded();
-if (clientIsOk()) {
+if (isClientAvailable()) {
 
 RecursionGuard guard(m_callingClient);
 if (isError(m_extendedStatusCode)  !m_dataReceived) {
@@ -498,7 +501,7 @@
 
 bool NetworkJob::startNewJobWithRequest(ResourceRequest newRequest, bool increasRedirectCount)
 {
-if (clientIsOk()) {
+if (isClientAvailable()) {
 RecursionGuard guard(m_callingClient);
 m_handle-client()-willSendRequest(m_handle.get(), newRequest, m_response);
 
@@ -616,7 +619,7 @@
 if (m_isFile || m_isData ||

[webkit-changes] [106933] trunk/Source/WebCore

Title: [106933] trunk/Source/WebCore








Revision 106933
Author o...@webkit.org
Date 2012-02-07 06:32:35 -0800 (Tue, 07 Feb 2012)


Log Message
[Qt][WK2] Compute and set cache capacities using the current CacheModel
https://bugs.webkit.org/show_bug.cgi?id=73918

Patch by Michael Brüning michael.brun...@nokia.com on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

No new tests. (build fix)

* platform/qt/FileSystemQt.cpp:
(WebCore::getVolumeFreeSizeForPath):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/FileSystemQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106932 => 106933)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 14:00:24 UTC (rev 106932)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 14:32:35 UTC (rev 106933)
@@ -1,3 +1,15 @@
+2012-02-07  Michael Brüning  michael.brun...@nokia.com
+
+[Qt][WK2] Compute and set cache capacities using the current CacheModel
+https://bugs.webkit.org/show_bug.cgi?id=73918
+
+Reviewed by Kenneth Rohde Christiansen.
+
+No new tests. (build fix)
+
+* platform/qt/FileSystemQt.cpp:
+(WebCore::getVolumeFreeSizeForPath):
+
 2012-02-07  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: add generic support for undo-ing DOM edits.


Modified: trunk/Source/WebCore/platform/qt/FileSystemQt.cpp (106932 => 106933)

--- trunk/Source/WebCore/platform/qt/FileSystemQt.cpp	2012-02-07 14:00:24 UTC (rev 106932)
+++ trunk/Source/WebCore/platform/qt/FileSystemQt.cpp	2012-02-07 14:32:35 UTC (rev 106933)
@@ -200,7 +200,7 @@
 BOOL result = GetDiskFreeSpaceExW((LPCWSTR)path, freeBytesToCaller, 0, 0);
 if (!result)
 return 0;
-return static_castuint64_tfreeBytesToCaller.QuadPart;
+return static_castuint64_t(freeBytesToCaller.QuadPart);
 #else
 struct statvfs volumeInfo;
 if (statvfs(path, volumeInfo))






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106934] trunk/LayoutTests

2012-02-07 Thread tonyg

Title: [106934] trunk/LayoutTests








Revision 106934
Author to...@chromium.org
Date 2012-02-07 06:52:17 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed gardening.

* platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png: Added. Pixel results for platform font.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (106933 => 106934)

--- trunk/LayoutTests/ChangeLog	2012-02-07 14:32:35 UTC (rev 106933)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 14:52:17 UTC (rev 106934)
@@ -1,3 +1,9 @@
+2012-02-07  Tony Gentilcore  to...@chromium.org
+
+Unreviewed gardening.
+
+* platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png: Added. Pixel results for platform font.
+
 2012-02-07  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: add generic support for undo-ing DOM edits.


Added: trunk/LayoutTests/platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/fast/canvas/check-stale-putImageData-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106935] trunk/Source

Title: [106935] trunk/Source








Revision 106935
Author commit-qu...@webkit.org
Date 2012-02-07 07:16:55 -0800 (Tue, 07 Feb 2012)


Log Message
[chromium] Add setNeedsRedraw to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=77555

Patch by Jonathan Backer bac...@chromium.org on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
(WebCore::CCThreadProxy::resetDamageTrackerOnImplThread):
(WebCore):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* public/WebWidget.h:
(WebWidget):
(WebKit::WebWidget::setNeedsRedraw):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setNeedsRedraw):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106934 => 106935)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 14:52:17 UTC (rev 106934)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 15:16:55 UTC (rev 106935)
@@ -1,3 +1,21 @@
+2012-02-07  Jonathan Backer  bac...@chromium.org
+
+[chromium] Add setNeedsRedraw to WebWidget
+https://bugs.webkit.org/show_bug.cgi?id=77555
+
+Reviewed by James Robinson.
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::setNeedsRedraw):
+* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+(WebCore::CCSingleThreadProxy::setNeedsRedraw):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::setNeedsRedraw):
+(WebCore::CCThreadProxy::resetDamageTrackerOnImplThread):
+(WebCore):
+* platform/graphics/chromium/cc/CCThreadProxy.h:
+(CCThreadProxy):
+
 2012-02-07  Michael Brüning  michael.brun...@nokia.com
 
 [Qt][WK2] Compute and set cache capacities using the current CacheModel


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (106934 => 106935)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-02-07 14:52:17 UTC (rev 106934)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-02-07 15:16:55 UTC (rev 106935)
@@ -251,9 +251,8 @@
 
 void CCLayerTreeHost::setNeedsRedraw()
 {
-if (CCThreadProxy::implThread())
-m_proxy-setNeedsRedraw();
-else
+m_proxy-setNeedsRedraw();
+if (!CCThreadProxy::implThread())
 m_client-scheduleComposite();
 }
 


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp (106934 => 106935)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp	2012-02-07 14:52:17 UTC (rev 106934)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp	2012-02-07 15:16:55 UTC (rev 106935)
@@ -29,6 +29,7 @@
 #include GraphicsContext3D.h
 #include LayerRendererChromium.h
 #include TraceEvent.h
+#include cc/CCDamageTracker.h
 #include cc/CCLayerTreeHost.h
 #include cc/CCTextureUpdater.h
 #include wtf/CurrentTime.h
@@ -194,6 +195,10 @@
 
 void CCSingleThreadProxy::setNeedsRedraw()
 {
+CCRenderSurface* renderSurface = m_layerTreeHostImpl-rootLayer()-renderSurface();
+if (renderSurface)
+renderSurface-damageTracker()-forceFullDamageNextUpdate();
+
 // FIXME: Once we move render_widget scheduling into this class, we can
 // treat redraw requests more efficiently than commitAndRedraw requests.
 setNeedsCommit();


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp (106934 => 106935)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp	2012-02-07 14:52:17 UTC (rev 106934)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp	2012-02-07 15:16:55 UTC (rev 106935)
@@ -28,6 +28,7 @@
 
 #include GraphicsContext3D.h
 #include TraceEvent.h
+#include cc/CCDamageTracker.h
 #include cc/CCDelayBasedTimeSource.h
 #include cc/CCFrameRateController.h
 #include cc/CCInputHandler.h
@@ -248,6 +249,7 @@
 {
 ASSERT(isMainThread());
 TRACE_EVENT(CCThreadProxy::setNeedsRedraw, this, 0);
+CCProxy::implThread()-postTask(createCCThreadTask(this, CCThreadProxy::resetDamageTrackerOnImplThread));
 CCProxy::implThread()-postTask(createCCThreadTask(this,

[webkit-changes] [106936] trunk/Tools

2012-02-07 Thread mario

Title: [106936] trunk/Tools








Revision 106936
Author ma...@webkit.org
Date 2012-02-07 07:22:03 -0800 (Tue, 07 Feb 2012)


Log Message
[GTK] Include gdk-pixbuf in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=77980

Reviewed by Gustavo Noronha Silva.

* gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (106935 => 106936)

--- trunk/Tools/ChangeLog	2012-02-07 15:16:55 UTC (rev 106935)
+++ trunk/Tools/ChangeLog	2012-02-07 15:22:03 UTC (rev 106936)
@@ -1,3 +1,12 @@
+2012-02-07  Mario Sanchez Prada  msanc...@igalia.com
+
+[GTK] Include gdk-pixbuf in the jhbuild modules
+https://bugs.webkit.org/show_bug.cgi?id=77980
+
+Reviewed by Gustavo Noronha Silva.
+
+* gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
+
 2012-02-07  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Prevent early test termination with newer Qt 5


Modified: trunk/Tools/gtk/jhbuild.modules (106935 => 106936)

--- trunk/Tools/gtk/jhbuild.modules	2012-02-07 15:16:55 UTC (rev 106935)
+++ trunk/Tools/gtk/jhbuild.modules	2012-02-07 15:22:03 UTC (rev 106936)
@@ -9,6 +9,7 @@
   dep package=fonts/
   dep package=fontconfig/
   dep package=freetype6/
+  dep package=gdk-pixbuf/
   dep package=gtk+/
   dep package=glib/
   dep package=glib-networking/
@@ -93,10 +94,21 @@
  md5sum=79390673f5d07a8fb342bc09b5055b6f/
   /autotools
 
+  autotools id=gdk-pixbuf autogen-sh=configure
+dependencies
+  dep package=glib/
+/dependencies
+branch module=/pub/GNOME/sources/gdk-pixbuf/2.23/gdk-pixbuf-2.23.5.tar.xz version=2.23.5
+repo=ftp.gnome.org
+hash=sha256:7a6c3550426f38f6b0eeeb49295654d9e706ce8f1786a4d0932f9d2c0d0bc500
+md5sum=066e30277cadc225a7cef4c258da830b/
+  /autotools
+
   autotools id=gtk+
 dependencies
   dep package=glib/
   dep package=cairo/
+  dep package=gdk-pixbuf/
 /dependencies
 branch module=/pub/GNOME/sources/gtk+/3.0/gtk+-3.0.12.tar.xz version=3.0.12
 repo=ftp.gnome.org






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106937] trunk/Source/WebCore

Title: [106937] trunk/Source/WebCore








Revision 106937
Author commit-qu...@webkit.org
Date 2012-02-07 07:27:08 -0800 (Tue, 07 Feb 2012)


Log Message
Web Inspector: fix objects duplication when switching filter in heap profiler.
https://bugs.webkit.org/show_bug.cgi?id=77974

Patch by Alexei Filippov alex...@chromium.org on 2012-02-07
Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (106936 => 106937)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 15:22:03 UTC (rev 106936)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 15:27:08 UTC (rev 106937)
@@ -1,3 +1,13 @@
+2012-02-07  Alexei Filippov  alex...@chromium.org
+
+Web Inspector: fix objects duplication when switching filter in heap profiler.
+https://bugs.webkit.org/show_bug.cgi?id=77974
+
+Reviewed by Yury Semikhatsky.
+
+* inspector/front-end/DetailedHeapshotView.js:
+(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
+
 2012-02-07  Jonathan Backer  bac...@chromium.org
 
 [chromium] Add setNeedsRedraw to WebWidget


Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js (106936 => 106937)

--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js	2012-02-07 15:22:03 UTC (rev 106936)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js	2012-02-07 15:27:08 UTC (rev 106937)
@@ -238,17 +238,13 @@
 this.sortingChanged();
 }
 
-if (this._filterProfileIndex === -1) {
-this.snapshot.aggregates(false, allObjects, null, aggregatesReceived.bind(this, allObjects));
-return;
-}
-
 this.dispose();
 this.removeChildren();
 this.resetSortingCache();
 
-var key = this._minNodeId + .. + this._maxNodeId;
-var filter = function(node) { var id = node.id; return id   + this._minNodeId +   id =  + this._maxNodeId + ; };
+var key = this._filterProfileIndex === -1 ? allObjects : this._minNodeId + .. + this._maxNodeId;
+var filter = this._filterProfileIndex === -1 ? null : function(node) { var id = node.id; return id   + this._minNodeId +   id =  + this._maxNodeId + ; };
+
 this.snapshot.aggregates(false, key, filter, aggregatesReceived.bind(this, key));
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106939] trunk/Source/WebKit2

2012-02-07 Thread abecsi

Title: [106939] trunk/Source/WebKit2








Revision 106939
Author abe...@webkit.org
Date 2012-02-07 07:33:58 -0800 (Tue, 07 Feb 2012)


Log Message
[Qt] [WK2] Fix the debug build after r106920

* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformSetCacheModel):
Remove unnecessary assert.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/qt/WebProcessQt.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (106938 => 106939)

--- trunk/Source/WebKit2/ChangeLog	2012-02-07 15:29:34 UTC (rev 106938)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-07 15:33:58 UTC (rev 106939)
@@ -1,3 +1,11 @@
+2012-02-07  Andras Becsi  andras.be...@nokia.com
+
+[Qt] [WK2] Fix the debug build after r106920
+
+* WebProcess/qt/WebProcessQt.cpp:
+(WebKit::WebProcess::platformSetCacheModel):
+Remove unnecessary assert.
+
 2012-02-03  Andras Becsi  andras.be...@nokia.com
 
 [Qt][WK2] Add the componentComplete method to WebView


Modified: trunk/Source/WebKit2/WebProcess/qt/WebProcessQt.cpp (106938 => 106939)

--- trunk/Source/WebKit2/WebProcess/qt/WebProcessQt.cpp	2012-02-07 15:29:34 UTC (rev 106938)
+++ trunk/Source/WebKit2/WebProcess/qt/WebProcessQt.cpp	2012-02-07 15:33:58 UTC (rev 106939)
@@ -96,7 +96,6 @@
 QNetworkDiskCache* diskCache = qobject_castQNetworkDiskCache*(m_networkAccessManager-cache());
 ASSERT(diskCache);
 
-ASSERT(WebCore::platformInfo());
 uint64_t physicalMemorySizeInMegabytes = physicalMemorySizeInBytes() / 1024 / 1024;
 
 // The Mac port of WebKit2 uses a fudge factor of 1000 here to account for misalignment, however,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106944] trunk

Title: [106944] trunk








Revision 106944
Author commit-qu...@webkit.org
Date 2012-02-07 07:55:39 -0800 (Tue, 07 Feb 2012)


Log Message
[GTK] Broken HTML5 scoped style detection
https://bugs.webkit.org/show_bug.cgi?id=77979

Patch by Priit Laes pl...@plaes.org on 2012-02-07
Reviewed by Gustavo Noronha Silva.

* configure.ac: Fix wrong variable for HTML5 style scoped detection

Modified Paths

trunk/ChangeLog
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (106943 => 106944)

--- trunk/ChangeLog	2012-02-07 15:54:43 UTC (rev 106943)
+++ trunk/ChangeLog	2012-02-07 15:55:39 UTC (rev 106944)
@@ -1,3 +1,12 @@
+2012-02-07  Priit Laes  pl...@plaes.org
+
+[GTK] Broken HTML5 scoped style detection
+https://bugs.webkit.org/show_bug.cgi?id=77979
+
+Reviewed by Gustavo Noronha Silva.
+
+* configure.ac: Fix wrong variable for HTML5 style scoped detection
+
 2012-02-06  Shinya Kawanaka  shin...@google.com
 
 Remove Element::ensureShadowRoot export.


Modified: trunk/configure.ac (106943 => 106944)

--- trunk/configure.ac	2012-02-07 15:54:43 UTC (rev 106943)
+++ trunk/configure.ac	2012-02-07 15:55:39 UTC (rev 106944)
@@ -742,7 +742,7 @@
 
 # check whether to enable HTML5 style scoped support
 AC_MSG_CHECKING([whether to enable HTML5 style scoped support])
-AC_ARG_ENABLE(file_system,
+AC_ARG_ENABLE(style_scoped,
   AC_HELP_STRING([--enable-style-scoped],
  [enable support for HTML5 style scoped [default=no]]),
   [], [enable_style_scoped=no])






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106945] trunk

Title: [106945] trunk








Revision 106945
Author commit-qu...@webkit.org
Date 2012-02-07 08:00:58 -0800 (Tue, 07 Feb 2012)


Log Message
Update .gitignore for Qt Creator/KDevelop.
https://bugs.webkit.org/show_bug.cgi?id=77984

Patch by Frederik Gladhorn frederik.gladh...@nokia.com on 2012-02-07
Reviewed by Simon Hausmann.

* .gitignore: Ignore temp files created by Qt Creator and KDevelop.

Modified Paths

trunk/.gitignore
trunk/ChangeLog




Diff

Modified: trunk/.gitignore (106944 => 106945)

--- trunk/.gitignore	2012-02-07 15:55:39 UTC (rev 106944)
+++ trunk/.gitignore	2012-02-07 16:00:58 UTC (rev 106945)
@@ -3,6 +3,7 @@
 *.perspective*
 *.pyc
 .DS_Store
+.directory
 build/
 /WebKitBuild/
 autoinstall.cache.d
@@ -191,3 +192,11 @@
 # Ignore files generated by the Qt build-system:
 Source/qtwebkitversion.h
 Tools/qmake/.build-hint
+
+# Ignore files generated by Qt Creator:
+*.pro.user
+
+# Ignore KDevelop files:
+.kdev_include_paths
+*.kdev4
+*.kate-swp


Modified: trunk/ChangeLog (106944 => 106945)

--- trunk/ChangeLog	2012-02-07 15:55:39 UTC (rev 106944)
+++ trunk/ChangeLog	2012-02-07 16:00:58 UTC (rev 106945)
@@ -1,3 +1,12 @@
+2012-02-07  Frederik Gladhorn  frederik.gladh...@nokia.com
+
+Update .gitignore for Qt Creator/KDevelop.
+https://bugs.webkit.org/show_bug.cgi?id=77984
+
+Reviewed by Simon Hausmann.
+
+* .gitignore: Ignore temp files created by Qt Creator and KDevelop.
+
 2012-02-07  Priit Laes  pl...@plaes.org
 
 [GTK] Broken HTML5 scoped style detection






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106946] trunk/Tools

Title: [106946] trunk/Tools








Revision 106946
Author commit-qu...@webkit.org
Date 2012-02-07 08:09:43 -0800 (Tue, 07 Feb 2012)


Log Message
[Qt] Give emulated touch-point a radius
https://bugs.webkit.org/show_bug.cgi?id=77985

Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.

Patch by Allan Sandfeld Jensen allan.jen...@nokia.com on 2012-02-07
Reviewed by Kenneth Rohde Christiansen.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
* MiniBrowser/qt/qml/MockTouchPoint.qml:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp
trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml




Diff

Modified: trunk/Tools/ChangeLog (106945 => 106946)

--- trunk/Tools/ChangeLog	2012-02-07 16:00:58 UTC (rev 106945)
+++ trunk/Tools/ChangeLog	2012-02-07 16:09:43 UTC (rev 106946)
@@ -1,3 +1,18 @@
+2012-02-07  Allan Sandfeld Jensen  allan.jen...@nokia.com
+
+[Qt] Give emulated touch-point a radius
+https://bugs.webkit.org/show_bug.cgi?id=77985
+
+Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
+
+Reviewed by Kenneth Rohde Christiansen.
+
+* MiniBrowser/qt/BrowserWindow.cpp:
+(BrowserWindow::updateVisualMockTouchPoints):
+* MiniBrowser/qt/MiniBrowserApplication.cpp:
+(MiniBrowserApplication::notify):
+* MiniBrowser/qt/qml/MockTouchPoint.qml:
+
 2012-02-07  Mario Sanchez Prada  msanc...@igalia.com
 
 [GTK] Include gdk-pixbuf in the jhbuild modules


Modified: trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp (106945 => 106946)

--- trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp	2012-02-07 16:00:58 UTC (rev 106945)
+++ trunk/Tools/MiniBrowser/qt/BrowserWindow.cpp	2012-02-07 16:09:43 UTC (rev 106946)
@@ -108,12 +108,14 @@
 mockTouchPointItem-setParentItem(rootObject());
 }
 
-QPointF position = touchPoint.area.topLeft();
+QPointF position = touchPoint.area.center();
 position.rx() -= geometry().x();
 position.ry() -= geometry().y();
 
 mockTouchPointItem-setX(position.x());
 mockTouchPointItem-setY(position.y());
+mockTouchPointItem-setWidth(touchPoint.area.width());
+mockTouchPointItem-setHeight(touchPoint.area.height());
 mockTouchPointItem-setProperty(pressed, QVariant(touchPoint.state != Qt::TouchPointReleased));
 }
 }


Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (106945 => 106946)

--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp	2012-02-07 16:00:58 UTC (rev 106945)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp	2012-02-07 16:09:43 UTC (rev 106946)
@@ -125,7 +125,7 @@
 const QMouseEvent* const mouseEvent = static_castQMouseEvent*(event);
 
 QWindowSystemInterface::TouchPoint touchPoint;
-touchPoint.area = QRectF(mouseEvent-globalPos(), QSizeF(1, 1));
+touchPoint.area = QRectF(mouseEvent-globalPos() - QPointF(30, 40), QSizeF(60, 80));
 touchPoint.pressure = 1;
 
 switch (mouseEvent-type()) {


Modified: trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml (106945 => 106946)

--- trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml	2012-02-07 16:00:58 UTC (rev 106945)
+++ trunk/Tools/MiniBrowser/qt/qml/MockTouchPoint.qml	2012-02-07 16:09:43 UTC (rev 106946)
@@ -37,7 +37,9 @@
 source: ../icons/touchpoint.png
 x: -(width / 2)
 y: -(height / 2)
-opacity: parent.pressed ? 0.8 : 0.0
+height: parent.height
+width: parent.width
+opacity: parent.pressed ? 0.6 : 0.0
 
 Behavior on opacity {
 NumberAnimation { duration: 200 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106948] trunk/LayoutTests

Title: [106948] trunk/LayoutTests








Revision 106948
Author o...@webkit.org
Date 2012-02-07 08:16:16 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed gardening after r106898. Update platform specific expected results

Patch by Ádám Kallai kallai.a...@stud.u-szeged.hu on 2012-02-07

* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt
trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106947 => 106948)

--- trunk/LayoutTests/ChangeLog	2012-02-07 16:13:37 UTC (rev 106947)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 16:16:16 UTC (rev 106948)
@@ -1,3 +1,10 @@
+2012-02-07  Ádám Kallai  kallai.a...@stud.u-szeged.hu
+
+Unreviewed gardening after r106898. Update platform specific expected results
+
+* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
+* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
+
 2012-02-07  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r106932.


Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt (106947 => 106948)

--- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt	2012-02-07 16:13:37 UTC (rev 106947)
+++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt	2012-02-07 16:16:16 UTC (rev 106948)
@@ -388,6 +388,7 @@
 PASS typeof Object.getOwnPropertyDescriptor(window, 'isNaN') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'isResultCorrect') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'isSuccessfullyParsed') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'isWorker') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'length') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'localStorage') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'location') is 'object'
@@ -501,6 +502,7 @@
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldHaveHadError') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldNotBe') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'startWorker') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'status') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'statusbar') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'stringify') is 'object'


Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt (106947 => 106948)

--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt	2012-02-07 16:13:37 UTC (rev 106947)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt	2012-02-07 16:16:16 UTC (rev 106948)
@@ -372,6 +372,7 @@
 PASS typeof Object.getOwnPropertyDescriptor(window, 'isNaN') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'isResultCorrect') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'isSuccessfullyParsed') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'isWorker') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'length') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'localStorage') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'location') is 'object'
@@ -493,6 +494,7 @@
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldHaveHadError') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldNotBe') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'shouldThrow') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'startWorker') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'status') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'statusbar') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'stringify') is 'object'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106950] trunk/LayoutTests

Title: [106950] trunk/LayoutTests








Revision 106950
Author o...@webkit.org
Date 2012-02-07 08:28:17 -0800 (Tue, 07 Feb 2012)


Log Message
[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
https://bugs.webkit.org/show_bug.cgi?id=52810

* platform/qt/Skipped: Skip one more test because of this bug.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (106949 => 106950)

--- trunk/LayoutTests/ChangeLog	2012-02-07 16:18:30 UTC (rev 106949)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 16:28:17 UTC (rev 106950)
@@ -1,3 +1,10 @@
+2012-02-07  Csaba Osztrogonác  o...@webkit.org
+
+[Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
+https://bugs.webkit.org/show_bug.cgi?id=52810
+
+* platform/qt/Skipped: Skip one more test because of this bug.
+
 2012-02-07  Ádám Kallai  kallai.a...@stud.u-szeged.hu
 
 Unreviewed gardening after r106898. Update platform specific expected results


Modified: trunk/LayoutTests/platform/qt/Skipped (106949 => 106950)

--- trunk/LayoutTests/platform/qt/Skipped	2012-02-07 16:18:30 UTC (rev 106949)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-02-07 16:28:17 UTC (rev 106950)
@@ -1339,6 +1339,7 @@
 svg/zoom/page/zoom-mask-with-percentages.svg
 svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html
 svg/dom/css-transforms.xhtml
+svg/carto.net/tabgroup.svg
 
 # [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
 # https://bugs.webkit.org/show_bug.cgi?id=52810






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106951] trunk/Source

2012-02-07 Thread tonyg

Title: [106951] trunk/Source








Revision 106951
Author to...@chromium.org
Date 2012-02-07 08:43:23 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed, rolling out r106935.
http://trac.webkit.org/changeset/106935
https://bugs.webkit.org/show_bug.cgi?id=77994

Crashes runMultiThread webkit_unit_test (Requested by tonyg-
cr on #webkit).

Patch by Sheriff Bot webkit.review@gmail.com on 2012-02-07

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::setNeedsRedraw):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::setNeedsRedraw):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* public/WebWidget.h:
(WebWidget):
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebWidget.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106950 => 106951)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 16:28:17 UTC (rev 106950)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 16:43:23 UTC (rev 106951)
@@ -1,5 +1,23 @@
 2012-02-07  Sheriff Bot  webkit.review@gmail.com
 
+Unreviewed, rolling out r106935.
+http://trac.webkit.org/changeset/106935
+https://bugs.webkit.org/show_bug.cgi?id=77994
+
+Crashes runMultiThread webkit_unit_test (Requested by tonyg-
+cr on #webkit).
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::setNeedsRedraw):
+* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+(WebCore::CCSingleThreadProxy::setNeedsRedraw):
+* platform/graphics/chromium/cc/CCThreadProxy.cpp:
+(WebCore::CCThreadProxy::setNeedsRedraw):
+* platform/graphics/chromium/cc/CCThreadProxy.h:
+(CCThreadProxy):
+
+2012-02-07  Sheriff Bot  webkit.review@gmail.com
+
 Unreviewed, rolling out r106932.
 http://trac.webkit.org/changeset/106932
 https://bugs.webkit.org/show_bug.cgi?id=77988


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (106950 => 106951)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-02-07 16:28:17 UTC (rev 106950)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-02-07 16:43:23 UTC (rev 106951)
@@ -251,8 +251,9 @@
 
 void CCLayerTreeHost::setNeedsRedraw()
 {
-m_proxy-setNeedsRedraw();
-if (!CCThreadProxy::implThread())
+if (CCThreadProxy::implThread())
+m_proxy-setNeedsRedraw();
+else
 m_client-scheduleComposite();
 }
 


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp (106950 => 106951)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp	2012-02-07 16:28:17 UTC (rev 106950)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp	2012-02-07 16:43:23 UTC (rev 106951)
@@ -29,7 +29,6 @@
 #include GraphicsContext3D.h
 #include LayerRendererChromium.h
 #include TraceEvent.h
-#include cc/CCDamageTracker.h
 #include cc/CCLayerTreeHost.h
 #include cc/CCTextureUpdater.h
 #include wtf/CurrentTime.h
@@ -195,10 +194,6 @@
 
 void CCSingleThreadProxy::setNeedsRedraw()
 {
-CCRenderSurface* renderSurface = m_layerTreeHostImpl-rootLayer()-renderSurface();
-if (renderSurface)
-renderSurface-damageTracker()-forceFullDamageNextUpdate();
-
 // FIXME: Once we move render_widget scheduling into this class, we can
 // treat redraw requests more efficiently than commitAndRedraw requests.
 setNeedsCommit();


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp (106950 => 106951)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp	2012-02-07 16:28:17 UTC (rev 106950)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp	2012-02-07 16:43:23 UTC (rev 106951)
@@ -28,7 +28,6 @@
 
 #include GraphicsContext3D.h
 #include TraceEvent.h
-#include cc/CCDamageTracker.h
 #include cc/CCDelayBasedTimeSource.h
 #include cc/CCFrameRateController.h
 #include cc/CCInputHandler.h
@@ -249,7 +248,6 @@
 {
 ASSERT(isMainThread());
 TRACE_EVENT(CCThreadProxy::setNeedsRedraw, this, 0);
-CCProxy::implThread()-postTask(createCCThreadTask(this, CCThreadProxy::resetDamageTrackerOnImplThread));
 CCProxy::implThread()-postTask(createCCThreadTask(this,

[webkit-changes] [106952] trunk/LayoutTests

2012-02-07 Thread tonyg

Title: [106952] trunk/LayoutTests








Revision 106952
Author to...@chromium.org
Date 2012-02-07 08:55:19 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed, more svg rebaselines following change in r106918.

* platform/chromium-linux/svg/text/text-text-05-t-expected.png:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/svg/text/text-text-05-t-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (106951 => 106952)

--- trunk/LayoutTests/ChangeLog	2012-02-07 16:43:23 UTC (rev 106951)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 16:55:19 UTC (rev 106952)
@@ -1,3 +1,9 @@
+2012-02-07  Tony Gentilcore  to...@chromium.org
+
+Unreviewed, more svg rebaselines following change in r106918.
+
+* platform/chromium-linux/svg/text/text-text-05-t-expected.png:
+
 2012-02-07  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode


Modified: trunk/LayoutTests/platform/chromium-linux/svg/text/text-text-05-t-expected.png

(Binary files differ)





___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106955] trunk/LayoutTests

Title: [106955] trunk/LayoutTests








Revision 106955
Author commit-qu...@webkit.org
Date 2012-02-07 09:21:25 -0800 (Tue, 07 Feb 2012)


Log Message
[Chromium] Layout Test media/controls-drag-timebar.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=77531

No more flakiness.

Patch by Ami Fischman fisch...@chromium.org on 2012-02-07
Reviewed by Eric Carlson.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106954 => 106955)

--- trunk/LayoutTests/ChangeLog	2012-02-07 17:19:02 UTC (rev 106954)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 17:21:25 UTC (rev 106955)
@@ -1,3 +1,14 @@
+2012-02-07  Ami Fischman  fisch...@chromium.org
+
+[Chromium] Layout Test media/controls-drag-timebar.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=77531
+
+No more flakiness.
+
+Reviewed by Eric Carlson.
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-07  Csaba Osztrogonác  o...@webkit.org
 
 [Qt][WK2] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106954 => 106955)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 17:19:02 UTC (rev 106954)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 17:21:25 UTC (rev 106955)
@@ -3979,8 +3979,6 @@
 
 BUGWK77526 WIN LINUX : svg/text/text-align-04-b.svg = PASS IMAGE
 
-BUGWK77531 WIN LINUX : media/controls-drag-timebar.html = PASS TIMEOUT
-
 BUGWK77534 LINUX : plugins/createScriptableObject-before-start.html = PASS MISSING
 
 // Hitting ASSERT_NOT_REACHED in EventHandler::handleTouchEvent() as of r106554.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106956] trunk/Source/WebCore

2012-02-07 Thread dino

Title: [106956] trunk/Source/WebCore








Revision 106956
Author d...@apple.com
Date 2012-02-07 09:34:59 -0800 (Tue, 07 Feb 2012)


Log Message
Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922

Reviewed by Chris Marrin.

Follow Chrome's lead to allow WebGL antialiasing
on ATI cards as long as we're on 10.7.2 and above.

No new tests. Covered by existing tests.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::systemAllowsMultisamplingOnATICards):
(WebCore):
(WebCore::GraphicsContext3D::validateAttributes):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106955 => 106956)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 17:21:25 UTC (rev 106955)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 17:34:59 UTC (rev 106956)
@@ -1,3 +1,21 @@
+2012-02-07  Dean Jackson  d...@apple.com
+
+Apple/Safari: Enable WebGL multisampling on ATI cards
+for OS X 10.7.2 and above.
+https://bugs.webkit.org/show_bug.cgi?id=77922
+
+Reviewed by Chris Marrin.
+
+Follow Chrome's lead to allow WebGL antialiasing
+on ATI cards as long as we're on 10.7.2 and above.
+
+No new tests. Covered by existing tests.
+
+* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
+(WebCore::systemAllowsMultisamplingOnATICards):
+(WebCore):
+(WebCore::GraphicsContext3D::validateAttributes):
+
 2012-02-07  Pavel Feldman  pfeld...@google.com
 
 Web Inspector: add generic support for undo-ing DOM edits.


Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp (106955 => 106956)

--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp	2012-02-07 17:21:25 UTC (rev 106955)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp	2012-02-07 17:34:59 UTC (rev 106956)
@@ -60,6 +60,21 @@
 
 namespace WebCore {
 
+static bool systemAllowsMultisamplingOnATICards()
+{
+#if PLATFORM(MAC)
+static SInt32 version;
+if (!version) {
+if (Gestalt(gestaltSystemVersion, version) != noErr)
+return false;
+}
+// See https://bugs.webkit.org/show_bug.cgi?id=77922 for more details
+return version  0x1072;
+#else
+return false;
+#endif
+}
+
 void GraphicsContext3D::validateAttributes()
 {
 Extensions3D* extensions = getExtensions();
@@ -74,9 +89,10 @@
 }
 if (m_attrs.antialias) {
 bool isValidVendor = true;
-// Currently in Mac we only turn on antialias if vendor is NVIDIA.
+// Currently in Mac we only turn on antialias if vendor is NVIDIA,
+// or if ATI and on 10.7.2 and above.
 const char* vendor = reinterpret_castconst char*(::glGetString(GL_VENDOR));
-if (!std::strstr(vendor, NVIDIA))
+if (!std::strstr(vendor, NVIDIA)  !(std::strstr(vendor, ATI)  systemAllowsMultisamplingOnATICards()))
 isValidVendor = false;
 if (!isValidVendor || !extensions-supports(GL_ANGLE_framebuffer_multisample) || isGLES2Compliant())
 m_attrs.antialias = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106957] trunk/Source/WebCore

2012-02-07 Thread vsevik

Title: [106957] trunk/Source/WebCore








Revision 106957
Author vse...@chromium.org
Date 2012-02-07 09:38:00 -0800 (Tue, 07 Feb 2012)


Log Message
Web Inspector: CodeGeneratorInspector.py: extend Array validator functionality
https://bugs.webkit.org/show_bug.cgi?id=77919

Patch by Peter Rybin peter.ry...@gmail.com on 2012-02-07
Patch by Peter Rybin peter.ry...@gmail.com on 2012-02-07
Reviewed by Yury Semikhatsky.

Array validator method runtimeCast is added, internal backing method
is moved from .cpp to .h (it's template anyway), boolean validator is
supported.

* inspector/CodeGeneratorInspector.py:
(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
(RawTypes.Bool.get_validate_method_params):
(TypeBuilder):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/CodeGeneratorInspector.py




Diff

Modified: trunk/Source/WebCore/ChangeLog (106956 => 106957)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 17:34:59 UTC (rev 106956)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 17:38:00 UTC (rev 106957)
@@ -1,3 +1,20 @@
+2012-02-07  Peter Rybin  peter.ry...@gmail.com
+
+Web Inspector: CodeGeneratorInspector.py: extend Array validator functionality
+https://bugs.webkit.org/show_bug.cgi?id=77919
+
+Patch by Peter Rybin peter.ry...@gmail.com on 2012-02-07
+Reviewed by Yury Semikhatsky.
+
+Array validator method runtimeCast is added, internal backing method
+is moved from .cpp to .h (it's template anyway), boolean validator is
+supported.
+
+* inspector/CodeGeneratorInspector.py:
+(RawTypes.Bool.get_validate_method_params.ValidateMethodParams):
+(RawTypes.Bool.get_validate_method_params):
+(TypeBuilder):
+
 2012-02-07  Dean Jackson  d...@apple.com
 
 Apple/Safari: Enable WebGL multisampling on ATI cards


Modified: trunk/Source/WebCore/inspector/CodeGeneratorInspector.py (106956 => 106957)

--- trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-02-07 17:34:59 UTC (rev 106956)
+++ trunk/Source/WebCore/inspector/CodeGeneratorInspector.py	2012-02-07 17:38:00 UTC (rev 106957)
@@ -422,7 +422,11 @@
 
 @staticmethod
 def get_validate_method_params():
-raise Exception(TODO)
+class ValidateMethodParams:
+name = Boolean
+var_type = bool
+as_method_name = Boolean
+return ValidateMethodParams
 
 @staticmethod
 def get_output_pass_model():
@@ -1122,7 +1126,7 @@
 }
  % class_name)
 
-writer.newline(typedef StructItemTraits ItemTraits;\n)
+writer.newline(typedef TypeBuilder::StructItemTraits ItemTraits;\n)
 
 for prop_data in resolve_data.optional_properties:
 prop_name = prop_data.p[name]
@@ -1167,22 +1171,29 @@
 validator_writer.newline(RefPtrInspectorObject object;\n)
 validator_writer.newline(bool castRes = value-asObject(object);\n)
 validator_writer.newline(ASSERT_UNUSED(castRes, castRes);\n)
-validator_writer.newline(InspectorObject::iterator it;\n)
 for prop_data in resolve_data.main_properties:
-validator_writer.newline(it = object-find(\%s\);\n % prop_data.p[name])
-validator_writer.newline(ASSERT(it != object-end());\n)
-validator_writer.newline(%s(it-second.get());\n % prop_data.param_type_binding.get_validator_call_text())
+validator_writer.newline({\n)
+it_name = %sPos % prop_data.p[name]
+validator_writer.newline(InspectorObject::iterator %s;\n % it_name)
+validator_writer.newline(%s = object-find(\%s\);\n % (it_name, prop_data.p[name]))
+validator_writer.newline(ASSERT(%s != object-end());\n % it_name)
+validator_writer.newline(%s(%s-second.get());\n % (prop_data.param_type_binding.get_validator_call_text(), it_name))
+validator_writer.newline(}\n)
 
-validator_writer.newline(int count = %s;\n % len(resolve_data.main_properties))
+validator_writer.newline(int foundPropertiesCount = %s;\n % len(resolve_data.main_properties))
 
 for prop_data in resolve_data.optional_properties:
-validator_writer.newline(it =

[webkit-changes] [106958] trunk/LayoutTests

Title: [106958] trunk/LayoutTests








Revision 106958
Author jchaffr...@webkit.org
Date 2012-02-07 09:45:05 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
Mark an SVG test as SLOW.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106957 => 106958)

--- trunk/LayoutTests/ChangeLog	2012-02-07 17:38:00 UTC (rev 106957)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 17:45:05 UTC (rev 106958)
@@ -1,3 +1,10 @@
+2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+* platform/chromium/test_expectations.txt:
+Mark an SVG test as SLOW.
+
 2012-02-07  Ami Fischman  fisch...@chromium.org
 
 [Chromium] Layout Test media/controls-drag-timebar.html is flaky


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106957 => 106958)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 17:38:00 UTC (rev 106957)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 17:45:05 UTC (rev 106958)
@@ -52,6 +52,8 @@
 BUGWK76270 SKIP : http/tests/appcache/abort-cache-ondownloading-manifest-404.html = FAIL
 BUGWK76270 SKIP : http/tests/appcache/abort-cache-ondownloading-resource-404.html = FAIL
 BUGWK76270 SKIP : http/tests/appcache/abort-cache-onprogress.html = FAIL
+// The test needs a rebaseline after BUGWK77736.
+BUGWK77997 DEBUG SLOW : svg/as-object/nested-embedded-svg-size-changes.html = IMAGE
 
 // -
 // TEMPORARILY SKIPPED TESTS
@@ -4002,7 +4004,7 @@
 BUGWK77736 : svg/as-object/embedded-svg-size-changes.html = IMAGE
 BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html = IMAGE+TEXT
 BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html = IMAGE+TEXT
-BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes.html = IMAGE
+BUGWK77736 RELEASE : svg/as-object/nested-embedded-svg-size-changes.html = IMAGE
 BUGWK77736 : svg/carto.net/tabgroup.svg = IMAGE+TEXT
 BUGWK77736 MAC LINUX: svg/carto.net/window.svg = IMAGE+TEXT
 BUGWK77736 MAC LINUX : svg/css/shadow-changes.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106960] trunk

2012-02-07 Thread rniwa

Title: [106960] trunk








Revision 106960
Author rn...@webkit.org
Date 2012-02-07 10:54:24 -0800 (Tue, 07 Feb 2012)


Log Message
Dashboard on perf-o-matic should be sorted
https://bugs.webkit.org/show_bug.cgi?id=77924

Reviewed by Tony Chang.

Sort tests in the frontend using the fact ES5 keeps the property order in the insertion order.

* Websites/webkit-perf.appspot.com/js/config.js:
(fetchDashboardManifest):

Modified Paths

trunk/ChangeLog
trunk/Websites/webkit-perf.appspot.com/js/config.js




Diff

Modified: trunk/ChangeLog (106959 => 106960)

--- trunk/ChangeLog	2012-02-07 18:49:10 UTC (rev 106959)
+++ trunk/ChangeLog	2012-02-07 18:54:24 UTC (rev 106960)
@@ -1,3 +1,15 @@
+2012-02-07  Ryosuke Niwa  rn...@webkit.org
+
+Dashboard on perf-o-matic should be sorted
+https://bugs.webkit.org/show_bug.cgi?id=77924
+
+Reviewed by Tony Chang.
+
+Sort tests in the frontend using the fact ES5 keeps the property order in the insertion order.
+
+* Websites/webkit-perf.appspot.com/js/config.js:
+(fetchDashboardManifest):
+
 2012-02-07  Frederik Gladhorn  frederik.gladh...@nokia.com
 
 Update .gitignore for Qt Creator/KDevelop.


Modified: trunk/Websites/webkit-perf.appspot.com/js/config.js (106959 => 106960)

--- trunk/Websites/webkit-perf.appspot.com/js/config.js	2012-02-07 18:49:10 UTC (rev 106959)
+++ trunk/Websites/webkit-perf.appspot.com/js/config.js	2012-02-07 18:54:24 UTC (rev 106960)
@@ -76,5 +76,13 @@
 cache: true,
 });
 
-$.getJSON(SERVER + '/api/test/dashboard', callback);
+$.getJSON(SERVER + '/api/test/dashboard', function (dashboardManifest) {
+var testToId = dashboardManifest['testToId'];
+var tests = Object.keys(testToId).sort();
+var sortedTestToId = {};
+for (var i = 0; i  tests.length; i++)
+sortedTestToId[tests[i]] = testToId[tests[i]];
+dashboardManifest['testToId'] = sortedTestToId;
+callback(dashboardManifest);
+});
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106961] trunk/Source/WebKit2

2012-02-07 Thread carlosgc

Title: [106961] trunk/Source/WebKit2








Revision 106961
Author carlo...@webkit.org
Date 2012-02-07 10:57:10 -0800 (Tue, 07 Feb 2012)


Log Message
[GTK] Add cut, copy and paste methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=76998

Reviewed by Martin Robinson.

* GNUmakefile.am: Add WebKitEditingCommands.h.
* UIProcess/API/gtk/WebKitEditingCommands.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(didValidateCommand): Callback called by the C API when an editor
command has been validated.
(webkit_web_view_can_execute_editing_command): Asynchronously
validate the given editing command.
(webkit_web_view_can_execute_editing_command_finish): Finish async
operation started by webkit_web_view_can_execute_editing_command().
(webkit_web_view_execute_editing_command): Execute the given
command.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(LoadTrackingTest::provisionalLoadFailed): Do not finish the main
loop on load failure, now finished is always called.
* UIProcess/API/gtk/tests/TestBackForwardList.cpp: Use WebViewTest
instead of LoadTrackingTest.
* UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Added.
(testWebViewEditorCutCopyPasteNonEditable):
(testWebViewEditorCutCopyPasteEditable):
(beforeAll):
(afterAll):
* UIProcess/API/gtk/tests/WebViewTest.cpp:
(loadChanged):
(WebViewTest::waitUntilLoadFinished): Run a main loop until load
finished.
* UIProcess/API/gtk/tests/WebViewTest.h: Add waitUntilLoadFinished().
* UIProcess/API/gtk/webkit2.h: Include WebKitEditingCommands.h.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt
trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h
trunk/Source/WebKit2/UIProcess/API/gtk/webkit2.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (106960 => 106961)

--- trunk/Source/WebKit2/ChangeLog	2012-02-07 18:54:24 UTC (rev 106960)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-07 18:57:10 UTC (rev 106961)
@@ -1,3 +1,41 @@
+2012-02-07  Carlos Garcia Campos  cgar...@igalia.com
+
+[GTK] Add cut, copy and paste methods to WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=76998
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: Add WebKitEditingCommands.h.
+* UIProcess/API/gtk/WebKitEditingCommands.h: Added.
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(didValidateCommand): Callback called by the C API when an editor
+command has been validated.
+(webkit_web_view_can_execute_editing_command): Asynchronously
+validate the given editing command.
+(webkit_web_view_can_execute_editing_command_finish): Finish async
+operation started by webkit_web_view_can_execute_editing_command().
+(webkit_web_view_execute_editing_command): Execute the given
+command.
+* UIProcess/API/gtk/WebKitWebView.h:
+* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
+* UIProcess/API/gtk/tests/GNUmakefile.am:
+* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
+(LoadTrackingTest::provisionalLoadFailed): Do not finish the main
+loop on load failure, now finished is always called.
+* UIProcess/API/gtk/tests/TestBackForwardList.cpp: Use WebViewTest
+instead of LoadTrackingTest.
+* UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Added.
+(testWebViewEditorCutCopyPasteNonEditable):
+(testWebViewEditorCutCopyPasteEditable):
+(beforeAll):
+(afterAll):
+* UIProcess/API/gtk/tests/WebViewTest.cpp:
+(loadChanged):
+(WebViewTest::waitUntilLoadFinished): Run a main loop until load
+finished.
+* UIProcess/API/gtk/tests/WebViewTest.h: Add waitUntilLoadFinished().
+* UIProcess/API/gtk/webkit2.h: Include WebKitEditingCommands.h.
+
 2012-02-07  Allan Sandfeld Jensen  allan.jen...@nokia.com
 
 Encode radius, force and rotationAngle in WebPlatformTouchPoint.


Modified: trunk/Source/WebKit2/GNUmakefile.am (106960 => 106961)

--- trunk/Source/WebKit2/GNUmakefile.am	2012-02-07 18:54:24 UTC (rev 106960)
+++ trunk/Source/WebKit2/GNUmakefile.am	2012-02-07 18:57:10 UTC (rev 106961)
@@ -86,6 +86,7 @@
 	$(WebKit2)/UIProcess/API/gtk/WebKitBackForwardListItem.h \

[webkit-changes] [106963] trunk/LayoutTests

2012-02-07 Thread mikelawther

Title: [106963] trunk/LayoutTests








Revision 106963
Author mikelawt...@chromium.org
Date 2012-02-07 11:18:19 -0800 (Tue, 07 Feb 2012)


Log Message
composited mask test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=76006

Reviewed by Ojan Vafai.

Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)

These tests are expected to 'fail', and will pass once calc() functionality is landed.
For now, they serve to demonstrate that the current code doesn't crash on these tests.

* css3/calc/resources/alpha-gradient.png: Added.
* css3/calc/simple-composited-mask-expected-mismatch.html: Added.
* css3/calc/simple-composited-mask.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/css3/calc/resources/alpha-gradient.png
trunk/LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html
trunk/LayoutTests/css3/calc/simple-composited-mask.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106962 => 106963)

--- trunk/LayoutTests/ChangeLog	2012-02-07 19:03:21 UTC (rev 106962)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 19:18:19 UTC (rev 106963)
@@ -1,3 +1,19 @@
+2012-02-07  Mike Lawther  mikelawt...@chromium.org
+
+composited mask test for CSS3 calc
+https://bugs.webkit.org/show_bug.cgi?id=76006
+
+Reviewed by Ojan Vafai.
+
+Tests for future implementation of CSS3 calc() (see http://webkit.org/b/16662)
+
+These tests are expected to 'fail', and will pass once calc() functionality is landed.
+For now, they serve to demonstrate that the current code doesn't crash on these tests.
+
+* css3/calc/resources/alpha-gradient.png: Added.
+* css3/calc/simple-composited-mask-expected-mismatch.html: Added.
+* css3/calc/simple-composited-mask.html: Added.
+
 2012-02-07  Ami Fischman  fisch...@chromium.org
 
 [Chromium] media/track/track-cue-nothing-to-render.html fails intermittently on Mac


Added: trunk/LayoutTests/css3/calc/resources/alpha-gradient.png (0 => 106963)

--- trunk/LayoutTests/css3/calc/resources/alpha-gradient.png	(rev 0)
+++ trunk/LayoutTests/css3/calc/resources/alpha-gradient.png	2012-02-07 19:18:19 UTC (rev 106963)
@@ -0,0 +1,11 @@
+\x89PNG
+
+
+IHDR\xC8\xC8QfgAMA\xD6\xD8\xD4OX2tEXtSoftwareAdobe ImageReadyq\xC9enIDATx\xDA\xED\xD6\xC1\xC0 \xC4@\xE8\xBFdB\xE4LfU\xCEx\x85\x84Ԣy\x85\x80B\xE0Q!\x84WB!\x84B! \x84r\xBF\x90\xE9B!\x84\x80g/B\x81?D! \xC4dA!\x84\xC0d)\x84\xC0d)\x84\x98,(D!P!0YP\x88B\xA0\x85@!
+\x81B\x85@!\x84\xC0d)
+Q\xA2\x93\xA5(D! \xC4dA!
+\x81B@\x88ɂB\x81\xC9R1YP1YP!0Y
+\x81BB`\xB2BLBL\x96B@!K! \xC4dA!\x84\xC0d)
+Q\x81\xC9R\xA2b\xB2\xA0\x85@!P\x88B@\x88ɂB\x85(
+\x81B\x85(
+!K!PBL\x96B@\x88ɂB\x81ɂB\x81\xC9R!\xFE\x85\x80B!\xCE^\x85\x80B@!\x84B!\x84\xE0\xCD(\x84B\x81+\xEB\xFF\xF4H\x8F@^\x84\xC0\x82=\xE9\xC8R!\x84B\xC1\xC7,\xED\xFE\xBA\xBBm\xBCOIEND\xAEB`\x82
\ No newline at end of file


Added: trunk/LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html (0 => 106963)

--- trunk/LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html	(rev 0)
+++ trunk/LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html	2012-02-07 19:18:19 UTC (rev 106963)
@@ -0,0 +1,31 @@
+!DOCTYPE html
+style
+#container {
+height: 760px;
+width: 260px;
+border: solid black;
+display: inline-block;
+}
+.box {
+position: relative;
+width: 200px;
+height: 200px;
+margin: 30px;
+border: 10px solid black;
+background-color: rgba(100, 100, 255, 0.8);
+-webkit-box-sizing: border-box;
+-webkit-box-shadow: black 0 4px 4px;
+}
+
+#container .masked {
+-webkit-mask-image: url(resources/alpha-gradient.png);
+-webkit-mask-repeat: repeat;
+-webkit-mask-size: 50px;
+}
+/style
+pTesting masks on compositing layers./p
+div id=container
+div class=masked box/div
+div class=masked box/div
+div class=masked box/div
+/div


Added: trunk/LayoutTests/css3/calc/simple-composited-mask.html (0 => 106963)

--- trunk/LayoutTests/css3/calc/simple-composited-mask.html	(rev 0)
+++ trunk/LayoutTests/css3/calc/simple-composited-mask.html	2012-02-07 19:18:19 UTC (rev 106963)
@@ -0,0 +1,43 @@
+!DOCTYPE html
+style
+#container {
+height: 760px;
+width: 260px;
+border: solid black;
+display: inline-block;
+}
+.box {
+position: relative;
+width: 200px;
+height: 200px;
+margin: 30px;
+border: 10px solid black;
+background-color: rgba(100, 100, 255, 0.8);
+-webkit-box-sizing: border-box;
+-webkit-box-shadow: black 0 4px 4px;
+}
+
+#container .masked-px {
+-webkit-mask-image:

[webkit-changes] [106964] trunk/Source/WebCore

2012-02-07 Thread dino

Title: [106964] trunk/Source/WebCore








Revision 106964
Author d...@apple.com
Date 2012-02-07 11:18:47 -0800 (Tue, 07 Feb 2012)


Log Message
Apple/Safari: Enable WebGL multisampling on ATI cards
for OS X 10.7.2 and above.
https://bugs.webkit.org/show_bug.cgi?id=77922

Address review comments by Alexey Proskuryakov and Mark Rowe.

* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::systemAllowsMultisamplingOnATICards):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106963 => 106964)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 19:18:19 UTC (rev 106963)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 19:18:47 UTC (rev 106964)
@@ -21,6 +21,17 @@
 for OS X 10.7.2 and above.
 https://bugs.webkit.org/show_bug.cgi?id=77922
 
+Address review comments by Alexey Proskuryakov and Mark Rowe.
+
+* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
+(WebCore::systemAllowsMultisamplingOnATICards):
+
+2012-02-07  Dean Jackson  d...@apple.com
+
+Apple/Safari: Enable WebGL multisampling on ATI cards
+for OS X 10.7.2 and above.
+https://bugs.webkit.org/show_bug.cgi?id=77922
+
 Reviewed by Chris Marrin.
 
 Follow Chrome's lead to allow WebGL antialiasing


Modified: trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp (106963 => 106964)

--- trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp	2012-02-07 19:18:19 UTC (rev 106963)
+++ trunk/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp	2012-02-07 19:18:47 UTC (rev 106964)
@@ -63,16 +63,21 @@
 static bool systemAllowsMultisamplingOnATICards()
 {
 #if PLATFORM(MAC)
+#if !defined(BUILDING_ON_SNOW_LEOPARD)  !defined(BUILDING_ON_LION)
+return true;
+#else
+ASSERT(isMainThread());
 static SInt32 version;
 if (!version) {
 if (Gestalt(gestaltSystemVersion, version) != noErr)
 return false;
 }
 // See https://bugs.webkit.org/show_bug.cgi?id=77922 for more details
-return version  0x1072;
+return version = 0x1072;
+#endif // SNOW_LEOPARD and LION
 #else
 return false;
-#endif
+#endif // PLATFORM(MAC)
 }
 
 void GraphicsContext3D::validateAttributes()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106965] trunk

2012-02-07 Thread hans

Title: [106965] trunk








Revision 106965
Author h...@chromium.org
Date 2012-02-07 11:26:26 -0800 (Tue, 07 Feb 2012)


Log Message
Chromium: remove WebSpeechInputResult::set
https://bugs.webkit.org/show_bug.cgi?id=77977

Reviewed by Darin Fisher.

It was renamed to assign() in r106475.

Source/WebKit/chromium:

* public/WebSpeechInputResult.h:

Tools:

* DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
(makeRectResult):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSpeechInputResult.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (106964 => 106965)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-07 19:18:47 UTC (rev 106964)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-07 19:26:26 UTC (rev 106965)
@@ -1,3 +1,14 @@
+2012-02-07  Hans Wennborg  h...@chromium.org
+
+Chromium: remove WebSpeechInputResult::set
+https://bugs.webkit.org/show_bug.cgi?id=77977
+
+Reviewed by Darin Fisher.
+
+It was renamed to assign() in r106475.
+
+* public/WebSpeechInputResult.h:
+
 2012-02-07  Sheriff Bot  webkit.review@gmail.com
 
 Unreviewed, rolling out r106935.


Modified: trunk/Source/WebKit/chromium/public/WebSpeechInputResult.h (106964 => 106965)

--- trunk/Source/WebKit/chromium/public/WebSpeechInputResult.h	2012-02-07 19:18:47 UTC (rev 106964)
+++ trunk/Source/WebKit/chromium/public/WebSpeechInputResult.h	2012-02-07 19:26:26 UTC (rev 106965)
@@ -45,9 +45,6 @@
 WebSpeechInputResult(const WebSpeechInputResult other) { assign(other); }
 ~WebSpeechInputResult() { reset(); }
 
-// FIXME: Remove this when Chromium has been updated.
-void set(const WebString utterance, double confidence) { assign(utterance, confidence); }
-
 WEBKIT_EXPORT void assign(const WebString utterance, double confidence);
 WEBKIT_EXPORT void assign(const WebSpeechInputResult other);
 WEBKIT_EXPORT void reset();


Modified: trunk/Tools/ChangeLog (106964 => 106965)

--- trunk/Tools/ChangeLog	2012-02-07 19:18:47 UTC (rev 106964)
+++ trunk/Tools/ChangeLog	2012-02-07 19:26:26 UTC (rev 106965)
@@ -1,3 +1,15 @@
+2012-02-07  Hans Wennborg  h...@chromium.org
+
+Chromium: remove WebSpeechInputResult::set
+https://bugs.webkit.org/show_bug.cgi?id=77977
+
+Reviewed by Darin Fisher.
+
+It was renamed to assign() in r106475.
+
+* DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
+(makeRectResult):
+
 2012-02-07  Allan Sandfeld Jensen  allan.jen...@nokia.com
 
 [Qt] Give emulated touch-point a radius


Modified: trunk/Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp (106964 => 106965)

--- trunk/Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp	2012-02-07 19:18:47 UTC (rev 106964)
+++ trunk/Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp	2012-02-07 19:26:26 UTC (rev 106965)
@@ -124,7 +124,7 @@
 sb.append(String::number(rect.height));
 
 WebSpeechInputResult res;
-res.set(WebString(sb.characters(), sb.length()), 1.0);
+res.assign(WebString(sb.characters(), sb.length()), 1.0);
 
 WebSpeechInputResultArray results;
 results.assign(res, 1);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106966] trunk/LayoutTests

Title: [106966] trunk/LayoutTests








Revision 106966
Author commit-qu...@webkit.org
Date 2012-02-07 11:30:40 -0800 (Tue, 07 Feb 2012)


Log Message
[chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac
https://bugs.webkit.org/show_bug.cgi?id=77896

Patch by Dana Jansens dan...@chromium.org on 2012-02-07
Reviewed by Kenneth Russell.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106965 => 106966)

--- trunk/LayoutTests/ChangeLog	2012-02-07 19:26:26 UTC (rev 106965)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 19:30:40 UTC (rev 106966)
@@ -1,3 +1,12 @@
+2012-02-07  Dana Jansens  dan...@chromium.org
+
+[chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac
+https://bugs.webkit.org/show_bug.cgi?id=77896
+
+Reviewed by Kenneth Russell.
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-07  Mike Lawther  mikelawt...@chromium.org
 
 composited mask test for CSS3 calc


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106965 => 106966)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 19:26:26 UTC (rev 106965)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 19:30:40 UTC (rev 106966)
@@ -3937,9 +3937,6 @@
 BUG_CARYCLARK MAC : editing/style/create-block-for-style-013.html = IMAGE
 BUG_CARYCLARK MAC : fast/dom/blur-contenteditable.html = IMAGE
 
-// May fail if these platforms differ from Linux. Remove this or rebaseline them once the bug lands.
-BUGWK76015 WIN MAC : fast/repaint/block-selection-gap-in-composited-layer.html = IMAGE
-
 // Need to implement file name logging.
 BUGWK76572 : http/tests/download = FAIL
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106967] trunk/LayoutTests

Title: [106967] trunk/LayoutTests








Revision 106967
Author jchaffr...@webkit.org
Date 2012-02-07 11:34:29 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed gardening.

* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
* platform/chromium/test_expectations.txt: Added a TEXT output to a test as seen
on the bots.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Removed Paths

trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106966 => 106967)

--- trunk/LayoutTests/ChangeLog	2012-02-07 19:30:40 UTC (rev 106966)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 19:34:29 UTC (rev 106967)
@@ -1,3 +1,11 @@
+2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt: Removed.
+* platform/chromium/test_expectations.txt: Added a TEXT output to a test as seen
+on the bots.
+
 2012-02-07  Dana Jansens  dan...@chromium.org
 
 [chromium] re-enable fast/repaint/block-selection-gap-in-composited-layer for win/mac


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106966 => 106967)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 19:30:40 UTC (rev 106966)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 19:34:29 UTC (rev 106967)
@@ -3792,7 +3792,7 @@
 BUGWK65711 : svg/custom/js-late-gradient-and-object-creation.svg = IMAGE+TEXT IMAGE
 BUGWK65711 : svg/custom/js-late-pattern-and-object-creation.svg = IMAGE+TEXT IMAGE
 
-BUGWK76727 : fast/multicol/span/span-as-immediate-child-property-removal.html = IMAGE+TEXT
+BUGWK76727 : fast/multicol/span/span-as-immediate-child-property-removal.html = IMAGE+TEXT TEXT
 BUGWK76727 : fast/multicol/span/span-as-immediate-columns-child-removal.html = IMAGE+TEXT
 
 // Text layout should have changed, kerning should look more natural. We previously didn't relayout


Deleted: trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt (106966 => 106967)

--- trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt	2012-02-07 19:30:40 UTC (rev 106966)
+++ trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/carto.net/window-expected.txt	2012-02-07 19:34:29 UTC (rev 106967)
@@ -1,278 +0,0 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderSVGRoot {svg} at (0,0) size 800x600
-RenderSVGHiddenContainer {defs} at (0,0) size 0x0
-RenderSVGRect {rect} at (0,0) size 800x600 [fill={[type=SOLID] [color=#D3D3D3]}] [x=-5000.00] [y=-5000.00] [width=15000.00] [height=15000.00]
-RenderSVGRect {rect} at (0,26) size 800x64 [fill={[type=SOLID] [color=#FF]}] [x=-5000.00] [y=0.00] [width=15000.00] [height=80.00]
-RenderSVGRect {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF]}] [x=-5000.00] [y=-5000.00] [width=5000.00] [height=15000.00]
-RenderSVGRect {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FF]}] [x=1024.00] [y=-5000.00] [width=5000.00] [height=15000.00]
-RenderSVGRect {rect} at (0,573) size 800x27 [fill={[type=SOLID] [color=#FF]}] [x=-5000.00] [y=700.00] [width=15000.00] [height=5000.00]
-RenderSVGText {text} at (10,11) size 328x23 contains 1 chunk(s)
-  RenderSVGInlineText {#text} at (0,0) size 328x23
-chunk 1 text run 1 at (10.00,30.00) startOffset 0 endOffset 34 width 327.68: Demonstration of the Window object
-RenderSVGText {text} at (10,37) size 63x16 contains 1 chunk(s)
-  RenderSVGInlineText {#text} at (0,0) size 63x16
-chunk 1 text run 1 at (10.00,50.00) startOffset 0 endOffset 10 width 62.72: Statustext
-RenderSVGContainer {use} at (319,33) size 112x18
-  RenderSVGContainer {g} at (319,33) size 112x18 [transform={m=((1.00,0.00)(0.00,1.00)) t=(480.00,20.00)}]
-RenderSVGViewportContainer {svg} at (319,33) size 112x18
-  RenderSVGRect {rect} at (319,33) size 112x18 [stroke={[type=SOLID] [color=#696969]}] [fill={[type=SOLID] [color=#DCDCDC]}] [x=-70.00] [y=-10.00] [width=140.00] [height=20.00]
-RenderSVGText {text} at (414,14) size 132x13 contains 1 chunk(s)
-  RenderSVGInlineText {#text} at (0,0) size 132x13
-chunk 1 (middle anchor) text run 1 at (414.08,25.00) startOffset 0 endOffset 23 width 131.84: Close Navigation Window
-RenderSVGContainer {use} at (437,33) size 111x18
-  RenderSVGContainer {g} at (437,33) size 111x18 [transform={m=((1.00,0.00)(0.00,1.00)) t=(630.00,20.00)}]
-RenderSVGViewportContainer {svg} at (437,33) size 111x18
-  RenderSVGRect {rect} at (437,33) size 111x18 [stroke={[type=SOLID] [color=#696969]}] [fill={[type=SOLID] [color=#DCDCDC]}] [x=-70.00] [y=-10.00] [width=140.00] [height=20.00]
-RenderSVGText {text} at (583,14) size 94x13 contains 1 chunk(s)
-

[webkit-changes] [106971] trunk/LayoutTests

2012-02-07 Thread jsbell

Title: [106971] trunk/LayoutTests








Revision 106971
Author jsb...@chromium.org
Date 2012-02-07 11:59:12 -0800 (Tue, 07 Feb 2012)


Log Message
[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
https://bugs.webkit.org/show_bug.cgi?id=65862

Unreviewed test expectations change. Removed this expectation in r106857
but it's still timing out so restoring it for now.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106970 => 106971)

--- trunk/LayoutTests/ChangeLog	2012-02-07 19:50:09 UTC (rev 106970)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 19:59:12 UTC (rev 106971)
@@ -1,3 +1,13 @@
+2012-02-07  Joshua Bell  jsb...@chromium.org
+
+[Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug
+https://bugs.webkit.org/show_bug.cgi?id=65862
+
+Unreviewed test expectations change. Removed this expectation in r106857
+but it's still timing out so restoring it for now.
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-07  Abhishek Arya  infe...@chromium.org
 
 Crash due to column style not updated on post block


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106970 => 106971)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 19:50:09 UTC (rev 106970)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 19:59:12 UTC (rev 106971)
@@ -3272,6 +3272,8 @@
 // Introduced in r92298, which might cause another test crashing.
 BUGZMO SKIP : fast/loader/reload-zero-byte-plugin.html = FAIL
 
+BUGWK65862 MAC DEBUG SLOW : storage/indexeddb/index-cursor.html = PASS
+
 // Performance issues with border radius clipping on Chromium not yet resolved
 BUGCR97716 : fast/clip/overflow-border-radius-composited.html = IMAGE
 // Consistently failing as of about r95590






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106972] trunk

2012-02-07 Thread inferno

Title: [106972] trunk








Revision 106972
Author infe...@chromium.org
Date 2012-02-07 12:01:42 -0800 (Tue, 07 Feb 2012)


Log Message
Crash in ContainerNode functions due to mutation events.
https://bugs.webkit.org/show_bug.cgi?id=77999

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add RefPtr to protect premature deletion of this due to mutation events.

Tests: fast/dom/remove-body-during-body-replacement.html
   fast/dom/remove-body-during-body-replacement2.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::appendChild):

LayoutTests:

* fast/dom/remove-body-during-body-replacement-expected.txt: Added.
* fast/dom/remove-body-during-body-replacement.html: Added.
* fast/dom/remove-body-during-body-replacement2-expected.txt: Added.
* fast/dom/remove-body-during-body-replacement2.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp


Added Paths

trunk/LayoutTests/fast/dom/remove-body-during-body-replacement-expected.txt
trunk/LayoutTests/fast/dom/remove-body-during-body-replacement.html
trunk/LayoutTests/fast/dom/remove-body-during-body-replacement2-expected.txt
trunk/LayoutTests/fast/dom/remove-body-during-body-replacement2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106971 => 106972)

--- trunk/LayoutTests/ChangeLog	2012-02-07 19:59:12 UTC (rev 106971)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 20:01:42 UTC (rev 106972)
@@ -1,3 +1,15 @@
+2012-02-07  Abhishek Arya  infe...@chromium.org
+
+Crash in ContainerNode functions due to mutation events.
+https://bugs.webkit.org/show_bug.cgi?id=77999
+
+Reviewed by Ryosuke Niwa.
+
+* fast/dom/remove-body-during-body-replacement-expected.txt: Added.
+* fast/dom/remove-body-during-body-replacement.html: Added.
+* fast/dom/remove-body-during-body-replacement2-expected.txt: Added.
+* fast/dom/remove-body-during-body-replacement2.html: Added.
+
 2012-02-07  Joshua Bell  jsb...@chromium.org
 
 [Chromium] storage/indexeddb/index-cursor.html timeouts on Mac Debug


Added: trunk/LayoutTests/fast/dom/remove-body-during-body-replacement-expected.txt (0 => 106972)

--- trunk/LayoutTests/fast/dom/remove-body-during-body-replacement-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/remove-body-during-body-replacement-expected.txt	2012-02-07 20:01:42 UTC (rev 106972)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.


Added: trunk/LayoutTests/fast/dom/remove-body-during-body-replacement.html (0 => 106972)

--- trunk/LayoutTests/fast/dom/remove-body-during-body-replacement.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/remove-body-during-body-replacement.html	2012-02-07 20:01:42 UTC (rev 106972)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+bodydivscript
+
+if (!window.layoutTestController)
+document.write(This test requires GCController.);
+else {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+
+function crash() {
+document.open();
+document.write(PASS. WebKit didn't crash.);
+document.close();
+GCController.collect();
+setTimeout(layoutTestController.notifyDone(), 0);
+}
+
+setTimeout(function () {
+document.addEventListener('DOMNodeInsertedIntoDocument', function () { crash(); }, true);
+document.addEventListener('DOMSubtreeModified', function () { /* noop */ }, false);
+document.body = document.createElement('body');
+}, 0);
+}
+
+/script
+/body
+/html


Added: trunk/LayoutTests/fast/dom/remove-body-during-body-replacement2-expected.txt (0 => 106972)

--- trunk/LayoutTests/fast/dom/remove-body-during-body-replacement2-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/remove-body-during-body-replacement2-expected.txt	2012-02-07 20:01:42 UTC (rev 106972)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.


Added: trunk/LayoutTests/fast/dom/remove-body-during-body-replacement2.html (0 => 106972)

--- trunk/LayoutTests/fast/dom/remove-body-during-body-replacement2.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/remove-body-during-body-replacement2.html	2012-02-07 20:01:42 UTC (rev 106972)
@@ -0,0 +1,30 @@
+!DOCTYPE html
+html
+bodydivscript
+
+if (!window.layoutTestController)
+document.write(This test requires GCController.);
+else {
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+
+function crash() {
+document.open();
+document.write(PASS. WebKit didn't crash.);
+document.close();
+GCController.collect();
+setTimeout(layoutTestController.notifyDone(), 0);
+}
+
+setTimeout(function () {
+document.addEventListener('DOMFocusOut', function () { crash(); }, true);
+document.addEventListener('DOMSubtreeModified',

[webkit-changes] [106973] trunk/Source/WebCore

2012-02-07 Thread mdelaney

Title: [106973] trunk/Source/WebCore








Revision 106973
Author mdela...@apple.com
Date 2012-02-07 12:04:23 -0800 (Tue, 07 Feb 2012)


Log Message
Remove redundant checks in CanvasRenderingContext2D.cpp
https://bugs.webkit.org/show_bug.cgi?id=78000

Reviewed by Dan Bernstein.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setShadowColor):
(WebCore::CanvasRenderingContext2D::setShadow):
(WebCore::CanvasRenderingContext2D::drawImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106972 => 106973)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 20:01:42 UTC (rev 106972)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 20:04:23 UTC (rev 106973)
@@ -1,3 +1,15 @@
+2012-02-07  Matthew Delaney  mdela...@apple.com
+
+Remove redundant checks in CanvasRenderingContext2D.cpp
+https://bugs.webkit.org/show_bug.cgi?id=78000
+
+Reviewed by Dan Bernstein.
+
+* html/canvas/CanvasRenderingContext2D.cpp:
+(WebCore::CanvasRenderingContext2D::setShadowColor):
+(WebCore::CanvasRenderingContext2D::setShadow):
+(WebCore::CanvasRenderingContext2D::drawImage):
+
 2012-02-07  Abhishek Arya  infe...@chromium.org
 
 Crash in ContainerNode functions due to mutation events.


Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp (106972 => 106973)

--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp	2012-02-07 20:01:42 UTC (rev 106972)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp	2012-02-07 20:04:23 UTC (rev 106973)
@@ -496,7 +496,6 @@
 {
 if (!parseColorOrCurrentColor(state().m_shadowColor, color, canvas()))
 return;
-
 applyShadow();
 }
 
@@ -1145,11 +1144,6 @@
 state().m_shadowOffset = FloatSize(width, height);
 state().m_shadowBlur = blur;
 state().m_shadowColor = makeRGBA32FromFloats(grayLevel, grayLevel, grayLevel, 1.0f);
-
-GraphicsContext* c = drawingContext();
-if (!c)
-return;
-
 applyShadow();
 }
 
@@ -1163,11 +1157,6 @@
 state().m_shadowColor = colorWithOverrideAlpha(rgba, alpha);
 state().m_shadowOffset = FloatSize(width, height);
 state().m_shadowBlur = blur;
-
-GraphicsContext* c = drawingContext();
-if (!c)
-return;
-
 applyShadow();
 }
 
@@ -1176,11 +1165,6 @@
 state().m_shadowOffset = FloatSize(width, height);
 state().m_shadowBlur = blur;
 state().m_shadowColor = makeRGBA32FromFloats(grayLevel, grayLevel, grayLevel, alpha);
-
-GraphicsContext* c = drawingContext();
-if (!c)
-return;
-
 applyShadow();
 }
 
@@ -1189,11 +1173,6 @@
 state().m_shadowOffset = FloatSize(width, height);
 state().m_shadowBlur = blur;
 state().m_shadowColor = makeRGBA32FromFloats(r, g, b, a);
-
-GraphicsContext* c = drawingContext();
-if (!c)
-return;
-
 applyShadow();
 }
 
@@ -1294,10 +1273,6 @@
 float sx, float sy, float sw, float sh,
 float dx, float dy, float dw, float dh, ExceptionCode ec)
 {
-if (!image) {
-ec = TYPE_MISMATCH_ERR;
-return;
-}
 drawImage(image, FloatRect(sx, sy, sw, sh), FloatRect(dx, dy, dw, dh), ec);
 }
 
@@ -1366,21 +1341,12 @@
 
 void CanvasRenderingContext2D::drawImage(HTMLCanvasElement* sourceCanvas, float x, float y, ExceptionCode ec)
 {
-if (!sourceCanvas) {
-ec = TYPE_MISMATCH_ERR;
-return;
-}
-
 drawImage(sourceCanvas, 0, 0, sourceCanvas-width(), sourceCanvas-height(), x, y, sourceCanvas-width(), sourceCanvas-height(), ec);
 }
 
 void CanvasRenderingContext2D::drawImage(HTMLCanvasElement* sourceCanvas,
 float x, float y, float width, float height, ExceptionCode ec)
 {
-if (!sourceCanvas) {
-ec = TYPE_MISMATCH_ERR;
-return;
-}
 drawImage(sourceCanvas, FloatRect(0, 0, sourceCanvas-width(), sourceCanvas-height()), FloatRect(x, y, width, height), ec);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106975] trunk/LayoutTests

Title: [106975] trunk/LayoutTests








Revision 106975
Author jchaffr...@webkit.org
Date 2012-02-07 12:28:57 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed gardening.

* platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-win/fast/events/frame-tab-focus-expected.txt: Removed.
* platform/chromium/fast/events/frame-tab-focus-expected.txt: Added.
* platform/chromium/test_expectations.txt:
Rebaseline some old entries in test_expectations.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png


Added Paths

trunk/LayoutTests/platform/chromium/fast/events/frame-tab-focus-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-win/fast/events/frame-tab-focus-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106974 => 106975)

--- trunk/LayoutTests/ChangeLog	2012-02-07 20:16:09 UTC (rev 106974)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 20:28:57 UTC (rev 106975)
@@ -1,3 +1,13 @@
+2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+* platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:
+* platform/chromium-win/fast/events/frame-tab-focus-expected.txt: Removed.
+* platform/chromium/fast/events/frame-tab-focus-expected.txt: Added.
+* platform/chromium/test_expectations.txt:
+Rebaseline some old entries in test_expectations.
+
 2012-02-07  Raymond Toy  r...@google.com
 
 createImpulseBuffer uses incorrect length


Added: trunk/LayoutTests/platform/chromium/fast/events/frame-tab-focus-expected.txt (0 => 106975)

--- trunk/LayoutTests/platform/chromium/fast/events/frame-tab-focus-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium/fast/events/frame-tab-focus-expected.txt	2012-02-07 20:28:57 UTC (rev 106975)
@@ -0,0 +1,146 @@
+This page tests tabbing between subframes. To test, click on this text to focus the main window. Then press Tab 7 times, then Shift-Tab 7 times, which should move focus forward and backward through all inputs and frames. Then press Option-Tab 11 times and Shift-Option-Tab 11 times, which should move focus forward and backward through all inputs, frames, and links.
+
+   [tabindex of one] [tabindex of three] [tabindex of two] [tabindex of three]
+Tabbing forward...
+
+main window: INPUT #2 (tabindex=2) focused
+main window: INPUT #2 (tabindex=2) blurred
+main window: INPUT #1 (tabindex=3) focused
+main window: INPUT #1 (tabindex=3) blurred
+main window: window blurred
+child: window focused
+child: INPUT #0 (tabindex=0) focused
+child: INPUT #0 (tabindex=0) blurred
+child: window blurred
+main window: window focused
+main window: INPUT #0 (tabindex=0) focused
+main window: INPUT #0 (tabindex=0) blurred
+main window: window blurred
+empty-child: window focused
+empty-child: window blurred
+middle-child-1: window focused
+middle-child-1: INPUT #0 (tabindex=0) focused
+middle-child-1: INPUT #0 (tabindex=0) blurred
+middle-child-1: window blurred
+middle-child-2: window focused
+middle-child-2: INPUT #0 (tabindex=0) focused
+middle-child-2: INPUT #0 (tabindex=0) blurred
+middle-child-2: window blurred
+main window: window focused
+main window: INPUT #3 (tabindex=0) focused
+main window: INPUT #3 (tabindex=0) blurred
+
+Tabbing backward...
+
+main window: INPUT #3 (tabindex=0) focused
+main window: INPUT #3 (tabindex=0) blurred
+main window: window blurred
+middle-child-2: window focused
+middle-child-2: INPUT #0 (tabindex=0) focused
+middle-child-2: INPUT #0 (tabindex=0) blurred
+middle-child-2: window blurred
+middle-child-1: window focused
+middle-child-1: INPUT #0 (tabindex=0) focused
+middle-child-1: INPUT #0 (tabindex=0) blurred
+middle-child-1: window blurred
+empty-child: window focused
+empty-child: window blurred
+main window: window focused
+main window: INPUT #0 (tabindex=0) focused
+main window: INPUT #0 (tabindex=0) blurred
+main window: window blurred
+child: window focused
+child: INPUT #0 (tabindex=0) focused
+child: INPUT #0 (tabindex=0) blurred
+child: window blurred
+main window: window focused
+main window: INPUT #1 (tabindex=3) focused
+main window: INPUT #1 (tabindex=3) blurred
+main window: INPUT #2 (tabindex=2) focused
+main window: INPUT #2 (tabindex=2) blurred
+
+Option-tabbing forward...
+
+main window: INPUT #2 (tabindex=2) focused
+main window: INPUT #2 (tabindex=2) blurred
+main window: INPUT #1 (tabindex=3) focused
+main window: INPUT #1 (tabindex=3) blurred
+main window: window blurred
+child: window focused
+child: INPUT #0 (tabindex=0) focused
+child: INPUT #0 (tabindex=0) blurred
+child: window blurred
+main window: window focused
+main window: INPUT #0 (tabindex=0) focused
+main window: INPUT #0 (tabindex=0) blurred
+main window: window blurred
+empty-child: window focused
+empty-child: window blurred
+middle-child-1: window

[webkit-changes] [106977] trunk/Source

Title: [106977] trunk/Source

Revision 106977
Author ander...@apple.com
Date 2012-02-07 12:45:52 -0800 (Tue, 07 Feb 2012)

Log Message
ScrollableAreaSet should be moved from Page to FrameView
https://bugs.webkit.org/show_bug.cgi?id=62762

Reviewed by Beth Dakin.

Source/WebCore:

It makes more sense for the set of scrollable areas to be per frame view instead of per page;
scrollable areas are associated with a containing frame view and their lifecycle follows the lifecycle of the
frame view much more closely. This could even fix a bunch of crashes where a scrollable area outlived its containing page.

* WebCore.exp.in:
Replace the Page member functions with FrameView member functions instead.

* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
Check if the frame view contains the given layer.

(WebCore::EventHandler::updateMouseEventTargetNode):
Ditto.

* page/FocusController.cpp:
(WebCore::contentAreaDidShowOrHide):
Add helper function.

(WebCore::FocusController::setContainingWindowIsVisible):
Call contentAreaDidShowOrHide for the main frame view, and for all scrollable areas
inside all subframe views.

* page/FrameView.cpp:
(WebCore::FrameView::FrameView):
Use early returns to make the code more clear. Also, don't add the scrollable area to the set here.

(WebCore::FrameView::~FrameView):
Don't remove the scrollable area here.

(WebCore::FrameView::zoomAnimatorTransformChanged):
m_page is gone so use m_frame-page() instead.

(WebCore::FrameView::setAnimatorsAreActive):
Call ScrollAnimator::setIsActive for all the scrollable areas in this frame view. Previously we used to do
this for all scrollable areas on the page, but since setAnimatorsAreActive will be called for each document,
this will be done implicitly.

(WebCore::FrameView::notifyPageThatContentAreaWillPaint):
Call ScrollableArea::contentDidPaint for this frame view and all its immediate scrollable areas. Previously, we used
to do this for all scrollable areas on the page, but we only need to do it for this frame view.

(WebCore::FrameView::scrollAnimatorEnabled):
Get the page from m_frame since m_page is gone.

(WebCore::FrameView::addScrollableArea):
(WebCore::FrameView::removeScrollableArea):
(WebCore::FrameView::containsScrollableArea):
Move these member functions here from Page.

(WebCore::FrameView::addChild):
If we are adding a frame view, add it to the scrollable area set.

(WebCore::FrameView::removeChild):
If we are removing a frame view, remove it from the scrollable area set.

* page/FrameView.h:
Move the member function declarations and the scrollable area set member variable here from Page.

* page/Page.cpp:
(WebCore::Page::~Page):
Don't call disconnectPage on the scrollable areas anymore.

* platform/ScrollView.h:
(ScrollView):
Make addChild and removeChild virtual.

* platform/ScrollableArea.h:
Remove disconnectFromPage.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::styleChanged):
The frame view now keeps track of the scrollable areas.

* rendering/RenderLayer.h:
Remove the page member variable and disconnectFromPage.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
The frame view now keeps track of the scrollable areas.

* rendering/RenderListBox.h:
Remove the page member variable and disconnectFromPage.

Source/WebKit/chromium:

Update for changes to WebCore now that the scrollable area set is kept per frame view.

* src/ScrollbarGroup.cpp:
(WebKit::ScrollbarGroup::ScrollbarGroup):
(WebKit::ScrollbarGroup::~ScrollbarGroup):
* src/ScrollbarGroup.h:
(WebCore):
(ScrollbarGroup):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::scrollbarGroup):

Source/WebKit2:

* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
(WebKit::BuiltInPDFView::initialize):
Call FrameView::addScrollableArea instead.

(WebKit::BuiltInPDFView::destroy):
Call FrameView::removeScrollableArea instead.

* WebProcess/Plugins/PDF/BuiltInPDFView.h:
Remove disconnectFromPage since it no longer exists on ScrollableArea.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/page/EventHandler.cpp
trunk/Source/WebCore/page/FocusController.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/page/Page.h
trunk/Source/WebCore/platform/ScrollView.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/ScrollbarGroup.cpp
trunk/Source/WebKit/chromium/src/ScrollbarGroup.h
trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp
trunk/Source/WebKit2/ChangeLog

[webkit-changes] [106978] trunk/Source

2012-02-07 Thread jer . noble

Title: [106978] trunk/Source








Revision 106978
Author jer.no...@apple.com
Date 2012-02-07 12:48:30 -0800 (Tue, 07 Feb 2012)


Log Message
Use CMClock as a timing source for PlatformClock where available.
https://bugs.webkit.org/show_bug.cgi?id=77885

Reviewed by Eric Carlson.

Source/_javascript_Core:

* wtf/Platform.h: Added WTF_USE_COREMEDIA.

Source/WebCore:

No new tests; performance improvement covered by existing test cases.

* WebCore.xcodeproj/project.pbxproj:
* platform/Clock.cpp:
(Clock::create): Use PlatformClockCM if available.
* platform/mac/PlatformClockCM.h: Added.
(WebCore::PlatformClockCM::playRate):
(WebCore::PlatformClockCM::isRunning):
* platform/mac/PlatformClockCM.mm: Added.
(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):
(PlatformClockCM::setCurrentTime):
(PlatformClockCM::currentTime):
(PlatformClockCM::setPlayRate):
(PlatformClockCM::start):
(PlatformClockCM::stop):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/Clock.cpp


Added Paths

trunk/Source/WebCore/platform/mac/PlatformClockCM.h
trunk/Source/WebCore/platform/mac/PlatformClockCM.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106977 => 106978)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-07 20:45:52 UTC (rev 106977)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-07 20:48:30 UTC (rev 106978)
@@ -1,3 +1,12 @@
+2012-02-06  Jer Noble  jer.no...@apple.com
+
+Use CMClock as a timing source for PlatformClock where available.
+https://bugs.webkit.org/show_bug.cgi?id=77885
+
+Reviewed by Eric Carlson.
+
+* wtf/Platform.h: Added WTF_USE_COREMEDIA.
+
 2012-02-06  Filip Pizlo  fpi...@apple.com
 
 ValueToNumber and ValueToDouble nodes don't do anything and should be removed


Modified: trunk/Source/_javascript_Core/wtf/Platform.h (106977 => 106978)

--- trunk/Source/_javascript_Core/wtf/Platform.h	2012-02-07 20:45:52 UTC (rev 106977)
+++ trunk/Source/_javascript_Core/wtf/Platform.h	2012-02-07 20:48:30 UTC (rev 106978)
@@ -1141,6 +1141,10 @@
 #define WTF_USE_AVFOUNDATION 1
 #endif
 
+#if PLATFORM(MAC)  !defined(BUILDING_ON_LEOPARD)  !defined(BUILDING_ON_SNOW_LEOPARD)  !defined(BUILDING_ON_LION)
+#define WTF_USE_COREMEDIA 1
+#endif
+
 #if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(EFL) || (PLATFORM(WIN)  !OS(WINCE)  !PLATFORM(WIN_CAIRO)) || PLATFORM(QT)
 #define WTF_USE_REQUEST_ANIMATION_FRAME_TIMER 1
 #endif


Modified: trunk/Source/WebCore/ChangeLog (106977 => 106978)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 20:45:52 UTC (rev 106977)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 20:48:30 UTC (rev 106978)
@@ -1,3 +1,27 @@
+2012-02-06  Jer Noble  jer.no...@apple.com
+
+Use CMClock as a timing source for PlatformClock where available.
+https://bugs.webkit.org/show_bug.cgi?id=77885
+
+Reviewed by Eric Carlson.
+
+No new tests; performance improvement covered by existing test cases.
+
+* WebCore.xcodeproj/project.pbxproj:
+* platform/Clock.cpp:
+(Clock::create): Use PlatformClockCM if available.
+* platform/mac/PlatformClockCM.h: Added.
+(WebCore::PlatformClockCM::playRate):
+(WebCore::PlatformClockCM::isRunning):
+* platform/mac/PlatformClockCM.mm: Added.
+(PlatformClockCM::PlatformClockCM):
+(PlatformClockCM::initializeWithTimingSource):
+(PlatformClockCM::setCurrentTime):
+(PlatformClockCM::currentTime):
+(PlatformClockCM::setPlayRate):
+(PlatformClockCM::start):
+(PlatformClockCM::stop):
+
 2012-02-06  Anders Carlsson  ander...@apple.com
 
 ScrollableAreaSet should be moved from Page to FrameView


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (106977 => 106978)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2012-02-07 20:45:52 UTC (rev 106977)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2012-02-07 20:48:30 UTC (rev 106978)
@@ -5598,6 +5598,7 @@
 		CD82030D1395AB6A00F956C6 /* WebVideoFullscreenHUDWindowController.mm in Sources */ = {isa = PBXBuildFile; fileRef = CD8203091395AB6A00F956C6 /* WebVideoFullscreenHUDWindowController.mm */; };
 		CD8203101395ACE700F956C6 /* WebWindowAnimation.h in Headers */ = {isa = PBXBuildFile; fileRef = CD82030E1395ACE700F956C6 /* WebWindowAnimation.h */; };
 		CD8203111395ACE700F956C6 /* WebWindowAnimation.mm in Sources */ = {isa = PBXBuildFile; fileRef = CD82030F1395ACE700F956C6 /* WebWindowAnimation.mm */; };
+		CDAA8D0A14D71B2E0061EA60 /* PlatformClockCM.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDAA8D0814D385600061EA60 /* PlatformClockCM.mm */; };
 		CDD525D7145B6DD0008D204D /* JSHTMLMediaElementCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CDF65CCC145B6AFE00C4C7AA /* JSHTMLMediaElementCustom.cpp */; };

[webkit-changes] [106979] branches/subpixellayout/Source/WebCore

2012-02-07 Thread eae

Title: [106979] branches/subpixellayout/Source/WebCore








Revision 106979
Author e...@chromium.org
Date 2012-02-07 13:06:31 -0800 (Tue, 07 Feb 2012)


Log Message
Various build fixes for branch

Modified Paths

branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
branches/subpixellayout/Source/WebCore/page/Page.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderThemeMac.mm
branches/subpixellayout/Source/WebCore/rendering/svg/RenderSVGShape.cpp




Diff

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (106978 => 106979)

--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2012-02-07 20:48:30 UTC (rev 106978)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2012-02-07 21:06:31 UTC (rev 106979)
@@ -1513,7 +1513,7 @@
 VisiblePositionRange range = VisiblePositionRange(visSelection.visibleStart(), visSelection.visibleEnd());
 IntRect bounds = boundsForVisiblePositionRange(range);
 #if PLATFORM(MAC)
-bounds.setLocation(m_renderer-document()-view()-screenToContents(roundedIntPoint(bounds.location(;
+bounds.setLocation(m_renderer-document()-view()-screenToContents(bounds.location()));
 #endif
 return IntPoint(bounds.x() + (bounds.width() / 2), bounds.y() - (bounds.height() / 2));
 }
@@ -2818,7 +2818,7 @@
 return IntRect();
 }
 
-AccessibilityObject* AccessibilityRenderObject::accessibilityImageMapHitTest(HTMLAreaElement* area, const LayoutPoint point) const
+AccessibilityObject* AccessibilityRenderObject::accessibilityImageMapHitTest(HTMLAreaElement* area, const IntPoint point) const
 {
 if (!area)
 return 0;


Modified: branches/subpixellayout/Source/WebCore/page/Page.cpp (106978 => 106979)

--- branches/subpixellayout/Source/WebCore/page/Page.cpp	2012-02-07 20:48:30 UTC (rev 106978)
+++ branches/subpixellayout/Source/WebCore/page/Page.cpp	2012-02-07 21:06:31 UTC (rev 106979)
@@ -1103,7 +1103,7 @@
 
 // The objects are only relevant if they are being painted within the viewRect().
 if (RenderView* view = object-view()) {
-if (!objectPaintRect.intersects(view-viewRect()))
+if (!objectPaintRect.intersects(pixelSnappedIntRect(view-viewRect(
 return;
 }
 


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp (106978 => 106979)

--- branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp	2012-02-07 20:48:30 UTC (rev 106978)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp	2012-02-07 21:06:31 UTC (rev 106979)
@@ -1742,7 +1742,7 @@
 }
 LayoutUnit baseWidth = renderer-width() - (isBoxSizingBorder ? LayoutUnit(0) : renderer-borderAndPaddingWidth());
 baseWidth = baseWidth / zoomFactor;
-styleDeclaration-setProperty(CSSPropertyWidth, String::number((baseWidth + difference.width().toFloat()) + px, false);
+styleDeclaration-setProperty(CSSPropertyWidth, String::number((baseWidth + difference.width()).toFloat()) + px, false);
 }
 
 if (resize != RESIZE_HORIZONTAL  difference.height()) {


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp (106978 => 106979)

--- branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp	2012-02-07 20:48:30 UTC (rev 106978)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp	2012-02-07 21:06:31 UTC (rev 106979)
@@ -272,7 +272,7 @@
 bool isCSSTable = !node() || !node()-hasTagName(tableTag);
 if (isCSSTable  styleLogicalWidth.isFixed()  styleLogicalWidth.isPositive()) {
 recalcBordersInRowDirection();
-borders = borderStart() + borderEnd() + (collapseBorders() ? 0 : paddingStart() + paddingEnd());
+borders = borderStart() + borderEnd() + (collapseBorders() ? LayoutUnit(0) : paddingStart() + paddingEnd());
 }
 return styleLogicalWidth.calcMinValue(availableWidth) + borders;
 }


Modified: branches/subpixellayout/Source/WebCore/rendering/RenderThemeMac.mm (106978 => 106979)

--- branches/subpixellayout/Source/WebCore/rendering/RenderThemeMac.mm	2012-02-07 20:48:30 UTC (rev 106978)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderThemeMac.mm	2012-02-07 21:06:31 UTC (rev 106979)
@@ -825,8 +825,8 @@
 NSLevelIndicatorCell* cell = levelIndicatorFor(renderMeter);
 // Makes enough room for cell's intrinsic size.
 NSSize cellSize = [cell cellSizeForBounds:LayoutRect(LayoutPoint(), bounds.size())];
-return LayoutSize(bounds.width()  cellSize.width ? cellSize.width : bounds.width(),
-  bounds.height()  cellSize.height ? cellSize.height : bounds.height());
+return LayoutSize(bounds.width().toInt()  cellSize.width ? cellSize.width : bounds.width().toInt(),
+

[webkit-changes] [106980] trunk/Source/WebCore

2012-02-07 Thread tony

Title: [106980] trunk/Source/WebCore








Revision 106980
Author t...@chromium.org
Date 2012-02-07 13:22:29 -0800 (Tue, 07 Feb 2012)


Log Message
move warning about css values and render style constants closer to where it applies
https://bugs.webkit.org/show_bug.cgi?id=78017

Reviewed by Darin Adler.

Move the warning about keeping RenderStyleConstnats.h enums and
CSSValueKeywords.in values in the same order closer to the properties
that the warning applies to. The warning was easy to miss and was
confusing since it doesn't apply to most values.

Also refactor 2 conversion functions to
enumerate the possible values so the order doesn't matter.

No new tests, just refactoring and comment cleanup.

* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator EListStylePosition): Name all possible values and add a NOT_REACHED().
(WebCore::CSSPrimitiveValue::operator EUserModify): Name all possible values and add a NOT_REACHED().
* css/CSSValueKeywords.in:
* css/SVGCSSPropertyNames.in:
* css/SVGCSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h
trunk/Source/WebCore/css/CSSValueKeywords.in
trunk/Source/WebCore/css/SVGCSSPropertyNames.in
trunk/Source/WebCore/css/SVGCSSValueKeywords.in
trunk/Source/WebCore/rendering/style/RenderStyleConstants.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106979 => 106980)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 21:06:31 UTC (rev 106979)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 21:22:29 UTC (rev 106980)
@@ -1,3 +1,28 @@
+2012-02-07  Tony Chang  t...@chromium.org
+
+move warning about css values and render style constants closer to where it applies
+https://bugs.webkit.org/show_bug.cgi?id=78017
+
+Reviewed by Darin Adler.
+
+Move the warning about keeping RenderStyleConstnats.h enums and
+CSSValueKeywords.in values in the same order closer to the properties
+that the warning applies to. The warning was easy to miss and was
+confusing since it doesn't apply to most values.
+
+Also refactor 2 conversion functions to
+enumerate the possible values so the order doesn't matter.
+
+No new tests, just refactoring and comment cleanup.
+
+* css/CSSPrimitiveValueMappings.h:
+(WebCore::CSSPrimitiveValue::operator EListStylePosition): Name all possible values and add a NOT_REACHED().
+(WebCore::CSSPrimitiveValue::operator EUserModify): Name all possible values and add a NOT_REACHED().
+* css/CSSValueKeywords.in:
+* css/SVGCSSPropertyNames.in:
+* css/SVGCSSValueKeywords.in:
+* rendering/style/RenderStyleConstants.h:
+
 2012-02-06  Jer Noble  jer.no...@apple.com
 
 Use CMClock as a timing source for PlatformClock where available.


Modified: trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h (106979 => 106980)

--- trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2012-02-07 21:06:31 UTC (rev 106979)
+++ trunk/Source/WebCore/css/CSSPrimitiveValueMappings.h	2012-02-07 21:22:29 UTC (rev 106980)
@@ -1396,7 +1396,15 @@
 
 template inline CSSPrimitiveValue::operator EListStylePosition() const
 {
-return (EListStylePosition)(m_value.ident - CSSValueOutside);
+switch (m_value.ident) {
+case CSSValueOutside:
+return OUTSIDE;
+case CSSValueInside:
+return INSIDE;
+default:
+ASSERT_NOT_REACHED();
+return OUTSIDE;
+}
 }
 
 template inline CSSPrimitiveValue::CSSPrimitiveValue(EListStyleType e)
@@ -2285,7 +2293,17 @@
 
 template inline CSSPrimitiveValue::operator EUserModify() const
 {
-return static_castEUserModify(m_value.ident - CSSValueReadOnly);
+switch (m_value.ident) {
+case CSSValueReadOnly:
+return READ_ONLY;
+case CSSValueReadWrite:
+return READ_WRITE;
+case CSSValueReadWritePlaintextOnly:
+return READ_WRITE_PLAINTEXT_ONLY;
+default:
+ASSERT_NOT_REACHED();
+return READ_ONLY;
+}
 }
 
 template inline CSSPrimitiveValue::CSSPrimitiveValue(EUserSelect e)


Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (106979 => 106980)

--- trunk/Source/WebCore/css/CSSValueKeywords.in	2012-02-07 21:06:31 UTC (rev 106979)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in	2012-02-07 21:22:29 UTC (rev 106980)
@@ -1,14 +1,6 @@
-// These are all values accepted for CSS2.
 //
-// WARNING:
-// 
+// CSS value names
 //
-// The Values are sorted according to the properties they belong to,
-// and have to be in the same order as the enums in RenderStyleConstants.h.
-//
-// If not, the optimizations in the cssparser and style selector will fail,
-// and produce incorrect results.
-//
 inherit
 initial
 //
@@ -16,6 +8,7 @@
 // CSS_PROP_BORDER_TOP_STYLE
 // CSS_PROP_BORDER_BOTTOM_STYLE
 // CSS_PROP_BORDER_LEFT_STYLE
+// The order here must match the order of the EBorderStyle enum in

[webkit-changes] [106981] trunk/LayoutTests

Title: [106981] trunk/LayoutTests








Revision 106981
Author jchaffr...@webkit.org
Date 2012-02-07 13:24:53 -0800 (Tue, 07 Feb 2012)


Log Message
Revert r106958.

* platform/chromium/test_expectations.txt:
It was a mistake as the test is really flaky not slow,
so now it is taking way longer to fail (see http://webkit.org/b/77997).

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106980 => 106981)

--- trunk/LayoutTests/ChangeLog	2012-02-07 21:22:29 UTC (rev 106980)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 21:24:53 UTC (rev 106981)
@@ -1,5 +1,13 @@
 2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
 
+Revert r106958.
+
+* platform/chromium/test_expectations.txt:
+It was a mistake as the test is really flaky not slow,
+so now it is taking way longer to fail (see http://webkit.org/b/77997).
+
+2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
+
 Unreviewed gardening.
 
 * platform/chromium-linux/fast/forms/tabbing-input-iframe-expected.png:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106980 => 106981)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 21:22:29 UTC (rev 106980)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 21:24:53 UTC (rev 106981)
@@ -52,8 +52,6 @@
 BUGWK76270 SKIP : http/tests/appcache/abort-cache-ondownloading-manifest-404.html = FAIL
 BUGWK76270 SKIP : http/tests/appcache/abort-cache-ondownloading-resource-404.html = FAIL
 BUGWK76270 SKIP : http/tests/appcache/abort-cache-onprogress.html = FAIL
-// The test needs a rebaseline after BUGWK77736.
-BUGWK77997 DEBUG SLOW : svg/as-object/nested-embedded-svg-size-changes.html = IMAGE
 
 // -
 // TEMPORARILY SKIPPED TESTS
@@ -3995,7 +3993,7 @@
 BUGWK77736 : svg/as-object/embedded-svg-size-changes.html = IMAGE
 BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1.html = IMAGE+TEXT
 BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2.html = IMAGE+TEXT
-BUGWK77736 RELEASE : svg/as-object/nested-embedded-svg-size-changes.html = IMAGE
+BUGWK77736 : svg/as-object/nested-embedded-svg-size-changes.html = IMAGE
 BUGWK77736 : svg/carto.net/tabgroup.svg = IMAGE+TEXT
 BUGWK77736 MAC LINUX : svg/carto.net/window.svg = IMAGE+TEXT
 BUGWK77736 MAC LINUX : svg/css/shadow-changes.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106982] trunk

2012-02-07 Thread beidson

Title: [106982] trunk








Revision 106982
Author beid...@apple.com
Date 2012-02-07 13:37:17 -0800 (Tue, 07 Feb 2012)


Log Message
rdar://problem/9567286 and https://bugs.webkit.org/show_bug.cgi?id=78003 WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html

Associate the credential with the URL of the challenge itself, not the original request:
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

LayoutTests:

* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added.
* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added.
* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added.
* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added.
* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
trunk/Source/WebCore/platform/network/mac/ResourceHandleMac.mm


Added Paths

trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/
trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt
trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/
trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php
trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php
trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php




Diff

Modified: trunk/LayoutTests/ChangeLog (106981 => 106982)

--- trunk/LayoutTests/ChangeLog	2012-02-07 21:24:53 UTC (rev 106981)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 21:37:17 UTC (rev 106982)
@@ -1,3 +1,16 @@
+2012-02-07  Brady Eidson  beid...@apple.com
+
+rdar://problem/9567286 and https://bugs.webkit.org/show_bug.cgi?id=78003
+WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain
+
+Reviewed by Alexey Proskuryakov.
+
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added.
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added.
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added.
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added.
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added.
+
 2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
 
 Revert r106958.


Added: trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt (0 => 106982)

--- trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt	2012-02-07 21:37:17 UTC (rev 106982)
@@ -0,0 +1,30 @@
+main frame - didStartProvisionalLoadForFrame
+main frame - didCommitLoadForFrame
+frame !--framePath //!--frame0 - didStartProvisionalLoadForFrame
+main frame -

[webkit-changes] [106983] trunk/Tools

2012-02-07 Thread zimmermann

Title: [106983] trunk/Tools








Revision 106983
Author zimmerm...@webkit.org
Date 2012-02-07 13:37:43 -0800 (Tue, 07 Feb 2012)


Log Message
layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Dan Bernstein.

Fix race condition in repaint rect tracking. When running a test using the repaint.js
harness right after a test starting with svg/W3C-SVG-1.1 the repaint test will fail,
the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
the repaint test already run, thus invalidating the previously tracked repaint rects.

* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
(runTest):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm




Diff

Modified: trunk/Tools/ChangeLog (106982 => 106983)

--- trunk/Tools/ChangeLog	2012-02-07 21:37:17 UTC (rev 106982)
+++ trunk/Tools/ChangeLog	2012-02-07 21:37:43 UTC (rev 106983)
@@ -1,3 +1,21 @@
+2012-02-07  Nikolas Zimmermann  nzimmerm...@rim.com
+
+layoutTestController.display() is flaky for SVG tests
+https://bugs.webkit.org/show_bug.cgi?id=78021
+
+Reviewed by Dan Bernstein.
+
+Fix race condition in repaint rect tracking. When running a test using the repaint.js
+harness right after a test starting with svg/W3C-SVG-1.1 the repaint test will fail,
+the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
+hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
+svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
+the repaint test already run, thus invalidating the previously tracked repaint rects.
+
+* DumpRenderTree/mac/DumpRenderTree.mm:
+(dump):
+(runTest):
+
 2012-02-07  Hans Wennborg  h...@chromium.org
 
 Chromium: remove WebSpeechInputResult::set


Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (106982 => 106983)

--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2012-02-07 21:37:17 UTC (rev 106982)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2012-02-07 21:37:43 UTC (rev 106983)
@@ -1146,10 +1146,8 @@
 WebArchive *webArchive = [[mainFrame dataSource] webArchive];
 resultString = HardAutorelease(createXMLStringFromWebArchiveData((CFDataRef)[webArchive data]));
 resultMimeType = @application/x-webarchive;
-} else {
-sizeWebViewForCurrentTest();
+} else
 resultString = [mainFrame renderTreeAsExternalRepresentationForPrinting:gLayoutTestController-isPrinting()];
-}
 
 if (resultString  !resultData)
 resultData = [resultString dataUsingEncoding:NSUTF8StringEncoding];
@@ -1303,6 +1301,7 @@
 releaseAndZero(draggingInfo);
 done = NO;
 
+sizeWebViewForCurrentTest();
 gLayoutTestController-setIconDatabaseEnabled(false);
 
 if (disallowedURLs)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106986] trunk/Source/WebCore

2012-02-07 Thread jamesr

Title: [106986] trunk/Source/WebCore








Revision 106986
Author jam...@google.com
Date 2012-02-07 13:50:57 -0800 (Tue, 07 Feb 2012)


Log Message
[chromium] Gracefully handle compositor initialization failure in single-threaded proxy
https://bugs.webkit.org/show_bug.cgi?id=78013

Reviewed by Kenneth Russell.

If compositor initialization fails it's not safe to proceed through the rest of the frame process. This adds
some early outs.

Tested manually by forcing the first makeContextCurrent() call fail.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::compositeAndReadback):
(WebCore::CCSingleThreadProxy::compositeImmediately):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (106985 => 106986)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 21:48:24 UTC (rev 106985)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 21:50:57 UTC (rev 106986)
@@ -1,3 +1,26 @@
+2012-02-07  James Robinson  jam...@chromium.org
+
+[chromium] Gracefully handle compositor initialization failure in single-threaded proxy
+https://bugs.webkit.org/show_bug.cgi?id=78013
+
+Reviewed by Kenneth Russell.
+
+If compositor initialization fails it's not safe to proceed through the rest of the frame process. This adds
+some early outs.
+
+Tested manually by forcing the first makeContextCurrent() call fail.
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::updateLayers):
+* platform/graphics/chromium/cc/CCLayerTreeHost.h:
+(CCLayerTreeHost):
+* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
+(WebCore::CCSingleThreadProxy::compositeAndReadback):
+(WebCore::CCSingleThreadProxy::compositeImmediately):
+(WebCore::CCSingleThreadProxy::commitIfNeeded):
+* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
+(CCSingleThreadProxy):
+
 2012-02-07  Brady Eidson  beid...@apple.com
 
 rdar://problem/9567286 and https://bugs.webkit.org/show_bug.cgi?id=78003


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (106985 => 106986)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-02-07 21:48:24 UTC (rev 106985)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp	2012-02-07 21:50:57 UTC (rev 106986)
@@ -371,22 +371,23 @@
 static_castCCSingleThreadProxy*(m_proxy.get())-compositeImmediately();
 }
 
-void CCLayerTreeHost::updateLayers()
+bool CCLayerTreeHost::updateLayers()
 {
 if (!m_layerRendererInitialized) {
 initializeLayerRenderer();
 // If we couldn't initialize, then bail since we're returning to software mode.
 if (!m_layerRendererInitialized)
-return;
+return false;
 }
 
 if (!rootLayer())
-return;
+return true;
 
 if (viewportSize().isEmpty())
-return;
+return true;
 
 updateLayers(rootLayer());
+return true;
 }
 
 void CCLayerTreeHost::updateLayers(LayerChromium* rootLayer)


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h (106985 => 106986)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h	2012-02-07 21:48:24 UTC (rev 106985)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h	2012-02-07 21:50:57 UTC (rev 106986)
@@ -184,7 +184,8 @@
 
 void setHaveWheelEventHandlers(bool);
 
-void updateLayers();
+// Returns false if we should abort this frame due to initialization failure.
+bool updateLayers();
 
 void updateCompositorResources(GraphicsContext3D*, CCTextureUpdater);
 void applyScrollAndScale(const CCScrollAndScaleSet);


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp (106985 => 106986)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp	2012-02-07 21:48:24 UTC (rev 106985)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp	2012-02-07 21:50:57 UTC (rev 106986)
@@ -78,7 +78,8 @@
 return false;
 }
 
-commitIfNeeded();
+if (!commitIfNeeded())
+return false;
 
 if (!doComposite())
 return false;
@@ -228,7 +229,8 @@
 if

[webkit-changes] [106987] trunk/Source/WebKit/chromium

Title: [106987] trunk/Source/WebKit/chromium








Revision 106987
Author commit-qu...@webkit.org
Date 2012-02-07 13:52:21 -0800 (Tue, 07 Feb 2012)


Log Message
Process Scroll-gesture events from the compositor.
https://bugs.webkit.org/show_bug.cgi?id=77477

Patch by Sadrul Habib Chowdhury sad...@chromium.org on 2012-02-07
Reviewed by James Robinson.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
* src/WebCompositorInputHandlerImpl.h:
(WebCompositorInputHandlerImpl):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp
trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.h
trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (106986 => 106987)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-07 21:50:57 UTC (rev 106986)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-07 21:52:21 UTC (rev 106987)
@@ -1,3 +1,16 @@
+2012-02-07  Sadrul Habib Chowdhury  sad...@chromium.org
+
+Process Scroll-gesture events from the compositor.
+https://bugs.webkit.org/show_bug.cgi?id=77477
+
+Reviewed by James Robinson.
+
+* src/WebCompositorInputHandlerImpl.cpp:
+(WebKit::WebCompositorInputHandlerImpl::WebCompositorInputHandlerImpl):
+(WebKit::WebCompositorInputHandlerImpl::handleInputEvent):
+* src/WebCompositorInputHandlerImpl.h:
+(WebCompositorInputHandlerImpl):
+
 2012-02-07  Anders Carlsson  ander...@apple.com
 
 ScrollableAreaSet should be moved from Page to FrameView


Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp (106986 => 106987)

--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2012-02-07 21:50:57 UTC (rev 106986)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp	2012-02-07 21:52:21 UTC (rev 106987)
@@ -81,6 +81,10 @@
 : m_client(0)
 , m_identifier(s_nextAvailableIdentifier++)
 , m_inputHandlerClient(inputHandlerClient)
+#ifndef NDEBUG
+, m_expectScrollUpdateEnd(false)
+#endif
+, m_scrollStarted(false)
 {
 ASSERT(CCProxy::isImplThread());
 
@@ -131,6 +135,44 @@
 case CCInputHandlerClient::ScrollFailed:
 break;
 }
+} else if (event.type == WebInputEvent::GestureScrollBegin) {
+ASSERT(!m_scrollStarted);
+ASSERT(!m_expectScrollUpdateEnd);
+#ifndef NDEBUG
+m_expectScrollUpdateEnd = true;
+#endif
+const WebGestureEvent gestureEvent = *static_castconst WebGestureEvent*(event);
+CCInputHandlerClient::ScrollStatus scrollStatus = m_inputHandlerClient-scrollBegin(IntPoint(gestureEvent.x, gestureEvent.y));
+switch (scrollStatus) {
+case CCInputHandlerClient::ScrollStarted:
+m_scrollStarted = true;
+m_client-didHandleInputEvent();
+return;
+case CCInputHandlerClient::ScrollIgnored:
+m_client-didNotHandleInputEvent(false /* sendToWidget */);
+return;
+case CCInputHandlerClient::ScrollFailed:
+break;
+}
+} else if (event.type == WebInputEvent::GestureScrollUpdate) {
+ASSERT(m_expectScrollUpdateEnd);
+if (m_scrollStarted) {
+const WebGestureEvent gestureEvent = *static_castconst WebGestureEvent*(event);
+m_inputHandlerClient-scrollBy(IntSize(-gestureEvent.deltaX, -gestureEvent.deltaY));
+m_client-didHandleInputEvent();
+return;
+}
+} else if (event.type == WebInputEvent::GestureScrollEnd) {
+ASSERT(m_expectScrollUpdateEnd);
+#ifndef NDEBUG
+m_expectScrollUpdateEnd = false;
+#endif
+if (m_scrollStarted) {
+m_inputHandlerClient-scrollEnd();
+m_client-didHandleInputEvent();
+m_scrollStarted = false;
+return;
+}
 }
 m_client-didNotHandleInputEvent(true /* sendToWidget */);
 }


Modified: trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.h (106986 => 106987)

--- trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.h	2012-02-07 21:50:57 UTC (rev 106986)
+++ trunk/Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.h	2012-02-07 21:52:21 UTC (rev 106987)
@@ -70,6 +70,11 @@
 int m_identifier;
 WebCore::CCInputHandlerClient* m_inputHandlerClient;
 
+#ifndef NDEBUG
+bool m_expectScrollUpdateEnd;
+#endif
+bool m_scrollStarted;
+
 static int s_nextAvailableIdentifier;
 static HashSetWebCompositorInputHandlerImpl** s_compositors;
 };


Modified: trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp (106986 => 106987)

--- trunk/Source/WebKit/chromium/tests/WebCompositorInputHandlerImplTest.cpp	2012-02-07 21:50:57 UTC (rev 106986)
+++

[webkit-changes] [106990] trunk/LayoutTests

Title: [106990] trunk/LayoutTests








Revision 106990
Author jchaffr...@webkit.org
Date 2012-02-07 14:08:07 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed gardening.

* platform/chromium/test_expectations.txt:
Mark those 2 tests as crashing in Debug as they seem
to be hitting an ASSERT.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106989 => 106990)

--- trunk/LayoutTests/ChangeLog	2012-02-07 22:02:18 UTC (rev 106989)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 22:08:07 UTC (rev 106990)
@@ -1,3 +1,11 @@
+2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+* platform/chromium/test_expectations.txt:
+Mark those 2 tests as crashing in Debug as they seem
+to be hitting an ASSERT.
+
 2012-02-07  Csaba Osztrogonác  o...@webkit.org
 
 [Qt] Unreviewed gardening, paint the bots green.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106989 => 106990)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 22:02:18 UTC (rev 106989)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 22:08:07 UTC (rev 106990)
@@ -4042,3 +4042,6 @@
 BUGWK77736 : svg/zoom/text/zoom-hixie-mixed-008.xml = IMAGE+TEXT
 BUGWK77736 MAC WIN : svg/zoom/text/zoom-hixie-mixed-009.xml = IMAGE
 BUGWK77736 : svg/zoom/text/zoom-hixie-rendering-model-004.xhtml = IMAGE+TEXT
+
+BUGWK78038 DEBUG : compositing/iframes/invisible-nested-iframe-show.html = PASS CRASH
+BUGWK78038 DEBUG : compositing/iframes/layout-on-compositing-change.html = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106991] trunk/LayoutTests

Title: [106991] trunk/LayoutTests








Revision 106991
Author commit-qu...@webkit.org
Date 2012-02-07 14:18:29 -0800 (Tue, 07 Feb 2012)


Log Message
IndexedDB createIndex should fail if options arg is invalid
https://bugs.webkit.org/show_bug.cgi?id=58467

Patch by Eugene Girard gir...@chromium.org on 2012-02-07
Reviewed by Tony Chang.

This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471
Adding unit tests to verify correct operation.

* storage/indexeddb/index-basics-expected.txt:
* storage/indexeddb/index-basics-workers-expected.txt:
* storage/indexeddb/resources/index-basics.js:
(deleteExisting):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/index-basics-expected.txt
trunk/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/index-basics.js




Diff

Modified: trunk/LayoutTests/ChangeLog (106990 => 106991)

--- trunk/LayoutTests/ChangeLog	2012-02-07 22:08:07 UTC (rev 106990)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 22:18:29 UTC (rev 106991)
@@ -1,3 +1,18 @@
+2012-02-07  Eugene Girard  gir...@chromium.org
+
+IndexedDB createIndex should fail if options arg is invalid
+https://bugs.webkit.org/show_bug.cgi?id=58467
+
+Reviewed by Tony Chang.
+
+This ticket was fixed as part of https://bugs.webkit.org/show_bug.cgi?id=58471
+Adding unit tests to verify correct operation.
+
+* storage/indexeddb/index-basics-expected.txt:
+* storage/indexeddb/index-basics-workers-expected.txt:
+* storage/indexeddb/resources/index-basics.js:
+(deleteExisting):
+
 2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/storage/indexeddb/index-basics-expected.txt (106990 => 106991)

--- trunk/LayoutTests/storage/indexeddb/index-basics-expected.txt	2012-02-07 22:08:07 UTC (rev 106990)
+++ trunk/LayoutTests/storage/indexeddb/index-basics-expected.txt	2012-02-07 22:18:29 UTC (rev 106991)
@@ -14,6 +14,14 @@
 store.createIndex('indexName', 'x')
 store.createIndex('indexName2', 'y', {unique: false})
 store.createIndex('zIndex', 'z', {unique: true})
+PASS indexObject2.unique is false
+PASS indexObject3.unique is true
+Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', true)
+PASS Exception was thrown.
+PASS store.createIndex('failureIndex', 'zzz', true) threw TypeError: Not an object.
+Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', 'string')
+PASS Exception was thrown.
+PASS store.createIndex('failureIndex', 'zzz', 'string') threw TypeError: Not an object.
 PASS 'name' in indexObject is true
 PASS indexObject.name is indexName
 PASS 'objectStore' in indexObject is true


Modified: trunk/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt (106990 => 106991)

--- trunk/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt	2012-02-07 22:08:07 UTC (rev 106990)
+++ trunk/LayoutTests/storage/indexeddb/index-basics-workers-expected.txt	2012-02-07 22:18:29 UTC (rev 106991)
@@ -15,6 +15,14 @@
 [Worker] store.createIndex('indexName', 'x')
 [Worker] store.createIndex('indexName2', 'y', {unique: false})
 [Worker] store.createIndex('zIndex', 'z', {unique: true})
+PASS [Worker] indexObject2.unique is false
+PASS [Worker] indexObject3.unique is true
+[Worker] Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', true)
+PASS [Worker] Exception was thrown.
+PASS [Worker] store.createIndex('failureIndex', 'zzz', true) threw TypeError: Not an object.
+[Worker] Expecting TypeError exception from store.createIndex('failureIndex', 'zzz', 'string')
+PASS [Worker] Exception was thrown.
+PASS [Worker] store.createIndex('failureIndex', 'zzz', 'string') threw TypeError: Not an object.
 PASS [Worker] 'name' in indexObject is true
 PASS [Worker] indexObject.name is indexName
 PASS [Worker] 'objectStore' in indexObject is true


Modified: trunk/LayoutTests/storage/indexeddb/resources/index-basics.js (106990 => 106991)

--- trunk/LayoutTests/storage/indexeddb/resources/index-basics.js	2012-02-07 22:08:07 UTC (rev 106990)
+++ trunk/LayoutTests/storage/indexeddb/resources/index-basics.js	2012-02-07 22:18:29 UTC (rev 106991)
@@ -36,6 +36,10 @@
 self.indexObject = evalAndLog(store.createIndex('indexName', 'x'));
 self.indexObject2 = evalAndLog(store.createIndex('indexName2', 'y', {unique: false}));
 self.indexObject3 = evalAndLog(store.createIndex('zIndex', 'z', {unique: true}));
+shouldBeFalse(indexObject2.unique);
+shouldBeTrue(indexObject3.unique);
+evalAndExpectExceptionClass(store.createIndex('failureIndex', 'zzz', true), TypeError);
+evalAndExpectExceptionClass(store.createIndex('failureIndex', 'zzz', 'string'), TypeError);
 addData();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org

[webkit-changes] [106993] trunk/Source/WebKit

Title: [106993] trunk/Source/WebKit








Revision 106993
Author commit-qu...@webkit.org
Date 2012-02-07 14:52:27 -0800 (Tue, 07 Feb 2012)


Log Message
[BlackBerry] Upstream DumpRenderTreeSupport
https://bugs.webkit.org/show_bug.cgi?id=77991

Patch by Rob Buis rb...@rim.com on 2012-02-07
Reviewed by Antonio Gomes.

No functionalities changed, no new tests.

* blackberry/WebKitSupport/DumpRenderTreeSupport.cpp: Added.
(toGeolocationClientMock):
(DumpRenderTreeSupport::DumpRenderTreeSupport):
(DumpRenderTreeSupport::~DumpRenderTreeSupport):
(DumpRenderTreeSupport::_javascript_ObjectsCount):
(DumpRenderTreeSupport::garbageCollectorCollect):
(DumpRenderTreeSupport::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupport::setLinksIncludedInFocusChain):
(DumpRenderTreeSupport::linksIncludedInFocusChain):
(DumpRenderTreeSupport::dumpConfigurationForViewport):
(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
(DumpRenderTreeSupport::resetGeolocationMock):
(DumpRenderTreeSupport::setMockGeolocationError):
(DumpRenderTreeSupport::setMockGeolocationPermission):
(DumpRenderTreeSupport::setMockGeolocationPosition):
(DumpRenderTreeSupport::scalePageBy):
(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
* blackberry/WebKitSupport/DumpRenderTreeSupport.h: Added.
(WebKit):
(WebCore):
(WTF):
(DumpRenderTreeSupport):

Modified Paths

trunk/Source/WebKit/ChangeLog


Added Paths

trunk/Source/WebKit/blackberry/WebKitSupport/
trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (106992 => 106993)

--- trunk/Source/WebKit/ChangeLog	2012-02-07 22:20:25 UTC (rev 106992)
+++ trunk/Source/WebKit/ChangeLog	2012-02-07 22:52:27 UTC (rev 106993)
@@ -1,3 +1,35 @@
+2012-02-07  Rob Buis  rb...@rim.com
+
+[BlackBerry] Upstream DumpRenderTreeSupport
+https://bugs.webkit.org/show_bug.cgi?id=77991
+
+Reviewed by Antonio Gomes.
+
+No functionalities changed, no new tests.
+
+* blackberry/WebKitSupport/DumpRenderTreeSupport.cpp: Added.
+(toGeolocationClientMock):
+(DumpRenderTreeSupport::DumpRenderTreeSupport):
+(DumpRenderTreeSupport::~DumpRenderTreeSupport):
+(DumpRenderTreeSupport::_javascript_ObjectsCount):
+(DumpRenderTreeSupport::garbageCollectorCollect):
+(DumpRenderTreeSupport::garbageCollectorCollectOnAlternateThread):
+(DumpRenderTreeSupport::setLinksIncludedInFocusChain):
+(DumpRenderTreeSupport::linksIncludedInFocusChain):
+(DumpRenderTreeSupport::dumpConfigurationForViewport):
+(DumpRenderTreeSupport::numberOfPendingGeolocationPermissionRequests):
+(DumpRenderTreeSupport::resetGeolocationMock):
+(DumpRenderTreeSupport::setMockGeolocationError):
+(DumpRenderTreeSupport::setMockGeolocationPermission):
+(DumpRenderTreeSupport::setMockGeolocationPosition):
+(DumpRenderTreeSupport::scalePageBy):
+(DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
+* blackberry/WebKitSupport/DumpRenderTreeSupport.h: Added.
+(WebKit):
+(WebCore):
+(WTF):
+(DumpRenderTreeSupport):
+
 2012-02-07  Jacky Jiang  zhaji...@rim.com
 
 [BlackBerry] Upstream BlackBerry WebCoreSupport DeviceOrientationClientBlackBerry and DeviceMotionClientBlackBerry classes


Added: trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.cpp (0 => 106993)

--- trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.cpp	(rev 0)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.cpp	2012-02-07 22:52:27 UTC (rev 106993)
@@ -0,0 +1,166 @@
+/*
+ * Copyright (C) 2012 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include config.h
+#include DumpRenderTreeSupport.h
+
+#include CSSComputedStyleDeclaration.h
+#include Frame.h
+#include GeolocationClientMock.h
+#include GeolocationController.h
+#include GeolocationError.h
+#include GeolocationPosition.h
+#include JSCSSStyleDeclaration.h
+#include JSElement.h
+#include Page.h
+#include ViewportArguments.h
+#include WebPage.h

[webkit-changes] [106994] trunk/Source/WebKit/chromium

Title: [106994] trunk/Source/WebKit/chromium








Revision 106994
Author commit-qu...@webkit.org
Date 2012-02-07 15:03:10 -0800 (Tue, 07 Feb 2012)


Log Message
[chromium] Unit test for bug #77996
https://bugs.webkit.org/show_bug.cgi?id=78019

Patch by Dana Jansens dan...@chromium.org on 2012-02-07
Reviewed by James Robinson.

* tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::afterTest):
(WTF):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (106993 => 106994)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-02-07 22:52:27 UTC (rev 106993)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-02-07 23:03:10 UTC (rev 106994)
@@ -1,3 +1,17 @@
+2012-02-07  Dana Jansens  dan...@chromium.org
+
+[chromium] Unit test for bug #77996
+https://bugs.webkit.org/show_bug.cgi?id=78019
+
+Reviewed by James Robinson.
+
+* tests/CCLayerTreeHostTest.cpp:
+(CCLayerTreeHostTestManySurfaces):
+(WTF::CCLayerTreeHostTestManySurfaces::CCLayerTreeHostTestManySurfaces):
+(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
+(WTF::CCLayerTreeHostTestManySurfaces::afterTest):
+(WTF):
+
 2012-02-07  Sadrul Habib Chowdhury  sad...@chromium.org
 
 Process Scroll-gesture events from the compositor.


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp (106993 => 106994)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2012-02-07 22:52:27 UTC (rev 106993)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp	2012-02-07 23:03:10 UTC (rev 106994)
@@ -1472,4 +1472,61 @@
 
 SINGLE_AND_MULTI_THREAD_TEST_F(CCLayerTreeHostTestLayerOcclusion)
 
+class CCLayerTreeHostTestManySurfaces : public CCLayerTreeHostTest {
+public:
+CCLayerTreeHostTestManySurfaces() { }
+
+virtual void beginTest()
+{
+// We create enough RenderSurfaces that it will trigger Vector reallocation while computing occlusion.
+Region occluded;
+const TransformationMatrix identityMatrix;
+VectorRefPtrTestLayerChromium  layers;
+VectorRefPtrTestLayerChromium  children;
+int numSurfaces = 20;
+RefPtrTestLayerChromium replica = TestLayerChromium::create();
+
+for (int i = 0; i  numSurfaces; ++i) {
+layers.append(TestLayerChromium::create());
+if (!i) {
+setLayerPropertiesForTesting(layers.last().get(), 0, identityMatrix, FloatPoint(0, 0), FloatPoint(0, 0), IntSize(100, 100), true);
+layers.last()-createRenderSurface();
+} else {
+setLayerPropertiesForTesting(layers.last().get(), layers[layers.size()-2].get(), identityMatrix, FloatPoint(0, 0), FloatPoint(1, 1), IntSize(100-i, 100-i), true);
+layers.last()-setMasksToBounds(true);
+layers.last()-setReplicaLayer(replica.get()); // Make it have a RenderSurface
+}
+}
+
+for (int i = 1; i  numSurfaces; ++i) {
+children.append(TestLayerChromium::create());
+setLayerPropertiesForTesting(children.last().get(), layers[i].get(), identityMatrix, FloatPoint(0, 0), FloatPoint(0, 0), IntSize(500, 500), false);
+}
+
+m_layerTreeHost-setRootLayer(layers[0].get());
+m_layerTreeHost-setViewportSize(layers[0]-bounds());
+m_layerTreeHost-updateLayers();
+m_layerTreeHost-commitComplete();
+
+for (int i = 0; i  numSurfaces-1; ++i) {
+IntRect expectedOcclusion(i+1, i+1, 100-i-1, 100-i-1);
+
+EXPECT_EQ_RECT(expectedOcclusion, layers[i]-occludedScreenSpace().bounds());
+EXPECT_EQ(1u, layers[i]-occludedScreenSpace().rects().size());
+}
+
+// Kill the layerTreeHost immediately.
+m_layerTreeHost-setRootLayer(0);
+m_layerTreeHost.clear();
+
+endTest();
+}
+
+virtual void afterTest()
+{
+}
+};
+
+SINGLE_AND_MULTI_THREAD_TEST_F(CCLayerTreeHostTestManySurfaces)
+
 } // namespace






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106995] trunk/LayoutTests

Title: [106995] trunk/LayoutTests








Revision 106995
Author jchaffr...@webkit.org
Date 2012-02-07 15:07:47 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed gardening after r106982.

* platform/chromium/test_expectations.txt:
We don't have at least one of the layoutTestController
functions used in this test so we are receiving an
exception and timing out.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (106994 => 106995)

--- trunk/LayoutTests/ChangeLog	2012-02-07 23:03:10 UTC (rev 106994)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 23:07:47 UTC (rev 106995)
@@ -1,3 +1,12 @@
+2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening after r106982.
+
+* platform/chromium/test_expectations.txt:
+We don't have at least one of the layoutTestController
+functions used in this test so we are receiving an
+exception and timing out.
+
 2012-02-07  Eugene Girard  gir...@chromium.org
 
 IndexedDB createIndex should fail if options arg is invalid


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (106994 => 106995)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 23:03:10 UTC (rev 106994)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-07 23:07:47 UTC (rev 106995)
@@ -3287,6 +3287,7 @@
 BUGWK66419 : http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html = TEXT
 BUGWK66419 : http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html = TEXT
 BUGWK66419 : http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html = TEXT TIMEOUT
+BUGWK66419 : http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html = TEXT TIMEOUT
 
 BUGV8_1634 : fast/js/const.html = TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106996] trunk/Source/WebCore

2012-02-07 Thread jer . noble

Title: [106996] trunk/Source/WebCore








Revision 106996
Author jer.no...@apple.com
Date 2012-02-07 15:12:27 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.

* platform/mac/PlatformClockCM.mm:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/PlatformClockCM.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (106995 => 106996)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 23:07:47 UTC (rev 106995)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 23:12:27 UTC (rev 106996)
@@ -1,3 +1,9 @@
+2012-02-07  Jer Noble  jer.no...@apple.com
+
+Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.
+
+* platform/mac/PlatformClockCM.mm:
+
 2012-02-07  James Robinson  jam...@chromium.org
 
 [chromium] Allow retaining texture across frames in composited video playback and correctly handle lost context


Modified: trunk/Source/WebCore/platform/mac/PlatformClockCM.mm (106995 => 106996)

--- trunk/Source/WebCore/platform/mac/PlatformClockCM.mm	2012-02-07 23:07:47 UTC (rev 106995)
+++ trunk/Source/WebCore/platform/mac/PlatformClockCM.mm	2012-02-07 23:12:27 UTC (rev 106996)
@@ -35,11 +35,11 @@
 
 SOFT_LINK_FRAMEWORK_OPTIONAL(CoreMedia)
 
-SOFT_LINK(CoreMedia, CMAudioDeviceClockCreate, int32_t, (CFAllocatorRef allocator, CFStringRef deviceUID, CMClockRef *clockOut), (allocator, deviceUID, clockOut))
-SOFT_LINK(CoreMedia, CMTimebaseCreateWithMasterClock, int32_t, (CFAllocatorRef allocator, CMClockRef masterClock, CMTimebaseRef *timebaseOut), (allocator, masterClock, timebaseOut))
-SOFT_LINK(CoreMedia, CMTimebaseSetTime, int32_t, (CMTimebaseRef timebase, CMTime time), (timebase, time))
+SOFT_LINK(CoreMedia, CMAudioDeviceClockCreate, OSStatus, (CFAllocatorRef allocator, CFStringRef deviceUID, CMClockRef *clockOut), (allocator, deviceUID, clockOut))
+SOFT_LINK(CoreMedia, CMTimebaseCreateWithMasterClock, OSStatus, (CFAllocatorRef allocator, CMClockRef masterClock, CMTimebaseRef *timebaseOut), (allocator, masterClock, timebaseOut))
+SOFT_LINK(CoreMedia, CMTimebaseSetTime, OSStatus, (CMTimebaseRef timebase, CMTime time), (timebase, time))
 SOFT_LINK(CoreMedia, CMTimebaseGetTime, CMTime, (CMTimebaseRef timebase), (timebase))
-SOFT_LINK(CoreMedia, CMTimebaseSetRate, int32_t, (CMTimebaseRef timebase, Float64 rate), (timebase, rate))
+SOFT_LINK(CoreMedia, CMTimebaseSetRate, OSStatus, (CMTimebaseRef timebase, Float64 rate), (timebase, rate))
 SOFT_LINK(CoreMedia, CMTimeMakeWithSeconds, CMTime, (Float64 seconds, int32_t preferredTimeScale), (seconds, preferredTimeScale))
 SOFT_LINK(CoreMedia, CMTimeGetSeconds, Float64, (CMTime time), (time))
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106997] trunk/Source/WebCore

Title: [106997] trunk/Source/WebCore








Revision 106997
Author commit-qu...@webkit.org
Date 2012-02-07 15:29:58 -0800 (Tue, 07 Feb 2012)


Log Message
[Chromium] Crash when using per-tile painting on Windows.
https://bugs.webkit.org/show_bug.cgi?id=75715

Patch by David Reveman reve...@chromium.org on 2012-02-07
Reviewed by James Robinson.

PlatformCanvas constructor on win32 expects forth argument to be a
shared section handle. Passing a pointer to a system memory causes
it to crash. Fix this by not using the PlatformCanvas API for
SkCanvas construction in per-tile texture uploader.

Tested with manual tests.

* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
(Texture):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp
trunk/Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (106996 => 106997)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 23:12:27 UTC (rev 106996)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 23:29:58 UTC (rev 106997)
@@ -1,3 +1,23 @@
+2012-02-07  David Reveman  reve...@chromium.org
+
+[Chromium] Crash when using per-tile painting on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=75715
+
+Reviewed by James Robinson.
+
+PlatformCanvas constructor on win32 expects forth argument to be a
+shared section handle. Passing a pointer to a system memory causes
+it to crash. Fix this by not using the PlatformCanvas API for
+SkCanvas construction in per-tile texture uploader.
+
+Tested with manual tests.
+
+* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
+(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect):
+(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
+* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
+(Texture):
+
 2012-02-07  Jer Noble  jer.no...@apple.com
 
 Unreviewed build fix; make OSStatus the explicit return type for CMTimebase functions.


Modified: trunk/Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp (106996 => 106997)

--- trunk/Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp	2012-02-07 23:12:27 UTC (rev 106996)
+++ trunk/Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp	2012-02-07 23:29:58 UTC (rev 106997)
@@ -33,7 +33,7 @@
 
 #include LayerPainterChromium.h
 #include SkCanvas.h
-#include skia/ext/platform_canvas.h
+#include SkDevice.h
 
 namespace WebCore {
 
@@ -45,18 +45,21 @@
 
 void BitmapSkPictureCanvasLayerTextureUpdater::Texture::prepareRect(const IntRect sourceRect)
 {
-size_t bufferSize = TextureManager::memoryUseBytes(sourceRect.size(), texture()-format());
-m_pixelData = adoptArrayPtr(new uint8_t[bufferSize]);
-OwnPtrSkCanvas canvas = adoptPtr(new skia::PlatformCanvas(sourceRect.width(), sourceRect.height(), false, m_pixelData.get()));
+m_device = adoptPtr(new SkDevice(SkBitmap::kARGB__Config, sourceRect.width(), sourceRect.height()));
+OwnPtrSkCanvas canvas = adoptPtr(new SkCanvas(m_device.get()));
 textureUpdater()-paintContentsRect(canvas.get(), sourceRect);
 }
 
 void BitmapSkPictureCanvasLayerTextureUpdater::Texture::updateRect(GraphicsContext3D* context, TextureAllocator* allocator, const IntRect sourceRect, const IntRect destRect)
 {
 texture()-bindTexture(context, allocator);
-ASSERT(m_pixelData.get());
-textureUpdater()-updateTextureRect(context, texture()-format(), destRect, m_pixelData.get());
-m_pixelData.clear();
+
+ASSERT(m_device);
+const SkBitmap* bitmap = m_device-accessBitmap(false);
+bitmap-lockPixels();
+textureUpdater()-updateTextureRect(context, texture()-format(), destRect, static_castuint8_t*(bitmap-getPixels()));
+bitmap-unlockPixels();
+m_device.clear();
 }
 
 PassRefPtrBitmapSkPictureCanvasLayerTextureUpdater BitmapSkPictureCanvasLayerTextureUpdater::create(PassOwnPtrLayerPainterChromium painter, bool useMapTexSubImage)


Modified: trunk/Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h (106996 => 106997)

--- trunk/Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h	2012-02-07 23:12:27 UTC (rev 106996)
+++ trunk/Source/WebCore/platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h	2012-02-07 23:29:58 UTC (rev 106997)
@@ -34,6 +34,8 @@
 #include PlatformColor.h
 #include SkPictureCanvasLayerTextureUpdater.h
 
+class SkDevice;
+
 namespace WebCore {

[webkit-changes] [106998] trunk/Source/WebCore

Title: [106998] trunk/Source/WebCore








Revision 106998
Author hara...@chromium.org
Date 2012-02-07 15:38:19 -0800 (Tue, 07 Feb 2012)


Log Message
[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=77957

Reviewed by Adam Barth.

This patch replaces IsSubType(WorkerContext) and something equivalent that
with the [IsWorkerContext] IDL.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GetInternalFields):
(GenerateConstructorGetter):
(GenerateImplementation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (106997 => 106998)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 23:29:58 UTC (rev 106997)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 23:38:19 UTC (rev 106998)
@@ -1,3 +1,20 @@
+2012-02-07  Kentaro Hara  hara...@chromium.org
+
+[Refactoring] Use the [IsWorkerContext] IDL in CodeGeneratorV8.pm
+https://bugs.webkit.org/show_bug.cgi?id=77957
+
+Reviewed by Adam Barth.
+
+This patch replaces IsSubType(WorkerContext) and something equivalent that
+with the [IsWorkerContext] IDL.
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GetInternalFields):
+(GenerateConstructorGetter):
+(GenerateImplementation):
+
 2012-02-07  David Reveman  reve...@chromium.org
 
 [Chromium] Crash when using per-tile painting on Windows.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (106997 => 106998)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-02-07 23:29:58 UTC (rev 106997)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-02-07 23:38:19 UTC (rev 106998)
@@ -505,17 +505,17 @@
 {
 my $dataNode = shift;
 my $name = $dataNode-name;
-
+
 my @customInternalFields = ();
- 
-# We can't ask whether a parent type has a given extendedAttribute, so special-case AbstractWorker and WorkerContext to include all sub-types.
+# We can't ask whether a parent type has a given extendedAttribute,
+# so special-case AbstractWorker and WorkerContext to include all sub-types.
 # Event listeners on DOM nodes are explicitly supported in the GC controller.
 # FIXME: SVGElementInstance should probably have the EventTarget extended attribute, but doesn't.
-if (!IsNodeSubType($dataNode) 
-($dataNode-extendedAttributes-{EventTarget} ||
- IsSubType($dataNode, AbstractWorker) ||
- IsSubType($dataNode, WorkerContext) ||
- $name eq SVGElementInstance)) {
+if (!IsNodeSubType($dataNode)
+ ($dataNode-extendedAttributes-{EventTarget}
+|| $dataNode-extendedAttributes-{IsWorkerContext}
+|| IsSubType($dataNode, AbstractWorker)
+|| $name eq SVGElementInstance)) {
 push(@customInternalFields, eventListenerCacheIndex);
 }
 
@@ -735,6 +735,7 @@
 
 sub GenerateConstructorGetter
 {
+my $dataNode = shift;
 my $implClassName = shift;
 
 push(@implContentDecls, END);
@@ -753,7 +754,7 @@
 // context of the DOMWindow and not in the context of the caller.
 return V8DOMWrapper::getConstructor(type, V8DOMWindow::toNative(info.Holder()));
 END
-} elsif ($implClassName eq DedicatedWorkerContext or $implClassName eq WorkerContext or $implClassName eq SharedWorkerContext) {
+} elsif ($dataNode-extendedAttributes-{IsWorkerContext}) {
 push(@implContentDecls, END);
 return V8DOMWrapper::getConstructor(type, V8WorkerContext::toNative(info.Holder()));
 END
@@ -2310,7 +2311,7 @@
 }
 
 if ($hasConstructors) {
-GenerateConstructorGetter($implClassName);
+GenerateConstructorGetter($dataNode, $implClassName);
 }
 
 my $indexer;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [106999] trunk/Source/JavaScriptCore

2012-02-07 Thread barraclough

Title: [106999] trunk/Source/_javascript_Core








Revision 106999
Author barraclo...@apple.com
Date 2012-02-07 15:43:28 -0800 (Tue, 07 Feb 2012)


Log Message
Crash on http://www.rickshawbags.com/
https://bugs.webkit.org/show_bug.cgi?id=78045

Reviewed by Darin Adler.

Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()

This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
isVariableObject() checks were excluding StaticScopeObjects, this patch
inadvertently changed them to be included.

* runtime/JSType.h:
- sort JSType enum such that StaticScopeObjectType comes before VariableObjectType,
  and thus is excluded from isVariableObject() checks.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSType.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (106998 => 106999)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-07 23:38:19 UTC (rev 106998)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-07 23:43:28 UTC (rev 106999)
@@ -1,3 +1,20 @@
+2012-02-07  Gavin Barraclough  barraclo...@apple.com
+
+Crash on http://www.rickshawbags.com/
+https://bugs.webkit.org/show_bug.cgi?id=78045
+
+Reviewed by Darin Adler.
+
+Problem URL is: http://www.rickshawbags.com/customize/custom-bag#!thl=rickshaw/bag()
+
+This is a bug introduced by https://bugs.webkit.org/show_bug.cgi?id=71933,
+isVariableObject() checks were excluding StaticScopeObjects, this patch
+inadvertently changed them to be included.
+
+* runtime/JSType.h:
+- sort JSType enum such that StaticScopeObjectType comes before VariableObjectType,
+  and thus is excluded from isVariableObject() checks.
+
 2012-02-06  Jer Noble  jer.no...@apple.com
 
 Use CMClock as a timing source for PlatformClock where available.


Modified: trunk/Source/_javascript_Core/runtime/JSType.h (106998 => 106999)

--- trunk/Source/_javascript_Core/runtime/JSType.h	2012-02-07 23:38:19 UTC (rev 106998)
+++ trunk/Source/_javascript_Core/runtime/JSType.h	2012-02-07 23:43:28 UTC (rev 106999)
@@ -49,11 +49,12 @@
 ErrorInstanceType,
 GlobalThisType,
 
-// VariableObjectType must come before all of the types of its subclasses and only its subclasses.
+StaticScopeObjectType,
+// VariableObjectType must be less than MOST of the types of its subclasses and only its subclasses.
+// We use =VariableObjectType checks to test for Global  Activation objects, but exclude StaticScopes.
 VariableObjectType,
 GlobalObjectType,
 ActivationObjectType,
-StaticScopeObjectType,
 };
 
 } // namespace JSC






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107000] trunk

2012-02-07 Thread leviw

Title: [107000] trunk








Revision 107000
Author le...@chromium.org
Date 2012-02-07 15:46:40 -0800 (Tue, 07 Feb 2012)


Log Message
unicode-bidi:plaintext is supposed to be effective on display:inline elements too
https://bugs.webkit.org/show_bug.cgi?id=73310

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for unicode-bidi: plaintext as a property on inlines. These are treated
like unicode-bidi: isolate with the addition of their directionality being determined
by the UBA.

Tests: fast/text/international/inline-plaintext-is-isolated-expected.html
   fast/text/international/inline-plaintext-is-isolated.html
   fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
   fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
   fast/text/international/inline-plaintext-with-generated-content-expected.html
   fast/text/international/inline-plaintext-with-generated-content.html

* platform/text/UnicodeBidi.h:
(WebCore::isIsolated): Added this convenience function as Plaintext and Isolate Unicode-Bidi values
are both treated as isolated content.
* rendering/InlineIterator.h:
(WebCore::notifyObserverEnteredObject): Inline now supports Unicode-Bidi Plaintext.
(WebCore::notifyObserverWillExitObject): Ditto.
(WebCore::bidiFirstSkippingEmptyInlines): Changed to support being called without a resolver.
(WebCore::isIsolatedInline): Inline now supports Unicode-Bidi: Plaintext.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::determineDirectionality): Generalized for inlines.
(WebCore::constructBidiRuns): Added support for Unicode-Bidi: Plaintext as an isolated inline.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Fixed comment.
(WebCore::RenderBlock::determineStartPosition): Fixed comment and switched to updated
bidiFirstSkippingEmptyInlines.

LayoutTests:

Ref tests for unicode-bidi: plaintext on inlines.

* fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
* fast/text/international/inline-plaintext-is-isolated.html: Added.
* fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
* fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
* fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
* fast/text/international/inline-plaintext-with-generated-content.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/UnicodeBidi.h
trunk/Source/WebCore/rendering/InlineIterator.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/text/international/inline-plaintext-is-isolated-expected.html
trunk/LayoutTests/fast/text/international/inline-plaintext-is-isolated.html
trunk/LayoutTests/fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html
trunk/LayoutTests/fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html
trunk/LayoutTests/fast/text/international/inline-plaintext-with-generated-content-expected.html
trunk/LayoutTests/fast/text/international/inline-plaintext-with-generated-content.html




Diff

Modified: trunk/LayoutTests/ChangeLog (106999 => 107000)

--- trunk/LayoutTests/ChangeLog	2012-02-07 23:43:28 UTC (rev 106999)
+++ trunk/LayoutTests/ChangeLog	2012-02-07 23:46:40 UTC (rev 107000)
@@ -1,3 +1,19 @@
+2012-02-07  Levi Weintraub  le...@chromium.org
+
+unicode-bidi:plaintext is supposed to be effective on display:inline elements too
+https://bugs.webkit.org/show_bug.cgi?id=73310
+
+Reviewed by Eric Seidel.
+
+Ref tests for unicode-bidi: plaintext on inlines.
+
+* fast/text/international/inline-plaintext-is-isolated-expected.html: Added.
+* fast/text/international/inline-plaintext-is-isolated.html: Added.
+* fast/text/international/inline-plaintext-relayout-with-leading-neutrals-expected.html: Added.
+* fast/text/international/inline-plaintext-relayout-with-leading-neutrals.html: Added.
+* fast/text/international/inline-plaintext-with-generated-content-expected.html: Added.
+* fast/text/international/inline-plaintext-with-generated-content.html: Added.
+
 2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed gardening after r106982.


Added: trunk/LayoutTests/fast/text/international/inline-plaintext-is-isolated-expected.html (0 => 107000)

--- trunk/LayoutTests/fast/text/international/inline-plaintext-is-isolated-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/international/inline-plaintext-is-isolated-expected.html	2012-02-07 23:46:40 UTC (rev 107000)
@@ -0,0 +1,22 @@
+!DOCTYPE HTML
+htmlhead
+meta http-equiv=Content-Type content=text/html;charset=utf-8
+style
+  .border {
+border: solid thin gray;
+  }
+/style
+/headbody
+  table
+tr
+  td class=border1 span dir=rtl#x05D0;!/spanlrm; 2/td
+  tdshould look

[webkit-changes] [107001] trunk/Source/WebCore

Title: [107001] trunk/Source/WebCore








Revision 107001
Author ander...@apple.com
Date 2012-02-07 15:47:59 -0800 (Tue, 07 Feb 2012)


Log Message
Scrolling tree should keep track of region we can't do fast scrolling for
https://bugs.webkit.org/show_bug.cgi?id=78050

Reviewed by Dan Bernstein.

We currently won't do fast scrolling for subframes and other types of scrollable areas.
Because of this, we'll have the scrolling tree keep a region of the page for which we can't
do fast scrolling. This region will be updated after layout.

* page/FrameView.cpp:
(WebCore::FrameView::scrollableAreaBoundingBox):
Return the bounding box.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Go through all the scrollable areas in this frame view and compute the region which we can't do
fast scrolling for.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
Update the non-fast-scrollable region.

* page/scrolling/ScrollingTreeState.cpp:
(WebCore::ScrollingTreeState::setNonFastScrollableRegion):
Set the non-fast-scrollable region if it's changed.

* platform/ScrollableArea.h:
Add scrollableAreaBoundingBox member function.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollableAreaBoundingBox):
Return the bounding box.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollableAreaBoundingBox):
Return the bounding box.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTree.h
trunk/Source/WebCore/page/scrolling/ScrollingTreeState.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTreeState.h
trunk/Source/WebCore/platform/ScrollableArea.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (107000 => 107001)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 23:46:40 UTC (rev 107000)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 23:47:59 UTC (rev 107001)
@@ -1,3 +1,42 @@
+2012-02-07  Anders Carlsson  ander...@apple.com
+
+Scrolling tree should keep track of region we can't do fast scrolling for
+https://bugs.webkit.org/show_bug.cgi?id=78050
+
+Reviewed by Dan Bernstein.
+
+We currently won't do fast scrolling for subframes and other types of scrollable areas.
+Because of this, we'll have the scrolling tree keep a region of the page for which we can't
+do fast scrolling. This region will be updated after layout.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::scrollableAreaBoundingBox):
+Return the bounding box.
+
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
+Go through all the scrollable areas in this frame view and compute the region which we can't do
+fast scrolling for.
+
+* page/scrolling/ScrollingTree.cpp:
+(WebCore::ScrollingTree::commitNewTreeState):
+Update the non-fast-scrollable region.
+
+* page/scrolling/ScrollingTreeState.cpp:
+(WebCore::ScrollingTreeState::setNonFastScrollableRegion):
+Set the non-fast-scrollable region if it's changed.
+
+* platform/ScrollableArea.h:
+Add scrollableAreaBoundingBox member function.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::scrollableAreaBoundingBox):
+Return the bounding box.
+
+* rendering/RenderListBox.cpp:
+(WebCore::RenderListBox::scrollableAreaBoundingBox):
+Return the bounding box.
+
 2012-02-07  Levi Weintraub  le...@chromium.org
 
 unicode-bidi:plaintext is supposed to be effective on display:inline elements too


Modified: trunk/Source/WebCore/page/FrameView.cpp (107000 => 107001)

--- trunk/Source/WebCore/page/FrameView.cpp	2012-02-07 23:46:40 UTC (rev 107000)
+++ trunk/Source/WebCore/page/FrameView.cpp	2012-02-07 23:47:59 UTC (rev 107001)
@@ -2549,6 +2549,12 @@
 return 0;
 }
 
+IntRect FrameView::scrollableAreaBoundingBox() const
+{
+// FIXME: This isn't correct for transformed frames. We probably need to ask the renderer instead.
+return frameRect();
+}
+
 bool FrameView::shouldSuspendScrollAnimations() const
 {
 return m_frame-loader()-state() != FrameStateComplete;


Modified: trunk/Source/WebCore/page/FrameView.h (107000 => 107001)

--- trunk/Source/WebCore/page/FrameView.h	2012-02-07 23:46:40 UTC (rev 107000)
+++ trunk/Source/WebCore/page/FrameView.h	2012-02-07 23:47:59 UTC (rev 107001)
@@ -371,6 +371,7 @@
 virtual void setVisibleScrollerThumbRect(const IntRect);
 virtual bool isOnActivePage() const;
 virtual ScrollableArea*

[webkit-changes] [107002] trunk/Source/WebCore

2012-02-07 Thread jer . noble

Title: [107002] trunk/Source/WebCore








Revision 107002
Author jer.no...@apple.com
Date 2012-02-07 15:53:02 -0800 (Tue, 07 Feb 2012)


Log Message
media/audio-data-url.html test broken on Lion
https://bugs.webkit.org/show_bug.cgi?id=69779

Reviewed by Eric Carlson.

Do not use OpenForPlayback attribute on data:// urls, as CoreMedia/QuickTime X cannot
handle those URLs.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (107001 => 107002)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 23:47:59 UTC (rev 107001)
+++ trunk/Source/WebCore/ChangeLog	2012-02-07 23:53:02 UTC (rev 107002)
@@ -1,3 +1,16 @@
+2011-10-10  Jer Noble  jer.no...@apple.com
+
+media/audio-data-url.html test broken on Lion
+https://bugs.webkit.org/show_bug.cgi?id=69779
+
+Reviewed by Eric Carlson.
+
+Do not use OpenForPlayback attribute on data:// urls, as CoreMedia/QuickTime X cannot
+handle those URLs.
+
+* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
+(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
+
 2012-02-07  Anders Carlsson  ander...@apple.com
 
 Scrolling tree should keep track of region we can't do fast scrolling for


Modified: trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm (107001 => 107002)

--- trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm	2012-02-07 23:47:59 UTC (rev 107001)
+++ trunk/Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm	2012-02-07 23:53:02 UTC (rev 107002)
@@ -259,7 +259,8 @@
 
 void MediaPlayerPrivateQTKit::createQTMovie(const String url)
 {
-NSURL *cocoaURL = KURL(ParsedURLString, url);
+KURL kURL(ParsedURLString, url);
+NSURL *cocoaURL = kURL;
 NSMutableDictionary *movieAttributes = commonMovieAttributes();
 [movieAttributes setValue:cocoaURL forKey:QTMovieURLAttribute];
 
@@ -282,9 +283,9 @@
 willUseProxy = NO;
 }
 
-if (!willUseProxy) {
+if (!willUseProxy  !kURL.protocolIsData()) {
 // Only pass the QTMovieOpenForPlaybackAttribute flag if there are no proxy servers, due
-// to rdar://problem/7531776.
+// to rdar://problem/7531776, or if not loading a data:// url due to rdar://problem/8103801.
 [movieAttributes setObject:[NSNumber numberWithBool:YES] forKey:@QTMovieOpenForPlaybackAttribute];
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107004] trunk/Source/WebCore

Title: [107004] trunk/Source/WebCore








Revision 107004
Author hara...@chromium.org
Date 2012-02-07 16:00:18 -0800 (Tue, 07 Feb 2012)


Log Message
Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=77973

Reviewed by Adam Barth.

This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
attributes should be prefixed by V8.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (107003 => 107004)

--- trunk/Source/WebCore/ChangeLog	2012-02-07 23:58:33 UTC (rev 107003)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 00:00:18 UTC (rev 107004)
@@ -1,3 +1,21 @@
+2012-02-07  Kentaro Hara  hara...@chromium.org
+
+Rename [v8OnProto] IDL attribute to [V8OnProto] IDL attribute
+https://bugs.webkit.org/show_bug.cgi?id=77973
+
+Reviewed by Adam Barth.
+
+This patch renames [v8OnProto] to [V8OnProto], since V8 specific IDL
+attributes should be prefixed by V8.
+
+No tests. No change in behavior.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrGetter):
+(GenerateNormalAttrSetter):
+(GenerateSingleBatchedAttribute):
+(GenerateImplementation):
+
 2011-10-10  Jer Noble  jer.no...@apple.com
 
 media/audio-data-url.html test broken on Lion


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (107003 => 107004)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-02-07 23:58:33 UTC (rev 107003)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-02-08 00:00:18 UTC (rev 107004)
@@ -810,7 +810,7 @@
 END
 }
 }
-} elsif ($attrExt-{v8OnProto} || $attrExt-{V8Unforgeable}) {
+} elsif ($attrExt-{V8OnProto} || $attrExt-{V8Unforgeable}) {
 if ($interfaceName eq DOMWindow) {
 push(@implContentDecls, END);
 v8::Handlev8::Object holder = info.Holder();
@@ -1054,7 +1054,7 @@
 push(@implContentDecls, $svgWrappedNativeType impInstance = wrapper-propertyReference();\n);
 push(@implContentDecls, $svgWrappedNativeType* imp = impInstance;\n);
 }
-} elsif ($attrExt-{v8OnProto}) {
+} elsif ($attrExt-{V8OnProto}) {
   if ($interfaceName eq DOMWindow) {
 push(@implContentDecls, END);
 v8::Handlev8::Object holder = info.Holder();
@@ -2030,7 +2030,7 @@
 }
 
 # An accessor can be installed on the proto
-if ($attrExt-{v8OnProto}) {
+if ($attrExt-{V8OnProto}) {
 $_on_proto_ = 1 /* on proto */;
 }
 
@@ -2281,7 +2281,7 @@
 }
 
 if ($attrType eq EventListener  $interfaceName eq DOMWindow) {
-$attribute-signature-extendedAttributes-{v8OnProto} = 1;
+$attribute-signature-extendedAttributes-{V8OnProto} = 1;
 }
 
 if ($attrType eq SerializedScriptValue) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107005] trunk

2012-02-07 Thread leviw

Title: [107005] trunk








Revision 107005
Author le...@chromium.org
Date 2012-02-07 16:14:42 -0800 (Tue, 07 Feb 2012)


Log Message
[SVG] Use element disappears after scripted change
https://bugs.webkit.org/show_bug.cgi?id=74392

Reviewed by Eric Seidel.

Source/WebCore:

Solution uncovered by Nikolas Zimmermann. Removing an early return that caused
SVGUseElements to not update the shadow root's style, and therefor not render
correctly.

Test: svg/custom/use-disappears-after-style-update.svg

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::didRecalcStyle):

LayoutTests:

* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* svg/custom/use-disappears-after-style-update.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGUseElement.cpp


Added Paths

trunk/LayoutTests/platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png
trunk/LayoutTests/platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt
trunk/LayoutTests/svg/custom/use-disappears-after-style-update.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (107004 => 107005)

--- trunk/LayoutTests/ChangeLog	2012-02-08 00:00:18 UTC (rev 107004)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 00:14:42 UTC (rev 107005)
@@ -1,5 +1,16 @@
 2012-02-07  Levi Weintraub  le...@chromium.org
 
+[SVG] Use element disappears after scripted change
+https://bugs.webkit.org/show_bug.cgi?id=74392
+
+Reviewed by Eric Seidel.
+
+* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
+* platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.txt: Added.
+* svg/custom/use-disappears-after-style-update.svg: Added.
+
+2012-02-07  Levi Weintraub  le...@chromium.org
+
 unicode-bidi:plaintext is supposed to be effective on display:inline elements too
 https://bugs.webkit.org/show_bug.cgi?id=73310
 


Added: trunk/LayoutTests/platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png (0 => 107005)

--- trunk/LayoutTests/platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png	(rev 0)
+++ trunk/LayoutTests/platform/mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png	2012-02-08 00:14:42 UTC (rev 107005)
@@ -0,0 +1,78 @@
+\x89PNG
+
+
+IHDR X\x9Av\x82p)tEXtchecksum1d1d349081904a94f21b0a92c10a6c7e@Ro IDATx\xED\xDDA
+\xC20\x84Q#\xDE[y,\x9E \x8B\xF2\xE3\xAF\xEBb\x867\xD9]\xB8\xF6\xF5 @\x80x\x9C\xE1 @\x80\xFC\x81 @\x80\x811d\x8C\xDAA @\x80 \xEE @\x80c\xC8\xB5\x83 @\x800@\xDC @\x80\xC6\x901j @\x80 `\x80\xB8 @\x80\x8C	 c\xD4@\x80 @\xE0uJ\xB0\xEB\xF4\xD5[\xDF\xDB\xEF\xB3?j\xFF\xF7|\xB7\xA2\xF81 @\x80Q_@\xA2ŉM\x80 @\xA0(`\x80[\x93\x99 @\x80@T\xC0\x89'6 @\x80\x81\xA2\x80RlMf @\x80Q$Z\x9C\xD8 @\x80\x8AH\xB15\x99	 @\x80D\x90hqb @\x80(
+ \xC5\xD6d@\x80 0@\xA2ŉM\x80 @\xA0(`\x80[\x93\x99 @\x80@T\xC0\x89'6 @\x80\x81\xA2\x80RlMf @\x80Q$Z\x9C\xD8 @\x80\x8AH\xB15\x99	 @\x80D\x90hqb @\x80(
+ \xC5\xD6d@\x80 0@\xA2ŉM\x80 @\xA0(`\x80[\x93\x99 @\x80@T\xC0\x89'6 @\x80\x81\xA2\x80RlMf @\x80Q$Z\x9C\xD8 @\x80\x8AH\xB15\x99	 @\x80D\x90hqb @\x80(
+ \xC5\xD6d@\x80 0@\xA2ŉM\x80 @\xA0(`\x80[\x93\x99 @\x80@T\xC0\x89'6 @\x80\x81\xA2\x80RlMf @\x80Q$Z\x9C\xD8 @\x80\x8Ak_O1\xB8\xCC @\x80\xF4|\xE9u1 @\x80\x81\xAC\x80\x92\xADNp @\x80=\xA4י\xC4 @\x80\xB2H\xB6:\xC1	 @\x80\xF4\x90^g @\x80\xC8
+ \xD9\xEA'@\x80 \xD00@z\x9DIL\x80 @ +`\x80d\xAB\x9C @\x80@O\xC0\xE9u1 @\x80\x81\xAC\x80\x92\xADNp @\x80=\xA4י\xC4 @\x80\xB2H\xB6:\xC1	 @\x80\xF4\x90^g @\x80\xC8
+ \xD9\xEA'@\x80 \xD00@z\x9DIL\x80 @ +`\x80d\xAB\x9C @\x80@O\xC0\xE9u1 @\x80\x81\xAC\x80\x92\xADNp @\x80=\xA4י\xC4 @\x80\xB2H\xB6:\xC1	 @\x80\xF4\x90^g @\x80\xC8
+ \xD9\xEA'@\x80 \xD00@z\x9DIL\x80 @ +`\x80d\xAB\x9C @\x80@O\xC0\xE9u1 @\x80\x81\xAC\x80\x92\xADNp @\x80=\xA4י\xC4 @\x80\xB2H\xB6:\xC1	 @\x80\xF4\x90^g @\x80\xC8
+ \xD9\xEA'@\x80 \xD00@z\x9DIL\x80 @ +`\x80d\xAB\x9C @\x80@O\xC0\xE9u1 @\x80\x81\xAC\x80\x92\xADNp @\x80=\xA4י\xC4 @\x80\xB2H\xB6:\xC1	 @\x80\xF4\x90^g @\x80\xC8
+ \xD9\xEA'@\x80 \xD00@z\x9DIL\x80 @ +`\x80d\xAB\x9C

[webkit-changes] [107006] trunk/Source/WebCore

Title: [107006] trunk/Source/WebCore








Revision 107006
Author ander...@apple.com
Date 2012-02-07 16:17:42 -0800 (Tue, 07 Feb 2012)


Log Message
Fix build.

* platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollableAreaBoundingBox):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollableArea.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (107005 => 107006)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 00:14:42 UTC (rev 107005)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 00:17:42 UTC (rev 107006)
@@ -1,3 +1,10 @@
+2012-02-07  Anders Carlsson  ander...@apple.com
+
+Fix build.
+
+* platform/ScrollableArea.h:
+(WebCore::ScrollableArea::scrollableAreaBoundingBox):
+
 2012-02-07  Levi Weintraub  le...@chromium.org
 
 [SVG] Use element disappears after scripted change


Modified: trunk/Source/WebCore/platform/ScrollableArea.h (107005 => 107006)

--- trunk/Source/WebCore/platform/ScrollableArea.h	2012-02-08 00:14:42 UTC (rev 107005)
+++ trunk/Source/WebCore/platform/ScrollableArea.h	2012-02-08 00:17:42 UTC (rev 107006)
@@ -156,7 +156,7 @@
 virtual ScrollableArea* enclosingScrollableArea() const = 0;
 
 // Returns the bounding box of this scrollable area, in the coordinate system of the enclosing scroll view.
-virtual IntRect scrollableAreaBoundingBox() const { ASSERT_NOT_REACHED(); }
+virtual IntRect scrollableAreaBoundingBox() const { ASSERT_NOT_REACHED(); return IntRect(); }
 
 bool isPinnedInBothDirections(const IntSize) const;
 bool isPinnedHorizontallyInDirection(int horizontalScrollDelta) const;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107007] branches/safari-534.54-branch

2012-02-07 Thread lforschler

Title: [107007] branches/safari-534.54-branch








Revision 107007
Author lforsch...@apple.com
Date 2012-02-07 16:26:45 -0800 (Tue, 07 Feb 2012)


Log Message
Merged r106982.

Modified Paths

branches/safari-534.54-branch/LayoutTests/ChangeLog
branches/safari-534.54-branch/Source/WebCore/ChangeLog
branches/safari-534.54-branch/Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp
branches/safari-534.54-branch/Source/WebCore/platform/network/mac/ResourceHandleMac.mm


Added Paths

branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php


Removed Paths

branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php
branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php




Diff

Modified: branches/safari-534.54-branch/LayoutTests/ChangeLog (107006 => 107007)

--- branches/safari-534.54-branch/LayoutTests/ChangeLog	2012-02-08 00:17:42 UTC (rev 107006)
+++ branches/safari-534.54-branch/LayoutTests/ChangeLog	2012-02-08 00:26:45 UTC (rev 107007)
@@ -1,3 +1,20 @@
+2011-02-07  Lucas Forschler  lforsch...@apple.com
+
+Merge 106982
+
+2012-02-07  Brady Eidson  beid...@apple.com
+
+rdar://problem/9567286 and https://bugs.webkit.org/show_bug.cgi?id=78003
+WebKit associates credentials with the wrong site if the authentication challenge takes place after a redirect chain
+
+Reviewed by Alexey Proskuryakov.
+
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Added.
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html: Added.
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-1-redirect-to-auth.php: Added.
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php: Added.
+* http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-3-output-credentials-then-finish.php: Added.
+
 2011-02-06  Lucas Forschler  lforsch...@apple.com
 
 Merge 104356


Deleted: branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt (106982 => 107007)

--- trunk/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt	2012-02-07 21:37:17 UTC (rev 106982)
+++ branches/safari-534.54-branch/LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt	2012-02-08 00:26:45 UTC (rev 107007)
@@ -1,30 +0,0 @@
-main frame - didStartProvisionalLoadForFrame
-main frame - didCommitLoadForFrame
-frame !--framePath //!--frame0 -

[webkit-changes] [107009] trunk/Source/WebCore

2012-02-07 Thread leviw

Title: [107009] trunk/Source/WebCore








Revision 107009
Author le...@chromium.org
Date 2012-02-07 16:52:39 -0800 (Tue, 07 Feb 2012)


Log Message
Update LayoutUnit usage in ColumnInfo and RenderFrameSet
https://bugs.webkit.org/show_bug.cgi?id=77914

Reviewed by Eric Seidel.

Updating ColumnInfo and RenderFrameSet to use LayoutUnits
instead of directly referencing integers for locations and
distances.

No new tests. No changed behavior.

* rendering/ColumnInfo.h:
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(ColumnInfo):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
* rendering/RenderFrameSet.h:
(RenderFrameSet):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/ColumnInfo.h
trunk/Source/WebCore/rendering/RenderFrameSet.cpp
trunk/Source/WebCore/rendering/RenderFrameSet.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (107008 => 107009)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 00:40:31 UTC (rev 107008)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 00:52:39 UTC (rev 107009)
@@ -1,3 +1,26 @@
+2012-02-07  Levi Weintraub  le...@chromium.org
+
+Update LayoutUnit usage in ColumnInfo and RenderFrameSet
+https://bugs.webkit.org/show_bug.cgi?id=77914
+
+Reviewed by Eric Seidel.
+
+Updating ColumnInfo and RenderFrameSet to use LayoutUnits
+instead of directly referencing integers for locations and
+distances.
+
+No new tests. No changed behavior.
+
+* rendering/ColumnInfo.h:
+(WebCore::ColumnInfo::forcedBreakOffset):
+(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
+(ColumnInfo):
+* rendering/RenderFrameSet.cpp:
+(WebCore::RenderFrameSet::paintColumnBorder):
+(WebCore::RenderFrameSet::paintRowBorder):
+* rendering/RenderFrameSet.h:
+(RenderFrameSet):
+
 2012-02-07  Adam Klein  ad...@chromium.org
 
 Add JSC support for delivering mutations when the outermost script context exits


Modified: trunk/Source/WebCore/rendering/ColumnInfo.h (107008 => 107009)

--- trunk/Source/WebCore/rendering/ColumnInfo.h	2012-02-08 00:40:31 UTC (rev 107008)
+++ trunk/Source/WebCore/rendering/ColumnInfo.h	2012-02-08 00:52:39 UTC (rev 107009)
@@ -75,8 +75,8 @@
 LayoutUnit minimumColumnHeight() const { return m_minimumColumnHeight; }
 
 int forcedBreaks() const { return m_forcedBreaks; }
-int forcedBreakOffset() const { return m_forcedBreakOffset; }
-int maximumDistanceBetweenForcedBreaks() const { return m_maximumDistanceBetweenForcedBreaks; }
+LayoutUnit forcedBreakOffset() const { return m_forcedBreakOffset; }
+LayoutUnit maximumDistanceBetweenForcedBreaks() const { return m_maximumDistanceBetweenForcedBreaks; }
 void clearForcedBreaks()
 { 
 m_forcedBreaks = 0;
@@ -107,8 +107,8 @@
 LayoutUnit m_columnHeight;
 LayoutUnit m_minimumColumnHeight;
 int m_forcedBreaks; // FIXME: We will ultimately need to cache more information to balance around forced breaks properly.
-int m_maximumDistanceBetweenForcedBreaks;
-int m_forcedBreakOffset;
+LayoutUnit m_maximumDistanceBetweenForcedBreaks;
+LayoutUnit m_forcedBreakOffset;
 PaginationUnit m_paginationUnit;
 };
 


Modified: trunk/Source/WebCore/rendering/RenderFrameSet.cpp (107008 => 107009)

--- trunk/Source/WebCore/rendering/RenderFrameSet.cpp	2012-02-08 00:40:31 UTC (rev 107008)
+++ trunk/Source/WebCore/rendering/RenderFrameSet.cpp	2012-02-08 00:52:39 UTC (rev 107009)
@@ -80,7 +80,7 @@
 return Color(208, 208, 208);
 }
 
-void RenderFrameSet::paintColumnBorder(const PaintInfo paintInfo, const IntRect borderRect)
+void RenderFrameSet::paintColumnBorder(const PaintInfo paintInfo, const LayoutRect borderRect)
 {
 if (!paintInfo.rect.intersects(borderRect))
 return;
@@ -100,7 +100,7 @@
 }
 }
 
-void RenderFrameSet::paintRowBorder(const PaintInfo paintInfo, const IntRect borderRect)
+void RenderFrameSet::paintRowBorder(const PaintInfo paintInfo, const LayoutRect borderRect)
 {
 if (!paintInfo.rect.intersects(borderRect))
 return;


Modified: trunk/Source/WebCore/rendering/RenderFrameSet.h (107008 => 107009)

--- trunk/Source/WebCore/rendering/RenderFrameSet.h	2012-02-08 00:40:31 UTC (rev 107008)
+++ trunk/Source/WebCore/rendering/RenderFrameSet.h	2012-02-08 00:52:39 UTC (rev 107009)
@@ -119,8 +119,8 @@
 void startResizing(GridAxis, int position);
 void continueResizing(GridAxis, int position);
 
-void paintRowBorder(const PaintInfo, const IntRect);
-void paintColumnBorder(const PaintInfo, const IntRect);
+void paintRowBorder(const PaintInfo, const LayoutRect);
+void paintColumnBorder(const PaintInfo, const LayoutRect);
 
 RenderObjectChildList m_children;
 






___
webkit-changes mailing list

[webkit-changes] [107011] tags/Safari-534.54.14/

2012-02-07 Thread lforschler

Title: [107011] tags/Safari-534.54.14/








Revision 107011
Author lforsch...@apple.com
Date 2012-02-07 16:58:59 -0800 (Tue, 07 Feb 2012)


Log Message
New tag.

Added Paths

tags/Safari-534.54.14/




Diff

Property changes: tags/Safari-534.54.14



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107012] trunk

2012-02-07 Thread mitz

Title: [107012] trunk








Revision 107012
Author m...@apple.com
Date 2012-02-07 16:59:11 -0800 (Tue, 07 Feb 2012)


Log Message
rdar://problem/10475450 Synthetic bold is illegible under some scaling transforms
https://bugs.webkit.org/show_bug.cgi?id=78044

Reviewed by Beth Dakin.

Source/WebCore: 

Tests: fast/text/synthetic-bold-transformed-expected.html
   fast/text/synthetic-bold-transformed.html

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels.

LayoutTests: 

* fast/text/synthetic-bold-transformed-expected.html: Added.
* fast/text/synthetic-bold-transformed.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/FontMac.mm


Added Paths

trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html
trunk/LayoutTests/fast/text/synthetic-bold-transformed.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107011 => 107012)

--- trunk/LayoutTests/ChangeLog	2012-02-08 00:58:59 UTC (rev 107011)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 00:59:11 UTC (rev 107012)
@@ -1,3 +1,13 @@
+2012-02-07  Dan Bernstein  m...@apple.com
+
+rdar://problem/10475450 Synthetic bold is illegible under some scaling transforms
+https://bugs.webkit.org/show_bug.cgi?id=78044
+
+Reviewed by Beth Dakin.
+
+* fast/text/synthetic-bold-transformed-expected.html: Added.
+* fast/text/synthetic-bold-transformed.html: Added.
+
 2012-02-07  Adam Klein  ad...@chromium.org
 
 Add JSC support for delivering mutations when the outermost script context exits


Added: trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html (0 => 107012)

--- trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/synthetic-bold-transformed-expected.html	2012-02-08 00:59:11 UTC (rev 107012)
@@ -0,0 +1,4 @@
+div style=position: relative;
+div style=-webkit-transform-origin: 0 0; -webkit-transform: scale(8); font-family: STSong;|/div
+div style=position: absolute; top: 0; -webkit-transform-origin: 0 0; -webkit-transform: translatex(1px) scale(8); font-family: STSong;|/div
+/div


Added: trunk/LayoutTests/fast/text/synthetic-bold-transformed.html (0 => 107012)

--- trunk/LayoutTests/fast/text/synthetic-bold-transformed.html	(rev 0)
+++ trunk/LayoutTests/fast/text/synthetic-bold-transformed.html	2012-02-08 00:59:11 UTC (rev 107012)
@@ -0,0 +1 @@
+div style=-webkit-transform-origin: 0 0; -webkit-transform: scale(8); font-family: STSong; font-weight: bold;|/div


Modified: trunk/Source/WebCore/ChangeLog (107011 => 107012)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 00:58:59 UTC (rev 107011)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 00:59:11 UTC (rev 107012)
@@ -1,3 +1,16 @@
+2012-02-07  Dan Bernstein  m...@apple.com
+
+rdar://problem/10475450 Synthetic bold is illegible under some scaling transforms
+https://bugs.webkit.org/show_bug.cgi?id=78044
+
+Reviewed by Beth Dakin.
+
+Tests: fast/text/synthetic-bold-transformed-expected.html
+   fast/text/synthetic-bold-transformed.html
+
+* platform/graphics/mac/FontMac.mm:
+(WebCore::Font::drawGlyphs): Changed to interpret syntheticBoldOffset as a length in device pixels.
+
 2012-02-07  Levi Weintraub  le...@chromium.org
 
 Update LayoutUnit usage in ColumnInfo and RenderFrameSet


Modified: trunk/Source/WebCore/platform/graphics/mac/FontMac.mm (107011 => 107012)

--- trunk/Source/WebCore/platform/graphics/mac/FontMac.mm	2012-02-08 00:58:59 UTC (rev 107011)
+++ trunk/Source/WebCore/platform/graphics/mac/FontMac.mm	2012-02-08 00:59:11 UTC (rev 107012)
@@ -222,7 +222,16 @@
 ColorSpace fillColorSpace = context-fillColorSpace();
 context-getShadow(shadowOffset, shadowBlur, shadowColor, shadowColorSpace);
 
-bool hasSimpleShadow = context-textDrawingMode() == TextModeFill  shadowColor.isValid()  !shadowBlur  !platformData.isColorBitmapFont()  (!context-shadowsIgnoreTransforms() || context-getCTM().isIdentityOrTranslationOrFlipped())  !context-isInTransparencyLayer();
+AffineTransform contextCTM = context-getCTM();
+float syntheticBoldOffset = font-syntheticBoldOffset();
+if (syntheticBoldOffset  !contextCTM.isIdentityOrTranslationOrFlipped()) {
+FloatSize horizontalUnitSizeInDevicePixels = contextCTM.mapSize(FloatSize(1, 0));
+float horizontalUnitLengthInDevicePixels = sqrtf(horizontalUnitSizeInDevicePixels.width() * horizontalUnitSizeInDevicePixels.width() + horizontalUnitSizeInDevicePixels.height() * horizontalUnitSizeInDevicePixels.height());
+if (horizontalUnitLengthInDevicePixels)
+syntheticBoldOffset /= horizontalUnitLengthInDevicePixels;
+};
+
+bool hasSimpleShadow = context-textDrawingMode() == TextModeFill  shadowColor.isValid()

[webkit-changes] [107013] trunk/Source/WebCore

Title: [107013] trunk/Source/WebCore








Revision 107013
Author ander...@apple.com
Date 2012-02-07 17:00:06 -0800 (Tue, 07 Feb 2012)


Log Message
Use the non-fast-scrollable region to detect when we can't do fast scrolling
https://bugs.webkit.org/show_bug.cgi?id=78056
rdar://problem/10247932

Reviewed by Sam Weinig.

* page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
Actually set the non-fast scrollable region on the scrolling tree state.

* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::tryToHandleWheelEvent):
Check if the wheel event's position is inside the non-fast-scrollable region
and return false if it is.

(WebCore::ScrollingTree::updateMainFrameScrollPosition):
Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.

* platform/graphics/Region.cpp:
* platform/graphics/Region.h:
Add a simple contains(const IntPoint) member function.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp
trunk/Source/WebCore/page/scrolling/ScrollingTree.h
trunk/Source/WebCore/platform/graphics/Region.cpp
trunk/Source/WebCore/platform/graphics/Region.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (107012 => 107013)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 00:59:11 UTC (rev 107012)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 01:00:06 UTC (rev 107013)
@@ -1,3 +1,27 @@
+2012-02-07  Anders Carlsson  ander...@apple.com
+
+Use the non-fast-scrollable region to detect when we can't do fast scrolling
+https://bugs.webkit.org/show_bug.cgi?id=78056
+rdar://problem/10247932
+
+Reviewed by Sam Weinig.
+
+* page/scrolling/ScrollingCoordinator.cpp:
+(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
+Actually set the non-fast scrollable region on the scrolling tree state.
+
+* page/scrolling/ScrollingTree.cpp:
+(WebCore::ScrollingTree::tryToHandleWheelEvent):
+Check if the wheel event's position is inside the non-fast-scrollable region
+and return false if it is.
+
+(WebCore::ScrollingTree::updateMainFrameScrollPosition):
+Store the cached main frame scroll position so we can use it in tryToHandleWheelEvent.
+
+* platform/graphics/Region.cpp:
+* platform/graphics/Region.h:
+Add a simple contains(const IntPoint) member function.
+
 2012-02-07  Dan Bernstein  m...@apple.com
 
 rdar://problem/10475450 Synthetic bold is illegible under some scaling transforms


Modified: trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp (107012 => 107013)

--- trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2012-02-08 00:59:11 UTC (rev 107012)
+++ trunk/Source/WebCore/page/scrolling/ScrollingCoordinator.cpp	2012-02-08 01:00:06 UTC (rev 107013)
@@ -117,6 +117,7 @@
 
 m_scrollingTreeState-setViewportRect(IntRect(IntPoint(), frameView-visibleContentRect().size()));
 m_scrollingTreeState-setContentsSize(frameView-contentsSize());
+m_scrollingTreeState-setNonFastScrollableRegion(nonScrollableRegion);
 scheduleTreeStateCommit();
 }
 


Modified: trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp (107012 => 107013)

--- trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp	2012-02-08 00:59:11 UTC (rev 107012)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp	2012-02-08 01:00:06 UTC (rev 107013)
@@ -61,10 +61,16 @@
 
 if (m_hasWheelEventHandlers)
 return false;
+
+if (!m_nonFastScrollableRegion.isEmpty()) {
+// FIXME: This is not correct for non-default scroll origins.
+IntPoint position = wheelEvent.position();
+position.moveBy(m_mainFrameScrollPosition);
+if (m_nonFastScrollableRegion.contains(position))
+return false;
+}
 }
 
-// FIXME: Check if we're over a subframe or overflow div.
-
 ScrollingThread::dispatch(bind(ScrollingTree::handleWheelEvent, this, wheelEvent));
 return true;
 }
@@ -106,6 +112,11 @@
 if (!m_scrollingCoordinator)
 return;
 
+{
+MutexLocker lock(m_mutex);
+m_mainFrameScrollPosition = scrollPosition;
+}
+
 callOnMainThread(bind(ScrollingCoordinator::updateMainFrameScrollPosition, m_scrollingCoordinator.get(), scrollPosition));
 }
 


Modified: trunk/Source/WebCore/page/scrolling/ScrollingTree.h (107012 => 107013)

--- trunk/Source/WebCore/page/scrolling/ScrollingTree.h	2012-02-08 00:59:11 UTC (rev 107012)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTree.h	2012-02-08 01:00:06 UTC (rev 107013)
@@ -73,6 +73,7 @@
 
 Mutex m_mutex;
 Region m_nonFastScrollableRegion;
+IntPoint m_mainFrameScrollPosition;
 bool m_hasWheelEventHandlers;
 };
 


Modified: trunk/Source/WebCore/platform/graphics/Region.cpp (107012 => 107013)

---

[webkit-changes] [107014] trunk/Source

Title: [107014] trunk/Source








Revision 107014
Author commit-qu...@webkit.org
Date 2012-02-07 17:03:07 -0800 (Tue, 07 Feb 2012)


Log Message
[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
https://bugs.webkit.org/show_bug.cgi?id=78020

Patch by David Reveman reve...@chromium.org on 2012-02-07
Reviewed by James Robinson.

Source/WebCore:

Revert r101854.

This patch is tested by the following unit test:
- TextureManagerTest.requestTextureExceedingPreferredLimit

* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::reserve):
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::requestTexture):
* platform/graphics/chromium/TextureManager.h:
(TextureManager):

Source/WebKit/chromium:

Update TextureManagerTest.requestTextureExceedingPreferredLimit test.

* tests/TextureManagerTest.cpp:
(WTF::TextureManagerTest::requestTexture):
(WTF::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/ManagedTexture.cpp
trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp
trunk/Source/WebCore/platform/graphics/chromium/TextureManager.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/TextureManagerTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107013 => 107014)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 01:00:06 UTC (rev 107013)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 01:03:07 UTC (rev 107014)
@@ -1,3 +1,22 @@
+2012-02-07  David Reveman  reve...@chromium.org
+
+[Chromium] REGRESSION(r101854): Causing large amounts of unnecessary repainting.
+https://bugs.webkit.org/show_bug.cgi?id=78020
+
+Reviewed by James Robinson.
+
+Revert r101854.
+
+This patch is tested by the following unit test:
+- TextureManagerTest.requestTextureExceedingPreferredLimit
+
+* platform/graphics/chromium/ManagedTexture.cpp:
+(WebCore::ManagedTexture::reserve):
+* platform/graphics/chromium/TextureManager.cpp:
+(WebCore::TextureManager::requestTexture):
+* platform/graphics/chromium/TextureManager.h:
+(TextureManager):
+
 2012-02-07  Anders Carlsson  ander...@apple.com
 
 Use the non-fast-scrollable region to detect when we can't do fast scrolling


Modified: trunk/Source/WebCore/platform/graphics/chromium/ManagedTexture.cpp (107013 => 107014)

--- trunk/Source/WebCore/platform/graphics/chromium/ManagedTexture.cpp	2012-02-08 01:00:06 UTC (rev 107013)
+++ trunk/Source/WebCore/platform/graphics/chromium/ManagedTexture.cpp	2012-02-08 01:03:07 UTC (rev 107014)
@@ -92,7 +92,7 @@
 m_textureManager-protectTexture(m_token);
 else {
 m_textureId = 0;
-reserved = m_textureManager-requestTexture(m_token, size, format, m_textureId);
+reserved = m_textureManager-requestTexture(m_token, size, format);
 if (reserved) {
 m_size = size;
 m_format = format;


Modified: trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp (107013 => 107014)

--- trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp	2012-02-08 01:00:06 UTC (rev 107013)
+++ trunk/Source/WebCore/platform/graphics/chromium/TextureManager.cpp	2012-02-08 01:03:07 UTC (rev 107014)
@@ -203,30 +203,6 @@
 }
 }
 
-unsigned TextureManager::replaceTexture(TextureToken newToken, TextureInfo newInfo)
-{
-for (ListHashSetTextureToken::iterator lruIt = m_textureLRUSet.begin(); lruIt != m_textureLRUSet.end(); ++lruIt) {
-TextureToken token = *lruIt;
-TextureInfo info = m_textures.get(token);
-if (info.isProtected)
-continue;
-if (!info.textureId)
-continue;
-if (newInfo.size != info.size || newInfo.format != info.format)
-continue;
-newInfo.textureId = info.textureId;
-#ifndef NDEBUG
-newInfo.allocator = info.allocator;
-#endif
-m_textures.remove(token);
-m_textureLRUSet.remove(token);
-m_textures.set(newToken, newInfo);
-m_textureLRUSet.add(newToken);
-return info.textureId;
-}
-return 0;
-}
-
 void TextureManager::addTexture(TextureToken token, TextureInfo info)
 {
 ASSERT(!m_textureLRUSet.contains(token));
@@ -291,10 +267,8 @@
 return textureId;
 }
 
-bool TextureManager::requestTexture(TextureToken token, IntSize size, unsigned format, unsigned textureId)
+bool TextureManager::requestTexture(TextureToken token, IntSize size, unsigned format)
 {
-textureId = 0;
-
 if (size.width()  m_maxTextureSize || size.height()  m_maxTextureSize)
 return false;
 
@@ -320,13 +294,6 @@
 #ifndef NDEBUG
 info.allocator = 0;
 #endif
-// Avoid churning by reusing the texture if it is about to be reclaimed and
-// it has the same size and format as the requesting texture.
-if (m_memoryUseBytes + memoryRequiredBytes  m_preferredMemoryLimitBytes) {
-textureId

[webkit-changes] [107015] branches/safari-534.54-branch/Source

2012-02-07 Thread lforschler

Title: [107015] branches/safari-534.54-branch/Source








Revision 107015
Author lforsch...@apple.com
Date 2012-02-07 17:15:45 -0800 (Tue, 07 Feb 2012)


Log Message
Versioning.

Modified Paths

branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig
branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig
branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig (107014 => 107015)

--- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2012-02-08 01:03:07 UTC (rev 107014)
+++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2012-02-08 01:15:45 UTC (rev 107015)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 14;
+TINY_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (107014 => 107015)

--- branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2012-02-08 01:03:07 UTC (rev 107014)
+++ branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig	2012-02-08 01:15:45 UTC (rev 107015)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 14;
+TINY_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig (107014 => 107015)

--- branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig	2012-02-08 01:03:07 UTC (rev 107014)
+++ branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig	2012-02-08 01:15:45 UTC (rev 107015)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 14;
+TINY_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig (107014 => 107015)

--- branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2012-02-08 01:03:07 UTC (rev 107014)
+++ branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig	2012-02-08 01:15:45 UTC (rev 107015)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 14;
+TINY_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig (107014 => 107015)

--- branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig	2012-02-08 01:03:07 UTC (rev 107014)
+++ branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig	2012-02-08 01:15:45 UTC (rev 107015)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 534;
 MINOR_VERSION = 54;
-TINY_VERSION = 14;
+TINY_VERSION = 15;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107016] trunk

Title: [107016] trunk








Revision 107016
Author commit-qu...@webkit.org
Date 2012-02-07 17:16:40 -0800 (Tue, 07 Feb 2012)


Log Message
Get rid of Source/autotools/webkit.m4
https://bugs.webkit.org/show_bug.cgi?id=77833

Patch by Priit Laes pl...@plaes.org on 2012-02-07
Reviewed by Martin Robinson.

Move checks from webkit.m4 to configure.ac and modernize macros:
  . Check for visibility flags after CXX has been defined
  . Use PKG_PROG_PKG_CONFIG for pkg-config lookup
  . Drop unused LIBFFTW_REQUIRED_VERSION
  . Update ICU libs for mingw (bug 77837).
  . Require Pango 1.21.0 (as per unicode backend)
  . Bump minimum glib version due to g_thread_init changes

* Source/autotools/webkit.m4: Removed.
* configure.ac:

Modified Paths

trunk/ChangeLog
trunk/configure.ac


Removed Paths

trunk/Source/autotools/webkit.m4




Diff

Modified: trunk/ChangeLog (107015 => 107016)

--- trunk/ChangeLog	2012-02-08 01:15:45 UTC (rev 107015)
+++ trunk/ChangeLog	2012-02-08 01:16:40 UTC (rev 107016)
@@ -1,3 +1,21 @@
+2012-02-07  Priit Laes  pl...@plaes.org
+
+Get rid of Source/autotools/webkit.m4
+https://bugs.webkit.org/show_bug.cgi?id=77833
+
+Reviewed by Martin Robinson.
+
+Move checks from webkit.m4 to configure.ac and modernize macros:
+  . Check for visibility flags after CXX has been defined
+  . Use PKG_PROG_PKG_CONFIG for pkg-config lookup
+  . Drop unused LIBFFTW_REQUIRED_VERSION
+  . Update ICU libs for mingw (bug 77837).
+  . Require Pango 1.21.0 (as per unicode backend)
+  . Bump minimum glib version due to g_thread_init changes
+
+* Source/autotools/webkit.m4: Removed.
+* configure.ac:
+
 2012-02-07  Ryosuke Niwa  rn...@webkit.org
 
 Dashboard on perf-o-matic should be sorted


Deleted: trunk/Source/autotools/webkit.m4 (107015 => 107016)

--- trunk/Source/autotools/webkit.m4	2012-02-08 01:15:45 UTC (rev 107015)
+++ trunk/Source/autotools/webkit.m4	2012-02-08 01:16:40 UTC (rev 107016)
@@ -1,171 +0,0 @@
-dnl macros to check for _javascript_Core and WebKit/Gtk+ dependencies
-dnl
-dnl The rationale is so that we can share these macros between 
-dnl WebKit and _javascript_Core builds.
-
-# global states
-m4_define([initialized], [no])
-
-AC_DEFUN([INIT_C_CXX_FLAGS],
-[dnl
-# If CXXFLAGS and CFLAGS are unset, default to empty.
-# This is to tell automake not to include '-g' if CXXFLAGS is not set
-# For more info - http://www.gnu.org/software/automake/manual/autoconf.html#C_002b_002b-Compiler
-if test -z $CXXFLAGS; then
-   CXXFLAGS=
-fi
-if test -z $CFLAGS; then
-   CFLAGS=
-fi
-])
-
-AC_DEFUN_ONCE([WEBKIT_INIT],
-[dnl
-dnl check if we have the required packages to have successful checks
-dnl
-# Make sure CXXFLAGS and CFLAGS are set before expanding AC_PROG_CXX to avoid
-# building with '-g -O2' on Release builds.
-AC_REQUIRE([INIT_C_CXX_FLAGS])
-
-# check for -fvisibility=hidden compiler support (GCC = 4)
-saved_CFLAGS=$CFLAGS
-CFLAGS=$CFLAGS -fvisibility=hidden -fvisibility-inlines-hidden
-AC_MSG_CHECKING([if ${CXX} supports -fvisibility=hidden -fvisibility-inlines-hidden])
-AC_COMPILE_IFELSE([AC_LANG_SOURCE([char foo;])],
-  [ AC_MSG_RESULT([yes])
-SYMBOL_VISIBILITY=-fvisibility=hidden SYMBOL_VISIBILITY_INLINES=-fvisibility-inlines-hidden ],
-AC_MSG_RESULT([no]))
-CFLAGS=$saved_CFLAGS
-AC_SUBST(SYMBOL_VISIBILITY)
-AC_SUBST(SYMBOL_VISIBILITY_INLINES)
-
-# check for pkg-config
-AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
-if test $PKG_CONFIG = no; then
-   AC_MSG_ERROR([Cannot find pkg-config, make sure it is installed in your PATH])
-fi
-
-AC_PATH_PROG(PERL, perl)
-if test -z $PERL; then
-   AC_MSG_ERROR([You need 'perl' to compile WebKit])
-fi
-
-AC_PATH_PROG(PYTHON, python)
-if test -z $PYTHON; then
-   AC_MSG_ERROR([You need 'python' to compile WebKit])
-fi
-
-AC_PATH_PROG(BISON, bison)
-if test -z $BISON; then
-   AC_MSG_ERROR([You need the 'bison' parser generator to compile WebKit])
-fi
-
-AC_PATH_PROG(MV, mv)
-if test -z $MV; then
-   AC_MSG_ERROR([You need 'mv' to compile WebKit])
-fi
-
-AC_REQUIRE([AC_PROG_CC])
-AC_REQUIRE([AC_PROG_CXX])
-AM_PROG_CC_STDC
-AM_PROG_CC_C_O
-AC_PROG_INSTALL
-AC_SYS_LARGEFILE
-
-# Check whether a C++ was found (AC_PROG_CXX sets $CXX to g++ even when it
-# doesn't exist)
-AC_LANG_PUSH([C++])
-AC_COMPILE_IFELSE([AC_LANG_PROGRAM([],[])],[],[AC_MSG_ERROR([No C++ compiler found])])
-AC_LANG_POP([C++])
-
-# C/C++ Language Features
-AC_C_CONST
-AC_C_INLINE
-AC_C_VOLATILE
-
-# C/C++ Headers
-AC_REQUIRE([AC_HEADER_STDC])
-AC_HEADER_STDBOOL
-
-m4_define([initialized], [yes])
-])
-
-AC_DEFUN_ONCE([WEBKIT_CHECK_DEPENDENCIES],
-[dnl
-dnl check for module dependencies
-for module in $1
-do
-case $module in
-glib) _WEBKIT_CHECK_GLIB ;;
-unicode) _WEBKIT_CHECK_UNICODE ;;
-*) AC_MSG_ERROR([I don't support that module. Sorry..]) ;;
-
-esac
-done
-])
-
-AC_DEFUN_ONCE([_WEBKIT_CHECK_GLIB],
-[dnl
-dnl check for glib
-# Version requirements

[webkit-changes] [107017] trunk/Source/WebKit2

2012-02-07 Thread timothy

Title: [107017] trunk/Source/WebKit2








Revision 107017
Author timo...@apple.com
Date 2012-02-07 17:28:16 -0800 (Tue, 07 Feb 2012)


Log Message
Initilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.

If WKView was created and loaded a page with canvas elements before beinging moved
to a window, the canvas elements would be locked in at a pixel ratio of 1. With this
change the WKView will use the main screen's pixel ratio until it moves to a window.

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (107016 => 107017)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 01:16:40 UTC (rev 107016)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 01:28:16 UTC (rev 107017)
@@ -1,3 +1,16 @@
+2012-02-07  Timothy Hatcher  timo...@apple.com
+
+Initilize the WebPageProxy intrinsicDeviceScaleFactor on creation of the WKView.
+
+If WKView was created and loaded a page with canvas elements before beinging moved
+to a window, the canvas elements would be locked in at a pixel ratio of 1. With this
+change the WKView will use the main screen's pixel ratio until it moves to a window.
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView initWithFrame:contextRef:pageGroupRef:]): Call setIntrinsicDeviceScaleFactor.
+
 2012-02-07  Alexey Proskuryakov  a...@apple.com
 
 Keep a reference in didReceiveInvalidMessage.


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (107016 => 107017)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2012-02-08 01:16:40 UTC (rev 107016)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2012-02-08 01:28:16 UTC (rev 107017)
@@ -2736,6 +2736,7 @@
 _data-_pageClient = PageClientImpl::create(self);
 _data-_page = toImpl(contextRef)-createWebPage(_data-_pageClient.get(), toImpl(pageGroupRef));
 _data-_page-initializeWebPage();
+_data-_page-setIntrinsicDeviceScaleFactor([self _intrinsicDeviceScaleFactor]);
 #if ENABLE(FULLSCREEN_API)
 _data-_page-fullScreenManager()-setWebView(self);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107018] trunk/LayoutTests

Title: [107018] trunk/LayoutTests








Revision 107018
Author commit-qu...@webkit.org
Date 2012-02-07 17:37:55 -0800 (Tue, 07 Feb 2012)


Log Message
Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.
https://bugs.webkit.org/show_bug.cgi?id=78030

Unreviewed.

Patch by Ami Fischman fisch...@chromium.org on 2012-02-07

* platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107017 => 107018)

--- trunk/LayoutTests/ChangeLog	2012-02-08 01:28:16 UTC (rev 107017)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 01:37:55 UTC (rev 107018)
@@ -1,3 +1,12 @@
+2012-02-07  Ami Fischman  fisch...@chromium.org
+
+Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.
+https://bugs.webkit.org/show_bug.cgi?id=78030
+
+Unreviewed.
+
+* platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt: Added.
+
 2012-02-07  Dan Bernstein  m...@apple.com
 
 rdar://problem/10475450 Synthetic bold is illegible under some scaling transforms


Added: trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt (0 => 107018)

--- trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/media/media-blocked-by-beforeload-expected.txt	2012-02-08 01:37:55 UTC (rev 107018)
@@ -0,0 +1,40 @@
+Test to ensure that a media file blocked by a beforeload handler generates an error and does not block the document's 'load' event.
+
+*** Test initial state ***
+EXPECTED (video.networkState == '0') OK
+EXPECTED (video.error == 'null') OK
+
+*** Test blocking the 'src' attribute ***
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+blocking load of 'src'
+
+EVENT('loadstart')
+
+EVENT('error')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+EXPECTED (video.error != 'null') OK
+EXPECTED (video.error.code == '4') OK
+EXPECTED (video.networkState == '3') OK
+
+*** Test using the source element ***
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+blocking load of first source element
+
+EVENT('beforeload')
+EXPECTED (event.target.tagName == 'VIDEO') OK
+allowing load of second source element
+
+EVENT('loadstart')
+
+EVENT('error')
+EXPECTED (event.target.tagName == 'SOURCE') OK
+EXPECTED (video.error == 'null') OK
+
+EVENT('loadedmetadata')
+
+END OF TEST
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107019] trunk

Title: [107019] trunk








Revision 107019
Author commit-qu...@webkit.org
Date 2012-02-07 17:49:27 -0800 (Tue, 07 Feb 2012)


Log Message
Remove extraneous MathML code before bug 52444 fix
https://bugs.webkit.org/show_bug.cgi?id=78034

Source/WebCore:

Patch by David Barton dbar...@mathscribe.com on 2012-02-07
Reviewed by Eric Seidel.

Per Darin Adler, I am breaking up the patch fixing bug 52444 into smaller pieces.
This patch removes a couple unused functions, some extra blank lines, unused #include
directives, etc., and adds a very few WebKit-standard changes to these files.

No new tests.

* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore):
* rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::getBoxModelObjectHeight):
- changed to a static member function since 'this' is unused;
  removed redundant non-const version
(WebCore::RenderMathMLBlock::getBoxModelObjectWidth):
- changed to a static member function since 'this' is unused;
  removed redundant non-const version
(WebCore):
* rendering/mathml/RenderMathMLFraction.cpp:
* rendering/mathml/RenderMathMLMath.cpp:
* rendering/mathml/RenderMathMLMath.h:
* rendering/mathml/RenderMathMLOperator.h:
(WebCore):
* rendering/mathml/RenderMathMLRoot.cpp:
* rendering/mathml/RenderMathMLRow.cpp:
* rendering/mathml/RenderMathMLRow.h:
* rendering/mathml/RenderMathMLSquareRoot.cpp:
* rendering/mathml/RenderMathMLSquareRoot.h:
* rendering/mathml/RenderMathMLSubSup.cpp:
* rendering/mathml/RenderMathMLSubSup.h:
* rendering/mathml/RenderMathMLUnderOver.cpp:
* rendering/mathml/RenderMathMLUnderOver.h:

LayoutTests:

Patch by David Barton dbar...@mathscribe.com on 2012-02-07
Reviewed by Eric Seidel.

The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test
environment timing issue, so I removed it.

* mathml/presentation/row.xhtml:
* platform/mac/mathml/presentation/row-expected.png:
* platform/mac/mathml/presentation/row-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/mathml/presentation/row.xhtml
trunk/LayoutTests/platform/mac/mathml/presentation/row-expected.png
trunk/LayoutTests/platform/mac/mathml/presentation/row-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLBlock.h
trunk/Source/WebCore/rendering/mathml/RenderMathMLFraction.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLMath.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLMath.h
trunk/Source/WebCore/rendering/mathml/RenderMathMLOperator.h
trunk/Source/WebCore/rendering/mathml/RenderMathMLRoot.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLRow.h
trunk/Source/WebCore/rendering/mathml/RenderMathMLSquareRoot.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLSquareRoot.h
trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.h
trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.h




Diff

Modified: trunk/LayoutTests/ChangeLog (107018 => 107019)

--- trunk/LayoutTests/ChangeLog	2012-02-08 01:37:55 UTC (rev 107018)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 01:49:27 UTC (rev 107019)
@@ -1,3 +1,17 @@
+2012-02-07  David Barton  dbar...@mathscribe.com
+
+Remove extraneous MathML code before bug 52444 fix
+https://bugs.webkit.org/show_bug.cgi?id=78034
+
+Reviewed by Eric Seidel.
+
+The rendering of the scrollbar in row-expected.png was flaky, presumably due to a test
+environment timing issue, so I removed it.
+
+* mathml/presentation/row.xhtml:
+* platform/mac/mathml/presentation/row-expected.png:
+* platform/mac/mathml/presentation/row-expected.txt:
+
 2012-02-07  Ami Fischman  fisch...@chromium.org
 
 Override expected-failure mac-leopard/media/media-blocked-by-beforeload-expected.txt with copy of expected-success expectation, for chromium-mac-leopard.


Modified: trunk/LayoutTests/mathml/presentation/row.xhtml (107018 => 107019)

--- trunk/LayoutTests/mathml/presentation/row.xhtml	2012-02-08 01:37:55 UTC (rev 107018)
+++ trunk/LayoutTests/mathml/presentation/row.xhtml	2012-02-08 01:49:27 UTC (rev 107019)
@@ -5,6 +5,9 @@
 mo {
background-color: rgb(200,200,200);
 }
+body {
+   overflow: hidden;
+}
 /style
 /head
 body


Modified: trunk/LayoutTests/platform/mac/mathml/presentation/row-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/mac/mathml/presentation/row-expected.txt (107018 => 107019)

--- trunk/LayoutTests/platform/mac/mathml/presentation/row-expected.txt	2012-02-08 01:37:55 UTC (rev 107018)
+++ trunk/LayoutTests/platform/mac/mathml/presentation/row-expected.txt	2012-02-08 01:49:27 UTC (rev 107019)
@@ -1,9 +1,9 @@
-layer at (0,0) size 785x614
-  RenderView at (0,0) size 785x600
-layer at (0,0) size

[webkit-changes] [107021] trunk/Source/WebCore

Title: [107021] trunk/Source/WebCore








Revision 107021
Author commit-qu...@webkit.org
Date 2012-02-07 18:05:34 -0800 (Tue, 07 Feb 2012)


Log Message
[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
https://bugs.webkit.org/show_bug.cgi?id=78029

Patch by Yong Li y...@rim.com on 2012-02-07
Reviewed by Rob Buis.

When a redirect is rejected by security origin check, the ResourceRequest
will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
case, we should stop handling the request.

No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
-origin-tripmine.html) can cover this.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::startNewJobWithRequest):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107020 => 107021)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 01:51:10 UTC (rev 107020)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 02:05:34 UTC (rev 107021)
@@ -1,3 +1,20 @@
+2012-02-07  Yong Li  y...@rim.com
+
+[BlackBerry] NetworkJob should stop redirecting when the request is cleared by client
+https://bugs.webkit.org/show_bug.cgi?id=78029
+
+Reviewed by Rob Buis.
+
+When a redirect is rejected by security origin check, the ResourceRequest
+will be cleared (see DocumentThreadableLoader::redirectReceived()). In this
+case, we should stop handling the request.
+
+No new tests because existing tests (like http:/tests/xmlhttprequest/redirect-cross
+-origin-tripmine.html) can cover this.
+
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::startNewJobWithRequest):
+
 2012-02-07  David Barton  dbar...@mathscribe.com
 
 Remove extraneous MathML code before bug 52444 fix


Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (107020 => 107021)

--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-02-08 01:51:10 UTC (rev 107020)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-02-08 02:05:34 UTC (rev 107021)
@@ -506,7 +506,8 @@
 m_handle-client()-willSendRequest(m_handle.get(), newRequest, m_response);
 
 // m_cancelled can become true if the url fails the policy check.
-if (m_cancelled)
+// newRequest can be cleared when the redirect is rejected.
+if (m_cancelled || newRequest.isEmpty())
 return false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107022] trunk/Tools

Title: [107022] trunk/Tools








Revision 107022
Author commit-qu...@webkit.org
Date 2012-02-07 18:06:08 -0800 (Tue, 07 Feb 2012)


Log Message
[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=78039

Patch by Justin Novosad ju...@chromium.org on 2012-02-07
Reviewed by Stephen White.

Adding the --enable-deferred-2d-canvas switch to DumpRenderTree

* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setDeferred2dCanvasEnabled):
(TestShell):
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
(WebPreferences::applyTo):
* DumpRenderTree/chromium/WebPreferences.h:
(WebPreferences):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp
trunk/Tools/DumpRenderTree/chromium/TestShell.h
trunk/Tools/DumpRenderTree/chromium/WebPreferences.cpp
trunk/Tools/DumpRenderTree/chromium/WebPreferences.h




Diff

Modified: trunk/Tools/ChangeLog (107021 => 107022)

--- trunk/Tools/ChangeLog	2012-02-08 02:05:34 UTC (rev 107021)
+++ trunk/Tools/ChangeLog	2012-02-08 02:06:08 UTC (rev 107022)
@@ -1,3 +1,27 @@
+2012-02-07  Justin Novosad  ju...@chromium.org
+
+[Chromium] add option for 2d canvas defered rendering to DumpRenderTree
+https://bugs.webkit.org/show_bug.cgi?id=78039
+
+Reviewed by Stephen White.
+
+Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
+
+* DumpRenderTree/chromium/DumpRenderTree.cpp:
+(main):
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::TestShell):
+(TestShell::resetWebSettings):
+(TestShell::runFileTest):
+* DumpRenderTree/chromium/TestShell.h:
+(TestShell::setDeferred2dCanvasEnabled):
+(TestShell):
+* DumpRenderTree/chromium/WebPreferences.cpp:
+(WebPreferences::reset):
+(WebPreferences::applyTo):
+* DumpRenderTree/chromium/WebPreferences.h:
+(WebPreferences):
+
 2012-02-07  Gyuyoung Kim  gyuyoung@samsung.com
 
 [CMAKE] Use *bin* and *lib* directories for executable and libraries.


Modified: trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp (107021 => 107022)

--- trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2012-02-08 02:05:34 UTC (rev 107021)
+++ trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp	2012-02-08 02:06:08 UTC (rev 107022)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2011 Google Inc. All rights reserved.
+ * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
@@ -56,6 +56,7 @@
 static const char optionEnableThreadedCompositing[] = --enable-threaded-compositing;
 static const char optionForceCompositingMode[] = --force-compositing-mode;
 static const char optionEnableAccelerated2DCanvas[] = --enable-accelerated-2d-canvas;
+static const char optionEnableDeferred2DCanvas[] = --enable-deferred-2d-canvas;
 static const char optionEnableAcceleratedPainting[] = --enable-accelerated-painting;
 static const char optionEnableAcceleratedCompositingForVideo[] = --enable-accelerated-video;
 static const char optionEnableCompositeToTexture[] = --enable-composite-to-texture;
@@ -143,6 +144,7 @@
 bool compositeToTexture = false;
 bool forceCompositingMode = false;
 bool accelerated2DCanvasEnabled = false;
+bool deferred2DCanvasEnabled = false;
 bool acceleratedPaintingEnabled = false;
 bool perTilePaintingEnabled = false;
 bool stressOpt = false;
@@ -186,6 +188,8 @@
 forceCompositingMode = true;
 else if (argument == optionEnableAccelerated2DCanvas)
 accelerated2DCanvasEnabled = true;
+else if (argument == optionEnableDeferred2DCanvas)
+deferred2DCanvasEnabled = true;
 else if (argument == optionEnableAcceleratedPainting)
 acceleratedPaintingEnabled = true;
 else if (!argument.find(optionUseGraphicsContext3DImplementation)) {
@@ -236,6 +240,7 @@
 shell.setCompositeToTexture(compositeToTexture);
 shell.setForceCompositingMode(forceCompositingMode);
 shell.setAccelerated2dCanvasEnabled(accelerated2DCanvasEnabled);
+shell.setDeferred2dCanvasEnabled(deferred2DCanvasEnabled);
 shell.setAcceleratedPaintingEnabled(acceleratedPaintingEnabled);
 shell.setPerTilePaintingEnabled(perTilePaintingEnabled);
 shell.setJavaScriptFlags(_javascript_Flags);


Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (107021 => 107022)

--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2012-02-08 02:05:34 UTC (rev 107021)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp

[webkit-changes] [107023] trunk

Title: [107023] trunk








Revision 107023
Author commit-qu...@webkit.org
Date 2012-02-07 18:21:04 -0800 (Tue, 07 Feb 2012)


Log Message
Resolve crash in FrameLoader::checkTimerFired.
https://bugs.webkit.org/show_bug.cgi?id=77907

Patch by Chris Palmer pal...@google.com on 2012-02-07
Reviewed by Eric Seidel.

Source/WebCore:

Test is LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkTimerFired):

LayoutTests:

* http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added.
* http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added.
* http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added.
* http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/FrameLoader.cpp


Added Paths

trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt
trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html
trunk/LayoutTests/http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html
trunk/LayoutTests/http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (107022 => 107023)

--- trunk/LayoutTests/ChangeLog	2012-02-08 02:06:08 UTC (rev 107022)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 02:21:04 UTC (rev 107023)
@@ -1,3 +1,15 @@
+2012-02-07  Chris Palmer  pal...@google.com
+
+Resolve crash in FrameLoader::checkTimerFired.
+https://bugs.webkit.org/show_bug.cgi?id=77907
+
+Reviewed by Eric Seidel.
+
+* http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt: Added.
+* http/tests/appcache/deferred-events-delete-while-raising-timer.html: Added.
+* http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html: Added.
+* http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html: Added.
+
 2012-02-07  David Barton  dbar...@mathscribe.com
 
 Remove extraneous MathML code before bug 52444 fix


Added: trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt (0 => 107023)

--- trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer-expected.txt	2012-02-08 02:21:04 UTC (rev 107023)
@@ -0,0 +1,4 @@
+Test the destruction of an iframe while deferred events are being raised does not crash the system.
+
+SUCCESS
+


Added: trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html (0 => 107023)

--- trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html	(rev 0)
+++ trunk/LayoutTests/http/tests/appcache/deferred-events-delete-while-raising-timer.html	2012-02-08 02:21:04 UTC (rev 107023)
@@ -0,0 +1,21 @@
+html
+script
+if (window.layoutTestController) {
+  layoutTestController.dumpAsText();
+  layoutTestController.waitUntilDone();
+}
+
+window._onmessage_ = function() {
+  document.getElementById('result').innerHTML = SUCCESS;
+  if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+function killChildFrame() {
+  document.body.removeChild(document.getElementsByTagName(iframe)[0]);
+}
+/script
+pTest the destruction of an iframe while deferred events are being raised does not crash the system./p
+div id=resultFAILURE/div
+iframe src=""
+/html


Added: trunk/LayoutTests/http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html (0 => 107023)

--- trunk/LayoutTests/http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html	(rev 0)
+++ trunk/LayoutTests/http/tests/appcache/resources/deferred-events-delete-while-raising-timer-1.html	2012-02-08 02:21:04 UTC (rev 107023)
@@ -0,0 +1,14 @@
+html manifest=THIS_FILE_DOES_NOT_EXIST.manifest
+script src=""
+script
+window.applicationCache._onchecking_ = function() {
+  parent.postMessage(hello, *);
+  parent.killChildFrame();
+}
+
+function killChildFrame() {
+  document.body.removeChild(document.getElementsByTagName(iframe)[0]);
+}
+/script
+iframe src=""
+/html


Added: trunk/LayoutTests/http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html (0 => 107023)

--- trunk/LayoutTests/http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html	(rev 0)
+++ trunk/LayoutTests/http/tests/appcache/resources/deferred-events-delete-while-raising-timer-2.html	2012-02-08 02:21:04 UTC (rev 107023)
@@ -0,0 +1,8 @@
+html manifest=THIS_FILE_DOES_NOT_EXIST.manifest
+script src=""
+script
+window.applicationCache._onchecking_ =

[webkit-changes] [107024] trunk/Source/WebCore

2012-02-07 Thread enne

Title: [107024] trunk/Source/WebCore








Revision 107024
Author e...@google.com
Date 2012-02-07 18:47:50 -0800 (Tue, 07 Feb 2012)


Log Message
Properly detect top level frames when propogating compositing
https://bugs.webkit.org/show_bug.cgi?id=78033

Reviewed by James Robinson.

There's no need to enumerate all tag names when searching for a
top-level frame. If a render view's document has a frame, then that
frame is not the top-level one.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (107023 => 107024)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 02:21:04 UTC (rev 107023)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 02:47:50 UTC (rev 107024)
@@ -1,3 +1,19 @@
+2012-02-07  Adrienne Walker  e...@google.com
+
+Properly detect top level frames when propogating compositing
+https://bugs.webkit.org/show_bug.cgi?id=78033
+
+Reviewed by James Robinson.
+
+There's no need to enumerate all tag names when searching for a
+top-level frame. If a render view's document has a frame, then that
+frame is not the top-level one.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):
+* rendering/RenderLayerCompositor.h:
+(RenderLayerCompositor):
+
 2012-02-07  Chris Palmer  pal...@google.com
 
 Resolve crash in FrameLoader::checkTimerFired.


Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (107023 => 107024)

--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2012-02-08 02:21:04 UTC (rev 107023)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2012-02-08 02:47:50 UTC (rev 107024)
@@ -1261,7 +1261,7 @@
 // Parent document content needs to be able to render on top of a composited frame, so correct behavior
 // is to have the parent document become composited too. However, this can cause problems on platforms that
 // use native views for frames (like Mac), so disable that behavior on those platforms for now.
-HTMLFrameOwnerElement* ownerElement = enclosingFrameElement();
+HTMLFrameOwnerElement* ownerElement = m_renderView-document()-ownerElement();
 RenderObject* renderer = ownerElement ? ownerElement-renderer() : 0;
 
 // If we are the top-level frame, don't propagate.
@@ -1292,14 +1292,6 @@
 return false;
 }
 
-HTMLFrameOwnerElement* RenderLayerCompositor::enclosingFrameElement() const
-{
-if (HTMLFrameOwnerElement* ownerElement = m_renderView-document()-ownerElement())
-return (ownerElement-hasTagName(iframeTag) || ownerElement-hasTagName(frameTag) || ownerElement-hasTagName(objectTag)) ? ownerElement : 0;
-
-return 0;
-}
-
 bool RenderLayerCompositor::needsToBeComposited(const RenderLayer* layer) const
 {
 if (!canBeComposited(layer))


Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.h (107023 => 107024)

--- trunk/Source/WebCore/rendering/RenderLayerCompositor.h	2012-02-08 02:21:04 UTC (rev 107023)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.h	2012-02-08 02:47:50 UTC (rev 107024)
@@ -178,8 +178,6 @@
 static bool allowsIndependentlyCompositedFrames(const FrameView*);
 bool shouldPropagateCompositingToEnclosingFrame() const;
 
-HTMLFrameOwnerElement* enclosingFrameElement() const;
-
 static RenderLayerCompositor* frameContentsCompositor(RenderPart*);
 // Return true if the layers changed.
 static bool parentFrameContentLayers(RenderPart*);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107025] trunk/Source/WebCore

Title: [107025] trunk/Source/WebCore








Revision 107025
Author commit-qu...@webkit.org
Date 2012-02-07 18:51:57 -0800 (Tue, 07 Feb 2012)


Log Message
Enable IPP for FFTFrame
https://bugs.webkit.org/show_bug.cgi?id=75522

Patch by Xingnan Wang xingnan.w...@intel.com on 2012-02-07
Reviewed by Tony Chang.

Add the FFTFrame implementation using Intel IPP's DFT algorithm.

* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/audio/FFTFrame.h:
(FFTFrame):
* platform/audio/FFTFrameStub.cpp:
* platform/audio/ipp/FFTFrameIPP.cpp: Added.
(WebCore):
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::initialize):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::getUpToDateComplexData):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/platform/audio/FFTFrame.h
trunk/Source/WebCore/platform/audio/FFTFrameStub.cpp


Added Paths

trunk/Source/WebCore/platform/audio/ipp/
trunk/Source/WebCore/platform/audio/ipp/FFTFrameIPP.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107024 => 107025)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 02:47:50 UTC (rev 107024)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 02:51:57 UTC (rev 107025)
@@ -1,3 +1,30 @@
+2012-02-07  Xingnan Wang  xingnan.w...@intel.com
+
+Enable IPP for FFTFrame
+https://bugs.webkit.org/show_bug.cgi?id=75522
+
+Reviewed by Tony Chang.
+
+Add the FFTFrame implementation using Intel IPP's DFT algorithm.
+
+* WebCore.gyp/WebCore.gyp:
+* WebCore.gypi:
+* platform/audio/FFTFrame.h:
+(FFTFrame):
+* platform/audio/FFTFrameStub.cpp:
+* platform/audio/ipp/FFTFrameIPP.cpp: Added.
+(WebCore):
+(WebCore::FFTFrame::FFTFrame):
+(WebCore::FFTFrame::initialize):
+(WebCore::FFTFrame::cleanup):
+(WebCore::FFTFrame::~FFTFrame):
+(WebCore::FFTFrame::multiply):
+(WebCore::FFTFrame::doFFT):
+(WebCore::FFTFrame::doInverseFFT):
+(WebCore::FFTFrame::realData):
+(WebCore::FFTFrame::imagData):
+(WebCore::FFTFrame::getUpToDateComplexData):
+
 2012-02-07  Adrienne Walker  e...@google.com
 
 Properly detect top level frames when propogating compositing


Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (107024 => 107025)

--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-02-08 02:47:50 UTC (rev 107024)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-02-08 02:51:57 UTC (rev 107025)
@@ -1145,6 +1145,11 @@
 'include_dirs+++': ['../dom'],
   },
 }],
+['OS==linux and WTF_USE_WEBAUDIO_IPP=1 in feature_defines', {
+  'cflags': [
+'!@(pkg-config --cflags-only-I ipp)',
+  ],
+}],
   ],
 },
 {
@@ -1347,6 +1352,13 @@
 'include_dirs++': ['../dom'],
   },
 }],
+['OS==linux and WTF_USE_WEBAUDIO_IPP=1 in feature_defines', {
+  'direct_dependent_settings': {
+'cflags': [
+  '!@(pkg-config --cflags-only-I ipp)',
+],
+  },
+}],
 ['OS != android and WTF_USE_WEBAUDIO_FFMPEG=1 in feature_defines', {
   # This directory needs to be on the include path for multiple sub-targets of webcore.
   'direct_dependent_settings': {
@@ -1985,6 +1997,16 @@
 'include_dirs+++': ['../dom'],
   },
 }],
+['OS==linux and WTF_USE_WEBAUDIO_IPP=1 in feature_defines', {
+  'link_settings': {
+'ldflags': [
+  '!@(pkg-config --libs-only-L ipp)',
+],
+'libraries': [
+  '-lipps -lippcore',
+],
+  },
+}],
 ['enable_svg!=0', {
   'dependencies': [
 'webcore_svg',


Modified: trunk/Source/WebCore/WebCore.gypi (107024 => 107025)

--- trunk/Source/WebCore/WebCore.gypi	2012-02-08 02:47:50 UTC (rev 107024)
+++ trunk/Source/WebCore/WebCore.gypi	2012-02-08 02:51:57 UTC (rev 107025)
@@ -2872,6 +2872,7 @@
 'platform/audio/ffmpeg/FFTFrameFFMPEG.cpp',
 'platform/audio/mac/FFTFrameMac.cpp',
 'platform/audio/mkl/FFTFrameMKL.cpp',
+'platform/audio/ipp/FFTFrameIPP.cpp',
 'platform/cf/BinaryPropertyList.cpp',
 'platform/cf/FileSystemCF.cpp',
 'platform/cf/KURLCFNet.cpp',


Modified: trunk/Source/WebCore/platform/audio/FFTFrame.h (107024 => 107025)

--- trunk/Source/WebCore/platform/audio/FFTFrame.h	2012-02-08 02:47:50 UTC (rev 107024)
+++ trunk/Source/WebCore/platform/audio/FFTFrame.h	2012-02-08 02:51:57 UTC (rev 107025)
@@ -60,6 +60,10 @@
 
 #endif // !USE_ACCELERATE_FFT
 
+#if USE(WEBAUDIO_IPP)
+#include ipps.h
+#endif //

[webkit-changes] [107026] trunk/Source

2012-02-07 Thread tony

Title: [107026] trunk/Source








Revision 107026
Author t...@chromium.org
Date 2012-02-07 19:00:36 -0800 (Tue, 07 Feb 2012)


Log Message
merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
https://bugs.webkit.org/show_bug.cgi?id=78036

Reviewed by Darin Adler.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebCore:

In r89362, we started running the preprocessor through CSSPropertyNames.in.
Now we can move DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
and wrap it in an #if.

No new tests, build refactoring.

* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
* DerivedSources.make: Remove DashboardSupportCSSPropertyNames.in.
* DerivedSources.pri: Remove DashboardSupportCSSPropertyNames.in.
* WebCore.xcodeproj/project.pbxproj: Remove DashboardSupportCSSPropertyNames.in.
* css/CSSPropertyNames.in: Wrap -webkit-dashboard-region in an #if.
* css/DashboardSupportCSSPropertyNames.in: Removed.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/DerivedSources.pri
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/css/CSSPropertyNames.in
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig


Removed Paths

trunk/Source/WebCore/css/DashboardSupportCSSPropertyNames.in




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (107025 => 107026)

--- trunk/Source/_javascript_Core/ChangeLog	2012-02-08 02:51:57 UTC (rev 107025)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-02-08 03:00:36 UTC (rev 107026)
@@ -1,3 +1,12 @@
+2012-02-07  Tony Chang  t...@chromium.org
+
+merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in
+https://bugs.webkit.org/show_bug.cgi?id=78036
+
+Reviewed by Darin Adler.
+
+* Configurations/FeatureDefines.xcconfig: Add ENABLE_DASHBOARD_SUPPORT to FEATURE_DEFINES.
+
 2012-02-07  Gyuyoung Kim  gyuyoung@samsung.com
 
 [CMAKE] Use *bin* and *lib* directories for executable and libraries.


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (107025 => 107026)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2012-02-08 02:51:57 UTC (rev 107025)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2012-02-08 03:00:36 UTC (rev 107026)
@@ -37,6 +37,8 @@
 ENABLE_CLIENT_BASED_GEOLOCATION = $(ENABLE_CLIENT_BASED_GEOLOCATION_$(REAL_PLATFORM_NAME));
 ENABLE_CLIENT_BASED_GEOLOCATION_macosx = ENABLE_CLIENT_BASED_GEOLOCATION;
 
+ENABLE_DASHBOARD_SUPPORT = ENABLE_DASHBOARD_SUPPORT;
+
 ENABLE_DATALIST = $(ENABLE_DATALIST_$(REAL_PLATFORM_NAME));
 ENABLE_DATALIST_macosx = ENABLE_DATALIST;
 
@@ -123,4 +125,4 @@
 ENABLE_WORKERS = ENABLE_WORKERS;
 ENABLE_XSLT = ENABLE_XSLT;
 
-FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CLIENT_BASED_GEOLOCATION) $(ENABLE_CSS_FILTERS) $(ENABLE_CSS_GRID_LAYOUT) $(ENABLE_CSS_SHADERS) $(ENABLE_DATALIST) $(ENABLE_DATA_TRANSFER_ITEMS) $(ENABLE_DETAILS) $(ENABLE_DEVICE_ORIENTATION) $(ENABLE_DIRECTORY_UPLOAD) $(ENABLE_FILE_SYSTEM) $(ENABLE_FILTERS) $(ENABLE_FULLSCREEN_API) $(ENABLE_GAMEPAD) $(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_INDEXED_DATABASE) $(ENABLE_INPUT_COLOR) $(ENABLE_INPUT_SPEECH) $(ENABLE_INPUT_TYPE_DATE) $(ENABLE_INPUT_TYPE_DATETIME) $(ENABLE_INPUT_TYPE_DATETIMELOCAL) $(ENABLE_INPUT_TYPE_MONTH) $(ENABLE_INPUT_TYPE_TIME) $(ENABLE_INPUT_TYPE_WEEK) $(ENABLE_JAVASCRIPT_DEBUGGER) $(ENABLE_LINK_PREFETCH) $(ENABLE_MATHML) $(ENABLE_MEDIA_SOURCE) $(ENABLE_MEDIA_STATISTICS) $(ENABLE_METER_TAG) $(ENABLE_MUTATION_OBSERVERS) $(ENABLE_NOTIFICATIONS) $(ENABLE_PAGE_VISIBILITY_API) $(ENABLE_PROGRESS_TAG) $(ENABLE_QUOTA) $(ENABLE_REGISTER_PROTOCOL_HANDLER) $(ENABLE_REQUEST_ANIMATION_FRAME) $(ENABLE_SHADOW_DOM) $(ENABLE_SHARED_WORKERS) $(ENABLE_SQL_DATABASE) $(ENABLE_STYLE_SCOPED) $(ENABLE_SVG) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS) $(ENABLE_TEXT_NOTIFICATIONS_ONLY) $(ENABLE_TOUCH_ICON_LOADING) $(ENABLE_VIDEO) $(ENABLE_VIDEO_TRACK) $(ENABLE_WEBGL) $(ENABLE_WEB_AUDIO) $(ENABLE_WEB_SOCKETS) $(ENABLE_WEB_TIMING) $(ENABLE_WORKERS) $(ENABLE_XSLT);
+FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ANIMATION_API) $(ENABLE_BLOB) $(ENABLE_CHANNEL_MESSAGING)

[webkit-changes] [107028] trunk/Source/WebKit2

2012-02-07 Thread timothy

Title: [107028] trunk/Source/WebKit2








Revision 107028
Author timo...@apple.com
Date 2012-02-07 19:20:07 -0800 (Tue, 07 Feb 2012)


Log Message
Avoid making a window for the Web Inspector when it is docked.

This also makes sure the inspector WKView is in a window before the page is loaded.
This avoids some redundant work caused by moving it to a window later.

https://webkit.org/b/78064

Reviewed by Brian Weinstein.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
(WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
(WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
(WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
(WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
(WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
(WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
(WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp
trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h
trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (107027 => 107028)

--- trunk/Source/WebKit2/ChangeLog	2012-02-08 03:10:38 UTC (rev 107027)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-08 03:20:07 UTC (rev 107028)
@@ -1,3 +1,30 @@
+2012-02-07  Timothy Hatcher  timo...@apple.com
+
+Avoid making a window for the Web Inspector when it is docked.
+
+This also makes sure the inspector WKView is in a window before the page is loaded.
+This avoids some redundant work caused by moving it to a window later.
+
+https://webkit.org/b/78064
+
+Reviewed by Brian Weinstein.
+
+* UIProcess/WebInspectorProxy.cpp:
+(WebKit::WebInspectorProxy::createInspectorPage): Set m_isAttached here...
+(WebKit::WebInspectorProxy::didLoadInspectorPage): ... instead of here.
+* UIProcess/WebInspectorProxy.h:
+(WebInspectorProxy):
+* UIProcess/mac/WebInspectorProxyMac.mm:
+(WebKit::WebInspectorProxy::createInspectorWindow): Added. Factored out of platformOpen.
+(WebKit::WebInspectorProxy::updateInspectorWindowTitle): Added. Factored out of platformInspectedURLChanged.
+(WebKit::WebInspectorProxy::platformCreateInspectorPage): Call platformAttach or createInspectorWindow.
+(WebKit::WebInspectorProxy::platformOpen): Make the view or window visible.
+(WebKit::WebInspectorProxy::platformDidClose): Only message m_inspectorWindow if it isn't nil.
+(WebKit::WebInspectorProxy::platformInspectedURLChanged): Store the urlString and call updateInspectorWindowTitle.
+(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Return early if not visible.
+(WebKit::WebInspectorProxy::platformAttach): Start out hidden if we are not visible yet. Destroy the window.
+(WebKit::WebInspectorProxy::platformDetach): Use createInspectorWindow to create it again.
+
 2012-02-07  Tony Chang  t...@chromium.org
 
 merge DashboardSupportCSSPropertyNames.in into CSSPropertyNames.in


Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (107027 => 107028)

--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp	2012-02-08 03:10:38 UTC (rev 107027)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp	2012-02-08 03:20:07 UTC (rev 107028)
@@ -207,6 +207,8 @@
 if (!m_page)
 return;
 
+m_isAttached = shouldOpenAttached();
+
 WebPageProxy* inspectorPage = platformCreateInspectorPage();
 ASSERT(inspectorPage);
 if (!inspectorPage)
@@ -216,7 +218,7 @@
 inspectorPageParameters = inspectorPage-creationParameters();
 
 String url = ""
-if (shouldOpenAttached())
+if (m_isAttached)
 url += ?docked=true;
 m_page-process()-assumeReadAccessToBaseURL(inspectorBaseURL());
 inspectorPage-loadURL(url);
@@ -225,7 +227,6 @@
 void WebInspectorProxy::didLoadInspectorPage()
 {
 m_isVisible = true;
-m_isAttached = shouldOpenAttached();
 
 // platformOpen is responsible for rendering attached mode depending on m_isAttached.
 platformOpen();


Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h (107027 => 107028)

--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.h

[webkit-changes] [107029] trunk/Source/WebCore

2012-02-07 Thread kling

Title: [107029] trunk/Source/WebCore








Revision 107029
Author kl...@webkit.org
Date 2012-02-07 19:26:18 -0800 (Tue, 07 Feb 2012)


Log Message
REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
http://webkit.org/b/78068

Reviewed by Ryosuke Niwa.

Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
This regressed in r106756 and I suspect it'll fix up the cycler regression.

* dom/StyledElement.cpp:
(WebCore::StyledElement::addCSSProperty):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/StyledElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107028 => 107029)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 03:20:07 UTC (rev 107028)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 03:26:18 UTC (rev 107029)
@@ -1,3 +1,16 @@
+2012-02-07  Andreas Kling  awesomekl...@apple.com
+
+REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.
+http://webkit.org/b/78068
+
+Reviewed by Ryosuke Niwa.
+
+Create CSS_IDENT values for attribute styles in the document's CSSValuePool.
+This regressed in r106756 and I suspect it'll fix up the cycler regression.
+
+* dom/StyledElement.cpp:
+(WebCore::StyledElement::addCSSProperty):
+
 2012-02-07  Noel Gordon  noel.gor...@gmail.com
 
 Remove TextureMapperQt from the gyp projects


Modified: trunk/Source/WebCore/dom/StyledElement.cpp (107028 => 107029)

--- trunk/Source/WebCore/dom/StyledElement.cpp	2012-02-08 03:20:07 UTC (rev 107028)
+++ trunk/Source/WebCore/dom/StyledElement.cpp	2012-02-08 03:26:18 UTC (rev 107029)
@@ -29,6 +29,7 @@
 #include CSSStyleSelector.h
 #include CSSStyleSheet.h
 #include CSSValueKeywords.h
+#include CSSValuePool.h
 #include Color.h
 #include ClassList.h
 #include ContentSecurityPolicy.h
@@ -142,9 +143,9 @@
 removeCSSProperty(id);
 }
 
-void StyledElement::addCSSProperty(int id, int value)
+void StyledElement::addCSSProperty(int propertyID, int identifier)
 {
-ensureAttributeStyle()-setProperty(id, value);
+ensureAttributeStyle()-setProperty(CSSProperty(propertyID, document()-cssValuePool()-createIdentifierValue(identifier)));
 }
 
 void StyledElement::addCSSImageProperty(int id, const String url)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107030] trunk

2012-02-07 Thread mikelawther

Title: [107030] trunk








Revision 107030
Author mikelawt...@chromium.org
Date 2012-02-07 19:40:33 -0800 (Tue, 07 Feb 2012)


Log Message
CSS3 calc() - simple parse time evaluation
https://bugs.webkit.org/show_bug.cgi?id=77960

Source/WebCore:

Adds simple number/percent _expression_ evaluation. rgb() and hsl() functions now
allow simple calc() expressions.

Reviewed by Ojan Vafai.

* css/CSSCalculationValue.cpp:
(WebCore):
(WebCore::CSSCalcValue::doubleValue):
(WebCore::CSSCalcPrimitiveValue::doubleValue):
(WebCore::CSSCalcBinaryOperation::doubleValue):
(CSSCalcBinaryOperation):
(WebCore::CSSCalcBinaryOperation::evaluate):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::isInt):
(CSSCalcValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parsedDouble):

LayoutTests:

Reviewed by Ojan Vafai.

* css3/calc/color-hsl-expected.txt:
* css3/calc/color-rgb-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/calc/color-hsl-expected.txt
trunk/LayoutTests/css3/calc/color-rgb-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSCalculationValue.cpp
trunk/Source/WebCore/css/CSSCalculationValue.h
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (107029 => 107030)

--- trunk/LayoutTests/ChangeLog	2012-02-08 03:26:18 UTC (rev 107029)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 03:40:33 UTC (rev 107030)
@@ -1,3 +1,13 @@
+2012-02-07  Mike Lawther  mikelawt...@chromium.org
+
+CSS3 calc() - simple parse time evaluation
+https://bugs.webkit.org/show_bug.cgi?id=77960
+
+Reviewed by Ojan Vafai.
+
+* css3/calc/color-hsl-expected.txt:
+* css3/calc/color-rgb-expected.txt:
+
 2012-02-07  Chris Palmer  pal...@google.com
 
 Resolve crash in FrameLoader::checkTimerFired.


Modified: trunk/LayoutTests/css3/calc/color-hsl-expected.txt (107029 => 107030)

--- trunk/LayoutTests/css3/calc/color-hsl-expected.txt	2012-02-08 03:26:18 UTC (rev 107029)
+++ trunk/LayoutTests/css3/calc/color-hsl-expected.txt	2012-02-08 03:40:33 UTC (rev 107030)
@@ -2,4 +2,4 @@
 These two sentences should be the same color (simple)
 These two sentences should be the same color (alpha)
 These two sentences should be the same color (alpha)
-FAIL
+PASS


Modified: trunk/LayoutTests/css3/calc/color-rgb-expected.txt (107029 => 107030)

--- trunk/LayoutTests/css3/calc/color-rgb-expected.txt	2012-02-08 03:26:18 UTC (rev 107029)
+++ trunk/LayoutTests/css3/calc/color-rgb-expected.txt	2012-02-08 03:40:33 UTC (rev 107030)
@@ -6,4 +6,4 @@
 C. These two sentences should be the same color (alpha)
 These two sentences should be the same color (percent alpha)
 These two sentences should be the same color (percent alpha)
-FAIL
+PASS


Modified: trunk/Source/WebCore/ChangeLog (107029 => 107030)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 03:26:18 UTC (rev 107029)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 03:40:33 UTC (rev 107030)
@@ -1,3 +1,27 @@
+2012-02-07  Mike Lawther  mikelawt...@chromium.org
+
+CSS3 calc() - simple parse time evaluation
+https://bugs.webkit.org/show_bug.cgi?id=77960
+
+Adds simple number/percent _expression_ evaluation. rgb() and hsl() functions now
+allow simple calc() expressions.
+
+Reviewed by Ojan Vafai.
+
+* css/CSSCalculationValue.cpp:
+(WebCore):
+(WebCore::CSSCalcValue::doubleValue):
+(WebCore::CSSCalcPrimitiveValue::doubleValue):
+(WebCore::CSSCalcBinaryOperation::doubleValue):
+(CSSCalcBinaryOperation):
+(WebCore::CSSCalcBinaryOperation::evaluate):
+* css/CSSCalculationValue.h:
+(CSSCalcExpressionNode):
+(WebCore::CSSCalcValue::isInt):
+(CSSCalcValue):
+* css/CSSParser.cpp:
+(WebCore::CSSParser::parsedDouble):
+
 2012-02-07  Andreas Kling  awesomekl...@apple.com
 
 REGRESSION(r106668-r106889): Chromium page cycler tests (Intl2) performance regressions.


Modified: trunk/Source/WebCore/css/CSSCalculationValue.cpp (107029 => 107030)

--- trunk/Source/WebCore/css/CSSCalculationValue.cpp	2012-02-08 03:26:18 UTC (rev 107029)
+++ trunk/Source/WebCore/css/CSSCalculationValue.cpp	2012-02-08 03:40:33 UTC (rev 107030)
@@ -76,6 +76,11 @@
 {
 return ;
 }
+
+double CSSCalcValue::doubleValue() const 
+{ 
+return m_expression-doubleValue();
+}
 
 CSSCalcExpressionNode::~CSSCalcExpressionNode() 
 {
@@ -94,7 +99,21 @@
 return m_value-cssText();
 }
 
-
+virtual double doubleValue() const
+{
+switch (m_category) {
+case CalcNumber:
+case CalcPercent:
+return m_value-getDoubleValue();
+case CalcLength:
+case CalcPercentLength:
+case CalcPercentNumber:
+case CalcOther:
+ASSERT_NOT_REACHED();
+break;
+}
+return 0;
+}
 private:
 explicit CSSCalcPrimitiveValue(CSSPrimitiveValue*

[webkit-changes] [107031] trunk/LayoutTests

Title: [107031] trunk/LayoutTests








Revision 107031
Author jchaffr...@webkit.org
Date 2012-02-07 19:53:22 -0800 (Tue, 07 Feb 2012)


Log Message
Unreviewed gardening.

Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg.

* platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added.
* platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added.
* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added.
* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png
trunk/LayoutTests/platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt
trunk/LayoutTests/platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt
trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png
trunk/LayoutTests/platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png
trunk/LayoutTests/platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png
trunk/LayoutTests/platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt
trunk/LayoutTests/platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt
trunk/LayoutTests/platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (107030 => 107031)

--- trunk/LayoutTests/ChangeLog	2012-02-08 03:40:33 UTC (rev 107030)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 03:53:22 UTC (rev 107031)
@@ -1,3 +1,20 @@
+2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
+
+Unreviewed gardening.
+
+Add / update the baselines for fast/text/synthetic-bold-transformed.html and svg/custom/use-disappears-after-style-update.svg.
+
+* platform/chromium-linux-x86/svg/custom/use-disappears-after-style-update-expected.txt: Added.
+* platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png: Added.
+* platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt: Added.
+* platform/chromium-mac-snowleopard/fast/text/synthetic-bold-transformed-expected.png: Added.
+* platform/chromium-mac-snowleopard/svg/custom/use-disappears-after-style-update-expected.png: Added.
+* platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Added.
+* platform/chromium-win-xp/svg/custom/use-disappears-after-style-update-expected.txt: Added.
+* platform/chromium-win/fast/text/synthetic-bold-transformed-expected.png: Added.
+* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Added.
+* platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.txt: Added.
+
 2012-02-07  Mike Lawther  mikelawt...@chromium.org
 
 CSS3 calc() - simple parse time evaluation


Added: trunk/LayoutTests/platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-linux/fast/text/synthetic-bold-transformed-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt (0 => 107031)

--- trunk/LayoutTests/platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/svg/custom/use-disappears-after-style-update-expected.txt	2012-02-08 03:53:22 UTC (rev 107031)
@@ -0,0 +1,17 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 300x400
+  RenderSVGRoot {svg} at (10,10) size 76x36
+RenderSVGHiddenContainer {defs} at (0,0) size 0x0
+  RenderSVGResourceFilter {filter} [id=simple] [filterUnits=objectBoundingBox] [primitiveUnits=userSpaceOnUse]
+[feOffset dx=0.00 dy=0.00]
+  [SourceGraphic]
+  RenderSVGRect {rect} at

[webkit-changes] [107032] trunk/Source/WebCore

2012-02-07 Thread eae

Title: [107032] trunk/Source/WebCore








Revision 107032
Author e...@chromium.org
Date 2012-02-07 19:56:27 -0800 (Tue, 07 Feb 2012)


Log Message
Add pixelSnappedX/Y/Width/Height methods
https://bugs.webkit.org/show_bug.cgi?id=78040

Reviewed by Eric Seidel.

Add pixel snapped versions of x/y/width/height methods. These return the
same value as the x/w/width/height methods for now but once we move over
to sub pixel layout they will snap the subpixel value to a device pixel
and return an integer value.

When snapping the left and top edge is simply rounded to the nearest
device pixel.
The right and bottom edges are computed by subtracting the rounded left/
top edge from the precise location and size. This ensures that the edges
all line up with device pixels and that the total size of an object,
including borders, is at most one pixel off.

In summary, the values are computed as follows:
x: round(x)
y: round(y)
maxX: round(x + width)
maxY: round(y + height)
width: round(x + width) - round(x)
height: round(y + height) - round(y)

We use the term pixel snapped to indicate that the numbers are not merely
rounded. This also matches the naming used by the line box tree.

No new tests, no functionality changes.

* page/PrintContext.cpp:
(WebCore::PrintContext::pageNumberForElement):
* rendering/RenderBlock.cpp:
(WebCorecollectIfNeeded):
* rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::FloatingObject::pixelSnappedX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxX):
(WebCore::RenderBlock::FloatingObject::pixelSnappedY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedMaxY):
(WebCore::RenderBlock::FloatingObject::pixelSnappedWidth):
(WebCore::RenderBlock::FloatingObject::pixelSnappedHeight):
(FloatingObject):
(WebCore::RenderBlock::pixelSnappedLogicalTopForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalBottomForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalLeftForFloat):
(WebCore::RenderBlock::pixelSnappedLogicalRightForFloat):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::pixelSnappedClientWidth):
(WebCore):
(WebCore::RenderBox::pixelSnappedClientHeight):
(WebCore::RenderBox::scrollHeight):
* rendering/RenderBox.h:
(WebCore::RenderBox::pixelSnappedWidth):
(WebCore::RenderBox::pixelSnappedHeight):
(RenderBox):
(WebCore::RenderBox::pixelSnappedOffsetWidth):
(WebCore::RenderBox::pixelSnappedOffsetHeight):
(WebCore::RenderBox::clientLogicalWidth):
(WebCore::RenderBox::clientLogicalHeight):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetWidth):
(WebCore):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetHeight):
* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::pixelSnappedOffsetLeft):
(WebCore::RenderBoxModelObject::pixelSnappedOffsetTop):
(RenderBoxModelObject):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::pixelSnappedScrollWidth):
(WebCore):
(WebCore::RenderLayer::pixelSnappedScrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
* rendering/RenderLayer.h:
(RenderLayer):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollHeight):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
* rendering/RenderTreeAsText.cpp:
(WebCore::write):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/PrintContext.cpp
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderBox.h
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
trunk/Source/WebCore/rendering/RenderBoxModelObject.h
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/RenderTreeAsText.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107031 => 107032)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 03:53:22 UTC (rev 107031)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 03:56:27 UTC (rev 107032)
@@ -1,3 +1,92 @@
+2012-02-07  Emil A Eklund  e...@chromium.org
+
+Add pixelSnappedX/Y/Width/Height methods
+https://bugs.webkit.org/show_bug.cgi?id=78040
+
+Reviewed by Eric Seidel.
+
+Add pixel snapped versions of x/y/width/height methods. These return the
+same value as the x/w/width/height methods for now but once we move over
+to sub pixel layout they will snap the subpixel value to a device pixel
+and return an integer value.
+
+When snapping the left and top

[webkit-changes] [107033] trunk/Source/WebKit

2012-02-07 Thread leo . yang

Title: [107033] trunk/Source/WebKit








Revision 107033
Author leo.y...@torchmobile.com.cn
Date 2012-02-07 20:05:20 -0800 (Tue, 07 Feb 2012)


Log Message
[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=77843

Reviewed by Rob Buis.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.

Modified Paths

trunk/Source/WebKit/ChangeLog


Added Paths

trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp
trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (107032 => 107033)

--- trunk/Source/WebKit/ChangeLog	2012-02-08 03:56:27 UTC (rev 107032)
+++ trunk/Source/WebKit/ChangeLog	2012-02-08 04:05:20 UTC (rev 107033)
@@ -1,3 +1,15 @@
+2012-02-07  Leo Yang  leo.y...@torchmobile.com.cn
+
+[BlackBerry] Upstream ChromeClientBlackBerry.{h, cpp}
+https://bugs.webkit.org/show_bug.cgi?id=77843
+
+Reviewed by Rob Buis.
+
+Initial upstream, no new tests.
+
+* blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp: Added.
+* blackberry/WebCoreSupport/ChromeClientBlackBerry.h: Added.
+
 2012-02-07  Rob Buis  rb...@rim.com
 
 [BlackBerry] Upstream DumpRenderTreeSupport


Added: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (0 => 107033)

--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp	(rev 0)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp	2012-02-08 04:05:20 UTC (rev 107033)
@@ -0,0 +1,843 @@
+/*
+ * Copyright (C) 2009 Torch Mobile Inc. http://www.torchmobile.com/
+ * Copyright (C) 2010, 2011, 2012 Research In Motion Limited. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+ */
+
+#include config.h
+#include ChromeClientBlackBerry.h
+
+#include BackingStore.h
+#include BackingStoreClient.h
+#include BackingStore_p.h
+#include CString.h
+#include DatabaseTracker.h
+#include Document.h
+#include DumpRenderTreeClient.h
+#include DumpRenderTreeSupport.h
+#include FileChooser.h
+#include FileIconLoader.h
+#include Frame.h
+#include FrameLoadRequest.h
+#include FrameLoader.h
+#include Geolocation.h
+#include GeolocationControllerClientBlackBerry.h
+#include HTMLInputElement.h
+#include HTMLNames.h
+#include HitTestResult.h
+#include Icon.h
+#include InputHandler.h
+#include KURL.h
+#include Node.h
+#include NotImplemented.h
+#include NotificationPresenterImpl.h
+#include Page.h
+#include PageGroup.h
+#include PageGroupLoadDeferrer.h
+#include PlatformString.h
+#include PopupMenuBlackBerry.h
+#include RenderView.h
+#include SVGZoomAndPan.h
+#include SearchPopupMenuBlackBerry.h
+#include SecurityOrigin.h
+#include SharedPointer.h
+#include ViewportArguments.h
+#include WebPage.h
+#include WebPageClient.h
+#include WebPage_p.h
+#include WebSettings.h
+#include WebString.h
+#include WindowFeatures.h
+#include BlackBerryPlatformLog.h
+#include BlackBerryPlatformSettings.h
+
+#define DEBUG_OVERFLOW_DETECTION 0
+
+using namespace BlackBerry::WebKit;
+
+namespace WebCore {
+
+static CString frameOrigin(Frame* frame)
+{
+DOMWindow* window = frame-domWindow();
+SecurityOrigin* origin = window-securityOrigin();
+CString latinOrigin = origin-toString().latin1();
+return latinOrigin;
+}
+
+ChromeClientBlackBerry::ChromeClientBlackBerry(WebPagePrivate* pagePrivate)
+: m_webPagePrivate(pagePrivate)
+{
+}
+
+void ChromeClientBlackBerry::addMessageToConsole(MessageSource, MessageType, MessageLevel, const String message, unsigned int lineNumber, const String sourceID)
+{
+#if ENABLE_DRT
+if (m_webPagePrivate-m_dumpRenderTree)
+m_webPagePrivate-m_dumpRenderTree-addMessageToConsole(message, lineNumber, sourceID);
+#endif
+
+m_webPagePrivate-m_client-addMessageToConsole(message.characters(), message.length(), sourceID.characters(), sourceID.length(), lineNumber);
+}
+
+void ChromeClientBlackBerry::runJavaScriptAlert(Frame* frame, const String message)
+{
+#if ENABLE_DRT
+if (m_webPagePrivate-m_dumpRenderTree) {
+m_webPagePrivate-m_dumpRenderTree-runJavaScriptAlert(message);
+return;
+

[webkit-changes] [107034] trunk/Source/WebCore

Title: [107034] trunk/Source/WebCore








Revision 107034
Author hara...@chromium.org
Date 2012-02-07 20:14:02 -0800 (Tue, 07 Feb 2012)


Log Message
[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
https://bugs.webkit.org/show_bug.cgi?id=78059

Reviewed by Adam Barth.

CodeGeneratorGObject.pm does not support custom attributes.
We can skip generating code for attributes with [Custom].
The change would make sense, since CodeGeneratorGObject.pm already
skips attributes with [CustomGetter] or [CustomSetter].

Test: bindings/scripts/test/TestObj.idl

* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107033 => 107034)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 04:05:20 UTC (rev 107033)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 04:14:02 UTC (rev 107034)
@@ -1,3 +1,21 @@
+2012-02-07  Kentaro Hara  hara...@chromium.org
+
+[GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm
+https://bugs.webkit.org/show_bug.cgi?id=78059
+
+Reviewed by Adam Barth.
+
+CodeGeneratorGObject.pm does not support custom attributes.
+We can skip generating code for attributes with [Custom].
+The change would make sense, since CodeGeneratorGObject.pm already
+skips attributes with [CustomGetter] or [CustomSetter].
+
+Test: bindings/scripts/test/TestObj.idl
+
+* bindings/scripts/CodeGeneratorGObject.pm:
+(SkipAttribute):
+* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
+
 2012-02-07  Emil A Eklund  e...@chromium.org
 
 Add pixelSnappedX/Y/Width/Height methods


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (107033 => 107034)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm	2012-02-08 04:05:20 UTC (rev 107033)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm	2012-02-08 04:14:02 UTC (rev 107034)
@@ -152,9 +152,10 @@
 
 sub SkipAttribute {
 my $attribute = shift;
-
-if ($attribute-signature-extendedAttributes-{CustomGetter} ||
-$attribute-signature-extendedAttributes-{CustomSetter}) {
+
+if ($attribute-signature-extendedAttributes-{Custom}
+|| $attribute-signature-extendedAttributes-{CustomGetter}
+|| $attribute-signature-extendedAttributes-{CustomSetter}) {
 return 1;
 }
 


Modified: trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp (107033 => 107034)

--- trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp	2012-02-08 04:05:20 UTC (rev 107033)
+++ trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp	2012-02-08 04:14:02 UTC (rev 107034)
@@ -1406,7 +1406,6 @@
 PROP_ATTR_WITH_SETTER_EXCEPTION,
 PROP_STRING_ATTR_WITH_GETTER_EXCEPTION,
 PROP_STRING_ATTR_WITH_SETTER_EXCEPTION,
-PROP_CUSTOM_ATTR,
 PROP_WITH_SCRIPT_STATE_ATTRIBUTE,
 PROP_WITH_SCRIPT_EXECUTION_CONTEXT_ATTRIBUTE,
 PROP_WITH_SCRIPT_STATE_ATTRIBUTE_RAISES,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107035] trunk

2012-02-07 Thread arv

Title: [107035] trunk








Revision 107035
Author a...@chromium.org
Date 2012-02-07 20:23:34 -0800 (Tue, 07 Feb 2012)


Log Message
[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
https://bugs.webkit.org/show_bug.cgi?id=78052

Reviewed by Nate Chapin.

Source/WebCore:

Before this patch the code generator did not add the named hidden reference when the data node
was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.

Covered by existing tests

* Target.pri:
* UseV8.cmake:
* WebCore.gypi:
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(HasCustomToV8Implementation):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
* bindings/v8/custom/V8NamedNodeMapCustom.cpp:

LayoutTests:

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/UseV8.cmake
trunk/Source/WebCore/WebCore.gypi
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp
trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp


Removed Paths

trunk/Source/WebCore/bindings/v8/custom/V8DOMTokenListCustom.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (107034 => 107035)

--- trunk/LayoutTests/ChangeLog	2012-02-08 04:14:02 UTC (rev 107034)
+++ trunk/LayoutTests/ChangeLog	2012-02-08 04:23:34 UTC (rev 107035)
@@ -1,3 +1,12 @@
+2012-02-07  Erik Arvidsson  a...@chromium.org
+
+[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
+https://bugs.webkit.org/show_bug.cgi?id=78052
+
+Reviewed by Nate Chapin.
+
+* platform/chromium/test_expectations.txt:
+
 2012-02-07  Julien Chaffraix  jchaffr...@webkit.org
 
 Unreviewed gardening.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107034 => 107035)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 04:14:02 UTC (rev 107034)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-02-08 04:23:34 UTC (rev 107035)
@@ -585,7 +585,6 @@
 BUGWK66377 : fast/dom/StyleSheet/gc-parent-rule.html = TEXT
 BUGWK66377 : fast/dom/StyleSheet/gc-parent-stylesheet.html = TEXT
 BUGWK66377 : fast/dom/StyleSheet/gc-rule-children-wrappers.html = TEXT
-BUGWK66377 : fast/dom/StyleSheet/gc-styleheet-wrapper.xhtml = TEXT
 
 // -
 // PENDING TESTS (forked to pending/, need to be sent upstream)


Modified: trunk/Source/WebCore/ChangeLog (107034 => 107035)

--- trunk/Source/WebCore/ChangeLog	2012-02-08 04:14:02 UTC (rev 107034)
+++ trunk/Source/WebCore/ChangeLog	2012-02-08 04:23:34 UTC (rev 107035)
@@ -1,3 +1,25 @@
+2012-02-07  Erik Arvidsson  a...@chromium.org
+
+[V8] Allow bindings for attributes on DOM nodes to also set a named hidden reference
+https://bugs.webkit.org/show_bug.cgi?id=78052
+
+Reviewed by Nate Chapin.
+
+Before this patch the code generator did not add the named hidden reference when the data node
+was a DOM Node. This lead to us having to create custom toV8 bindings in a few places.
+
+Covered by existing tests
+
+* Target.pri:
+* UseV8.cmake:
+* WebCore.gypi:
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrGetter):
+(HasCustomToV8Implementation):
+* bindings/v8/custom/V8DOMStringMapCustom.cpp:
+* bindings/v8/custom/V8DOMTokenListCustom.cpp: Removed.
+* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
+
 2012-02-07  Kentaro Hara  hara...@chromium.org
 
 [GTK] Ignore [Custom] attributes in CodeGeneratorGObject.pm


Modified: trunk/Source/WebCore/Target.pri (107034 => 107035)

--- trunk/Source/WebCore/Target.pri	2012-02-08 04:14:02 UTC (rev 107034)
+++ trunk/Source/WebCore/Target.pri	2012-02-08 04:23:34 UTC (rev 107035)
@@ -158,8 +158,7 @@
 bindings/v8/custom/V8InjectedScriptHostCustom.cpp \
 bindings/v8/custom/V8InjectedScriptManager.cpp \
 bindings/v8/custom/V8InspectorFrontendHostCustom.cpp \
-bindings/v8/custom/V8DOMStringMapCustom.cpp \
-bindings/v8/custom/V8DOMTokenListCustom.cpp
+bindings/v8/custom/V8DOMStringMapCustom.cpp
 
 SOURCES += \
 bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp \


Modified: trunk/Source/WebCore/UseV8.cmake (107034 => 107035)

--- trunk/Source/WebCore/UseV8.cmake	2012-02-08 04:14:02 UTC (rev 107034)
+++ trunk/Source/WebCore/UseV8.cmake	2012-02-08 04:23:34 UTC (rev 107035)
@@ -81,7 +81,6 @@
 bindings/v8/custom/V8CustomXPathNSResolver.cpp
 bindings/v8/custom/V8DOMFormDataCustom.cpp
 bindings/v8/custom/V8DOMStringMapCustom.cpp
-bindings/v8/custom/V8DOMTokenListCustom.cpp

[webkit-changes] [107037] trunk/Source/WebKit/chromium