Re: unable to compile wine from latest git
On Tue, Oct 4, 2011 at 3:52 AM, Austin English austinengl...@gmail.com wrote: On Mon, Oct 3, 2011 at 12:24, Vijay Kiran Kamuju infyqu...@gmail.com wrote: Hi, This is on fedora 15. I have just downloaded the fresh git, and attempting the my first build on this system. Please bottom-post on wine mailing lists. The source code is downloaded to a usb drive which is FAT32 formatted. Looking at $TOPDIR/Makefile: __builddeps__: dlls/libd3dcompiler.def dlls/libd3dcompiler.def: dlls/d3dcompiler_43/libd3dcompiler.def $(RM) $@ $(LN_S) d3dcompiler_43/libd3dcompiler.def $@ LN_S is `ln -s`, which will fail on a fat32 file system. You need to build on a file system that supports symlinks (ext3/4, xfs, nfs, etc.). -- -Austin Well, if you see configure script. There is an alternative for ln -s, and it is cp -p which is is used for MSYS and DJPP based builds. I modified the configure and it worked I will try to send that patch for review may be by evening. - Vijay
unable to compile wine from latest git
Hi, I just downloaded the git and tried compile it. I just issued `make` command after doing `./configure` But it gave the below errors: make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/tools/wrc' make[1]: Entering directory `/media/PENDRIVE/devel/repo/wine/include' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/include' make[1]: Entering directory `/media/PENDRIVE/devel/repo/wine/dlls/adsiid' make[1]: Nothing to be done for `all'. make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/dlls/adsiid' rm -f dlls/libd3dcompiler.def cp -p d3dcompiler_43/libd3dcompiler.def dlls/libd3dcompiler.def cp: cannot stat `d3dcompiler_43/libd3dcompiler.def': No such file or directory make: *** [dlls/libd3dcompiler.def] Error 1 Since the build of wine has changed a bit, i am unable to understand how to fix this issue. Thanks, Vijay
Re: unable to compile wine from latest git
On Mon, Oct 3, 2011 at 2:15 PM, Bruno Jesus 00cp...@gmail.com wrote: On Mon, Oct 3, 2011 at 09:03, Vijay Kiran Kamuju infyqu...@gmail.com wrote: Hi, I just downloaded the git and tried compile it. I just issued `make` command after doing `./configure` ... Since the build of wine has changed a bit, i am unable to understand how to fix this issue. Try make distclean ./configure make depend make It did not work, same error Try this too: git clean -fd I did it and then I tried 'make' still the same error. Now doing the distclean and recompling. Still the same can this be a file system issue. (i do not think it is) I can see that there is libd3dcompiler.def file Taken from: http://wine.1045685.n5.nabble.com/Latest-Git-Fails-tools-install-td1838892.html Vijay
Re: unable to compile wine from latest git
Hi, This is on fedora 15. I have just downloaded the fresh git, and attempting the my first build on this system. The source code is downloaded to a usb drive which is FAT32 formatted. The hardware is a Compaq laptop with core duo processor and 2 G RAM. Do you need any more details. Thanks, Vijay On Mon, Oct 3, 2011 at 8:17 PM, Austin English austinengl...@gmail.com wrote: On Mon, Oct 3, 2011 at 05:03, Vijay Kiran Kamuju infyqu...@gmail.com wrote: Hi, I just downloaded the git and tried compile it. I just issued `make` command after doing `./configure` But it gave the below errors: make[1]: Leaving directory `/media/PENDRIVE/devel/repo/wine/tools/wrc' What type of file system is that on? -- -Austin
Re: [3/3] msxml3: Support creating IXMLParser Interface (try 2)
On Wed, Sep 7, 2011 at 2:13 PM, Alistair Leslie-Hughes leslie_alist...@hotmail.com wrote: On 7/09/2011 9:43 PM, Nikolay Sivov wrote: (not related to patch contents) First time I saw this on a list I thought - god dammit, another parser interface. But looking at methods list it's probably a first candidate to be independent from libxml2 without any loss in functionality or big overhead like XPath or XSL things. We'll see. Is it mentioned as obsolete by any chance? Seems to be a kind of low level parser. Yes, these are marked as obsolete but are still valid interfaces for embedded windows. They are defined in xmlparser.idl but since there are marked as local, I believe they wont be registered as per normal. Best Regards Alistair Leslie-Hughes There is a bug# 5841 which depends on these functionality. This is a deprecrated functionality provided only by msxml3 Thanks, Vijay
Re: Wine and serial port AGAIN
Hi All, Can anyone tell me how to get that into the mainline kernel ASAP. Or Anyone can send it on my behalf to lkml list to get it into main line Thanks, Vijay On Sat, Dec 18, 2010 at 2:20 AM, Pavel Troller pat...@sinus.cz wrote: On Fri, Dec 17, 2010 at 8:42 AM, Wolfram Sang wolf...@the-dreams.de wrote: OT: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0bca1b913affbd7e2fdaffee62a499659a466eb5 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d281da7ff6f70efca0553c288bb883e8605b3862 This is kernel related :P Ehrm, where does that add a handler for pl2303.c? I just made a patch for it. Its not there in the kernel yet. I need someone to test it. Hi Vijay! IT WORKS!!! It REALLY works! Sorry for yelling, but it's really working! I've used the 2.6.36 version, which Vijay sent me privately, after adding a missing semicolon it compiled cleanly and since the first attempt, the program writes the radio PERFECTLY! It's even better than on windows, because on my colleague's computer, attempt to program the radio always gives error for the first time and one must click Retry. The second attempt is then OK. Here, it works without any glitch! So, really many thanks to Vijay and all the experts here, which found the real cause of this problem! And sorry for blaming wine, it was not its fault! With regards, Pavel
Re: Wine and serial port AGAIN
On Fri, Dec 17, 2010 at 6:42 AM, Wolfram Sang wolf...@the-dreams.de wrote: On 17/12/10 11:21, Uwe Bonnes wrote: Pavel == Pavel Troller pat...@sinus.cz writes: Pavel Hi! As a technician, I need often to use some form of serial Pavel port communication. My recent experience is with a program for ... Pavel power-cycled. The radio is connected using a USB cable, which Pavel contains just a regular PL-2303 USB to serial converter, which is Pavel perfectly supported in Linux. Port assignment for wine is also It seems that the PL2303 driver doesn't implement TIOCGICOUNT /usr/src/linux/usb/serial/pl2303.c Well, no, this ioctl gets handled by the tty-layer. Yes, the driver needs to define a get_icount-routine which it lacks. I think this is introduced in kernel 2.6.37 (not yet released) Regards, Wolfram
Re: Wine and serial port AGAIN
On Fri, Dec 17, 2010 at 7:28 AM, Wolfram Sang wolf...@the-dreams.de wrote: It seems that the PL2303 driver doesn't implement TIOCGICOUNT /usr/src/linux/usb/serial/pl2303.c Well, no, this ioctl gets handled by the tty-layer. Yes, the driver needs to define a get_icount-routine which it lacks. I think this is introduced in kernel 2.6.37 (not yet released) So, its commit-id would be? ;) (And I can't see anything even in linux-next...) Anyway, this driver-talk became offtopic for this list. OT: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0bca1b913affbd7e2fdaffee62a499659a466eb5 http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d281da7ff6f70efca0553c288bb883e8605b3862 This is kernel related :P Regards, Wolfram
Re: Wine and serial port AGAIN
On Fri, Dec 17, 2010 at 8:42 AM, Wolfram Sang wolf...@the-dreams.de wrote:
OT:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0bca1b913affbd7e2fdaffee62a499659a466eb5
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=d281da7ff6f70efca0553c288bb883e8605b3862
This is kernel related :P
Ehrm, where does that add a handler for pl2303.c?
I just made a patch for it.
Its not there in the kernel yet.
I need someone to test it.
attaching the c file
/*
* Prolific PL2303 USB to serial adaptor driver
*
* Copyright (C) 2001-2007 Greg Kroah-Hartman (g...@kroah.com)
* Copyright (C) 2003 IBM Corp.
*
* Original driver for 2.2.x by anonymous
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License version
* 2 as published by the Free Software Foundation.
*
* See Documentation/usb/usb-serial.txt for more information on using this
* driver
*
*/
#include linux/kernel.h
#include linux/errno.h
#include linux/init.h
#include linux/slab.h
#include linux/tty.h
#include linux/tty_driver.h
#include linux/tty_flip.h
#include linux/serial.h
#include linux/module.h
#include linux/moduleparam.h
#include linux/spinlock.h
#include linux/uaccess.h
#include linux/usb.h
#include linux/usb/serial.h
#include pl2303.h
/*
* Version Information
*/
#define DRIVER_DESC Prolific PL2303 USB to serial adaptor driver
static int debug;
#define PL2303_CLOSING_WAIT (30*HZ)
static const struct usb_device_id id_table[] = {
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID) },
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_RSAQ2) },
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_DCU11) },
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_RSAQ3) },
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_PHAROS) },
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_ALDIGA) },
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_MMX) },
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_GPRS) },
{ USB_DEVICE(PL2303_VENDOR_ID, PL2303_PRODUCT_ID_HCR331) },
{ USB_DEVICE(IODATA_VENDOR_ID, IODATA_PRODUCT_ID) },
{ USB_DEVICE(IODATA_VENDOR_ID, IODATA_PRODUCT_ID_RSAQ5) },
{ USB_DEVICE(ATEN_VENDOR_ID, ATEN_PRODUCT_ID) },
{ USB_DEVICE(ATEN_VENDOR_ID2, ATEN_PRODUCT_ID) },
{ USB_DEVICE(ELCOM_VENDOR_ID, ELCOM_PRODUCT_ID) },
{ USB_DEVICE(ELCOM_VENDOR_ID, ELCOM_PRODUCT_ID_UCSGT) },
{ USB_DEVICE(ITEGNO_VENDOR_ID, ITEGNO_PRODUCT_ID) },
{ USB_DEVICE(ITEGNO_VENDOR_ID, ITEGNO_PRODUCT_ID_2080) },
{ USB_DEVICE(MA620_VENDOR_ID, MA620_PRODUCT_ID) },
{ USB_DEVICE(RATOC_VENDOR_ID, RATOC_PRODUCT_ID) },
{ USB_DEVICE(TRIPP_VENDOR_ID, TRIPP_PRODUCT_ID) },
{ USB_DEVICE(RADIOSHACK_VENDOR_ID, RADIOSHACK_PRODUCT_ID) },
{ USB_DEVICE(DCU10_VENDOR_ID, DCU10_PRODUCT_ID) },
{ USB_DEVICE(SITECOM_VENDOR_ID, SITECOM_PRODUCT_ID) },
{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_ID) },
{ USB_DEVICE(SAMSUNG_VENDOR_ID, SAMSUNG_PRODUCT_ID) },
{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_SX1) },
{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X65) },
{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_X75) },
{ USB_DEVICE(SIEMENS_VENDOR_ID, SIEMENS_PRODUCT_ID_EF81) },
{ USB_DEVICE(BENQ_VENDOR_ID, BENQ_PRODUCT_ID_S81) }, /* Benq/Siemens S81 */
{ USB_DEVICE(SYNTECH_VENDOR_ID, SYNTECH_PRODUCT_ID) },
{ USB_DEVICE(NOKIA_CA42_VENDOR_ID, NOKIA_CA42_PRODUCT_ID) },
{ USB_DEVICE(CA_42_CA42_VENDOR_ID, CA_42_CA42_PRODUCT_ID) },
{ USB_DEVICE(SAGEM_VENDOR_ID, SAGEM_PRODUCT_ID) },
{ USB_DEVICE(LEADTEK_VENDOR_ID, LEADTEK_9531_PRODUCT_ID) },
{ USB_DEVICE(SPEEDDRAGON_VENDOR_ID, SPEEDDRAGON_PRODUCT_ID) },
{ USB_DEVICE(DATAPILOT_U2_VENDOR_ID, DATAPILOT_U2_PRODUCT_ID) },
{ USB_DEVICE(BELKIN_VENDOR_ID, BELKIN_PRODUCT_ID) },
{ USB_DEVICE(ALCOR_VENDOR_ID, ALCOR_PRODUCT_ID) },
{ USB_DEVICE(WS002IN_VENDOR_ID, WS002IN_PRODUCT_ID) },
{ USB_DEVICE(COREGA_VENDOR_ID, COREGA_PRODUCT_ID) },
{ USB_DEVICE(YCCABLE_VENDOR_ID, YCCABLE_PRODUCT_ID) },
{ USB_DEVICE(SUPERIAL_VENDOR_ID, SUPERIAL_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LD220_PRODUCT_ID) },
{ USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
{ USB_DEVICE(ZEAGLE_VENDOR_ID, ZEAGLE_N2ITION3_PRODUCT_ID) },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) },
{ USB_DEVICE(SANWA_VENDOR_ID, SANWA_PRODUCT_ID) },
{ USB_DEVICE(ADLINK_VENDOR_ID, ADLINK_ND6530_PRODUCT_ID) },
{ } /* Terminating entry */
};
MODULE_DEVICE_TABLE(usb, id_table);
static struct usb_driver pl2303_driver = {
.name = pl2303,
.probe = usb_serial_probe,
.disconnect = usb_serial_disconnect,
.id_table = id_table,
.suspend = usb_serial_suspend,
.resume = usb_serial_resume,
.no_dynamic_id = 1,
.supports_autosuspend = 1,
};
#define SET_LINE_REQUEST_TYPE 0x21
#define SET_LINE_REQUEST 0x20
#define SET_CONTROL_REQUEST_TYPE 0x21
#define SET_CONTROL_REQUEST 0x22
#define CONTROL_DTR 0x01
#define CONTROL_RTS 0x02
#define BREAK_REQUEST_TYPE 0x21
#define BREAK_REQUEST 0x23
#define
WebKit vs Gecko and Wine
Hi, I have a nice idea to discuss at wineconf this year. Is it possible to use webkit for mshtml and jscript implementations of wine? Have been hearing a lotta good reviews about performance of webkit and lotta other browsers adopting it. How much work would it be to support webkit as to provide an alternative for winegecko? Firstly is it feasible. Thanks, VJ - Zsa Zsa Gabor - He taught me housekeeping; when I divorce I keep the house.
Re: Problems Running Windows app
Hi,
Please post this a bug in bugzilla.
Also please post the detailed logs in the bug description.
Please also provide a link and name of the software you are trying to run.
Also try testing with the latest wine 1.1.3
Thanks,
Vijay
Fran Lebowitz - Life is something to do when you can't get to sleep.
On Fri, Aug 29, 2008 at 3:10 AM, Chris Vermeulen
[EMAIL PROTECTED] wrote:
Hi
Please help me I'm currently running ubuntu 8.04, with wine 1.0 I've got
a program that I use to program Telephone systems. It uses a SQL
database with a web interface. but I can't get this to work on wine, if
I want to install it gives me the following and just closes.
Usage:
Install a product:
msiexec {package|productcode} [property]
msiexec /i {package|productcode} [property]
msiexec /a package [property]
Repair an installation:
msiexec /f[p|o|e|d|c|a|u|m|s|v] {package|productcode}
Uninstall a product:
msiexec /x {package|productcode} [property]
Advertise a product:
msiexec /j[u|m] package [/t transform] [/g languageid]
msiexec {u|m} package [/t transform] [/g languageid]
Apply a patch:
msiexec /p patchpackage [property]
msiexec /p patchpackage /a package [property]
Modifiers for above operations:
msiexec /l[*][i|w|e|a|r|u|c|m|o|p|v|][+|!] logfile
msiexec /q{|n|b|r|f|n+|b+|b-}
Register a module:
msiexec /y module
Unregister a module:
msiexec /z module
Display usage and copyright:
msiexec {/h|/?}
NOTE: Product code on commandline unimplemented as of yet
Copyright 2004 Vincent B�ron
Please help I'm hate this dual booting into windows. If I can get this
working It'll be like a huge Christmas gift. If you need the program let
me know and I'll get it to you
Thanks
Chris Vermeulen
#
Notice
This e-mail message and/or attachments may contain information
that is confidential to ITEC and/or any of its affiliated companies.
If you are not the intended recipient you cannot use, distribute or copy the
message and/or
attachments. In such a case, please notify the sender by return
e-mail immediately and erase all copies of the message and/or
attachments. Opinions, conclusions and other information in this
message and/or attachments that do not relate to the official
business of ITEC or any of its affiliated companies are neither given nor
endorsed by it.
ITEC and its affiliated companies accept no liability or responsibility of
whatever nature
for any failure or loss arising from the use of email as a form of
communication.
#
improvement to patchwatcher
Hi, Is it possible to add column to the patchwatcher, whether the patch has been rejected/accepted/pending into git. Also please skip the mail entries if they do have Re: in the subject and do not have any patch. Mark the corresponding patch to rejected/needs more work. Thanks, VJ --- Fred Allen - California is a fine place to live - if you happen to be an orange.
Re: Patchwatcher online
Yes. I already changed the success message to make more sense,
and added background colors of green and red for success and failure.
I dislike the implementation, while I like the idea. You now have:
a:visited { color: #FF; }
.fail { background color: #ff5050; }
At least on my laptop display, #ff5050 on #ff is quite hard to read.
I think making the a:visited link for pass or fail to be balck is good enough.
I think this should do the trick.
.pass a:visited { color: #00; }
.fail a:visited { color: #00; }
---
VJ
Re: [advapi32] - Add stub for ConvertToAutoInheritPrivateObjectSecurity
On Mon, Aug 11, 2008 at 11:59 PM, Dmitry Timoshkov
[EMAIL PROTECTED] wrote:
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote:
+BOOL WINAPI ConvertToAutoInheritPrivateObjectSecurity(
+PSECURITY_DESCRIPTOR ParentDescriptor,
+PSECURITY_DESCRIPTOR CreatorDescriptor,
+PSECURITY_DESCRIPTOR* NewDescriptor,
+GUID* ObjectType,
+BOOL IsDirectoryObject,
+PGENERIC_MAPPING GenericMapping )
+{
+FIXME(%p %p %p %p %d %p - stub\n, ParentDescriptor,
CreatorDescriptor,
+ NewDescriptor, ObjectType, IsDirectoryObject, GenericMapping);
+
+return FALSE;
+}
It would be better to not copy variable names from MSDN/PSDK and come up
with your own naming. Say, (parent, creator, new, type, is_directory,
mapping)
would work.
I just used the CreatePrivateObjectSecurity as an example, it used
MSDN/PSDK naming.
--- a/include/winbase.h
+++ b/include/winbase.h
@@ -1373,6 +1373,7 @@ WINBASEAPI HANDLE WINAPI
CreateNamedPipeW(LPCWSTR,DWORD,DWORD,DWORD,DWORD,D
#define CreateNamedPipe
WINELIB_NAME_AW(CreateNamedPipe)
WINBASEAPI BOOLWINAPI
CreatePipe(PHANDLE,PHANDLE,LPSECURITY_ATTRIBUTES,DWORD);
WINADVAPI BOOLWINAPI
CreatePrivateObjectSecurity(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR*,BOOL,HANDLE,PGENERIC_MAPPING);
+WINADVAPI BOOLWINAPI
ConvertToAutoInheritPrivateObjectSecurity(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR*,GUID*,BOOL,PGENERIC_MAPPING);
WINBASEAPI BOOLWINAPI
CreateProcessA(LPCSTR,LPSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCSTR,LPSTARTUPINFOA,LPPROCESS_INFORMATION);
WINBASEAPI BOOLWINAPI
CreateProcessW(LPCWSTR,LPWSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCWSTR,LPSTARTUPINFOW,LPPROCESS_INFORMATION);
#define CreateProcess
WINELIB_NAME_AW(CreateProcess)
Please keep the entries alphabetically sorted.
Ok.
I will send another version with the changes soon.
---
VJ
Re: Patchwatcher online
Hi, I have one more concern. Its regarding running of tests. When running tests for the patch, I think we should just run the tests of the dlls that are affected direct;y or indirectly by that change. its running the tests for entire wine, which is very time consuming. What will happen if we have patch barrage, like once when alexander comes from vacation. How much time will that take for verification of the entire patch tree submitted then. Just my $0.02 Thanks, VJ On Mon, Aug 11, 2008 at 3:05 PM, Dan Kegel [EMAIL PROTECTED] wrote: On Mon, Aug 11, 2008 at 10:13 AM, Michael Karcher [EMAIL PROTECTED] wrote: Am Montag, den 11.08.2008, 09:45 -0700 schrieb Dan Kegel: The scripts now run conformance tests and report regressions. Does Ditto, but just the new error:end of output mean that there are no new errors? Yes. Sorry, I'll tidy that up tonight, it really should say no regressions found.
Re: Patchwatcher online
On Mon, Aug 11, 2008 at 7:42 PM, Dan Kegel [EMAIL PROTECTED] wrote: On Mon, Aug 11, 2008 at 4:31 PM, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: When running tests for the patch, I think we should just run the tests of the dlls that are affected direct;y or indirectly by that change. its running the tests for entire wine, which is very time consuming. True, but hey, it was easier to code. And getting anything like this working at all is pretty hard. Figuring out which tests a give patch affects is an extra challenge I'd rather not face just now. Once it's up and working well we can refine it. Ok I was expressing my concern as it took around 2-3hrs to see my patch in the patchwatcher. Also as you you running the wine tests all for each patch are you cleaning the .wine directory ( I am bit confused here) What will happen if we have patch barrage, like once when alexander comes from vacation. It'll fall behind some. If need be, I can run it on a really fast machine. It would better if we have a parallelized version of the tests also run on a fast m/c. Also can you improve the messages. If there are errors, Its possible to only show the test data that failed rather than the complete test run. Also put it in a public repository with you as sole commiter. So If we have any suggestions/improvements, can mail you with the changes (We will not flood ur mail box ;) ) VJ - dan
Re: Patchwatcher online
On Mon, Aug 11, 2008 at 8:34 PM, Dan Kegel [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Ok I was expressing my concern as it took around 2-3hrs to see my patch in the patchwatcher. It's running on a 1GHz single core machine right now. I'll probably put it on something rather faster. Something around 2GHz would be ok Also as you you running the wine tests all for each patch are you cleaning the .wine directory ( I am bit confused here) No. Probably should, but I'm not. I think you should do that, if there are some changes that involve wineserver and some change to registry. It would better if we have a parallelized version of the tests also run on a fast m/c. I do have a patch that enables parallel execution of conformance tests, I hope Alexandre accepts it. That will help on multicore systems. Beyond that, I could fairly easily use multiple machines, e.g. assign all patches to machines based on md5sum. Ok, it would be interesting how parallelization could affect wine :) Also can you improve the messages. Yes. I already changed the success message to make more sense, and added background colors of green and red for success and failure. Also add Yellow for ignored patches. For ignored patches /i would like to add a second pass, when have to check if the patch is generated by git or not if not patch is being ignored now, for that we need to process the patch to see whether we can extract some info to send the correct patch level. If there are errors, Its possible to only show the test data that failed rather than the complete test run. Yes. Also put it in a public repository with you as sole commiter. Already there, see http://code.google.com/p/winezeug/ Thanks So If we have any suggestions/improvements, can mail you with the changes (We will not flood ur mail box ;) ) Please do. I will look into it now VJ
Re: Patchwatcher online
On Mon, Aug 11, 2008 at 11:02 PM, Dan Kegel [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Also add Yellow for ignored patches. Let me think on that a bit. Probably. For ignored patches /i would like to add a second pass, when have to check if the patch is generated by git or not if not patch is being ignored now, for that we need to process the patch to see whether we can extract some info to send the correct patch level. Yes, I plan to add a little code to try to guess the right argument to -p. Ahh... I forgot how to handle dependent patches, if they are not in a patch series Sorry, I always seem to get all kinda of weird ideas about how things can go wrong VJ
Re: Concerning Bug 11509 (AES Provider Handling for Windows XP)
Hi, Modifying an existing key is not a good idea. Julliard, is also against it, hence rejected my second try. It will fail for 2003 and Vista. I am working on a fix. Having no time to test, my last days on my current project at work. Pretty busy :( Will send the new patch on monday. Thanks, VJ On Sat, May 10, 2008 at 6:30 PM, Mounir IDRASSI [EMAIL PROTECTED] wrote: Hi, From what I see, the patch correcting this bug from Vijay has been refused because it modifies the name of the RSA and AES provider, which is wrong. However, this patch can be easily changed to keep the current name and simply add a new provider name. So, the declaration of the variable szRSAName should be changed to static const WCHAR szRSAName[4][66] and its value appended at the end with the new name of the provider for XP instead of modifying the last field. This way, I'm sure the patch will be accepted. Vijay : can you submit a modified version of your patch. Cheers, Mounir IDRASSI IDRIX - Cryptography And IT Security Experts http://www.idrix.fr
RE: [PATCH] winecfg = control panel applets patch
Hi, This is regarding the control panel applet patch you have submitted to wine-patches. I would like to have the applets should be part of wine's control program. They would be better be as files in the /programs/control/ And you should extend the existing control.exe and winecfg in wine to open these applets. Please correct me if I am wrong. Just my 2 cents. VJ
Re: [rsaenh] Fix AES Provider Handling for Windows XP (resend)
Hi, Please let me know why this patch has been rejected. http://www.winehq.org/pipermail/wine-patches/2008-February/049817.html It seems this patch has gone completely unnoticed. Please Comment. Somehow, my patches are not getting commited/reviewed. Did I do anything wrong, please do tell me. Thanks, Vijay 2008/2/8 Vijay Kiran Kamuju [EMAIL PROTECTED]: ChangeLog Fix the AES Provider Handling for Windows XP by adding AES Provider string for XP in wine registry Bug#11509
Re: winedbg - using pdb from Visual Studio 2005
Hi, can you try this patch: http://www.winehq.org/pipermail/wine-patches/2008-January/049156.html I think currently dbghelp in wine doesnt support pdb files generated by VS 2005. Thanks, VJ On Feb 5, 2008 12:54 PM, Michel Jacques [EMAIL PROTECTED] wrote: Hello, I am using PDBs generated with 2005 with wine version 0.9.54. I get errors related to my PDBs and I am wondering if I need to change the pdb format? Anything special to do when using 2005? Here are the errors I get, each time one of my pdb gets loaded: 0009:trace:dbghelp:SymFindFileInPathW (hProcess = 0x30, searchPath = (null), full_path = LC:\\master\\x86\\debug\\bin\\mydll.pdb, id = 0x34c160, two = 0x0002, three = 0x, flags = 0x0008, buffer = 0x34b718, cb = 0x6020fb50, user = 0x34bd30) 0009:err:dbghelp_msc:pdb_process_types -Unknown type info version 20040203 0009:err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols 0009:trace:dbghelp:pcs_callback 0x111998 2 0x34c378 0009:trace:dbghelp:pcs_callback 0x111998 1 0x34c378 0009:trace:dbghelp:pe_load_stabs failed to load the STABS debug info Thanks, Michel Jacques Découvrez les styles qui font sensation sur Yahoo! Québec Avatars. http://cf.avatars.yahoo.com/
Re: winedbg - using pdb from Visual Studio 2005
can you also try this patch also?
--
VJ
On Feb 5, 2008 12:02 PM, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote:
Hi,
can you try this patch:
http://www.winehq.org/pipermail/wine-patches/2008-January/049156.html
I think currently dbghelp in wine doesnt support pdb files generated by VS
2005.
Thanks,
VJ
On Feb 5, 2008 12:54 PM, Michel Jacques [EMAIL PROTECTED] wrote:
Hello,
I am using PDBs generated with 2005 with wine version 0.9.54.
I get errors related to my PDBs and I am wondering if I need
to change the pdb format? Anything special to do when using 2005?
Here are the errors I get, each time one of my pdb gets loaded:
0009:trace:dbghelp:SymFindFileInPathW (hProcess = 0x30, searchPath =
(null), full_path =
LC:\\master\\x86\\debug\\bin\\mydll.pdb, id = 0x34c160, two = 0x0002,
three = 0x,
flags = 0x0008, buffer = 0x34b718, cb = 0x6020fb50, user = 0x34bd30)
0009:err:dbghelp_msc:pdb_process_types -Unknown type info version 20040203
0009:err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading
symbols
0009:trace:dbghelp:pcs_callback 0x111998 2 0x34c378
0009:trace:dbghelp:pcs_callback 0x111998 1 0x34c378
0009:trace:dbghelp:pe_load_stabs failed to load the STABS debug info
Thanks,
Michel Jacques
Découvrez les styles qui font sensation sur Yahoo! Québec Avatars.
http://cf.avatars.yahoo.com/
diff --git a/dlls/dbghelp/msc.c b/dlls/dbghelp/msc.c
index 66a2570..78af43f 100644
--- a/dlls/dbghelp/msc.c
+++ b/dlls/dbghelp/msc.c
@@ -1944,7 +1944,8 @@ static void pdb_process_types(const struct msc_debug_info* msc_dbg,
case 19950410: /* VC 4.0 */
case 19951122:
case 19961031: /* VC 5.0 / 6.0 */
-case 19990903:
+case 19990903: /* VC 7.0 */
+case 20040203: /* VC 8.0 */
break;
default:
ERR(-Unknown type info version %d\n, types.version);
@@ -2184,7 +2185,8 @@ static BOOL pdb_process_internal(const struct process* pcs,
case 0:/* VC 4.0 */
case 19960307: /* VC 5.0 */
case 19970606: /* VC 6.0 */
-case 19990903:
+case 19990903: /* VC 7.0 */
+case 20040203: /* VC 8.0 */
break;
default:
ERR(-Unknown symbol info version %d %08x\n,
@@ -2194,11 +2196,14 @@ static BOOL pdb_process_internal(const struct process* pcs,
pdb_process_symbol_imports(pcs, msc_dbg, symbols, symbols_image, image, pdb_lookup, module_index);
/* Read global symbol table */
-modimage = pdb_read_file(image, pdb_lookup, symbols.gsym_file);
+/* only the low word of gsym_file is the file number for the symbols file. On VC 8.0 the high word
+ is always 0x002a, on VC 7.0 its 0x. similarly hash1_file and hash2_file the high word values
+ for VC 7.0 are 0x38a0 and 0x0c05 and for VC 8.0 they are 0x8800 and 0xc267 respectively. */
+modimage = pdb_read_file(image, pdb_lookup, symbols.gsym_file 0x);
if (modimage)
{
codeview_snarf(msc_dbg, modimage, 0,
- pdb_get_file_size(pdb_lookup, symbols.gsym_file), NULL);
+ pdb_get_file_size(pdb_lookup, symbols.gsym_file 0x), NULL);
pdb_free(modimage);
}
@@ -2231,6 +2236,12 @@ static BOOL pdb_process_internal(const struct process* pcs,
pdb_free(modimage);
}
+
+/* PDB files generated from VC 8.0 use a new format for storing linee no information.
+ The lineno_size member of PDB_SYMBOL_EX header is 0 but unknown2 has a value. */
+if (sfile.unknown2 sfile.lineno_size == 0)
+FIXME(Line no info is missing.\n);
+
file_name = (const char*)file + size;
file_name += strlen(file_name) + 1;
file = (BYTE*)((DWORD)(file_name + strlen(file_name) + 1 + 3) ~3);
@@ -2281,6 +2292,9 @@ static BOOL pdb_process_file(const struct process* pcs,
msc_dbg-module-module.SourceIndexed = TRUE;
msc_dbg-module-module.Publics = TRUE;
}
+else
+ TRACE(failed to load pdb file.\n);
+
return ret;
}
Re: GOM player
It blew up in wine or windows. Is it a problem with wine. What about other media types. -- VJ On 1/17/08, Dan Kegel [EMAIL PROTECTED] wrote: http://www.guardian.co.uk/technology/2008/jan/17/linux.korea says everyone in Korea uses the GOM player instead of Windows Media Player. It installs ok, but blew up when I tried to load the Sony music stream from its playlist. Free download http://www.gomplayer.com/ supposedly comes with lots of codecs. - Dan
Re: IDirectSound and Unknown IID
Hi,
if you could mention the application/game name, it would be gr8.
also a note to all the people who send fix-bug requests please mention
the app/game name in the mails.
if anyone who can put that in some documentation/some place in the
website that would be gr8.
Thanks,
vj
On Dec 29, 2007 10:51 AM, Guillaume B. [EMAIL PROTECTED] wrote:
Hi,
First post here, so I don't know if it's the right place for this.
I'm trying to make the sound and music work in a game with Wine. Currently,
the sound doesn't work because the game does some tests to check if
everything is OK before it starts the music.
For now, it fails early in those tests but I've hacked some things in the
latest git source and the game goes a little farther before it stops trying
to make the sound and music work. But now I'm stuck so I was wondering if
anyone had an idea.
Here's a part of the dsound trace:
trace:dsound:IDirectSound8_IDirectSound8_QueryInterface (0x2ce8de8
{2a8af120-e9de-4132-aaa5-4bdda5f325b8},0x34d634)
trace:dsound:DSOUND_QueryInterface8 (0x2fdc1e0
{2a8af120-e9de-4132-aaa5-4bdda5f325b8},0x34d634)
warn:dsound:DSOUND_QueryInterface8 Unknown IID
{2a8af120-e9de-4132-aaa5-4bdda5f325b8}
So the problem is that the interace {2a8af120-e9de-4132-aaa5-4bdda5f325b8}
is not supported by the current Wine implementation. I've searched around
but I couldn't find anything about this IID. If I knew what interface it
was, maybe I could implement a stub and it might make the sound work.
So does anyone as an idea?
Thanks,
Guillaume B.
bugs audit volunteers required
Hi, just like last year we did an audit of all the bugs in bugzilla. I think this year also we should do the same, the bugs are growing large and older bugs are being neglected. just wanted to say that we need to check all the old open bugs, and test them/ask the user for status. Close the bug as Abandoned if there is no response. also test the application yourself on latest git. this is the work to be done. and we need volunteers for this work. need volunteers to clear up the mess(old abandoned bugs) in bugzilla Thanks, vj
Re: bugs audit volunteers required
On Dec 31, 2007 6:49 PM, Austin English [EMAIL PROTECTED] wrote: On Dec 31, 2007 6:42 PM, James McKenzie [EMAIL PROTECTED] wrote: I agree. If you cannot find the application or a demo version to work with, how can you fix the bug. Logs and other helpers go a long way. Maybe an intro page as to what is needed and how to get it. This will become more and more critical as the project approaches 'release' status (1.0). Also, marking bugs as having insufficient information to fix advises the reporter that the project needs more information to help or troubleshoot. Maybe add a resolution of NEEDMOREINFO? +1 vote from me This would put a heavy load on the bug admins and actually slow down the process. I work on other projects. Clicking on the NEW BUG link should take a person to a web page with reporting criteria. At this point, the reporter will read through a page of what should be done to report a bug. After clicking a 'I read and understand the reporting requirements', then the reporter will be able to submit a bug. After a few cycles of this, regular reporters will not be subject to this page and will be taken instead to the regular bug reporting page. For the occasional reporter, this is a good way to handle bug reports, IMHO. Agreed. +1 vote from me Page should contain some info like critical info we need like logs, etc, steps to reproducec, download link. (check ubuntu launchpad). It should automatically create the bug in bugzilla, based on that info. -- VJ - Austin
Re: File a bug report?
On Dec 7, 2007 8:41 AM, Gilles May [EMAIL PROTECTED] wrote: Hi everybody. After updating WINE to from 0.9.49 to 0.9.50 I noticed major slowdown in Company of Heroes, to the point that I get like 1 Frame every 2 seconds. Wine spams the console with: fixme:d3d_shader:IWineD3DVertexShaderImpl_CompileShader Vertexshader 0x4d20b78 recompiled more than 50 times Trying to find out the cause for the slowdown I did my first attempt at using git bisect and I could trace the slowdown to this patch: 959212304dfaf0e7459374593b20b74fe22a0b57 is first bad commit commit 959212304dfaf0e7459374593b20b74fe22a0b57 Author: Stefan Dösinger [EMAIL PROTECTED] Date: Tue Nov 20 21:14:10 2007 +0100 wined3d: Track vertex declaration changes on vertex shaders. This has been fixed to an extent in the current git, please test with current git or wait for the 0.9.51 --- VJ If an attribute has type D3DDECLTYPE_D3DCOLOR, the red and blue channels are swizzled in the shader. Since the attribute is stored in the vertex declaration and not the vertex shader, it can change by setting a new vertex declaration. If this happens, we have to recompile the shader with the swizzling of that specific attribute turned on or off. :04 04 327661a4d0f8a02bdc18380084589c891b64af9c e35a2bcbf9514e4f261d8b7a93dcb24c0b3c89a7 M dlls Now without that patch there is slight texture corruption in the game, with the patch it's much much less but it renders the game unplayable. The reason I didn't file a bug report is that I am not sure if it is really a bug or not since obviously the patch fixes in-game texture corruption. Regards, Gilles
A small question regarding cpuid
Hi, I was going through dlls/kernel32/cpu.c and stumbled upon the functions do_cpuid and have_cpuid. It seems the assembly code for both the Intel and AMD 64 bit processors. Is it possible to remove the ifdefs or add the x86_64 ifdef. And one more question does this change help 64 bit windows support? Thanks, VJ
Re: kernel32:add ReadFileScatter
On Dec 3, 2007 5:02 AM, James Hawkins [EMAIL PROTECTED] wrote: On Dec 2, 2007 5:22 PM, Dan Kegel [EMAIL PROTECTED] wrote: Hey Louis, Focht is using a pseudonym, and I believe it's Wine policy to not accept patches without real names. His patches should be used as guides only, and should not be reposted to wine-patches, until such time as he decloaks. If he doesn't want to decloak, I think we can't use his patches. I rather wish he would avoid attach patches to bugs, as it tempts people into submitting them as you have done, which is a waste of effort given Wine's policy. But I greatly value his ability to describe where and how Wine is wrong. - Dan There's also the issue that Focht disassembles native Windows binaries, and as such, no patches from him will be accepted. I agree, he needs to stop posting patches to wine-bugs, as those patches are tainted and can be used against us in a legal situation. I dont think thats a good idea, asking someone not to post fixes/patches to wine-bugs. Its upon the users to test his ideas, we may not incorporate his patches into the main tree. But his patches help us understand where the problem lies and how to overcome it. Its better that He/We post a disclaimer that the patch is for informative and testing purposes. And that they may not be included in main tree, but can be used upon users discretion. so that wine itself may not be held responsible, in case of any legal threat. -- VJ -- James Hawkins
Re: Error while compiling the wine-0.9.49 in RedHat Linux
If you could raise a bug in bugzilla, we could discuss it there. And please attach the config.log to the bugzilla entry. -- VJ On Dec 1, 2007 10:38 AM, manish jaiswal [EMAIL PROTECTED] wrote: While compiling the wine-0.9.49 I am getting these error. Please help me to resolve these error's. winegcc: gcc failed make[2]: *** [winex11.drv.so] Error 2 make[2]: Leaving directory `/home/manish/Desktop/Download/wine-0.9.49/dlls/winex11.drv' make[1]: *** [winex11.drv] Error 2 make[1]: Leaving directory `/home/manish/Desktop/Download/wine-0.9.49/dlls' make: *** [dlls] Error 2 Thanking in anticipation. with regards: Manish Get the freedom to save as many mails as you wish. Click here to know how.
Re: [Patch] for wined3d: Correcting order issue
On Nov 30, 2007 3:26 AM, Roderick Colenbrander [EMAIL PROTECTED] wrote:
Hi all,
This patch repairs my previous one, as the command never got executed,
because 8600 matches before 8600M.
Marco Schuster
diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c
index e4b5bdf..50b3250 100644
--- a/dlls/wined3d/directx.c
+++ b/dlls/wined3d/directx.c
@@ -950,6 +950,11 @@ BOOL IWineD3DImpl_FillGLCaps(WineD3D_GL_Info
*gl_info) {
gl_info-gl_card = CARD_NVIDIA_GEFORCE_8800GTS;
vidmem = 320; /* The 8800GTS uses 320MB, a 8800GTX
can have 768MB */
}
+/* Geforce8 - midend mobile */
+else if(strstr(gl_info-gl_renderer, 8600 M)) {
+gl_info-gl_card = CARD_NVIDIA_GEFORCE_8600MGT;
+vidmem = 512;
+}
/* Geforce8 - midend */
else if(strstr(gl_info-gl_renderer, 8600) ||
strstr(gl_info-gl_renderer, 8700))
@@ -957,11 +962,6 @@ BOOL IWineD3DImpl_FillGLCaps(WineD3D_GL_Info
*gl_info) {
gl_info-gl_card = CARD_NVIDIA_GEFORCE_8600GT;
vidmem = 256;
}
-/* Geforce8 - midend mobile */
-else if(strstr(gl_info-gl_renderer, 8600 M)) {
-gl_info-gl_card = CARD_NVIDIA_GEFORCE_8600MGT;
-vidmem = 512;
-}
/* Geforce8 - lowend */
else if(strstr(gl_info-gl_renderer, 8300) ||
strstr(gl_info-gl_renderer, 8400) ||
I would prefer not to extend the list with lots of additional models. In my
opinion it isn't really needed as the list would become a lot longer and this
makes it harder to maintain. If we would continue this way we would easily
have to add two dozen additional mobile cards which are now handled as their
desktop equivalents.
I Would rather have a registry entry for all the cards, and user can
add new cards. If they feel its not there. But I think this idea came
up quite a long back and was rejected in favor of in the code values.
Sorry for raising it up again.
-- VJ
Re: d3dx9__xx dlls
On Nov 28, 2007 12:34 PM, Michael Stefaniuc [EMAIL PROTECTED] wrote: Maarten Lankhorst wrote: Stefan Dösinger schreef: What do we do if there's a d3dx9_37.dll next month? One thing that comes to mind is: git-mv d3dx9_36 d3dx9_37 and create a forward dll for the old one. Renames are cheap in git and we do not loose the history. I also think that rename is not a good idea. I would like propose a new idea, why dont we have different spec files inside wine_d3dx for all different versions of dlls. Its something like we have done it in the ole32. But, it requires some makefile/configure cruft. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich
xdg_user_dirs patches
Hi Lei, I think a new file for user dir look up in the shell32 is of no use. Rather than we can add it to the xdg.c and xdg.h, as it contains the generic xdg code for shell32. Its like having all xdg specific code at one place. This is my personal opinion about those patches. Thanks, VJ
Re: [0/3] RSA AES provider to rsaenh
On Nov 20, 2007 3:57 PM, James Hawkins [EMAIL PROTECTED] wrote: On 11/20/07, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Hi, This is a description of patch series which I am now going to send. It adds the new Enhanced RSA AES provider to the rsaenh. The one application which I know uses it is Office 2007. The first patch contains the tests for the RSA AES provider. the second patch contains the RSA AES provider implementation the last patch removes the todo's in the tests. The implementation and tests have been verified by Juan Lang. You can't fix the tests and remove the todo_wines in separate patches. During the try 2, there were failures in the tests. So I resubmited them, by changing the parameters. As I accidentally used used wrong parameters. The tests will fail inbetween commits. The test fail due to missing implementation, Hence I put them in todo's. After the implementation is there, they do not fail. I think thats the procedure followed. I have put the remove todo's in separate patch, as its large. -- VJ
[0/3] RSA AES provider to rsaenh
On Nov 20, 2007 4:23 PM, Juan Lang [EMAIL PROTECTED] wrote: The test fail due to missing implementation, Hence I put them in todo's. After the implementation is there, they do not fail. I think thats the procedure followed. I have put the remove todo's in separate patch, as its large. James is correct, patches 2 and 3 should be concatenated. 2 is already necessarily large, and adding 3 to it doesn't add much to its size. --Juan Damn, I have to reset the git tree. Then apply patches manually and resend them :( Should I wait.? :( --- VJ
Re: d3dx8 [patch 1/10] Implement D3DXPlaneFromPointNormal
On 11/19/07, Stefan Dösinger [EMAIL PROTECTED] wrote: Hi, It's not really about this patch, but I am curious what the plans about sharing code between the various d3dx?_* libraries are. I think a big amount of functionality can be shared among d3dx8.dll, d3dx9_*.dll, and propably d3dxof.dll and d3drm.dll. I think this was discussed in the past, but I am not sure if there was any outcome. The solution chosen for d3d was to create an internal library wined3d.dll, and have the other libs call it. I guess something similar should be done for d3dx as well. For non COM interfaces this is pretty easy anyway. We can rename d3dx8 to wined3dx at any time and just load the functions into a new d3d8 thunk using the .spec file, without any C code. So I guess we can leave things as they currently are and move over to a shared lib once non-math functions are implemented, or someone starts d3dx9_*.dll Functions like D3DXCreateTextureFromFileA seem to be a bit harder. Since they take an IDirect3DDevice8 * interface pointer d3dx9 cannot use them as is. Making a shared implementation is also not quite possible because it would need a wined3ddevice then, but only d3d8.dll knows how to get a wined3ddevice from a d3ddevice8. Also, d3dx* would depend on wined3d then, which is propably not what we want. David, do you have any plans regarding that? As a sidenote, I really like your patches! The patches are small but still every patch makes sense for itself, and tests in every patch :-) I will write a HLSL compiler at some point, and propably a shader assembler. This will be needed for a complete d3dx8 and d3dx9 implementation, as well as d3d10. I am not yet sure where to put it, but it could be a standalone lib in libs/, to allow using the compiler at build time, or just include it in wined3dx, if we decide to add such a library. Why not having the functionality of d3dx in wined3d, instead of having a separate d3dx library called wined3dx? I like the having all the common functionality of d3drm,d3dx8, d3dx9_* and d3dxof dlls at one place and for all the version dependent stuff, we keep it the respective dlls. -- VJ
Re: Add tests for RSA_AES provider in rsaenh
There is a test in derive_key function that fails. If I put a if condition to make it a todo_wine, it looks loke a hack and its ugly As that function is used alot. --- VJ On Nov 16, 2007 5:45 PM, Reece Dunn [EMAIL PROTECTED] wrote: On 16/11/2007, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: ChangeLog -- Add tests for RSA_AES provider in rsaenh Note: --- Some tests might fail as there is no RSA_AES provider in wine. These will be fixed once the implementation is in place, which will be sent next. The recommended way to do this is mark the parts of the tests that fail in Wine with todo_wine. - Reece
Re: Add tests for RSA_AES provider in rsaenh
On Nov 17, 2007 11:45 AM, James Hawkins [EMAIL PROTECTED] wrote: On Nov 17, 2007, at 9:34 AM, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: There is a test in derive_key function that fails. If I put a if condition to make it a todo_wine, it looks loke a hack and its ugly As that function is used alot. --- VJ On Nov 16, 2007 5:45 PM, Reece Dunn [EMAIL PROTECTED] wrote: On 16/11/2007, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: ChangeLog -- Add tests for RSA_AES provider in rsaenh Note: --- Some tests might fail as there is no RSA_AES provider in wine. These will be fixed once the implementation is in place, which will be sent next. The recommended way to do this is mark the parts of the tests that fail in Wine with todo_wine. - Reece Ugly or not, the tests wont be accepted otherwise. Also, please bottom-post on this list. -- James It seems there is a bug in the tests, Once this is fixed I will resend it again. I have sent this to Juan Lang for review. Once our expert tells me whats wrong I will resend. Sorry for top posting, I was in a hurry. --- VJ
Re: CryptAcquireContext Failure, default/Type 024 requested
Hi,
I have implemented the AES support for rsaenh.dll
Please test the attached patch.
Thanks,
VJ
On Sep 24, 2007 12:04 PM, Rob Seger [EMAIL PROTECTED] wrote:
Sweet! Thanks!
I'll see what I can do and probably end up asking some more specific
questions later ;)
Rob
On 9/24/07, Juan Lang [EMAIL PROTECTED] wrote:
I found the wincrypt.h #define line that says what type 024
is: #define PROV_RSA_AES 24.
In that case, it should be straightforward enough to add an AES
implementation to Wine's rsaenh.dll. There's free (as in speech)
source available for it. Take a look at rsaenh.c and implglue.c in
dlls/rsaenh; you'd want to add it as a new block cipher.
--Juan
From 34eb26f43746b68b054897f9c68eba27027668ff Mon Sep 17 00:00:00 2001
From: Vijay Kiran Kamuju [EMAIL PROTECTED]
Date: Fri, 9 Nov 2007 14:05:26 -0600
Subject: [PATCH] Add AES support to rsaenh.dll with tests
---
dlls/rsaenh/Makefile.in|1 +
dlls/rsaenh/implglue.c | 29 ++
dlls/rsaenh/implglue.h |1 +
dlls/rsaenh/rsaenh.c | 31 +++-
dlls/rsaenh/tests/rsaenh.c | 57 +++-
dlls/rsaenh/tomcrypt.h |9 +++
6 files changed, 126 insertions(+), 2 deletions(-)
diff --git a/dlls/rsaenh/Makefile.in b/dlls/rsaenh/Makefile.in
index e6b9470..7c5a054 100644
--- a/dlls/rsaenh/Makefile.in
+++ b/dlls/rsaenh/Makefile.in
@@ -8,6 +8,7 @@ IMPORTLIB = librsaenh.$(IMPLIBEXT)
IMPORTS = crypt32 advapi32 kernel32
C_SRCS = \
+ aes.c \
des.c \
handle.c \
implglue.c \
diff --git a/dlls/rsaenh/implglue.c b/dlls/rsaenh/implglue.c
index d31f615..bb39a7b 100644
--- a/dlls/rsaenh/implglue.c
+++ b/dlls/rsaenh/implglue.c
@@ -3,6 +3,7 @@
* Glueing the RSAENH specific code to the crypto library
*
* Copyright (c) 2004, 2005 Michael Jung
+ * Copyright (c) 2007 Vijay Kiran Kamuju
*
* based on code by Mike McCormack and David Hammerton
*
@@ -194,6 +195,19 @@ BOOL setup_key_impl(ALG_ID aiAlgid, KEY_CONTEXT *pKeyContext, DWORD dwKeyLen,
case CALG_DES:
des_setup(abKeyValue, 8, 0, pKeyContext-des);
break;
+
+case CALG_AES:
+case CALG_AES_128:
+aes_setup(abKeyValue, 16, 0, pKeyContext-aes);
+break;
+
+case CALG_AES_192:
+aes_setup(abKeyValue, 24, 0, pKeyContext-aes);
+break;
+
+case CALG_AES_256:
+aes_setup(abKeyValue, 32, 0, pKeyContext-aes);
+break;
}
return TRUE;
@@ -209,6 +223,10 @@ BOOL duplicate_key_impl(ALG_ID aiAlgid, CONST KEY_CONTEXT *pSrcKeyContext,
case CALG_3DES:
case CALG_3DES_112:
case CALG_DES:
+case CALG_AES:
+case CALG_AES_128:
+case CALG_AES_192:
+case CALG_AES_256:
memcpy(pDestKeyContext, pSrcKeyContext, sizeof(KEY_CONTEXT));
break;
case CALG_RSA_KEYX:
@@ -275,6 +293,17 @@ BOOL encrypt_block_impl(ALG_ID aiAlgid, DWORD dwKeySpec, KEY_CONTEXT *pKeyContex
}
break;
+case CALG_AES:
+case CALG_AES_128:
+case CALG_AES_192:
+case CALG_AES_256:
+if (enc) {
+aes_ecb_encrypt(in, out, pKeyContext-aes);
+} else {
+aes_ecb_decrypt(in, out, pKeyContext-aes);
+}
+break;
+
case CALG_RSA_KEYX:
case CALG_RSA_SIGN:
outlen = inlen = (mp_count_bits(pKeyContext-rsa.N)+7)/8;
diff --git a/dlls/rsaenh/implglue.h b/dlls/rsaenh/implglue.h
index d421c3d..5deaf53 100644
--- a/dlls/rsaenh/implglue.h
+++ b/dlls/rsaenh/implglue.h
@@ -63,6 +63,7 @@ typedef union tagKEY_CONTEXT {
rc2_key rc2;
des_key des;
des3_key des3;
+aes_key aes;
prng_state rc4;
rsa_key rsa;
} KEY_CONTEXT;
diff --git a/dlls/rsaenh/rsaenh.c b/dlls/rsaenh/rsaenh.c
index 4bb64ab..734f44b 100644
--- a/dlls/rsaenh/rsaenh.c
+++ b/dlls/rsaenh/rsaenh.c
@@ -5,6 +5,7 @@
* Copyright 2002 TransGaming Technologies (David Hammerton)
* Copyright 2004 Mike McCormack for CodeWeavers
* Copyright 2004, 2005 Michael Jung
+ * Copyright 2007 Vijay Kiran Kamuju
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -153,7 +154,7 @@ typedef struct tagKEYCONTAINER
/**
* aProvEnumAlgsEx - Defines the capabilities of the CSP personalities.
*/
-#define RSAENH_MAX_ENUMALGS 20
+#define RSAENH_MAX_ENUMALGS 24
#define RSAENH_PCT1_SSL2_SSL3_TLS1 (CRYPT_FLAG_PCT1|CRYPT_FLAG_SSL2|CRYPT_FLAG_SSL3|CRYPT_FLAG_TLS1)
static const PROV_ENUMALGS_EX aProvEnumAlgsEx[4][RSAENH_MAX_ENUMALGS+1] =
{
@@ -161,6 +162,10 @@ static const PROV_ENUMALGS_EX aProvEnumAlgsEx[4][RSAENH_MAX_ENUMALGS+1] =
{CALG_RC2, 40, 40, 56,0,4,RC2, 24,RSA Data Security's RC2},
{CALG_RC4
Re: CryptAcquireContext Failure, default/Type 024 requested
Hi Juan
On Nov 9, 2007 2:21 PM, Juan Lang [EMAIL PROTECTED] wrote:
Hi Vijay,
you forgot aes.c in your patch - please remember to git add it, then
commit it along with the rest of the changes.
From what you've sent, your patch looks pretty good so far. A few comments:
@@ -161,6 +162,10 @@ static const PROV_ENUMALGS_EX
aProvEnumAlgsEx[4][RSAENH_MAX_ENUMALGS+1] =
{CALG_RC2, 40, 40, 56,0,4,RC2,
24,RSA Data Security's RC2},
{CALG_RC4, 40, 40, 56,0,4,RC4,
24,RSA Data Security's RC4},
{CALG_DES, 56, 56, 56,0,4,DES,
31,Data Encryption Standard (DES)},
+ {CALG_AES, 128,128, 128,0,4,AES,
35,Advanced Encryption Standard (AES)},
+ {CALG_AES_128, 128,128, 128,0,8,AES-128,
39,Advanced Encryption Standard (AES-128)},
+ {CALG_AES_192, 192,192, 192,0,8,AES-192,
39,Advanced Encryption Standard (AES-192)},
+ {CALG_AES_256, 256,256, 256,0,8,AES-256,
39,Advanced Encryption Standard (AES-256)},
I'm not sure AES support should be included in every personality of
rsaenh. Specifically, some cryptographic providers don't support it.
Here's a blog that mentions how the MS_ENHANCED_PROV provider doesn't
support it, but the MS_ENH_RSA_AES_PROV does:
http://sys.cs.rice.edu/~sethn/wordpress/?p=19
I think I'll split the patch into 3 parts
1) basic AES implementation in rsaenh
2) Add AES provider info with registering MS_ENH_RSA_AES_PROV.
I have to make aProvEnumAlgsEx[4][RSAENH_MAX_ENUMALGS+1] to
aProvEnumAlgsEx[5][RSAENH_MAX_ENUMALGS+1]
and add the new algorithms, can you help me what algo's should I add
to the new one.
Add the registering code for type24 provider.
3) Tests
+if (!result) {
+/* rsaenh compiled without OpenSSL */
+ok(GetLastError()==NTE_BAD_ALGID, %08x\n, GetLastError());
+return;
+}
Our rsaenh hasn't built against OpenSSL in some time, so this test
should be removed from existing tests. You don't need to do that if
you don't want, but don't bother adding it to new tests.
+result = CryptEncrypt(hKey, (HCRYPTHASH)NULL, TRUE, 0, pbData, dwLen,
16);
+ok(result, %08x\n, GetLastError());
+
+result = CryptDecrypt(hKey, (HCRYPTHASH)NULL, TRUE, 0, pbData, dwLen);
+ok(result, %08x\n, GetLastError());
You should check that the encrypted output matches some expected
value, and that the decrypted output matches the plaintext input.
Well, I have tested the decrypted output by putting printf's.
I will make sure we have good tests for it.
Will send new patch set soon.
Thanks very much for getting this started.
--Juan
Re: shdocvw question
Hi, I dont know about ole32 stuff. I think we should not remove the stuff, you have just removed. rather it would be better if there is null check for it, and decrease reference count. Thanks, VJ PS: I really dont know about ole32 stuff. On 11/3/07, Allan Tong [EMAIL PROTECTED] wrote: The attached patch should fix the crash in bug #6120, but I'm afraid I don't understand enough to know if the patch is correct or not. The code that the patch removes was setting the client site pointer to NULL. A later dereference on that pointer causes the crash. I guess I don't understand why the client site pointer is being explicitly set to NULL. Shouldn't Release handle that when the reference count reaches zero? - Allan
wine tests question?
Hi, I have been looking into http://test.winehq.org/data/. And I have got a question, when i saw the test data. Why do some tests do not return the data about tests they haven't run/skipped. They spew messages something like below: mapi32:prop start dlls/mapi32/tests/prop.c 1.20 mapi32:prop done (-1073741819) mapi32:util start dlls/mapi32/tests/util.c 1.9 mapi32:util done (-1073741819) I am trying to figure out a reason so that i can fix this. can you guys help me out? thanks, VJ
Re: wine tests question?
Well, I have researched a bit error code -1073741819=0xc005 This a status_no_access violation, in winetest we should say the test crashed message On 10/27/07, Robert Shearman [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju wrote: Hi, I have been looking into http://test.winehq.org/data/. And I have got a question, when i saw the test data. Why do some tests do not return the data about tests they haven't run/skipped. They spew messages something like below: mapi32:prop start dlls/mapi32/tests/prop.c 1.20 mapi32:prop done (-1073741819) mapi32:util start dlls/mapi32/tests/util.c 1.9 mapi32:util done (-1073741819) I am trying to figure out a reason so that i can fix this. can you guys help me out? Probably because it has crashed. -- Rob Shearman
Re: my first patch
This looks good, I am not an expert in that area.
Send this patch to [EMAIL PROTECTED]
Cheers,
VJ
On 10/26/07, viny [EMAIL PROTECTED] wrote:
Can someone tell me if this patch is correct for submitting to wine-patches.
I have generated this patch with git format-patch -o out origin
(related bug : http://bugs.winehq.org/show_bug.cgi?id=9805)
From c5eab13b67e6f24b3518dd77840f260dc101520e Mon Sep 17 00:00:00 2001
From: Vincent Hardy [EMAIL PROTECTED]
Date: Fri, 26 Oct 2007 13:37:39 +0200
Subject: [PATCH] Add TypeLib version for W2K, WXP, and Vista
---
dlls/oleaut32/typelib16.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/dlls/oleaut32/typelib16.c b/dlls/oleaut32/typelib16.c
index a010f7d..31bbf93 100644
--- a/dlls/oleaut32/typelib16.c
+++ b/dlls/oleaut32/typelib16.c
@@ -153,6 +153,9 @@ HRESULT WINAPI LoadTypeLib16(
*| OLE 2.1 NT 1993-95 ?? ???
*| OLE 2.3.1 W95 23 700
*| OLE2 4.0 NT4SP6 1993-98 40 4277
+ *| OLE 2.1 W2K2000 10 3029
+ *| OLE 2.1 WXP2002 10 3029
+ *| OLE 2.1 Vista 2007 10 3029
*/
DWORD WINAPI OaBuildVersion16(void)
{
@@ -171,6 +174,12 @@ DWORD WINAPI OaBuildVersion16(void)
return MAKELONG(3024, 10); /* W98 SE */
case 0x0004: /* NT4 */
return MAKELONG(4277, 40); /* NT4 SP6 */
+case 0x0005: /* W2K */
+ return MAKELONG(3029, 10); /* W2K SP4 */
+case 0x0105: /* WXP */
+ return MAKELONG(3029, 10); /* WXP SP2 */
+case 0x0006: /* Vista */
+ return MAKELONG(3029, 10); /* Vista */
default:
FIXME(Version value not known yet. Please investigate it!\n);
return 0;
--
1.5.2.5
Re: Add winhttp.dll.
Hi Jacek, I think you can use the header I sent a while back to wine-patches for this. http://www.winehq.org/pipermail/wine-patches/2005-September/020901.html The original patch: http://www.winehq.org/pipermail/wine-patches/attachments/20050923/790dfab2/winhttp-0001.obj This might require some re-work. It was rejected at that time, when I wanted to add winhttp.dll It might be of some help to you. Thanks, VJ
Re: Getting CA certificates into the registry
Hi, Is it possible to put it on sourceforge like the gecko engine? And download it whenever necessary. And also it should have versioning support and be updated frequently. Thanks, VJ On 7/26/07, Juan Lang [EMAIL PROTECTED] wrote: Since you mentioned Mozilla CVS, perhaps another option is to package them together with gecko? That's an interesting idea. I'll work on getting them from CVS, then talk to Jacek about it. Thanks, --Juan
Re: programs/winefontcfg: Add winefontcfg
Hi,
Is it possible to have a separate tab for fonts in winecfg, rather
than a separate program.
Its my opinion of winefontcfg, rather than having a collection of
configuration tools. Better have one.
Thanks,
VJ
On 7/12/07, Dan Kegel [EMAIL PROTECTED] wrote:
On 7/11/07, Nigel Liang (梁乃強) [EMAIL PROTECTED] wrote:
Sent in try 2:
http://www.winehq.org/pipermail/wine-patches/2007-July/041356.html
Not all the locals in FontLinkListBoxWndProc really need to be static.
(e.g. 'dst')
Those that really need to be static should probably be initialized to
zero, and cleared to zero after they're consumed.
(I'm thinking of 'src' in particular; it's just scary to
have a value hanging around in there after you do the
move; what happens if you get a stray WM_BUTTONUP message
later?)
The code indentation style is nonstandard; I think wine
usually uses 4 space, not 2 space.
(OK, OK, I probably submitted lots of code that wasn't 4 space
indented, but I'm sorry :-)
You still have nonportable initializations like
+ const WCHAR fontlinktermstr[] = {0,0};
Wine uses ANSI C. You cannot initialize nonstatic arrays
at compile time.
You have some globals with names that aren't obviously global
or easy to search for:
+static PROCESS_INFORMATION pi;
+static HWND hChild, hParent;
This probably isn't too bad, but pi really is too
short for a global variable name.
- Dan
--
Wine for Windows ISVs: http://kegel.com/wine/isv
Re: Parallels Wine dlls rebuilt with mingw for your testing
Hi, I have went through the code changes of d3d8 in parallels. And done a diff with 0.9.36 code, there are almost no changes. There are some changes for checking certain functions while loading the dll. They have put code in the getting of registry keys in the DllMain. These are changes noticed in d3d8. Will see the rest of the code? Got some other work bye, VJ On 7/2/07, Steven Edwards [EMAIL PROTECTED] wrote: Hi, I expect if any ofyou are interested you've already talked to Stefan about the code drop from Parallels he is reviewing. I did a build of the drop with Mingw and was able to build everything except ddraw.dll. If anyone is interested in the binary and makefiles, I've forwarded the information on to Stefan with directions on how to build and a rather hackish patch. He said he would post the mingw package sometime later today. Thanks -- Steven Edwards There is one thing stronger than all the armies in the world, and that is an idea whose time has come. - Victor Hugo
Re: Ubuntu starting to support windows autorun.inf on cd-rom insertion!
Hi, I agree with stefan's views. We should not hard code the wine path, but should search for it. If it fails only then only we should resort to it. The searching should be done first using the package managers like rpm,deb. Inorder to search for wine path by searching for standard app installations like wine,cxoffice,cedega in this order) If it fails then it should search for it using the 'which wine' ouptut. If that too fails we should use hardcoded paths. (as last resort). Thanks, VJ On 7/3/07, Stefan Dösinger [EMAIL PROTECTED] wrote: Am Dienstag, 3. Juli 2007 17:47 schrieb Dan Kegel: Check this out. Hanusz Leszek just posted a patch implementing part of https://wiki.ubuntu.com/autorun It's at http://launchpadlibrarian.net/8292130/gnome-volume-manager-autorun-inf-02.p atch Are we ready for prime time, kids? :-) On a technical sidenote, instead of hardcoding the wine path he should test some common wine locations, perhaps including cedega and crossover(/usr/local/bin/wine, ~/cxoffice/bin/wine /opt/cxoffice/bin/wine come to my mind). Or perhaps just parse the autorun.inf and then pass the .exe to the normal gnome / kde file opening methods to have whatever app is associated with the mime type run the app. Otherwise I like the idea. I tried to so something like that a long time ago, but I failed.
Re: Ubuntu starting to support windows autorun.inf on cd-rom insertion!
Hi, Thanks for your constructives criticisms. I was thinking more about putting the wine path in a gconf key so that you can specify it directly. Trying to search the path using the methods you described can be used then as a fallback when the key is not present or invalid. I would say that please have a look at wine module code in guidance. for checking whether wine has been installed or not. and to get its path. What is wine module code ? I tried grepping the wine source code for cedega and cxoffice but found nothing. Please point me in the good direction. In KDE there is a configuration gui for wine in the guidance.(http://www.simonzone.com/software/guidance/) Similar to winecfg, I think its a product of Google SoC. Check the source code of wineconfig.py. I feel that I am a bit vague here, but the download the source for guidance in the website mentioned and see the wineconfig.py. To see how they check whether wine is installed or not. Thanks, VJ
Re: Add new dll mscat32
Hi, I havent tested by putting a stubbed dll, but i have tested it with the native one. Well, after I have written the stubbed dll, will test again. As I have to check which function it actually uses. Thanks, VJ On 6/12/07, James Hawkins [EMAIL PROTECTED] wrote: On 6/11/07, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Hi, I would like to add a stub dll for mscat32.dll in wine. It mostly is a forwarder dll ie, it has forwards for most of the functions to wintrust.dll And it also provides functions for reading catalog files. It is mostly used by microsoft for it installers. I mean for its own products like Winodows Media Player 9, IE, etc. I wanted to inform to get the approval from wine team, for inclusion of this dll. If adding a stub dll fixes a bug, there's not a lot of reason not to accept such a patch. -- James Hawkins
Re: Add new dll mscat32
Hi, There seems to be already a patch available. http://www.winehq.org/pipermail/wine-devel/2006-April/047232.html I would like to know from author, if this will work with latest version of wine Can anyone test windows media player installation with this patch? Thanks, VJ On 6/12/07, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Hi, I havent tested by putting a stubbed dll, but i have tested it with the native one. Well, after I have written the stubbed dll, will test again. As I have to check which function it actually uses. Thanks, VJ On 6/12/07, James Hawkins [EMAIL PROTECTED] wrote: On 6/11/07, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Hi, I would like to add a stub dll for mscat32.dll in wine. It mostly is a forwarder dll ie, it has forwards for most of the functions to wintrust.dll And it also provides functions for reading catalog files. It is mostly used by microsoft for it installers. I mean for its own products like Winodows Media Player 9, IE, etc. I wanted to inform to get the approval from wine team, for inclusion of this dll. If adding a stub dll fixes a bug, there's not a lot of reason not to accept such a patch. -- James Hawkins
Add new dll mscat32
Hi, I would like to add a stub dll for mscat32.dll in wine. It mostly is a forwarder dll ie, it has forwards for most of the functions to wintrust.dll And it also provides functions for reading catalog files. It is mostly used by microsoft for it installers. I mean for its own products like Winodows Media Player 9, IE, etc. I wanted to inform to get the approval from wine team, for inclusion of this dll. Thanks, VJ
[PATCH 4/4] dpnhupnp: Implement IDirectPlayNatHelper stub
Hi, It seems there is a problem with the fake dll entry for dpnhupnp.dll in wine.inf @@ -2129,6 +2129,7 @@ HKLM,%CurrentVersion%\Telephony\Country List\998,SameAreaRule,,G 11,,dmusic.dll,1 11,,dplayx.dll,1 11,,dpnet.dll,1 +11,,dpnhupnp,1 11,,dsound.dll,1 11,,dswave.dll,1 11,,dxdiagn.dll,1 The ebtry should have been 11,,dpnhupnp.dll,1 Correct and resend Thanks, VJ
[1/5] basetsd.h: Fix a typo in the parameter name
Hi I think this patch is not correct. -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I dont see 'l' defined or sent to this macro any where. Thanks, VJ
Set background image for virtual desktop
Hi, Is it possible to set background image for the virtual desktop in wine? If so how do we set it? (I am bored see same old single color virtual desktop ;) ) Cheers, VJ PS: - Any new areas I could work on since d3drm work is complete
Suse wine and wind/u issues
Hi, We are trying to port a windows app to linux. Previous we are using Wind/U. Now we want to test the feasibilty of wine, instead of Wind/U. We have installed Wind/U and Wine on the SLES 9 machine. We have installed the rpm. When we are configuring the wine, using winecfg/wineprefixcreate, its hanging. Its unable to create the fake dlls. Can you please help us. Is this problem occuring due to Wind/U? Thanks, VJ
Re: Suse wine and wind/u issues
Hi,
We are have installed SLES in vmware.
Its hanging in here in wineprefixcreate:
${WINELOADER:-$bindir/wine} rundll32.exe
setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf
Thanks,
VJ
On 4/26/07, Marcus Meissner [EMAIL PROTECTED] wrote:
On Thu, Apr 26, 2007 at 06:58:57AM -0400, Vijay Kiran Kamuju wrote:
Hi,
We are trying to port a windows app to linux.
Previous we are using Wind/U.
Now we want to test the feasibilty of wine, instead of Wind/U.
We have installed Wind/U and Wine on the SLES 9 machine.
We have installed the rpm.
When we are configuring the wine, using winecfg/wineprefixcreate, its
hanging.
Its unable to create the fake dlls.
Can you please help us.
Is this problem occuring due to Wind/U?
I just tried notepad, which works for me including setup
of the fake wine directories.
It might be waiting for a CUPS service to return data.
Ciao, Marcus
Re: Suse wine and wind/u issues
Hi,
I dont think so.
I will check tommorrow, its on my office pc.
We have installed Bristol's Wind/U, well its being loade into to PATH
and LD_LIBRARY_PATH.
Is there any problem if wind/U is included first.
Can It coexist with wine?
Thanks,
VJ
On 4/26/07, Vitaliy Margolen [EMAIL PROTECTED] wrote:
Did you disabled all XIM modules? Or at least did `export XMODIFIERS=`?
Vitaliy
BTW please respect the way the reply was made initially.
Vijay Kiran Kamuju wrote:
Hi,
We are have installed SLES in vmware.
Its hanging in here in wineprefixcreate:
${WINELOADER:-$bindir/wine} rundll32.exe
setupapi.dll,InstallHinfSection DefaultInstall 128 wine.inf
Thanks,
VJ
On 4/26/07, Marcus Meissner [EMAIL PROTECTED] wrote:
On Thu, Apr 26, 2007 at 06:58:57AM -0400, Vijay Kiran Kamuju wrote:
Hi,
We are trying to port a windows app to linux.
Previous we are using Wind/U.
Now we want to test the feasibilty of wine, instead of Wind/U.
We have installed Wind/U and Wine on the SLES 9 machine.
We have installed the rpm.
When we are configuring the wine, using winecfg/wineprefixcreate, its
hanging.
Its unable to create the fake dlls.
Can you please help us.
Is this problem occuring due to Wind/U?
I just tried notepad, which works for me including setup
of the fake wine directories.
It might be waiting for a CUPS service to return data.
Ciao, Marcus
Re: Winscard support (for smart cards)
Hi, If there is a sample implementation or some kinda initial source code. (Just send a initial code) We can try to help you in integrating the code into wine tree. By progressing step by step. Thanks, VJ On 4/25/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Saulius Krasuckas [EMAIL PROTECTED] wrote: IMHO it would be best for the community if you will start doing this immediatelly, not once done. Unfortunately, we are well advanced and we can't do it that way due to other constraints in the project. Another bad point is that, since we are not really experts in autoconf and libtool scripts, we started from a pre-configured source tree and adapted the files of the cryptdll library (the simplest one). So we will definitely need the help of the community to integrate our source seamlessly into the wine source tree. Mounir IDRASSI IDRIX - Cryptography And IT Security Experts http://www.idrix.fr
Fwd: Status of Wine in (K)Ubuntu
Hi Jonathan Riddell has sent me a reply regarding the wine status in Ubuntu. I am also putting that message below. I have nominated Scott Ritchie as maintainer for wine in Ubuntu. I think we need to put up a proposal for wine for Ubuntu. Any Ideas, guys. Thanks, VJ -- Forwarded message -- From: Jonathan Riddell [EMAIL PROTECTED] Date: Apr 23, 2007 8:49 AM Subject: Re: Status of Wine in (K)Ubuntu To: Vijay Kiran Kamuju [EMAIL PROTECTED] On Sun, Apr 08, 2007 at 05:10:59PM -0400, Vijay Kiran Kamuju wrote: What is the current release/packaing stratergy wrt Wine. Is it possible toomchange the release/packaging statergy of Wine. As the current release of wine is fortnightly and mostly its bug fix release. And the ubuntu universe version is not upto date with the current wine release. I would like to create a blueprint for wine like as Till the release of 1.0 we will be releasing fortnightly updates in sync with Wine releases. After that we will give patches based on fixes given on main branch like all other s/w till next version. I think this is a good statergy. And I t will be benificial to wine and ubuntu. Can i make such a blue print and make it available for fiesty, please. I dont mind if you do it. I don't know of anyone who actively works on wine in the Ubuntu archives. I'd recommend posting a proposal to ubuntu-motu for more regular updates. But updates must follow the ubuntu release schedule. https://lists.ubuntu.com/mailman/listinfo/ubuntu-motu Jonathan
Re: D3DRM (to be continued....)
Hi, Just w8 for 2-3 days. No negative comments yet, good sign ;) Thanks, VJ On 4/23/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hi all, my patches for D3DRM have not been applied yet. I thought to have made all the requested changes. But it seems no. So, am I in the good way? What changes must I make now? These patches fix Bug 7442 also. Thanks you in advance for any advice and suggestion. David Adam PS: I follow closely the following advice of wine-wiki for developpers: Just do not give up! of the page http://winehq.org/site/sending_patches :))
Re: wine latest packages for feisty
Hi, I might well ask Jonathan Riddell to endorse you. To be the Master of Universe, (I remember there was a comic/cartoon with similar tag line :P) So we get fairly latest builds of wine. for now there is no backports repository for feisty :( bye, VJ On 4/8/07, Scott Ritchie [EMAIL PROTECTED] wrote: I think you mean Master of The Universe (I am an Ubuntu member already), such that I directly make the universe packages. This more or less happens as it is - another Ubuntu dev just puts my packages straight into universe. If you enable the backports repository, you should also get a fairly recent Wine package (roughly what's in the latest development universe). I might want to take over that personally soon. Thanks, Scott Ritchie On Sun, 2007-04-08 at 17:38 -0400, Vijay Kiran Kamuju wrote: Hi Scott, Is it possible that you can become a ubuntu core member so that all the users for ubuntu get the latest wine releases. (most of the releases have more bugfixes than new features :P )? Thanks, VJ On 4/8/07, Scott Ritchie [EMAIL PROTECTED] wrote: On Sun, 2007-04-08 at 17:17 -0400, Vijay Kiran Kamuju wrote: Hi, Wherr can I get the 0.9.34 wine built for ubuntu feisty. I am currently using ubuntu's 0.9.33, they havent updated it (Idont they will update it as they are in rc1 freeze). Thanks, VJ Nowhere, yet. Still need to build it. Guess it's time I install Feisty. Thanks, Scott Ritchie
Re: Resend: Add d3drmdef.h header file - try 3
Hi, We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. Thanks, VJ PS: - If implementation and tests are needed, will be sending on thursday as I am on vacation/leave. On 3/20/07, Dan Kegel [EMAIL PROTECTED] wrote: Vijay wrote: Resend. Please let me why this one has been dropped. I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan
Re: Resend: Add d3drmdef.h header file - try 3
Hi, Can somebody more experienced than me, please look into this? Modify and Submit to the wine-patches, please anyone who is working on wined3d. I and David Adam put a lotta effort making implementation and tests for d3drm. So that we can make older games that use vector manipulations work, there are bugs in bugzilla that need this functionality. I have a very tough luck getting in my patches. eg: my wininet patches (1yr back, more testcases), comctl monthcal patch(no testcase) and now this d3drm. Please someone help David Adam and Me in this, most of the hardwork is done by David. I dont wanna let him down. I know its very tough to get patches done by newbies to get in, esp wine. Please someone from wined3d please help us. Thanks, VJ On 3/20/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: We have made the tests and implementation. We are waiting for this to get into the tree. Just ironing out minor issues with our implementation. Once this gets in it would be easy to send in the implementation and tests. How this could get in if you didn't bother to fix all the problems pointed out? -- Dmitry.
wine opinion of a user
Hi, http://www.selfadhesivelabels.com/blog/2007/03/20/windos-software-that-we-dont-believe-will-run-under-linux/ This is a response from a user. Can any one order and test sage 50 line business s/w. And other s/w. Dan, you can redirect them to appdb. Thanks, VJ
Re: Add very basic initial tests for d3drm
Hi,
Fixed this one, and it requires d3drmdef.h patch earlier I sent.
Is the d3drmdef.h patch ok?
Will be sending the corrected version soon.
Thanks,
VJ
On 3/14/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote:
Vijay Kiran Kamuju [EMAIL PROTECTED] wrote:
+START_TEST(vector)
+{
+ init_function_pointers();
+
+ VectorTest();
+ QuaternionTest();
What happens if init_function_pointers() failed?
--
Dmitry.
Re: Add d3drmdef.h header - try 2
Hi, Please ignore the this one. I am sending a new one. I wrongly named the header file, effects of late night coding bye, VJ On 3/13/07, Francois Gouget [EMAIL PROTECTED] wrote: On Tue, 13 Mar 2007, Vijay Kiran Kamuju wrote: Changelog --- Add minimalistic d3drmdef.h extern LPD3DVECTOR D3DRMAPI D3DRMVectorAdd(LPD3DVECTOR, LPD3DVECTOR, LPD3DVECTOR); Two nitpicks: Wine's headers usually don't specify extern (it's implicit). If there's a large list of functions it can also be nice to sort them in alphabetical order as other forms of grouping tend to break down after a time. But this is not a hard and fast rules and it is not always followed. -- Francois Gouget [EMAIL PROTECTED] http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS
d3drm test implementation need comments and review
Hi, I have implemented some d3drm functions and made some changes. Original implementation is by David Adam. Currently I dont have a wine repository to test the patch. Before applying the patch please create the dlls/d3drm/tests directory Please send me you comments, regarding this. If there are any compilation/execution errors, please notify me. I will correct them (I dont have access to linux m/c currently) Thanks, VJ d3drm.diff Description: Binary data
Re: Add implementation of D3DRMVector* functions
Hi,
Can you update these comments to this bugzilla entry, #7442?
Thanks,
VJ
On 3/12/07, H. Verbeet [EMAIL PROTECTED] wrote:
On 12/03/07, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote:
Hi,
This is a patch by David Adams, implementing D3DRMVector* functions in
d3drm.dll
I am sending the patch to this mailing list as this was posted on
bugzilla and awaiting review.
A few comments:
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
0;2110;-130;1, USA
I don't think that change should be there.
+LPD3DVECTOR result=(LPD3DVECTOR)(malloc(sizeof(LPD3DVECTOR)));
That and other places in that patch should be using HeapAlloc/HeapFree
+LPD3DVECTOR D3DRMAPI D3DRMVectorRandom(LPD3DVECTOR d)
+{
+
+srand(time(NULL));
+d-x=(float)(rand());
+d-y=(float)(rand());
+d-z=(float)(rand());
+TRACE(Random vector=(%f,%f,%f)\n,d-x,d-y,d-z);
+return d;
+}
I'm not sure about this, but I'm thinking it might be better to
generate a normalized vector there.
- The indentation in D3DRMVectorRotate is a bit of a mess
- Writing test cases doesn't hurt, and in this case should be pretty easy
Re: Add implementation of D3DRMVector* functions
Hi, Currently I dont have a wine repository, so that I could not apply and test it. No time to change it :( Next will check properly. Thanks, VJ On 3/12/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: This is a patch by David Adams, implementing D3DRMVector* functions in d3drm.dll I am sending the patch to this mailing list as this was posted on bugzilla and awaiting review. 1. it's not really nice to send something with name attachment.cgi as a patch. 2. the patch has inconsistent formatting and very hard to read due to that 3. the patch is extremely buggy in memory allocations: instead of allocating the space for an object it allocates the space only for a pointer. I'd suggest to allocate all the objects on the stack instead. -- Dmitry.
Re: Add d3drmdef.h header
Hi, I thought for completeness, we provide the entire header. I did write all that with the help DirectX SDK. (Phew It took me 3 hrs to type it) Thanks, VJ On 3/12/07, Dan Kegel [EMAIL PROTECTED] wrote: vijay wrote: [complete d3drmdef.h] It seems premature to check that in without any code that uses it. Also, did you really write all that yourself? - Dan
Re: Add d3drmdef.h header
Hi On 3/12/07, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: I thought for completeness, we provide the entire header. I did write all that with the help DirectX SDK. (Phew It took me 3 hrs to type it) If it ends up as an almost exact copy of a microsoft header it's not worth an effort. +#ifndef __D3DRMDEFS_H__ +#define __D3DRMDEFS_H__ I saw d3dtypes.h and other d3d header files, its defined like this only, no wine prefix has been added. That's exactly how microsoft does it, this is not how we do it in Wine. +#ifndef D3DRMAPI +#define D3DRMAPI WINAPI +#endif In some header files its defined like this. I will remove all of the below and submit a minimalistic header file. That will support the d3drmvector functions. Consider this patch as for the record. Same here. +#define D3DRMOPTIONS_LEFTHANDED 0x0001L Same here, and in a lot of other places. You lost 3 hours typing it, we lost time reviewing it. This not the 1st time. I have problems porting header files from native SDK's -- Dmitry. Thanks, VJ
Patches in bugzilla
Hi, There are some patches that are attached in the bugzilla. They havent sent to wine-patches mailing list. Can I mail them to the mailing list on their behalf? I have asked them to submit to the mailing list. The patches are submitted about 2 months back. Thanks, VJ
Re: Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlightingof current date.
Hi, It might be because of the MULTISELECT style not being set. Can you please test with the MULTISELECT set? In the older version of the control spy test its set by default, and in the new version its not set. Can you please test that and also test by applying the other patch as well? Currently I am tidying it up and putting some comments. As the order of messages sent is a bit messed up. Dimitry: What do we need to setup, if we want a test framework for messages in comctl32 similar to user32? Lei and Dan, This can also be a good exercise. But I will try to do it myself first. Cheers, VJ On 12/27/06, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Lei Zhang [EMAIL PROTECTED] wrote: I see the problem Duane reports as well. As long as you stay with in the current month, the current day will remain highlighted even if you click another date. It will disappear if you (a) highlight the current date, then another date, or (b) if you go to another month. On 12/26/06, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Hi, It did it for me. when I did the tests. I will check again. Currently I am out of net access for atleast 2 weeks. Shifting to a new room(hostel). So I will test it soon, please bear with me, and also please test with my other patch(month calander one). May be I should leave that for Dan's students. But I will fix it as this is my bug, anyways. Since 2 independent persons do see that the patch has caused a regression, and it's not going to be fixed in a reasonable amount of time, I'd suggest to revert that patch as an obviously wrong then. -- Dmitry.
Re: Vijay Kiran Kamuju : comctl32: MonthCalendar - Fix highlighting of current date.
Hi, It did it for me. when I did the tests. I will check again. Currently I am out of net access for atleast 2 weeks. Shifting to a new room(hostel). So I will test it soon, please bear with me, and also please test with my other patch(month calander one). May be I should leave that for Dan's students. But I will fix it as this is my bug, anyways. bye, VJ On 12/26/06, Duane Clark [EMAIL PROTECTED] wrote: Alexandre Julliard wrote: Module: wine Branch: master Commit: c5b8df481f2bb0362b57188a8c7df423030ba8b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5b8df481f2bb0362b57188a8c7df423030ba8b0 Author: Vijay Kiran Kamuju [EMAIL PROTECTED] Date: Sun Dec 24 13:31:56 2006 +0530 comctl32: MonthCalendar - Fix highlighting of current date. That does highlight the current date on startup. But I notice that when I click another date, the current date doesn't get unhighlighted.
Re: [comctl32] MonthCalendar - Fix wrong date selected when clicknext/prev months day (#6967)
Hi, On 12/25/06, Dmitry Timoshkov [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: - retval = *daypos + (7 * *weekpos) - firstDay; + retval = *daypos + ((7 * *weekpos) - firstDay); return retval; } This change doesn't make any difference, neither in functionality, nor in readability IMO. Please avoid this kind of changes, it only clutters the patch, making it hard to see what is the real change. This was a mistake I didnt notice. - lpht-st.wDay = MONTHCAL_MonthLength(lpht-st.wMonth,lpht-st.wYear) -day; + lpht-st.wDay = day+MONTHCAL_MonthLength(lpht-st.wMonth,lpht-st.wYear) ; A couple of spaces around '+' won't hurt, and a space before ';' doesn't match an existing code style. Will change this one, I was bit out of style. -return TRUE; +/*return TRUE;*/ If you are not sure that the return should be removed, it's a sign that you need a test case, just commenting it out without any explanation is not a solution. Same comment to all other similar cases. Should I add comments or Do I have to add test cases? test cases are bit difficult as they are all UI based, and dont have exact testcases. As I rearranged the codes and removed the returns as the necessary messages are not being sent (in order as observed on windows using both old and latest versions of ControlSpy) If you think I should add comments, I would be glad to modify. Tests are a bit difficult :( (if you can help, I will try) +MONTHCAL_CopyTime(infoPtr-minSel,nmsc.stSelStart); +MONTHCAL_CopyTime(infoPtr-maxSel,nmsc.stSelEnd); nmsc.nmhdr.hwndFrom = infoPtr-hwndSelf; nmsc.nmhdr.idFrom = GetWindowLongPtrW(infoPtr-hwndSelf, GWLP_ID); nmsc.nmhdr.code = MCN_SELCHANGE; -MONTHCAL_CopyTime(infoPtr-minSel,nmsc.stSelStart); -MONTHCAL_CopyTime(infoPtr-maxSel,nmsc.stSelEnd); This change is not needed. I agree. This came up because it while doing regression testing with new control spy V2.0 where MULTISELECT message is not eanbled by default. Should I send a new version of the patch, with the changes? Waiting for your reply. --- VJ
comctl monthcalendar help
Hi, I am trying to fix visual bug in comctl monthcalendar control. When I am using the control spy v2.0 for comctl5.0, I can see that current date is highled with grey background on windows xp. (similar to when we click a day in the calendar) But on wine its not happening. I am trying to find out, how we draw that highlighting. And also how we draw the default calendar. Thanks, VJ
Re: comctl monthcalendar help
Hi, I am trying to figure why its not highlighting the current date (It should be greyed), but its not. Well I am trying to figure out. I think somehow it indirectly sends the MCN_SELECT for the current date. We need to incorporate that in the ode calling default case. I need some help, which function would be called if we send MCN_SELECT and MCN_RELEASED messages Thanks, VJ On 12/23/06, Duane Clark [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju wrote: Hi, I am trying to fix visual bug in comctl monthcalendar control. When I am using the control spy v2.0 for comctl5.0, I can see that current date is highled with grey background on windows xp. (similar to when we click a day in the calendar) But on wine its not happening. I am trying to find out, how we draw that highlighting. And also how we draw the default calendar. In general, drawing is done by the function Paint; in the case of the monthcal, by MONTHCAL_Paint. The default date is set in MONTHCAL_Create, with the call GetLocalTime(infoPtr-todaysDate); The decoration of the day, including highlighting, is done in MONTHCAL_DrawDay. The highlighting would be the calls hbr = GetSysColorBrush(COLOR_GRAYTEXT); hrgn = CreateEllipticRgn(r.left, r.top, r.right, r.bottom); FillRgn(hdc, hrgn, hbr);
Re: usp10: implement ScriptStringAnalyse, ScriptStringFree, ScriptStringXtoCP, ScriptStringCPtoX
Hi,
It may be because you need to split it into smaller individual patches.
Its rather a one big patch.
Cheers,
VJ
On 12/14/06, Clinton Stimpson [EMAIL PROTECTED] wrote:
Hi,
Can I get some feedback on this patch?
It appears to have been rejected.
Thanks,
Clinton
Clinton Stimpson wrote:
This patch implements ScriptStringAnalyse, ScriptStringFree,
ScriptStringXtoCP, ScriptStringCPtoX.
Also, many todo_wine's are removed.
Thanks,
Clinton Stimpson
ChangeLog
Implement ScriptStringAnalyse, ScriptStringFree,
ScriptStringXtoCP, ScriptStringCPtoX
Index: dlls/usp10/usp10.c
===
RCS file: /home/wine/wine/dlls/usp10/usp10.c,v
retrieving revision 1.45
diff -u -r1.45 usp10.c
--- dlls/usp10/usp10.c12 Dec 2006 20:30:48 - 1.45
+++ dlls/usp10/usp10.c13 Dec 2006 03:28:30 -
@@ -73,6 +73,46 @@
HDC hdc;
} Scriptcache;
+typedef struct {
+ int numGlyphs;
+ WORD* glyphs;
+ WORD* pwLogClust;
+ int* piAdvance;
+ SCRIPT_VISATTR* psva;
+ GOFFSET* pGoffset;
+ ABC* abc;
+} StringGlyphs;
+
+typedef struct {
+ BOOL invalid;
+ HDC hdc;
+ int cItems;
+ int cMaxGlyphs;
+ SCRIPT_ITEM* pItem;
+ int numItems;
+ StringGlyphs* glyphs;
+ SIZE* sz;
+} StringAnalysis;
+
+static void ME_StringAnalysisFree(StringAnalysis* analysis)
+{
+ int i;
+ for(i=0; ianalysis-numItems; i++)
+ {
+HeapFree(GetProcessHeap(), 0, analysis-glyphs[i].glyphs);
+HeapFree(GetProcessHeap(), 0, analysis-glyphs[i].pwLogClust);
+HeapFree(GetProcessHeap(), 0, analysis-glyphs[i].piAdvance);
+HeapFree(GetProcessHeap(), 0, analysis-glyphs[i].psva);
+HeapFree(GetProcessHeap(), 0, analysis-glyphs[i].pGoffset);
+HeapFree(GetProcessHeap(), 0, analysis-glyphs[i].abc);
+ }
+
+ HeapFree(GetProcessHeap(), 0, analysis-glyphs);
+ HeapFree(GetProcessHeap(), 0, analysis-pItem);
+
+ HeapFree(GetProcessHeap(), 0, analysis);
+}
+
/***
* DllMain
*
@@ -448,9 +488,16 @@
const BYTE *pbInClass,
SCRIPT_STRING_ANALYSIS *pssa)
{
- FIXME((%p,%p,%d,%d,%d,0x%x,%d,%p,%p,%p,%p,%p,%p): stub\n,
- hdc, pString, cString, cGlyphs, iCharset, dwFlags,
- iReqWidth, psControl, psState, piDx, pTabdef, pbInClass, pssa);
+ HRESULT hr;
+ StringAnalysis* analysis;
+ int numItemizedItems;
+ int i;
+ SCRIPT_CACHE* sc = 0;
+
+ TRACE((%p,%p,%d,%d,%d,0x%x,%d,%p,%p,%p,%p,%p,%p)\n,
+hdc, pString, cString, cGlyphs, iCharset, dwFlags,
+iReqWidth, psControl, psState, piDx, pTabdef, pbInClass, pssa);
+
if (1 cString || NULL == pString) {
return E_INVALIDARG;
}
@@ -458,7 +505,64 @@
return E_PENDING;
}
- return E_NOTIMPL;
+ analysis = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
+ sizeof(StringAnalysis));
+
+ analysis-hdc = hdc;
+ numItemizedItems = 255;
+ analysis-pItem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
+ numItemizedItems*sizeof(SCRIPT_ITEM)+1);
+
+ hr = ScriptItemize(pString, cString, numItemizedItems, psControl,
+ psState, analysis-pItem, analysis-numItems);
+
+ while(hr == E_OUTOFMEMORY)
+ {
+numItemizedItems *= 2;
+HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, analysis-pItem,
+numItemizedItems*sizeof(SCRIPT_ITEM)+1);
+hr = ScriptItemize(pString, cString, numItemizedItems, psControl,
+ psState, analysis-pItem, analysis-numItems);
+ }
+
+ analysis-glyphs = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
+ sizeof(StringGlyphs)*analysis-numItems);
+ sc = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(SCRIPT_CACHE));
+
+ for(i=0; ianalysis-numItems; i++)
+ {
+int cChar = analysis-pItem[i+1].iCharPos - analysis-pItem[i].iCharPos;
+int numGlyphs = 1.5 * cChar + 16;
+WORD* glyphs = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
sizeof(WORD)*numGlyphs);
+WORD* pwLogClust = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
sizeof(WORD)*cChar);
+int* piAdvance = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
sizeof(int)*numGlyphs);
+SCRIPT_VISATTR* psva = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
sizeof(SCRIPT_VISATTR)*cChar);
+GOFFSET* pGoffset = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
sizeof(GOFFSET)*numGlyphs);
+ABC* abc = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(ABC));
+int numGlyphsReturned;
+
+/* FIXME: non unicode strings */
+WCHAR* pStr = (WCHAR*)pString;
+hr = ScriptShape(hdc, sc, pStr[analysis-pItem[i].iCharPos],
+ cChar, numGlyphs, analysis-pItem[i].a,
+
wine crosstest is not working
Hi, I am trying to make crosstest for msxml and other wine modules like advpack. I am unable to compile them. My OS is Kubuntu 6.06 i386 (Dapper) Thanks, VJ
Re: Add IRunnableObject stub implementation
Huw, Can you look at the debug log after applying the SupportInfo Patch in the bug#6341. I think QI should be done for IXMLDocument not IXMLNode. I will try to do it for IXMLNode as well. Thanks, VJ On 10/11/06, Huw Davies [EMAIL PROTECTED] wrote: On Wed, Oct 11, 2006 at 12:55:41AM -0400, Vijay Kiran Kamuju wrote: I will wait on sending tests on this one. Until the first one gets in (http://www.winehq.org/pipermail/wine-patches/2006-September/030659.html) Ok, so let's look at that one. I think the problem here is that ISupportErrorInfo should hang off the underlying node object (in node.c) rather than domdoc itself. All of the objects that inherit from IXMLDOMNode will then get ISupportErrorInfo for free rather than having to implement it for each node type (you'll obviously need to forward the QI through to the node implementation). It would be worth checking that QI on, for example, an attribute node does indeed return ISupportErrorInfo. Another interesting thing to look at (although you can't really write a test for this) is to look at whether the pointer you get back from QI(ISupportErrorInfo) is 'close' to the pointer you get for QI(IXMLDOMDocument) or QI(IXMLDOMNode). If I'm right, it should be close to the latter, in your implementation it'll be close to the former. Huw.
Re: [msxml3] Add IRunnableObject stub implementation
Check the bug# 6341, previously I sent a patch http://www.winehq.org/pipermail/wine-patches/2006-September/030659.html No response, so I thought its noway getting into the main tree, so no tests. Well I sent this one to the list so that it does not get lost. On 10/10/06, Huw Davies [EMAIL PROTECTED] wrote: On Tue, Oct 10, 2006 at 04:45:40PM -0400, Vijay Kiran Kamuju wrote: Add IRunnableObject stub implementation, It's not at all clear to me what this interface should do in this context. Could you at least add a test that shows that the domdoc object should expose IRunnableObject? Thanks, Huw.
Re: Add IRunnableObject stub implementation
Hi, I will wait on sending tests on this one. Until the first one gets in (http://www.winehq.org/pipermail/wine-patches/2006-September/030659.html) Then I will resend with tests. Or may be I will write tests and send them seperately, it really depends on mood tommorrow afternoon. bye, VJ On 10/11/06, Dan Kegel [EMAIL PROTECTED] wrote: On 10/10/06, Huw Davies huw at codeweavers.com wrote: On Tue, Oct 10, 2006 at 04:45:40PM -0400, Vijay Kiran Kamuju wrote: Add IRunnableObject stub implementation, It's not at all clear to me what this interface should do in this context. Could you at least add a test that shows that the domdoc object should expose IRunnableObject? Check the bug# 6341 [http://bugs.winehq.org/show_bug.cgi?id=6341 ] previously I sent a patch http://www.winehq.org/pipermail/wine-patches/2006-September/030659.html No response, so I thought its noway getting into the main tree, so no tests. Well I sent this one to the list so that it does not get lost. Vijay, tests are exactly what you need to get things into the tree! And adding the test Huw suggests is very easy, go ahead and do that, and repost your patch with the test added (after verifying that the test passes on real windows). Thanks for working on some of these msxml problems! - Dan
Re: dsound.dll, dlls/dsound/mixer.c -- DSOUND_MixerVol() optimization
Hi,
using MMX/SSE2 means it would be platform/architecture specific code.
we should be platform independent as possible.
Thank,
VJ
On 10/7/06, [EMAIL PROTECTED]
[EMAIL PROTECTED] wrote:
I was reading through dlls/dsound/mixer.c and I came across the function
DSOUND_MixerVol() that really stood out. The purpose of the code it to
apply a volume amplification by multiplying the channel data by the
amplification factor. What *really* struck me was the parallelism that
could be achieved using SIMD instructions (I am the author of the
project SIMDx86 on Sourceforge):
for (i = 0; i len; i += 2) {
*bps = (*bps * dsb-cvolpan.dwTotalLeftAmpFactor) 16;
bps++;
}
The segment below it for stereo sound not shown but is basically the
same thing.
This could be done extremely easily using MMX, which could process 32
samples/loop interation, or SSE2 which could process 64 samples/loop
(actually, more, but cache lines aren't that big yet). With the
addition of some aggressive prefetching, there could be a signifigant
speed up. Now, here is the question:
What is WINE's policy toward:
1) Optimizations, rather than bugfix patches.
2) Inline assembly language (allowed, disallowed)? Inline assembly
language for the purpose of optimization (instead of, say, fixing up
stack)?
3) Function pointers to select optimal code paths?
4) Detecting/using enhanced x86 instruction sets (e.g. MMX/SSE2)? Is
there still an effort to make WINE work with non-x86? (DarWINE or
something)?
Re: Bugs with new 'installer' keyword
I wil be looking msxml. On 9/26/06, Dan Kegel [EMAIL PROTECTED] wrote: I think the new 'installer' keyword is on every bug that needs it now. http://bugs.winehq.org/buglist.cgi?product=Winekeywords_type=allwordskeywords=installer%2C+downloadbug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENED shows 94 downloadable apps with keyword 'installer'. Here's a breakdown by component: 24 wine-misc 17 wine-ole 15 wine-msi 7 wine-binary 6 wine-net 4 wine-x11 4 wine-msxml 3 wine-programs 3 wine-kernel 2 wine-user 2 wine-setupapi 2 wine-richedit 1 wine-shdocvw 1 Wine-Rebar 1 wine-msvcrt 1 wine-gdi-(printing) 1 wine-directx-d3d James is taking on the msi and setupapi ones, I think. Anyone else interested in plowing through these to see if we can resolve all the installer bugs before 1.0? - Dan
Re: Whither msxml?
Hi our msxml idl flles are not in sync with psdk idl files. especially it still doesnot have SAX defines. And XML DSO definitions. (this is a bit compilicated). As msxml.idl includes xmldso.idl in PSDK headers. And msxml2.idl defines them in the idl file itself. As there are some incompatibilities with msxml2 and msxml3 (esp guids) But in the wine implementation, Mike wnet for a simplified approach with the msxml idl implementation. To reuse msxml.idl functionality in msxml2.idl, by including it. But we should not do that, if we want to support older versions of msxml. We should redo the idl's first inorder, to get msxml implemented correctly. Thanks, VJ On 9/23/06, Dan Kegel [EMAIL PROTECTED] wrote: For the past two years, I've helped UCLA's cs130 by pointing them at an area of Wine that needs improvement and helping them get patches submitted. For Winter 2007, I'm considering having them focus on msxml3. So I'm starting to look at bugzilla (see my previous message) and dig up demo apps and articles that might help us understand where wine's msxml needs to go. Man, oh, man are there a lot of pages about msxml out there. If anyone has tips on sore spots with Wine's msxml, please let me know. A few random notes: MSDN on msxml: http://windowssdk.msdn.microsoft.com/en-us/library/ms763742.aspx I see the spec file for msxml3 has a bunch of stubbed ordinals. Anyone know what they are? Can Wine handle the msxml3 jumpstart demo app from year 2000 yet? http://msdn.microsoft.com/library/en-us/dnmsxml/html/sax2jumpstart.asp Or the msxsl.exe wrapper app? http://www.microsoft.com/downloads/details.aspx?familyid=2fb55371-c94e-4373-b0e9-db4816552e41displaylang=en Programming The SAX2 3.0 Using MSXML (examples in vb6) http://xml.sys-con.com/read/40210.htm MSXML, It's Not Just for VB Programmers Anymore (examples in perl) http://www.perl.com/pub/a/2001/04/17/msxml.html Python XML http://safari.oreilly.com/0596001282 Here's a page that seems to show how to use msxsl and explains differences between msxml3 and msxml4: http://www.perfectxml.com/articles/xml/XSLTInMSXML.asp msxml3 examples: http://www.perfectxml.com/articles/xml/msxml30.asp A C++ Template Wrapper for the XML SAX API http://www.ddj.com/showArticle.jhtml?articleID=184401778 etc. etc. - Dan
Re: [c2man] remove hardcoded extension (try#2)
well some spec files are like wnaspi32.spec, when we parse the names of those.
We need to hard code them to dll.
There is no other way unless you change the spec file names.
On 9/20/06, Alexandre Julliard [EMAIL PROTECTED] wrote:
Vijay Kiran Kamuju [EMAIL PROTECTED] writes:
my $uc_dll_name = uc $dll_name;
+
+ if (($dll_ext ne 'ds') ($dll_ext ne 'acm') ($dll_ext ne 'drv')
+ ($dll_ext ne 'exe') ($dll_ext ne 'ocx') ($dll_ext ne 'vxd'))
+ {
+$dll_ext='dll';
+ }
You are still hardcoding things, there's really no reason to do that.
--
Alexandre Julliard
[EMAIL PROTECTED]
Re: Governance revisited (Wineconf report)
Some kinda patch management system would help. I think like bugzilla. On 9/20/06, Jeremy White [EMAIL PROTECTED] wrote: Wine works fine as-is in my opinion ;) Which you are entitled to, but my opinion happens to differ. Whether the wine core source has all the patches, (Which it doesn't - many, but not all) isn't relevant, it's the process that they go through that I believe could improve. For the record, Governance is something we often spend a chunk of time on at each Wine conference. Brian has written a nice summary of Wineconf on WWN (thanks Brian!), including a reprise of the talk on governance. Being insufferably long winded, and feeling the need to create a complete record, I would add a few things to what Brian wrote. First, I think there was clear and essentially unanimous agreement that the current high standards for quality were a Good Thing (TM), including the Holy Order of Writing Conformance Tests. Second, I think we had fairly clear agreement that so long as he can handle it, it is most efficient to have Alexandre as the sole maintainer. Obviously, the more help he gets from component maintainers (e.g. Mike/MSI, Rob/COM), the better. Third, I think there was clear agreement that Alexandre is often a Royal Pain In the Ass (RPITA). He ignores patches, responds tersely, and sometimes delivers the occassional kiss of death: I can't tell you what to change, but your patch is wrong. However, we, the assembled 30 or so of the most core Wine developers, could not think of a single case where Alexandre had been proven wrong. Nor could we think of a single instance when he had failed to be persuaded by reasonable argument; making a rather compelling case that he is generally right. We also talk, from time to time, about building some sort of patch tracking system to allow for better management of patches. Something like a 'ticket' system, so people could see the status of their email, whether or not it had been reviewed, etc, etc. I think there is some sense that this might be useful, but it's a sufficiently complex problem, and it has to be written in emacs, that we always defer it for the future. So I think the strong (if not unamimous) consensus was to continue on as we are, but make an effort to provide an 'ambassador' program of some kind, particularly around folks that are new to Wine. If you have a specific concrete suggestion for change, this would be a fine time to put it forward. But if your proposal is largely: Alexandre should accept more patches, I think you'll find that none of the core Wine developers will support you in that, so it's not worth the effort, at least not in this venue. Cheers, Jeremy
Re: [c2man] remove hardcoded extension (try#2)
Well then will this do good, if the file extension is 'spec', then we will take the default value as 'dll'. As the logic i am using to parse the filenames is, I am checking using the first part of the extension. Can you tell me a better method other than this? I will cahnge to that. On 9/20/06, Alexandre Julliard [EMAIL PROTECTED] wrote: Vijay Kiran Kamuju [EMAIL PROTECTED] writes: well some spec files are like wnaspi32.spec, when we parse the names of those. We need to hard code them to dll. There is no other way unless you change the spec file names. That doesn't mean you need to hardcode a list of extensions, any extension is allowed, and the code should cope with that. -- Alexandre Julliard [EMAIL PROTECTED]
Re: Already Error while installing MS Office 2003
May be Alexander might have rejected some patches on wine for MSI that went to codeweavers. A guess of course. On 9/15/06, Roland Kaeser [EMAIL PROTECTED] wrote: Hello Just tried to test install office 2003 on wine 0.9.21. But getting already errors. I read in C't (german it magazine) that office 2003 works on codeweavers. Can somebody declare me this? Does codeweavers voluntary not provide the corrections to wine to sell their product? Looks very strange to me. Roland Debug Output while installing office (breaks down when it trieds to start installation of the files (after setup configuration and serial number request) - fixme:imm:ImmDisableIME (-1): stub fixme:advapi:CheckTokenMembership ((nil) 0x190388 0x346d3c) stub! err:ole:CoUninitialize Mismatched CoUninitialize err:ole:CoUninitialize Mismatched CoUninitialize fixme:advapi:CheckTokenMembership ((nil) 0x1ad6f8 0x7d3683b8) stub! err:msidb:WHERE_VerifyCondition Couldn't find column LLock fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates - 67 ignored LUpgrade table values err:msidb:WHERE_VerifyCondition Couldn't find column LLock err:msi:msi_dialog_set_font No font entry for L52 err:msi:msi_dialog_set_font No font entry for L9 err:msi:msi_dialog_set_font No font entry for L52 fixme:msi:ControlEvent_SpawnWaitDialog Doing Nothing fixme:msi:ControlEvent_SpawnWaitDialog Doing Nothing err:msi:msi_dialog_set_font No font entry for L100 err:heap:HEAP_ValidateInUseArena Heap 0x11: in-use arena 0x1ed990 next block has PREV_FREE flag fixme:msi:msi_unimplemented_action_stub MigrateFeatureStates - 67 ignored LUpgrade table values err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\1031\\OFREADME.HTM) err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\1031\\OFREADME.HTM) fixme:msi:ACTION_HandleStandardAction unhandled standard action LSetODBCFolders fixme:msi:deformat_component component key LHTM_Editor_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LHTM_Editor_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LCore_IDE_Resource_DLLs_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LCore_IDE_Resource_DLLs_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LCore_IDE_Cmd_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LCore_IDE_Cmd_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LVS_SCC_Core_TeamCore_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LVS_SCC_Core_TeamCore_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LCSS_Package_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LCSS_Package_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key L_VS_Debugging_SDM2_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key L_VS_Debugging_SDM2_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key L_VS_Debugging_VSDebug_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key L_VS_Debugging_VSDebug_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LWbBrwsrPckgRsrcDLLDEUX86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LWbBrwsrPckgRsrcDLLDEUX86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LURL_Font_Color_Picker_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 fixme:msi:deformat_component component key LURL_Font_Color_Picker_DEU_X86.3643236F_FC70_11D3_A536_0090278A1BB8 err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\CSSPKGUI.DLL) err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\CSSPKGUI.DLL) err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\HTMEDUI.DLL) err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\HTMEDUI.DLL) err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\htmdlgsUI.dll) err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\htmdlgsUI.dll) err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\vsdebugui.dll) err:msi:deformat_file Unable to get ShortPath size (Lc:\\Programme\\Microsoft Office\\OFFICE11\\VS Runtime\\1031\\vsdebugui.dll)
WM_*UISTATE message implementation in wine
Hi, Has wine an implementation for WM_*UISTATE messages? Can anybody tell me where should it be implemented and how it should be implemented. Does it involve complex coding? Thanks, VJ
Re: WM_*UISTATE message implementation in wine
I forgot add the msdn link about WM_*UISTATE, http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winui/winui/windowsuserinterface/userinput/keyboardaccelerators/aboutkeyboardaccelerators.asp On 9/14/06, Vijay Kiran Kamuju [EMAIL PROTECTED] wrote: Hi, Has wine an implementation for WM_*UISTATE messages? Can anybody tell me where should it be implemented and how it should be implemented. Does it involve complex coding? Thanks, VJ
RTL language support in usp.dll
Hi, Your patch for RTL support in usp10.dll. http://www.winehq.org/pipermail/wine-patches/2006-September/030571.html Only includes support for Arabic. If you could include for other RTL languages esp Hebrew (other RTL languages are Farsi and Urdu). I think that would be an easy task for you as you know the usp internals. ;) bye, VJ
Re: wine complation fails with latest git
Please do a make clean in widl directory and do make On 9/12/06, EA Durbin [EMAIL PROTECTED] wrote: I'm not able to compile wine with the latest source from git. gcc-3.4 -c -I. -I. -I../../include -I../../include-Wall -pipe -fno-strict-aliasing -gstabs+ -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o parser.yy.o parser.yy.c parser.l: In function `parser_lex': parser.l:129: error: `parser_lval' undeclared (first use in this function) parser.l:129: error: (Each undeclared identifier is reported only once parser.l:129: error: for each function it appears in.) parser.l: In function `kw_token': parser.l:342: error: `parser_lval' undeclared (first use in this function) make[2]: *** [parser.yy.o] Error 1 make[2]: Leaving directory `/home/eric/wine/tools/widl' make[1]: *** [widl] Error 2 make[1]: Leaving directory `/home/eric/wine/tools' make: *** [tools] Error 2
Anything wrong with this patch? Comments....
Hi, Anything wrong with this patch, http://www.winehq.org/pipermail/wine-patches/2006-August/030201.html Please do send me comments, this fixes installation of icqlite. Thanks, VJ
Symbol demangling and the games crashing
Hi, In the bug reports I have seen that we are facing problems with symbol demangling of '_R' operators and 'Y' datatypes. err:msvcrt:symbol_demangle Unknown operator: _R and err:msvcrt:demangle_datatype Unknown type Y Escpecially for games StarTrek Armada and Gothic. If anyone is intersted in symbol demangling stuff(msvcrt), here is an excellent guide for definition of symbols, etc : http://sparcs.kaist.ac.kr/~tokigun/article/vcmangle.html I will try to come up with a basic patch for that. I dont mind, If someone beats me to it. Thanks, VJ
wine and dos support
Hi, A friend of mine is asking me to get dos based games to work using wine. Well, I generally tell to use dosbox for that. Is it possible make them work in wine. If yes, what effort should we put into that. I mean what should we need to implement. Is it possible to lift some parts of other LGPL dos projects. Thanks, VJ
Google SOC projects Success/Failure
Hi, As the Google SOC concluded. We need to evaluate whether our SOC projects were successfull or not. Some of them got through like Oleview, Trash implementation, riched20 improvisation. I really dont know about the clamav integration, shell integration (there were some patches regarding this I think), improve mswscock.dll and ntlm using gensec. Wineconf is about to start, I think we need to re-think what might be good additions and how should we proceed for 1.0 release. I see about 50-60% success in the SOC - 2006. There were a lotta widl improvements, this thing should have been a SOC project ;) Please feel to comment on this. Thanks, VJ
