Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-07-08 Thread Romain Primet
Yep sorry, my bad, this was a configuration issue on my side, the fix worked. Cheers ! 2015-07-06 21:51 GMT+02:00 Andy Clement : > Hi Romain, > > It should be in - I can see the fix in the git log (although I wish we’d > tracked this in a real bugzilla rather than just in email). Are you sure >

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-07-06 Thread Andy Clement
Hi Romain, It should be in - I can see the fix in the git log (although I wish we’d tracked this in a real bugzilla rather than just in email). Are you sure you aren’t hitting something new now, having changed a bit of code? cheers, Andy > On Jul 6, 2015, at 5:33 AM, Romain Primet wrote: > >

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-07-06 Thread Romain Primet
Hi Andy, Contacting you again abount this issue, did the fix make it into 1.8.6? We get the same errors at compile time. Cheers Romain 2015-04-12 19:53 GMT+02:00 Andy Clement : > Nope I have no testcase, I couldn’t recreate it in a simple scenario after > trying for a little while so had to wo

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-12 Thread Andy Clement
Nope I have no testcase, I couldn’t recreate it in a simple scenario after trying for a little while so had to work on it in Romains complete app. Sometimes I don’t have the cycles to get a lovely regression test in place :( cheers, Andy > On Apr 12, 2015, at 8:02 AM, Alexander Kriegisch > w

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-12 Thread Alexander Kriegisch
Hi Andy. > Possibly it is the use of declare parents extends (with generics), > that is just not as common as declare parents implements. Actually, no. That was the first thing I tried, namely getting rid of the interface implementation 'DefaultIdentifiable' and replacing it like this: package

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-11 Thread Andy Clement
Hey, Yes, Romain sent me some repo references off list so the discussion ended up continuing there. I was planning to post back here when we got to a conclusion (which we just did last night when Romain tested a 1.8.6 snapshot I created with a potential fix). The new method will make it into t

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-11 Thread Alexander Kriegisch
Romain, I was just curious, it is not necessary to dig deeper. It was just an idea, I did not expect it to work anyway. Compilation errors exist for a reason. ;-) -- Alexander Kriegisch http://scrum-master.de Romain Primet schrieb am 11.04.2015 15:03: > Le 11/04/2015 14:47, Alexander Kriegisc

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-11 Thread Romain Primet
Le 11/04/2015 14:47, Alexander Kriegisch a écrit : Sounds good, Romain, I had no idea Andy was in touch with you. BTW, I noticed that if you add true to the POM of zvtm-cluster, the build continues and the necessary methods seem to be there in the resulting class files. Can you please test

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-11 Thread Alexander Kriegisch
Sounds good, Romain, I had no idea Andy was in touch with you. BTW, I noticed that if you add true to the POM of zvtm-cluster, the build continues and the necessary methods seem to be there in the resulting class files. Can you please test that with the official v1.8.5 (not the fixed preview

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-11 Thread Romain Primet
Hi Alexander, I got a reply from Andy off-list; looks like an issue with ITD and generic types (ITD not being done on raw type). I'm sure Andy will be more precise; also, he has provided me with a snapshot build of aspectj that builds zvtm-cluster just fine. Thanks a lot to you both for the

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-11 Thread Alexander Kriegisch
Hi Andy. I have looked into this a little more and noticed that the build within Eclipse Luna with AJDT works nicely, but fails with AspectJ Maven Plugin and on the command line via ajc.bat. So this might be a clue what it going wrong if you can answer one question: What does ADJT differently i

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-08 Thread Andy Clement
If there is one ajc, yep. I'm afraid I haven't had a chance to dig further into this yet. cheers Andy On 6 April 2015 at 12:34, Romain Primet wrote: > > > For a particular compilation we collect up all the aspects we know > about. We then apply all the aspects affecting the type structure (inte

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-06 Thread Romain Primet
> For a particular compilation we collect up all the aspects we know about. We then apply all the aspects affecting the type structure (inter type declarations, declare parents), then later we apply the advice. > If you are describing a two step process where a compile step is relying on som

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-06 Thread Andy Clement
> Some aspects or classes are already woven before the ITD they rely on has > happened. For a particular compilation we collect up all the aspects we know about. We then apply all the aspects affecting the type structure (inter type declarations, declare parents), then later we apply the advi

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-03 Thread Alexander Kriegisch
I have checked out Romain's project from here: svn://svn.code.sf.net/p/zvtm/code/ zvtm-code What I saw is that module zvtm-cluster wants to weave ITD methods into zvtm-core. There are other aspects relying on ITD-ed methods introduced by other aspects. There seems to be something wrong with the

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-02 Thread Andy Clement
And worth looking at the 1.6.8 readme: http://eclipse.org/aspectj/doc/released/README-168.html It starts with: The first sentence in the 1.6.7 readme was 'AspectJ 1.6.7 includes some radical internal changes.' Unfortunately not enough t

Re: [aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-02 Thread Alexander Kriegisch
Hi Romain. Is there any specific reason for you to use an AspectJ version from 2009? How about giving 1.8.5 a try? Disregarding the version, do you think you can share your aspect(s) and target class(es), ideally a minimal example reproducing the problem? Even though you say it is unrelated, t

[aspectj-users] ajc 1.6.6 -> 1.6.7+ behavior changes ?

2015-04-02 Thread Romain Primet
Hi list, I have an aspectJ-based codebase that currently uses 1.6.6 (compiler and runtime) and builds fine. Moving to 1.6.7+, I get errors related to inter-type declarations. Specifically, a library is being weaved by an aspect that declares a new parent for an existing class. This parent s