On Fri, 27 Sep 2024 16:34:52 GMT, Alexey Ivanov wrote:
> Now that standard window layouts are available as part of the
> `PassFailJFrame` framework, we can use them in tests.
>
> Two tests from #21180, specifically
> `test/jdk/java/awt/Frame/DefaultFrameIconTest.java` and
&
t windows. At this time,
> the tests implement positioning explicitly in the test. After #21207 is
> integrated, these two tests could be updated to use the standard layout. They
> would serve as sample usage of multi-window test UI.
Alexey Ivanov has updated the pull request with a new
On Tue, 1 Oct 2024 18:59:22 GMT, Harshitha Onkar wrote:
>> Following tests are added as part of this PR:
>>
>> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual
>> PassFailJFrame (PFJ) test**, problemlisted on all platforms.
>>
>> 2. java/awt/dnd/DragSourceMotionListen
t windows. At this time,
> the tests implement positioning explicitly in the test. After #21207 is
> integrated, these two tests could be updated to use the standard layout. They
> would serve as sample usage of multi-window test UI.
Alexey Ivanov has updated the pull request with a new
On Thu, 26 Sep 2024 12:58:34 GMT, Alexey Ivanov wrote:
> Provides a set of default layouts for manual test using multiple test UI
> windows.
>
> The initial implementation in the demo in #15721 was too complicated. After
> looking at the simplified version used in #21180,
On Tue, 24 Sep 2024 15:51:09 GMT, Alexey Ivanov wrote:
> I re-worked the entire description of `PassFailJFrame`:
>
> Add description of what UI elements it provides and how to interact with them.
> Add anchors for linking to the sections.
>
> Use `{@snippet}` instead of `{
On Tue, 1 Oct 2024 20:41:17 GMT, Harshitha Onkar wrote:
> Problemlisted java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java
> fails on macOS
Looks good to me.
-
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21297#pullrequestreview
On Mon, 30 Sep 2024 14:32:35 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed redundant frame.setLocation()
>
> test/jdk/java/awt/dnd/DragToAnotherScr
On Tue, 1 Oct 2024 19:02:16 GMT, Harshitha Onkar wrote:
> Just a thought: May be it it is good to add a delay in PFJ's forcePass() and
> forceFail() which gives time for the user to see any messages or logs in the
> logArea.
I don't think it's good. What if there's no log area?
Adding a helpe
On Sat, 24 Aug 2024 00:11:14 GMT, Sergey Bylokhov wrote:
>> This changeset updates the image in the documentation for the
>> `Document.insert` method. The image in `Document.remove` was updated by
>> [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>>
>> Now the illustr
On Sun, 22 Sep 2024 14:47:14 GMT, Alexey Ivanov wrote:
>> This changeset updates the image in the documentation for the
>> `Document.insert` method. The image in `Document.remove` was updated by
>> [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #157
On Mon, 30 Sep 2024 18:39:22 GMT, Harshitha Onkar wrote:
>> Following tests are open-sourced in this PR:
>>
>> 1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
>> 2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual
>> PFJ test
>
> Harshitha Onkar
On Mon, 30 Sep 2024 18:13:50 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/MouseInfo/ContainerResizeMousePositionTest.java line 95:
>>
>>> 93:
>>> 94: if (!eventCaught.await(2, TimeUnit.SECONDS)) {
>>> 95: if (!testSucceeded) {
>>
>> These two conditions look independent
On Mon, 30 Sep 2024 16:51:04 GMT, Harshitha Onkar wrote:
> Following tests are open-sourced in this PR:
>
> 1. /java/awt/MouseInfo/ContainerResizeMousePositionTest.java - Automated
> 2. [LINUX ONLY] /java/awt/color/XAWTDifference/XAWTDifference.java - Manual
> PFJ test
Changes requested by aiv
On Fri, 27 Sep 2024 22:01:13 GMT, Harshitha Onkar wrote:
>> Following tests are added as part of this PR:
>>
>> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual
>> PassFailJFrame (PFJ) test**, problemlisted on all platforms.
>>
>> 2. java/awt/dnd/DragSourceMotionListe
On Fri, 27 Sep 2024 04:17:30 GMT, Harshitha Onkar wrote:
>> Following tests are added as part of this PR:
>>
>> 1. /java/awt/dnd/DnDHTMLToOutlookTest/DnDHTMLToOutlookTest.java - **Manual
>> PassFailJFrame (PFJ) test**, problemlisted on all platforms.
>>
>> 2. java/awt/dnd/DragSourceMotionListe
column to
> the bottom of the instruction frame. The left of the first window is aligned
> to that of the instruction frame.
>
> If required, the test developer can provide a custom implementation.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a
Now that standard window layouts are available as part of the `PassFailJFrame`
framework, we can use them in tests.
Two tests from #21180, specifically
`test/jdk/java/awt/Frame/DefaultFrameIconTest.java` and
`test/jdk/java/awt/Frame/MenuCrash.java`, use two test windows. At this time,
the test
On Fri, 27 Sep 2024 14:58:31 GMT, Alexander Zvegintsev
wrote:
>> No, not directly.
>>
>> But you can combine it with explicit call to `WindowLayouts`:
>>
>>
>> .positionTestUI((testWindows, instructionUI) -> {
>> instructionUI.setLocation(200, 200);
>> WindowLayouts.rightOneRow(testWi
On Fri, 27 Sep 2024 14:45:42 GMT, Alexey Ivanov wrote:
>>> Should we provide a way to place instruction frame in arbitrary location on
>>> screen?
>>
>> You can do it by using the `InstructionUI` interface that's passed to you
>> when you implement a
On Fri, 27 Sep 2024 14:48:32 GMT, Alexander Zvegintsev
wrote:
>>> If you call `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` after
>>> `.positionTestUIRightRow`, it is respected.
>>
>> Perhaps, this behaviour should be called out in the docs somewhere. All
>> `.positionTestUIRight*` as
On Fri, 27 Sep 2024 14:28:15 GMT, Alexey Ivanov wrote:
>> If you call `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)` after
>> `.positionTestUIRightRow`, it is respected.
>
>> Should we provide a way to place instruction frame in arbitrary location on
>> sc
column to
> the bottom of the instruction frame. The left of the first window is aligned
> to that of the instruction frame.
>
> If required, the test developer can provide a custom implementation.
Alexey Ivanov has updated the pull request incrementally with two additional
commits s
On Fri, 27 Sep 2024 14:25:17 GMT, Alexander Zvegintsev
wrote:
>> Let me check… All the samples look good, however, this looks like a typo.
>
> I tried this
>
> Checkout this PR locally:
> $ git fetch https://git.openjdk.org/jdk.git pull/21210/head:pull/21210
> $ git checkout pull/21210
>
>
>
On Fri, 27 Sep 2024 14:07:44 GMT, Alexander Zvegintsev
wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add missing parentheses for vertical positioning
>
> test/jdk/java/awt/regt
On Fri, 27 Sep 2024 14:21:14 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1405:
>>
>>> 1403: * Positions the test UI windows in a row to the right of
>>> 1404: * the instruction frame. The top of the
On Thu, 26 Sep 2024 13:57:09 GMT, Alexey Ivanov wrote:
>> Provides a set of default layouts for manual test using multiple test UI
>> windows.
>>
>> The initial implementation in the demo in #15721 was too complicated. After
>> looking at the simplified version u
column to
> the bottom of the instruction frame. The left of the first window is aligned
> to that of the instruction frame.
>
> If required, the test developer can provide a custom implementation.
Alexey Ivanov has updated the pull request incrementally with one ad
Provides a set of default layouts for manual test using multiple test UI
windows.
The initial implementation in the demo in #15721 was too complicated. After
looking at the simplified version used in #21180, I re-worked the layouts into
separate methods.
The layout methods are in `WindowLayout
On Wed, 25 Sep 2024 11:31:38 GMT, Alexey Ivanov wrote:
> Removes the wildcard bound from
> `PassFailJFrame.PositionWindows.positionTestWindows` so that implementing the
> interface is simpler as one don't have to remember to declare the
> `testWindows` parameter as `List`
On Mon, 23 Sep 2024 20:40:47 GMT, Alexey Ivanov wrote:
> I added description to all the constructors available in `PassFailJFrame`.
>
> I generated the javadoc for it: [`PassFailJFrame` constructor
> details](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html
On Wed, 25 Sep 2024 10:48:53 GMT, Alexander Zvegintsev
wrote:
> few more tests to open source
>
> Testing looks good
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21180#pullrequestreview-2328048717
On Wed, 25 Sep 2024 11:53:23 GMT, Alexander Zvegintsev
wrote:
> > GitHub doesn't like `#1` in the subject of the JBS issue — it links it to
> > the first PR in the JDK project.
>
> I know, but it's just visual, the PR can be integrated without any issue
But it looks frightening and confusing,
On Wed, 25 Sep 2024 11:31:38 GMT, Alexey Ivanov wrote:
> Removes the wildcard bound from
> `PassFailJFrame.PositionWindows.positionTestWindows` so that implementing the
> interface is simpler as one don't have to remember to declare the
> `testWindows` parameter as `List`
On Wed, 25 Sep 2024 10:48:53 GMT, Alexander Zvegintsev
wrote:
> few more tests to open source
>
> Testing looks good
GitHub doesn't like `#1` in the subject of the JBS issue — it links it to the
first PR in the JDK project.
-
PR Comment: https://git.openjdk.org/jdk/pull/21180#is
Removes the wildcard bound from
`PassFailJFrame.PositionWindows.positionTestWindows` so that implementing the
interface is simpler as one don't have to remember to declare the `testWindows`
parameter as `List` — just use `List`.
It is a backwards compatible change, all the tests which use `List
rame.html](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html)
> could be easier to read and review.
>
> The current version of the generated docs contains changes from #21145 and
> this PR. The PRs can be integrated independently.
Alexey Ivanov has updated the pull reque
provides a more streamlined experience, therefore new tests
> should use it instead of constructors. We may update the tests which use the
> constructors, after which the constructors can be removed.
Alexey Ivanov has updated the pull request incrementally with two additional
commits s
On Tue, 24 Sep 2024 17:20:57 GMT, Phil Race wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use EDT abbreviation in constructor description
>>
>> The term EDT (Eve
On Tue, 24 Sep 2024 23:36:17 GMT, Harshitha Onkar wrote:
> > Shall we deprecate the constructors in favor of Builder?
> >
> > The builder provides a more streamlined experience, therefore new tests
> > should use it instead of constructors. We may update the tests which use
> > the constructors
provides a more streamlined experience, therefore new tests
> should use it instead of constructors. We may update the tests which use the
> constructors, after which the constructors can be removed.
Alexey Ivanov has updated the pull request incrementally with one additional
commit since
On Tue, 24 Sep 2024 15:51:09 GMT, Alexey Ivanov wrote:
> I re-worked the entire description of `PassFailJFrame`:
>
> Add description of what UI elements it provides and how to interact with them.
> Add anchors for linking to the sections.
>
> Use `{@snippet}` instead of `{
I re-worked the entire description of `PassFailJFrame`:
Add description of what UI elements it provides and how to interact with them.
Add anchors for linking to the sections.
Use `{@snippet}` instead of `{@code}` for sample code.
Use method references instead of lambdas in samples.
Document requ
I added description to all the constructors available in `PassFailJFrame`.
I generated the javadoc for it:
[`PassFailJFrame/api`](https://cr.openjdk.org/~aivanov/PassFailJFrame/api/PassFailJFrame.html)
which is easier to read. This hosted javadoc could be used as a reference to
its API.
The co
On Wed, 18 Sep 2024 12:05:22 GMT, Alexey Ivanov wrote:
> Support of multiple test UI windows in `PassFailJFrame` is still evolving.
> After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the
> `Builder` has a method `positionTestUI` to supply an implementati
On Mon, 23 Sep 2024 14:30:30 GMT, Alexey Ivanov wrote:
> Resolve the error:
>
> PassFailJFrame.java:161: error: text not allowed in element
> * to add a log area,
> ^
>
>
> Shorten the rendered javadoc for `log`, `logClear` and
On Wed, 18 Sep 2024 20:12:08 GMT, Alexey Ivanov wrote:
> > > With the proposed change in this pull request, the implementation would
> > > use ComponentListener.componentMoved:
> >
> >
> > you mean the implementation of the test ? Perhaps adding the require
Resolve the error:
PassFailJFrame.java:161: error: text not allowed in element
* to add a log area,
^
Shorten the rendered javadoc for `log`, `logClear` and `logSet`.
@azvegint, could you take a look?
-
Commit messages:
- 8340461: Amend desc
On Wed, 18 Sep 2024 20:52:23 GMT, Alexey Ivanov wrote:
> > Perhaps adding the required pattern in the examples would be a good idea.
>
> Yes, it's a good idea.
Although, I support this, I feel it is out of scope for this change.
I submitted [JDK-8340469](https://bugs.openj
On Tue, 20 Aug 2024 23:53:45 GMT, Alisen Chung wrote:
>> Currently the bug described in the issue is that the colors of the
>> TextComponents do not change when setting TextComponents to uneditable. The
>> default uneditable color (SystemColor.control) happens to be the same as the
>> default
On Fri, 23 Aug 2024 05:24:16 GMT, Abhishek Kumar wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix import
>
> src/java.desktop/share/classes/java/awt/TextArea.java line 610:
>
>> 608:
>> 609: @Override
>> 6
On Tue, 20 Aug 2024 23:53:45 GMT, Alisen Chung wrote:
>> Currently the bug described in the issue is that the colors of the
>> TextComponents do not change when setting TextComponents to uneditable. The
>> default uneditable color (SystemColor.control) happens to be the same as the
>> default
On Thu, 8 Aug 2024 01:19:55 GMT, Alisen Chung wrote:
>> Yes, but as far I could see `TextArea.background` property is being set in
>> `AquaLookAndFeel.java, MotifLookAndFeel.java, BasicLookAndFeel.java,
>> XAWTLookAndFeel.java and WindowsLookAndFeel.java`
>> and this L&F will not be set in AWT
On Fri, 23 Aug 2024 04:26:30 GMT, Prasanta Sadhukhan
wrote:
> Also, since the testcase is just testing the background color, I think it can
> be made automated and even headless by using textfield/textarea rendering to
> BufferedImage
AWT components cannot be created in headless environment.
On Mon, 23 Sep 2024 04:19:20 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component e
On Mon, 29 Jul 2024 13:43:42 GMT, Alexey Ivanov wrote:
> This changeset updates the image in the documentation for the
> `Document.insert` method. The image in `Document.remove` was updated by
> [JDK-4622866](https://bugs.openjdk.org/browse/JDK-4622866) in PR #15701.
>
> Now t
or JDK
> 24](https://cr.openjdk.org/~aivanov/8337287/api/java.desktop/javax/swing/text/Document.html#insertString(int,java.lang.String,javax.swing.text.AttributeSet)).
>
> As in the case with `remove`, I marked up to classes and members with {@code}.
Alexey Ivanov has updated the pull requ
On Wed, 18 Sep 2024 15:34:02 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component e
On Thu, 19 Sep 2024 09:40:56 GMT, Alexey Ivanov wrote:
> I am open-sourcing the `Numpad1KeyTyped.java` test.
>
> I used `CountDownLatch` for synchronisation.
>
> The test passes in CI.
This pull request has now been integrated.
Changeset: 3c22d83c
Author: Alexey Ivanov
UR
On Wed, 4 Sep 2024 03:34:34 GMT, Alisen Chung wrote:
> Cleaning up tests building ExtendedRobot that shouldn't be.
The title suggest a larger amount of clean-up. “Clean up _a few_ tests” could
be better. (Git recommends the use of imperative mood in titles: “Clean up”
instead of “Cleaning up”,
On Wed, 4 Sep 2024 03:34:34 GMT, Alisen Chung wrote:
> Cleaning up tests building ExtendedRobot that shouldn't be.
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java line 1:
> 1: /*
`frame` should be disposed of on EDT.
`TestTitlePane` can be
On Thu, 25 Jul 2024 11:17:23 GMT, Andrey Turbanov wrote:
> 2 fields in javax.swing.SortingFocusTraversalPolicy could be made 'static':
> 1. FORWARD_TRAVERSAL = 0
> 2. BACKWARD_TRAVERSAL = 1
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/2032
On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov wrote:
> It has become quite common to use the following code
>
>
> .rows((int) INSTRUCTIONS.lines().count() + 1)
>
>
> to set the number of rows for `PassFailJFrame`.
>
> Make this the default value. Newer te
On Thu, 19 Sep 2024 15:10:55 GMT, Alexander Zvegintsev
wrote:
> As another improvement, we can also consider calculating the default number
> of columns (based on the widest string?) in a separate issue.
Yes!
I added a comment in JBS:
> This is part of a larger effort for providing better de
On Thu, 19 Sep 2024 16:22:27 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Minor fix
Marked as rev
On Thu, 19 Sep 2024 16:08:09 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> TestFrame var declared a
On Thu, 19 Sep 2024 14:55:39 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test restructured and test frames set visible true
>
> test/jdk/java/awt/MenuItem/Lo
On Thu, 19 Sep 2024 04:56:13 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test restructured and te
On Tue, 17 Sep 2024 12:39:20 GMT, Alexey Ivanov wrote:
> A trivial change which adds border around instruction text. It makes the text
> easier to read.
>
> (In some tests, people added leading spaces to each line to make the
> instructions easier to read; with the added bor
On Thu, 19 Sep 2024 09:40:56 GMT, Alexey Ivanov wrote:
> I am open-sourcing the `Numpad1KeyTyped.java` test.
>
> I used `CountDownLatch` for synchronisation.
>
> The test passes in CI.
The test is somewhat similar to #21013, it uses similar synchronisation logic.
--
I am open-sourcing the `Numpad1KeyTyped.java` test.
I used `CountDownLatch` for synchronisation.
The test passes in CI.
-
Commit messages:
- 8340008: KeyEvent/KeyTyped/Numpad1KeyTyped.java has 15 seconds timeout
Changes: https://git.openjdk.org/jdk/pull/21085/files
Webrev: https
On Mon, 16 Sep 2024 09:55:19 GMT, Alexey Ivanov wrote:
> This changeset refactors `java/awt/event/KeyEvent/FunctionKeyTest.java`.
>
> Key changes:
>
> - Use `CyclicBarrier` to verify whether a key is pressed and released;
> - Use `CountDownLatch` for frame activation;
> -
On Wed, 18 Sep 2024 20:12:08 GMT, Alexey Ivanov wrote:
> Perhaps adding the required pattern in the examples would be a good idea.
Yes, it's a good idea.
-
PR Comment: https://git.openjdk.org/jdk/pull/21057#issuecomment-2359383555
On Wed, 18 Sep 2024 19:42:08 GMT, Phil Race wrote:
> > With the proposed change in this pull request, the implementation would use
> > ComponentListener.componentMoved:
>
> you mean the implementation of the test ? Perhaps adding the required pattern
> in the examples would be a good idea.
@p
On Wed, 18 Sep 2024 15:07:57 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test instruction update
On Wed, 18 Sep 2024 15:07:57 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test instruction update
On Wed, 18 Sep 2024 12:38:34 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added requires jtreg tag
On Wed, 18 Sep 2024 12:38:34 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> added requires jtreg tag
On Wed, 18 Sep 2024 11:07:29 GMT, Nizar Benalla wrote:
> I assumed this would be automatically merged once I became a committer.
No, the Skara bots don't revisit the PRs after the OpenJDK Census is changed.
You weren't a committer when you issued the `/integrate` command, so it
required a spon
On Wed, 18 Sep 2024 10:52:28 GMT, Alexey Ivanov wrote:
> > Actually, I thought `.positionTestWindow` would be called for the first
> > window automatically, then you can position other windows based on the
> > assigned location. Eventually, it's not called at all if a
On Wed, 18 Sep 2024 12:06:31 GMT, Abhishek Kumar wrote:
>>>What about macOS? The test can be run there.
>>
>> On macOS, it is of the normal font like windows. Should I update the
>> instructions for macOS as well?
>
>>I'm for replacing Solaris with Linux. There's no way a test would be run on
On Wed, 18 Sep 2024 12:05:22 GMT, Alexey Ivanov wrote:
> Support of multiple test UI windows in `PassFailJFrame` is still evolving.
> After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the
> `Builder` has a method `positionTestUI` to supply an implementati
Support of multiple test UI windows in `PassFailJFrame` is still evolving.
After [JDK-8340210](https://bugs.openjdk.org/browse/JDK-8340210), the `Builder`
has a method `positionTestUI` to supply an implementation of the
`PositionWindows` interface which handles the positioning of all test UI
wi
On Wed, 18 Sep 2024 10:48:23 GMT, Abhishek Kumar wrote:
> > What about Linux? Solaris isn't supported by JDK any more.
>
> Tested on linux. Menu's font are large and on Windows it is normal size.
I'm for replacing Solaris with Linux. There's no way a test would be run on
Solaris using the most
On Wed, 18 Sep 2024 11:32:55 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
L
On Wed, 18 Sep 2024 10:51:49 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test instruction update
On Wed, 18 Sep 2024 10:51:49 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test instruction update
On Wed, 18 Sep 2024 10:51:49 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Test instruction update
On Wed, 18 Sep 2024 10:12:27 GMT, Abhishek Kumar wrote:
>> Actually, I thought `.positionTestWindow` would be called for the first
>> window automatically, then you can position other windows based on the
>> assigned location. Eventually, it's not called at all if a list of windows
>> is creat
On Wed, 18 Sep 2024 04:43:50 GMT, Abhishek Kumar wrote:
>> Few AWT MenuItem related tests are converted from applet to manual and moved
>> to open.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add requires tag
Marked
On Wed, 18 Sep 2024 04:25:55 GMT, Abhishek Kumar wrote:
>> test/jdk/java/awt/MenuItem/LotsOfMenuItemsTest.java line 98:
>>
>>> 96: firstFrame.setLocation(970, 350);
>>> 97: testFrame.setLocation(970, 510);
>>> 98: }
>>
>> Hard-coding coordinates is not the best solution. The
On Wed, 18 Sep 2024 10:07:13 GMT, Alexey Ivanov wrote:
>> I gave a try to get PassFailFrame position but some error occured and then
>> hard coded. I agree hard-coding is not a best solution and thanks for
>> suggesting the other way around. A bit of correction in setting
On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla wrote:
> Can I get a review for this doc-only change? I updated some links because the
> websites moved from HTTP to HTTPS. The redirects can cause some
> false-positives on tests.
>
> TIA
@nizarbenalla Looks you're a committer now. You have to
On Fri, 13 Sep 2024 15:01:23 GMT, Nizar Benalla wrote:
> Can I get a review for this doc-only change? I updated some links because the
> websites moved from HTTP to HTTPS. The redirects can cause some
> false-positives on tests.
>
> TIA
Marked as reviewed by aivanov (Reviewer).
-
On Fri, 6 Sep 2024 11:37:10 GMT, Abhishek Kumar wrote:
>> There is no Swatches tab available for GTK Look and Feel due to the
>> different ColorChooser UI design. Updated the test instructions.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the
On Tue, 17 Sep 2024 04:31:09 GMT, Abhishek Kumar wrote:
> Few AWT MenuItem related tests are converted from applet to manual and moved
> to open.
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/MenuItem/GiantFontTest.java line 72:
> 70: mb.add(m);
> 71: f.setMenuBar
On Tue, 17 Sep 2024 17:25:34 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Tue, 17 Sep 2024 16:19:27 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component e
On Mon, 16 Sep 2024 21:38:36 GMT, Harshitha Onkar wrote:
>> `positionTestUI()` option is added to PassFailJFrame (PFJ).
>>
>> With this change multiple UI can be positioned using the PFJ new builder
>> pattern by providing implementation for the Functional Interface
>> `PositionWindows.positio
On Tue, 17 Sep 2024 13:45:06 GMT, Alexey Ivanov wrote:
> It has become quite common to use the following code
>
>
> .rows((int) INSTRUCTIONS.lines().count() + 1)
>
>
> to set the number of rows for `PassFailJFrame`.
>
> Make this the default value. Newer te
401 - 500 of 1954 matches
Mail list logo
