Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-26 Thread via GitHub
frankgh commented on PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#issuecomment-1912886999 Closed via https://github.com/apache/cassandra-analytics/commit/8c20b452dd0728a6fad6d276a7be9fa1b9274495 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-26 Thread via GitHub
frankgh closed pull request #31: CASSANDRA-19273 Allow setting TTL for snapshots created through reader URL: https://github.com/apache/cassandra-analytics/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-26 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1468236613 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -109,6 +134,50 @@ private ClientConfig(Map options)

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-25 Thread via GitHub
sarankk commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1467053662 ## cassandra-bridge/src/main/java/org/apache/cassandra/spark/utils/MapUtils.java: ## @@ -225,4 +225,15 @@ public static String getOrDefault(Map options, Strin

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-25 Thread via GitHub
frankgh commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1467052902 ## cassandra-bridge/src/main/java/org/apache/cassandra/spark/utils/MapUtils.java: ## @@ -225,4 +225,15 @@ public static String getOrDefault(Map options, Strin

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-22 Thread via GitHub
sarankk commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462775859 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -109,6 +134,50 @@ private ClientConfig(Map options)

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-22 Thread via GitHub
sarankk commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462774050 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -24,25 +24,45 @@ import java.util.Map; import java.util.Op

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-22 Thread via GitHub
frankgh commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462559574 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -109,6 +134,50 @@ private ClientConfig(Map options)

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-22 Thread via GitHub
sarankk commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462469394 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -138,7 +138,7 @@ private ClearSnapshotStrategy parseClearSn

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-22 Thread via GitHub
sarankk commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462466619 ## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/SharedClusterSparkIntegrationTestBase.java: ## @@ -84,7 +84,7 @@ protecte

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-22 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462464312 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -138,7 +138,7 @@ private ClearSnapshotStrategy parseClearSn

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-22 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462458671 ## cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/SharedClusterSparkIntegrationTestBase.java: ## @@ -84,7 +84,7 @@ protecte

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-18 Thread via GitHub
sarankk commented on PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#issuecomment-1899368851 As per @yifan-c suggestions, to avoid confusion caused by allowing both `clearSnapshot` option and `snapshotTTL` option, we are going ahead with following setting to determine wh

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456718177 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ## @@ -341,24 +341,31 @@ private CompletionStage> createSna

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
frankgh commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456716322 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -146,6 +158,16 @@ public boolean clearSnapshot() re

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
frankgh commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456715644 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ## @@ -341,24 +341,31 @@ private CompletionStage> createSna

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456714473 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ## @@ -341,24 +341,31 @@ private CompletionStage> createSna

Re: [PR] CASSANDRA-19273 Allow setting TTL for snapshots created through reader [cassandra-analytics]

2024-01-17 Thread via GitHub
yifan-c commented on code in PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#discussion_r1456713939 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java: ## @@ -341,24 +341,31 @@ private CompletionStage> createSna