[GitHub] [samza] ajothomas merged pull request #1649: [Docs] Samza 1.8.0 release website updates

2023-01-18 Thread GitBox
ajothomas merged PR #1649: URL: https://github.com/apache/samza/pull/1649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apac

[GitHub] [samza] ajothomas opened a new pull request, #1649: [Docs] Samza 1.8.0 release website updates

2023-01-17 Thread GitBox
ajothomas opened a new pull request, #1649: URL: https://github.com/apache/samza/pull/1649 This PR has all website/doc related changes w.r.t to samza 1.8.0 release. Since we did not add anything for 1.7.0 release, this PR adds a release.md and download links for 1.7.0 release. -- This is

[GitHub] [samza] li-afaris commented on pull request #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2023-01-14 Thread GitBox
li-afaris commented on PR #1647: URL: https://github.com/apache/samza/pull/1647#issuecomment-1382703530 Good catch. I updated publish-site.sh and tested the best that I could as I don't have SVN write access. Let me know if it doesn't work correctly. Thanks -- This is an automated

[GitHub] [samza] li-afaris commented on pull request #1204: Bump jekyll from 3.4.5 to 3.6.3 in /docs

2023-01-12 Thread GitBox
li-afaris commented on PR #1204: URL: https://github.com/apache/samza/pull/1204#issuecomment-1381196091 This can probably be closed "won't-fix" as Jekyll 4.3.1 is in the dependency tree from pull request #1647. The following is from `./gradlew docs:dependencies` ``` gems +---

[GitHub] [samza] li-afaris commented on pull request #1621: Bump ffi from 1.9.23 to 1.15.5 in /docs

2023-01-12 Thread GitBox
li-afaris commented on PR #1621: URL: https://github.com/apache/samza/pull/1621#issuecomment-1381195077 This can probably be closed "won't-fix" as ffi was upgraded to 1.15.5 from pull request #1647. The following is from `./gradlew docs:dependencies` ``` gems +--- rubygems:jeky

[GitHub] [samza] li-afaris commented on pull request #1623: Bump json from 2.1.0 to 2.3.0 in /docs

2023-01-12 Thread GitBox
li-afaris commented on PR #1623: URL: https://github.com/apache/samza/pull/1623#issuecomment-1381194149 This can probably be closed "won't-fix" as JSON 2.6.3 is in the dependency tree from pull request #1647. The following is from `./gradlew docs:dependencies` ``` gems +--- ru

[GitHub] [samza] li-afaris commented on pull request #1624: Bump redcarpet from 3.4.0 to 3.5.1 in /docs

2023-01-12 Thread GitBox
li-afaris commented on PR #1624: URL: https://github.com/apache/samza/pull/1624#issuecomment-1381193456 This can probably be closed "won't-fix" as redcarpet was replaced with Kramdown from pull request #1647 and is no longer used. -- This is an automated message from the Apache Git Servic

[GitHub] [samza] li-afaris commented on pull request #1632: Bump addressable from 2.5.2 to 2.8.1 in /docs

2023-01-12 Thread GitBox
li-afaris commented on PR #1632: URL: https://github.com/apache/samza/pull/1632#issuecomment-1381192497 This can probably be closed "won't-fix" as addressable 2.8.1 is in the dependency tree from pull request #1647. The following is from `./gradlew docs:dependencies` ``` gems

[GitHub] [samza] li-afaris commented on a diff in pull request #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2023-01-12 Thread GitBox
li-afaris commented on code in PR #1647: URL: https://github.com/apache/samza/pull/1647#discussion_r1068741225 ## docs/meetups/index.html: ## @@ -21,7 +21,7 @@ --> -{% assign sorted = (site.meetups | sort: 'date') | reverse %} +{% assign sorted = site.meetups | sort

[GitHub] [samza] li-afaris commented on a diff in pull request #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2023-01-12 Thread GitBox
li-afaris commented on code in PR #1647: URL: https://github.com/apache/samza/pull/1647#discussion_r1068741065 ## docs/talks/index.html: ## @@ -21,7 +21,7 @@ --> -{% assign sorted = (site.talks | sort: 'date') | reverse %} +{% assign sorted = site.talks | sort: 'dat

[GitHub] [samza] mynameborat commented on a diff in pull request #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2023-01-12 Thread GitBox
mynameborat commented on code in PR #1647: URL: https://github.com/apache/samza/pull/1647#discussion_r1068483167 ## docs/meetups/index.html: ## @@ -21,7 +21,7 @@ --> -{% assign sorted = (site.meetups | sort: 'date') | reverse %} +{% assign sorted = site.meetups | so

[GitHub] [samza] mynameborat merged pull request #1648: Update RocksDB to version 7.8.3 to reduce write amplification

2023-01-09 Thread GitBox
mynameborat merged PR #1648: URL: https://github.com/apache/samza/pull/1648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[GitHub] [samza] mynameborat commented on pull request #1648: Update RocksDB to version 7.8.3 to reduce write amplification

2023-01-09 Thread GitBox
mynameborat commented on PR #1648: URL: https://github.com/apache/samza/pull/1648#issuecomment-1376380697 @shekhars-li can you run the build locally/publish another dummy commit to trigger the checks again? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [samza] shekhars-li opened a new pull request, #1648: Update RocksDB to version 7.8.3 to reduce write amplification

2023-01-06 Thread GitBox
shekhars-li opened a new pull request, #1648: URL: https://github.com/apache/samza/pull/1648 What: Updated RocksDB to version 7.8.3 Why: This version reduces the write compaction by aligning compaction output file boundaries. More details can be found in [this blog post](http://rocksdb.o

[GitHub] [samza] li-afaris commented on pull request #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2023-01-05 Thread GitBox
li-afaris commented on PR #1647: URL: https://github.com/apache/samza/pull/1647#issuecomment-1372953087 FYI: Removing the Jekyll incremental build flag resolved the file name differences I found in the previous comment. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [samza] amf3 commented on pull request #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2023-01-04 Thread GitBox
amf3 commented on PR #1647: URL: https://github.com/apache/samza/pull/1647#issuecomment-1371765244 I found the following differences after generating documents with Jekyll using both MRI Ruby & Jruby. Input was generated by running find on the _site directory and saving the output to a sor

[GitHub] [samza] li-afaris commented on pull request #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2022-12-21 Thread GitBox
li-afaris commented on PR #1647: URL: https://github.com/apache/samza/pull/1647#issuecomment-1361904668 > I'm open to suggestions for improving confidence relating to the Jekyll plugin changes. One thing I thought of was to list & compare the generated file names in _site. I found s

[GitHub] [samza] li-afaris commented on pull request #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2022-12-20 Thread GitBox
li-afaris commented on PR #1647: URL: https://github.com/apache/samza/pull/1647#issuecomment-1360645861 I'm not sure why the last commit (ccb932d) failed testing when the previous one (651a1bc) worked. You can see the diff by clicking the ccb932d link above. Is the samza-kafka_2.12:t

[GitHub] [samza] li-afaris opened a new pull request, #1647: [SAMZA-2772] Manage Jekyll dependencies with Gradle

2022-12-20 Thread GitBox
li-afaris opened a new pull request, #1647: URL: https://github.com/apache/samza/pull/1647 # Summary This change moves Jekyll dependency management into Gradle. Contributors will no longer be required to install ruby & Jekyll by hand. # Changes * Gemfiles no longer manage depend

[GitHub] [samza] xinyuiscool merged pull request #1646: [Docs] Add Ajo Thomas to committers list and GPG keys

2022-12-16 Thread GitBox
xinyuiscool merged PR #1646: URL: https://github.com/apache/samza/pull/1646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[GitHub] [samza] ajothomas opened a new pull request, #1646: [DOC] Add Ajo Thomas to committers list and GPG keys

2022-12-16 Thread GitBox
ajothomas opened a new pull request, #1646: URL: https://github.com/apache/samza/pull/1646 Add Ajo Thomas to committers list and GPG keys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [samza] dxichen merged pull request #1645: Fix restore factory not configured log

2022-12-15 Thread GitBox
dxichen merged PR #1645: URL: https://github.com/apache/samza/pull/1645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache

[GitHub] [samza] dxichen opened a new pull request, #1645: Fix restore factory not configured log

2022-12-14 Thread GitBox
dxichen opened a new pull request, #1645: URL: https://github.com/apache/samza/pull/1645 Currently if a restore factory is missing due to a misconfiguration we exit due to a NPE ``` 2022-12-13 18:23:07.794 [main] SamzaContainer [ERROR] Caught exception/error while initializing con

[GitHub] [samza] dxichen merged pull request #1644: Fix performance bug in kafka/blobstore commit lifecycle.

2022-11-28 Thread GitBox
dxichen merged PR #1644: URL: https://github.com/apache/samza/pull/1644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache

[GitHub] [samza] shekhars-li opened a new pull request, #1644: Fix perfomance bug

2022-11-28 Thread GitBox
shekhars-li opened a new pull request, #1644: URL: https://github.com/apache/samza/pull/1644 Bug - We introduced blob store backed for state backup and restore in [this commit](https://github.com/apache/samza/commit/7cc4eaa96fff244f6dce9c18af804917db7c3b2b). - `StateBackendFactory` imp

[GitHub] [samza] shanthoosh merged pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-16 Thread GitBox
shanthoosh merged PR #1641: URL: https://github.com/apache/samza/pull/1641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apa

[GitHub] [samza] shanthoosh commented on pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-16 Thread GitBox
shanthoosh commented on PR #1641: URL: https://github.com/apache/samza/pull/1641#issuecomment-1317938599 Thanks for adding the tests @jia-gao . After going through the linkedin documents and JIRA tickets, it seems like we are just proceeding with the approach finalized as a part of the inve

[GitHub] [samza] jia-gao commented on pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-16 Thread GitBox
jia-gao commented on PR #1641: URL: https://github.com/apache/samza/pull/1641#issuecomment-1317936984 > validating > @jia-gao As discussed offline, it would be great if we can add a unit-test for validating these changes in this patch. Added unit tests -- This is an

[GitHub] [samza] xinyuiscool merged pull request #1642: SAMZA-2769: [PipelineDrain] Add drainMode to DrainNotification

2022-11-16 Thread GitBox
xinyuiscool merged PR #1642: URL: https://github.com/apache/samza/pull/1642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[GitHub] [samza] ajothomas commented on a diff in pull request #1642: SAMZA-2769: [PipelineDrain] Add drainMode to DrainNotification

2022-11-16 Thread GitBox
ajothomas commented on code in PR #1642: URL: https://github.com/apache/samza/pull/1642#discussion_r1024611620 ## samza-core/src/main/java/org/apache/samza/drain/DrainUtils.java: ## @@ -54,44 +74,34 @@ private DrainUtils() { * @return generated uuid for the DrainNotification

[GitHub] [samza] shanthoosh commented on pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-16 Thread GitBox
shanthoosh commented on PR #1641: URL: https://github.com/apache/samza/pull/1641#issuecomment-1317817165 @jia-gao As discussed offline, it would be great if we can add a unit-test for validating these changes in this patch. -- This is an automated message from the Apache Git Service. To r

[GitHub] [samza] ajothomas commented on a diff in pull request #1642: SAMZA-2769: [PipelineDrain] Add drainMode to DrainNotification

2022-11-16 Thread GitBox
ajothomas commented on code in PR #1642: URL: https://github.com/apache/samza/pull/1642#discussion_r1024598787 ## samza-api/src/main/java/org/apache/samza/drain/DrainMode.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

[GitHub] [samza] xinyuiscool commented on a diff in pull request #1642: SAMZA-2769: [PipelineDrain] Add drainMode to DrainNotification

2022-11-16 Thread GitBox
xinyuiscool commented on code in PR #1642: URL: https://github.com/apache/samza/pull/1642#discussion_r1024576429 ## samza-api/src/main/java/org/apache/samza/drain/DrainMode.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

[GitHub] [samza] ajothomas closed pull request #1643: SAMZA-2770: [Pipeline Drain] Enable drain monitor by default

2022-11-16 Thread GitBox
ajothomas closed pull request #1643: SAMZA-2770: [Pipeline Drain] Enable drain monitor by default URL: https://github.com/apache/samza/pull/1643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [samza] ajothomas opened a new pull request, #1643: SAMZA-2770: [Pipeline Drain] Enable drain monitor by default

2022-11-16 Thread GitBox
ajothomas opened a new pull request, #1643: URL: https://github.com/apache/samza/pull/1643 # Summary Drain monitor had been turned off by default. The idea was to turn it on after testing the pipeline drain feature. # Changes - Set `DRAIN_MONITOR_ENABLED_DEFAULT` to true in `Job

[GitHub] [samza] ajothomas opened a new pull request, #1642: SAMZA-2769: [PipelineDrain] Abstract DrainNotification to make it extensible

2022-11-16 Thread GitBox
ajothomas opened a new pull request, #1642: URL: https://github.com/apache/samza/pull/1642 # Summary The current `DrainNotification` is a concrete class tasked with signaling samza engine to clear intermediate state. It is currently inextensible and any changes to the class in the future

[GitHub] [samza] jia-gao commented on a diff in pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-16 Thread GitBox
jia-gao commented on code in PR #1641: URL: https://github.com/apache/samza/pull/1641#discussion_r1024297945 ## samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppenderMetrics.java: ## @@ -46,7 +43,6 @@ public class StreamAppenderMetrics extends MetricsBase {

[GitHub] [samza] alnzng commented on a diff in pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-14 Thread GitBox
alnzng commented on code in PR #1641: URL: https://github.com/apache/samza/pull/1641#discussion_r1021917783 ## samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppenderMetrics.java: ## @@ -46,7 +43,6 @@ public class StreamAppenderMetrics extends MetricsBase {

[GitHub] [samza] jia-gao commented on pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-14 Thread GitBox
jia-gao commented on PR #1641: URL: https://github.com/apache/samza/pull/1641#issuecomment-1314166098 > Is the default support to prevent recursion not available when this change was introduced or did we upgrade to newer version of log4j that adds this prevention at the framework layer?

[GitHub] [samza] mynameborat merged pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-11-09 Thread GitBox
mynameborat merged PR #1637: URL: https://github.com/apache/samza/pull/1637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[GitHub] [samza] ajothomas commented on a diff in pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-11-09 Thread GitBox
ajothomas commented on code in PR #1637: URL: https://github.com/apache/samza/pull/1637#discussion_r1018537087 ## samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java: ## @@ -106,7 +110,10 @@ public void run() { callback.failure(new SamzaException(m

[GitHub] [samza] ajothomas commented on a diff in pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-11-09 Thread GitBox
ajothomas commented on code in PR #1637: URL: https://github.com/apache/samza/pull/1637#discussion_r1018502824 ## samza-core/src/main/java/org/apache/samza/config/TaskConfig.java: ## @@ -90,6 +90,13 @@ public class TaskConfig extends MapConfig { // timeout for triggering a ca

[GitHub] [samza] ajothomas commented on a diff in pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-11-09 Thread GitBox
ajothomas commented on code in PR #1637: URL: https://github.com/apache/samza/pull/1637#discussion_r1018501997 ## samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java: ## @@ -106,7 +110,10 @@ public void run() { callback.failure(new SamzaException(m

[GitHub] [samza] ajothomas commented on a diff in pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-11-09 Thread GitBox
ajothomas commented on code in PR #1637: URL: https://github.com/apache/samza/pull/1637#discussion_r1018500682 ## samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java: ## @@ -127,4 +127,14 @@ public List updateCallback(TaskCallbackImpl callback) { retu

[GitHub] [samza] xinyuiscool merged pull request #1640: SAMZA-2741: [Pipeline Drain] Fix ApplicationUtil.isHighLevelApiJob to work for anonymous and lambda `SamzaApplication` classes

2022-11-08 Thread GitBox
xinyuiscool merged PR #1640: URL: https://github.com/apache/samza/pull/1640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[GitHub] [samza] mynameborat commented on a diff in pull request #1640: SAMZA-2741: [Pipeline Drain] Fix ApplicationUtil.isHighLevelApiJob to work for anonymous and lambda `SamzaApplication` classes

2022-11-08 Thread GitBox
mynameborat commented on code in PR #1640: URL: https://github.com/apache/samza/pull/1640#discussion_r1017221725 ## samza-core/src/main/java/org/apache/samza/config/ApplicationConfig.java: ## @@ -46,6 +46,11 @@ public enum ApplicationMode { BATCH } + public enum Appli

[GitHub] [samza] mynameborat commented on pull request #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-08 Thread GitBox
mynameborat commented on PR #1641: URL: https://github.com/apache/samza/pull/1641#issuecomment-1307762089 Is the default support to prevent recursion not available when this change was introduced or did we upgrade to newer version of log4j that adds this prevention at the framework layer?

[GitHub] [samza] jia-gao opened a new pull request, #1641: LISAMZA-27395 removing the current recursive call prevention logic

2022-11-08 Thread GitBox
jia-gao opened a new pull request, #1641: URL: https://github.com/apache/samza/pull/1641 Issue: We have observed logging data loss happen in StreamAppender The RC is that current implementation of the “[append()](https://github.com/apache/samza/blob/master/samza-log4j/src/main/java/or

[GitHub] [samza] mynameborat commented on a diff in pull request #1640: SAMZA-2741: [Pipeline Drain] Fix ApplicationUtil.isHighLevelApiJob to work for anonymous and lambda `SamzaApplication` classes

2022-11-07 Thread GitBox
mynameborat commented on code in PR #1640: URL: https://github.com/apache/samza/pull/1640#discussion_r1016065159 ## samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java: ## @@ -69,6 +69,8 @@ public static Runnable createRunLoop(scala.collection.immutable.Map

[GitHub] [samza] ajothomas opened a new pull request, #1640: SAMZA-2741: [Pipeline Drain] Fix ApplicationUtil.isHighLevelApiJob to work for anonymous and lambda `SamzaApplication` classes

2022-11-07 Thread GitBox
ajothomas opened a new pull request, #1640: URL: https://github.com/apache/samza/pull/1640 # Summary `ApplicationUtil.isHighLevelApiJob` doesn't work for cases where `SamzaApplication` could have been created as an anonymous class and lambdas # Cause Anonymous class names and la

[GitHub] [samza] mynameborat merged pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
mynameborat merged PR #1636: URL: https://github.com/apache/samza/pull/1636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[GitHub] [samza] alnzng commented on pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on PR #1636: URL: https://github.com/apache/samza/pull/1636#issuecomment-1306372678 @mynameborat I have fixed the check issue(checksytle issue) and resolved all the comments. Can you please check? Thanks. -- This is an automated message from the Apache Git Service. To res

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015983431 ## samza-core/src/main/java/org/apache/samza/container/host/ProcessCPUStatistics.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [samza] mynameborat commented on pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
mynameborat commented on PR #1636: URL: https://github.com/apache/samza/pull/1636#issuecomment-1306336433 Looks good to me mostly. Can you close out the conversations that have been resolved and respond to the comments that are pending. Also, fix the latest checks so that I can merge

[GitHub] [samza] mynameborat commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
mynameborat commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015978318 ## samza-core/src/main/java/org/apache/samza/container/host/ProcessCPUStatistics.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015958371 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] lakshmi-manasa-g commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
lakshmi-manasa-g commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015754291 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015751569 ## samza-core/src/main/java/org/apache/samza/container/host/ProcessCPUStatistics.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015714131 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015713429 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] lakshmi-manasa-g commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
lakshmi-manasa-g commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015642158 ## samza-core/src/main/java/org/apache/samza/container/host/SystemStatisticsGetter.java: ## @@ -30,4 +30,11 @@ public interface SystemStatisticsGetter { * @r

[GitHub] [samza] lakshmi-manasa-g commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-07 Thread GitBox
lakshmi-manasa-g commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1015641830 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014527935 ## samza-core/src/main/java/org/apache/samza/container/host/PosixCommandBasedStatisticsGetter.java: ## @@ -85,4 +86,10 @@ public SystemMemoryStatistics getSystemMemoryStat

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014528695 ## samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala: ## @@ -49,6 +49,7 @@ class SamzaContainerMetrics( val executorWorkFactor = newGauge

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014528695 ## samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala: ## @@ -49,6 +49,7 @@ class SamzaContainerMetrics( val executorWorkFactor = newGauge

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014527935 ## samza-core/src/main/java/org/apache/samza/container/host/PosixCommandBasedStatisticsGetter.java: ## @@ -85,4 +86,10 @@ public SystemMemoryStatistics getSystemMemoryStat

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014527343 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014525707 ## samza-core/src/main/java/org/apache/samza/container/host/SystemStatisticsGetter.java: ## @@ -30,4 +30,11 @@ public interface SystemStatisticsGetter { * @return {@li

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014525560 ## samza-core/src/main/java/org/apache/samza/container/host/SystemStatistics.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014525279 ## samza-core/src/main/java/org/apache/samza/container/host/StatisticsMonitorImpl.java: ## @@ -117,23 +118,23 @@ public void run() { } private void sampleStatistic

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014524771 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014523821 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014523336 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] alnzng commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
alnzng commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014522272 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [samza] mynameborat commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
mynameborat commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1013440757 ## samza-core/src/main/java/org/apache/samza/container/host/DefaultSystemStatisticsGetter.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [samza] lakshmi-manasa-g commented on a diff in pull request #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-11-04 Thread GitBox
lakshmi-manasa-g commented on code in PR #1636: URL: https://github.com/apache/samza/pull/1636#discussion_r1014326963 ## samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundatio

[GitHub] [samza] alnzng commented on pull request #1638: SAMZA-2764: add the metric "container-active-threads" back

2022-11-04 Thread GitBox
alnzng commented on PR #1638: URL: https://github.com/apache/samza/pull/1638#issuecomment-1303916282 thanks for merging it @mynameborat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [samza] mynameborat merged pull request #1638: SAMZA-2764: add the metric "container-active-threads" back

2022-11-03 Thread GitBox
mynameborat merged PR #1638: URL: https://github.com/apache/samza/pull/1638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[GitHub] [samza] mynameborat commented on a diff in pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-11-03 Thread GitBox
mynameborat commented on code in PR #1637: URL: https://github.com/apache/samza/pull/1637#discussion_r1013403151 ## samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java: ## @@ -106,7 +110,10 @@ public void run() { callback.failure(new SamzaException

[GitHub] [samza] xinyuiscool merged pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
xinyuiscool merged PR #1639: URL: https://github.com/apache/samza/pull/1639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.ap

[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123821 ## samza-test/src/test/java/org/apache/samza/test/drain/DrainHighLevelApiIntegrationTest.java: ## @@ -74,20 +74,30 @@ public void describe(StreamApplicationDescriptor

[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123456 ## samza-core/src/main/java/org/apache/samza/container/RunLoop.java: ## @@ -875,49 +876,40 @@ private boolean shouldDrain() { return false; } - i

[GitHub] [samza] ajothomas commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-03 Thread GitBox
ajothomas commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1013123301 ## samza-core/src/main/java/org/apache/samza/container/RunLoop.java: ## @@ -875,49 +876,40 @@ private boolean shouldDrain() { return false; } - i

[GitHub] [samza] ajothomas commented on a diff in pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-11-02 Thread GitBox
ajothomas commented on code in PR #1637: URL: https://github.com/apache/samza/pull/1637#discussion_r1012008633 ## samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java: ## @@ -76,7 +76,7 @@ List update(TaskCallbackImpl cb) { private final TaskCallbacks compl

[GitHub] [samza] xinyuiscool commented on a diff in pull request #1639: SAMZA-2741: [Pipeline Drain] Fix processing of Drain messages for High-Level and Low-level API

2022-11-01 Thread GitBox
xinyuiscool commented on code in PR #1639: URL: https://github.com/apache/samza/pull/1639#discussion_r1010901435 ## samza-test/src/test/java/org/apache/samza/test/drain/DrainHighLevelApiIntegrationTest.java: ## @@ -74,20 +74,30 @@ public void describe(StreamApplicationDescriptor

[GitHub] [samza] ajothomas opened a new pull request, #1639: SAMZA-2741: Pipeline Drain- Fix processing of Drain messages for High-Level and Low-level API

2022-11-01 Thread GitBox
ajothomas opened a new pull request, #1639: URL: https://github.com/apache/samza/pull/1639 # Symptoms and Cause: There were a few issues with the processing of drain messages that this PR attempts to fix. The following issues were encountered during the end-to-end testing with test pipel

[GitHub] [samza] alnzng opened a new pull request, #1638: SAMZA-2764: add the metric "container-active-threads" back

2022-11-01 Thread GitBox
alnzng opened a new pull request, #1638: URL: https://github.com/apache/samza/pull/1638 # Symptom No data was emitted for the metric `container-active-threads` # Cause This PR(#1501 ) removed the logic to emit data for metric accidently: https://github.com/apache/samza/p

[GitHub] [samza] mynameborat commented on a diff in pull request #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-10-31 Thread GitBox
mynameborat commented on code in PR #1637: URL: https://github.com/apache/samza/pull/1637#discussion_r1010012333 ## samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java: ## @@ -76,7 +76,7 @@ List update(TaskCallbackImpl cb) { private final TaskCallbacks com

[GitHub] [samza] ajothomas opened a new pull request, #1637: SAMZA-2765: [Pipeline Drain] Adding config for task callback timeout during drain

2022-10-31 Thread GitBox
ajothomas opened a new pull request, #1637: URL: https://github.com/apache/samza/pull/1637 # Improvement: This PR is a part of the Pipeline Drain work and aims to provide a way to specify a task callback timeout to be used for pipeline drain. The standard `task.callback.timeout.ms` p

[GitHub] [samza] Treydone commented on pull request #1633: Add GraalSystems in "powered-by"

2022-10-31 Thread GitBox
Treydone commented on PR #1633: URL: https://github.com/apache/samza/pull/1633#issuecomment-1297695724 Sorry, I can't build the site locally... Even from the master branch with the command `bundle exec jekyll build,` I got an error ``` jekyll 3.4.5 | Error: No header received bac

[GitHub] [samza] mynameborat commented on pull request #1635: SAMZA-2763: Support worker JVM opts for Samza Beam portable mode

2022-10-26 Thread GitBox
mynameborat commented on PR #1635: URL: https://github.com/apache/samza/pull/1635#issuecomment-1292317691 We will revisit this when we have Samza Beam portable support in oSS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [samza] mynameborat closed pull request #1635: SAMZA-2763: Support worker JVM opts for Samza Beam portable mode

2022-10-26 Thread GitBox
mynameborat closed pull request #1635: SAMZA-2763: Support worker JVM opts for Samza Beam portable mode URL: https://github.com/apache/samza/pull/1635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [samza] alnzng opened a new pull request, #1636: SAMZA-2762: new cpu usage metric which counts child processes usage

2022-10-25 Thread GitBox
alnzng opened a new pull request, #1636: URL: https://github.com/apache/samza/pull/1636 # Symptom We have observed that some use cases used quasar(TensorFlow framework) to do model inference and this framework spawn child processes(non-JVM) to run TensorFlow serving. These child proc

[GitHub] [samza] mynameborat opened a new pull request, #1635: SAMZA-2763: Support worker JVM opts for Samza Beam portable mode

2022-10-25 Thread GitBox
mynameborat opened a new pull request, #1635: URL: https://github.com/apache/samza/pull/1635 **Summary**: Support JVM options for worker process in Samza Beam portable mode **Description**: With portable mode support for Samza Beam, we want to tune and configure the JVM options for worke

[GitHub] [samza] sborya merged pull request #1634: Update zookeeper and kazoo version

2022-10-17 Thread GitBox
sborya merged PR #1634: URL: https://github.com/apache/samza/pull/1634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@samza.apache.

[GitHub] [samza] mynameborat commented on pull request #1633: Add GraalSystems in "powered-by"

2022-10-17 Thread GitBox
mynameborat commented on PR #1633: URL: https://github.com/apache/samza/pull/1633#issuecomment-1281000897 can you publish the website locally to make sure the changes look as expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

  1   2   3   4   5   6   7   8   9   10   >