Re: [Discuss] plugins release

2016-09-08 Thread David Barth
Hey guys, Alex has a set of fixes for ubuntu code in the following plugins: - https://github.com/apache/cordova-plugin-inappbrowser/pull/174 - https://github.com/apache/cordova-plugin-battery-status/pull/38 - https://github.com/cordova-ubuntu/cordova-plugin-geolocation/pull/2 Should we

[GitHub] cordova-plugin-battery-status issue #38: CB-11256: (ubuntu) Qt API change br...

2016-09-08 Thread david-barth-canonical
Github user david-barth-canonical commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/38 Just to confirm LGTM and +1 from me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-inappbrowser issue #174: CB-3360 Fix Oxide version & support ...

2016-09-08 Thread david-barth-canonical
Github user david-barth-canonical commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/174 Just to confirm LGTM and +1 from me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-06-15 Thread David Barth
I merged the PRs in. > > > > > > Building and deploying site now. I'll post here once it is live. > > > > > > -Steve > > > > > > On Tue, Jun 14, 2016 at 2:32 AM, David Barth < > david.ba...@canonical.com> > > > wrote: > &g

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-06-14 Thread David Barth
://github.com/apache/cordova-docs/pull/610 Can you guys review the pull-requests (I don't have rights to merge it right now in Github) Thanks David On Wed, Jun 8, 2016 at 4:39 PM, David Barth wrote: > > On Tue, Jun 7, 2016 at 2:36 AM, Shazron wrote: > >> Time to wra

Re: [Vote] 4.3.4 Ubuntu Release

2016-06-08 Thread David Barth
Thanks everyone. The vote has now closed. The results are: Positive Binding Votes: 3 David Barth Shazron Abdullah Jesse MacFadyen Negative Binding Votes: 0 The vote has passed. On Fri, Jun 3, 2016 at 9:27 PM, Jesse wrote: > +1 > > - verified archive sigs, and git tag > - cre

Re: [DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-06-08 Thread David Barth
On Tue, Jun 7, 2016 at 2:36 AM, Shazron wrote: > Time to wrap up the vote, David? > Indeed. Thanks for the feedback.

[GitHub] cordova-docs pull request #610: CB 11328 - Ubuntu platform documentation upd...

2016-06-08 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/610 CB 11328 - Ubuntu platform documentation update Update the platform guide to reflect the status as of cordova-ubuntu@4.3.4 You can merge this pull request into a Git repository

[Vote] 4.3.4 Ubuntu Release

2016-05-26 Thread David Barth
Hey, Please review and vote on this 4.3.4 Ubuntu Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-11294 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-11294/ The p

[GitHub] cordova-docs pull request: Cordova Ubuntu 4.3.4 release announceme...

2016-05-26 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/607 Cordova Ubuntu 4.3.4 release announcement You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-docs

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

2016-05-24 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-docs/pull/497#issuecomment-221223223 Yeah, probably. I'll redo an announcement for 4.3.4 --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

2016-05-24 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-docs/pull/497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[DISCUSS] Cordova-Ubuntu Release 4.3.4

2016-05-19 Thread David Barth
Hey, Just a quick note to say I'm going to do another minor release of cordova-ubuntu to fix some bugs. It will still be on the 4.3.x line, ie a bit outdated, but to keep a safe fallback while we get 6.x ready for developers to use. I will use https://issues.apache.org/jira/browse/CB-11294

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

2016-05-12 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-battery-status pull request: CB-11256 (was Fix due ...

2016-05-12 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/35 CB-11256 (was Fix due to Qt SystemInfo API updates) You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova

[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...

2016-05-09 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-lib/pull/438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: Fix plugin platform_www & cordova_plugin...

2016-05-09 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/438 Fix plugin platform_www & cordova_plugins.json copy You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cor

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.3 blog post

2016-02-10 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/497 Add Cordova Ubuntu 4.3.3 blog post Blog post to announce cordova-ubuntu 4.3.3 You can merge this pull request into a Git repository by running: $ git pull https

Re: [Vote] 4.3.3 Ubuntu Release

2016-02-09 Thread David Barth
The vote has now closed. The results are: Positive Binding Votes: 3 David Barth Steven Gill Jesse MacFadyen Negative Binding Votes: 0 The vote has passed. On Tue, Feb 9, 2016 at 10:04 AM, David Barth wrote: > \o/ Thank you Jesse. > > The warning is not a regression. We're

Re: [Vote] 4.3.3 Ubuntu Release

2016-02-09 Thread David Barth
t think this blocks the vote. > === > missing icon element in config.xml > Error: icon does not exist: > /Tests/UbuntuVote/platforms/ubuntu/www/www/img/logo.png > > > @purplecabbage > risingj.com > > On Mon, Feb 8, 2016 at 5:31 AM, David Barth > wrote: > > &

Re: [Vote] 4.3.3 Ubuntu Release

2016-02-08 Thread David Barth
Thanks Steven, I need one more vote. Anyone else can run a quick: platform add / rm ? On Fri, Feb 5, 2016 at 7:34 PM, Steven Gill wrote: > +1 > > ran coho verify archive > added fine to a project. Can't build due to lack of environment. > > On Fri, Feb 5, 2016 at 8:15 A

Re: [Vote] 4.3.3 Ubuntu Release

2016-02-05 Thread David Barth
Any feedback on the release? I need your votes ! :) On Thu, Jan 28, 2016 at 5:25 PM, David Barth wrote: > Please review and vote on this 4.3.3 Ubuntu Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/bro

Re: [DISCUSS] Cordova-Ubuntu Release

2016-02-03 Thread David Barth
your key to dist/keys? > > I was trying to verify your archive and ran into it not being able to find > the public key. > > On Wed, Jan 27, 2016 at 7:50 AM, Mefire O. wrote: > > > +1 > > > > On Jan 27, 2016 7:19 AM, Steven Gill wrote: > > +1 > > On Jan

[Vote] 4.3.3 Ubuntu Release

2016-01-28 Thread David Barth
Please review and vote on this 4.3.3 Ubuntu Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10453 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10453/ The package

[GitHub] cordova-ubuntu pull request: Set of fixes for Cordova-Ubuntu 4.3.3

2016-01-28 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ubuntu pull request: Set of fixes for Cordova-Ubuntu 4.3.3

2016-01-28 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/21 Set of fixes for Cordova-Ubuntu 4.3.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu master

Re: [DISCUSS] Old platforms support deprecation

2016-01-27 Thread David Barth
On Mon, Jan 25, 2016 at 8:16 PM, Steven Gill wrote: > Nikhil, sounds reasonable. > > I originally misunderstood Vlads message. He isn't proposing the > PlatformAPI Polyfill for deprecation. This is the code which is used by > platforms that haven't released a platform API implementation. > > He i

Re: [DISCUSS] Cordova 6.0.0 Release!

2016-01-27 Thread David Barth
+1 On Fri, Jan 22, 2016 at 9:24 PM, Steven Gill wrote: > any objections or concerns? Some PRs or issues that need to get fixed > before I do this? > > I want to try to get the vote out either later today or Monday. > > -Steve >

[DISCUSS] Cordova-Ubuntu Release

2016-01-27 Thread David Barth
Hi, I need to do another quick interim release of Cordova-Ubuntu to address a significant bug with the use of a deprecated Oxide API. This should become cordova-ubuntu@4.3.3 Does anyone have any reason to delay a cordova-ubuntu platform release? Any outstanding patches to land? I am starting th

[GitHub] cordova-docs pull request: Add Cordova Ubuntu 4.3.2 blog post

2016-01-08 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-docs/pull/452 Add Cordova Ubuntu 4.3.2 blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-docs cordova

Re: [DISCUSS] Cordova-Ubuntu Release

2016-01-05 Thread David Barth
--- > >> > >> Do you think I'm missing something? > >> cordova --version gives 4.3.1 > >> > >> I'm not running locally linked cordova-lib copies, just whatever was > >> released by the CLI. > >> > >> On Fri,

Re: [Vote] 4.3.2 Ubuntu Release (attempt 2)

2016-01-05 Thread David Barth
I double checked and I think I can now technically conclude the vote positively, though i'm not officially listed on the PMC page yet ( http://people.apache.org/committers-by-project.html#cordova-pmc) The vote has now closed. The results are: Positive Binding Votes: 3 David Barth Sh

Re: [Vote] 4.3.2 Ubuntu Release (attempt 2)

2016-01-04 Thread David Barth
ncies > have Apache-compatible licenses > * added platform and built using master versions of the CLI and > cordova-lib (on OS X and Ubuntu 15) > > > On Mon, Dec 21, 2015 at 3:33 AM, David Barth > wrote: > > Please review and vote on this 4.3.2 Android Release > > b

[Vote] 4.3.2 Ubuntu Release (attempt 2)

2015-12-21 Thread David Barth
Please review and vote on this 4.3.2 Android Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10210 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10210/ The packag

Re: [Vote] 4.3.2 Ubuntu Release

2015-12-21 Thread David Barth
Fri, Dec 18, 2015 at 6:36 AM David Barth > wrote: > > > I will ask for a re-vote on this, as I have pushed an updated archive > with > > the missing node_modules. I also made a git commit (tag moved forward as > > well) with the missing directory as well. > > &

Re: [Vote] 4.3.2 Ubuntu Release

2015-12-18 Thread David Barth
ISCUSS] thread. > > On Thu, Dec 17, 2015 at 11:08 AM, David Barth > wrote: > > Please review and vote on this 4.3.2 Ubuntu Release > > by replying to this email (and keep discussion on the DISCUSS thread) > > > > Release issue: https://issues.apache.org/jira/brows

Re: [DISCUSS] Cordova-Ubuntu Release

2015-12-18 Thread David Barth
https://git-wip-us.apache.org/repos/asf/cordova-ubuntu.git#4.3.2 > > instead. > > --- > On both OS X 10.11 and Ubuntu 15.10: > > I get an exception: > https://gist.github.com/shazron/b8449933e532d4185084 > > This does not happen on ubuntu@4.3.1 (default) > > >

[Vote] 4.3.2 Ubuntu Release

2015-12-17 Thread David Barth
Please review and vote on this 4.3.2 Ubuntu Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10210 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10210/ The package

[GitHub] cordova-ubuntu pull request: CB-10119 - Can't install click chroot...

2015-12-17 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/20 CB-10119 - Can't install click chroot 14.10 Fix for CB-10119, switching the default framework to 15.04 Also a fix for check_reqs which was referencing a function tha

[DISCUSS] Cordova-Ubuntu Release

2015-12-17 Thread David Barth
Hi, I would like to do a quick interim release for cordova-ubuntu, in order to fix the default framework used. This bug is referenced here: https://issues.apache.org/jira/browse/CB-10119 I have created the release task here and am proceeding with

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

2015-12-03 Thread David Barth
have node_modules > > > On Wed, Dec 2, 2015 at 1:55 PM Steven Gill wrote: > > > Okay sweet. Can you add a +1 on the vote thread that is open for Ubuntu. > We > > need one other committer to give a +1 so I can wrapnit up and publish > > On Dec 2, 2015 10:47 AM, &

Re: [NOTICE] David Barth has become a committer

2015-12-03 Thread David Barth
; On Wed, Dec 2, 2015 at 4:58 AM David Barth > wrote: > > > Thanks everyone for the kind welcome messages. > > > > Yeah, Ubuntu is here, either as a host platform for cordova-android or > as a > > target with cordova-ubuntu (desktop, device or as a converged platform)

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

2015-12-03 Thread david-barth-canonical
Github user david-barth-canonical commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/349#discussion_r46569876 --- Diff: cordova-lib/src/plugman/platforms/ubuntu.js --- @@ -29,6 +29,54 @@ function toCamelCase(str) { }).join

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-12-02 Thread david-barth-canonical
Github user david-barth-canonical commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/294#discussion_r46471716 --- Diff: cordova-lib/src/plugman/platforms/ubuntu.js --- @@ -29,6 +29,51 @@ function toCamelCase(str) { }).join

[GitHub] cordova-lib pull request: Cb 9590 - Ubuntu support for the new plu...

2015-12-02 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/349 Cb 9590 - Ubuntu support for the new plugin naming convention Re-opening the pull request with hopefully a better fix that can handle all situations. You can merge this pull

Re: [VOTE] cordova-ubuntu 4.3.1

2015-12-02 Thread David Barth
+1 On Wed, Nov 25, 2015 at 2:33 AM, Steven Gill wrote: > Please review and vote on this 4.3.1 Ubuntu Release > by replying to this email (and keep discussion on the DISCUSS thread) > > Release issue: https://issues.apache.org/jira/browse/CB-10030 > > The archive has been published to > dist/dev:

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

2015-12-02 Thread David Barth
On Tue, Dec 1, 2015 at 10:01 PM, Steven Gill wrote: > Which raw api changes to cordova@5.3.x make it unusable with ubuntu? As > far > as I know, cordova-ubuntu should work the same with cordova@4.x and > cordova@5.x. The platform API changes aren't necessary to work with > cordova@5.x > It worke

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

2015-12-02 Thread David Barth
g changes to cordova-lib, make sure to send them as PRs still > so > > people can review them. Especially if the change can possible affect > other > > platforms. > > > > > > > > > > > > On Tue, Dec 1, 2015 at 9:08 AM, David Barth > > wrot

[GitHub] cordova-lib pull request: Cb 9618 - Icon parameter should not be r...

2015-12-02 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/347 Cb 9618 - Icon parameter should not be relative to the www directory on Ubuntu This patch fixes a long standing issue, whereby the icon parameter in the app manifest was

Re: [NOTICE] David Barth has become a committer

2015-12-02 Thread David Barth
ir manager) know with > Kudos. > > > > > > From: Jesse > > Sent: Tuesday, December 1, 2015 1:04 PM > > To: dev@cordova.apache.org > > Subject: Re: [NOTICE] David Barth has become a committer > > > > Con

Re: [DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

2015-12-01 Thread David Barth
en Gill > wrote: > > > Starting the vote for this > > > > On Tue, Nov 17, 2015 at 9:31 AM, David Barth > > wrote: > > > >> Hey, > >> > >> I would like to update the 4.x series of cordova-ubuntu with a couple of > >> fixes, and

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

2015-11-20 Thread David Barth
On Fri, Nov 20, 2015 at 2:31 AM, Steven Gill wrote: > [...] > @David, I can review those changes. Can you send it as PRs and send me the > links. They can go out in the next tools release (soon)! > Sure, Pull-requests, re-opened here: https://github.com/apache/cordova-lib/pull/294

[GitHub] cordova-ubuntu pull request: Cordova-Ubuntu Platform Release 4.3.1...

2015-11-19 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/19 Cordova-Ubuntu Platform Release 4.3.1 From the RELEASENOTES.md * default icon name www/img/logo.png * add defaut icon parameter to config.xml * use QUrl

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

2015-11-17 Thread David Barth
an re-do pull-requests if those 2 are eligible for that patch release. Let me know David On Tue, Nov 17, 2015 at 6:24 PM, David Barth wrote: > Yeah, +1 for https://issues.apache.org/jira/browse/CB-9987 to help manage > the transition of platforms to the 5.x world > > > On Tue, Nov

[DISCUSS] Cordova-Ubuntu bug fix release (4.3.1)

2015-11-17 Thread David Barth
Hey, I would like to update the 4.x series of cordova-ubuntu with a couple of fixes, and make it the last in the series supporting the cordova-cli 4.3.1 branch as well - Cb 9868 - Should propose to install missing Ubuntu dependencies on platform add

Re: [DISCUSS] Cordova CLI & LIB 5.4.1 Release

2015-11-17 Thread David Barth
Yeah, +1 for https://issues.apache.org/jira/browse/CB-9987 to help manage the transition of platforms to the 5.x world On Tue, Nov 17, 2015 at 3:24 AM, Steven Gill wrote: > Need to do a patch release for Lib & CLI. > > Fixing these 3 issues: > https://issues.apache.org/jira/browse/CB-9976 > htt

[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...

2015-11-13 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls

2015-11-13 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ubuntu pull request: Cb 9694 - Add support for HTTP urls

2015-11-12 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/18 Cb 9694 - Add support for HTTP urls The cordova-ubuntu container currently does not support loading the app from a network URL, only local file URLs. This prevents features

[GitHub] cordova-ubuntu pull request: check if content src points to a url ...

2015-11-12 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-ubuntu/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-11-03 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-153422772 I have update the pull request to add support for taking the class name from the plugin.xml file. For plugins using one of the 2 existing naming

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-10-16 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-148743166 ok, i understand the problem now. In particular, the code to guess the classname is nice, but other platforms resort to encapsulating this

[GitHub] cordova-ubuntu pull request: add defaut icon parameter to config.x...

2015-10-15 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/16 add defaut icon parameter to config.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu CB

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-10-15 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-148342742 It does work on my system at least. I run this branch along with my other 3 pull requests, but I don't think they have an influence on the p

[GitHub] cordova-ubuntu pull request: check if content src points to a url ...

2015-09-30 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-ubuntu/pull/14 check if content src points to a url or local file You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-23 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/299#issuecomment-142564241 Yes, makes sense. Icon management needs more tweaks, but this way it will work better already Thanks for the review. --- If your project is set up

[GitHub] cordova-lib pull request: icon parameter should not be relative to...

2015-09-07 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/299 icon parameter should not be relative to the www directory on Ubuntu You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova

[GitHub] cordova-lib pull request: Cb 9618

2015-09-07 Thread david-barth-canonical
Github user david-barth-canonical closed the pull request at: https://github.com/apache/cordova-lib/pull/298 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: Cb 9618

2015-09-07 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/298 Cb 9618 Patch to change iconPath to be relative to the project root directory, only; ie not to the www sub-directory anymore. You can merge this pull request into a Git

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-09-07 Thread david-barth-canonical
Github user david-barth-canonical commented on the pull request: https://github.com/apache/cordova-lib/pull/294#issuecomment-138310314 It does work both with old style plugin names, like "org.apache.cordova.battery-status" and new style names "cordova-plugin-media-capt

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-09-01 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/294 CB-9590 - Ubuntu support for the new plugin naming convention This patch allows ubuntu users to add plugins using the new naming convention and build properly. This also leaves

Re: 3.3.0 Release

2013-12-12 Thread David Barth
Le 12/12/2013 14:34, David Barth a écrit : Other platforms ran into the permission issue you mentioned. I think https://issues.apache.org/jira/browse/CB-3812 should have fixed it. Maybe others can chime in with some suggestions here too. Yes, I couldn't re-install support for android

Re: 3.3.0 Release

2013-12-12 Thread David Barth
Le 11/12/2013 23:49, Steven Gill a écrit : The master branch on CLI now depends on the correct plugman. That problem should be good. I will review the two pull requests and merge in if they look good. And there is a 3rd one to make it run more reliably: https://github.com/Zaspire/cordova-ubuntu

Re: 3.3.0 Release

2013-12-12 Thread David Barth
Le 12/12/2013 03:21, Carlos Santana a écrit : CLI design contract is to just run platforms//bin/create nothing about running npm install on platform repo files. If your platform scripts have dependencies platform is responsible to satisfy its dependencies. BlackBerry and Android have dependenci

Re: 3.3.0 Release

2013-12-11 Thread David Barth
Le 11/12/2013 16:39, David Barth a écrit : Le 10/12/2013 19:37, Steven Gill a écrit : Lets start the final round of tagging today! https://issues.apache.org/jira/browse/CB-5538 +1, but we're still chasing down some dependency and chmod +x issues on the Ubuntu part. Will update this t

Re: 3.3.0 Release

2013-12-11 Thread David Barth
Le 10/12/2013 19:37, Steven Gill a écrit : Lets start the final round of tagging today! https://issues.apache.org/jira/browse/CB-5538 +1, but we're still chasing down some dependency and chmod +x issues on the Ubuntu part. Will update this thread shortly. David

Pull request: fix ubuntu platform for ia32

2013-12-10 Thread David Barth
See https://github.com/apache/cordova-cli/pull/111 I think it's important to fix for 3.3.0-rc1 Thanks David

Pull request: Add Ubuntu to the README.md file

2013-12-06 Thread David Barth
Hi, In preparation for the 3.3 release, here is a quick pull request to add Ubuntu to the README.md file, along with some release notes elements https://github.com/apache/cordova-cli/pull/106 (namely no cross-compilation support from cordova-cli yet, but coming soon hopefully) David