Re: Review Request 25270: Enable bridge network in Mesos

2014-09-04 Thread Timothy Chen
> On Sept. 3, 2014, 10:59 a.m., Tom Arnfeld wrote: > > What's the reason for not also supporting the `port` resource type? For > > example, the Hadoop framework uses this > > https://github.com/mesos/hadoop/blob/master/src/main/java/org/apache/hadoop/mapred/ResourcePolicy.java#L458-L472. > > I

Re: Review Request 25270: Enable bridge network in Mesos

2014-09-04 Thread Tom Arnfeld
> On Sept. 3, 2014, 10:59 a.m., Tom Arnfeld wrote: > > What's the reason for not also supporting the `port` resource type? For > > example, the Hadoop framework uses this > > https://github.com/mesos/hadoop/blob/master/src/main/java/org/apache/hadoop/mapred/ResourcePolicy.java#L458-L472. > > I

Re: Review Request 25334: Fixed python egg proto imports.

2014-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52413 --- Patch looks great! Reviews applied: [25334] All tests passed. - M

Review Request 25372: Made the GarbageCollector injectable into the Slave.

2014-09-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25372/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1715 https://issues.ap

Review Request 25373: Added a test for sending pending tasks during re-registration.

2014-09-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25373/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1715 https://issues.ap

Review Request 25371: Send pending tasks during re-registration.

2014-09-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25371/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1715 https://issues.ap

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/#review52400 --- Patch looks great! Reviews applied: [24984] All tests passed. - M

Re: Review Request 25355: Minor update to include package config file

2014-09-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/#review52398 --- Ship it! Ship It! - Vinod Kone On Sept. 4, 2014, 9 p.m., Timothy

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2380

2014-09-04 Thread Benjamin Mahler
Alright, I'm going to remove the H11 slave from the label expression to cut the noise. Filed a ticket for getting libcurl installed: https://issues.apache.org/jira/browse/INFRA-8308 On Thu, Sep 4, 2014 at 4:59 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://build

Re: Review Request 25355: Minor update to include package config file

2014-09-04 Thread Timothy St. Clair
> On Sept. 4, 2014, 9:19 p.m., Vinod Kone wrote: > > Makefile.am, lines 27-28 > > > > > > i'm likely missing context. what is this for? A while back we added a package config file, or .pc file. This mod installs it i

Jenkins build is back to normal : Mesos-Ubuntu-distcheck #317

2014-09-04 Thread Apache Jenkins Server
See

Review Request 25369: Add Dockerfile for building Mesos from source

2014-09-04 Thread Gabriel Monroy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25369/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME #2380

2014-09-04 Thread Apache Jenkins Server
See Changes: [yujie.jay] Improved the error message when destroying a container. -- [...truncated 260 lines...] 3rdparty/Makefile.am:145: warning: source file

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review52372 --- src/linux/cgroups.cpp

Re: Review Request 25344: Improved the error message when destroying a container.

2014-09-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/#review52380 --- Ship it! src/linux/cgroups.cpp

Re: Review Request 25344: Improved the error message when destroying a container.

2014-09-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- (Updated Sept. 4, 2014, 11:47 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25344: Improved the error message when destroying a container.

2014-09-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- (Updated Sept. 4, 2014, 11:42 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25344: Improved the error message when destroying a container.

2014-09-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/#review52378 --- Ship it! Thanks! src/linux/cgroups.cpp

Re: Review Request 25344: Improved the error message when destroying a container.

2014-09-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- (Updated Sept. 4, 2014, 11:12 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-09-04 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Sept. 4, 2014, 11:01 p.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-09-04 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Sept. 4, 2014, 10:49 p.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25270: Enable bridge network in Mesos

2014-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 4, 2014, 10:04 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-04 Thread Timothy Chen
> On Sept. 4, 2014, 8:23 p.m., Timothy St. Clair wrote: > > src/docker/docker.cpp, line 324 > > > > > > Don't you want --host= and --bridge=br(x), in the case where folks > > configure bridges for vlans? Hi Tim, the

Re: Review Request 25355: Minor update to include package config file

2014-09-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/#review52358 --- Makefile.am

deploy_dir

2014-09-04 Thread Tim St Clair
Quick Pole: Do folks care if - deploy_dir=@localstatedir@/@PACKAGE@/deploy vs. deploy_dir=@sysconfdir@/@PACKAGE@ Right now I keep them in: '/etc/mesos/' but in all honesty, they should probably live in: /etc/sysconfig/mesos-*-env Thoughts? -- Cheers, Timothy St. Clair Red Hat Inc.

Re: Review Request 22066: Added timeout to rescind unused offers

2014-09-04 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22066/ --- (Updated Sept. 4, 2014, 5:09 p.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 22066: Added timeout to rescind unused offers

2014-09-04 Thread Kapil Arya
> On Aug. 19, 2014, 6:21 p.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, lines 2134-2136 > > > > > > This comment is no longer relevant, and we can remove the Clock::resume > > Ben Mahler wrote: > Unfortu

Review Request 25355: Minor update to include package config file

2014-09-04 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25355/ --- Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone. Bugs: MESOS

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

2014-09-04 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/ --- (Updated Sept. 4, 2014, 8:45 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 4, 2014, 8:34 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25250: Mark running tasks killed during framework shutdown.

2014-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25250/#review52351 --- Patch looks great! Reviews applied: [25250] All tests passed. - M

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/ --- (Updated Sept. 4, 2014, 8:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25270: Enable bridge networking and port mapping for Docker

2014-09-04 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25270/#review52347 --- src/docker/docker.cpp

Jenkins build is back to normal : mesos-reviewbot #1466

2014-09-04 Thread Apache Jenkins Server
See

Re: Review Request 25205: Fix command executor path check

2014-09-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25205/#review52333 --- Bad patch! Reviews applied: [25205] Failed command: git apply --in

Re: Review Request 25334: Fixed python egg proto imports.

2014-09-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52331 --- src/Makefile.am

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-09-04 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/#review52317 --- 3rdparty/libprocess/src/encoder.hpp

Re: Review Request 25334: Fixed python egg proto imports.

2014-09-04 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/#review52316 --- Ship it! :thumbsup: Is there any reason we're not running `test-co

Review Request 25344: Improved the error message when destroying a container.

2014-09-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25344/ --- Review request for mesos and Ben Mahler. Repository: mesos-git Description --

Re: The mesos.interface python egg

2014-09-04 Thread Thomas Rampelberg
I'm not sure what happened, but I got it fixed up this morning. On Thu, Sep 4, 2014 at 4:55 AM, Till Toenshoff wrote: >> Has someone been changing things relating to the new *mesos.interface* python >> egg on pypi? I don't seem to be able to install it anymore.. which is >> strange as it's listed

Re: The mesos.interface python egg

2014-09-04 Thread Till Toenshoff
> Has someone been changing things relating to the new *mesos.interface* python > egg on pypi? I don't seem to be able to install it anymore.. which is > strange as it's listed as available on the pypi site. > > Here's some output: https://gist.github.com/tarnfeld/dcf936eb247c7bd5d2d1 I am gettin

Review Request 25334: Fixed python egg proto imports.

2014-09-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25334/ --- Review request for mesos, Benjamin Hindman, Tom Arnfeld, Thomas Rampelberg, and

Re: Review Request 24984: Libprocess: Use Content-Length instead of Encoding: Chunked

2014-09-04 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24984/ --- (Updated Sept. 4, 2014, 9:28 a.m.) Review request for mesos. Changes ---

The mesos.interface python egg

2014-09-04 Thread Tom Arnfeld
Hey guys, Has someone been changing things relating to the new *mesos.interface* python egg on pypi? I don't seem to be able to install it anymore.. which is strange as it's listed as available on the pypi site. Here's some output: https://gist.github.com/tarnfeld/dcf936eb247c7bd5d2d1 Cheers, T