://reviews.apache.org/r/20863/diff/
Testing
---
Tested locally.
Thanks,
Vinod Kone
;https://reviews.apache.org/r/20026/#comment75332>
why the change in brace type?
src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/20026/#comment75335>
move this to tests/mesos.hpp?
- Vinod Kone
On April 29, 2014, 6:24 p.m., Ian Downes wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20870/#review41789
---
Ship it!
Ship It!
- Vinod Kone
On April 30, 2014, 12:25 a.m
Is someone looking into this? Till?
On Tue, Apr 29, 2014 at 3:38 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:
> See <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/1821/changes
> >
>
> Changes:
>
> [idownes] Rename CgroupsLauncher to LinuxLauncher
introduced. I'm looking into it.
> >>
> >> On Apr 29, 2014, at 5:26 PM, Vinod Kone wrote:
> >>
> >>> Is someone looking into this? Till?
> >>>
> >>>
> >>> On Tue, Apr 29, 2014 at 3:38 PM, Apache Jenk
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20872/#review41795
---
Ship it!
Ship It!
- Vinod Kone
On April 30, 2014, 1:19 a.m
874/#comment75423>
Kill the comment.
- Vinod Kone
On April 30, 2014, 2:50 a.m., Tobi Knaup wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
hey adam can you triage this?
On Tue, Apr 29, 2014 at 11:09 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:
> See <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2101/changes
> >
>
> Changes:
>
> [vinod] Fixed distclea
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20884/#review41833
---
Ship it!
Ship It!
- Vinod Kone
On April 30, 2014, 8:38 a.m
<https://reviews.apache.org/r/20898/#comment75528>
Can X be different than T?
- Vinod Kone
On April 30, 2014, 6:28 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20898/#review41878
---
Ship it!
Ship It!
- Vinod Kone
On April 30, 2014, 7:41 p.m
sos-tests`mesos::internal::tests::Cluster::Slaves::shutdown(this=0x000108506f38)
>> >>> + 2124 at cluster.hpp:450, queue = 'com.apple.main-thread', stop
>> reason =
>> >>> EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
>> >>>frame #0: 0x000100093f1c
&
https://issues.apache.org/jira/browse/MESOS-1273
On Wed, Apr 30, 2014 at 4:06 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:
> See <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2103/changes
> >
>
> Changes:
>
> [bma
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20929/#review41900
---
Ship it!
Ship It!
- Vinod Kone
On May 1, 2014, 12:04 a.m
f205dca43f10697862e3fd3f435f1127a9d0aecb
Diff: https://reviews.apache.org/r/20932/diff/
Testing
---
make check (there were some unrelated flaky/broken tests for which there are
already tickets filed)
Thanks,
Vinod Kone
check
Thanks,
Vinod Kone
Looks like the fix still needs some time. I'll disable the test on the
master in the meanwhile to unblock others.
On Wed, Apr 30, 2014 at 3:58 PM, Vinod Kone wrote:
> If you need time to fix it and don't want to feel pressured to submit a
> fix we could disable the test on t
commit ef6423cdc0085a66d895482d4d041e2135072c5c
Author: Vinod Kone
Date: Thu May 1 12:59:06 2014 -0700
Temporarily disabled ExternalContainerizerTest.Launch due to
MESOS-1257.
On Thu, May 1, 2014 at 12:36 PM, Vinod Kone wrote:
> Looks like the fix still needs some time. I
On Thu, May 1, 2014 at 4:38 PM, Ian Downes (JIRA) wrote:
> [vagrant@mesos cpu]$ sudo mkdir mesos && sudo chown -R vagrant:vagrant
> mesos
>
How can a unprivileged Jenkins job do this?
981/#comment75674>
No check for error here?
src/master/registrar.cpp
<https://reviews.apache.org/r/20981/#comment75660>
How about handling error condition in all the RegistrarProcess methods? If
a method cannot be invoked when in error it should've a check.
- Vinod Kone
On
333e37ccd5746c5026740cfcb816499cea61a545
src/master/master.cpp f205dca43f10697862e3fd3f435f1127a9d0aecb
Diff: https://reviews.apache.org/r/20932/diff/
Testing
---
make check (there were some unrelated flaky/broken tests for which there are
already tickets filed)
Thanks,
Vinod Kone
tps://reviews.apache.org/r/20955/#comment75713>
Why doesn't this return a Try?
- Vinod Kone
On May 1, 2014, 5:10 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https
/exists.hpp
<https://reviews.apache.org/r/20970/#comment75717>
is it possible to get a EPERM with sig 0?
- Vinod Kone
On May 1, 2014, 7:17 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail.
tps://reviews.apache.org/r/20971/#comment75721>
do we need errno == ECHILD check here?
- Vinod Kone
On May 1, 2014, 7:18 p.m., Ian Downes wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
--gtest_filter="*RestartBeforeContainerizerLaunch*"
--verbose --gtest_repeat=100 --gtest_break_on_failure
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20981/#review42003
---
Ship it!
Ship It!
- Vinod Kone
On May 2, 2014, 1:09 a.m., Ben
+1
make check passes on OSX 10.9 w/ gcc-4.8
On Wed, Apr 30, 2014 at 11:18 PM, Niklas Nielsen wrote:
> Hi all,
>
> Please vote on releasing the following candidate as Apache Mesos 0.18.1.
>
>
> 0.18.1 includes the following:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21007/#review42044
---
ping?
- Vinod Kone
On May 2, 2014, 2:22 a.m., Vinod Kone wrote
> On May 2, 2014, 6:53 p.m., Vinod Kone wrote:
> > src/master/master.cpp, lines 1289-1290
> > <https://reviews.apache.org/r/21017/diff/1/?file=573738#file573738line1289>
> >
> > Update the log message. How about?
> >
> > LOG(
slave " << *slave
<< " because " << slave->info.checkpoint() ? "slave is not
checkpointing" : "framework is not checkpointing";
- Vinod Kone
On May 2, 2014, 6:20 p.m., Adam B wrote:
>
> --
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21019/#review42046
---
Ship it!
Ship It!
- Vinod Kone
On May 2, 2014, 6:56 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21021/#review42047
---
Ship it!
Ship It!
- Vinod Kone
On May 2, 2014, 7:08 p.m., Ben
779e856ef8c62819a45f3a942609baa75142
Diff: https://reviews.apache.org/r/20284/diff/
Testing
---
Used it post this review.
Thanks,
Vinod Kone
Let's just update post-reviews to use mesos-style to give feedback sooner.
@vinodkone
Sent from my mobile
> On May 5, 2014, at 8:17 AM, Tim St Clair wrote:
>
> Many many thanks!
> Hopefully this can streamline the reviews.
>
> - Original Message -
>> From: "Benjamin Hindman"
>> T
g/r/21086/#comment75906>
How about updating execute to return None when an exception is thrown and
ignore_errors=True?
then we can just call execute('post-review', '--version') and
execute('rbt', '--version')?
- Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21086/#review42171
---
Ship it!
Ship It!
- Vinod Kone
On May 5, 2014, 5:51 p.m
<https://reviews.apache.org/r/20955/#comment75989>
Why not return ErrnoError()?
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/20955/#comment75990>
ditto.
- Vinod Kone
On May 2, 2014, 10:02 p.m., Ian
/20818/#comment75999>
can you include the error?
src/linux/cgroups.cpp
<https://reviews.apache.org/r/20818/#comment76000>
How come we are not doing retires anymore?
- Vinod Kone
On May 5, 2014, 8:16 p.m., Ian Downes wrote:
>
> -
be in flight. is that intended?
include/mesos/mesos.proto
<https://reviews.apache.org/r/21052/#comment76003>
+1 doesn't seem to belong here.
also,
s/does currently not/currently does not/
- Vinod Kone
On May 3, 2014, 6:38 a.m.,
052/#comment76020>
Oops totally missed the move. I thought you were introducing it. Ah Review
Board.
- Vinod Kone
On May 3, 2014, 6:38 a.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail.
s. In the current code base I don't see an use case for it yet.
If/when the need arises, we can update the methods to take vectors of subjects
and objects.
Makes sense?
- Vinod
---
This is an automatically generated e-mail. T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21098/#review42250
---
Ship it!
Ship It!
- Vinod Kone
On May 6, 2014, 5:41 a.m
debugged with the help of benm.
https://issues.apache.org/jira/browse/MESOS-1310
On Sun, May 4, 2014 at 10:11 PM, Benjamin Hindman wrote:
> This is a rather peculiar issue ... has anybody else seen this crash
> before?
>
>
> On Sun, May 4, 2014 at 5:23 PM, Apache Jenkins Server <
> jenk...@bui
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21122/#review42326
---
Ship it!
Ship It!
- Vinod Kone
On May 6, 2014, 6:02 p.m., Ian
674/#comment76128>
Some one mentioned this on the MesosJenkins GitHub yesterday.
This check for executable no longer works because a new letter "[XN]" is
appended to the end of the URI.
This should be:
s/token.substr(pos + 1)/token.substr(pos + 1, 1)/
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21237/#review42609
---
Ship it!
Ship It!
- Vinod Kone
On May 8, 2014, 9:27 p.m., Jie
sting
---
make check
Thanks,
Vinod Kone
add a TODO for now.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18730/#review42577
---
On May
g/r/21176/#comment76250>
s/Re-start/Restart/
src/tests/master_tests.cpp
<https://reviews.apache.org/r/21176/#comment76251>
s/WillRepeatedly(Return())/Times(0)/ ?
- Vinod Kone
On May 7, 2014, 11:05 p.m., Ben
/registrar_zookeeper_tests.cpp
376ac1ed6d62f977f4aa3d55007f225e5a534ce1
Diff: https://reviews.apache.org/r/21175/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21180/#review42445
---
Ship it!
Ship It!
- Vinod Kone
On May 7, 2014, 11:05 p.m., Ben
hmm..you should be able to. are you logged in?
On Sun, May 11, 2014 at 11:09 AM, Steven Phung wrote:
> Hello,
>
> For some reason I don't have permission to assign tasks to myself. About
> two weeks ago when I first joined looking to contribute I did have
> permission, could someone help me wi
make check
Thanks,
Vinod Kone
g/r/21186/#comment76307>
s/Re-start/Restart/
- Vinod Kone
On May 8, 2014, 1:15 a.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
0a350b0b402edb3ca648c91c920043f66c08fe0e
src/master/master.cpp d851a7291acce950ea9391ddfb8813a432aeda34
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
---
make check
Thanks,
Vinod Kone
812ad2cea4349727e92d0aa04fc8ce9b6c637af7
src/tests/master_tests.cpp 30ea7ffad4eb0ad011942d91cbf61284b031a80e
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21175/diff/
Testing
---
make check
Thanks,
Vinod Kone
/
Testing
---
Thanks,
Vinod Kone
.
Bugs: MESOS-1234
https://issues.apache.org/jira/browse/MESOS-1234
Repository: mesos-git
Description
---
See summary.
Diffs
-
support/verify-reviews.py 1d6356887b36354069b763771ea86341bd60fb7b
Diff: https://reviews.apache.org/r/20617/diff/
Testing
---
Thanks,
Vinod
and reset it back to 'mtu' so
that the test doesn't have any side-effect? just a thought.
- Vinod Kone
On May 9, 2014, 9:49 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
tests?
Also, do *all* these tests need the capabilities checked in check()?
- Vinod Kone
On May 9, 2014, 10:27 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To
/linux/routing/filter/arp.cpp
<https://reviews.apache.org/r/20296/#comment76715>
new line.
- Vinod Kone
On April 28, 2014, 5:03 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
che.org/r/20297/#comment76724>
include the value of size in the message.
- Vinod Kone
On April 28, 2014, 5:04 p.m., Jie Yu wrote:
>
> ---
> This is an automatically genera
dominic, can you triage this?
@vinodkone
On Mon, May 12, 2014 at 6:18 PM, Apache Jenkins Server <
jenk...@builds.apache.org> wrote:
> See <
> https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2119/changes
> >
>
> Changes:
>
> [yujie.jay] Add a return statement to
g/r/20295/#comment76709>
Why not take action::Action and use the dynamic cast trick in an earlier
review?
src/linux/routing/filter/icmp.hpp
<https://reviews.apache.org/r/20295/#comment76710>
No update for Redirect action?
- Vinod Kone
On April 28, 2014, 5:02 p.m.,
360/#comment76735>
How about taking the list of file names to run the linter against as
command line args to mesos-style.py?. I think thats more flexible and lets
users feed it whatever files they want.
e.g., 'git diff --name-only | xargs ./support/mesos-style.py'
- Vinod
p
<https://reviews.apache.org/r/20781/#comment76688>
Can we print the old and new priorities here?
src/linux/routing/queueing/internal.hpp
<https://reviews.apache.org/r/20781/#comment76702>
s/queue/queueing/ ?
src/linux/routing/queueing/internal.hpp
<https://reviews.a
doesnt look this belongs to "mesos" group. s/mesos/aurora/ ?
On Tue, May 13, 2014 at 10:49 AM, Dominic Hamon wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21386/
> --
+1
On Tue, May 13, 2014 at 10:54 AM, Benjamin Hindman
wrote:
> +1!
>
>
> On Tue, May 13, 2014 at 9:51 AM, Niklas Nielsen wrote:
>
>> Hey everyone,
>>
>> First and foremost, I apologize for the radio silence on my part with
>> regards to the 0.18.1 release. We didn't announce it or make it publi
276/#comment76778>
There should be a CHECK_NOTNULL(task) here.
Alternatively, s/task->state()/state/ here and in the log statement in
default.
- Vinod Kone
On May 13, 2014, 6:02 p.m., Dominic Hamon wrote:
>
> -
s and tasks).
So, updating the terminal task counts with the latter but not the former
seems misleading.
Lets update the counters after we fix the slave to do the right thing.
- Vinod Kone
On May 13, 2014, 7:35 p.m., Dominic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21279/#review42890
---
Ship it!
Ship It!
- Vinod Kone
On May 13, 2014, 9:31 p.m
completeTask() gets called after all the pending updates for a task are
ACKed. i think it's better for these counters to reflect when a task
transitions to terminal state instead of when its updates are acked.
- Vinod Kone
On May 12, 2014, 8:53 p.
dd an
option (--force or something) that could override the default filtering rules
too if someone needs it.
- Vinod Kone
On May 13, 2014, 9:56 p.m., Steven Phung wrote:
>
> ---
> This is an automatically generate
g/r/21141/#comment76725>
Why not have remove() return a Future that gets satisfied when the link is
removed. Are there other cases where 'wait' will be used?
Also, if we do we need wait, I would recommend
s/wait/removed/ to be more explicit.
- Vinod Kone
On May 7,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21360/#review42947
---
Ship it!
Ship It!
- Vinod Kone
On May 14, 2014, 4:24 a.m
--
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21360/
> ---
>
> (Updated May 14, 2014, 4:24 a.m.)
>
>
> Review request for mesos and V
make check
Thanks,
Vinod Kone
Hamon.
Repository: mesos-git
Description
---
See summary.
Diffs
-
docs/mesos-developers-guide.md d195bded640dd4f55672b75ad1cc5f0ea4aa9fd7
support/hooks/pre-commit PRE-CREATION
Diff: https://reviews.apache.org/r/21439/diff/
Testing
---
Tested locally.
Thanks,
Vinod Kone
> On May 14, 2014, 6:07 a.m., Vinod Kone wrote:
> > Ship It!
Committed this with a minor fix. Thanks Steven.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21360/#re
f8ed65bf7b7e4f3c0834c9e22a525137856e9b23
src/tests/mesos.cpp 242d98ad195a8ab1256918c48a2956e2e085d26d
Diff: https://reviews.apache.org/r/21445/diff/
Testing
---
make check
Thanks,
Vinod Kone
.
e.g: s/unregister_slave_messages/messages_unregister_slave/
- Vinod Kone
On May 14, 2014, 5:40 p.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
s.get()).
src/slave/containerizer/isolators/cgroups/perf_event.cpp
<https://reviews.apache.org/r/20963/#comment76987>
can you print the cgroup name too?
- Vinod Kone
On May 1, 2014, 6:42 p.m., Ian Downes wrote:
>
> --
aster/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
---
make check
Thanks,
Vinod Kone
f461a1515e7bafac677f2d0bcdd499f57ba3f029
src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21175/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21141/#review43074
---
Ship it!
Ship It!
- Vinod Kone
On May 15, 2014, 12:47 a.m., Jie
: https://reviews.apache.org/r/21464/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21182/#review42515
---
Ship it!
Ship It!
- Vinod Kone
On May 8, 2014, 12:56 a.m
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21439/#review42994
---
On May 14, 2014, 5:43 p.m., Vinod Kone wrote:
>
> ---
&g
registration and not authentication (added a TODO).
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21464/#review43057
------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21190/#review42527
---
Ship it!
Ship It!
- Vinod Kone
On May 8, 2014, 1:32 a.m., Jie
5>
Can you be more specific? There is only one expectation, that of not
receiving a status update, correct?
- Vinod Kone
On May 9, 2014, 12:06 a.m., Dominic Hamon wrote:
>
> ---
> This is an automatically generated e-mail.
and see if
it works as expected?
- Vinod Kone
On May 11, 2014, 7:07 p.m., Steven Phung wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
://reviews.apache.org/r/21464/#review43041
---
On May 14, 2014, 11:06 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21457/#review43032
---
Ship it!
Ship It!
- Vinod Kone
On May 14, 2014, 9:23 p.m., Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21269/#review43073
---
Ship it!
Ship It!
- Vinod Kone
On May 15, 2014, 12:43 a.m., Jie
d.
- Vinod
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21464/#review43067
---
On May 14, 2014, 11:06 p.m., Vinod Kone wrote:
>
> --
s.cpp 85c57b29f6a56683e0df9788dea64ebb36e00812
src/tests/slave_tests.cpp 29dc7d434646998b04481e9ae6fe8589d7fed8e7
Diff: https://reviews.apache.org/r/21464/diff/
Testing
---
make check
Thanks,
Vinod Kone
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21462/#review43028
---
Ship it!
Ship It!
- Vinod Kone
On May 14, 2014, 9:31 p.m., Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20295/#review43017
---
Ship it!
Ship It!
- Vinod Kone
On April 28, 2014, 5:02 p.m
87ea77aa19e482a20f081061e81acc89582eacdd
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21236/diff/
Testing
---
make check
Thanks,
Vinod Kone
901 - 1000 of 3936 matches
Mail list logo
