Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-18 Thread Mathias Bauer
On 14.06.2010 23:32, Andrew Douglas Pitonyak wrote: On 06/14/2010 07:05 AM, Bartosz wrote: I thought I had a patch somewhere to do some of the conversion, but I can't find it now. I remember that I didn't go ahead with it at the time because my first cut at it left OOo larger than it was before

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-17 Thread Stephan Bergmann
On 06/17/10 15:46, Bartosz wrote: 2010/6/16 Eike Rathke wrote: Hi Bartosz, On Tuesday, 2010-06-15 09:06:19 +0200, Bartosz wrote: After replace svArrays by STL containers, in some cases I observed boost of performance. For example: for (USHORT i = 0; i < aEntries.size(); ++i) Please

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-17 Thread Bartosz
2010/6/16 Eike Rathke wrote: > Hi Bartosz, > > On Tuesday, 2010-06-15 09:06:19 +0200, Bartosz wrote: > >> After replace svArrays by STL containers, in some cases I observed boost of >> performance. >> >> For example: >> for (USHORT i = 0; i < aEntries.size(); ++i) > > Please ensure to adapt

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-16 Thread Bartosz
Great success! I have successfully removed the SvArray of objects macro (SV_DECL_OBJARR and SV_IMPL_OBJARR macros). Please feel free to check and test it. Patch is available at (replace_svarray3.patch): http://www.openoffice.org/issues/show_bug.cgi?id=112395 2010/6/15 Bjoern Michaelsen: >> Cha

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-16 Thread Eike Rathke
Hi Bartosz, On Tuesday, 2010-06-15 09:06:19 +0200, Bartosz wrote: > After replace svArrays by STL containers, in some cases I observed boost of > performance. > > For example: > for (USHORT i = 0; i < aEntries.size(); ++i) Please ensure to adapt also all types where necessary, in this c

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-15 Thread Andrew Douglas Pitonyak
On 06/15/2010 02:55 AM, Mathias Bauer wrote: On 14.06.2010 12:01, Caolán McNamara wrote: A code replacement like this creates the question what shall be the goal: - reduce memory footprint - improve performance - remove code duplication - improve code quality My primary interest is in code

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-15 Thread Jan Holst Jensen
On 2010-06-15 10:44, Bjoern Michaelsen wrote: Am Tue, 15 Jun 2010 09:18:45 +0200 schrieb Jan Holst Jensen: On 2010-06-15 09:06, Bartosz wrote: By the way. After replace svArrays by STL containers, in some cases I observed boost of performance. For example: for (USHORT i = 0;

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-15 Thread Mathias Bauer
On 14.06.2010 12:01, Caolán McNamara wrote: On Mon, 2010-06-14 at 11:22 +0200, Michael Stahl wrote: the SvArrays should be replaced by appropriate STL types (mostly vector, i guess, but probably in some cases stacks or deques or something else). deques I think was the best option in general th

[dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-15 Thread Bjoern Michaelsen
Am Tue, 15 Jun 2010 09:18:45 +0200 schrieb Jan Holst Jensen : > On 2010-06-15 09:06, Bartosz wrote: > > By the way. > > After replace svArrays by STL containers, in some cases I observed > > boost of performance. > > > > For example: > > for (USHORT i = 0; i< aEntries.size(); ++i) > >

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-15 Thread Ruediger Timm
On 06/15/10 09:06, Bartosz wrote: Getting rid of SvArray might not be enough alone to fix this, but it would be a big step in the right direction. Please also have a look at the work in cws new_itemsets which tries to get rid of the old SfxItemSet implementation and replace it with stl container-

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-15 Thread Jan Holst Jensen
On 2010-06-15 09:06, Bartosz wrote: By the way. After replace svArrays by STL containers, in some cases I observed boost of performance. For example: for (USHORT i = 0; i< aEntries.size(); ++i) { if (aEntries.at(i).aFntFmt == rFntFmt) { aRes = aEnt

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-15 Thread Bartosz
> Getting rid of SvArray might not be enough alone to fix this, but it > would be a big step in the right direction. Please also have a look at > the work in cws new_itemsets which tries to get rid of the old > SfxItemSet implementation and replace it with stl container-based stuff > whereever poss

[dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Bjoern Michaelsen
Am Mon, 14 Jun 2010 17:32:27 -0400 schrieb Andrew Douglas Pitonyak : > Changing out SvArray, will fix this long standing bug, which will > bring great joy and happiness to my life. > > http://www.openoffice.org/issues/show_bug.cgi?id=84159 Getting rid of SvArray might not be enough alone to fix

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Andrew Douglas Pitonyak
On 06/14/2010 07:05 AM, Bartosz wrote: I thought I had a patch somewhere to do some of the conversion, but I can't find it now. I remember that I didn't go ahead with it at the time because my first cut at it left OOo larger than it was before hand, which was an annoying result. Great. If

[dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Michael Stahl
On 14/06/2010 13:05, Bartosz wrote: >> I thought I had a patch somewhere to do some of the conversion, but I >> can't find it now. I remember that I didn't go ahead with it at the time >> because my first cut at it left OOo larger than it was before hand, >> which was an annoying result. > > Great

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Bartosz
> I thought I had a patch somewhere to do some of the conversion, but I > can't find it now. I remember that I didn't go ahead with it at the time > because my first cut at it left OOo larger than it was before hand, > which was an annoying result. Great. If you could find this patch, it will be v

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Caolán McNamara
On Mon, 2010-06-14 at 11:22 +0200, Michael Stahl wrote: > the SvArrays should be replaced by appropriate STL types (mostly vector, i > guess, but probably in some cases stacks or deques or something else). deques I think was the best option in general the last time I looked at this. Probably best

[dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Michael Stahl
On 13/06/2010 22:36, Bartosz Kosiorek wrote: > Hi. hi Bartosz, > In the > http://wiki.services.openoffice.org/wiki/To-Dos#Replace_code_with_3rd_party > there is section about "Replace self made containers with STL containers. > SvPointerArray, BigPointerArray" > But in higher section there is