Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://loca

2013-06-04 Thread Mengwei Ding
. Description --- commit b15c944cc52937d5c51c7f921ab685db7fb59a2b Author: Mengwei Ding Date: Tue Jun 4 15:10:03 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For exam

Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://loca

2013-06-04 Thread Mengwei Ding
. Description --- commit 67ccd56d492ac4910c28376f7be0bcaad4e5cbdb Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For exam

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-04 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Description --- commit 67ccd56d492ac4910c28376f7be0bcaad4e5cbdb Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistan

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-04 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Description (updated) --- commit 67ccd56d492ac4910c28376f7be0bcaad4e5cbdb Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more cons

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-04 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Description (updated) --- commit 6d2a4bb0331210cda99d571579705084b12fb357 Author: Mengwei Ding Date: Thu May 30 16:30:53 2013 -0700 SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop :100644 100644 979b892.

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-04 Thread Mengwei Ding
default and notify the user by one line output. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11561/#review21449 ------- On June 4, 2013, 11:46 p.m., Mengwei Ding wrote: > > ---

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
----- On June 4, 2013, 11:46 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11561/ > ---

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
a default value, why not simply return? That way, the > > default value will not be hard coded in multiple files. > > Mengwei Ding wrote: > Yeah, this is a good one. I had another thought about this issue, Abe. The reason why I did not directly return is that for any new va

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-05 Thread Mengwei Ding
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11535/#review21450 ------- On June 4, 2013, 11:22 p.m., Mengwei Ding wrote: > > -

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
ted) --- commit d7787293082b398511b7d331fdd12c7ca682dc03 Author: Mengwei Ding Date: Thu May 30 16:30:53 2013 -0700 SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop :100644 100644 979b892... 866f3b8... M client/src/main/java/org/apache/sqoop/client/core/Constan

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Changes --- Add a more specific description for "poll-timeout" option. Description (updated) --- commit d7787293082b398511b7d331fdd12c7ca682dc03 Author: Mengwei Ding Date: Thu May 30 16:30:53 2013 -0700 SQOOP-1028: remove po

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-05 Thread Mengwei Ding
plications. For example, 'set server --url http://localhost:12000/sqoop' Description (updated) --- commit 31a39620c4f102f0eb23958a571d220ee5aa721d Author: Mengwei Ding Date: Wed May 29 18:04:53 2013 -0700 SQOOP-973 add --url option for 'set server', which enab

Re: Review Request: SQOOP-973 add --url option for 'set server', which enables specifying host, port and webapp in a more consistant way with other applications. For example, 'set server --url http://

2013-06-05 Thread Mengwei Ding
-mail. To reply, visit: https://reviews.apache.org/r/11535/#review21496 --- On June 5, 2013, 6:01 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: SQOOP-1028: remove poll-timeout parameter and add 'poll-timeout' option for sqoop

2013-06-05 Thread Mengwei Ding
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11561/#review21495 --- On June 5, 2013, 5:27 p.m., Mengwei Ding wrote: > >

Review Request: correct an error message from FrameworkValidator

2013-06-06 Thread Mengwei Ding
--- commit 511f5c15595f9292056bec1718087a166abd637e Author: Mengwei Ding Date: Thu Jun 6 16:05:30 2013 -0700 correct an error message from FrameworkValidator :100644 100644 a42363d... d72b9f8... M core/src/main/java/org/apache/sqoop/framework/FrameworkValidator.java This addresses bug

Review Request: SQOOP-1081 implement destroy() function for ConnectorManager in sqoop-core

2013-06-13 Thread Mengwei Ding
. Description --- commit fe17874e419a328ad16d21b541d9c919c91d9e95 Author: Mengwei Ding Date: Thu Jun 13 17:37:03 2013 -0700 SQOOP-1081 implement destroy() function for ConnectorManager in sqoop-core :100644 100644 27ec754... 500189a... M core/src/main/java/org/apache/sqoop/connector

Re: Review Request: SQOOP-1006 Update year in the notice file to 2013

2013-06-13 Thread Mengwei Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10692/#review21892 --- Ship it! Ship It! - Mengwei Ding On April 21, 2013, 8:38 p.m

Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-17 Thread Mengwei Ding
. Description --- commit 719aeaab2cd74338399f43c411f7dccd95089c7b Author: Mengwei Ding Date: Wed Jun 12 15:47:26 2013 -0700 SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager :100644 100644 500189a... 5ea1ab3... M core/src/main

Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-18 Thread Mengwei Ding
. Description --- commit 6367bd9781040a77a355a2728c0e365338eb497e Author: Mengwei Ding Date: Tue Jun 18 15:43:25 2013 -0700 SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`) :100644 100644 9c7b351... 0c5a596... M client/src/main/java/org/apache

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-18 Thread Mengwei Ding
-- > > (Updated June 17, 2013, 10:33 p.m.) > > > Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek. > > > Description > --- > > commit 719aeaab2cd74338399f43c411f7dccd95089c7b > Author: Mengwei Ding &g

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-18 Thread Mengwei Ding
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/11920/#review22027 ------- On June 17, 2013, 10:33 p.m., Mengwei Ding wrote: > > --- > This is an automatically genera

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-18 Thread Mengwei Ding
, Hari Shreedharan, and Abraham Elmahrek. Changes --- Made improvements according to Jarcec's comments. Thank you, Jarcec. Description (updated) --- commit 934b7a7a860fdfffabe2f06ca89530fe2d083d7f Author: Mengwei Ding Date: Wed Jun 12 15:47:26 2013 -0700 SQOOP-971 Add dy

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-18 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Changes --- Sorry, just remove several useless imports. Description (updated) --- commit 7fc5ae741cbe74e3f9aa50138dadfc3fdb594cbd Author: Mengwei Ding Date: Wed Jun 12 15:47:26 2013 -0700 SQOOP-971 Add dynamic reconfiguration ability to

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-19 Thread Mengwei Ding
tion (updated) --- commit 445bb5ec9c96f363f1c586d9ff534726c049a1cc Author: Mengwei Ding Date: Tue Jun 18 15:43:25 2013 -0700 SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`) :100644 100644 9c7b351... 4ca71a4... M client/src/main/java/org/apache/sqoop/client/SqoopClie

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-19 Thread Mengwei Ding
t;--jid" option for `show submission` command Description (updated) --- commit 2800218fb1e6336b635e6ae85071f344d4a8a3dd Author: Mengwei Ding Date: Tue Jun 18 15:43:25 2013 -0700 SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`) :100644 100644 9c7b35

Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-19 Thread Mengwei Ding
. Description --- commit a8f82e64b4787ae48aa5b1b1beeb10214cc1e175 Author: Mengwei Ding Date: Wed Jun 19 17:56:57 2013 -0700 SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds. :100644 100644 056fcc8... 1020209... M clie

Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-20 Thread Mengwei Ding
ility class? Yes, I do think so! Thank you, Abe. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11983/#review22190 --- On June

Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-21 Thread Mengwei Ding
Shreedharan, and Abraham Elmahrek. Changes --- Move parseOptions() and getLong() static methods to a new created util class "OptionParser". Description (updated) --- commit 5cc954a0e8594a1ddd667d06cc438100b44fe234 Author: Mengwei Ding Date: Wed Jun 19 17:56:57

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-21 Thread Mengwei Ding
t's ok to apply the new configuration changes to the repository at this time. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11920/#review22137 --------

Re: Review Request: SQOOP-971 Add dynamic reconfiguration ability to RepositoryManager, ConnectorManager and FrameworkManager

2013-06-21 Thread Mengwei Ding
ea52e9 server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 1c40fc1 Diff: https://reviews.apache.org/r/11920/diff/ Testing --- Thanks, Mengwei Ding

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-21 Thread Mengwei Ding
sit: https://reviews.apache.org/r/11952/#review22263 --- On June 19, 2013, 6:59 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-21 Thread Mengwei Ding
t; > "--details"?) yes, that's exactly what I mean. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11952/#review22263 ------- On June 19, 2013, 6:59 p.m., Mengwei Ding wr

Re: Review Request: SQOOP-1088 Submission History API - Add both APIs and shell command (`show submission`)

2013-06-21 Thread Mengwei Ding
, Hari Shreedharan, and Abraham Elmahrek. Changes --- add more unit test cases for TestSubmissionBean. Description (updated) --- commit 7e11dd64165daae5297c843055041edb2803f5da Author: Mengwei Ding Date: Tue Jun 18 15:43:25 2013 -0700 SQOOP-1088 Submission History API - Add both

Re: Review Request: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-21 Thread Mengwei Ding
r the future. Cool. I wat thinking about this too. And your suggestions make thing easier. :) - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11983/#review22281 --- On June 21, 2013,

Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-26 Thread Mengwei Ding
/client/shell/SubmissionStopFunction.java c407d01 client/src/main/resources/client-resource.properties 8a570a1 docs/src/site/sphinx/CommandLineClient.rst a14898f Diff: https://reviews.apache.org/r/11983/diff/ Testing --- Done several manual test for all these 3 commands and their options. Thanks, Mengwei Ding

Review Request 12113: SQOOP-1100 SQOOP2: Add missing setBoolean() method for MutableContext

2013-06-26 Thread Mengwei Ding
. Bugs: SQOOP-1100 https://issues.apache.org/jira/browse/SQOOP-1100 Repository: sqoop-sqoop2 Description --- commit 85198e81fafabd03bbbdbd93b517a808c00bfda0 Author: Mengwei Ding Date: Tue Jun 25 13:27:07 2013 -0700 SQOOP-1100 SQOOP2: Add missing setBoolean() method for

Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-06-28 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- improved the documentation. Bugs: SQOOP-675 https://issues.apache.org/jira/browse/SQOOP-675 Repository: sqoop-sqoop2 Description (updated) --- commit 96d06c080a2b13e30c3a074770cbbaec9d9453d7 Author: Mengwei Ding Date: Wed Jun

Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-07-01 Thread Mengwei Ding
I update this code review. Now, fixed. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11983/#review22541 ------

Re: Review Request 12092: SQOOP-1073 Sqoop2: Introduce schema for transferred data

2013-07-01 Thread Mengwei Ding
tps://reviews.apache.org/r/12092/#comment46307> Hi, Jarce, I find a tiny error here. I think the StringUtils in the org.apache.commons.utils package rather than the lang package. - Mengwei Ding On June 29, 2013, 9:11 p.m., Jarek Cecho

Re: Review Request 12092: SQOOP-1073 Sqoop2: Introduce schema for transferred data

2013-07-01 Thread Mengwei Ding
> On July 1, 2013, 4:36 p.m., Mengwei Ding wrote: > > common/src/main/java/org/apache/sqoop/schema/Schema.java, line 20 > > <https://reviews.apache.org/r/12092/diff/2/?file=313292#file313292line20> > > > > Hi, Jarce, I find a tiny error her

Re: Review Request 11983: SQOOP-675 replace 'submission' cmd with 'start', 'stop' and 'status' cmds.

2013-07-01 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- Remove unused imports. Bugs: SQOOP-675 https://issues.apache.org/jira/browse/SQOOP-675 Repository: sqoop-sqoop2 Description (updated) --- commit 93eeb1225d6be0d95783ce6da5b8fd6e3d9fe986 Author: Mengwei Ding Date: Wed Jun 19 17

Review Request 12218: SQOOP-997 provide ability to disable the automatic upgrade for connectors and framework.

2013-07-01 Thread Mengwei Ding
. Bugs: SQOOP-997 https://issues.apache.org/jira/browse/SQOOP-997 Repository: sqoop-sqoop2 Description --- commit f6b3bb1a61c2e9cd3736c5a05882ace390705536 Author: Mengwei Ding Date: Mon Jul 1 17:19:27 2013 -0700 SQOOP-997 provide ability to disable the automatic upgrade for

Re: Review Request 12218: SQOOP-997 provide ability to disable the automatic upgrade for connectors and framework.

2013-07-02 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Bugs: SQOOP-997 https://issues.apache.org/jira/browse/SQOOP-997 Repository: sqoop-sqoop2 Description (updated) --- commit bfd2a7d35c83cdbf3e21c64ea77fcec41b258b9a Author: Mengwei Ding Date: Mon Jul 1 17:19:27 2013 -0700 SQOOP-997 provide

Review Request 12248: SQOOP-994 Sqoop2: upgrade: add calling validation to the upgrade method.

2013-07-03 Thread Mengwei Ding
. Bugs: SQOOP-994 https://issues.apache.org/jira/browse/SQOOP-994 Repository: sqoop-sqoop2 Description --- commit 5772ec00d04595174ad2018dbb3f6af74fd82cba Author: Mengwei Ding Date: Tue Jul 2 18:48:29 2013 -0700 SQOOP-994 Sqoop2: upgrade: add calling validation to the upgrade

Review Request 12260: SQOOP-1123 Sqoop2: Add eclipse project metadata folder excluded from maven

2013-07-03 Thread Mengwei Ding
://issues.apache.org/jira/browse/SQOOP-1123 Repository: sqoop-sqoop2 Description --- commit fce7666a41f56bfa6c6fb5aad0c6c58cafc57152 Author: Mengwei Ding Date: Wed Jul 3 13:45:31 2013 -0700 SQOOP-1123 Sqoop2: Add eclipse project metadata folder excluded from maven :100644 100644 8785e01

Review Request 12344: Sqoop2: SqoopException being nested into another SqoopException in Repository

2013-07-08 Thread Mengwei Ding
. Bugs: SQOOP-1128 https://issues.apache.org/jira/browse/SQOOP-1128 Repository: sqoop-sqoop2 Description --- commit 01fe8a30cfe6d8f9f87162c6bf8cf4591271653e Author: Mengwei Ding Date: Mon Jul 8 16:48:50 2013 -0700 Sqoop2: SqoopException being nested into another SqoopException in

Review Request 12370: SQOOP-996: Sqoop2: create upgrade tests

2013-07-09 Thread Mengwei Ding
://issues.apache.org/jira/browse/SQOOP-996 Repository: sqoop-sqoop2 Description --- commit b3602f1d6190926eeffa2fa10e81efdd6611092b Author: Mengwei Ding Date: Wed Jul 3 15:56:49 2013 -0700 SQOOP-996: Sqoop2: create upgrade tests :100644 100644 0732b2c... 2b6e436... M core/pom.xml :00

Review Request 12449: SQOOP-1130: Sqoop2: Sqoop MapReduce Job Failed when max and min boundary are both null

2013-07-10 Thread Mengwei Ding
://issues.apache.org/jira/browse/SQOOP-1130 Repository: sqoop-sqoop2 Description --- commit e5488360666077b527282e517369fd8f5cdf5341 Author: Mengwei Ding Date: Wed Jul 10 11:47:07 2013 -0700 SQOOP-1130: Sqoop2: Sqoop MapReduce Job Failed when max and min boundary are both null :100644

Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-10 Thread Mengwei Ding
://issues.apache.org/jira/browse/SQOOP-1049 Repository: sqoop-sqoop2 Description --- commit 47e73c30b49be0168459d76bf8993205c7a4f4fc Author: Mengwei Ding Date: Wed Jul 10 11:41:05 2013 -0700 SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL :100644 100644 abcc89d

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-11 Thread Mengwei Ding
, this is an issue. I will use 'count(1)' instead. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12451/#review23028 ---------

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-11 Thread Mengwei Ding
t; > > I'm concerned a bit of using count() aggregate function as it might > > lead to another full table scan which might significantly hurt performance. > > Maybe we could make the ability for checking nulls in the split by column > > optional? > >

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-12 Thread Mengwei Ding
t; > > I'm concerned a bit of using count() aggregate function as it might > > lead to another full table scan which might significantly hurt performance. > > Maybe we could make the ability for checking nulls in the split by column > > optional? > >

Review Request 12522: SQOOP-1136: Sqoop2: MBooleanInput should copy persistenceId when do clone()

2013-07-12 Thread Mengwei Ding
://issues.apache.org/jira/browse/SQOOP-1136 Repository: sqoop-sqoop2 Description --- commit aed85ad9b7b6593313b8ec77eac475c9e2401fb9 Author: Mengwei Ding Date: Fri Jul 12 14:55:23 2013 -0700 SQOOP-1136: Sqoop2: MBooleanInput should copy persistenceId when do clone() :100644 100644 68142da

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-12 Thread Mengwei Ding
-resources.properties 44fc984 Diff: https://reviews.apache.org/r/12451/diff/ Testing --- Have done a manual test, in which I successfully import a table with some null values in partition column. Thanks, Mengwei Ding

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-12 Thread Mengwei Ding
. Changes --- Add test case. Bugs: SQOOP-1049 https://issues.apache.org/jira/browse/SQOOP-1049 Repository: sqoop-sqoop2 Description (updated) --- commit 40709543f87c4a6f8fc6e8d7ad124cb4e917185d Author: Mengwei Ding Date: Wed Jul 10 11:41:05 2013 -0700 SQOOP-1049: Sqoop2

Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

2013-07-16 Thread Mengwei Ding
. Bugs: SQOOP-1141 https://issues.apache.org/jira/browse/SQOOP-1141 Repository: sqoop-sqoop2 Description --- commit 65c0b55f6630c8dfec06b5fb150e5dcc07153e33 Author: Mengwei Ding Date: Tue Jul 16 10:41:12 2013 -0700 SQOOP-1141 Sqoop2: Provide ability to enable/disable connections

Re: Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

2013-07-17 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- Updated unit test cases. Bugs: SQOOP-1141 https://issues.apache.org/jira/browse/SQOOP-1141 Repository: sqoop-sqoop2 Description (updated) --- commit 86e2e605b433a9ac62921aaffcd2a92171133cef Author: Mengwei Ding Date: Tue Jul 16

Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-17 Thread Mengwei Ding
. Bugs: SQOOP-1142 https://issues.apache.org/jira/browse/SQOOP-1142 Repository: sqoop-sqoop2 Description --- commit 9d406f5b76eb3ef717793fd97ba410b33885893d Author: Mengwei Ding Date: Wed Jul 17 10:48:05 2013 -0700 SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-18 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- Update the way to get username. Bugs: SQOOP-1142 https://issues.apache.org/jira/browse/SQOOP-1142 Repository: sqoop-sqoop2 Description (updated) --- commit d1cca7f5283847096dec27134edf56804f07e96d Author: Mengwei Ding Date: Wed

Re: Review Request 12370: SQOOP-996: Sqoop2: create upgrade tests

2013-07-18 Thread Mengwei Ding
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12370/#review23316 --- On July 9, 2013, 8:22 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 12370: SQOOP-996: Sqoop2: create upgrade tests

2013-07-18 Thread Mengwei Ding
connector upgrade procedure" Thank you for pointing this out. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12370/#review23316 -----

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-18 Thread Mengwei Ding
tps://reviews.apache.org/r/12451/#review2 ------- On July 12, 2013, 11:12 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-18 Thread Mengwei Ding
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/12451/#review2 ------- On July 12, 2013, 11:12 p.m., Mengwei Ding wrote: > > --- > This is an au

Re: Review Request 12370: SQOOP-996: Sqoop2: create upgrade tests

2013-07-18 Thread Mengwei Ding
ed, I make the first function call inside them throw an exception. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12370/#review23316 ------

Re: Review Request 12370: SQOOP-996: Sqoop2: create upgrade tests

2013-07-18 Thread Mengwei Ding
erated e-mail. To reply, visit: https://reviews.apache.org/r/12370/#review23316 ------- On July 9, 2013, 8:22 p.m., Mengwei Ding wrote: > > --- > This is an automatica

Re: Review Request 12370: SQOOP-996: Sqoop2: create upgrade tests

2013-07-18 Thread Mengwei Ding
. Bugs: SQOOP-996 https://issues.apache.org/jira/browse/SQOOP-996 Repository: sqoop-sqoop2 Description (updated) --- commit cef19e8b3f6755f0c25e5b6cb2051a05aba6eef3 Author: Mengwei Ding Date: Wed Jul 3 15:56:49 2013 -0700 SQOOP-996: Sqoop2: create upgrade tests :100644 100644

Re: Review Request 12451: SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

2013-07-18 Thread Mengwei Ding
: Mengwei Ding Date: Wed Jul 10 11:41:05 2013 -0700 SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL :100644 100644 f3dee8e... 27db8af... M common/src/main/java/org/apache/sqoop/model/FormUtils.java :100644 100644 7792c57... 8d0c4ab... M connector/connector

Re: Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

2013-07-18 Thread Mengwei Ding
: Mengwei Ding Date: Tue Jul 16 10:41:12 2013 -0700 SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs :100644 100644 4ca71a4... 158e46c... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java :100644 100644 b7b0436... 999790d... M client/src/main/java/org

Re: Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

2013-07-18 Thread Mengwei Ding
) --- commit ba552918976799d7b7877dc31371274c6a4ba733 Author: Mengwei Ding Date: Tue Jul 16 10:41:12 2013 -0700 SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs :100644 100644 4ca71a4... 158e46c... M client/src/main/java/org/apache/sqoop/client/SqoopClient.java :100644

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-22 Thread Mengwei Ding
reviews.apache.org/r/12713/#review23595 --- On July 18, 2013, 5:09 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-22 Thread Mengwei Ding
reviews.apache.org/r/12713/#review23595 --- On July 18, 2013, 5:09 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12713/ >

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-22 Thread Mengwei Ding
engwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12713/#review23595 ------- On July 18, 2013, 5:09 p.m., Mengwei Ding wrote: > > -

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-22 Thread Mengwei Ding
--------- On July 18, 2013, 5:09 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12713/ > -

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-22 Thread Mengwei Ding
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12713/#review23595 ------- On July 18, 2013, 5:09 p.m., Mengwei Ding wrote: > > -

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-23 Thread Mengwei Ding
for creater and updater, and make them compatible for derby repo upgrading. Bugs: SQOOP-1142 https://issues.apache.org/jira/browse/SQOOP-1142 Repository: sqoop-sqoop2 Description (updated) --- commit a7d25c9311dd9b48cfff55ed808716a43439b816 Author: Mengwei Ding Date: Wed Jul 17 10

Re: Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

2013-07-24 Thread Mengwei Ding
ut this problem as I did for SQOOP-1142 - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12593/#review23727 ------- On July 18, 2013, 11:58 p.m., Mengwei Ding wrote: > >

Re: Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

2013-07-24 Thread Mengwei Ding
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12593/#review23727 ------- On July 18, 2013, 11:58 p.m., Mengwei Ding wrote: > > -

Re: Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

2013-07-24 Thread Mengwei Ding
gt; What do you think? Thank you for providing so many options, Jarcec. I am going to take the last one. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12593/#review23727 --

Re: Review Request 12593: SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

2013-07-24 Thread Mengwei Ding
(updated) --- commit a3c6f9d77694936a30f4cbef97ede6954aba4004 Author: Mengwei Ding Date: Tue Jul 16 10:41:12 2013 -0700 SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs :100644 100644 4ca71a4... 158e46c... M client/src/main/java/org/apache/sqoop/client

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-07-24 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- update several naming inconsistencies. Bugs: SQOOP-1142 https://issues.apache.org/jira/browse/SQOOP-1142 Repository: sqoop-sqoop2 Description (updated) --- commit ec9fff7a8f45632e25f0138eb1991007a5967b06 Author: Mengwei Ding Date

Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures

2013-07-24 Thread Mengwei Ding
. Bugs: SQOOP-1143 https://issues.apache.org/jira/browse/SQOOP-1143 Repository: sqoop-sqoop2 Description --- commit 79fef1510f3a309b582a9f31045237b837703d27 Author: Mengwei Ding Date: Tue Jul 23 16:51:53 2013 -0700 SQOOP-1143 Sqoop2: Provide server audit log for operations upon

Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures

2013-07-29 Thread Mengwei Ding
----- On July 24, 2013, 11:17 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12932/ > -

Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures

2013-07-29 Thread Mengwei Ding
necessary. Yeah, make sense. Thank you, Jarcec. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12932/#review24061 ---------

Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures

2013-07-29 Thread Mengwei Ding
30ddb Author: Mengwei Ding Date: Tue Jul 23 16:51:53 2013 -0700 SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures :00 100644 000... 881532d... A core/src/main/java/org/apache/sqoop/audit/AuditLogger.java :00 100644 000... 9e27d7c... A cor

Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures

2013-08-02 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- made changes based on review comments. Bugs: SQOOP-1143 https://issues.apache.org/jira/browse/SQOOP-1143 Repository: sqoop-sqoop2 Description (updated) --- commit e1043afccdafc866b376df812f3a6fd7976f777a Author: Mengwei Ding Date

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-08-02 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- made changes based on review comments. Bugs: SQOOP-1142 https://issues.apache.org/jira/browse/SQOOP-1142 Repository: sqoop-sqoop2 Description (updated) --- commit b524404b665b296462365e6823f24347f40f1462 Author: Mengwei Ding Date

Re: Review Request 12932: SQOOP-1143 Sqoop2: Provide server audit log for operations upon metadata structures

2013-08-02 Thread Mengwei Ding
--------- On Aug. 2, 2013, 9:34 p.m., Mengwei Ding wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12932/ > -

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-08-02 Thread Mengwei Ding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12713/#review24060 --- On Aug. 2, 2013, 9:36 p.m., Mengwei Ding wrote: >

Review Request 13273: SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used

2013-08-05 Thread Mengwei Ding
. Bugs: SQOOP-1162 https://issues.apache.org/jira/browse/SQOOP-1162 Repository: sqoop-sqoop2 Description --- commit 64ebb185e42578ec0138639780e4953e22d4cff9 Author: Mengwei Ding Date: Mon Aug 5 10:47:29 2013 -0700 SQOOP-1162: Sqoop2: 'show option' should have help ent

Review Request 13338: SQOOP-921: Sqoop2: Create standalone shell package

2013-08-06 Thread Mengwei Ding
. Bugs: SQOOP-921 https://issues.apache.org/jira/browse/SQOOP-921 Repository: sqoop-sqoop2 Description --- commit 0ba78c6da15ad3a67bdec754025066abc4792eea Author: Mengwei Ding Date: Tue Aug 6 11:24:08 2013 -0700 SQOOP-921: Sqoop2: Create standalone shell package :100644 100644

Review Request 13385: SQOOP-827 Sqoop2: MMapInput is null while retrieving from DB if pass empty map on write

2013-08-07 Thread Mengwei Ding
. Bugs: SQOOP-827 https://issues.apache.org/jira/browse/SQOOP-827 Repository: sqoop-sqoop2 Description --- Update MMapInput for this issue. Also update all related test cases. Use MMapInput in updateConnection() now. commit 3a08e4f9be43b3eedcd1e939423eaef39a46944f Author: Mengwei Ding

Re: Review Request 13338: SQOOP-921: Sqoop2: Create standalone shell package

2013-08-07 Thread Mengwei Ding
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13338/#review24760 --- On Aug. 6, 2013, 8 p.m., Mengwei Ding wrote: > > --- >

Review Request 13452: SQOOP-923 Sqoop2: Create developer guide

2013-08-09 Thread Mengwei Ding
. Bugs: SQOOP-923 https://issues.apache.org/jira/browse/SQOOP-923 Repository: sqoop-sqoop2 Description --- commit c9134f9a7c448b606e0b7392c45e634dbfc53260 Author: Mengwei Ding Date: Tue Aug 6 14:34:40 2013 -0700 SQOOP-923 Sqoop2: Create developer guide :00 100644 000

Re: Review Request 13452: SQOOP-923 Sqoop2: Create developer guide

2013-08-09 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Bugs: SQOOP-924 https://issues.apache.org/jira/browse/SQOOP-924 Repository: sqoop-sqoop2 Description --- commit c9134f9a7c448b606e0b7392c45e634dbfc53260 Author: Mengwei Ding Date: Tue Aug 6 14:34:40 2013 -0700 SQOOP-923 Sqoop2: Create

Re: Review Request 13452: SQOOP-924 Sqoop2: Devguide: Describe wire protocol

2013-08-09 Thread Mengwei Ding
) --- commit 1b533c60a4c4f0da12b9140fdb0838ba24c00045 Author: Mengwei Ding Date: Tue Aug 6 14:34:40 2013 -0700 SQOOP-924 Sqoop2: Devguide: Describe wire protocol :00 100644 000... 1022795... A docs/src/site/sphinx/NetworkAPI.rst :100644 100644 15ddfbb... 1d83db5... M docs/src/site

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-08-14 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- Revised based on comments. Bugs: SQOOP-1142 https://issues.apache.org/jira/browse/SQOOP-1142 Repository: sqoop-sqoop2 Description (updated) --- commit 492db1577c4aa91290346557f2d952acd8fce986 Author: Mengwei Ding Date: Wed Jul

Re: Review Request 12713: SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures

2013-08-14 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- incorporate comments. Bugs: SQOOP-1142 https://issues.apache.org/jira/browse/SQOOP-1142 Repository: sqoop-sqoop2 Description (updated) --- commit a0121f728cbdc02bc3cba3dde462f817c4694f9f Author: Mengwei Ding Date: Wed Jul 17 10

Re: Review Request 13385: SQOOP-827 Sqoop2: MMapInput is null while retrieving from DB if pass empty map on write

2013-08-15 Thread Mengwei Ding
, Hari Shreedharan, and Jarek Cecho. Changes --- Incorporate the comments. Thanks, Jarcec. Bugs: SQOOP-827 https://issues.apache.org/jira/browse/SQOOP-827 Repository: sqoop-sqoop2 Description (updated) --- commit d354e88d56123b0a331179d41ad2df2eb5d02ba4 Author: Mengwei Ding

Re: Review Request 13273: SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used

2013-08-15 Thread Mengwei Ding
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13273/#review25191 ------- On Aug. 5, 2013, 6:10 p.m., Mengwei Ding wrote: > > ---

Re: Review Request 13273: SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used

2013-08-19 Thread Mengwei Ding
s, definitely. - Mengwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13273/#review25285 --- On Aug. 5, 2013, 6:1

  1   2   3   >