Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

This reminds me: would it be possible to keep track of who merged a PR? (i.e., the person that set the 'push' label) Currently, commits just appear on the branch with the original author and the committer field set to something non-descript, e.g., commit 275d0a39c42ad73a6e4929822f56f5d8c16ede96

Re: [edk2-devel] [PATCH v4 0/3] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set

On Thu, 2 May 2024 at 11:06, Gerd Hoffmann wrote: > > On Wed, May 01, 2024 at 02:03:37PM GMT, Michael Roth wrote: > > For the most part, OVMF will clear the encryption bit for MMIO regions, > > but there is currently one known exception during SEC when the APIC > > base address is accessed via

Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024

On Wed, 1 May 2024 at 19:44, Michael D Kinney wrote: > > Hello, > > I would like to propose that TianoCore move all code review from email > based code reviews to GitHub Pull Requests based code reviews. > > The proposed date to switch would be immediately after the next stable > tag which is

Re: [edk2-devel] [PATCH v5 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

> 3. Remove the architecture comment in PEI INF. > 4. Reoder the PEI INF in alphabetical order. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 > > PR: https://github.com/tianocore/edk2/pull/5568 > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Gerd

Re: [edk2-devel] [PATCH v4 4/8] OvmfPkg: Add the QemuFwCfgMmioLib PEI stage version

On Fri, 26 Apr 2024 at 10:29, Chao Li wrote: > > Added the PEI stage library for QemuFwCfgMmioLib, which uses the FDT to > find the fw_cfg and parse it. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: G

Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

On Mon, 29 Apr 2024 at 09:09, Chao Li wrote: > > Hi Ard, > > OK, I will make adjustments according to your suggestions and submit the V5 > today. > No, please do not make any adjustments. I will take the v4 and apply these changes directly. Please do not send another revision unless there are

Re: [edk2-devel] [PATCH v4 0/8] Adjust the QemuFwCfgLibMmio and add PEI stage

On Mon, 29 Apr 2024 at 03:17, Chao Li wrote: > > Hi Ard and Gerd and other maintainers, > > Could you review this version and give your suggestions? > This looks ok to me now, modulo a few minor tweaks (see below) that I will apply when merging. I also changed the type signatures to extern

Re: [edk2-devel] [PATCH v1] Maintainers.txt: Update StandaloneMmPkg and UefiCpuPkg Reviewer

On Mon, 29 Apr 2024 at 07:32, Jiaxin Wu wrote: > > This is to update StandaloneMmPkg and UefiCpuPkg Reviewer. > > Cc: Ray Ni > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Signed-off-by: Jiaxin Wu Thanks for helping out.

Re: [edk2-devel] [PATCH v2] OvmfPkg: Don't make APIC MMIO accesses with encryption bit set

On Fri, 26 Apr 2024 at 16:16, Roth, Michael via groups.io wrote: > > On Fri, Apr 26, 2024 at 08:51:20AM -0500, Roth, Michael via groups.io wrote: > > For the most part, OVMF will clear the encryption bit for MMIO regions, > > but there is currently one known exception during SEC when the APIC > >

Re: [edk2-devel] [PATCH v3 2/7] OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio

mu.dsc"). > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Sunil V L > Cc: Andrei Warkentin > Signed-off-by: Chao Li > --- > .../Library/Qemu

Re: [edk2-devel] [PATCH v3 1/7] OvmfPkg: Separate QemuFwCfgLibMmio.c into two files

VVirtQemu.dsc"). > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4755 > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Sunil V L > Cc: Andrei Warkentin > Signed-off-by: Chao Li

Re: [edk2-devel] [PATCH v2 2/7] OvmfPkg: Add the way of HOBs in QemuFwCfgLibMmio

On Thu, 25 Apr 2024 at 10:10, Chao Li wrote: > > Hi Gerd, > > > Thanks, > Chao > On 2024/4/25 15:40, Gerd Hoffmann wrote: > > Hi, > > +EFI_GUID mFwCfgSelectorAddressGuid = FW_CONFIG_SELECTOR_ADDRESS_HOB_GUID; > +EFI_GUID mFwCfgDataAddressGuid = FW_CONFIG_DATA_ADDRESS_HOB_GUID; > +EFI_GUID

Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in confidential guests

On Wed, 24 Apr 2024 at 18:36, Yao, Jiewen wrote: > > Thanks Ard. > > I have submitted https://github.com/tianocore/edk2/pull/5595 3 hours ago. > But it seems the CI stops working... > OK, I have dropped my PR. > > > > -Original Message- > > From

Re: [edk2-devel] [PATCH v2] OvmfPkg: Harden #VC instruction emulation somewhat (CVE-2024-25742)

On Tue, 23 Apr 2024 at 11:28, Gerd Hoffmann wrote: > > On Fri, Apr 19, 2024 at 11:21:46AM -0700, Adam Dunlap wrote: > > Ensure that when a #VC exception happens, the instruction at the > > instruction pointer matches the instruction that is expected given the > > error code. This is to mitigate

Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/VirtHstiDxe: do not load driver in confidential guests

lso isn't > > anything we can reasonably test, neither flash storage nor SMM mode will > > be used in that case. So just skip driver load when running in a > > confidential guest. > > > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Fixes: 506740982bba ("Ov

Re: [edk2-devel] [PATCH v1 0/4] Adjust the QemuFwCfgLibMmio and add PEI stage

On Wed, 24 Apr 2024 at 13:19, Gerd Hoffmann wrote: > > On Wed, Apr 24, 2024 at 09:57:50AM +0800, Chao Li wrote: > > Hi Gerd and Ard, > > > > Can I submit the V2 this week? I want all OvmfPkg changes to be meged before > > the 202405 feature freeze. > > Yea, go ahead, lets stick to the PCD

Re: [edk2-devel] [PATCH v3 0/5] OvmfPkg: Add VirtHstiDxe driver

On Mon, 22 Apr 2024 at 12:47, Gerd Hoffmann wrote: > > v3: > - use PcdOvmfFlashNvStorageVariableBase > - add reviewed-by tags > v2: > - remove 'Q35' from test bits > - add patch with a README.md > > Gerd Hoffmann (3): > OvmfPkg/VirtHstiDxe: add varstore flash check > OvmfPkg/VirtHstiDxe:

[edk2-devel] [PATCH] ArmVirtPkg/ArmVirtQemu: always build XIP code with strict alignment

From: Ard Biesheuvel The optimization that enabled entry with MMU and caches enabled at EL1 removed the strict alignment requirement for XIP code (roughly, any code that might execute with the MMU and caches off, which means SEC and PEI phase modules but also *all* BASE libraries), on the basis

Re: [edk2-devel] [PATCH v3 5/6] target/arm: Do memory type alignment check when translation disabled

On Fri, 19 Apr 2024 at 18:36, Ard Biesheuvel wrote: > > On Fri, 19 Apr 2024 at 18:09, Jonathan Cameron via groups.io > wrote: > > > > On Fri, 19 Apr 2024 13:52:07 +0200 > > Gerd Hoffmann wrote: > > > > > Hi, > > > > > > > G

Re: [edk2-devel] [PATCH v3 5/6] target/arm: Do memory type alignment check when translation disabled

strict alignment. > So with out the errata > DEFINE GCC_AARCH64_CC_XIPFLAGS = -mstrict-align -mgeneral-regs-only > is replaced with > [BuildOptions] > +!if $(CAVIUM_ERRATUM_27456) == TRUE^M > + GCC:*_*_AARCH64_PP_FLAGS = -DCAVIUM_ERRATUM_27456^M > +!else^M >GCC:*_*_AARCH64_CC_XIP

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

On Fri, 19 Apr 2024 at 15:00, Chang, Abner wrote: > > [AMD Official Use Only - General] > > I guess my RB misled contributors thought the patch is good to merge. > However, I was thinking Eric's team should give the final RB after the > validation as they are the maintainers for the subordinate

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

On Fri, 19 Apr 2024 at 11:06, Xing, Eric wrote: > > [AMD Official Use Only - General] > > Hi Ard, > > This checkin causes VanGoghBoard build fail now. Would you help revert it? > I will merge PATCH to VanGoghBoard after the code review process done and > code changes are verified pass on real

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

On Fri, 19 Apr 2024 at 10:10, Xing, Eric via groups.io wrote: > > [AMD Official Use Only - General] > > > Thanks Duke. > > > > Hi Thomas, > > > > PATCH1/2 still cannot be checked in because today’s VanGoghBoard is based off > EDK2_202208. Please hold on this PATCH check in. > > Apologies, but I

Re: [edk2-devel] MdeModulePkg: Fix MAT SplitRecord() Logic introduce one bug and will cause SUT reset when boot to windows

Hello Dandan, On Thu, 18 Apr 2024 at 15:03, Dandan Bi wrote: > > Hi Taylor, > > > > >>Extra EfiRuntimeServicesCode regions which aren't part of loaded runtime > >>images. > > This may be related to the original size of EfiRuntimeServicesCode in memory > map, and the size can be configured via

Re: [edk2-devel] [PATCH] OvmfPkg: Harden #VC instruction emulation somewhat (CVE-2024-25742)

(cc Jiewen) Please cc the OVMF maintainers when you send edk2 patches. (There is a Maintainers file in the root of the repo) On Wed, 17 Apr 2024 at 18:54, Adam Dunlap via groups.io wrote: > > Ensure that when a #VC exception happens, the instruction at the > instruction pointer matches the

Re: [edk2-devel] [PATCH v1] MdeModulePkg: Fixup MAT Attributes After Splitting EFI Memory Map

On Wed, 17 Apr 2024 at 16:34, Taylor Beebe wrote: > > > On 4/17/2024 7:09 AM, Oliver Smith-Denny wrote: > > On 4/17/2024 7:05 AM, Taylor Beebe wrote: > >> > >> On 4/17/2024 6:40 AM, Oliver Smith-Denny wrote: > >>> Aside from this, I wonder if we can be more aspirational here. These > >>>

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: Add VirtHstiDxe driver

On Wed, 17 Apr 2024 at 10:18, Gerd Hoffmann wrote: > > On Fri, Mar 22, 2024 at 03:27:31PM +0100, Gerd Hoffmann wrote: > > > > > > Gerd Hoffmann (2): > > OvmfPkg/VirtHstiDxe: add varstore flash check > > OvmfPkg/VirtHstiDxe: add code flash check > > > > Konstantin Kostiuk (2): > > OvmfPkg:

Re: [edk2-devel] [PATCH v1] MdeModulePkg: Fixup MAT Attributes After Splitting EFI Memory Map

Hi Taylor, On Wed, 17 Apr 2024 at 04:28, Taylor Beebe wrote: > > The Memory Attributes Table is generated by fetching the EFI > memory map and splitting entries which contain loaded > images so DATA and CODE sections have separate descriptors. > The splitting is done via a call to SplitTable()

Re: [edk2-devel] [PATCH v3 00/24] Provide SEV-SNP support for running under an SVSM

(cc'ing the stewards) On Fri, 12 Apr 2024 at 17:14, Tom Lendacky wrote: > > On 4/12/24 10:05, Ard Biesheuvel wrote: > > On Fri, 12 Apr 2024 at 16:02, Tom Lendacky wrote: > >> > >> Re-pinging the list/maintainers, again. I need reviews from the > >>

Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

On Sat, 13 Apr 2024 at 11:37, Qinkun Bao wrote: > ... > > > > I think it is a bad idea to go and apply changes all across the boot > > software ecosystem to measure the same assets into different > > measurement protocols. I'mm afraid it creates technical debt that will > > come and bite us in

Re: [edk2-devel] [PATCH v3 00/24] Provide SEV-SNP support for running under an SVSM

On Fri, 12 Apr 2024 at 16:02, Tom Lendacky wrote: > > Re-pinging the list/maintainers, again. I need reviews from the > maintainers on patches #2, #7, #10, #11 and #13. > > Once I get final approval, I'll submit the change to edk2-platforms for > the new library as a reply to this series for a

Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

On Thu, 11 Apr 2024 at 12:29, Gerd Hoffmann wrote: > > On Thu, Apr 11, 2024 at 09:56:48AM +, Yao, Jiewen wrote: > > Please allow me to clarify what you are proposing: > > Do you mean in vTPM case, we extend both, but we only need TCG event log, > > NOT CC event log? > > Elsewhere in this

Re: [edk2-devel] [RFC PATCH] OvmfPkg/SecurityPkg: Add build option for coexistance of vTPM and RTMR.

TMR, and only extends one of vTPM or RTMR, but the > other one only verifies the other, then the chain of trust is broken." > > At same time, we also respect that it might be a valid use case for Google. > I would like to ask the opinion in the EDKII community, especially the OVMF > and

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses

On Tue, 9 Apr 2024 at 13:56, Gerd Hoffmann wrote: > > On Mon, Apr 08, 2024 at 08:53:10AM +0100, Phillip Tennen wrote: > > Hi, thank you for taking a look at the patch! > > > > This patch can be verified to be working with this app (which was the > > motivation for submitting this): > >

Re: [edk2-devel] [PATCH v2 0/3] MdeModulePkg: ImagePropertiesRecordLib Fixes

; months, which has slowed down getting some really > important fixes into MdeModulePkg. > Yes, could we please get this merged? These are important fixes. In case it was missed, for the series: Reviewed-by: Ard Biesheuvel -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages s

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg/AcpiTableDxe: PCD switch to avoid using ACPI reclaim memory

Hello Aaron, Could you describe the problem that is being solved by the ability to use EfiAcpiMemoryNVS for ACPI tables? On Thu, 28 Mar 2024 at 05:59, Aaron Li wrote: > > Hi Liming, > > Currently this patch does not have a related Bugzilla. > > According to UEFI spec, the ACPI Tables at boot

Re: [edk2-devel] [PATCH v1 1/1] ArmVirtPkg: Kvmtool: Fix ACPI/DT boot selection

alue 00 indicates ACPI boot > Value 01 indicates DT boot > > 2. Set the boot mode to ACPI >setvar ForceNoAcpi -guid > "50BEA1E5-A2C5-46E9-9B3A-59596516B00A" > -nv -bs =0x00 > > 3. Set the boot mode to DT >setvar ForceNoAcpi -guid > "50BE

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Align the SEC module within OvmfPkgX64

zeroes leading to an > ALIGN_POINTER macro that doesn't work. > > Cc: Ard Biesheuvel > > Signed-off-by: Glenn Griffin > --- > OvmfPkg/OvmfPkgX64.fdf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPk

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Maintainers.txt: add myself as QemuSbsa maintainer

On Tue, 26 Mar 2024 at 14:11, Marcin Juszkiewicz wrote: > > With all changes going around sbsa-ref/QemuSbsa platform Leif suggested > that I should become maintainer as well. > > My GitHub account name is "hrw". > > Signed-off-by: Marcin Juszkiewicz Welcom

Re: [edk2-devel] [PATCH edk2-platforms v7 1/4] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

On Tue, 19 Mar 2024 at 14:50, Marcin Juszkiewicz wrote: > > This library provides functions to check for hardware information. > For now it covers CPU ones: > > - amount of cpu cores > - MPIDR value for cpu core > - NUMA node id for cpu core > > Values are read from TF-A using platform specific

Re: [edk2-devel] [PATCH edk2-non-osi 1/1] Qemu/Sbsa: update TF-A binaries to get needed SMC calls

On Thu, 14 Mar 2024 at 15:21, Marcin Juszkiewicz wrote: > > W dniu 14.03.2024 o 15:17, Marcin Juszkiewicz via groups.io pisze: > > We want to stop parsing DeviceTree (in EDK2) to gather hardware information. > > > > Instead we ask TF-A for those details using SMC calls. On real hardware > >

Re: [edk2-devel] [PATCH edk2-platforms v6 2/7] Platform/SbsaQemu: read amount of cpus during init

On Tue, 19 Mar 2024 at 11:25, Marcin Juszkiewicz wrote: > > W dniu 15.03.2024 o 12:49, Marcin Juszkiewicz pisze: > > W dniu 14.03.2024 o 16:13, Ard Biesheuvel pisze: > > >> How is it guaranteed that other components will only see the correct > >> core cou

Re: [edk2-devel] [PATCH v1 17/26] OvmfPkg/LoongArchVirt: Add serial port hook library

On Fri, 15 Mar 2024 at 10:49, Chao Li wrote: > > Hi Gerd, > > > Thanks, > Chao > On 2024/3/15 17:33, Gerd Hoffmann wrote: > > On Mon, Mar 11, 2024 at 05:39:02PM +0800, Chao Li wrote: > > Add a serial port hook library in LoongArchVirt named > Fdt16550SerialProtHookLib, this library is referenced

Re: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues

On Thu, 14 Mar 2024 at 15:52, gaoliming via groups.io wrote: > > For this patch set, I have no comments. Reviewed-by: Liming Gao > > Merged as #5471 > > -邮件原件- > > 发件人: Oliver Smith-Denny > > 发送时间: 2024年3月10日 3:06 > > 收件人: devel@edk2.groups.io &g

Re: 回复: [edk2-devel][PATCH v2 1/1] MdeModulePkg: Remove ArmPkg Dependency

ed-by: > > Liming Gao > > > >> -邮件原件- > >> 发件人: Oliver Smith-Denny > >> 发送时间: 2024年2月15日 7:20 > >> 收件人: devel@edk2.groups.io > >> 抄送: Leif Lindholm ; Ard Biesheuvel > >> ; Sami Mujawar ; > >> Liming Gao ; Se

Re: [edk2-devel] [PATCH edk2-platforms v6 6/7] Platform/SbsaQemu: get the information of memory via SMC calls

On Wed, 6 Mar 2024 at 12:42, Marcin Juszkiewicz wrote: > > From: Xiong Yining > > Provide functions to check for memory information: > > - amount of memory nodes > - memory address > - NUMA node id for memory > > Values are read from TF-A using platform specific SMC calls. > > Signed-off-by:

Re: [edk2-devel] [PATCH edk2-platforms v6 4/7] Platform/SbsaQemu: move FdtHandlerLib to SbsaQemuHardwareInfoLib

On Wed, 6 Mar 2024 at 12:42, Marcin Juszkiewicz wrote: > > There is no need for EDK2 to know that there is DeviceTree around. > All hardware information is read using functions from > SbsaQemuHardwareInfoLib library. > > Library fallbacks to parsing DT if needed. > I'd prefer to have only a

Re: [edk2-devel] [PATCH edk2-platforms v6 3/7] Platform/SbsaQemu: use PcdCoreCount directly

On Wed, 6 Mar 2024 at 12:42, Marcin Juszkiewicz wrote: > > During platform initialization we read amount of cpu cores and set > PcdCoreCount so there is no need to call FdtHandler. > How can you be sure that that code executes first? > Signed-off-by: Marcin Juszkiewicz > --- >

Re: [edk2-devel] [PATCH edk2-platforms v6 1/7] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

On Thu, 14 Mar 2024 at 16:09, Ard Biesheuvel wrote: > > On Wed, 6 Mar 2024 at 12:42, Marcin Juszkiewicz > wrote: > > > > This library provides functions to check for hardware information. > > For now it covers CPU ones: > > > > - amount of cpu cores > &g

Re: [edk2-devel] [PATCH edk2-platforms v6 2/7] Platform/SbsaQemu: read amount of cpus during init

On Wed, 6 Mar 2024 at 12:42, Marcin Juszkiewicz wrote: > > We read it once and store in Pcd for future use. > > Signed-off-by: Marcin Juszkiewicz > --- > .../SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf | 4 +++- > .../SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c

Re: [edk2-devel] [PATCH edk2-platforms v6 1/7] Platform/SbsaQemu: add SbsaQemuHardwareInfoLib

On Wed, 6 Mar 2024 at 12:42, Marcin Juszkiewicz wrote: > > This library provides functions to check for hardware information. > For now it covers CPU ones: > > - amount of cpu cores > - MPIDR value for cpu core > - NUMA node id for cpu core > > Values are read from TF-A using platform specific

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

On Tue, 12 Mar 2024 at 17:56, Leif Lindholm wrote: > > On 2024-03-12 09:50, Ard Biesheuvel wrote: > > On Tue, 12 Mar 2024 at 17:38, Leif Lindholm > > wrote: > >> > >> On 2024-03-12 08:17, Ard Biesheuvel wrote: > >>> From: Ard Biesheuvel > &g

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: > > On 2024-03-12 08:17, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > NonCoherentIoMmuSetAttribute() does nothing except return > > EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI

[edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does nothing except return EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI bus driver will fail a PCI I/O Map() operation if the SetAttributes fails. So return EFI_SUCCESS instead. Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build

From: Ard Biesheuvel The DEBUG build no longer fits when all build options used by the release script on github.com/pftf are used, presumably due to the OpenSSL upgrade. So bump the size for all builds. Signed-off-by: Ard Biesheuvel --- Platform/RaspberryPi/RPi4/RPi4.fdf | 14

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build

On Tue, 12 Mar 2024 at 11:29, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > The DEBUG build no longer fits when all build options used by the > release script on github.com/pftf are used, presumably due to the > OpenSSL upgrade. > > So bump the size for all builds

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

in memory. > > Cc: Liming Gao > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Taylor Beebe > > Signed-off-by: Oliver Smith-Denny > --- > MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.c | 4 > +++- >

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

On Mon, 11 Mar 2024 at 20:34, Oliver Smith-Denny wrote: > > On 3/4/2024 2:38 PM, Oliver Smith-Denny wrote: > > On 3/4/2024 11:24 AM, Oliver Smith-Denny wrote: > >> On 3/4/2024 10:54 AM, Ard Biesheuvel wrote: > >>> On Mon, 4 Mar 2024 at 18:49, Oliver Smith-Denny &

Re: [edk2-devel] [PATCH v2 0/5] Platform/RaspberryPi: Various minor fixes

On Wed, 17 Jan 2024 at 22:36, Jeremy Linton wrote: > > This includes a change to always initialize the PL011 to the > configured baud (which should be 115200 for the SBSA UART), which > fixes linux's assumption that SBSA UARTs are pre-programmed for > 115200. This in turn (re)enables the PL011

Re: [edk2-devel] [PATCH v2 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

On Wed, 17 Jan 2024 at 22:36, Jeremy Linton wrote: > > The rpi's config.txt controls which uart (pl011, or miniuart) is > selected as the console. TFA and edk2 follow its lead, but if the > miniuart is selected as the primary and the machine is booted in ACPI > mode the baud/etc is never

Re: [edk2-devel] [PATCH v2 3/4] StandaloneMmPkg: Support to unregister MMI handler inside MMI handler

Cc: Liming Gao > Cc: Jiaxin Wu > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Signed-off-by: Zhiguang Liu > --- > StandaloneMmPkg/Core/Mmi.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Ard Biesh

Re: [edk2-devel][PATCH v3 3/3] MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types

f dynamic heap guard configurations). > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4674 > Github PR: https://github.com/tianocore/edk2/pull/5382 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao > > Signed-off-by: Oliver Smith-De

Re: [edk2-devel] [PATCH] Maintainers.txt: remove Laszlo's entries

On Fri, 8 Mar 2024 at 10:14, Laszlo Ersek wrote: > > On 3/6/24 23:22, Michael D Kinney wrote: > > Reviewed-by: Michael D Kinney > > Merged as commit ccf91b518f22, via > . > > Thank you all for everything, Goodbye Laszlo. It was great to have you

Re: [edk2-devel] [PATCH v2 05/10] ArmPlatformPkg: auto-generate SEC ProcessLibraryConstructorList() decl

mPkg.dsc -t GCC5 > > build -a AARCH64 -b DEBUG \ > -m ArmPlatformPkg/PrePi/PeiUniCore.inf \ > -p ArmPlatformPkg/ArmPlatformPkg.dsc -t GCC5 > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 > Signed-off-by:

Re: [edk2-devel] [PATCH v2 06/10] ArmVirtPkg: auto-generate SEC ProcessLibraryConstructorList() decl

ePi/PrePi.c| 6 -- > 2 files changed, 1 insertion(+), 7 deletions(-) > Reviewed-by: Ard Biesheuvel > diff --git a/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf > b/ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf

Re: [edk2-devel] [edk2-platforms PATCH v2 1/4] BeagleBoardPkg: auto-generate SEC ProcessLibraryConstructorList() decl

agleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc -t GCC5 > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > Platform/BeagleBoard/BeagleBoardPkg/PrePi/PeiUniCore.inf | 2 +-

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

On Mon, 4 Mar 2024 at 18:49, Oliver Smith-Denny wrote: > > Hi Ard, > > On 3/1/2024 3:58 AM, Ard Biesheuvel wrote: > > Hi Oliver, > > > > On Tue, 27 Feb 2024 at 21:27, Oliver Smith-Denny > > wrote: > >> > >> When an ImageRe

Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges

uplicate it at multiple places. > > Can you let me know if I can merge this patch, please? > I have no problems with that, please go ahead. Acked-by: Ard Biesheuvel I will note that we will have to clean this up in the future, though: the architected GIC pieces should not be p

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

emitting sections either using a non-1:1 file:memory mapping, or with unallocated holes in the file representation? > Cc: Liming Gao > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Taylor Beebe > > Signed-off-by: Oliver Smith-Denny > --- > MdeModulePkg/Lib

Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

On Wed, 21 Feb 2024 at 23:16, Laszlo Ersek wrote: > > On 2/20/24 15:48, Ard Biesheuvel wrote: > > Hello Mike, > > > > I understand the desire to be pedantic about cc'ing the right > > maintainers, but I'm not convinced this is the way. > > > > - th

Re: [edk2-devel] Merge commit in edk2-non-osi

On Wed, 21 Feb 2024 at 16:05, Michael D Kinney wrote: > > Hi Ard, > > I disagree. We have never allowed a force push to the main > branch of TianoCore repos. This has happened before and > was discussed and the policy is to not fix. Even the edk2 > repo has some merge commits in its history

Re: [edk2-devel][PATCH v2 0/3] Fix Runtime Granularity Issues

Update guard commit message, comments, and static assert to use > the correct types > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao > > Oliver Smith-Denny (3): > MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages > MdeModulePkg: D

Re: [edk2-devel] [PATCH v3 0/6] OvmfPkg: Add support for 5-level paging

mfPkg/PlatformInitLib: add 5-level paging support > I'm fine with all this but I haven't looked in great detail, so Acked-by: Ard Biesheuvel -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115726): https://edk2.groups.io/g/devel/

Re: [edk2-devel] Merge commit in edk2-non-osi

On Wed, 21 Feb 2024 at 02:49, Nate DeSimone wrote: > > Hi Everyone, > > It appears that a merge commit was introduced to edk2-non-osi due to a PR > merge: > > https://github.com/tianocore/edk2-non-osi/commit/61b65fccfe4c75bc9ecb7b542412a436e3db5de6 > > I would like to remind everyone that we

Re: [edk2-devel] [Patch 3/4] BaseTools/Scripts/PatchCheck: Error if no Cc tags are present

Hello Mike, I understand the desire to be pedantic about cc'ing the right maintainers, but I'm not convinced this is the way. - the presence of a cc: tag does not guarantee that the person was cc'ed - only git send-email will take CC:s in the message body into account by default (but this can

Re: [edk2-devel] [Patch 1/1] BaseTools/Scripts/PatchCheck: Error if commit modifies multiple packages

gle commit. Not the entire PR. > 2) The information about what CI checks to skip are part of the >commit message and the commit history so the information can be >reused if needed in downstream CI. > 3) The information is in the commit message, so it is available for both >PR CI checks and 'push' CI checks. > 4) No new behavi

Re: [edk2-devel] mail-archive.com (secondary archive) feed resumed

On Fri, 16 Feb 2024 at 15:20, Laszlo Ersek wrote: > > On 2/15/24 14:45, Rebecca Cran wrote: > > On 2/15/2024 4:28 AM, Laszlo Ersek wrote: > >> mail-archive.com is an important secondary archive because it offers > >> message-id-based lookup. "git am --message-id" captures patch email > >> message

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

On Thu, 15 Feb 2024 at 20:55, Oliver Smith-Denny wrote: > > On 2/14/2024 11:50 PM, Ard Biesheuvel wrote: > > I looked at the EFI spec again, and EfiACPIReclaimMemory is not > > actually listed as a memory type that has this 64k alignment > > requirement. This makes sense

Re: [edk2-devel][PATCH v1 1/1] MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations

On Thu, 15 Feb 2024 at 18:08, Oliver Smith-Denny wrote: > > On 2/14/2024 11:50 PM, Ard Biesheuvel wrote> On Thu, 15 Feb 2024 at > 01:34, Oliver Smith-Denny > > wrote >> This could also be fixed with > > rearchitecting the heap guard system to > >> r

Re: [edk2-devel] [PATCH v5 00/11] DynamicTablesPkg: Enable _PSD/_CPC generation using SCMI

; > A patchset for Juno-r2 platforms will be submitted to demonstrate > this functionality. > > [1] https://edk2.groups.io/g/devel/message/111901 > > Pierre Gondois (11): > ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION > ArmPkg/ArmScmiDxe: Add PERFORMANCE_DESCRIBE_FASTCHANNEL s

Re: [edk2-devel] [PATCH RESEND 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

On Mon, 22 Jan 2024 at 03:34, Nhi Pham via groups.io wrote: > > From: Laszlo Ersek > > The current dependency evaluator violates the memory access permission > when patching depex grammar directly in the read-only depex memory area. > > Laszlo pointed out the optimization issue in the thread (1)

Re: [edk2-devel] [PATCH v3 5/5] MdeModulePkg: Extend NestedInterruptTplLib to support Arm CPUs

eInterrupts(), which also sets both > flags). > > Tested by patching ArmPkg's TimerDxe to use NestedInterruptTplLib and > verifying that ArmVirtQemu passes the NestedInterruptTplLib self-tests > for both ARM and AARCH64. > > Cc: Ard Biesheuvel > Signed-off-by: Michael Brown

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Remove optimization for depex evaluation

On Fri, 19 Jan 2024 at 05:58, Nhi Pham via groups.io wrote: > > From: Laszlo Ersek > > The current dependency evaluator violates the memory access permission > when patching depex grammar directly in the read-only depex memory area. > > Laszlo pointed out the optimization issue in the thread (1)

Re: [edk2-devel] [PATCH v3 0/6] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

On Thu, 18 Jan 2024 at 21:28, Laszlo Ersek wrote: > > On 1/16/24 18:10, Gerd Hoffmann wrote: > > This is a little series containing the flash corruption fix sent > > yesterday with an slightly improved commit message and some small > > improvements on top of this. > > > > v3: > > - fix diagram >

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: drop support for TPM 1.2

(cc Jiewen. Laszlo) On Tue, 16 Jan 2024 at 16:42, Gerd Hoffmann wrote: > > > > Gerd Hoffmann (2): > OvmfPkg: remove TPM1_ENABLE build option > OvmfPkg/Tcg2Config: remove unused TPM 1.2 support > Good riddance Acked-by: Ard Biesheuvel -=-=-=-=-=-=-=-=-=-=-=- Groups.

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

On Tue, 16 Jan 2024 at 10:37, Laszlo Ersek wrote: > > On 1/15/24 18:56, Ard Biesheuvel wrote: > > On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote: > >> > >> On 1/12/24 12:37, Gerd Hoffmann wrote: > >>> This is a little series containing the

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote: > > On 1/12/24 12:37, Gerd Hoffmann wrote: > > This is a little series containing the flash corruption fix sent > > yesterday with an slightly improved commit message and some small > > improvements on top of this. > > > > Gerd Hoffmann (4): > >

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

bug.cgi?id=1468526. The bug is > > still occuring for CloudHv guests because the PlatformScanE820 > > utility is not currently supported for CloudHv. > > > > My working branch for these changes can be found here: > > https://github.com/thomasbarrett/edk2/tree/cloud-hv-1tb-ram

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

On Mon, 15 Jan 2024 at 16:32, Ard Biesheuvel wrote: > > On Mon, 15 Jan 2024 at 16:27, Gerd Hoffmann wrote: > > > > On Fri, Jan 12, 2024 at 06:31:41PM +, Thomas Barrett wrote: > > > This series adds support for cloud-hypervisor guests with >1TiB > > &

Re: [edk2-devel] [PATCH v3 0/3] Support CloudHv guests with >1TB of RAM

2/tree/cloud-hv-1tb-ram > > > > Cc: Anatol Belski > > Cc: Ard Biesheuvel > > Cc: Gerd Hoffmann > > Cc: Jianyong Wu > > Cc: Jiewen Yao > > Cc: Laszlo Ersek > > Cc: Rob Bradford > > > > Thomas Barrett (3): > > OvmfPkg: Add

Re: [edk2-devel] Memory Attribute for depex section

On Mon, 15 Jan 2024 at 14:07, Nhi Pham wrote: > > On 1/12/2024 4:45 PM, Laszlo Ersek wrote: > > (Independently: I think that's a valid thing to do for *SMM* drivers, > > because the entry point functions of those drivers are permitted to use > > both SMM and DXE/UEFI protocols. But whether the

[edk2-devel] [PATCH edk2-platforms 1/1] Maintainers: Remove Ard as Platform/ARM reviewer

From: Ard Biesheuvel Remove me as reviewer for ARM development platforms: I am no longer employed by ARM and have no access to or knowledge about ARM development/reference hardware. Signed-off-by: Ard Biesheuvel --- Maintainers.txt | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too

On Fri, 12 Jan 2024 at 12:38, Gerd Hoffmann wrote: > > It is possible to find variable entries with State being 0xff, > i.e. not updated since flash block erase. This indicates the > header write was not completed (and therefore State was not set > to VAR_HEADER_VALID_ONLY). Treat this as

Re: [edk2-devel] [PATCH 3/4] OvmfPkg/VirtNorFlashDxe: allow larger writes without block erase

FER_SIZE_IN_BYTES)) { > + if ((*NumBytes + (Offset & BOUNDARY_OF_32_WORDS)) <= (4 * > P30_MAX_BUFFER_SIZE_IN_BYTES)) { > // Check to see if we need to erase before programming the data into NOR. > // If the destination bits are only changing from 1s to 0s we can j

Re: [edk2-devel] [PATCH 2/4] OvmfPkg/VirtNorFlashDxe: clarify block write logic

to handle updates larger > than two P30_MAX_BUFFER_SIZE_IN_BYTES blocks, even though the patch > does not actually change the size limit. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Ard Biesheuvel Nit below > --- > OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 31

Re: [edk2-devel] [PATCH 1/4] OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads

log. This should have been 0xff. > > This patch fixes the calculation. > > Signed-off-by: Gerd Hoffmann Thanks a lot for taking the time to track this down and fix it. Reviewed-by: Ard Biesheuvel > --- > OvmfPkg/VirtNorFlashDxe/VirtNorFlash.c | 2 +- > 1 file changed,

Re: [edk2-devel] [PATCH v1 0/4] Bz4166: Integer Overflow in CreateHob()

On Thu, 11 Jan 2024 at 09:35, Guo, Gua wrote: > > CC: @Mathews, John and @Zimmer, Vincent > > Hi @Gerd Hoffmann > > My company teammate share me your patch can resolved > https://bugzilla.tianocore.org/show_bug.cgi?id=4166. So the signed-off name > is your name. > Again, a signed-off-by line

Re: [edk2-devel] [PATCH 5/5] Platform/RaspberryPi: Update PCIe MMIO window for DT

On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote: > > Since we are updating the DT memory map and telling it how > we have configured the PCIe, there isn't a reason for moving the > MMIO window. In fact this appears to fix OpenBSD+DT as well as > it makes the linux XHCI reset sequence happier. >

Re: [edk2-devel] [PATCH 4/5] Platform/RaspberryPi: Give the user control over the XHCI mailbox

On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote: > > Its a complete tossup whether removing the mailbox call after we have > set up the XHCI works for a given kernel+distro in DT mode. So lets > give users which want to try DT the option of flipping this on/off. > > Users that don't want to

Re: [edk2-devel] [PATCH 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

Hi Jeremy, Thanks for the patches. On Thu, 11 Jan 2024 at 00:52, Jeremy Linton wrote: > > The rpi's config.txt controls which uart (pl011, or miniuart) is > selected as the console. TFA and edk2 follow its lead, but if the > miniuart is selected as the primary and the machine is booted in ACPI

<    1   2   3   4   5   6   7   8   9   10   >