Andriy,
I think this is basically a rule, although I don't think it's stated
anywhere. We do rely heavily on this locking strategy since there are many
places that will hold the namespace lock to prevent spa config changes but
yet wait for a txg to sync.
Is it honored everywhere? Well, I hope so
Andriy,
Can you give me some details about how you're able to reproduce this panic.
I would like to help debug this. I'm also looking into the range_tree()
panic, so any details you can provide would be very helpful.
If you can publish the crash dumps, I can also download them and take a
look.
LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/47#issuecomment-165781640___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
LGTM.
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/43#issuecomment-161622259___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/44#issuecomment-161621968___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
> @@ -1508,7 +1509,15 @@ exi_cache_trim(struct exportinfo *exi)
>* used for NFSAUTH_CACHE_TRIM seconds.
>*/
> for (c = avl_first(tree); c != NULL; c = AVL_NEXT(tree, c)) {
> - rw_enter(>authc_lock, RW_WRITER);
> +
LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/22#issuecomment-152831278___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
Looks good to me
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/31#issuecomment-152831553___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/21#issuecomment-152831323___
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
sues/6292
>
>
> Repository: illumos-gate
>
>
> Description
> ---
>
> 6292 exporting a pool while an async destroy is running can leave entries in
> the deferred tree
> Reviewed by: Paul Dagnelie <p...@delphix.com>
> Reviewed by: Matthew Ahrens
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/258/#review826
---
Ship it!
Ship It!
- George Wilson
On Oct. 10, 2015, 11:15 p.m
I don't think L2ARC can be shared only spare devices can be shared.
- George
On Fri, Sep 11, 2015 at 7:23 AM, Andriy Gapon
wrote:
>
> I am curious what was the original reason to not allow sharing of cache
> devices
> (L2ARC) between pools?
> After all, the main ARC
. It would not be a trivial
implementation but seems doable.
- George
On Fri, Sep 11, 2015 at 7:40 AM, Andriy Gapon <andriy.ga...@clusterhq.com>
wrote:
> On 11/09/2015 16:36, George Wilson wrote:
> > I don't think L2ARC can be shared only spare devices can be shared.
>
> But why
Jorgen,
Since you're unloading the pool, there should not be any new allocations or
frees happening. This is actually prevented by the call to txg_sync_stop()
from spa_unload(). Here it should perform the final txg_wait_synced() to
clear out all the ms_freetrees and stop the sync thread.
You
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/229/#review764
---
Ship it!
Ship It!
- George Wilson
On June 25, 2015, 12:34 p.m
like to see review from Saso and George as well.
George, Saso, ping.
- Andriy
On June 25th, 2015, 3:34 p.m. EEST, Andriy Gapon wrote:
Review request for OpenZFS Developer Mailing List, Justin Gibbs, George
Wilson, Matthew Ahrens, and Saso Kiselkov.
By Andriy Gapon.
*Updated June 25
Jorgen,
Can you provide some details about the stack trace when you hit this
failure. All of the ms_freetrees should be empty by the time you can
range_tree_destroy(). So to debug this we need to understand the calling
stack to determine why that isn't happening.
Thanks,
George
On Sat, Aug 22,
.
- George Wilson
On May 6, 2015, 12:21 p.m., Andriy Gapon wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/219/
---
(Updated May 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/217/#review728
---
Ship it!
Ship It!
- George Wilson
On May 8, 2015, 3:29 a.m., Gleb
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/226/#review735
---
Ship it!
Ship It!
- George Wilson
On May 27, 2015, 1:51 p.m
christopher.si...@delphix.com
Original author: George Wilson
Diffs
-
usr/src/uts/common/fs/zfs/dmu_traverse.c
14eef2e7516c9b5e717ef318321ee137dcd19c9f
Diff: https://reviews.csiden.org/r/172/diff/
Testing
---
ztest; zfs test suite
http://jenkins/job/zfs-precommit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/167/#review543
---
Ship it!
Ship It!
- George Wilson
On Feb. 27, 2015, 7:45 p.m., Xin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/163/#review530
---
Ship it!
Ship It!
- George Wilson
On Feb. 21, 2015, 5:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/155/#review477
---
Ship it!
Ship It!
- George Wilson
On Feb. 4, 2015, 4:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/152/#review461
---
Ship it!
Ship It!
- George Wilson
On Jan. 27, 2015, 5:55 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/147/#review407
---
Ship it!
Ship It!
- George Wilson
On Dec. 16, 2014, 6:39 a.m., Xin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/128/#review408
---
Ship it!
Ship It!
- George Wilson
On Dec. 2, 2014, 12:22 p.m
Comment block missing start and end lines.
usr/src/uts/sparc/stmf_sbd/Makefile
https://reviews.csiden.org/r/131/#comment348
Comment block missing start and end lines.
- George Wilson
On Dec. 15, 2014, 4:48 a.m., Justin Gibbs wrote
On 7/7/14, 3:33 AM, Jan Schmidt via illumos-zfs wrote:
On Wed, June 25, 2014 at 16:15 (+0200), Keith Wesolowski Via Illumos-zfs wrote:
On Wed, Jun 25, 2014 at 01:47:54PM +0200, Jan Schmidt via illumos-zfs wrote:
That patch looks somewhat promising, though I have not tried it yet. How did
On 5/7/14, 10:55 AM, Steven Hartland wrote:
- Original Message - From: George Wilson
george.wil...@delphix.com
To: Steven Hartland kill...@multiplay.co.uk; developer@open-zfs.org
Sent: Wednesday, May 07, 2014 3:07 PM
Subject: Re: [OpenZFS Developer] zfs zio reordering
On 5/7/14, 11:46 AM, Steven Hartland wrote:
- Original Message - From: George Wilson
george.wil...@delphix.com
There are a couple of cases where it can work but I'm going to make
it such that requires you to always return back ZIO_PIPELINE_STOP.
Otherwise it's makes it too easy
On 5/7/14, 12:50 PM, Steven Hartland wrote:
- Original Message - From: George Wilson
george.wil...@delphix.com
On 5/7/14, 11:46 AM, Steven Hartland wrote:
- Original Message - From: George Wilson
george.wil...@delphix.com
There are a couple of cases where it can work
Steven,
I think there is probably another way we can solve this problem but I
first want to get a better understanding of the corruption. We have not
integrated the TRIM support upstream and I suspect that's the source of
most of the problems. Can you confirm that with TRIM disabled that most
Hmm, 'zpool scrub' should be able to clear that error. Can you tell me
which options you used to 'zinject' and I'll try reproducing it here.
Thanks,
George
On 2/26/14 4:22 AM, Andriy Gapon wrote:
I did some experimenting and used zinject to introduce some non-correctable data
errors while
LGTM.
- George
On 1/14/14 12:57 PM, Saso Kiselkov wrote:
On 1/14/14, 11:51 AM, Andriy Gapon wrote:
Recently I noticed that on one of our systems l2arc_feed_thread was consuming
non insignificant amount of CPU time. I looked at some stats (FreeBSD has local
changes that add a few kstats for
Ilya,
I think there is a bigger problem here that your vdev_mirror() change
would cover up. The problems is that we should never have a bp with a
dva that is out of range. So we need to understand how that is occurring.
As for you question about metaslab_allocate_dva(), I'm assuming you're
On 12/17/13 5:21 AM, Gaurav Mahajan wrote:
Hi all,
I am trying to understand relations of root ZIO and children ZIO.
This is what I have understood.. Please correct me if I'm wrong.
Usually whenever we want to do a series of IO operations like in sync
thread.
We create a root ZIO with
Andriy,
The fix looks good but I have a couple of questions:
1. Are you sure you want the TRIM priority to be lower than SCRUB?
2. You have zfs_vdev_trim_max_active set to 1 with an /* XXX */ next to
it. Does this mean you haven't settled on the final value for active max?
Thanks,
George
On
38 matches
Mail list logo