Re: Merge multi-line descriptions in .opt files

2013-07-20 Thread Hans-Peter Nilsson
On Sat, 20 Jul 2013, Göran Uddeborg wrote: > While translating GCC (to Swedish), I've occasionally come across > obviously truncated strings. Often, it has been caused by multiple > lines used for the description in .opt files. I've tried to file > reports about them. > > One such report I made

Re: [PATCH] Add a new option "-ftree-bitfield-merge" (patch / doc inside)

2013-07-18 Thread Hans-Peter Nilsson
On Wed, 17 Jul 2013, Zoran Jovanovic wrote: > Hello, > This patch adds new optimization pass that combines several adjacent bit > field accesses that copy values from one memory location to another into > single bit field access. > > Example: > > Original code: >   D.1351; >   D.1350; >   D.13

RE: [ping] Re: [patch 0/4] reimplement -fstrict-volatile-bitfields, v3

2013-07-16 Thread Hans-Peter Nilsson
On Sat, 13 Jul 2013, Bernd Edlinger wrote: > Hi Sandra, > > On Fri, 5 Jul 2013, Hans-Peter Nilsson wrote > > Or - maybe more acceptable - an optional warning, say > > -Wportable-volatility, to warn about code for which separate > > incompatbile definitions on differ

Re: [patch 4/4] -fstrict-volatile-bitfields cleanup v3: remove from defaults on all targets

2013-07-05 Thread Hans-Peter Nilsson
On Mon, 1 Jul 2013, Andrew Pinski wrote: > On Sun, Jun 30, 2013 at 8:32 PM, DJ Delorie wrote: > > > > Given how much trouble I went through to make it the default, I'd > > rather not revert all that work... especially since the flag is > > *required* for proper operation of the hardware on many

Committed: fix for frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2013-07-03 Thread Hans-Peter Nilsson
Eric Botcazou asked that I re-apply this previously reverted patch, so here goes. Bootstrapped+regression-test x86_64-unknown-linux-gnu at r200585 with and without -m32. The 32-bit i686-* aka. -m32 previously exposed PR55030. Though that PR was originally about the regression causing the revert,

Re: [PATCH] Fix for PR 57692

2013-07-02 Thread Hans-Peter Nilsson
On Wed, 26 Jun 2013, Iyer, Balaji V wrote: > Hello Everyone, > This patch will fix a FAIL in one of the test cases for array > notations. The reason for fail is that the array sizes were huge and thus it > was causing a stack overflow. This patch should fix the issue. I am > committing thi

Re: new port: msp430-elf, revision 3

2013-06-19 Thread Hans-Peter Nilsson
On Wed, 19 Jun 2013, DJ Delorie wrote: > > Third revision, mostly the same as the last, haven't heard any additional > feedback in the last few weeks. Ok to commit yet? > [libgcc] > > * config.host (msp*-*-elf): New. > * config/msp430/: New port. A random spotting; copyright header r

Re: [PATCH] DATA_ALIGNMENT vs. DATA_ABI_ALIGNMENT (PR target/56564)

2013-06-07 Thread Hans-Peter Nilsson
On Fri, 7 Jun 2013, Richard Henderson wrote: > I've had a brief look over the instances of D_A within the tree atm. Most of > them carry the cut-n-paste comment "for the same reasons". These I believe > never intended an ABI change, and were really only interested in optimization. > > But these I

Re: Symtab cleanups 4/17

2013-06-06 Thread Hans-Peter Nilsson
> From: Jan Hubicka > Date: Wed, 5 Jun 2013 16:18:52 +0200 > * class.c (emit_register_classes_in_jcr_section): Use DECL_PRESERVE_P > instead of mark_decl_referenced. > > * decl2.c (maybe_make_one_only): Use forced_by_abi instad of > mark_decl_referenced. >

Re: More vector folding

2013-05-17 Thread Hans-Peter Nilsson
> From: Marc Glisse > Date: Tue, 14 May 2013 13:47:23 +0200 > Here is what I tested during the night, I'll just rename the function. > I took the chance to remove an unnecessary alternative in TRUTH_XOR_EXPR. > > Passes bootstrap+testsuite on x86_64-linux-gnu. > > 2013-05-14 Marc Glisse > >

Breakage with your libstdc++ allocator patch

2013-04-22 Thread Hans-Peter Nilsson
For cris-elf at r198164: ... libtool: compile: /tmp/hpautotest-gcc0/cris-elf/gccobj/./gcc/xgcc -shared-libgcc -B/tmp/hpautotest-gcc0/cris-elf/gccobj/./gcc -nostdinc++ -L/tmp/hpautotest-gcc0/cris-elf/gccobj/cris-elf/libstdc++-v3/src -L/tmp/hpautotest-gcc0/cris-elf/gccobj/cris-elf/libstdc++-v3/s

Re: [wwwdocs] ftp.axis.se only works via http these days

2013-03-31 Thread Hans-Peter Nilsson
> - ftp://ftp.axis.se/pub/users/hp/pgccfd/";>Porting GCC for > + http://ftp.axis.se/pub/users/hp/pgccfd/";>Porting GCC for >Dunces by Hans-Peter Nilsson < href="mailto:hans-peter.nils...@axis.com";>hans-peter.nils...@axis.com>. > >http://cobolforgcc.sourceforge.net/cobol_toc.html";>Using, > brgds, H-P

vec_concat, vec_duplicate doc updated (was: Re: question about section 10.12)

2013-02-21 Thread Hans-Peter Nilsson
> From: Hans-Peter Nilsson > Date: Mon, 28 Jan 2013 23:14:21 +0100 > * doc/rtl.texi (vec_concat, vec_duplicate): Mention that > scalars are valid operands. Finally committed as obvious after brief check of generated dvi and info. brgds, H-P

closing PR's (was Re: [PATCH ARM iWMMXt 0/5] Improve iWMMXt support)

2013-02-20 Thread Hans-Peter Nilsson
On Mon, 28 Jan 2013, nick clifton wrote: > > Also, could you close its duplicates, bugs 36798 and 36966? > > Sorry no. I do not actually own these PRs, so I cannot close them. :-( Sorry if I misinterpret, but it seems a reminder is in order: magic powers are attached to whome...@gcc.gnu.org accou

Re: question about section 10.12

2013-01-28 Thread Hans-Peter Nilsson
> From: Kenneth Zadeck > Date: Mon, 28 Jan 2013 02:02:41 +0100 > this looks good to me. does your patch also address the vec_concat > issue that marc raised? You mean the issue being "same thing there"? I can confirm that (I've stumbled upon) the same issue being there (i.e. similarly applies

Re: [RFA:] fix failing gfortran.dg/inquire_10.f90 for newlib targets

2013-01-20 Thread Hans-Peter Nilsson
> From: Janne Blomqvist > Date: Sun, 20 Jan 2013 20:14:11 +0100 > On Sun, Jan 20, 2013 at 2:29 AM, Hans-Peter Nilsson > wrote: > > Ever since it was changed to a "run" test (from the default > > "compile", i.e. just producing assembly code), the te

[RFA:] fix failing gfortran.dg/inquire_10.f90 for newlib targets

2013-01-19 Thread Hans-Peter Nilsson
Ever since it was changed to a "run" test (from the default "compile", i.e. just producing assembly code), the test gfortran.dg/inquire_10.f90 has failed for newlib targets while linking, because (besides cygwin and some linux support), newlib doesn't have getcwd: /tmp/ccNhxU2l.o: In function `MAI

Re: [testsuite] add option to LTO flags for c-torture/execute/builtins tests

2013-01-15 Thread Hans-Peter Nilsson
On Tue, 15 Jan 2013, Janis Johnson wrote: > Most of the tests in gcc.c-torture/execute/builtins that use LTO torture > options "-O2 -flto -fuse-linker-plugin -fno-fat-lto-objects" fail to > link on EABI and ELF targets with multiple definitions for either memset > or strlen. I filed PR testsuite/5

Re: [RFA:] fix group-loads of VOIDmode constants, expr.c:emit_group_load_1

2012-12-02 Thread Hans-Peter Nilsson
On Sat, 1 Dec 2012, Eric Botcazou wrote: > > Of course this matters only to >64bit (i.e. >registersize) values like > > TImode, alias __int128. The problem here is that group-loading a > > constant for a function return-value doesn't work; it's passed to > > simplify_gen_subreg which horks on the

[RFA:] fix group-loads of VOIDmode constants, expr.c:emit_group_load_1

2012-11-30 Thread Hans-Peter Nilsson
(No cans of worms opened here, I believe...) For MMIX with the default, Knuth's ABI (returning values in register $0, through the register stack), function return values are prepared in a register-swapped fashion due to the way the register stack works, which has to be expressed as: (parallel [

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-28 Thread Hans-Peter Nilsson
On Tue, 27 Nov 2012, Jakub Jelinek wrote: > 2012-11-26 Jakub Jelinek > > PR debug/36728 > PR debug/55467 > * cselib.c (cselib_process_insn): If cselib_preserve_constants, > don't reset table and exit early on volatile insns and setjmp. > Reset table afterwards on se

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-27 Thread Hans-Peter Nilsson
On Tue, 27 Nov 2012, Jakub Jelinek wrote: > On Tue, Nov 27, 2012 at 06:44:23AM -0500, Hans-Peter Nilsson wrote: JFTR: No I didn't, Eric wrote the below. But, it made sense to me. :) > > > We apparently have a small conflict between the meaning of volatile asms > > >

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-27 Thread Hans-Peter Nilsson
I quoted the whole discussion, see a single line below. On Mon, 19 Nov 2012, Eric Botcazou wrote: > > Unfortunately, it causes regressions; read on for a very brief > > analysis. > > > > For x86_64-linux (base multilib): > > > > Running > > /home/hp/gcctop/tmp/pr55030-2n/gcc/gcc/testsuite/gcc.dg/g

Re: r193821 - in /trunk/gcc: ChangeLog common.opt d...

2012-11-26 Thread Hans-Peter Nilsson
I don't see this posted on gcc-patches@, but... On Mon, 26 Nov 2012, ste...@gcc.gnu.org wrote: > testsuite/ > * testsuite/gcc.dg/20050811-1.c: Change -dv option to -graph option > to -fdump-rtl-all. > * testsuite/gcc.dg/pr37858.c: Remove -dv option. ...looks like you missed: Ex

Re: [Patch,testsuite] ad PR52641: More fixes for not-so-common targets

2012-11-26 Thread Hans-Peter Nilsson
On Mon, 26 Nov 2012, Georg-Johann Lay wrote: > Hans-Peter Nilsson wrote: > > On Fri, 23 Nov 2012, Georg-Johann Lay wrote: > >> Here are some more fixes for 16-bit int and similar. > > > >>* gcc.c-torture/execute/20120919-1.x: New file (int32plus). > &g

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-25 Thread Hans-Peter Nilsson
Thanks for the reviews! On Mon, 19 Nov 2012, Eric Botcazou wrote: > Thanks for the analysis. I don't think that the redundancy of the clobber > list matters here: the clobbers are added to all asm statements, volatile or > not, so they aren't intended to make the volatile statements more precise

Re: [patch] reorg.c janitor patch 2: handle DEBUG_INSN

2012-11-25 Thread Hans-Peter Nilsson
On Sun, 25 Nov 2012, Steven Bosscher wrote: > stop_search_p will reach the default case on DEBUG_INSN, and the > default case is "gcc_unreachable()". I suppose this means nobody is > using DWARF3+ on a dbr_sched target, it can't possibly ever have > worked. Eric? There must be something else (som

Re: [PATCH] Remove unused DELAY_SLOTS_FOR_EPILOGUE target macro

2012-11-24 Thread Hans-Peter Nilsson
On Sat, 24 Nov 2012, Steven Bosscher wrote: > Hello, > > The DELAY_SLOTS_FOR_EPILOGUE target macro, and the related > ELIGIBLE_FOR_EPILOGUE_DELAY macro, are unused. The attached patch > removes them. > > OK for trunk? Obviously; Jeff Law preapproved their removal long ago. (I forgot about it.) Bu

Re: [PATCH] Allocate extra 16 bytes for -fsanitize=address

2012-11-24 Thread Hans-Peter Nilsson
On Fri, 23 Nov 2012, H.J. Lu wrote: > On Fri, Nov 23, 2012 at 9:38 AM, Jakub Jelinek wrote: > > On Fri, Nov 23, 2012 at 09:23:37AM -0800, H.J. Lu wrote: > >> This patch allocates extra 16 bytes for -fsanitize=address so that > >> asan won't report read beyond memory buffer. It is used by > >> boot

Re: [Patch,testsuite] ad PR52641: More fixes for not-so-common targets

2012-11-24 Thread Hans-Peter Nilsson
On Fri, 23 Nov 2012, Georg-Johann Lay wrote: > Here are some more fixes for 16-bit int and similar. > * gcc.c-torture/execute/20120919-1.x: New file (int32plus). No, you should be able to use dg-directives in the main file these days. (The .x files are obsolete since a few years, IIRC.) br

Committed: handle negative numbers in gcc-gdb-test.exp

2012-11-24 Thread Hans-Peter Nilsson
Without this, I got weird ERRORs and those Tcl backtraces you come to hate, instead of the expected FAILs. Committed as obvious after running a failing guality test and obvserving the intended change. (Well ok, *adding an explanatory comment* is apparently not obvious, but I'll take that liberty..

Re: [PATCH, RFC] Dumping expanded MD files

2012-11-23 Thread Hans-Peter Nilsson
On Thu, 22 Nov 2012, Kirill Yukhin wrote: > Hi folks, > > This patch adds an utility for dumping MD-files after iterators and > define_substs expanding. The new utility is named genmddump and is > built along with other gen* programs. > > I also added new target to Makefile to invoke this utility.

Re: Reduce complette unrolling & peeling limits

2012-11-23 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Jan Hubicka wrote: > > > > this patch reduces max-peeled-insns and max-completely-peeled-insns > > > > from 400 > > > > to 100. The reason why I am doing this is that I want to reduce code > > > > bloat > > > > caused by my cunroll work that enabled a lot more unrolling then

Re: [RFC PATCH] Masked load/store vectorization

2012-11-20 Thread Hans-Peter Nilsson
On Tue, 20 Nov 2012, Jakub Jelinek wrote: > 2012-11-20 Jakub Jelinek > > * Makefile.in (tree-if-conv.o): Depend on $(TARGET_H), $(EXPR_H) > and $(OPTABS_H). > * config/i386/sse.md (maskload, maskstore): New expanders. (etc., new patterns, but nothing for md.texi) Missing docum

Re: [RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-18 Thread Hans-Peter Nilsson
On Mon, 12 Nov 2012, Eric Botcazou wrote: > > This is a target-specific blockage insn, but with the general form > > found in all targets defining it. The default blockage is an empty > > asm-volatile, which is what cse_insn recognized. The blockage insn is > > there to "prevent scheduling" of th

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Paolo Bonzini wrote: > Il 18/11/2012 16:59, Hans-Peter Nilsson ha scritto: > > Nice, but I agree with the other poster that this'd IMHO be > > better as --enable-checking=asan (or actually, > > --enable-checking=all,asan). > > Yeah, that's

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Andreas Tobler wrote: > On 18.11.12 20:11, Hans-Peter Nilsson wrote: > > On Sun, 18 Nov 2012, Andreas Tobler wrote: > >> Is there a minimum gcc to bootstrap current trunk? > >> I currently fail to bootstrap trunk with a 4.2.1 gcc, but a 4.6 > &g

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Andreas Tobler wrote: > Is there a minimum gcc to bootstrap current trunk? > I currently fail to bootstrap trunk with a 4.2.1 gcc, but a 4.6 > succeeds. A gcc-4.1.2 has worked for me in the past, before this recent vec.h change. I think that's the minimum version reportedly w

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Diego Novillo wrote: > My cris-elf builds worked fine, but config-list.mk only builds stage > 1, it does not build libgfortran. Can you give me instructions on how > to build your target on my x86 workstation? Better see the PR for cc1 command-line and preprocessed C-file. b

Re: VEC re-write [patch 01/25]

2012-11-18 Thread Hans-Peter Nilsson
On Sat, 17 Nov 2012, Diego Novillo wrote: > I have now committed all 25 parts of this patch as rev 193595. Please > CC me on any problems that you think may be related to this rewrite. That seems to have trigged some bug in gcc-4.4-era. See PR55381. There are a lot of suspicious warnings from v

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, H.J. Lu wrote: > On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: > > Il 18/11/2012 00:54, H.J. Lu ha scritto: > >> +@if gcc-bootstrap > >> +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) > >> +LIBASAN_LIBS=-B$$r/prev-$(TARGET_SUBDIR)/libsanitizer/asan/.libs > >> +endi

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-17 Thread Hans-Peter Nilsson
On Wed, 14 Nov 2012, Jakub Jelinek wrote: > > Which brings us to the question of what to do with the patch for 4.8. > > It's true that you made the deadline for stage1 closure. But there will > > be no users of this feature, so it begs the question of why we should > > apply it now. Have you a co

Re: [COMMITTED] Move libsanitizer configure logic to subdirectory

2012-11-16 Thread Hans-Peter Nilsson
On Tue, 13 Nov 2012, Richard Henderson wrote: > As discussed elsewhere. Tested on x86_64-linux. > +2012-11-13 Richard Henderson > + > + * configure.ac: Move libsanitizer logic to subdirectory. > + * configure: Regenerate. > + Thanks and sorry for copypasting the wrong pattern in the f

Re: [Committed] Add testcase

2012-11-15 Thread Hans-Peter Nilsson
On Fri, 9 Nov 2012, Andrew Pinski wrote: > Committed the testcase as obvious after a quick test to make sure it > works. Note someone might need to mark the testcase as only > executable on targets which have 32bit ints. Someone like you? There are plenty of greppable effective-target attributes

Regression with "[C++11] PR54413 Option for turning off compiler extensions for numeric literals."

2012-11-14 Thread Hans-Peter Nilsson
> From: Ed Smith-Rowland <3dw...@verizon.net> > Date: Fri, 9 Nov 2012 05:55:16 +0100 > libcpp > > 2012-11-09 Ed Smith-Rowland <3dw...@verizon.net> > > PR c++/54413 > * include/cpplib.h (cpp_interpret_float_suffix): Add cpp_reader* arg. > (cpp_interpret_int_suffix): Add

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
> From: Richard Henderson > Date: Wed, 14 Nov 2012 02:34:32 +0100 > On 11/13/2012 05:20 PM, Hans-Peter Nilsson wrote: > > Right. And, I think it's worth to repeat ;) that IMHO best to > > there simply check that -faddress-sanitizer can compile > > error-free (i.e

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
> From: Richard Henderson > Date: Tue, 13 Nov 2012 21:38:40 +0100 > On 11/13/2012 05:24 AM, Jakub Jelinek wrote: > > Yes. And it shouldn't be just based on target CPU, but also based > > on target OS, I don't think libsanitizer supports anything but linux (glibc > > + maybe android) right now, w

Re: Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-13 Thread Hans-Peter Nilsson
> From: Dodji Seketeli > Date: Tue, 13 Nov 2012 16:04:12 +0100 > I guess when the issue of the missing files is resolved, we can enable > building libsanitizer on Darwin proper. Here is the patchlet I am > proposing so far http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00993.html. That's the dire

Committed: Fix PR55257: g++.dg/debug/dwarf2/non-virtual-thunk.C and heads-up target maintainers

2012-11-12 Thread Hans-Peter Nilsson
...those of you who don't have the equivalent of the patch below in your ports, that is. You'll likely only notice through a slightly reduced debugging experience and g++.dg/debug/dwarf2/non-virtual-thunk.C failing. Yes, the docs should mention these functions need to be called IMHO obviously, bu

Committed: framework bits for disabling libsanitizer. RFC on which targets for which to disable it.

2012-11-12 Thread Hans-Peter Nilsson
While the fallout(*) from the libsanitizer commit is handled, it's obvious it should have a noconfigdirs= section in toplevel/configure.ac like the other target libs. Here's what I committed after observing that a cris-elf build passed, where it previously failed building libsanitizer which wrongl

[RFA:] fix PR55030, wrong code from __builtin_setjmp_receiver

2012-11-11 Thread Hans-Peter Nilsson
The problem exposed in PR55030 (repeatable on x86_64-linux with -m32 at r192676) is that the fake-frame-pointer "frame" is replaced with the actual-frame-pointer "bp" in cse1, around the critical insn in __builtin_setjmp_receiver that restores their defined offset. The patch in PR55030/r192676 rem

Re: patch fixing a test for PR55151

2012-11-08 Thread Hans-Peter Nilsson
On Wed, 7 Nov 2012, Vladimir Makarov wrote: > On 12-11-07 5:27 PM, H.J. Lu wrote: > > You should check !ia32 target: > > > > /* { dg-do compile { target { ! { ia32 } } } } */ > > > > > Thanks, H.J. I've just fixed it. > > Index: testsuite/ChangeLog > ===

Re: [RFA:] PR55186 - gcc.dg/const-uniq-1.c fails due to vector not in the constant pool

2012-11-05 Thread Hans-Peter Nilsson
> From: Eric Botcazou > Date: Mon, 5 Nov 2012 15:29:11 +0100 > > But, for cris-elf (and reasonably the same for other targets) > > there might not be such a constant-pool entry in the first > > place: the vectors are too short to rule out piecewise > > initialization as optimal for size (counting

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-11-04 Thread Hans-Peter Nilsson
On Sun, 4 Nov 2012, Kirill Yukhin wrote: > Hi, > > >> But... I don't really understand it, so here's some feedback on > >> the documentation: Regarding the language, a definite article is > > Patch with fixed doc is attached. Changelog is the same > > Is it OK? The structure is much improved and q

[RFA:] PR55186 - gcc.dg/const-uniq-1.c fails due to vector not in the constant pool

2012-11-02 Thread Hans-Peter Nilsson
Due to weird circumstances detailed in the PR, this test briefly passed (it has always failed before), so technically I'm fixing a regression. :) The test checks that a certain label is mentioned twice; being mentioned once infers that there are two identical initializer vectors in the constant-po

Re: [PATCH] Fix CDDCE miscompilation (PR tree-optimization/55018)

2012-11-01 Thread Hans-Peter Nilsson
> From: Steven Bosscher > Date: Sun, 28 Oct 2012 19:33:29 +0100 > On Mon, Oct 22, 2012 at 11:09 PM, Jakub Jelinek wrote: > > On Mon, Oct 22, 2012 at 10:51:43PM +0200, Steven Bosscher wrote: > > Wouldn't it be way cheaper to just export dfs_find_deadend from cfganal.c > > and call it in calc_dfs_t

Re: [PATCH, generic] New RTL primitive: `define_subst'

2012-10-31 Thread Hans-Peter Nilsson
(CC list trimmed.) On Wed, 31 Oct 2012, Kirill Yukhin wrote: > Hi, > This patch introduces a new RTL expression called define_subst and > required by it define_subst_attr. > > The new feature allows to make MD-files more compact - it defines a > rule by which a parser could generate modified versi

Re: [PATCH 3/3] [asan] Instrument built-in memory access function calls

2012-10-29 Thread Hans-Peter Nilsson
On Wed, 24 Oct 2012, Dodji Seketeli wrote: > Jakub Jelinek writes: > > On Tue, Oct 23, 2012 at 03:11:29PM +0200, Dodji Seketeli wrote: > > > * asan.c (insert_if_then_before_iter) > > > (instrument_mem_region_access) > > > (maybe_instrument_builtin_call, maybe_instrument_call): New static > >

Re: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-22 Thread Hans-Peter Nilsson
On Tue, 23 Oct 2012, Dominique Dhumieres wrote: > This patch (r192676) is probably causing > > FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Os > FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Os > FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Os

Re: Committed: fix gcc.dg/webizer.c (the trivial part :)

2012-10-21 Thread Hans-Peter Nilsson
On Sun, 21 Oct 2012, Andreas Schwab wrote: > Hans-Peter Nilsson writes: > > > I used __builtin_exit just to avoid declarations or includes; > > A "return 0" would have worked just as well. It's not the preferred method. Fail: abort(). Pass: exit(0). Don&#

Committed: fix gcc.dg/webizer.c (the trivial part :)

2012-10-21 Thread Hans-Peter Nilsson
Committed as obvious. Without this, mmix-knuth-mmixware exited with 2256, likely a return-address left over in the return-value-register. I used __builtin_exit just to avoid declarations or includes; the default implicit declaration apparently incompatible with this use. I saw nothing in the relat

Committed: skip testsuite/23_containers/bitset/45713.cc for mmix-*-*.

2012-10-20 Thread Hans-Peter Nilsson
For mmix-knuth-mmixware, MAX_FIXED_MODE_SIZE is the default, GET_MODE_BITSIZE (DImode), which of course isn't larger than the size-type, the same size on this 64-bit target. I don't think making it larger (i.e. TImode) would help: that seems instead likely to introduce awkward spurious non-host_in

Ping: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-20 Thread Hans-Peter Nilsson
CC:ing middle-end maintainers this time. I was a bit surprised when Eric Botcazou wrote in his review, quoted below, that he's not one of you. Maybe approve that too? On Mon, 15 Oct 2012, Hans-Peter Nilsson wrote: > On Fri, 12 Oct 2012, Eric Botcazou wrote: > > > (insn 168

Committed, libgcc MMIX: implement static marking of program and data memory

2012-10-20 Thread Hans-Peter Nilsson
one mem, to simplify counting cycles. - LDBU$255,$1,0 - LDBU$255,$1,1 - PUSHJ $2,_init #ifdef __MMIX_ABI_GNU__ brgds, H-PCopyright 2012 Hans-Peter Nilsson. This file may be freely copied and distributed, provided that no changes whatsoever are made. Ah, just ki

breakage with "[v3] (almost) finish "

2012-10-19 Thread Hans-Peter Nilsson
> From: Jonathan Wakely > Date: Fri, 19 Oct 2012 18:16:51 +0200 > This adds support for piecewise construction of std::pair by > scoped_allocator_adaptor. The only thing missing from > scoped_allocator_adaptor now is that my definition of OUTERMOST isn't > recursive so doesn't work for nested sc

Re: [RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-15 Thread Hans-Peter Nilsson
On Fri, 12 Oct 2012, Eric Botcazou wrote: > > (insn 168 49 51 3 (set (reg/f:DI 253 $253) > > (plus:DI (reg/f:DI 253 $253) > > (const_int 24 [0x18]))) > > /tmp/mmiximp2/gcc/gcc/testsuite/gcc.c-torture/execute/built-in-setjmp.c:21 > > -1 (nil)) > > (insn 51 168 52 3 (clobber (reg/

Committed, MMIX: fix */builtin-apply-2.c for an instrumented setup.

2012-10-15 Thread Hans-Peter Nilsson
When running the test-suite for these tests on an instrumented mmix simulator (plus gcc and newlib patches to match) that, instead of silently allocating zeros, barfs on accesses beyond the defined stack, these tests fail because of that check. There are no stack parameters to copy, so there's jus

Committed, MMIX: fix INCOMING_REGNO / OUTGOING_REGNO for return-value

2012-10-14 Thread Hans-Peter Nilsson
Back then, I must've missed that INCOMING_REGNO / OUTGOING_REGNO are used to map return-value-register/s too. Fixes: FAIL: gcc.dg/builtin-apply4.c execution test ... FAIL: gcc.dg/builtin-return-1.c execution test ... FAIL: gcc.dg/torture/stackalign/builtin-apply-4.c -O0 execution test FAIL: gcc.

[RFA:] Fix frame-pointer-clobbering in builtins.c:expand_builtin_setjmp_receiver

2012-10-11 Thread Hans-Peter Nilsson
The md.texi entry for nonlocal_goto_receiver says "A typical reason why you might need this pattern is if some value, such as a pointer to a global table, must be restored when the frame pointer is restored. Note that a nonlocal goto only occurs within a unit-of-translation, so a global table point

Committed, PR54897 (was: [C++ PATCH] -Wsizeof-pointer-memaccess warning (take 2))

2012-10-11 Thread Hans-Peter Nilsson
> From: Hans-Peter Nilsson > Date: Thu, 11 Oct 2012 02:13:32 +0200 > There's now an "excess error": > > x/libstdc++-v3/testsuite/23_containers/bitset/45713.cc:24:55: > error: size of array 'test' is not an integral constant-expression > int test

Re: PATCH to acinclude.m4 to fix gas version detection

2012-10-10 Thread Hans-Peter Nilsson
On Thu, 4 Oct 2012, Jason Merrill wrote: > Recent versions of binutils seem to have started putting ' around the version > number in bfd/configure.in, which was confusing gcc configure. This patch > allows us to detect the version number again. > > OK for trunk? > I committed my already-approved

Re: [C++ PATCH] -Wsizeof-pointer-memaccess warning (take 2)

2012-10-10 Thread Hans-Peter Nilsson
> From: Jakub Jelinek > Date: Tue, 2 Oct 2012 14:56:29 +0200 > 2012-10-02 Jakub Jelinek > > cp/ > * cp-tree.h (SIZEOF_EXPR_TYPE_P): Define. > * tree.c (cp_tree_equal): Handle SIZEOF_EXPR with > SIZEOF_EXPR_TYPE_P. ...etc. Looks like this caused a regression; PR54897,

Re: libbacktrace patch committed: Trace through shared libraries

2012-10-10 Thread Hans-Peter Nilsson
On Tue, 9 Oct 2012, Ian Lance Taylor wrote: > It's an incorrect warning from an old version of GCC. Fixed like so. > Bootstrapped and ran libbacktrace testsuite on > x86_64-unknown-linux-gnu. Committed to mainline. Another two in libbackend/elf.c, committed as obvious after build passed the poin

Re: libbacktrace patch committed: Trace through shared libraries

2012-10-09 Thread Hans-Peter Nilsson
On Tue, 9 Oct 2012, Ian Lance Taylor wrote: > Patch bootstrapped and ran libbacktrace and Go testsuites on > x86_64-unknown-linux-gnu. Committed to mainline. Trying x86_64 host gcc 4.1.2 (--target=rl78-elf but not the issue) at r192285: /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONF

Build failure with "[PATCH] PR 53528 c++/ C++11 Generalized Attribute support"

2012-10-08 Thread Hans-Peter Nilsson
> From: Dodji Seketeli > Date: Mon, 8 Oct 2012 14:12:04 +0200 > Jason Merrill writes: > > > OK. > > Thanks. Committed to trunk at revision r192199. This caused a build failure, see PR54860. brgds, H-P

Committed, MMIX: fix a port-bug outputting constants, improving test-results.

2012-10-07 Thread Hans-Peter Nilsson
Fixing this bug, which effectively caused 0 to be emitted instead of constants requiring more than one actual insn to generate (through the base-plus-offset support, kind-of macro insns), i.e. like "LDA $2,#0lx" instead of "LDA $2,#ff", gets rid of 193 of the regressions from (some-early-ti

Breakage with "[v3] patch, configuring GCC --disable-libgomp causes libstdc++ abi check to fail."

2012-09-28 Thread Hans-Peter Nilsson
> MIME-Version: 1.0 > From: Benjamin De Kosnik > Date: Fri, 28 Sep 2012 22:02:46 +0200 > There's no reason for this unintentional ABI breakage with this > configure flag. > 2012-09-28 Benjamin Kosnik > > * acinclude.m4 (GLIBCXX_ENABLE_PARALLEL): Remove ENABLE_PARALLEL. > * i

Re: [patch] PR54645 move location_adhoc_data map into GC

2012-09-24 Thread Hans-Peter Nilsson
On Fri, 21 Sep 2012, Dehao Chen wrote: > This patch moves location_adhoc_data into GC, and also rebuild the > hash table when reading in the PCH. After the patch, PCH can work as > expected. > > Bootstrapped and passed gcc regression tests on x8664_linux. If you have a moment to consider improveme

Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

2012-09-20 Thread Hans-Peter Nilsson
On Thu, 20 Sep 2012, Georg-Johann Lay wrote: > Hans-Peter Nilsson wrote: > > Georg-Johann Lay wrote: > >> mode_dependent_address_p is not sensitive to the address space of the > >> passed > >> address. Thus, add an addr_space_t parameter to the hook. >

Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p

2012-09-20 Thread Hans-Peter Nilsson
On Thu, 20 Sep 2012, Georg-Johann Lay wrote: > mode_dependent_address_p is not sensitive to the address space of the passed > address. Thus, add an addr_space_t parameter to the hook. Borderline obvious. :) (J/k; the added functionality seems obvious but the implementation may have non-obvious i

Re: [committed] Fix g++.dg/debug/dwarf2/nested-3.C to handle hppa assembler comment

2012-09-18 Thread Hans-Peter Nilsson
> From: John David Anglin > Date: Sun, 16 Sep 2012 19:13:19 +0200 > This adjusts the regexp to work on hppa. Tested on hppa2.0w-hp-hpux11.11 > and hppa64-hp-hpux11.11. Committed to trunk. > 2012-09-16 John David Anglin > > PR debug/54460 > * g++.dg/debug/dwarf2/nested-3.C: Add

Re: [PATCH,mmix] convert to constraints.md

2012-09-14 Thread Hans-Peter Nilsson
On Wed, 12 Sep 2012, Hans-Peter Nilsson wrote: > On Wed, 12 Sep 2012, Nathan Froyd wrote: > > > - Keeping old layout of "mmix_reg_or_8bit_operand". That looked like > > > a spurious change and I prefer the ior construct to the > > > if_then_else. >

Re: [PATCH,mmix] convert to constraints.md

2012-09-12 Thread Hans-Peter Nilsson
On Wed, 12 Sep 2012, Nathan Froyd wrote: > - Original Message - > > Nathan, again thanks. There are a few minor tweaks compared to your > > version: > > Thanks for fixing this up! > > > - Keeping old layout of "mmix_reg_or_8bit_operand". That looked like > > a spurious change and I pref

Re: [PATCH,mmix] convert to constraints.md

2012-09-11 Thread Hans-Peter Nilsson
On Fri, 31 Aug 2012, Hans-Peter Nilsson wrote: > On Fri, 3 Aug 2012, Hans-Peter Nilsson wrote: > Sorry, but I need more time to get > test-results for a recent trunk revision to a state where > testing patches makes sense. I'll test the patch and commit > that or a variant.

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-08 Thread Hans-Peter Nilsson
Oleg Endo wrote: > On Thu, 2012-09-06 at 14:41 +0200, Georg-Johann Lay wrote: > > The change is definitely in the right direction, but I wonder > > how it helps to fix code bloats of 300%-400% as in PR52543? > > I'm not familiar with the AVR parts. > BTW, There was a small change in lower-subreg wh

Re: [PATCH] Add -fmem-report-wpa

2012-09-08 Thread Hans-Peter Nilsson
On Thu, 6 Sep 2012, Andi Kleen wrote: > From: Andi Kleen > Passed bootstrap and testsuite on x86_64. > +++ b/gcc/lto/lto.c > @@ -2016,6 +2016,8 @@ do_whole_program_analysis (void) >/* Show the LTO report before launching LTRANS. */ >if (flag_lto_report) > print_lto_report (); > +

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Hans-Peter Nilsson
On Tue, 4 Sep 2012, Oleg Endo wrote: > On Mon, 2012-09-03 at 01:58 +0200, Oleg Endo wrote: > > OKOK -- I'll do it :) > > (within the next couple of days) > > > > And so I did. Attached is an updated patch that adds the address space > parameter to the address_cost function. I hope that this chan

Re: [PATCH][RFC] Add -Og

2012-09-04 Thread Hans-Peter Nilsson
On Mon, 3 Sep 2012, Richard Guenther wrote: > On Fri, Aug 10, 2012 at 1:30 PM, Richard Guenther wrote: > > > > This adds a new optimization level, -Og, as previously discussed. > > It aims at providing fast compilation, a superior debugging > > experience and reasonable runtime performance. Inste

ping [RFA:] fix configury version checks for in-tree binutils

2012-09-02 Thread Hans-Peter Nilsson
Ping with CC to build maintainers. (Further pings, if any are needed, will be with URL only.) On Sun, 26 Aug 2012, Hans-Peter Nilsson wrote: > Found while investigating PR54373. A combined tree (in-tree binutils) > using binutils post-2.22 is semi-broken at the moment: the version of

Re: Fold VEC_PERM_EXPR a little more

2012-09-02 Thread Hans-Peter Nilsson
On Sat, 1 Sep 2012, Marc Glisse wrote: > gcc/ > * fold-const.c (fold_ternary_loc): Constant-propagate after > removing dead operands. > > gcc/testsuite/ > * gcc.dg/fold-perm.c: Improve test. (adding a line and a parameter to the function containing the test-code) JFTR: generally

Re: [PATCH,mmix] convert to constraints.md

2012-08-31 Thread Hans-Peter Nilsson
On Fri, 3 Aug 2012, Hans-Peter Nilsson wrote: > On Thu, 2 Aug 2012, Nathan Froyd wrote: > > H-P, if you'd like to test beforehand, that'd be great. > > ...yes, I'd like to test this before, please. Thanks for your > work. (Let's set a timeout at the end

Re: out-of-line and arch-specific random_device

2012-08-30 Thread Hans-Peter Nilsson
> From: Ulrich Drepper > Date: Tue, 28 Aug 2012 05:57:08 +0200 This patch (commit r190787) broke build for non-_GLIBCXX_USE_RANDOM_TR1 targets. (See libstdc++-v3/configure.ac and its crossconfig.m4 for a list.) > Index: libstdc++-v3/include/bits/random.h > ==

Re: [MIPS, committed] Add missing COSTS_N_INSNS call.

2012-08-29 Thread Hans-Peter Nilsson
On Wed, 29 Aug 2012, Richard Sandiford wrote: > Richard Sandiford writes: > > I'm testing a patch to make the testsuite work out the default > > -m{no,}synci, which ought to be enough. The usual rules should > > then kick in and force -mno-synci where necessary. Hopefully. > > Here's the patch.

Re: [PATCH] rs6000: Add a builtin to read the time base register on PowerPC

2012-08-29 Thread Hans-Peter Nilsson
On Wed, 29 Aug 2012, Michael Meissner wrote: > On Wed, Aug 29, 2012 at 01:56:05PM -0400, Hans-Peter Nilsson wrote: > > On Wed, 29 Aug 2012, Segher Boessenkool wrote: > > > On some systems the timebase runs at a rather low frequency, say 20MHz. > > > This test will spur

Re: [PATCH] rs6000: Add a builtin to read the time base register on PowerPC

2012-08-29 Thread Hans-Peter Nilsson
On Wed, 29 Aug 2012, Segher Boessenkool wrote: > > +++ b/gcc/testsuite/gcc.target/powerpc/ppc-get-timebase.c > > @@ -0,0 +1,22 @@ > > +/* { dg-do run { target { powerpc*-*-* } } } */ > > + > > +/* Test if __builtin_ppc_get_timebase() is compatible with the current > > + processor and if it's chan

Re: [google/gcc-4_7, trunk] Fix problem with -fdebug-types-section and template instantiations, take 2

2012-08-28 Thread Hans-Peter Nilsson
On Tue, 28 Aug 2012, Cary Coutant wrote: > 2012-08-28 Cary Coutant > > * gcc/dwarf2out.c (clone_tree_partial): Remove. > (copy_decls_walk): Don't copy children of a declaration > into a type unit. Can't say anything about the patch but watch out with the changelog entry: put

Re: [MIPS, committed] Add missing COSTS_N_INSNS call.

2012-08-28 Thread Hans-Peter Nilsson
On Tue, 28 Aug 2012, Richard Sandiford wrote: > Hans-Peter Nilsson writes: > > On Sun, 26 Aug 2012, Richard Sandiford wrote: > >> I'm preparing a patch to turn gcc.target/mips into a torture-like > >> testsuite. > > > > While on the subject of gcc

Re: [MIPS, committed] Add missing COSTS_N_INSNS call.

2012-08-27 Thread Hans-Peter Nilsson
On Sun, 26 Aug 2012, Richard Sandiford wrote: > I'm preparing a patch to turn gcc.target/mips into a torture-like > testsuite. While on the subject of gcc.target/mips and its extensions, it also doesn't handle a build configured with --with-synci=yes. (Well, not on the 4.7 branch at least.) brgds

To-be-committed: correct out-of-tree .hidden support for mmix-knuth-mmixware

2012-08-26 Thread Hans-Peter Nilsson
GCC configure should say that the linker does *not* support .hidden. For static-only linking (the only mode supported on this simulator-only system) this shouldn't really matter. But, different code is actually used (not just the attribute-hidden decorations), so different bugs are exposed. Like

To-be-committed: fix configure case when assembler COMDAT group support is lacking

2012-08-26 Thread Hans-Peter Nilsson
If the out-of-tree target assembler supports neither: .section .text,"axG",@progbits,.foo,comdat (tsk tsk no leading space, though that's a red herring) nor: .section .text,"axG",%progbits,.foo,comdat then gcc/configure.ac drops through into the system-specific case seen in the patch, where for *-*

<    4   5   6   7   8   9   10   11   12   >