rbalamohan commented on a change in pull request #1340:
URL: https://github.com/apache/hive/pull/1340#discussion_r464815905
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTableLoader.java
##
@@ -125,13 +126,24 @@ public void
jcamachor commented on a change in pull request #1325:
URL: https://github.com/apache/hive/pull/1325#discussion_r464764059
##
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java
##
@@ -53,6 +53,34 @@
private static final Logger LOG =
shameersss1 commented on pull request #1271:
URL: https://github.com/apache/hive/pull/1271#issuecomment-668367912
@kgyrtkirk @jcamachor Could you please take a look?
This is an automated message from the Apache Git Service.
dengzhhu653 commented on pull request #1242:
URL: https://github.com/apache/hive/pull/1242#issuecomment-668366427
Hi @pvary, Is there anything I can do to move this forward?
This is an automated message from the Apache Git
viirya commented on pull request #1356:
URL: https://github.com/apache/hive/pull/1356#issuecomment-668358395
cc @sunchao
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
viirya opened a new pull request #1356:
URL: https://github.com/apache/hive/pull/1356
### What changes were proposed in this pull request?
This PR proposes to shade Guava from hive-exec in Hive 2.3 branch.
### Why are the changes needed?
When trying to
github-actions[bot] closed pull request #1021:
URL: https://github.com/apache/hive/pull/1021
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jcamachor commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464729855
##
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java
##
@@ -49,6 +50,8 @@
import com.google.common.collect.Lists;
import
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464722308
##
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java
##
@@ -205,7 +205,9 @@
DROP_MAPPING("DROP MAPPING",
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464722096
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/type/TypeCheckProcFactory.java
##
@@ -283,6 +283,33 @@ public Object process(Node nd, Stack
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464722011
##
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java
##
@@ -49,6 +50,8 @@
import com.google.common.collect.Lists;
import
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464721831
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/PrepareStatementAnalyzer.java
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464714632
##
File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java
##
@@ -1619,6 +1620,9 @@ public static ColStatistics
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464713600
##
File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out
##
@@ -0,0 +1,1575 @@
+PREHOOK: query: explain extended prepare pcount from
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464710291
##
File path: ql/src/test/results/clientpositive/llap/prepare_plan.q.out
##
@@ -0,0 +1,1575 @@
+PREHOOK: query: explain extended prepare pcount from
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464709177
##
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/ExprDynamicParamDesc.java
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software
jcamachor commented on pull request #1147:
URL: https://github.com/apache/hive/pull/1147#issuecomment-668281996
@maheshk114 , thanks for addressing the first batch of comments. PR looks
better. I have done a second pass and left some additional comments that should
be addressed before
jcamachor commented on a change in pull request #1147:
URL: https://github.com/apache/hive/pull/1147#discussion_r464673502
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java
##
@@ -747,6 +747,8 @@ public static RewritablePKFKJoinInfo
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464701187
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java
##
@@ -0,0 +1,377 @@
+/*
+ * Licensed to the Apache
vineetgarg02 commented on a change in pull request #1315:
URL: https://github.com/apache/hive/pull/1315#discussion_r464698359
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/drop/ExecuteStatementAnalyzer.java
##
@@ -0,0 +1,377 @@
+/*
+ * Licensed to the Apache
vihangk1 commented on a change in pull request #1355:
URL: https://github.com/apache/hive/pull/1355#discussion_r464689406
##
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##
@@ -3258,8 +3260,19 @@ public Partition createPartition(Table tbl, Map partSpec)
kishendas opened a new pull request #1355:
URL: https://github.com/apache/hive/pull/1355
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was
jcamachor merged pull request #1326:
URL: https://github.com/apache/hive/pull/1326
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mustafaiman commented on a change in pull request #1352:
URL: https://github.com/apache/hive/pull/1352#discussion_r464532531
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/wrapper/VectorHashKeyWrapperGeneral.java
##
@@ -262,6 +255,138 @@ private void
mustafaiman commented on a change in pull request #1352:
URL: https://github.com/apache/hive/pull/1352#discussion_r464523610
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java
##
@@ -514,7 +526,8 @@ private void
zabetak commented on a change in pull request #1331:
URL: https://github.com/apache/hive/pull/1331#discussion_r464505336
##
File path:
itests/util/src/main/java/org/apache/hadoop/hive/ql/dataset/QTestDatasetHandler.java
##
@@ -84,23 +83,25 @@ public boolean initDataset(String
zabetak commented on a change in pull request #1331:
URL: https://github.com/apache/hive/pull/1331#discussion_r464503259
##
File path:
itests/util/src/main/java/org/apache/hadoop/hive/ql/dataset/QTestDatasetHandler.java
##
@@ -52,8 +51,8 @@
private File datasetDir;
kuczoram commented on a change in pull request #1327:
URL: https://github.com/apache/hive/pull/1327#discussion_r464501671
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java
##
@@ -115,6 +115,10 @@ void runCompactionQueries(HiveConf conf,
scarlin-cloudera opened a new pull request #1354:
URL: https://github.com/apache/hive/pull/1354
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
###
kgyrtkirk closed pull request #1250:
URL: https://github.com/apache/hive/pull/1250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kgyrtkirk commented on pull request #1341:
URL: https://github.com/apache/hive/pull/1341#issuecomment-668089074
@pvary could you please take another look?
This is an automated message from the Apache Git Service.
To respond
pvargacl commented on pull request #1230:
URL: https://github.com/apache/hive/pull/1230#issuecomment-668087223
@pvary could you merge this?
This is an automated message from the Apache Git Service.
To respond to the message,
jcamachor closed pull request #1333:
URL: https://github.com/apache/hive/pull/1333
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pvargacl commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464483465
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +126,217 @@
*/
private long visibilityTxnId;
+
pvargacl commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464476338
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +126,217 @@
*/
private long visibilityTxnId;
+
pvargacl commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464473125
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -1641,28 +1645,26 @@ public int
pvargacl commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464472005
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +126,217 @@
*/
private long visibilityTxnId;
+
jcamachor closed pull request #1317:
URL: https://github.com/apache/hive/pull/1317
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jcamachor merged pull request #1351:
URL: https://github.com/apache/hive/pull/1351
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jcamachor merged pull request #1328:
URL: https://github.com/apache/hive/pull/1328
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jcamachor merged pull request #1349:
URL: https://github.com/apache/hive/pull/1349
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kasakrisz commented on a change in pull request #1349:
URL: https://github.com/apache/hive/pull/1349#discussion_r464309156
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterJoinRule.java
##
@@ -52,14 +55,34 @@ protected
HunterL closed pull request #1313:
URL: https://github.com/apache/hive/pull/1313
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
abstractdog commented on a change in pull request #1331:
URL: https://github.com/apache/hive/pull/1331#discussion_r464382232
##
File path:
itests/util/src/main/java/org/apache/hadoop/hive/ql/dataset/QTestDatasetHandler.java
##
@@ -52,8 +51,8 @@
private File datasetDir;
kuczoram commented on a change in pull request #1327:
URL: https://github.com/apache/hive/pull/1327#discussion_r464369294
##
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java
##
@@ -261,22 +326,77 @@ protected void
kuczoram commented on a change in pull request #1327:
URL: https://github.com/apache/hive/pull/1327#discussion_r464368518
##
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java
##
@@ -217,6 +224,64 @@ void
szehonCriteo opened a new pull request #1353:
URL: https://github.com/apache/hive/pull/1353
…om a parquet file
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing
kuczoram commented on a change in pull request #1327:
URL: https://github.com/apache/hive/pull/1327#discussion_r464313931
##
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java
##
@@ -95,6 +98,10 @@ private void
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464312615
##
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java
##
@@ -618,7 +618,13 @@ public void testMultipleInserts() throws Exception {
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464311382
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -1641,28 +1645,26 @@ public int
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464310228
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +126,217 @@
*/
private long visibilityTxnId;
+
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464309265
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java
##
@@ -1574,20 +1577,23 @@ public int
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464308530
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##
@@ -2493,7 +2514,7 @@ private static Path chooseFile(Path baseOrDeltaDir,
FileSystem
dengzhhu653 closed pull request #1205:
URL: https://github.com/apache/hive/pull/1205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464306341
##
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidInputFormat.java
##
@@ -118,70 +126,217 @@
*/
private long visibilityTxnId;
+
szlta commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464303366
##
File path:
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java
##
@@ -250,18 +255,71 @@ public void testGetOrcTailForPath()
pvary commented on a change in pull request #1339:
URL: https://github.com/apache/hive/pull/1339#discussion_r464304647
##
File path:
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java
##
@@ -250,18 +255,71 @@ public void testGetOrcTailForPath()
jdere commented on pull request #1350:
URL: https://github.com/apache/hive/pull/1350#issuecomment-667863766
@prasanthj thanks for pointing that out - I've tried to update the patch to
use hive.query.name
This is an
klcopp commented on pull request #1346:
URL: https://github.com/apache/hive/pull/1346#issuecomment-667836261
Closed and reopened to rerun tests
This is an automated message from the Apache Git Service.
To respond to the
klcopp closed pull request #1346:
URL: https://github.com/apache/hive/pull/1346
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
shameersss1 commented on a change in pull request #1328:
URL: https://github.com/apache/hive/pull/1328#discussion_r464215422
##
File path:
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JdbcRecordIterator.java
##
@@ -59,9 +62,26 @@ public
61 matches
Mail list logo