[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003765#comment-17003765
]
Claude Warren commented on COLLECTIONS-728:
---
There may be some disconnect here. The
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003600#comment-17003600
]
Gilles Sadowski commented on COLLECTIONS-728:
-
{quote}we may have to agree to disagree
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003589#comment-17003589
]
Claude Warren commented on COLLECTIONS-728:
---
I think we may have to agree to disagree on
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002067#comment-17002067
]
Gilles Sadowski commented on COLLECTIONS-728:
-
bq. how do you propose to move the hash
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001911#comment-17001911
]
Claude Warren commented on COLLECTIONS-728:
---
I think I am confused. Without resorting to
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001889#comment-17001889
]
Gilles Sadowski commented on COLLECTIONS-728:
-
bq. CachingHasher (from another project)
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001847#comment-17001847
]
Claude Warren commented on COLLECTIONS-728:
---
I don't think that isCompataible() as a
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001053#comment-17001053
]
Gilles Sadowski commented on COLLECTIONS-728:
-
{quote}When Shapes or BloomFilters that
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001015#comment-17001015
]
Claude Warren commented on COLLECTIONS-728:
---
The hash computation is used in the Hasher
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000951#comment-17000951
]
Gilles Sadowski commented on COLLECTIONS-728:
-
{quote}properties are now tracked in the
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1748#comment-1748
]
Claude Warren commented on COLLECTIONS-728:
---
In all the work I have done with Bloom
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996909#comment-16996909
]
Gilles Sadowski commented on COLLECTIONS-728:
-
{quote}I would like to avoid that
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996742#comment-16996742
]
Claude Warren commented on COLLECTIONS-728:
---
I think there may be a nomenclature issue
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996728#comment-16996728
]
Gilles Sadowski commented on COLLECTIONS-728:
-
{quote}{{HashFunction}}
{quote}
I still
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996674#comment-16996674
]
Claude Warren commented on COLLECTIONS-728:
---
I have added HashFunctionIdentity to replace
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16996508#comment-16996508
]
Claude Warren commented on COLLECTIONS-728:
---
Yes, I have hashers that depend on the
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993591#comment-16993591
]
Gilles Sadowski commented on COLLECTIONS-728:
-
Would methods {{getName()}},
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990888#comment-16990888
]
Claude Warren commented on COLLECTIONS-728:
---
The idea of using ID's for each provider/hash
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990850#comment-16990850
]
Alex Herbert commented on COLLECTIONS-728:
--
{quote}it would make more sense to follow the
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990840#comment-16990840
]
Claude Warren commented on COLLECTIONS-728:
---
The issue of broken hashes is a problem and I
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990829#comment-16990829
]
Gilles Sadowski commented on COLLECTIONS-728:
-
{quote}The naming is intended to provide
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990798#comment-16990798
]
Claude Warren commented on COLLECTIONS-728:
---
Hasher names:
The Shape of the Bloom filter
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990667#comment-16990667
]
Gilles Sadowski commented on COLLECTIONS-728:
-
bq. you know all the possible values. We
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990597#comment-16990597
]
Claude Warren commented on COLLECTIONS-728:
---
Mutability: I think all issues are fixed
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990552#comment-16990552
]
Gilles Sadowski commented on COLLECTIONS-728:
-
About mutability:
* Couldn't {{shape}}
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990527#comment-16990527
]
Claude Warren commented on COLLECTIONS-728:
---
*API Issue*
The Hash function takes a buffer
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990468#comment-16990468
]
Gilles Sadowski commented on COLLECTIONS-728:
-
Thanks; we are getting closer...
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985141#comment-16985141
]
Gilles Sadowski commented on COLLECTIONS-728:
-
I don't think that it is Commons practice
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970260#comment-16970260
]
Claude Warren commented on COLLECTIONS-728:
---
Any more comments on this contribution?
>
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965626#comment-16965626
]
Claude Warren commented on COLLECTIONS-728:
---
Updated PR with following notes:
I added
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965284#comment-16965284
]
Claude Warren commented on COLLECTIONS-728:
---
I will provide update the PR with the
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964906#comment-16964906
]
Gilles Sadowski commented on COLLECTIONS-728:
-
{quote}The API always requires both
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964893#comment-16964893
]
Claude Warren commented on COLLECTIONS-728:
---
Quick note:
I somewhat get the rationale
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964861#comment-16964861
]
Gilles Sadowski commented on COLLECTIONS-728:
-
Thanks for explaining again.
I somewhat
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964753#comment-16964753
]
Claude Warren commented on COLLECTIONS-728:
---
=== From the conversation above ===
Why
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964093#comment-16964093
]
Gilles Sadowski commented on COLLECTIONS-728:
-
bq. Yep, this was just a new look at a
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962970#comment-16962970
]
Claude Warren commented on COLLECTIONS-728:
---
I originally answered this in an email, but
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962154#comment-16962154
]
Gilles Sadowski commented on COLLECTIONS-728:
-
bq. implementation
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961433#comment-16961433
]
Alex Herbert commented on COLLECTIONS-728:
--
{quote}your second match is incorrect. Match is
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961283#comment-16961283
]
Claude Warren commented on COLLECTIONS-728:
---
Based on the feedback and questions I have
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960025#comment-16960025
]
Alex Herbert commented on COLLECTIONS-728:
--
Following on from a conversation had on GitHub
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960002#comment-16960002
]
Gilles Sadowski commented on COLLECTIONS-728:
-
bq. there is nothing in it that allows
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959847#comment-16959847
]
Alex Herbert commented on COLLECTIONS-728:
--
Looking at BloomFilter.java class there is
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955201#comment-16955201
]
Claude Warren commented on COLLECTIONS-728:
---
BF_Func.md is a list of bloom filter
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946214#comment-16946214
]
Claude Warren commented on COLLECTIONS-728:
---
Looking at the Log, distance, and some of the
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946183#comment-16946183
]
Claude Warren commented on COLLECTIONS-728:
---
BloomCollectionStatistics should be called
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945857#comment-16945857
]
Gilles Sadowski commented on COLLECTIONS-728:
-
bq. other implementations of BloomFilter.
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945717#comment-16945717
]
Claude Warren commented on COLLECTIONS-728:
---
I am working to clean up the issues that
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942393#comment-16942393
]
Gilles Sadowski commented on COLLECTIONS-728:
-
Thanks for the removal of
[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942269#comment-16942269
]
Claude Warren commented on COLLECTIONS-728:
---
Updated pull request to include latest
50 matches
Mail list logo
