RE: [PATCH] doc: add emergency-call-handling.txt

2011-04-19 Thread Jeevaka.Badrappan
Hi Bertrand, ofono-boun...@ofono.org wrote: > Hi Jeevaka, > > One 'minor bug', I guess that there is a missing 'Post SIM > and Post online atoms are not created.' For case 2. > Good catch. > And one question. For case 2 and 3, the 'Modem remains in > online mode but the functionalities will b

RE: Retrieve ofono_sim_password_type

2011-04-08 Thread Jeevaka.Badrappan
Hi Christophe, > Hi, > > I need to map ofono_sim_password_type according to h24 AT command manual. > > Can somebody check if I mapped correctly enum with documentation definition. > > OFONO_SIM_PASSWORD_SIM_PIN : PIN attempts > > OFONO_SIM_PASSWORD_SIM_PUK,

RE: [RFC PATCH 0/9] Emergency Mode

2011-03-31 Thread Jeevaka.Badrappan
Hi Marcel, ofono-boun...@ofono.org wrote: > Hi Jeevaka, > >> Following patch is a proposal for emergency mode. Test has been >> done with the phonesim. >> >> Listed down few important cases to give an overview of the state >> changes that happen in each case. > > and I think we should turn th

RE: [PATCH v2 2/4] voicecall: refactor emergency number list handling

2011-03-30 Thread Jeevaka.Badrappan
Hi Denis, Denis Kenzior wrote: > Hi Jeevaka, > >> void emit_en_list_changed(struct ofono_voicecall *vc) static void >> set_new_ecc(struct ofono_voicecall *vc) { >> int i = 0; >> +GSList *l; >> >> g_slist_foreach(vc->en_list, (GFunc) g_free, NULL); >> g_slist_free(vc->en_list); @

RE: [PATCH 1/2] stk: fix issue with null data object

2011-03-11 Thread Jeevaka.Badrappan
Hi Andrew, Andrzej Zaborowski wrote: > Hi Jeevaka > > On 7 March 2011 16:35, Jeevaka Badrappan > wrote: >> As per the specification, if alphad identifier is provided and is a >> null data object, no information should be given to the user. > > What do do you think of the following change? > >

RE: [PATCH 2/2] stkutil: fix issue with null data object

2011-03-08 Thread Jeevaka.Badrappan
Hi Andrew, ofono-boun...@ofono.org wrote: > Hi Jeevaka, > > On 7 March 2011 16:35, Jeevaka Badrappan > wrote: >> --- >>  src/stkutil.c |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/src/stkutil.c b/src/stkutil.c index abd1c99..66b2924 >> 100644 --- a/src/stkut

RE: [PATCH] atmodem: Enable network time for AT modem

2011-03-08 Thread Jeevaka.Badrappan
Hi Marcel, ofono-boun...@ofono.org wrote: > Hi Antti, > >> drivers/atmodem/network-registration.c |2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/atmodem/network-registration.c >> b/drivers/atmodem/network-registration.c >> index 4913611..2d589f0 100644

RE: [PATCH] atmodem: Enable network time for AT modem

2011-03-08 Thread Jeevaka.Badrappan
Hi Aki, ofono-boun...@ofono.org wrote: > Hi Jeevaka, > > On Tue, 2011-03-08 at 12:35 +0200, ext > jeevaka.badrap...@elektrobit.com > wrote: >> This log is taken some time back. Possible that Network Daylight >> Saving Time is received as part of the MM information message whereas >> it may not be

RE: [PATCH] atmodem: Enable network time for AT modem

2011-03-08 Thread Jeevaka.Badrappan
Hi Antti, ofono-boun...@ofono.org wrote: > Hi Jeevaka, > > On Tue, 2011-03-08 at 10:59 +0200, ext > jeevaka.badrap...@elektrobit.com > wrote: >> Hi Antti, >> >> ofono-boun...@ofono.org wrote: >>> --- >>> drivers/atmodem/network-registration.c |2 ++ >>> 1 files changed, 2 insertions(+), 0 d

RE: [PATCH] atmodem: Enable network time for AT modem

2011-03-08 Thread Jeevaka.Badrappan
Hi Antti, ofono-boun...@ofono.org wrote: > --- > drivers/atmodem/network-registration.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/atmodem/network-registration.c > b/drivers/atmodem/network-registration.c > index 4913611..2d589f0 100644 > --- a/drivers

RE: [RFC] doc: Add support for CMAS/EU-Alert

2011-02-21 Thread Jeevaka.Badrappan
Hi Rajesh, ofono-boun...@ofono.org wrote: > Hi Jeeva, > > Is this WarningType really required on the App side ? > Irrespective of the warning type, the emergency broadcast > message handling won't change on the apps side (i.e, its > going to be displayed immediately to the user). This can be > ac

RE: [PATCH] plugin: add plugin for Linktop/Teracom LW273 data card

2011-02-10 Thread Jeevaka.Badrappan
Hi Amit, ofono-boun...@ofono.org wrote: > Hi Amit, > > On 02/09/2011 10:56 AM, Amit Mendapara wrote: >> Hi Danis, >> >> I have submitted three patches as you suggested but no one has >> reviewed it. Would you tell me what else I can do to ensure it's >> been integrated in ofono? >> > > So it

RE: [PATCH v3 4/4] ifxmodem: move call creation to xcallstat_notify

2011-02-08 Thread Jeevaka.Badrappan
Hi Denis, Denis Kenzior wrote: > > So if you really insist on creating the call with a > particular id, you might as well make that a parameter of the > create_call function. However, do note that you still have one > potential problem. > If the ATD callback returns before the call is signaled,

RE: [PATCH] ifxmodem: refactor call status notifications

2011-02-05 Thread Jeevaka.Badrappan
Hi all, Badrappan Jeevaka wrote: > --- > drivers/ifxmodem/voicecall.c | 197 > +++--- > 1 files changed, 90 insertions(+), 107 deletions(-) > Ignore this patch. Regards, Jeevaka ___ ofono mailing list ofono@ofono.

RE: [PATCH 3/4] nettime: Documentation

2011-02-01 Thread Jeevaka.Badrappan
Hi Antti, ofono-boun...@ofono.org wrote: > --- > doc/network-time-api.txt | 36 > 1 files changed, 36 insertions(+), 0 deletions(-) create > mode 100644 doc/network-time-api.txt > > diff --git a/doc/network-time-api.txt > b/doc/network-time-api.txt new fil

RE: [PATCH 0/2] Fix issue with DST

2011-02-01 Thread Jeevaka.Badrappan
ofono-boun...@ofono.org wrote: > On Tuesday 01 February 2011 13:44:03 ext Jeevaka Badrappan, you wrote: >> Hi, >> >> Following patch converts the DST from hours to seconds which is the >> expected outcome. > > Is it? I think DST is just a boolean. Refere 3GPP TS 24.008 section 10.5.3.12 Regard

RE: [RFC] doc: Proposal for LTE/IMS API.

2011-01-28 Thread Jeevaka.Badrappan
Hi Sjur, ofono-boun...@ofono.org wrote: > > - SIM identities used for IMS registration such as: > PrivateImsIdentity, PublicImsIdentity, HomeDomainName. Correct me if I'm wrong. Private Identity is the one used for registration, authorisation, administration and billing purposes whereas the P

RE: SAT support in oFono

2011-01-21 Thread Jeevaka.Badrappan
Hi Lasse, ofono-boun...@ofono.org wrote: > Hi > > I am checking what is the level of SAT/STK support in ofono > and have a couple of questions. The current implementation > contains support for basic STK commands, like menus, inputs, > calls, sms and so on. In TODO, there is only REFRESH command

RE: [PATCH 4/4] atmodem: sim-auth atom driver.

2011-01-20 Thread Jeevaka.Badrappan
Hi Andrzej, ofono-boun...@ofono.org wrote: > +static void at_discover_apps_cb(gboolean ok, GAtResult *result, > + gpointer user_data) +{ > + struct cb_data *cbd = user_data; > + GAtResultIter iter; > + ofono_sim_list_apps_cb_t cb = cbd->cb; > + struct of

RE: [PATCH 1/1] atmodem: add ifx support for pin retries query

2011-01-17 Thread Jeevaka.Badrappan
Hi Lucas, Lucas De Marchi wrote: > this happens to work for -1, but bear in mind memset "fills > the first n bytes of the memory area". Considering > sizeof(int) == 4, it will set each byte to -1, which happens > to be -1 considering all 4 bytes too. But imo this is just > being lucky. > > In my

RE: [PATCH v3 2/2] plugins: add ctm create to ifx plugin

2011-01-13 Thread Jeevaka.Badrappan
Hi Marcel, ofono-boun...@ofono.org wrote: > Hi Jeevaka, > >> plugins/ifx.c |2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/plugins/ifx.c b/plugins/ifx.c index c0a69c2..08b0001 >> 100644 --- a/plugins/ifx.c >> +++ b/plugins/ifx.c >> @@ -57,6 +57,7 @@ >> #includ

RE: [RFC 2/4] stk: Handle Launch Browser proactive command

2011-01-13 Thread Jeevaka.Badrappan
Hi, >> >> So a question about this.  Why are we checking the netreg atom? >> Shouldn't we be checking the gprs atom's attached property?  But this >> brings up an even more interesting question, do we even need to >> assume that we have to be attached to the cellular network to >> perform these o

RE: [RFC 3/5] voicecall: Add ofono_voicecall_tty_notify api

2011-01-13 Thread Jeevaka.Badrappan
Hi Kai Vehmanen, ofono-boun...@ofono.org wrote: > not later, but as part of standard call setup. E.g. on ISI, > CTM is a property of a voice call. And this makes sense as > TTY calls _are_ essentially voice calls, with just a bit > indicating to the network that the voice circuit should be > free

RE: [RFC 3/5] voicecall: Add ofono_voicecall_tty_notify api

2011-01-12 Thread Jeevaka.Badrappan
Hi Marcel, ofono-boun...@ofono.org wrote: >> Main reason for separate notification function is to avoid going >> through all the cases handled inside voicecall_notify. TTY field in >> ofono_call is basically for the GetProperties. > > I see. So here is the main question that comes from this now.

RE: [PATCH 2/2] ifxmodem: add enable/disable ctm support

2011-01-12 Thread Jeevaka.Badrappan
Hi Marcel, ofono-boun...@ofono.org wrote: >> +static void xctms_modify_cb(gboolean ok, GAtResult *result, >> gpointer +user_data) { + struct cb_data *cbd = user_data; >> +ofono_ctm_set_cb_t cb = cbd->cb; >> +struct ofono_error error; >> +const char *setting = NULL; >> +struct o

RE: [RFC 3/5] voicecall: Add ofono_voicecall_tty_notify api

2011-01-12 Thread Jeevaka.Badrappan
Hi Marcel, ofono-boun...@ofono.org wrote: > Hi Jeevaka, > >> include/voicecall.h |2 ++ >> src/voicecall.c | 12 >> 2 files changed, 14 insertions(+), 0 deletions(-) >> >> diff --git a/include/voicecall.h b/include/voicecall.h index >> e37d73b..6f1bdd2 100644 --- a/includ

RE: [PATCH] stkutil: fix crash issue cause by null length of text string

2010-12-07 Thread Jeevaka.Badrappan
Hi Guillaume, > > According to 3GPP TS 31.124 a null length for the text string > should be allowed. An empty string must be returned to the > user in this case. > --- > src/stkutil.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) > Agree. As per the 3GPP TS 31.124 null

RE: [PATCH 1/7] call-forwarding: Read/Write cfis/cphs-cff

2010-12-07 Thread Jeevaka.Badrappan
Hi Denis, > > + ofono_bool_t online; > > Why do you need to track this variable? Can't you simply > call ofono_modem_get_online()? > This way calling of ofono_modem_get_online for each get or set request can be avoided. Regards, Jeevaka ___ ofon

RE: [PATCH 4/4] TODO: Marking the Barred Dialing task as done

2010-12-06 Thread Jeevaka.Badrappan
Hi Sankar, > Then as per your email, the support provided in Ofono seems to be limited. If there is no enable or disable is allowed, > I am not sure, how we can we have a card in which FDN enabled, which will force the ofono to enter presim state. Unless there is no > option to disable at, foreve

RE: [PATCH 4/4] TODO: Marking the Barred Dialing task as done

2010-12-06 Thread Jeevaka.Badrappan
Hi Sankar, > Is there a way for the clients to enable or disable the Fixed Dialling? I assume they should be able to do this by using the dbus calls, "LockPin/UnlockPin". Is there a > way to store the FDN numbers in the sim card? How does ofono validate the request to be passed to the network wh

RE: [PATCH 3/3] stk: Handle provide local info proactive command

2010-11-30 Thread Jeevaka.Badrappan
Hi Yang, > > +static void get_time(struct stk_response *rsp) { > + time_t now; > + struct tm *t; > + > + time(&now); > + t = localtime(&now); > + > + rsp->result.type = STK_RESULT_TYPE_SUCCESS; > + > + if (t->tm_year > 100) > + rsp->provide_local_info.dateti

RE: [PATCH] stk: Add busy error for the display text command

2010-11-30 Thread Jeevaka.Badrappan
Hi Guillaume, > > > > Denis on IRC also wondered if this response should be > allowed when the > > message is flagged urgent. > > > > According to the spec I think no, this type of response is > not allowed when the message is fluffed urgent. > As per the ETSI TS 102 223 V9.0.0 section 6

RE: [RFC 7/7] doc: Add new property to call forwarding

2010-11-25 Thread Jeevaka.Badrappan
Hi Sankar, > As per the specification, querying of group of supplementary services is not allowed. Do you propose a solution where core queries all the three call forwardings namely > CF busy, CF Not Reachable, CF noreply and updating the clients with the status using the above property after re

RE: [PATCH] isi: Fix issue in call forwarding erase response

2010-11-24 Thread Jeevaka.Badrappan
Hi Aki, > > I think the problem is that we try to decode the alpha tag > even when it is not present, i.e., when _numlen is zero. > > In fact, this has already been fixed in my current working > tree in a bit different way. Mostly due to the fact that I added a new > g_isi_sb_iter_get_struct

RE: [PATCH 1/2] stk: provide access technology info

2010-11-18 Thread Jeevaka.Badrappan
Hi Yang, > + > +unsigned int __ofono_netreg_get_tech(struct ofono_netreg *netreg) { > + GSList *o; > + unsigned int techs = 0; > + struct network_operator_data *opd; > + > + for (o = netreg->operator_list; o; o = o->next) { > + opd = o->data; > + techs |= o

Identification of Active Application in UICC card

2010-10-18 Thread Jeevaka.Badrappan
Hi, According to 3GPP specification 3GPP TS 31.102 section 5.1.1 USIM application selection, "After UICC activation, the ME selects a USIM application. If no EFDIR file is found or no USIM applications are listed in the EFDIR file, the ME may then try to select the GSM application as specified in

RE: Handling of Fixed Dialing

2010-10-07 Thread Jeevaka.Badrappan
Hi Petteri, > and thanks for the comments. > I checked the invalidated-flag of EFadn (from file status-byte of GET RESPONSE) and it actually changed according to FDN-enabling/disabling. But for some reason I didn't > got any change in EFsst for FDN/ADN-services. Could it be a good idea to add

RE: Handling of Fixed Dialing

2010-10-06 Thread Jeevaka.Badrappan
Hi Petteri, > First patch checks if Fixed Dialing is enabled in the SIM-card by reading FD-activated bit from EFsst or EFest. If FDN is enabled, SIM initialization procedure is stopped, > and modem will stay in the PRE-SIM state. > If FD is enabled, this is signaled via DBUS. > I haven't been ab

RE: [RFC PATCH 1/4] sim: check if FD is enabled in the SIM-card

2010-10-01 Thread Jeevaka.Badrappan
Hi Petteri, +static void at_barring_query_enabled(struct ofono_sim *sim, + ofono_sim_locked_cb_t cb, void *data) { + struct sim_data *sd = ofono_sim_get_data(sim); + struct cb_data *cbd = cb_data_new(cb, data); + char buf[64]; + + if (!cbd) +

RE: [PATCH] phonesim: simulate Send USSD in sim app

2010-09-29 Thread Jeevaka.Badrappan
Hi Denis, Marcel, > what was wrong with the clear indication that this patch is messed up. > > This patch comes from a stupid Windows system that tries to change > every single mode to 0755. Please fix this. > Whoops, my fault totally missed this. I wonder if there are git settings that can

RE: [PATCH 5/5] cf: Handle send ss proactive command

2010-09-21 Thread Jeevaka.Badrappan
Hi Yang, > --- a/src/stk.c > +++ b/src/stk.c > + unsigned char addnl[2]; > + > + default: > + DBG("Send ss finishes with error type: %d", error->type); > + rsp.result.type = STK_RESULT_TYPE_SS_RETURN_ERROR; > + addnl[0] = (unsigned char) error->error; >

RE: Reg: Memory capacity exceeded

2010-09-20 Thread Jeevaka.Badrappan
Hi Denis, > The thing is, oFono configures SMS for direct delivery (e.g. no SM/ME storage). And even if direct delivery does not work (e.g. crappy modem or Class 2 / Class 3 messages) oFono still removes the SMS > as soon as it is delivered. We should never hit a sim/me memory full conditions

RE: Reg: Memory capacity exceeded

2010-09-20 Thread Jeevaka.Badrappan
Hi, > Of course, one can argue whether this feature really has some real > world relevance or is purely theoretical. > > I wonder if it is a type approval requirement to support? > I'm afraid there is a PICS case for this thing. I cannot recall how we got N900 through this particular hoop, but p

RE: Reg: Memory capacity exceeded

2010-09-20 Thread Jeevaka.Badrappan
Hi Marcel, > If device memory capacity is over there is a way to set HLR about > memory capacity exceeded. > But in Ofono I didn't find any indication regarding memory capacity > exceeded for class 1 messages. > > Is this feature is going to be added in future? please let me know. > when you

RE: [PATCH 0/1] stk: Handle send ss proactive command

2010-09-15 Thread Jeevaka.Badrappan
Hi Yang, > Below is the description: > This patch is to handle send ss proactive command from SIM. > Currently when sending a supplementary service control string via D-Bus, a series of functions would be called. For example, if we want to send a call barring activatioin string via D-Bus, these

RE: [PATCH 1/2] Internal and Driver API changes for Send USSD proactive command

2010-09-07 Thread Jeevaka.Badrappan
Hi Denis, > > - else if (charset == SMS_CHARSET_8BIT) { > - /* TODO: Figure out what to do with 8 bit data */ > + if (charset == SMS_CHARSET_7BIT) { > + switch (data->charset) { > + case AT_UTIL_CHARSET_GSM: > + msg = convert_gsm_

RE: [PATCH 2/2] stk and stkutil changes for Send USSD proactivecommand

2010-09-06 Thread Jeevaka.Badrappan
Hi Andrew, > What is the meaning of that -1? I don't see this value handled in stkutil. If dcs is -1, then the text is assumed to be in UTF-8. Will add the -1 handling in stkutil.h > The rest of this patch looks okay to me, but you have some formatting > issues: space after '(' above, and

RE: Patch: "Added missing DCS handling in stkutil and stk" Description

2010-09-06 Thread Jeevaka.Badrappan
Hi Denis, Andrzej, > Actually the spec is deviating from the intended purpose of the Text data object (which > should contain Text), so handling it specifically is actually better. I have incorported the comments as part of the Patch "stk and stkutil changes for Send USSD proactive command". A

Patch: "Added missing DCS handling in stkutil and stk" Description

2010-09-02 Thread Jeevaka.Badrappan
Hi, The following patch "Added missing DCS handling in stkutil and stk" handles the missing dcs case as: As per 3GPP TS 31.111 section 8.15 Text string structure requires dcs and text string to be sent. Current stkutil function and data structure is missing the dcs information. In this patch,

RE: [PATCH 07/11] added stk_response_text_string for USSD result

2010-09-02 Thread Jeevaka.Badrappan
Hi, > On irc we figured that the best hint about what is expected to be returned is in the tests in 31.124. +CUSD returns sms-like DCS, while STK expects Cell Broadcast-like DCS and recommends using only the > values 00, 04, 08, so there needs to be a translation from one to the other (perhaps

RE: [PATCH 02/11] Changes done as per the changed driver API

2010-09-02 Thread Jeevaka.Badrappan
Hi Pekka, > I thought the modem already unpacks the ussd message to 8-bit gsm and the dcs parameter is rather meaningless in that case. Perhaps the atmodem ussd should re-pack the string in order to achieve the > desired symmetry on the API? Agree that the modem already unpacks the string rece

RE: Clarification on USSD support in ofono

2010-09-01 Thread Jeevaka.Badrappan
Hi Denis, > Can you send what you have so far to the list? Andrew and Yang are actually already looking into this, so it might be nice for the three of you to be on the same page and not duplicate effort. I'm sending the patches for the Send USSD proactive command handling. I have tested the c

RE: Clarification on USSD support in ofono

2010-08-31 Thread Jeevaka.Badrappan
Hi, > Can you send what you have so far to the list? Andrew and Yang are actually already looking into this, so it might be nice for the three of you to be on the same page and > not duplicate effort. Ok, I'll try to send the patch by today. Thanks and Regards, Jeevaka -

RE: Clarification on USSD support in ofono

2010-08-31 Thread Jeevaka.Badrappan
Hi Denis, > The original USSD API actually did look like this. It used binary data > + dcs field. However, we quickly found that all modems are screwed up > in this area. The specification added binary PDU mode to SMS and CBS, but never bothered with USSD. So all modems get this part wrong.

RE: Clarification on USSD support in ofono

2010-08-31 Thread Jeevaka.Badrappan
Hi, > Yes, the driver api may need a change like this. The current API was created based on the fact that many modems don't understand anything other than DCS = 15. However > with STK's "Send USSD" command, sending the requested DCS as-is is probably our best bet. > There is a hope that most

RE: Clarification on USSD support in ofono

2010-08-31 Thread Jeevaka.Badrappan
Hi Marcel > you have me confused now. Are you talking about the D-Bus based API towards applications or the SIM Toolkit support? > SIM Toolkit is something totally different. Even for SMS we just deal with raw PDUs there. While the user side applications over D-Bus will never get access to the

RE: Clarification on USSD support in ofono

2010-08-31 Thread Jeevaka.Badrappan
Hi Marcel, > Currently, oFono expects the USSD string in UTF-8. ofono(Atom driver > - AT or ISI) converts the UTF-8 string to GSM 7-bit default alphabet > and sends it to the network. In this way, we will always send the data > coding scheme as GSM 7-bit default alphabet or whatever the char

Clarification on USSD support in ofono

2010-08-31 Thread Jeevaka.Badrappan
Hi, Currently, oFono expects the USSD string in UTF-8. ofono(Atom driver - AT or ISI) converts the UTF-8 string to GSM 7-bit default alphabet and sends it to the network. In this way, we will always send the data coding scheme as GSM 7-bit default alphabet or whatever the character set modem is

RE: [PATCH] sim: Ensure to call sim_pin_check

2010-08-25 Thread Jeevaka.Badrappan
Hi Yang Gu, > In current code, sim_pin_check() is called inside sim_efpl_read_cb(). > However, there may be a chance it would never be called, thus the modem won't be initialized correctly. > --- > src/sim.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > diff --git a/src/sim.