[kudu-CR](branch-0.10.x) Change to non-SNAPSHOT version on 0.10.x branch

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Change to non-SNAPSHOT version on 0.10.x branch .. Change to non-SNAPSHOT version on 0.10.x branch Change-Id: I3f8f60893a426388c7c257ae165f9f7e34142d5a Re

[kudu-CR] Bump version to 1.0.0-SNAPSHOT

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Bump version to 1.0.0-SNAPSHOT .. Bump version to 1.0.0-SNAPSHOT Change-Id: I555d01b7704f4bd71559207520b68f64d58cd66c Reviewed-on: http://gerrit.cloudera.

[kudu-CR](branch-0.10.x) Change to non-SNAPSHOT version on 0.10.x branch

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Change to non-SNAPSHOT version on 0.10.x branch .. Patch Set 1: Verified+1 Same dist-test/isolate flakiness seen earlier -- To view, visit http://gerrit.cloudera

[kudu-CR](branch-0.10.x) Change to non-SNAPSHOT version on 0.10.x branch

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Change to non-SNAPSHOT version on 0.10.x branch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4001 To unsubscribe, visit http://g

[kudu-CR] Bump version to 1.0.0-SNAPSHOT

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Bump version to 1.0.0-SNAPSHOT .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4000 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/16/src/kudu/tablet/compaction.cc File src/kud

[kudu-CR](branch-0.10.x) Change to non-SNAPSHOT version on 0.10.x branch

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Change to non-SNAPSHOT version on 0.10.x branch .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2945/ -- To view, visit http://gerrit.cloude

[kudu-CR](branch-0.10.x) Change to non-SNAPSHOT version on 0.10.x branch

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/4001 Change subject: Change to non-SNAPSHOT version on 0.10.x branch .. Change to non-SNAPSHOT version on 0.10.x branch Change-Id: I3f8f60893a4

[kudu-CR] Bump version to 1.0.0-SNAPSHOT

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Bump version to 1.0.0-SNAPSHOT .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2944/ -- To view, visit http://gerrit.cloudera.org:8080/4000

[kudu-CR] Bump version to 1.0.0-SNAPSHOT

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4000 to review the following change. Change subject: Bump version to 1.0.0-SNAPSHOT .. Bump version to 1.0.0-SNAPSHOT Chang

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/2943/ -- To view, visit http://gerrit.cloude

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#17). Change subject: KUDU-236 (part 1). Implement tablet history GC .. KUDU-236 (par

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/3076/16/src/kudu/tablet/compaction-test.cc File sr

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/3076/16/src/kudu/tablet/compaction-test.cc File s

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add time/watermark based garbage collection to ResultTracker .. Add time/watermark based garbage collection to ResultTracker This adds time and watermark

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Start a background thread to run ResultTracker GC .. Start a background thread to run ResultTracker GC Change-Id: Ia34ce95e78920596eb8b9db53643845f637c8e6

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Verified+1 the test failure was some weird dist-test flakiness that I'm looking into

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tool: rewrite parser logic .. tool: rewrite parser logic While leaf and non-leaf actions share some common properties, there is much they don't share. Rat

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/result_tracker.

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3996 To unsubscribe, visit http://gerrit.cloudera.org:8

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/re

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: > looks good but the patch it's based on seems to have exploded. Yeah, I rebased to switch the order around. And I thoug

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2942/ -- To view, visit http://gerrit.cloudera.org:8080/3996 To u

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3996 To unsubscribe, visit http://gerrit.cloudera.org:8

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 2: looks good but the patch it's based on seems to have exploded. -- To view, visit http://gerrit.cloudera.org:8080/3996

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: integration_tests: end-to-end master permanent failure test .. integration_tests: end-to-end master permanent failure test This commit defines a workflow

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3969 To unsubscribe, v

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: kicked off dist-test runs with 1000 of each of the integration tests here: http://dis

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#18). Change subject: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 18: Build Started http://104.196.14.100/job/kudu-gerrit/2941/ -- To view, visit http:/

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: (6 comments) http://gerrit.cloudera.org:8080/#/c/3628/17/src/kudu/rpc/CMakeLists.txt

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: Yea, gerrit's poor at dealing with renames. git show -M does a better job. For your

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3952 to look at the new patch set (#8). Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. KUDU-456

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2940/ -- To view, visit http://gerrit.cl

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [util/monotime] added handy operators for MonoTime .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2939/ -- To view, visit http://gerrit.clo

[kudu-CR] [util/monotime] added handy operators for MonoTime

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3999 Change subject: [util/monotime] added handy operators for MonoTime .. [util/monotime] added handy operators for MonoTime Change-Id: Ia8a

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#16). Change subject: KUDU-236 (part 1). Implement tablet history GC .. KUDU-236 (par

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2938/ -- To view, visit http://gerrit.cloude

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 15: > > > Could you also add a GCing thread to mt-tablet-test? It's a > good > > > way to test interac

[kudu-CR] Support downgrade to version that has LocalConsensus

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Support downgrade to version that has LocalConsensus .. Patch Set 2: > Can you please give this a manual test as part of voting on 0.10 RC? Sure, no problem. --

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: (6 comments) It's pretty tough to review exactly_once_rpc-test.cc since gerrit is sho

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3996 to look at the new patch set (#2). Change subject: tool: rewrite parser logic .. tool: rewrite parser

[kudu-CR] catalog manager: avoid more races between Init() and GetTabletPeer()

2016-08-15 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3997 to review the following change. Change subject: catalog_manager: avoid more races between Init() and GetTabletPeer() .

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3969 to look at the new patch set (#4). Change subject: integration_tests: end-to-end master permanent failure test

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2936/ -- To view, visit http://gerrit.cloudera.org:8080/3996 To u

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3996/1/src/kudu/tools/tool_action.h File src/kudu/tools/tool_action.h:

[kudu-CR] catalog manager: avoid more races between Init() and GetTabletPeer()

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: catalog_manager: avoid more races between Init() and GetTabletPeer() .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2937/ -- To view, visi

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2935/ -- To view, visit http://g

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1474: single to multi-master deployment migration .. KUDU-1474: single to multi-master deployment migration This patch introduces the machinery needed

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: fs: allow format with user-specified uuid .. fs: allow format with user-specified uuid The CLI tool is going to use this for the "handling permanent failur

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 5: Verified+1 The test failure was unrelated, and I've got a patch ready to go for it. -- To view, visit ht

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3076 to look at the new patch set (#15). Change subject: KUDU-236 (part 1). Implement tablet history GC .. KUDU-236 (par

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2934/ -- To view, visit http://gerrit.cloude

[kudu-CR] KUDU-236 (part 1). Implement tablet history GC

2016-08-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-236 (part 1). Implement tablet history GC .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/3076/14/src/kudu/tablet/compaction.cc File src/kudu

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3996/1/src/kudu/tools/tool_action.h File src/kudu/tools/tool_action.h:

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3969 To unsubscribe, v

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3880 To unsubscribe, visit

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3968 To unsubscribe, visit http://gerrit

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3968/4/src/kudu/util/oid_generator-test.cc File src/kudu/

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tool: rewrite parser logic .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2933/ -- To view, visit http://gerrit.cloudera.org:8080/3996 To u

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3969 to look at the new patch set (#3). Change subject: integration_tests: end-to-end master permanent failure test .. i

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2932/ -- To view, visit http://g

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-15 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3880 to look at the new patch set (#7). Change subject: KUDU-1474: single to multi-master deployment migration .. KUDU-1

[kudu-CR] tool: rewrite parser logic

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new change for review. http://gerrit.cloudera.org:8080/3996 Change subject: tool: rewrite parser logic .. tool: rewrite parser logic While leaf and non-leaf actions share some common properties, ther

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2931/ -- To view, visit http://gerrit

[kudu-CR] KUDU-1474: single to multi-master deployment migration

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1474: single to multi-master deployment migration .. Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/3880/6/src/kudu/gutil/strings/join.h File s

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3968 to look at the new patch set (#5). Change subject: fs: allow format with user-specified uuid .. fs: al

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2930/ -- To view, visit http://gerrit.cloudera.org

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 4: (1 comment) LGTM except for nit http://gerrit.cloudera.org:8080/#/c/3968/4/src/kudu/util/oid_generator-

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc F

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3961 To unsubscribe, visit http:/

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Another pass on 0.10.0 release notes .. Patch Set 3: k, i just committed, we can do one more patch, but want to get an RC out soon. -- To view, visit http://gerr

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Another pass on 0.10.0 release notes .. Another pass on 0.10.0 release notes Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9 Reviewed-on: http://gerr

[kudu-CR] integration tests: end-to-end master permanent failure test

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: integration_tests: end-to-end master permanent failure test .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3969/2/src/kudu/tools/tool_action.cc F

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/2929/ -- To view, visit http:/

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3961 to look at the new patch set (#5). Change subject: Start a background thread to run ResultTracker GC ..

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#17). Change subject: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3968 To unsubscribe, visit http://gerrit

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2928/ -- To view, visit http://gerrit.clou

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: (8 comments) http://gerrit.cloudera.org:8080/#/c/3628/15/src/kudu/integration-tests/

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3968 to look at the new patch set (#4). Change subject: fs: allow format with user-specified uuid .. fs: allow format wi

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2927/ -- To view, visit http://gerrit.cloudera.org

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3968/2/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_mana

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: fs: allow format with user-specified uuid .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2926/ -- To view, visit http://gerrit.cloudera.org

[kudu-CR] fs: allow format with user-specified uuid

2016-08-15 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3968 to look at the new patch set (#3). Change subject: fs: allow format with user-specified uuid .. fs: allow format wi

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3961 To unsubscribe, visit http:/

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Another pass on 0.10.0 release notes .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3979/2/docs/release_notes.adoc File docs/release

[kudu-CR] KUDU-526: use on-disk cmeta when loading existing master state

2016-08-15 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-526: use on-disk cmeta when loading existing master state .. KUDU-526: use on-disk cmeta when loading existing master state The cmeta is populated whe

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: (8 comments) http://gerrit.cloudera.org:8080/#/c/3628/15/src/kudu/integration-tests/

[kudu-CR] KUDU-456 Implement AUTO FLUSH BACKGROUND flush mode

2016-08-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-456 Implement AUTO_FLUSH_BACKGROUND flush mode .. Patch Set 6: (7 comments) Thank you for the review! I posted a new version (patchset 7) because the LINT

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Start a background thread to run ResultTracker GC .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2924/ -- To view, visit http://gerrit.clou

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2925/ -- To view, visit http:/

[kudu-CR] Start a background thread to run ResultTracker GC

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3961 to look at the new patch set (#4). Change subject: Start a background thread to run ResultTracker GC .. Start a bac

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3628 to look at the new patch set (#16). Change subject: Add time/watermark based garbage collection to ResultTracker

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/15/src/kudu/rpc/service_if.cc F

[kudu-CR] Add time/watermark based garbage collection to ResultTracker

2016-08-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add time/watermark based garbage collection to ResultTracker .. Patch Set 15: (7 comments) http://gerrit.cloudera.org:8080/#/c/3628/15//COMMIT_MSG Commit Message:

[kudu-CR] Improvements and corrections to Impala CREATE TABLE examples

2016-08-15 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has submitted this change and it was merged. Change subject: Improvements and corrections to Impala CREATE TABLE examples .. Improvements and corrections to Impala CREATE TABLE examples Change-Id: I093972a7b

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-15 Thread Misty Stanley-Jones (Code Review)
Misty Stanley-Jones has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3638/1/docs/index.adoc File docs/index.adoc:

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-15 Thread Misty Stanley-Jones (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3638 to look at the new patch set (#3). Change subject: KUDU-1517 Implement doc feedback from Sue M .. KUDU-1517 Impleme

[kudu-CR] KUDU-1517 Implement doc feedback from Sue M

2016-08-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1517 Implement doc feedback from Sue M .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2923/ -- To view, visit http://gerrit.cloudera.o

  1   2   >