Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review122479 --- Fix it, then Ship it! Would love to commit this asap, but we *n

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 8:13 a.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 44441: Treated command as executable value and arguments in mesos-execute.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review122487 --- Patch looks great! Reviews applied: [1] Passed command: expo

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122488 --- Fix it, then Ship it! docs/weights.md (lines 51 - 53)

Re: Review Request 43863: Move the implementation of updateWeights out of header.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review122490 --- Ship it! Ship It! - Adam B On Feb. 27, 2016, 4:43 a.m., Yong

Re: Review Request 43863: Move the implementation of updateWeights out of header.

2016-03-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/#review122493 --- Fix it, then Ship it! src/master/weights.hpp (line 35)

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
> On March 3, 2016, 1:03 a.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2607-2609 > > > > > > I'm an ESL, but having both "per weight" and "by weight" sounds a bit > > strang

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122494 --- Fix it, then Ship it! Just a bunch a grammar fixes. Otherwise s

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
> On March 4, 2016, 6:45 a.m., Bernd Mathiske wrote: > > > > Joseph Wu wrote: > I also noticed a couple of these: > ``` > MesosSchedulerDriver driver( > &sched, DEFAULT_FRAMEWORK_INFO, master.get()->pid, > DEFAULT_CREDENTIAL); > ``` > Now fixed (there were two spac

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- (Updated March 8, 2016, 11:27 a.m.) Review request for mesos and Adam B. Chan

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-08 Thread Abhishek Dasgupta
> On March 4, 2016, 6:55 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni.cpp, line 61 > > > > > > Add a `+` at the end. While not necessary, makes it more readable. > > Qian Zha

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review122502 --- Fix it, then Ship it! src/tests/scheduler_event_call_tests.cpp

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? > > Joseph Wu wrote: > In this

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review122504 --- Ship it! Ship It! - Bernd Mathiske On March 4, 2016, 3:55 p.

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/ --- (Updated March 8, 2016, 12:10 p.m.) Review request for mesos, Adam B and Alexan

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 12:29 p.m.) Review request for mesos, Michael Park, Nei

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-03-08 Thread Yongqiao Wang
> On March 8, 2016, 8:07 a.m., Adam B wrote: > > src/master/master.hpp, lines 1040-1042 > > > > > > So if I try to update N roles in one request, but I am not authorized > > to update 1, then I would get back a si

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated March 8, 2016, 12:47 p.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review122507 --- Patch looks great! Reviews applied: [42719] Passed command: expo

Re: Review Request 43863: Move the implementation of updateWeights out of header.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43863/ --- (Updated March 8, 2016, 1:05 p.m.) Review request for mesos, Adam B and Alexand

Re: Review Request 42719: Add doc for weights.

2016-03-08 Thread Yongqiao Wang
> On March 8, 2016, 9:19 a.m., Adam B wrote: > > docs/weights.md, lines 22-23 > > > > > > This will have to be updated when we add GET I will update this doc for GET request after addressing #MESOS-4316. - Yongqiao

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 1:19 p.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-03-08 Thread Travis Hegner
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for https://revi

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 1:29 p.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 1:24 p.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 1:33 p.m.) Review request for mesos, Michael Park, Neil

Review Request 44511: Add registry tests for /weights endpoint.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/ --- Review request for mesos and Adam B. Bugs: MESOS-4797 https://issues.apache

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 2:05 p.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 2:08 p.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-03-08 Thread Travis Hegner
> On Feb. 9, 2016, 7:13 p.m., Joerg Schad wrote: > > src/docker/docker.cpp, line 307 > > > > > > Are these additional checks which should apply in both cases (i.e. > > deprecated and new `addressLocation`? I.e. prio

Re: Review Request 43920: Added a helper function to stout : os/which.hpp.

2016-03-08 Thread Disha Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/ --- (Updated March 8, 2016, 2:22 p.m.) Review request for mesos and Joseph Wu. Bu

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/ --- (Updated March 8, 2016, 10:42 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122520 --- Patch looks great! Reviews applied: [43824] Passed command: expo

Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/ --- Review request for mesos and Adam B. Bugs: MESOS-4316 https://issues.apache

Review Request 44513: Added missing flag to authentication docs.

2016-03-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44513/ --- Review request for mesos and Adam B. Repository: mesos Description --- A

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review122528 --- Patch looks great! Reviews applied: [41681, 43863, 41790, 44511]

Review Request 44514: Implemented NetworkCniIsolatorProcess::prepare().

2016-03-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/ --- Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu. Bugs: ME

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/#review122533 --- Bad patch! Reviews applied: [43798, 43792] Failed command: ./sup

Re: Review Request 43798: Added overview section to upgrades.md.

2016-03-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43798/ --- (Updated March 8, 2016, 4:18 p.m.) Review request for mesos, Michael Park, Neil

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-03-08 Thread Timothy Chen
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for https://revi

Re: Review Request 43093: MESOS-4370 NetworkSettings.IPAddress field is deprectaed in Docker

2016-03-08 Thread Travis Hegner
> On March 7, 2016, 5:36 p.m., Timothy Chen wrote: > > Are you still be able to work on this? We like to get this merged, so if > > you can't or don't reply we will create a new patch based on this. > > Travis Hegner wrote: > Hi Timothy, > > I've been stalling this for https://revi

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/ --- (Updated March 8, 2016, 5:43 p.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 8, 2016, 5:44 p.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-08 Thread Anurag Singh
> On March 3, 2016, 10:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/ --- (Updated March 8, 2016, 5:50 p.m.) Review request for mesos, Adam B, Joerg Scha

Re: Review Request 44474: Improve master tasks metrics.

2016-03-08 Thread Cong Wang
> On March 8, 2016, 12:37 a.m., Ian Downes wrote: > > src/master/master.cpp, line 6461 > > > > > > I'm not familiar with this code but it appears to be changing the > > behavior substantially. > > > > The

Re: Review Request 44474: Improve master tasks metrics.

2016-03-08 Thread Cong Wang
> On March 8, 2016, 12:37 a.m., Ian Downes wrote: > > src/master/metrics.cpp, line 215 > > > > > > foreach? I don't think we can use foreach over enum, can we? - Cong

Re: Review Request 44474: Improve master tasks metrics.

2016-03-08 Thread Cong Wang
> On March 7, 2016, 11:17 p.m., Neil Conway wrote: > > src/master/master.cpp, line 6461 > > > > > > Seems like we use post-increment elsewhere in this RR? I am not sure I understand your question, but post-incremen

Re: Review Request 43920: Added a helper function to stout : os/which.hpp.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/#review122552 --- Patch looks great! Reviews applied: [43920] Passed command: expo

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

2016-03-08 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review122546 --- src/slave/containerizer/mesos/isolators/network/cni.cpp (line 49)

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

2016-03-08 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 8, 2016, 6:10 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 41632: Windows: Added Console Ctrl handling in `slave.cpp`.

2016-03-08 Thread Daniel Pravat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 8, 2016, 6:15 p.m.) Review request for mesos, Alex Naparu, Danie

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/ --- (Updated March 8, 2016, 6:15 p.m.) Review request for mesos, Till Toenshoff and

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-08 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/#review122543 --- src/authorizer/authorizer.cpp (line 44)

Re: Review Request 44319: Removed initialize method from the authorizer interface.

2016-03-08 Thread Vinod Kone
> On March 8, 2016, 1:08 a.m., Vinod Kone wrote: > > include/mesos/authorizer/authorizer.hpp, line 58 > > > > > > seems weird that this interface takes ACLs as a param. can we make it > > take Parameters instead? I t

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/ --- (Updated March 8, 2016, 6:25 p.m.) Review request for mesos, Till Toenshoff and

Re: Review Request 41049: New python lib with only the executor driver.

2016-03-08 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41049/#review122564 --- Sorry for the spam, I added -static-libstdc++ to allow better comp

Review Request 44515: Added agent flags for HTTP authentication.

2016-03-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. Bugs: ME

Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. Bugs: ME

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44360/#review122572 --- Looks good, main thing is just to add some context to the installe

Re: Review Request 44360: Added a script to install the Nvidia GDK on a host.

2016-03-08 Thread Ben Mahler
> On March 8, 2016, 7:15 p.m., Ben Mahler wrote: > > Looks good, main thing is just to add some context to the installer script > > so that others understand why it exists. Could you update the testing done so that others can tell how you tested this? - Ben -

Re: Review Request 44512: Support to get weights info by /weights.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44512/#review122584 --- Patch looks great! Reviews applied: [41681, 43863, 44512] Passed

Re: Review Request 44361: Added configure flags to build with Nvidia GPU support.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44361/#review122582 --- Fix it, then Ship it! Looks good, thanks! configure.ac (lines

Re: Review Request 44513: Added missing flag to authentication docs.

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44513/#review122594 --- Patch looks great! Reviews applied: [44513] Passed command: expo

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- (Updated March 8, 2016, 9:58 p.m.) Review request for mesos, Jie Yu and Travis

Re: Review Request 44363: Added stubs for the Nvidia GPU device isolator.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44363/#review122600 --- Fix it, then Ship it! Looks good thanks, can you ask Jie about

Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- Review request for mesos, Jie Yu and Travis Hegner. Repository: mesos Descrip

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/ --- (Updated March 8, 2016, 9:58 p.m.) Review request for mesos, Jie Yu and Travis

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated March 8, 2016, 2:32 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 8, 2016, 2:33 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-08 Thread Joseph Wu
> On March 8, 2016, 3:50 a.m., Bernd Mathiske wrote: > > src/tests/scheduler_event_call_tests.cpp, line 367 > > > > > > In most other places you have the blank line before the detector. True. Fixed four places in:

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-08 Thread Joseph Wu
> On March 3, 2016, 2:15 p.m., Joseph Wu wrote: > > src/master/contender.hpp, lines 17-18 > > > > > > This whole file seems like a pretty substantial change. I'd recommend > > pulling it out into a separate review (

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122610 --- Ship it! Ship It! - Joseph Wu On March 4, 2016, 5:23 p.m., G

Re: Review Request 44455: Fixed AppcImageFetcherTest for manifest formatting.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44455/ --- (Updated March 8, 2016, 10:45 p.m.) Review request for mesos and Jie Yu. Repo

Review Request 44533: Fixed AppcStoreTest fixture to remove imageId from test image.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44533/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- F

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-08 Thread Vikrama Ditya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122612 --- src/slave/containerizer/containerizer.cpp (line 107)

Review Request 44534: Refactored AppcImageFetcherTest.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44534/ --- Review request for mesos and Jie Yu. Repository: mesos Description --- C

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/ --- (Updated March 8, 2016, 10:49 p.m.) Review request for mesos and Jie Yu. Repo

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44456/ --- (Updated March 8, 2016, 10:50 p.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 43920: Added a helper function to stout : os/which.hpp.

2016-03-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43920/#review122613 --- Looks good. Before I give a "Ship It!", your next steps should be

Re: Review Request 44514: Implemented NetworkCniIsolatorProcess::prepare().

2016-03-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44514/#review122619 --- Patch looks great! Reviews applied: [44004, 44200, 44269, 44514]

Re: Review Request 43824: Addressed comments of 41672.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43824/#review122622 --- src/tests/hierarchical_allocator_tests.cpp (line 233)

Re: Review Request 44364: Added infrastructure for Nvidia GPU specific tests.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44364/#review122624 --- src/tests/containerizer/nvidia_gpu_isolator_tests.cpp (lines 30 -

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-08 Thread Jojy Varghese
> On March 8, 2016, 1:57 a.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_appc_tests.cpp, lines 590-591 > > > > > > Looking at the original code, why do we need this id? Should that > > always be the same

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

2016-03-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review122623 --- src/tests/master_maintenance_tests.cpp (line 481)

Re: Review Request 42705: Update docs for --weights flag and authorization.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42705/#review122625 --- Need to update the --weights flags help message in flags.cpp too.

Re: Review Request 44513: Added missing flag to authentication docs.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44513/#review122626 --- Ship it! Ship It! - Adam B On March 8, 2016, 7:15 a.m., Greg

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review122630 --- src/master/constants.cpp (lines 52 - 53)

Re: Review Request 44363: Added stubs for the Nvidia GPU device isolator.

2016-03-08 Thread Vikrama Ditya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44363/#review122633 --- Ship it! Ship It! - Vikrama Ditya On March 8, 2016, 10:46 p.

Re: Review Request 44531: Fixed parsing network ip address with docker.

2016-03-08 Thread Dan Osborne
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44531/#review122637 --- Ship it! Ship It! - Dan Osborne On March 8, 2016, 10:54 p.m.

Re: Review Request 44365: Added flag to specify available Nvidia GPUs on an agent's command line.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44365/#review122628 --- src/slave/flags.hpp (line 92)

Re: Review Request 44366: Added GPUs as an explicit resource.

2016-03-08 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44366/#review122638 --- Could you update the description to reflect the new state of the c

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 9, 2016, 1:35 a.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 9, 2016, 1:34 a.m.) Review request for mesos and Benjamin Hindma

Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- Review request for mesos. Repository: mesos Description --- MasterConten

Review Request 44544: Moved contender and detector definitions into separate directories.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44544/ --- Review request for mesos. Repository: mesos Description --- Moved conten

Review Request 44545: Separated standalone and zookeeper classes.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- Review request for mesos. Repository: mesos Description --- Instead of k

Re: Review Request 44004: Add 'name' field into NetworkInfo.

2016-03-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44004/ --- (Updated March 9, 2016, 9:38 a.m.) Review request for mesos, Avinash sridharan,

Review Request 44547: Added functions in promises to the collect header.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- Review request for mesos. Repository: mesos Description --- Added functi

Review Request 44546: Moved functions in promises to a common header file.

2016-03-08 Thread Anurag Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- Review request for mesos. Repository: mesos Description --- Moved functi

  1   2   >