Change in vdsm[master]: vdsm.spec: Move mom requirement

2012-12-05 Thread wudxw
Mark Wu has posted comments on this change. Change subject: vdsm.spec: Move mom requirement .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9515 To unsubscribe, visit ht

Change in vdsm[master]: Remove duplicate implementation of prefix2netmask

2012-12-05 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Remove duplicate implementation of prefix2netmask .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/9759 To unsubscribe, visit http://gerrit.ovirt.org

Change in vdsm[master]: Remove duplicate implementation of prefix2netmask

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove duplicate implementation of prefix2netmask .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/223/ : SUCCESS http

Change in vdsm[master]: Remove duplicate implementation of prefix2netmask

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove duplicate implementation of prefix2netmask .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/257/ (2/2)

Change in vdsm[master]: Remove duplicate implementation of prefix2netmask

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove duplicate implementation of prefix2netmask .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/223/ (1/2) -- To view, v

Change in vdsm[master]: Remove duplicate implementation of prefix2netmask

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove duplicate implementation of prefix2netmask .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/222/ : SUCCESS ht

Change in vdsm[master]: Remove duplicate implementation of prefix2netmask

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove duplicate implementation of prefix2netmask .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/256/ (1/2)

Change in vdsm[master]: Remove duplicate implementation of prefix2netmask

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Remove duplicate implementation of prefix2netmask .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/222/ (2/2) -- To view, v

Change in vdsm[master]: Remove duplicate implementation of prefix2netmask

2012-12-05 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Remove duplicate implementation of prefix2netmask .. Remove duplicate implementation of prefix2netmask Change-Id: I113e26ced6dc8d6318ab8e23118fb2394a7257eb Signed-off

Change in vdsm[master]: Added gluster volume top functionalities

2012-12-05 Thread tjeyasin
Timothy Asir has posted comments on this change. Change subject: Added gluster volume top functionalities .. Patch Set 9: No score (2 inline comments) Commit Message Line 3:

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: pep8: comply with E122 and E123 .. pep8: comply with E122 and E123 Signed-off-by: Dan Kenigsberg Change-Id: Iaa9dffbe1cc1c137430ec30148694e01750260a6

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: pep8: comply with E122 and E123 .. Patch Set 2: Looks good to me, approved thanks -- To view, visit http://gerrit.ovirt.org/9730 To unsubscribe, visit http://g

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/221/ : SUCCESS

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/255/

Change in vdsm[master]: Add shutdown based on qemu-ga(qemu guest agent) in vdsm

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/221/ (1/2) -- To v

Change in vdsm[master]: logging: setup log filter correctly

2012-12-05 Thread wudxw
Mark Wu has posted comments on this change. Change subject: logging: setup log filter correctly .. Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Do you know any reason why python doesn't suppo

Change in vdsm[master]: PEP8 cleanup for *.py under vdsm_hooks

2012-12-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP8 cleanup for *.py under vdsm_hooks .. Patch Set 1: No score -- To view, visit http://gerrit.ovirt.org/9734 To unsubscribe, visit http://gerrit.ovirt.org/s

Change in vdsm[master]: PEP8 cleanup for *.py under vdsm_hooks

2012-12-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: PEP8 cleanup for *.py under vdsm_hooks .. Patch Set 1: (2 inline comments) A string literal is changed.

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) sorry, -1 for I did not find "updateDevice" de

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 10: Looks good to me, but someone else must approve (1 inline comment)

Change in vdsm[master]: Extract bonding options building into a separate function.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract bonding options building into a separate function. .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/220/ : SUCC

Change in vdsm[master]: Extract bonding options building into a separate function.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract bonding options building into a separate function. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/220/ (2/2) -- T

Change in vdsm[master]: Extract bonding options building into a separate function.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract bonding options building into a separate function. .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/254

Change in vdsm[master]: Extract bonding options building into a separate function.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract bonding options building into a separate function. .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/219/ : SUCC

Change in vdsm[master]: Extract bonding options building into a separate function.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract bonding options building into a separate function. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/253

Change in vdsm[master]: Extract bonding options building into a separate function.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Extract bonding options building into a separate function. .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/219/ (2/2) -- T

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread shaohef
ShaoHe Feng has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9560 To unsubscribe

Change in vdsm[master]: cpu mode support for vdsm

2012-12-05 Thread wudxw
Mark Wu has posted comments on this change. Change subject: cpu mode support for vdsm .. Patch Set 3: I would prefer that you didn't submit this (3 inline comments) File vds

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: pep8: comply with E122 and E123 .. Patch Set 2: Verified; Looks good to me, but someone else must approve (1 inline comment) Pass autobuild.sh and pydiff. .

Change in vdsm[master]: [WIP] netwiring: [4/4] Add API definitions.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] netwiring: [4/4] Add API definitions. .. Patch Set 17: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/218/ : SUCCESS http://

Change in vdsm[master]: [WIP] netwiring: [4/4] Add API definitions.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] netwiring: [4/4] Add API definitions. .. Patch Set 17: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/218/ (2/2) -- To view, visit

Change in vdsm[master]: [WIP] netwiring: [4/4] Add API definitions.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: [WIP] netwiring: [4/4] Add API definitions. .. Patch Set 17: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/252/ (1/2) -- T

Change in vdsm[master]: [WIP] netwiring: [4/4] Add API definitions.

2012-12-05 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: [WIP] netwiring: [4/4] Add API definitions. .. Patch Set 16: (12 inline comments) File vdsm/API.py

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 6: (1 inline comment) File vdsm/storag

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread abaron
Ayal Baron has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 6: (1 inline comment) File vdsm/storage/imageRe

Change in vdsm[master]: Sometimes the test host is overloaded and that might cause a...

2012-12-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Sometimes the test host is overloaded and that might cause a false positive with such a low timeout .. Sometimes the test host is overloaded and that m

Change in vdsm[master]: Sometimes the test host is overloaded and that might cause a...

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Sometimes the test host is overloaded and that might cause a false positive with such a low timeout .. Patch Set 1: Verified; Looks good to me, approved 5 seco

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8: comply with E122 and E123 .. Patch Set 2: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/vdsm_pep8_gerr

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: pep8: comply with E122 and E123 .. Patch Set 2: oops, no idea how I've failed in the previous patchset. Zhou, please use -1 when you spot an error like that. I

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8: comply with E122 and E123 .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/217/ (1/2) -- To view, visit http://gerrit

Change in vdsm[master]: pep8: comply with E122 and E123

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: pep8: comply with E122 and E123 .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/251/ (2/2) -- To view, visit

Change in vdsm[master]: [WIP] netwiring: [4/4] Add API definitions.

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: [WIP] netwiring: [4/4] Add API definitions. .. Patch Set 16: I would prefer that you didn't submit this (12 inline comments) ..

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 10: Looks good to me, approved (1 inline comment) File

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9560 To unsubscribe, visit http://ger

Change in vdsm[master]: Do not fail when getVSize is called on an inctive LV.

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Do not fail when getVSize is called on an inctive LV. .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) ...

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 6: I would prefer that you didn't submit this (1 inline comment) ...

Change in vdsm[master]: miscTests: Use /var/tmp for O_DIRECT tests

2012-12-05 Thread danken
Dan Kenigsberg has abandoned this change. Change subject: miscTests: Use /var/tmp for O_DIRECT tests .. Patch Set 1: Abandoned no need in this, given the unanimous support for http://gerrit.ovirt.org/#/c/9661/ -- To view, vis

Change in vdsm[master]: dd: use iflag=direct only when supported by the os

2012-12-05 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: dd: use iflag=direct only when supported by the os .. dd: use iflag=direct only when supported by the os Much like as vdsm's use of fileUtils.DirectFil

Change in vdsm[master]: dd: use iflag=direct only when supported by the os

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: dd: use iflag=direct only when supported by the os .. Patch Set 3: Verified; Looks good to me, approved thanks, reviewers. -- To view, visit http://gerrit.ovir

Change in vdsm[master]: sdcache: add refresh to connectStoragePool

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sdcache: add refresh to connectStoragePool .. Patch Set 2: (1 inline comment) File vdsm/storage/sp.py Line

Change in vdsm[master]: pep8 fixes for vdsm file

2012-12-05 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: pep8 fixes for vdsm file .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Fil

Change in vdsm[master]: pep8 fixes for vdsm file

2012-12-05 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: pep8 fixes for vdsm file .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) File

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread agl
Adam Litke has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: Looks good to me, but someone else must approve Waiting on others who participated in the discussion to approv

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep

Change in vdsm[master]: Fix indentation on fileSD

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix indentation on fileSD .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/215/ : SUCCESS http://jenkins.ovirt.org/job

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vds

Change in vdsm[master]: Fix indentation on fileSD

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix indentation on fileSD .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/215/ (2/2) -- To view, visit http://gerrit.ovirt

Change in vdsm[master]: Sometimes the test host is overloaded and that might cause a...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Sometimes the test host is overloaded and that might cause a false positive with such a low timeout .. Patch Set 1: Build Successful http://jenkins.

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_uni

Change in vdsm[master]: Sometimes the test host is overloaded and that might cause a...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Sometimes the test host is overloaded and that might cause a false positive with such a low timeout .. Patch Set 1: Build Started http://jenkins.ovirt

Change in vdsm[master]: Sometimes the test host is overloaded and that might cause a...

2012-12-05 Thread smizrahi
Saggi Mizrahi has uploaded a new change for review. Change subject: Sometimes the test host is overloaded and that might cause a false positive with such a low timeout .. Sometimes the test host is overloaded and that might caus

Change in vdsm[master]: Fix indentation on fileSD

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix indentation on fileSD .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/249/ (1/2) -- To view, visit http:

Change in vdsm[master]: Sometimes the test host is overloaded and that might cause a...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Sometimes the test host is overloaded and that might cause a false positive with such a low timeout .. Patch Set 1: Build Started http://jenkins.ovirt

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 10: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/vdsm_pe

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 10: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/247/ (2/2) -- To view

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 10: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/213/ (1/2) -- To view, visit http:/

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 2: Fails Build Failed http://jenkins.ovirt.org/job/v

Change in vdsm[master]: Fix indentation on fileSD

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix indentation on fileSD .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/211/ : SUCCESS http://jenkins.ovirt.org/j

Change in vdsm[master]: Fix indentation on fileSD

2012-12-05 Thread smizrahi
Saggi Mizrahi has uploaded a new change for review. Change subject: Fix indentation on fileSD .. Fix indentation on fileSD Change-Id: Iadf2ecce62022dba47b6c92186e0aeae7011c813 Signed-off-by: Saggi Mizrahi --- M vdsm/storage/fil

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep

Change in vdsm[master]: Fix indentation on fileSD

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix indentation on fileSD .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/211/ (1/2) -- To view, visit http://gerrit.ovirt

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_uni

Change in vdsm[master]: Fix indentation on fileSD

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Fix indentation on fileSD .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/245/ (2/2) -- To view, visit http:

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 9: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org/job/vdsm_pep

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 9: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/210/ (2/2) -- To view, visit http://

Change in vdsm[master]: netwiring: [3/4] Add cli entry point.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [3/4] Add cli entry point. .. Patch Set 9: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/244/ (1/2) -- To view,

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/v

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_uni

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep

Change in vdsm[master]: Check that underlying filesystem supports direct IO before c...

2012-12-05 Thread smizrahi
Saggi Mizrahi has uploaded a new change for review. Change subject: Check that underlying filesystem supports direct IO before creating a domain on it .. Check that underlying filesystem supports direct IO before creating a doma

Change in vdsm[master]: dd: use iflag=direct only when supported by the os

2012-12-05 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: dd: use iflag=direct only when supported by the os .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9661

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/208/ : SUCCESS http://jenkins.o

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/242/ (2/2) -- To view,

Change in vdsm[master]: netwiring: [2/4] Add API definitions.

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: netwiring: [2/4] Add API definitions. .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/208/ (1/2) -- To view, visit http://

Change in vdsm[master]: netwiring: [1/4] Extend vmInterfaceDevice API def

2012-12-05 Thread agl
Adam Litke has posted comments on this change. Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def .. Patch Set 2: Looks good to me, approved Agreement was reached after discussion on list. Approving. -- To view

Change in vdsm[master]: add emulator pin support to create vm

2012-12-05 Thread lhornyak
Laszlo Hornyak has posted comments on this change. Change subject: add emulator pin support to create vm .. Patch Set 7: Royce: at the moment I am still waiting for the VDSM team to decide which design they would accept :( --

Change in vdsm[master]: Move hsm.validatePoolSD() -> pool.validatePoolSD().

2012-12-05 Thread shuming
Shu Ming has posted comments on this change. Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD(). .. Patch Set 2: I would prefer that you didn't submit this (2 inline comments) ..

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread abaron
Ayal Baron has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9660 To unsubscribe, visit h

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/207/ : SUCCESS htt

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 6: Verified Verified on a storage domain containing _remove_me volumes and broken images.

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/241/ (2/2)

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 6: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/207/ (1/2) -- To view,

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 5: I would prefer that you didn't submit this Build Unstable http://jenkins.ovirt.org

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread fsimonce
Federico Simoncelli has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 5: Verified Verified on a storage domain containing _remove_me volumes and broken images.

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/240/ (1/2)

Change in vdsm[master]: upgrade: reallocate the metadata slots when needed

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: upgrade: reallocate the metadata slots when needed .. Patch Set 5: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/206/ (2/2) -- To view,

Change in vdsm[master]: Move hsm.validatePoolSD() -> pool.validatePoolSD().

2012-12-05 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: Move hsm.validatePoolSD() -> pool.validatePoolSD(). .. Patch Set 2: (1 inline comment) File vdsm/storage/sp.p

Change in vdsm[master]: vdsm startup: fix assert statement

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm startup: fix assert statement .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/205/ : SUCCESS http://jenkins.ovir

Change in vdsm[master]: [WIP] BZ#748386 - refactor qemuConvert to only use qemu-img ...

2012-12-05 Thread ykaplan
Yeela Kaplan has posted comments on this change. Change subject: [WIP] BZ#748386 - refactor qemuConvert to only use qemu-img convert. .. Patch Set 4: I would prefer that you didn't submit this (11 inline comments) A few small

Change in vdsm[master]: vdsm startup: fix assert statement

2012-12-05 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm startup: fix assert statement .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/205/ (2/2) -- To view, visit http://ger

  1   2   >