Francesco Romani has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/55074/5/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 1
Sandro Bonazzola has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1: Verified+1
Users noticed the hook is missing:
http://lists.ovirt.org/pipermail/users/2016-August/041794.h
gerrit-hooks has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is require
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: build also vhostmd hook
..
automation: build also vhostmd hook
In 3.6 we shipped vdsm-hook-vhostmd as part of our VDSM releases.
In 4.0 this hook
Nir Soffer has posted comments on this change.
Change subject: tests: Introduce FakeSanlock
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/62265/1//COMMIT_MSG
Commit Message:
Line 7: tests: Introduce FakeSanlock
Lin
Nir Soffer has posted comments on this change.
Change subject: storage: domainMonitor.getAllHostIds() API
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61997/2//COMMIT_MSG
Commit Message:
Line 20: The
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6: Code-Review-1
(6 comments)
The actual code looks very nice, but __eq__ is completely wrong.
https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
(4 comments)
Generally looks too complicated, specially the test code and infrastructure
looks much more comp
Nir Soffer has posted comments on this change.
Change subject: tests: Remove global sanlock mock
..
Patch Set 2: Code-Review+2
I see this mock is handled in the next patches.
--
To view, visit https://gerrit.ovirt.org/61996
T
Nir Soffer has posted comments on this change.
Change subject: tests: Remove global sanlock mock
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/61996/2//COMMIT_MSG
Commit Message:
Line 8:
Line 9: We're currently mo
Nir Soffer has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61436
To unsubscribe, visit https://gerr
gerrit-hooks has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: tests: Introduce FakeSanlock
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: tests: Remove global sanlock mock
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sdm: Use guarded.context in copy_data
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: storage: domainMonitor.getAllHostIds() API
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Adam Litke has uploaded a new change for review.
Change subject: tests: Introduce FakeSanlock
..
tests: Introduce FakeSanlock
For the few tests that depend on sanlock, introduce FakeSanlock which
does nothing except record acqui
Nir Soffer has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 1: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/61995/1/lib/api/vdsm-api.yml
File lib/a
Jenkins CI has posted comments on this change.
Change subject: fixing repos for standard ci
..
Patch Set 5: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 3
--
To view, visit
Jenkins CI has posted comments on this change.
Change subject: fixing repos for standard ci
..
Patch Set 5:
Propagate review hook: Continuous Integration value inherited from patch 4
--
To view, visit https://gerrit.ovirt.org
Jenkins CI has posted comments on this change.
Change subject: fixing repos for standard ci
..
Patch Set 5: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch 2
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: WIP vm: add utility to get sublogger
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/61992/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 22
gerrit-hooks has posted comments on this change.
Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To v
Adam Litke has submitted this change and it was merged.
Change subject: testlib: Use osutils.close_fd to avoid fd leaks
..
testlib: Use osutils.close_fd to avoid fd leaks
If a child process exit when we close a file descriptor,
gerrit-hooks has posted comments on this change.
Change subject: testlib: Use osutils.close_fd to avoid fd leaks
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Adam Litke has submitted this change and it was merged.
Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..
osutils: Move NoIntrCall to osutils.uninterruptible
Streamline the code and missing tests
Change-Id
gerrit-hooks has posted comments on this change.
Change subject: fixing repos for standard ci
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: changing repos to be multi arch and support ppc64le
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/61463/7//COMMIT_MSG
Commit Message:
Line 9:
gerrit-hooks has posted comments on this change.
Change subject: changing repos to be multi arch and support ppc64le
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: changing repos to be multi arch and support ppc64le
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: add dry run option
..
Patch Set 1:
verified with 62052
--
To view, visit https://gerrit.ovirt.org/62257
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 2: Verified+1
Verified using this patch and 62257:
run
./kvm2ovirt --uri qemu
Francesco Romani has uploaded a new change for review.
Change subject: kvm2ovirt: add dry run option
..
kvm2ovirt: add dry run option
for testing purposes only.
Change-Id: I749dd215f87aa46f08583cdd481ea80cf808681d
Related-To: h
gerrit-hooks has posted comments on this change.
Change subject: kvm2ovirt: add dry run option
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 2:
* #1365051::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1365051
Nir Soffer has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/55074/5/lib/vdsm/concurrent.py
File lib/vdsm/concurrent.py:
Line 175:
L
gerrit-hooks has posted comments on this change.
Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sd: Support volume leases
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit
Adam Litke has submitted this change and it was merged.
Change subject: sd: Support volume leases
..
sd: Support volume leases
Add acquireVolumeLease(), inquireVolumeLease() and relaseVolumeLease()
to StorageDomainManifest. The
Adam Litke has posted comments on this change.
Change subject: sd: Support volume leases
..
Patch Set 9: Verified+1
Verified with copy_data patches:
69fa25e5-cb18-45d5-b71d-1a5d7827916f::INFO::2016-08-11
15:06:49,050::cluster
Nir Soffer has posted comments on this change.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/61460/5//COMMIT_MSG
Commit Message:
Line 9: This patch:
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 1:
Nijin, could you please verify?
--
To view, visit https://gerrit.ovirt.or
gerrit-hooks has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https
Nir Soffer has submitted this change and it was merged.
Change subject: automation: build also vhostmd hook
..
automation: build also vhostmd hook
In 3.6 we shipped vdsm-hook-vhostmd as part of our VDSM releases.
In 4.0 this ho
Nir Soffer has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.org/s
Francesco Romani has posted comments on this change.
Change subject: kvm2ovirt: Fixes issue in importing VMs with libvirt uri
qemu+tcp
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62052
To unsubscr
Irit Goihman has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/61902/8/tests/functional/supervdsmFuncTests.py
File tests/fu
Adam Litke has submitted this change and it was merged.
Change subject: sd: Unify getVolumeLease signature
..
sd: Unify getVolumeLease signature
StorageDomain.getVolumeLease accepted only a volume uuid, while
BlockStorageDomain
Adam Litke has submitted this change and it was merged.
Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..
clusterlock: Fix LocalLock.supports_volume_leases
LocalLock is using single lock file to implement lea
Adam Litke has submitted this change and it was merged.
Change subject: clusterlock: Support for multiple leases
..
clusterlock: Support for multiple leases
Previously the clusterlock api was supporting only a single lease (the
gerrit-hooks has posted comments on this change.
Change subject: WIP vm: add utility to get sublogger
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sd: Unify getVolumeLease signature
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https
Adam Litke has submitted this change and it was merged.
Change subject: clusterlock: Fix double close on EINTR
..
clusterlock: Fix double close on EINTR
Use new osutil.close_fd() to close lockfile properly without retrying if
t
gerrit-hooks has posted comments on this change.
Change subject: sd: Move getVolumeLease to StorageDomainManifest
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Fix double close on EINTR
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
Adam Litke has submitted this change and it was merged.
Change subject: sd: Move getVolumeLease to StorageDomainManifest
..
sd: Move getVolumeLease to StorageDomainManifest
We need to acquire volume leases from any host during
Adam Litke has posted comments on this change.
Change subject: clusterlock: Support for multiple leases
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60422
To unsubscribe, visit https://gerrit.ovirt.
Sandro Bonazzola has posted comments on this change.
Change subject: automation: fix lago repo for fc24
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62248
To unsubscribe, visit https://gerrit.ovirt.org
Sandro Bonazzola has posted comments on this change.
Change subject: automation: move glusterfs to 3.8
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62250
To unsubscribe, visit https://gerrit.ovirt.org/
gerrit-hooks has posted comments on this change.
Change subject: functional tests: fix supervdsmServer test
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Raise if lock is used improperly
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Support for multiple leases
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Adam Litke has submitted this change and it was merged.
Change subject: clusterlock: Raise if lock is used improperly
..
clusterlock: Raise if lock is used improperly
Cluster locks which do not support multiple leases (SafeLeas
Adam Litke has posted comments on this change.
Change subject: clusterlock: Raise if lock is used improperly
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60424
To unsubscribe, visit https://gerrit.o
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Adam Litke has submitted this change and it was merged.
Change subject: cluserlock: Use errno instead of os.errno
..
cluserlock: Use errno instead of os.errno
The errno attribute in the os module is not part of the module api b
gerrit-hooks has posted comments on this change.
Change subject: osutils: Start the osutils module
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:/
gerrit-hooks has posted comments on this change.
Change subject: cluserlock: Use errno instead of os.errno
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Adam Litke has submitted this change and it was merged.
Change subject: osutils: Start the osutils module
..
osutils: Start the osutils module
We use to have code calling os.close() using utils.NoIntrCall. If
os.close(fd) was i
gerrit-hooks has posted comments on this change.
Change subject: tests: bootstrap the livemerge tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Francesco Romani has uploaded a new change for review.
Change subject: tests: bootstrap the livemerge tests
..
tests: bootstrap the livemerge tests
Bootstrap the livemerge tests.
We start with a simple test for LiveMergeCleanupT
Francesco Romani has posted comments on this change.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
Patch Set 5: Verified+1
copied score, jenkins check is sufficient to cover changes since last
verification
Francesco Romani has posted comments on this change.
Change subject: virt: vm: switch to concurrent.thread()
..
Patch Set 7: Verified+1
verified using https://gerrit.ovirt.org/#/c/62253/
--
To view, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: tests: bootstrap the livemerge tests
..
Patch Set 1: Verified+1
verified by jenkins.
--
To view, visit https://gerrit.ovirt.org/62253
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: WIP: virt: migration: use the new VM sublogger
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: switch to concurrent.thread()
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: yajsonrpc: switch to concurrent.thread()
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: shorten executor thread system names
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 5:
* #1141422::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1141422::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: switch to concurrent.thread()
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Sandro Bonazzola has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 2:
so, 4 +1 have been collected, chance that someone add a +2 and merge?
--
To view, visit https://gerrit.o
gerrit-hooks has posted comments on this change.
Change subject: automation: move glusterfs to 3.8
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: move glusterfs to 3.8
..
automation: move glusterfs to 3.8
Moving glusterfs to 3.8 since it's the default
for Fedora 24 and CentOS Storage SIG.
gerrit-hooks has posted comments on this change.
Change subject: automation: fix lago repo for fc24
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: fix lago repo for fc24
..
automation: fix lago repo for fc24
Change-Id: Ie04335874206b7c0410534d2ac48317d954fffb4
Signed-off-by: Sandro Bonazzola
gerrit-hooks has posted comments on this change.
Change subject: v2v: Add helper that redirects stdin/out/err
..
Patch Set 3:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Che
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/14/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS14, Line 8
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/62094/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS2
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Add helper that redirects stdin/out/err
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62092/2//COMMIT_MSG
Commit Message:
Line 3: AuthorDa
gerrit-hooks has posted comments on this change.
Change subject: v2v: Add PipelineProc, pipeline wrapper object
..
Patch Set 3:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* C
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 16:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check Prod
gerrit-hooks has posted comments on this change.
Change subject: packaging: spec: update Url field
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:/
Francesco Romani has posted comments on this change.
Change subject: packaging: spec: update Url field
..
Patch Set 1:
we are not changing production code, no need for a BZ for this fix.
--
To view, visit https://gerrit.ovirt
Francesco Romani has submitted this change and it was merged.
Change subject: packaging: spec: update Url field
..
packaging: spec: update Url field
Change-Id: I39d78682eb367e41764405d531f40f84f35960d9
Signed-off-by: Sandro Bon
1 - 100 of 156 matches
Mail list logo