[jira] [Comment Edited] (CASSANDRA-18772) Remove dependency on commons-codec
[
https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755541#comment-17755541
]
Maxim Muzafarov edited comment on CASSANDRA-18772 at 8/17/23 1:44 PM:
--
OK, I've found an easy way to find all the unused dependencies, but this list
should be carefully filtered, as some of the "unused dependencies" may actually
be used at runtime. I doubt we can add running of this command to the ant build
as the maven is used.
h3. The command
Tested on the latest trunk (\{{commons-codec}} is there).
{code}
# copy packages to the build/target/classes to run maven
for d in `find ./build/classes -maxdepth 2 -type d -name org -or -name com`; do
`rsync -a $d ./build/target/classes`; done
{code}
{code:java}
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code:java}
[WARNING] Used undeclared dependencies found:
[WARNING]io.netty:netty-handler:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-buffer:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-codec:jar:4.1.96.Final:compile
[WARNING]org.checkerframework:checker-qual:jar:3.10.0:compile
[WARNING]io.netty:netty-transport:jar:4.1.96.Final:compile
[WARNING]
io.netty:netty-transport-native-unix-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-transport-classes-epoll:jar:4.1.96.Final:compile
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]net.openhft:affinity:jar:3.23.3:compile
[WARNING]org.slf4j:log4j-over-slf4j:jar:1.7.25:compile
[WARNING]io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile
[WARNING]com.github.jnr:jnr-constants:jar:0.10.4:compile
[WARNING]io.dropwizard.metrics:metrics-logback:jar:3.1.5:compile
[WARNING]org.antlr:ST4:jar:4.0.8:compile
[WARNING]org.gridkit.jvmtool:mxdump:jar:0.14:compile
[WARNING]io.netty:netty-tcnative-boringssl-static:jar:2.0.61.Final:compile
[WARNING]com.google.j2objc:j2objc-annotations:jar:1.3:compile
[WARNING]org.gridkit.lab:jvm-attach-api:jar:1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-json:jar:0.14:compile
[WARNING]org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
[WARNING]com.github.jnr:jnr-ffi:jar:2.2.13:compile
[WARNING]commons-codec:commons-codec:jar:1.9:compile
[WARNING]org.caffinitas.ohc:ohc-core-j8:jar:0.5.1:compile
[WARNING]org.bouncycastle:bcpkix-jdk15on:jar:1.70:compile
[WARNING]net.java.dev.jna:jna-platform:jar:5.13.0:compile
[WARNING]com.github.jnr:jffi:jar:1.3.11:compile
[WARNING]io.netty:netty-all:jar:4.1.96.Final:compile
[WARNING]org.gridkit.jvmtool:sjk-stacktrace:jar:0.14:compile
[WARNING]
io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.94.Final:compile
[INFO]
[INFO] BUILD SUCCESS
[INFO]
{code}
EDITED:
I was confused that the netty-all library was reported in a previous attempt,
so I've rechecked everything and found the problem with that approach. The mvn
command tool requires the compiled classes to be in the {{target}} directory,
but currently they're in classes/, so once I copied them to
build/target everything started working.
was (Author: mmuzaf):
OK, I've found an easy way to find all the unused dependencies, but this list
should be carefully filtered, as some of the "unused dependencies" may actually
be used at runtime. I doubt we can add running of this command to the ant build
as the maven is used.
h3. The command
Tested on the latest trunk (\{{commons-codec}} is there).
{code}
# copy packages to the build/target/classes to run maven
for d in `find ./build/classes -maxdepth 2 -type d -name org -or -name com`; do
`rsync -a $d ./build/target/classes`; done
{code}
{code:java}
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code:java}
[WARNING] Used undeclared dependencies found:
[WARNING]io.netty:netty-handler:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-buffer:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-codec:jar:4.1.96.Final:compile
[WARNING]org.checkerframework:checker-qual:jar:3.10.0:compile
[WARNING]io.netty:netty-transport:jar:4.1.96.Final:compile
[WARNING]
io.netty:netty-transport-native-unix-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-transport-classes-epoll:jar:4.1.96.Final:compile
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]
[jira] [Created] (CASSANDRA-18777) Revise unused project dependencies
Maxim Muzafarov created CASSANDRA-18777:
---
Summary: Revise unused project dependencies
Key: CASSANDRA-18777
URL: https://issues.apache.org/jira/browse/CASSANDRA-18777
Project: Cassandra
Issue Type: Task
Reporter: Maxim Muzafarov
There are some project dependencies that are no longer used, but they are still
declared in the parent pom. I think we can revise the project dependencies and
clean up the ones that are not used.
There are two issues here:
- deleting unused dependencies - it should be agreed by the community in
advance;
- adding an automation check to prevent the same problem in the future;
As a naive approach to finding the list of unused dependencies, the {{mvn
dependency:analyze}} command can be used. The command will not outline the list
of dependencies to remove, as some of them may only be used at runtime, so the
list should be considered cautiously. We put the built classes in the
{{build/classes}} and {{build/test/classes}} directories, which won't work for
the maven dependency plugin because it expects the built classes to be in the
{{target/classes}} directory - to trick that, we can copy them all there and
run the plugin against the built pom file. Below you can find commands to
reproduce the result and the result itself.
h3. The command
Tested on the latest trunk (commons-codec is there).
{code}
# copy packages to the build/target/classes to run maven
for d in `find ./build/classes -maxdepth 2 -type d -name org -or -name com`; do
`rsync -a $d ./build/target/classes`; done
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code}
[WARNING] Used undeclared dependencies found:
[WARNING]io.netty:netty-handler:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-buffer:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-codec:jar:4.1.96.Final:compile
[WARNING]org.checkerframework:checker-qual:jar:3.10.0:compile
[WARNING]io.netty:netty-transport:jar:4.1.96.Final:compile
[WARNING]
io.netty:netty-transport-native-unix-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-transport-classes-epoll:jar:4.1.96.Final:compile
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]net.openhft:affinity:jar:3.23.3:compile
[WARNING]org.slf4j:log4j-over-slf4j:jar:1.7.25:compile
[WARNING]io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile
[WARNING]com.github.jnr:jnr-constants:jar:0.10.4:compile
[WARNING]io.dropwizard.metrics:metrics-logback:jar:3.1.5:compile
[WARNING]org.antlr:ST4:jar:4.0.8:compile
[WARNING]org.gridkit.jvmtool:mxdump:jar:0.14:compile
[WARNING]io.netty:netty-tcnative-boringssl-static:jar:2.0.61.Final:compile
[WARNING]com.google.j2objc:j2objc-annotations:jar:1.3:compile
[WARNING]org.gridkit.lab:jvm-attach-api:jar:1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-json:jar:0.14:compile
[WARNING]org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
[WARNING]com.github.jnr:jnr-ffi:jar:2.2.13:compile
[WARNING]commons-codec:commons-codec:jar:1.9:compile
[WARNING]org.caffinitas.ohc:ohc-core-j8:jar:0.5.1:compile
[WARNING]org.bouncycastle:bcpkix-jdk15on:jar:1.70:compile
[WARNING]net.java.dev.jna:jna-platform:jar:5.13.0:compile
[WARNING]com.github.jnr:jffi:jar:1.3.11:compile
[WARNING]io.netty:netty-all:jar:4.1.96.Final:compile
[WARNING]org.gridkit.jvmtool:sjk-stacktrace:jar:0.14:compile
[WARNING]
io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.94.Final:compile
[INFO]
[INFO] BUILD SUCCESS
[INFO]
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18775) Remove libraries in lib/sigar-bin for unsupported architectures
[
https://issues.apache.org/jira/browse/CASSANDRA-18775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755618#comment-17755618
]
Maxim Muzafarov edited comment on CASSANDRA-18775 at 8/17/23 4:28 PM:
--
I'll take a look at it, sure. I think I need a few weeks to polish
CASSANDRA-16360 and try to figure out how to handle this one.
was (Author: mmuzaf):
[~mmuzaf] I'll take a look at it, sure. I think I need a few weeks to polish
CASSANDRA-16360 and try to figure out how to handle this one.
> Remove libraries in lib/sigar-bin for unsupported architectures
> ---
>
> Key: CASSANDRA-18775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18775
> Project: Cassandra
> Issue Type: Task
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> ✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [trunk L|⚑ 49]
> 15:41 $ ls -la lib/sigar-bin/
> total 6376
> drwxrwxr-x 2 fermat fermat 4096 aug 17 11:26 .
> drwxrwxr-x 5 fermat fermat 12288 aug 17 11:28 ..
> -rw-rw-r-- 1 fermat fermat 210641 aug 17 11:26 libsigar-amd64-freebsd-6.so
> -rw-rw-r-- 1 fermat fermat 246605 aug 17 11:26 libsigar-amd64-linux.so
> -rw-rw-r-- 1 fermat fermat 251360 aug 17 11:26 libsigar-amd64-solaris.so
> -rw-rw-r-- 1 fermat fermat 577452 aug 17 11:26 libsigar-ia64-hpux-11.sl
> -rw-rw-r-- 1 fermat fermat 494929 aug 17 11:26 libsigar-ia64-linux.so
> -rw-rw-r-- 1 fermat fermat 516096 aug 17 11:26 libsigar-pa-hpux-11.sl
> -rw-rw-r-- 1 fermat fermat 425077 aug 17 11:26 libsigar-ppc64-aix-5.so
> -rw-rw-r-- 1 fermat fermat 310792 aug 17 11:26 libsigar-ppc64le-linux.so
> -rw-rw-r-- 1 fermat fermat 330767 aug 17 11:26 libsigar-ppc64-linux.so
> -rw-rw-r-- 1 fermat fermat 400925 aug 17 11:26 libsigar-ppc-aix-5.so
> -rw-rw-r-- 1 fermat fermat 258547 aug 17 11:26 libsigar-ppc-linux.so
> -rw-rw-r-- 1 fermat fermat 269932 aug 17 11:26 libsigar-s390x-linux.so
> -rw-rw-r-- 1 fermat fermat 261896 aug 17 11:26 libsigar-sparc64-solaris.so
> -rw-rw-r-- 1 fermat fermat 285004 aug 17 11:26 libsigar-sparc-solaris.so
> -rw-rw-r-- 1 fermat fermat 397440 aug 17 11:26
> libsigar-universal64-macosx.dylib
> -rw-rw-r-- 1 fermat fermat 377668 aug 17 11:26 libsigar-universal-macosx.dylib
> -rw-rw-r-- 1 fermat fermat 179751 aug 17 11:26 libsigar-x86-freebsd-5.so
> -rw-rw-r-- 1 fermat fermat 179379 aug 17 11:26 libsigar-x86-freebsd-6.so
> -rw-rw-r-- 1 fermat fermat 233385 aug 17 11:26 libsigar-x86-linux.so
> -rw-rw-r-- 1 fermat fermat 242880 aug 17 11:26 libsigar-x86-solaris.so
> ✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [trunk L|⚑ 49]
> 15:43 $ du -shc lib/sigar-bin/
> 6,3Mlib/sigar-bin/
> 6,3Mtotal
> {code}
> I think we could definitely improve this. We basically need just x86-linux,
> amd64-linux and two libs for macosx.
> We could save like 5M from the final tarball size. From 75M down to 70M is
> not bad!
> Or maybe I am not getting something and we need this?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18772) Remove dependency on commons-codec
[
https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755541#comment-17755541
]
Maxim Muzafarov edited comment on CASSANDRA-18772 at 8/17/23 1:23 PM:
--
OK, I've found an easy way to find all the unused dependencies, but this list
should be carefully filtered, as some of the "unused dependencies" may actually
be used at runtime. I doubt we can add running of this command to the ant build
as the maven is used.
h3. The command
Tested on the latest trunk (\{{commons-codec}} is there).
{code:java}
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code:java}
[WARNING] Used undeclared dependencies found:
[WARNING]io.netty:netty-handler:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-buffer:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-codec:jar:4.1.96.Final:compile
[WARNING]org.checkerframework:checker-qual:jar:3.10.0:compile
[WARNING]io.netty:netty-transport:jar:4.1.96.Final:compile
[WARNING]
io.netty:netty-transport-native-unix-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-transport-classes-epoll:jar:4.1.96.Final:compile
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]net.openhft:affinity:jar:3.23.3:compile
[WARNING]org.slf4j:log4j-over-slf4j:jar:1.7.25:compile
[WARNING]io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile
[WARNING]com.github.jnr:jnr-constants:jar:0.10.4:compile
[WARNING]io.dropwizard.metrics:metrics-logback:jar:3.1.5:compile
[WARNING]org.antlr:ST4:jar:4.0.8:compile
[WARNING]org.gridkit.jvmtool:mxdump:jar:0.14:compile
[WARNING]io.netty:netty-tcnative-boringssl-static:jar:2.0.61.Final:compile
[WARNING]com.google.j2objc:j2objc-annotations:jar:1.3:compile
[WARNING]org.gridkit.lab:jvm-attach-api:jar:1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-json:jar:0.14:compile
[WARNING]org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
[WARNING]com.github.jnr:jnr-ffi:jar:2.2.13:compile
[WARNING]commons-codec:commons-codec:jar:1.9:compile
[WARNING]org.caffinitas.ohc:ohc-core-j8:jar:0.5.1:compile
[WARNING]org.bouncycastle:bcpkix-jdk15on:jar:1.70:compile
[WARNING]net.java.dev.jna:jna-platform:jar:5.13.0:compile
[WARNING]com.github.jnr:jffi:jar:1.3.11:compile
[WARNING]io.netty:netty-all:jar:4.1.96.Final:compile
[WARNING]org.gridkit.jvmtool:sjk-stacktrace:jar:0.14:compile
[WARNING]
io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.94.Final:compile
[INFO]
{code}
EDITED:
I was confused that the netty-all library was reported in a previous attempt,
so I've rechecked everything and found the problem with that approach. The mvn
command tool requires the compiled classes to be in the {{target}} directory,
but currently they're in classes/, so once I copied them to
build/target everything started working.
was (Author: mmuzaf):
OK, I've found an easy way to find all the unused dependencies, but this list
should be carefully filtered, as some of the "unused dependencies" may actually
be used at runtime. I doubt we can add running of this command to the ant build
as the maven is used.
h3. The command
Tested on the latest trunk (\{{commons-codec}} is there).
{code:java}
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code:java}
[INFO] --- dependency:3.2.0:analyze (default-cli) @ cassandra-all ---
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]net.openhft:chronicle-threads:jar:2.23.25:compile
[WARNING]org.psjava:psjava:jar:0.1.19:compile
[WARNING]ch.qos.logback:logback-core:jar:1.2.9:compile
[WARNING]io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile
[WARNING]org.lz4:lz4-java:jar:1.8.0:compile
[WARNING]org.apache.commons:commons-lang3:jar:3.11:compile
[WARNING]com.fasterxml.jackson.core:jackson-annotations:jar:2.13.2:compile
[WARNING]net.openhft:chronicle-bytes:jar:2.23.33:compile
[WARNING]ch.obermuhlner:big-math:jar:2.3.0:compile
[WARNING]io.airlift:airline:jar:0.8:compile
[WARNING]io.dropwizard.metrics:metrics-logback:jar:3.1.5:compile
[WARNING]io.dropwizard.metrics:metrics-core:jar:3.1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-core:jar:0.14:compile
[WARNING]com.github.seancfoley:ipaddress:jar:5.3.3:compile
[WARNING]com.google.j2objc:j2objc-annotations:jar:1.3:compile
[WARNING]com.fasterxml.jackson.core:jackson-databind:jar:2.13.2.2:compile
[jira] [Comment Edited] (CASSANDRA-18775) Remove libraries in lib/sigar-bin for unsupported architectures
[
https://issues.apache.org/jira/browse/CASSANDRA-18775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755618#comment-17755618
]
Maxim Muzafarov edited comment on CASSANDRA-18775 at 8/17/23 4:45 PM:
--
I'll take a look at it, sure. I think I need a few weeks to polish
CASSANDRA-16360 and will try to figure out how to handle this one.
was (Author: mmuzaf):
I'll take a look at it, sure. I think I need a few weeks to polish
CASSANDRA-16360 and try to figure out how to handle this one.
> Remove libraries in lib/sigar-bin for unsupported architectures
> ---
>
> Key: CASSANDRA-18775
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18775
> Project: Cassandra
> Issue Type: Task
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.x
>
>
> {code}
> ✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [trunk L|⚑ 49]
> 15:41 $ ls -la lib/sigar-bin/
> total 6376
> drwxrwxr-x 2 fermat fermat 4096 aug 17 11:26 .
> drwxrwxr-x 5 fermat fermat 12288 aug 17 11:28 ..
> -rw-rw-r-- 1 fermat fermat 210641 aug 17 11:26 libsigar-amd64-freebsd-6.so
> -rw-rw-r-- 1 fermat fermat 246605 aug 17 11:26 libsigar-amd64-linux.so
> -rw-rw-r-- 1 fermat fermat 251360 aug 17 11:26 libsigar-amd64-solaris.so
> -rw-rw-r-- 1 fermat fermat 577452 aug 17 11:26 libsigar-ia64-hpux-11.sl
> -rw-rw-r-- 1 fermat fermat 494929 aug 17 11:26 libsigar-ia64-linux.so
> -rw-rw-r-- 1 fermat fermat 516096 aug 17 11:26 libsigar-pa-hpux-11.sl
> -rw-rw-r-- 1 fermat fermat 425077 aug 17 11:26 libsigar-ppc64-aix-5.so
> -rw-rw-r-- 1 fermat fermat 310792 aug 17 11:26 libsigar-ppc64le-linux.so
> -rw-rw-r-- 1 fermat fermat 330767 aug 17 11:26 libsigar-ppc64-linux.so
> -rw-rw-r-- 1 fermat fermat 400925 aug 17 11:26 libsigar-ppc-aix-5.so
> -rw-rw-r-- 1 fermat fermat 258547 aug 17 11:26 libsigar-ppc-linux.so
> -rw-rw-r-- 1 fermat fermat 269932 aug 17 11:26 libsigar-s390x-linux.so
> -rw-rw-r-- 1 fermat fermat 261896 aug 17 11:26 libsigar-sparc64-solaris.so
> -rw-rw-r-- 1 fermat fermat 285004 aug 17 11:26 libsigar-sparc-solaris.so
> -rw-rw-r-- 1 fermat fermat 397440 aug 17 11:26
> libsigar-universal64-macosx.dylib
> -rw-rw-r-- 1 fermat fermat 377668 aug 17 11:26 libsigar-universal-macosx.dylib
> -rw-rw-r-- 1 fermat fermat 179751 aug 17 11:26 libsigar-x86-freebsd-5.so
> -rw-rw-r-- 1 fermat fermat 179379 aug 17 11:26 libsigar-x86-freebsd-6.so
> -rw-rw-r-- 1 fermat fermat 233385 aug 17 11:26 libsigar-x86-linux.so
> -rw-rw-r-- 1 fermat fermat 242880 aug 17 11:26 libsigar-x86-solaris.so
> ✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [trunk L|⚑ 49]
> 15:43 $ du -shc lib/sigar-bin/
> 6,3Mlib/sigar-bin/
> 6,3Mtotal
> {code}
> I think we could definitely improve this. We basically need just x86-linux,
> amd64-linux and two libs for macosx.
> We could save like 5M from the final tarball size. From 75M down to 70M is
> not bad!
> Or maybe I am not getting something and we need this?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18772) Remove dependency on commons-codec
[
https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755541#comment-17755541
]
Maxim Muzafarov edited comment on CASSANDRA-18772 at 8/17/23 1:42 PM:
--
OK, I've found an easy way to find all the unused dependencies, but this list
should be carefully filtered, as some of the "unused dependencies" may actually
be used at runtime. I doubt we can add running of this command to the ant build
as the maven is used.
h3. The command
Tested on the latest trunk (\{{commons-codec}} is there).
{code}
# copy packages to the build/target/classes to run maven
for d in `find ./build/classes -maxdepth 2 -type d -name org -or -name com`; do
`rsync -a $d ./build/target/classes`; done
{code}
{code:java}
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code:java}
[WARNING] Used undeclared dependencies found:
[WARNING]io.netty:netty-handler:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-buffer:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-codec:jar:4.1.96.Final:compile
[WARNING]org.checkerframework:checker-qual:jar:3.10.0:compile
[WARNING]io.netty:netty-transport:jar:4.1.96.Final:compile
[WARNING]
io.netty:netty-transport-native-unix-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-transport-classes-epoll:jar:4.1.96.Final:compile
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]net.openhft:affinity:jar:3.23.3:compile
[WARNING]org.slf4j:log4j-over-slf4j:jar:1.7.25:compile
[WARNING]io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile
[WARNING]com.github.jnr:jnr-constants:jar:0.10.4:compile
[WARNING]io.dropwizard.metrics:metrics-logback:jar:3.1.5:compile
[WARNING]org.antlr:ST4:jar:4.0.8:compile
[WARNING]org.gridkit.jvmtool:mxdump:jar:0.14:compile
[WARNING]io.netty:netty-tcnative-boringssl-static:jar:2.0.61.Final:compile
[WARNING]com.google.j2objc:j2objc-annotations:jar:1.3:compile
[WARNING]org.gridkit.lab:jvm-attach-api:jar:1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-json:jar:0.14:compile
[WARNING]org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
[WARNING]com.github.jnr:jnr-ffi:jar:2.2.13:compile
[WARNING]commons-codec:commons-codec:jar:1.9:compile
[WARNING]org.caffinitas.ohc:ohc-core-j8:jar:0.5.1:compile
[WARNING]org.bouncycastle:bcpkix-jdk15on:jar:1.70:compile
[WARNING]net.java.dev.jna:jna-platform:jar:5.13.0:compile
[WARNING]com.github.jnr:jffi:jar:1.3.11:compile
[WARNING]io.netty:netty-all:jar:4.1.96.Final:compile
[WARNING]org.gridkit.jvmtool:sjk-stacktrace:jar:0.14:compile
[WARNING]
io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.94.Final:compile
[INFO]
{code}
EDITED:
I was confused that the netty-all library was reported in a previous attempt,
so I've rechecked everything and found the problem with that approach. The mvn
command tool requires the compiled classes to be in the {{target}} directory,
but currently they're in classes/, so once I copied them to
build/target everything started working.
was (Author: mmuzaf):
OK, I've found an easy way to find all the unused dependencies, but this list
should be carefully filtered, as some of the "unused dependencies" may actually
be used at runtime. I doubt we can add running of this command to the ant build
as the maven is used.
h3. The command
Tested on the latest trunk (\{{commons-codec}} is there).
{code:java}
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code:java}
[WARNING] Used undeclared dependencies found:
[WARNING]io.netty:netty-handler:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-buffer:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-codec:jar:4.1.96.Final:compile
[WARNING]org.checkerframework:checker-qual:jar:3.10.0:compile
[WARNING]io.netty:netty-transport:jar:4.1.96.Final:compile
[WARNING]
io.netty:netty-transport-native-unix-common:jar:4.1.96.Final:compile
[WARNING]io.netty:netty-transport-classes-epoll:jar:4.1.96.Final:compile
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]net.openhft:affinity:jar:3.23.3:compile
[WARNING]org.slf4j:log4j-over-slf4j:jar:1.7.25:compile
[WARNING]io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile
[WARNING]com.github.jnr:jnr-constants:jar:0.10.4:compile
[WARNING]
[jira] [Updated] (CASSANDRA-18780) ConnectionBurnTest fails with NullPointerException
[
https://issues.apache.org/jira/browse/CASSANDRA-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18780:
Test and Documentation Plan: Run ConnectionBurnTest locally.
Status: Patch Available (was: Open)
> ConnectionBurnTest fails with NullPointerException
> --
>
> Key: CASSANDRA-18780
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18780
> Project: Cassandra
> Issue Type: Bug
> Components: Test/burn
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.x
>
>
> The ConnectionBurnTest is used to check the throughput of outgoing and
> incoming connections and report the results of execution to the log. During
> the test run, I noticed a couple of errors that actually prevent us from
> getting any results.
> # The {{NullPointerException}} is thrown during the test execution
> {code:java}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.metrics.ClientMetrics.unpauseConnection(ClientMetrics.java:69)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onReserveCapacityRegained(AbstractMessageHandler.java:314)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onGlobalReserveCapacityRegained(AbstractMessageHandler.java:289)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$Ticket.reactivateHandler(AbstractMessageHandler.java:792)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$ReactivateHandlers.run(AbstractMessageHandler.java:740)
> {code}
> # The exception is swallowed and the test exits almost immediately, but the
> exception itself is not rethrown and the exit code is zero. The test is
> always green on CI, but a fatal exception has occurred;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18780) ConnectionBurnTest fails with NullPointerException
[
https://issues.apache.org/jira/browse/CASSANDRA-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756586#comment-17756586
]
Maxim Muzafarov commented on CASSANDRA-18780:
-
[~benedict] Hey, it seems you are the author of this test. Can you please take
a look at this simple fix for the test? Do you have time to look at it? I was
trying to verify the CASSANDRA-16360 and stumbled upon this problem.
Changes are here:
https://github.com/apache/cassandra/pull/2613/files
> ConnectionBurnTest fails with NullPointerException
> --
>
> Key: CASSANDRA-18780
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18780
> Project: Cassandra
> Issue Type: Bug
> Components: Test/burn
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.x
>
>
> The ConnectionBurnTest is used to check the throughput of outgoing and
> incoming connections and report the results of execution to the log. During
> the test run, I noticed a couple of errors that actually prevent us from
> getting any results.
> # The {{NullPointerException}} is thrown during the test execution
> {code:java}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.metrics.ClientMetrics.unpauseConnection(ClientMetrics.java:69)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onReserveCapacityRegained(AbstractMessageHandler.java:314)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onGlobalReserveCapacityRegained(AbstractMessageHandler.java:289)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$Ticket.reactivateHandler(AbstractMessageHandler.java:792)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$ReactivateHandlers.run(AbstractMessageHandler.java:740)
> {code}
> # The exception is swallowed and the test exits almost immediately, but the
> exception itself is not rethrown and the exit code is zero. The test is
> always green on CI, but a fatal exception has occurred;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18780) ConnectionBurnTest fails with NullPointerException
[
https://issues.apache.org/jira/browse/CASSANDRA-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18780:
Fix Version/s: 5.x
> ConnectionBurnTest fails with NullPointerException
> --
>
> Key: CASSANDRA-18780
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18780
> Project: Cassandra
> Issue Type: Bug
> Components: Test/burn
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.x
>
>
> The ConnectionBurnTest is used to check the throughput of outgoing and
> incoming connections and report the results of execution to the log. During
> the test run, I noticed a couple of errors that actually prevent us from
> getting any results.
> # The {{NullPointerException}} is thrown during the test execution
> {code:java}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.metrics.ClientMetrics.unpauseConnection(ClientMetrics.java:69)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onReserveCapacityRegained(AbstractMessageHandler.java:314)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onGlobalReserveCapacityRegained(AbstractMessageHandler.java:289)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$Ticket.reactivateHandler(AbstractMessageHandler.java:792)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$ReactivateHandlers.run(AbstractMessageHandler.java:740)
> {code}
> # The exception is swallowed and the test exits almost immediately, but the
> exception itself is not rethrown and the exit code is zero. The test is
> always green on CI, but a fatal exception has occurred;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18780) ConnectionBurnTest fails with NullPointerException
[
https://issues.apache.org/jira/browse/CASSANDRA-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756585#comment-17756585
]
Maxim Muzafarov commented on CASSANDRA-18780:
-
Another thing, that happens when an error occurs during the test execution
(like the one mentioned in the ticket description) is that the test itself
waits indefinitely on inbound/outbound socket close futures, because the signal
is not released in the Verifry class. Here are some stack traces to illustrate
the issue.
{code}
"main" #1 prio=5 os_prio=31 cpu=1826.36ms elapsed=20.33s tid=0x000154016800
nid=0x2203 waiting on condition [0x00016b5c9000]
java.lang.Thread.State: TIMED_WAITING (parking)
at jdk.internal.misc.Unsafe.park(java.base@11.0.17/Native Method)
at
java.util.concurrent.locks.LockSupport.parkNanos(java.base@11.0.17/LockSupport.java:357)
at
org.apache.cassandra.utils.concurrent.WaitQueue$Standard$AbstractSignal.awaitUntil(WaitQueue.java:302)
at
org.apache.cassandra.utils.concurrent.Awaitable$AsyncAwaitable.awaitUntil(Awaitable.java:314)
at
org.apache.cassandra.utils.concurrent.AsyncFuture.awaitUntil(AsyncFuture.java:160)
at
org.apache.cassandra.utils.concurrent.Awaitable$Defaults.await(Awaitable.java:114)
at
org.apache.cassandra.utils.concurrent.AbstractFuture.await(AbstractFuture.java:449)
at
org.apache.cassandra.utils.concurrent.AbstractFuture.get(AbstractFuture.java:252)
at
org.apache.cassandra.net.ConnectionBurnTest$Test.run(ConnectionBurnTest.java:509)
at
org.apache.cassandra.net.ConnectionBurnTest.test(ConnectionBurnTest.java:678)
at
org.apache.cassandra.net.ConnectionBurnTest.test(ConnectionBurnTest.java:719)
at
jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@11.0.17/Native
Method)
{code}
{code}
"Messaging-EventLoop-6-1" #24 daemon prio=5 os_prio=31 cpu=3231.92ms
elapsed=18.01s tid=0x000141b38800 nid=0x8203 waiting on condition
[0x00016ea0e000]
java.lang.Thread.State: WAITING (parking)
at jdk.internal.misc.Unsafe.park(java.base@11.0.17/Native Method)
at
java.util.concurrent.locks.LockSupport.park(java.base@11.0.17/LockSupport.java:323)
at
org.apache.cassandra.utils.concurrent.WaitQueue$Standard$AbstractSignal.await(WaitQueue.java:289)
at
org.apache.cassandra.utils.concurrent.WaitQueue$Standard$AbstractSignal.await(WaitQueue.java:282)
at
org.apache.cassandra.net.Verifier$EventSequence.ensureChunk(Verifier.java:1341)
at
org.apache.cassandra.net.Verifier$EventSequence.put(Verifier.java:1314)
at org.apache.cassandra.net.Verifier.onSerialize(Verifier.java:293)
at org.apache.cassandra.net.Connection.serialize(Connection.java:199)
at
org.apache.cassandra.net.ConnectionBurnTest$Test$1.serialize(ConnectionBurnTest.java:161)
at
org.apache.cassandra.net.ConnectionBurnTest$Test$1.serialize(ConnectionBurnTest.java:157)
at
org.apache.cassandra.net.Message$Serializer.serialize(Message.java:712)
at
org.apache.cassandra.net.OutboundConnection$EventLoopDelivery.doRun(OutboundConnection.java:817)
at
org.apache.cassandra.net.OutboundConnection$Delivery.run(OutboundConnection.java:691)
{code}
> ConnectionBurnTest fails with NullPointerException
> --
>
> Key: CASSANDRA-18780
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18780
> Project: Cassandra
> Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
>
> The ConnectionBurnTest is used to check the throughput of outgoing and
> incoming connections and report the results of execution to the log. During
> the test run, I noticed a couple of errors that actually prevent us from
> getting any results.
> # The {{NullPointerException}} is thrown during the test execution
> {code:java}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.metrics.ClientMetrics.unpauseConnection(ClientMetrics.java:69)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onReserveCapacityRegained(AbstractMessageHandler.java:314)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onGlobalReserveCapacityRegained(AbstractMessageHandler.java:289)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$Ticket.reactivateHandler(AbstractMessageHandler.java:792)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$ReactivateHandlers.run(AbstractMessageHandler.java:740)
> {code}
> # The exception is swallowed and the test exits almost immediately, but the
> exception itself is not rethrown and the exit code is zero. The test is
> always green on CI, but a fatal exception has occurred;
--
This message was sent by
[jira] [Updated] (CASSANDRA-18780) ConnectionBurnTest fails with NullPointerException
[
https://issues.apache.org/jira/browse/CASSANDRA-18780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18780:
Bug Category: Parent values: Correctness(12982)
Complexity: Challenging
Component/s: Test/burn
Discovered By: User Report
Severity: Normal
Status: Open (was: Triage Needed)
> ConnectionBurnTest fails with NullPointerException
> --
>
> Key: CASSANDRA-18780
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18780
> Project: Cassandra
> Issue Type: Bug
> Components: Test/burn
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
>
> The ConnectionBurnTest is used to check the throughput of outgoing and
> incoming connections and report the results of execution to the log. During
> the test run, I noticed a couple of errors that actually prevent us from
> getting any results.
> # The {{NullPointerException}} is thrown during the test execution
> {code:java}
> java.lang.NullPointerException: null
> at
> org.apache.cassandra.metrics.ClientMetrics.unpauseConnection(ClientMetrics.java:69)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onReserveCapacityRegained(AbstractMessageHandler.java:314)
> at
> org.apache.cassandra.net.AbstractMessageHandler.onGlobalReserveCapacityRegained(AbstractMessageHandler.java:289)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$Ticket.reactivateHandler(AbstractMessageHandler.java:792)
> at
> org.apache.cassandra.net.AbstractMessageHandler$WaitQueue$ReactivateHandlers.run(AbstractMessageHandler.java:740)
> {code}
> # The exception is swallowed and the test exits almost immediately, but the
> exception itself is not rethrown and the exit code is zero. The test is
> always green on CI, but a fatal exception has occurred;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757040#comment-17757040 ] Maxim Muzafarov commented on CASSANDRA-18717: - [~e.dimitrova] The same problem exists for the checkstyle rules - they are configured but are not highlighted in the IDE. Currently, each developer solves this thing locally by himself, but I think we need a more common approach here. We can highlight these problems with the modern IDE we support and make them visible right in the opened window. For example, in the IntelliJ IDEA it is called - Inspections (see the "severity" field on the screenshot here [1]). >From my point of view, this problem consists of two steps: - We need to put the IntelliJ IDEA workspace configuration under the .idea directory in the project root to make this configuration shareable. The generate-idea-files is good for the first initialization of the project, but if we want to slightly adjust the configuration files (e.g. increase the severity level of a certain lint) it will erase all locally stored workspace configuration. A more detailed description of the problem and how to fix it can be found here: CASSANDRA-18277 - We need to configure and store the inspection configuration in the .idea directory and increase the severity level of a certain javadoc rule up to the "error" level, so a problem class is directly highlighted and visible in the working window. [1] https://www.jetbrains.com/help/idea/code-inspection.html > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758115#comment-17758115 ] Maxim Muzafarov commented on CASSANDRA-14667: - [~e.dimitrova] I checkouted the java-driver repo, prepared a new driver version with the above changes, and tested everything locally. I was not able to run all of the dtest on CI, but the tests that I saw failed due to missing classes in the classpath, they started to pass. Changes here (without the driver upgrade) also work, but with shading metrics in the driver itself we don't need to copy the required classes from the metrics library and 3.11.5 will reduce the cassandra-related patch up to ~10-20 lines of code (if we have 3.11.5 we won't need to copy missing classes and won't need to use withoutMetrics()) which seems to be the correct way to go. https://github.com/apache/cassandra/pull/2238 > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Attachments: signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18743) Remove dependency on archived project metrics-reporter-config
[
https://issues.apache.org/jira/browse/CASSANDRA-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755249#comment-17755249
]
Maxim Muzafarov commented on CASSANDRA-18743:
-
I haven't found usages of the {{org.apache.commons.codec}} package, so I think
we can easily remove this dependency, the code also compiles without it.
However, I'm not sure if such a change is related to the patch itself as there
is no requirement for this package from the metrics-reporter-config side.
> Remove dependency on archived project metrics-reporter-config
> -
>
> Key: CASSANDRA-18743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18743
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Abe Ratnofsky
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> metrics-reporter-config has been archived for over 3 years, and has received
> no updates in nearly 6 years:
> https://github.com/addthis/metrics-reporter-config
> metrics-reporter-config processes YAML unsafely:
> https://github.com/addthis/metrics-reporter-config/blob/master/reporter-config-base/src/main/java/com/addthis/metrics/reporter/config/AbstractReporterConfig.java#L39C34-L39C45
> This is related to CASSANDRA-18614, which is focused on migrating to safe
> YAML processing for the main configuration files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18743) Remove dependency on archived project metrics-reporter-config
[
https://issues.apache.org/jira/browse/CASSANDRA-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755249#comment-17755249
]
Maxim Muzafarov edited comment on CASSANDRA-18743 at 8/16/23 8:39 PM:
--
I haven't found usages of the {{org.apache.commons.codec}} package, so I think
we can easily remove this dependency, the code also compiles without it.
However, I'm not sure if such a change is related to the patch itself as there
is no requirement for this package from the metrics-reporter-config side.
Should we file an separate issue for that?
was (Author: mmuzaf):
I haven't found usages of the {{org.apache.commons.codec}} package, so I think
we can easily remove this dependency, the code also compiles without it.
However, I'm not sure if such a change is related to the patch itself as there
is no requirement for this package from the metrics-reporter-config side.
> Remove dependency on archived project metrics-reporter-config
> -
>
> Key: CASSANDRA-18743
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18743
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Abe Ratnofsky
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0, 5.x
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> metrics-reporter-config has been archived for over 3 years, and has received
> no updates in nearly 6 years:
> https://github.com/addthis/metrics-reporter-config
> metrics-reporter-config processes YAML unsafely:
> https://github.com/addthis/metrics-reporter-config/blob/master/reporter-config-base/src/main/java/com/addthis/metrics/reporter/config/AbstractReporterConfig.java#L39C34-L39C45
> This is related to CASSANDRA-18614, which is focused on migrating to safe
> YAML processing for the main configuration files.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755254#comment-17755254 ] Maxim Muzafarov commented on CASSANDRA-18772: - I was thinking about how we could find other dependencies that are no longer used, and how we could find them during the build. One I've found: https://docs.jboss.org/tattletale/userguide/1.2/en-US/html/ant.html https://tattletale.jboss.org/ I'll do some more digging to find a robust solution. > Remove dependency on commons-codec > -- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies >Reporter: Ekaterina Dimitrova >Assignee: Ekaterina Dimitrova >Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756116#comment-17756116 ] Maxim Muzafarov commented on CASSANDRA-18717: - To me, the most important obligation we have is to provide users with a good view of Cassandra internals by making the javadocs available on the web. Many important things are only mentioned in the javadocs, but not in the documentation. This is not a bad thing, as it is up to the user how deep they want to go. If we want the javadocs to be a part of the documentation, and to be available with every new release, it should at least be compilable. This is even more important when new CEPs that come into play. And now we have two ways to go: either every commit has compilable javadocs, or we fix them all before releasing a new version. So, I've assumed here, that we've chosen the first one, right? > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756130#comment-17756130 ] Maxim Muzafarov edited comment on CASSANDRA-18717 at 8/18/23 9:31 PM: -- [~smiklosovic] I've updated your PR for 5.0 brach (can't push it to your repository), see the link below. I've put javadoc under the check task, rebased on the top of trunk (cassandra-5.0 for the second one), and fixed a couple of new errors. [~e.dimitrova] please, check the links below. I've updated them according to the ML discussion. For the trunk changes are here: https://github.com/apache/cassandra/pull/2548 For the 5.0: https://github.com/apache/cassandra/compare/trunk...Mmuzaf:cassandra:CASSANDRA-18717-5.0 was (Author: mmuzaf): [~smiklosovic] I've updated your PR for 5.0 brach (can't push it to your repository), see the link below. I've put javadoc under the check task, rebased on the top of trunk (cassandra-5.0 for the second one), and fixed a couple of new errors. [~e.dimitrova] please, check the links below. I've updated them in accordance to the ML discussion. For the trunk changes are here: https://github.com/apache/cassandra/pull/2548 For the 5.0: https://github.com/apache/cassandra/compare/trunk...Mmuzaf:cassandra:CASSANDRA-18717-5.0 > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756130#comment-17756130 ] Maxim Muzafarov edited comment on CASSANDRA-18717 at 8/18/23 9:31 PM: -- [~smiklosovic] I've updated your PR for 5.0 brach (can't push it to your repository), see the link below. I've put javadoc under the check task, rebased on the top of trunk (cassandra-5.0 for the second one), and fixed a couple of new errors. [~e.dimitrova] please, check the links below. I've updated them in accordance to the ML discussion. For the trunk changes are here: https://github.com/apache/cassandra/pull/2548 For the 5.0: https://github.com/apache/cassandra/compare/trunk...Mmuzaf:cassandra:CASSANDRA-18717-5.0 was (Author: mmuzaf): [~smiklosovic] I've updated your PR for 5.0 brach (can't push it to your repository), see the link below. I've put javadoc under the check task, rebased on the top of trunk (cassandra-5.0 for the second one), and fixed a couple of new errors. [~e.dimitrova] please, check the links below. For the trunk changes are here: https://github.com/apache/cassandra/pull/2548 For the 5.0: https://github.com/apache/cassandra/compare/trunk...Mmuzaf:cassandra:CASSANDRA-18717-5.0 > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756130#comment-17756130 ] Maxim Muzafarov commented on CASSANDRA-18717: - [~smiklosovic] I've updated your PR for 5.0 brach (can't push it to your repository), see the link below. I've put javadoc under the check task, rebased on the top of trunk (cassandra-5.0 for the second one), and fixed a couple of new errors. [~e.dimitrova] please, check the links below. For the trunk changes are here: https://github.com/apache/cassandra/pull/2548 For the 5.0: https://github.com/apache/cassandra/compare/trunk...Mmuzaf:cassandra:CASSANDRA-18717-5.0 > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 0.5h > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18772) Remove dependency on commons-codec
[
https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755541#comment-17755541
]
Maxim Muzafarov commented on CASSANDRA-18772:
-
OK, I've found an easy way to find all the unused dependencies, but this list
should be carefully filtered, as some of the "unused dependencies" may actually
be used at runtime. I doubt we can add running of this command to the ant build
as the maven is used.
h3. The command
Tested on the latest trunk (\{{commons-codec}} is there).
{code:java}
mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom
org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true
-DignoreNonCompile
{code}
h3. The result
{code:java}
[INFO] --- dependency:3.2.0:analyze (default-cli) @ cassandra-all ---
[WARNING] Unused declared dependencies found:
[WARNING]com.github.jnr:jffi:jar:native:1.3.11:compile
[WARNING]net.openhft:chronicle-threads:jar:2.23.25:compile
[WARNING]org.psjava:psjava:jar:0.1.19:compile
[WARNING]ch.qos.logback:logback-core:jar:1.2.9:compile
[WARNING]io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile
[WARNING]org.lz4:lz4-java:jar:1.8.0:compile
[WARNING]org.apache.commons:commons-lang3:jar:3.11:compile
[WARNING]com.fasterxml.jackson.core:jackson-annotations:jar:2.13.2:compile
[WARNING]net.openhft:chronicle-bytes:jar:2.23.33:compile
[WARNING]ch.obermuhlner:big-math:jar:2.3.0:compile
[WARNING]io.airlift:airline:jar:0.8:compile
[WARNING]io.dropwizard.metrics:metrics-logback:jar:3.1.5:compile
[WARNING]io.dropwizard.metrics:metrics-core:jar:3.1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-core:jar:0.14:compile
[WARNING]com.github.seancfoley:ipaddress:jar:5.3.3:compile
[WARNING]com.google.j2objc:j2objc-annotations:jar:1.3:compile
[WARNING]com.fasterxml.jackson.core:jackson-databind:jar:2.13.2.2:compile
[WARNING]net.java.dev.jna:jna:jar:5.13.0:compile
[WARNING]org.gridkit.lab:jvm-attach-api:jar:1.5:compile
[WARNING]org.gridkit.jvmtool:sjk-json:jar:0.14:compile
[WARNING]org.agrona:agrona:jar:1.17.1:compile
[WARNING]org.slf4j:jcl-over-slf4j:jar:1.7.25:compile
[WARNING]
com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.13.2:compile
[WARNING]com.github.jbellis:jamm:jar:0.4.0:compile
[WARNING]net.openhft:posix:jar:2.24ea4:compile
[WARNING]net.openhft:chronicle-queue:jar:5.23.37:compile
[WARNING]commons-codec:commons-codec:jar:1.9:compile
[WARNING]com.boundary:high-scale-lib:jar:1.0.6:compile
[WARNING]org.caffinitas.ohc:ohc-core-j8:jar:0.5.1:compile
[WARNING]com.addthis.metrics:reporter-config3:jar:3.0.3:compile
[WARNING]
com.datastax.cassandra:cassandra-driver-core:jar:shaded:3.11.0:compile
[WARNING]com.github.luben:zstd-jni:jar:1.5.5-1:compile
[WARNING]com.carrotsearch:hppc:jar:0.8.1:compile
[WARNING]org.xerial.snappy:snappy-java:jar:1.1.10.1:compile
[WARNING]org.bouncycastle:bcpkix-jdk15on:jar:1.70:compile
[WARNING]com.google.code.findbugs:jsr305:jar:2.0.2:compile
[WARNING]com.clearspring.analytics:stream:jar:2.5.2:compile
[WARNING]org.mindrot:jbcrypt:jar:0.4:compile
[WARNING]
io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.94.Final:compile
[WARNING]ch.qos.logback:logback-classic:jar:1.2.9:compile
[WARNING]com.google.guava:guava:jar:32.0.1-jre:compile
[WARNING]org.apache.commons:commons-math3:jar:3.2:compile
[WARNING]org.yaml:snakeyaml:jar:1.26:compile
[WARNING]org.apache.lucene:lucene-core:jar:9.7.0:compile
[WARNING]net.openhft:affinity:jar:3.23.3:compile
[WARNING]org.eclipse.jdt:ecj:jar:3.33.0:compile
[WARNING]org.slf4j:log4j-over-slf4j:jar:1.7.25:compile
[WARNING]org.caffinitas.ohc:ohc-core:jar:0.5.1:compile
[WARNING]org.gridkit.jvmtool:sjk-cli:jar:0.14:compile
[WARNING]org.apache.lucene:lucene-analysis-common:jar:9.7.0:compile
[WARNING]com.github.jnr:jnr-constants:jar:0.10.4:compile
[WARNING]org.hdrhistogram:HdrHistogram:jar:2.1.9:compile
[WARNING]net.openhft:chronicle-core:jar:2.23.36:compile
[WARNING]com.github.ben-manes.caffeine:caffeine:jar:2.9.2:compile
[WARNING]org.antlr:ST4:jar:4.0.8:compile
[WARNING]org.gridkit.jvmtool:mxdump:jar:0.14:compile
[WARNING]io.netty:netty-tcnative-boringssl-static:jar:2.0.61.Final:compile
[WARNING]org.antlr:antlr-runtime:jar:3.5.2:compile
[WARNING]com.beust:jcommander:jar:1.30:compile
[WARNING]com.fasterxml.jackson.core:jackson-core:jar:2.13.2:compile
[WARNING]javax.inject:javax.inject:jar:1:compile
[WARNING]io.dropwizard.metrics:metrics-jvm:jar:3.1.5:compile
[WARNING]commons-cli:commons-cli:jar:1.5.0:compile
[WARNING]com.github.jnr:jnr-ffi:jar:2.2.13:compile
[WARNING]org.slf4j:slf4j-api:jar:1.7.25:compile
[WARNING]org.fusesource:sigar:jar:1.6.4:compile
[WARNING]org.jctools:jctools-core:jar:3.1.0:compile
[WARNING]
[jira] [Commented] (CASSANDRA-18702) Add jmh microbenchmarks to eclipse IDE
[ https://issues.apache.org/jira/browse/CASSANDRA-18702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17755023#comment-17755023 ] Maxim Muzafarov commented on CASSANDRA-18702: - +1 tested locally > Add jmh microbenchmarks to eclipse IDE > -- > > Key: CASSANDRA-18702 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18702 > Project: Cassandra > Issue Type: Bug > Components: Build >Reporter: Berenguer Blasi >Assignee: Berenguer Blasi >Priority: Normal > Fix For: 5.x > > > Currently jmh tests are not being picked up by the Eclipse IDE. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18751) Fix Requires for Java for RPM packages
[ https://issues.apache.org/jira/browse/CASSANDRA-18751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754573#comment-17754573 ] Maxim Muzafarov commented on CASSANDRA-18751: - Here is the list of OS with java-1.8.0-openjdk-headless: https://rpmfind.net/linux/rpm2html/search.php?query=java-1.8.0-openjdk-headless So, I think it should be fine. > Fix Requires for Java for RPM packages > -- > > Key: CASSANDRA-18751 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18751 > Project: Cassandra > Issue Type: Task > Components: Packaging >Reporter: Stefan Miklosovic >Assignee: Stefan Miklosovic >Priority: Normal > Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x > > Time Spent: 1h > Remaining Estimate: 0h > > We have to change Requires in redhat/cassandra.spec to > java-1.8.0 for 3.0 and 3.11 > (java-1.8.0 or java-11) for 4.0. and 4.1 > (java-11 or java-17) for 5.0 and trunk > noboolean would contain only java-1.8.0 and java-11 respectively where > applicable. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17754768#comment-17754768 ] Maxim Muzafarov commented on CASSANDRA-14667: - [~absurdfarce] Thanks, I look forward to your comments :-) > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Attachments: signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18799) Remove org.caffinitas.ohc:ohc-core-j8 dependency
[
https://issues.apache.org/jira/browse/CASSANDRA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759967#comment-17759967
]
Maxim Muzafarov commented on CASSANDRA-18799:
-
[~e.dimitrova] Thanks for noticing this, I also found that the upgrade is
required to 0.7.1+ because of the following commit
[d6a834338d0b7de5b79d10c95d1bc08d73238c63|https://github.com/snazy/ohc/commit/d6a834338d0b7de5b79d10c95d1bc08d73238c63].
The tests results for the latest changes are here:
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=cassandra-18799
#2489
Overall looks good. The results include a couple of failed tests, both of which
I've run locally. The {{org.apache.cassandra.transport.CQLConnectionTest}}
passes locally, and the second one has its own problem to fix: CASSANDRA-18361
Since the library is related to off-heap caching, I think the results that are
the most interesting for us are {{j11_cqlsh_dtests_py311_offheap}} and
{{j11_dtests_offheap}}, can you help to run them either? I've tried running
them on my own CircleCI plan and failed with an error "Try out a larger
resource class or running tests in parallel to speed up job execution.", it
seems to me that Jenkins still doesn't work.
> Remove org.caffinitas.ohc:ohc-core-j8 dependency
>
>
> Key: CASSANDRA-18799
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18799
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems the `org.caffinitas.ohc:ohc-core-j8` is not required anymore and the
> Cassandra project moved away from JDK8 support. The changes are here:
> CASSANDRA-18255
> We can remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18799) Remove org.caffinitas.ohc:ohc-core-j8 dependency
[
https://issues.apache.org/jira/browse/CASSANDRA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759967#comment-17759967
]
Maxim Muzafarov edited comment on CASSANDRA-18799 at 8/29/23 2:01 PM:
--
[~e.dimitrova] Thanks for noticing this, I also found that the upgrade is
required to 0.7.1+ because of the following commit
[d6a834338d0b7de5b79d10c95d1bc08d73238c63|https://github.com/snazy/ohc/commit/d6a834338d0b7de5b79d10c95d1bc08d73238c63].
The tests results for the latest changes are here:
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=cassandra-18799
#2489 (thank you for scheduling it!)
Overall looks good. The results include a couple of failed tests, both of which
I've run locally. The {{org.apache.cassandra.transport.CQLConnectionTest}}
passes locally, and the second one has its own problem to fix: CASSANDRA-18361
Since the library is related to off-heap caching, I think the results that are
the most interesting for us are {{j11_cqlsh_dtests_py311_offheap}} and
{{j11_dtests_offheap}}, can you help to run them either? I've tried running
them on my own CircleCI plan and failed with an error "Try out a larger
resource class or running tests in parallel to speed up job execution.", it
seems to me that Jenkins still doesn't work.
was (Author: mmuzaf):
[~e.dimitrova] Thanks for noticing this, I also found that the upgrade is
required to 0.7.1+ because of the following commit
[d6a834338d0b7de5b79d10c95d1bc08d73238c63|https://github.com/snazy/ohc/commit/d6a834338d0b7de5b79d10c95d1bc08d73238c63].
The tests results for the latest changes are here:
https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=cassandra-18799
#2489
Overall looks good. The results include a couple of failed tests, both of which
I've run locally. The {{org.apache.cassandra.transport.CQLConnectionTest}}
passes locally, and the second one has its own problem to fix: CASSANDRA-18361
Since the library is related to off-heap caching, I think the results that are
the most interesting for us are {{j11_cqlsh_dtests_py311_offheap}} and
{{j11_dtests_offheap}}, can you help to run them either? I've tried running
them on my own CircleCI plan and failed with an error "Try out a larger
resource class or running tests in parallel to speed up job execution.", it
seems to me that Jenkins still doesn't work.
> Remove org.caffinitas.ohc:ohc-core-j8 dependency
>
>
> Key: CASSANDRA-18799
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18799
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 5.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It seems the `org.caffinitas.ohc:ohc-core-j8` is not required anymore and the
> Cassandra project moved away from JDK8 support. The changes are here:
> CASSANDRA-18255
> We can remove it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757366#comment-17757366 ] Maxim Muzafarov commented on CASSANDRA-18717: - I really hope this is just related to the concerns outlined here, and not a blocker for the patch that fixes javadocs. :-) > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757479#comment-17757479 ] Maxim Muzafarov commented on CASSANDRA-18717: - Since the CEPs are related to the new piece of code, I think the amount of conflict with javadoc will be extremely minimal. Such a technique also increases the amount of work for the patches that are waiting for the CEPs to land. The more patches waiting, the more extra work for we would have to do for no reason. My suggestion is to go directly to the CEPs (I assume they are all publicly available) and fix the javadocs there and merge the current patch. I can do that. OR Merge it as is without making the CI fail, as we probably need to ship compilable javadocs in an earlier aplha version (not only because it is difficult to maintain such kinds of patches over a long period of time :-) ) Mick outlined the list of CEPs that are waiting to be completed soon, no a big deal to check all and fix them all. WDYT? https://lists.apache.org/thread/znm04w0fc5076ccdo8p3t3ghjox863zz > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757551#comment-17757551 ] Maxim Muzafarov commented on CASSANDRA-18717: - [~samt] Thank you for sharing the link to the work, the last thing we want to do is to add another layer of complexity to the long-awaited work during the rebase. I have my own personal experience with keeping the distributed snapshot patch up to date for a long period of time during the review, and I remember how painful it can be. Now I'm confused by the question of what criteria we should use to put one of the patches on hold and continue with the others. The number of changed files doesn't seem to be a good one. Should we introduce such criteria and publish them? I have cherry-picked the fix of javadocs to the branch you provided, and actually, it's really easy to apply. There were a few conflicts and ~8 errors with javadoc compilation. The cause of the conflicts was mostly because the method signature was changed e.g. TokenRingUtils#getPrimaryRangesForEndpoint, the last ones were caused by unacceptable symbols <, > or & e.g. the javadoc for the constant TCM_RECENTLY_SEALED_PERIOD_INDEX_SIZE. So, I think the CASSANDRA-18314 would probably be a bigger problem to rebase on and that's why I am confused. The changes for your branch are here: https://github.com/apache/cassandra/compare/cep-21-tcm...Mmuzaf:cassandra:cep-21-tcm-javadoc > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757574#comment-17757574 ] Maxim Muzafarov commented on CASSANDRA-14667: - [~absurdfarce] thank you for the summary. So the first step is to wait for 3.11.5 to be released, and then I need to update the Cassandra-related part of the PR right after that, right? Or is some kind of release preparation help needed on my part? > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Attachments: signature.asc > > Time Spent: 1.5h > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18717) Fix errors or remove ant javadoc task
[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17757626#comment-17757626 ] Maxim Muzafarov commented on CASSANDRA-18717: - I will prepare everything as soon as the big patches will have land, no worries :-) let's just not forget all the issues we put on hold! I remember how painful the rebase can be, so I agree with you to return to it when we are ready for such changes. Don't see a rush here. > Fix errors or remove ant javadoc task > - > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18785) Add optional task to run Sonar analysis
[
https://issues.apache.org/jira/browse/CASSANDRA-18785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784933#comment-17784933
]
Maxim Muzafarov commented on CASSANDRA-18785:
-
checked locally
+1
Should we merge it to the trunk only?
> Add optional task to run Sonar analysis
> ---
>
> Key: CASSANDRA-18785
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18785
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Env variables:
> - {{SONAR_SERVER_URL}} - default value:
> {{[http://127.0.0.1:9000|http://127.0.0.1:9000/]}} - the running instance of
> SonarQube server
> - {{SONAR_PROJECT_KEY}} - default value: {{- name>}} - the Cassandra project key as defined in the SonarQube server
> instance
> - {{SONAR_CASSANDRA_TOKEN}} - the analysis token for the Cassandra project;
> it is required when {{SONAR_SERVER_URL}} is explicitly provided
> Tasks:
> 1. {{ant sonar}} - runs the Sonar scan of the project and generate an HTML
> report. It requires the server is running and the project is configured
> 2. {{ant start-sonar-server}} - pulls the Docker image of the SonarQube
> Community server, starts it, awaits until ready, and update admin credentials
> to {{admin:password}} (they are initially {{admin:admin}} and Sonar forces
> changing them on first login)
> 3. {{ant stop-sonar-server}} - stops the local Docker container running the
> SonarQube server; does not remove the container so that it can be restarted
> and the previous analysis results can be inspected
> When the server is running, you can configure SonarLinter plugin in IntelliJ
> to connect to the server and use the same quality profile.
> Run modes:
> - External - when the {{SONAR_SERVER_URL}} env variable is defined, the
> script assumes that the server is already fully setup and the script should
> only submit the analysis results. In this case, it does not update the
> project's quality profile using the configuration stored in the branch - it
> is up to the user to configure the project in external SonarQube instance
> - Internal - when the {{SONAR_SERVER_URL}} env variable is not set, the
> script assumes that the server is running locally at the address and port; In
> this case, the script automatically tries to create the project with name/key
> defined in {{{}SONAR_PROJECT_KEY{}}}, upload the quality profile for the
> project from {{{}.build/sonar-quality-profile.xml{}}}, and recreate the
> analysis token, which is then used for the analysis. To perform those
> operations, the script must provide admin credentials for the local SonarQube
> server instance - they are assumed to be {{{}admin:password{}}}.
> The quality profile attached in the {{.build/sonar-quality-profile.xml}} file
> is the copy of the default SonarWay Java profile but it can be customized per
> branch.
>
> After the analysis, a simple HTML report is generated by listing the existing
> issues in the project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18785) Add optional task to run Sonar analysis
[
https://issues.apache.org/jira/browse/CASSANDRA-18785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784941#comment-17784941
]
Maxim Muzafarov commented on CASSANDRA-18785:
-
The replacement of the eclipse-warning is part of another issue that will
introduce CheckerFramework, isn't it? CASSANDRA-18239
> Add optional task to run Sonar analysis
> ---
>
> Key: CASSANDRA-18785
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18785
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Assignee: Jacek Lewandowski
>Priority: Normal
> Time Spent: 10h 20m
> Remaining Estimate: 0h
>
> Env variables:
> - {{SONAR_SERVER_URL}} - default value:
> {{[http://127.0.0.1:9000|http://127.0.0.1:9000/]}} - the running instance of
> SonarQube server
> - {{SONAR_PROJECT_KEY}} - default value: {{- name>}} - the Cassandra project key as defined in the SonarQube server
> instance
> - {{SONAR_CASSANDRA_TOKEN}} - the analysis token for the Cassandra project;
> it is required when {{SONAR_SERVER_URL}} is explicitly provided
> Tasks:
> 1. {{ant sonar}} - runs the Sonar scan of the project and generate an HTML
> report. It requires the server is running and the project is configured
> 2. {{ant start-sonar-server}} - pulls the Docker image of the SonarQube
> Community server, starts it, awaits until ready, and update admin credentials
> to {{admin:password}} (they are initially {{admin:admin}} and Sonar forces
> changing them on first login)
> 3. {{ant stop-sonar-server}} - stops the local Docker container running the
> SonarQube server; does not remove the container so that it can be restarted
> and the previous analysis results can be inspected
> When the server is running, you can configure SonarLinter plugin in IntelliJ
> to connect to the server and use the same quality profile.
> Run modes:
> - External - when the {{SONAR_SERVER_URL}} env variable is defined, the
> script assumes that the server is already fully setup and the script should
> only submit the analysis results. In this case, it does not update the
> project's quality profile using the configuration stored in the branch - it
> is up to the user to configure the project in external SonarQube instance
> - Internal - when the {{SONAR_SERVER_URL}} env variable is not set, the
> script assumes that the server is running locally at the address and port; In
> this case, the script automatically tries to create the project with name/key
> defined in {{{}SONAR_PROJECT_KEY{}}}, upload the quality profile for the
> project from {{{}.build/sonar-quality-profile.xml{}}}, and recreate the
> analysis token, which is then used for the analysis. To perform those
> operations, the script must provide admin credentials for the local SonarQube
> server instance - they are assumed to be {{{}admin:password{}}}.
> The quality profile attached in the {{.build/sonar-quality-profile.xml}} file
> is the copy of the default SonarWay Java profile but it can be customized per
> branch.
>
> After the analysis, a simple HTML report is generated by listing the existing
> issues in the project.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18932) Harry-found CorruptSSTableException / RT Closer issue when reading entire partition
[
https://issues.apache.org/jira/browse/CASSANDRA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784475#comment-17784475
]
Maxim Muzafarov commented on CASSANDRA-18932:
-
+1 as a quick fix, but it looks like we should enforce a contract related to
the `seekToPosition' method usage so that we never have to face the same issue
again.
> Harry-found CorruptSSTableException / RT Closer issue when reading entire
> partition
> ---
>
> Key: CASSANDRA-18932
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18932
> Project: Cassandra
> Issue Type: Bug
> Components: Local/SSTable
>Reporter: Alex Petrov
>Assignee: Jacek Lewandowski
>Priority: Normal
> Fix For: 5.0-beta, 5.0.x, 5.x
>
> Attachments: node1_.zip, operation.log.zip, screenshot-1.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While testing some new machinery for Harry, I have encountered a new RT
> closer / SSTable Corruption issue. I have grounds to believe this was
> introduced during the last year.
> Issue seems to happen because of intricate interleaving of flushes with
> writes and deletes.
> {code:java}
> ERROR [ReadStage-2] 2023-10-16 18:47:06,696 JVMStabilityInspector.java:76 -
> Exception in thread Thread[ReadStage-2,5,SharedPool]
> org.apache.cassandra.io.sstable.CorruptSSTableException: Corrupted:
> RandomAccessReader:BufferManagingRebufferer.Aligned:CompressedChunkReader.Mmap(/Users/ifesdjeen/foss/java/apache-cassandra-4.0/data/data1/harry/table_1-07c35a606c0a11eeae7a4f6ca489eb0c/nc-5-big-Data.db
> - LZ4Compressor, chunk length 16384, data length 232569)
> at
> org.apache.cassandra.io.sstable.AbstractSSTableIterator$AbstractReader.hasNext(AbstractSSTableIterator.java:381)
> at
> org.apache.cassandra.io.sstable.AbstractSSTableIterator.hasNext(AbstractSSTableIterator.java:242)
> at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95)
> at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32)
> at
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47)
> at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133)
> at
> org.apache.cassandra.utils.MergeIterator$Candidate.advance(MergeIterator.java:376)
> at
> org.apache.cassandra.utils.MergeIterator$ManyToOne.advance(MergeIterator.java:188)
> at
> org.apache.cassandra.utils.MergeIterator$ManyToOne.computeNext(MergeIterator.java:157)
> at
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47)
> at
> org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:534)
> at
> org.apache.cassandra.db.rows.UnfilteredRowIterators$UnfilteredRowMergeIterator.computeNext(UnfilteredRowIterators.java:402)
> at
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47)
> at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:95)
> at
> org.apache.cassandra.db.rows.LazilyInitializedUnfilteredRowIterator.computeNext(LazilyInitializedUnfilteredRowIterator.java:32)
> at
> org.apache.cassandra.utils.AbstractIterator.hasNext(AbstractIterator.java:47)
> at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133)
> at
> org.apache.cassandra.db.transform.BaseRows.hasNext(BaseRows.java:133)
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:151)
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:101)
> at
> org.apache.cassandra.db.rows.UnfilteredRowIteratorSerializer.serialize(UnfilteredRowIteratorSerializer.java:86)
> at
> org.apache.cassandra.db.partitions.UnfilteredPartitionIterators$Serializer.serialize(UnfilteredPartitionIterators.java:343)
> at
> org.apache.cassandra.db.ReadResponse$LocalDataResponse.build(ReadResponse.java:201)
> at
> org.apache.cassandra.db.ReadResponse$LocalDataResponse.(ReadResponse.java:186)
> at
> org.apache.cassandra.db.ReadResponse.createDataResponse(ReadResponse.java:48)
> at
> org.apache.cassandra.db.ReadCommand.createResponse(ReadCommand.java:346)
> at
> org.apache.cassandra.service.StorageProxy$LocalReadRunnable.runMayThrow(StorageProxy.java:2186)
> at
>
[jira] [Assigned] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov reassigned CASSANDRA-15254: --- Assignee: Maxim Muzafarov (was: Benjamin Lerer) > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Maxim Muzafarov >Priority: Normal > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656631#comment-17656631
]
Maxim Muzafarov commented on CASSANDRA-18126:
-
[~smiklosovic] , [~aleksey], [~jmckenzie], [~dcapwell]
Thank you all for the review.
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 3.0.29, 3.11.15, 4.0.8, 4.1.1, 4.2
>
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653433#comment-17653433 ] Maxim Muzafarov commented on CASSANDRA-15254: - [~blerer] , Hello and happy new year! Do you have plans to finalize this issue? If not, do you mind if I continue the task? :) > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Benjamin Lerer >Priority: Normal > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18089: Change Category: Code Clarity Complexity: Normal Component/s: Build Status: Open (was: Triage Needed) > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports from a package is that you can tell at a glance which > class you meant to use, which does reading and refactoring the source code > that much easier. > The checkstyle that is already used for checking the source code has a such > check and this check may be added to the config both for the production and > test source code: > https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport > Besides adding a new checkstyle rule it may be more convenient for those > community members that are working with the code to reflect the same rule in > the IDE's inspection profiles (if it's possible), thus using the 'optimize > imports' will produce the same results on each execution as the checkstyle > does. > Summary: > - add new checkstyle rule; > - update IDE's appropriate built-in inspections configurations; > - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-9209) Add static analysis to report any AutoCloseable objects that are not encapsulated in a try/finally block
[ https://issues.apache.org/jira/browse/CASSANDRA-9209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-9209: --- Epic Link: CASSANDRA-18090 > Add static analysis to report any AutoCloseable objects that are not > encapsulated in a try/finally block > > > Key: CASSANDRA-9209 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9209 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core, Legacy/Testing >Reporter: Benedict Elliott Smith >Priority: Normal > Fix For: 4.x > > > Shouldn't be too tricky, and would help us potentially avoid a number of > bugs. A follow up would be to enable optional ref counting (or at least leak > detection) at run time for AutoCloseable objects, possibly only for those we > care about, but also possible via bytecode weaving so that we could capture > all of them without question. > (/cc [~tjake]) -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17400) Fail build or warn when closeable reference is not closed in tests
[
https://issues.apache.org/jira/browse/CASSANDRA-17400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-17400:
Epic Link: CASSANDRA-18090
> Fail build or warn when closeable reference is not closed in tests
> --
>
> Key: CASSANDRA-17400
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17400
> Project: Cassandra
> Issue Type: Task
>Reporter: Paulo Motta
>Priority: Normal
> Labels: lhf
>
> I came across a recent test stuck issue which was caused by an
> {{Autocloseable}} object not being closed properly, leaking some references
> and ultimately causing a deadlock.
> To prevent similar issues in the future we should add a check that fail or
> warn when references are not closed during tests.
> If such check already exists we should look into fixing violations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-9919) Cleanup closeable iterator usage
[ https://issues.apache.org/jira/browse/CASSANDRA-9919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-9919: --- Epic Link: CASSANDRA-18090 > Cleanup closeable iterator usage > > > Key: CASSANDRA-9919 > URL: https://issues.apache.org/jira/browse/CASSANDRA-9919 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core >Reporter: Benedict Elliott Smith >Priority: Normal > Fix For: 4.x > > > Our iterators are all sensibly AutoCloseable, but we still have a lot of > places where we close the iterator if we reach the end in next() / hasNext(). > ThIs behaviour will only mask problems, as any exceptions in normal > processing will miss these pathways. Since we much more heavily depend on > iterators now, we need to be certain they are rock solid. So I would prefer > we remove our crutches and work through any pain earlier. > CASSANDRA-9918 can then help us catch any misuse more easily. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18090) Cassandra code style and static analysys
[ https://issues.apache.org/jira/browse/CASSANDRA-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18090: Epic Name: Code Style & Static Analysis (was: Cassandra code style and static analysys) > Cassandra code style and static analysys > > > Key: CASSANDRA-18090 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18090 > Project: Cassandra > Issue Type: Epic >Reporter: Maxim Muzafarov >Priority: Normal > > This is an umbrella ticket that aggregates all activities related to > improving code style guides as well as adding new tools for code analysis. > Despite the fact that expanding the code style rules and adding such checks > to the source code may take a long time, the main goals for this epic are: > - add a static code analysis automatic checks support (SpotBug) to the build; > - in terms of automatic code checking make GitHub pull requests more > convenient; > - update the checkstyle configuration; > *Cassandra code style guide*: > [https://cassandra.apache.org/_/development/code_style.html] > https://cwiki.apache.org/confluence/display/CASSANDRA2/CodeStyle > Discussion _Code style and static analysis_ on the dev list: > [https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h] > Discussion _Add SpotBugs to the build_ on the dev list: > [https://lists.apache.org/thread/1ro1mvkpvt4vr24nw7dbpdlxo82mq3hz] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-17925:
Epic Link: CASSANDRA-18090
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale: Importing all classes from a package or static
> members from a class leads to tight coupling between packages or classes and
> might lead to problems when a new version of a library introduces name
> clashes.
> This should be applied to test checktyle as well and the source code should
> be refactored on imports too.
> This should be done on cassandra-4.1 as well as for trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18089: Epic Link: CASSANDRA-18090 > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports from a package is that you can tell at a glance which > class you meant to use, which does reading and refactoring the source code > that much easier. > The checkstyle that is already used for checking the source code has a such > check and this check may be added to the config both for the production and > test source code: > https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport > Besides adding a new checkstyle rule it may be more convenient for those > community members that are working with the code to reflect the same rule in > the IDE's inspection profiles (if it's possible), thus using the 'optimize > imports' will produce the same results on each execution as the checkstyle > does. > Summary: > - add new checkstyle rule; > - update IDE's appropriate built-in inspections configurations; > - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17124) Enable checkstyle on tests
[ https://issues.apache.org/jira/browse/CASSANDRA-17124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-17124: Epic Link: CASSANDRA-18090 > Enable checkstyle on tests > -- > > Key: CASSANDRA-17124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17124 > Project: Cassandra > Issue Type: Task > Components: Test/unit >Reporter: Brandon Williams >Priority: Normal > Fix For: 4.x > > > Currently, checkstyle only runs against the source, leaving the tests with > violations. This ticket is to clean up the test code so checkstyle can be > run against it at build time. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[ https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644809#comment-17644809 ] Maxim Muzafarov commented on CASSANDRA-17797: - [~e.dimitrova], Hello, is this issue still pinned to the Grace Hopper Celebration Open Source day? It seems to me it is important for the project, so I'd like to take care of it. > All system properties and environment variables should be accessed via the > new CassandraRelevantProperties and CassandraRelevantEnv classes > --- > > Key: CASSANDRA-17797 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17797 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Ekaterina Dimitrova >Priority: Low > Labels: ghc-lhf > Fix For: 4.x > > > Follow up ticket for CASSANDRA-15876 - > "Always access system properties and environment variables via the new > CassandraRelevantProperties and CassandraRelevantEnv classes" > As part of that ticket we moved to the two new classes only > properties/variables that were currently listed in System Properties Virtual > Table. > We have to move to those classes the rest of the properties around the code > and start using those classes to access all of them. > +Additional information for newcomers:+ > You might want to start by getting acquainted with > CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might > want to check what changes were done and how the first batch was transferred > to this new framework as part of > [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e] > We are interested into the properties accessed currently through > getProperties around the code. > As part of CASSANDRA-15876 relevant unit tests were added > (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure > that all tests Cassandra pass and also to think about potential update of the > mentioned test class. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[ https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov reassigned CASSANDRA-17797: --- Assignee: Maxim Muzafarov > All system properties and environment variables should be accessed via the > new CassandraRelevantProperties and CassandraRelevantEnv classes > --- > > Key: CASSANDRA-17797 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17797 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Low > Fix For: 4.x > > > Follow up ticket for CASSANDRA-15876 - > "Always access system properties and environment variables via the new > CassandraRelevantProperties and CassandraRelevantEnv classes" > As part of that ticket we moved to the two new classes only > properties/variables that were currently listed in System Properties Virtual > Table. > We have to move to those classes the rest of the properties around the code > and start using those classes to access all of them. > +Additional information for newcomers:+ > You might want to start by getting acquainted with > CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might > want to check what changes were done and how the first batch was transferred > to this new framework as part of > [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e] > We are interested into the properties accessed currently through > getProperties around the code. > As part of CASSANDRA-15876 relevant unit tests were added > (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure > that all tests Cassandra pass and also to think about potential update of the > mentioned test class. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[
https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17645480#comment-17645480
]
Maxim Muzafarov commented on CASSANDRA-17797:
-
[~e.dimitrova]
# As I can see all the system properties that have the *"cassandra."* prefix
are already included in the virtual tables, so if we directly add them to the
_CassandraRelevantProperties_ nothing should change from the user's point of
view.
[https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/virtual/SystemPropertiesTable.java#L76]
# I also see some system properties that are not directly related to
Cassandra's project however they are used for some configurations in production
code as well as for tests e.g. [_io.netty.transport.estimateSizeOnSubmit_
|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/DatabaseDescriptor.java#L115],
[_"io.netty.eventLoopThreads"_|https://github.com/apache/cassandra/blob/trunk/test/distributed/org/apache/cassandra/distributed/test/NativeMixedVersionTest.java].
From my point of view such properties should not be part of
{_}CassandraRelevantProperties{_}, but correct me if I'm missing something here.
Am I?
# And the last point - some of the properties are used only for test/debug
purposes e.g.
["cassandra.debugrefcount"|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/concurrent/Ref.java#L96].
It seems to me that _CassandraRelevantProperties_ is related to the public API
and probably such properties should not be exposed to the public API at all.
Should I also add them to this class?
One more thing that seems to be more important here: using system properties
may affect lead to some performance issues due to the Hashtable being used
under the hood for storing them, especially those that are used really often
and are not cached to static variables.
> All system properties and environment variables should be accessed via the
> new CassandraRelevantProperties and CassandraRelevantEnv classes
> ---
>
> Key: CASSANDRA-17797
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17797
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Low
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Follow up ticket for CASSANDRA-15876 -
> "Always access system properties and environment variables via the new
> CassandraRelevantProperties and CassandraRelevantEnv classes"
> As part of that ticket we moved to the two new classes only
> properties/variables that were currently listed in System Properties Virtual
> Table.
> We have to move to those classes the rest of the properties around the code
> and start using those classes to access all of them.
> +Additional information for newcomers:+
> You might want to start by getting acquainted with
> CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might
> want to check what changes were done and how the first batch was transferred
> to this new framework as part of
> [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e]
> We are interested into the properties accessed currently through
> getProperties around the code.
> As part of CASSANDRA-15876 relevant unit tests were added
> (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure
> that all tests Cassandra pass and also to think about potential update of the
> mentioned test class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18089: Fix Version/s: 4.x > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports from a package is that you can tell at a glance which > class you meant to use, which does reading and refactoring the source code > that much easier. > The checkstyle that is already used for checking the source code has a such > check and this check may be added to the config both for the production and > test source code: > https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport > Besides adding a new checkstyle rule it may be more convenient for those > community members that are working with the code to reflect the same rule in > the IDE's inspection profiles (if it's possible), thus using the 'optimize > imports' will produce the same results on each execution as the checkstyle > does. > Summary: > - add new checkstyle rule; > - update IDE's appropriate built-in inspections configurations; > - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[
https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18089:
Test and Documentation Plan:
The documentation must be updated once an agreement on this issue will be
reached.
Test:
{{$ git fetch origin pull/ID/head:BRANCH_NAME}}
was:The documentation must be updated once an agreement on this issue will be
reached.
> The source code must obey the avoid star import checkstyle rule
> ---
>
> Key: CASSANDRA-18089
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18089
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Cassandra has the code style rules regarding the classes import order:
> [https://cassandra.apache.org/_/development/code_style.html]
> Importing all classes from a package or static members from a class leads to
> tight coupling between packages or classes and might lead to problems when a
> new library version introduces name clashes. The advantage of explicitly
> listing all imports from a package is that you can tell at a glance which
> class you meant to use, which does reading and refactoring the source code
> that much easier.
> The checkstyle that is already used for checking the source code has a such
> check and this check may be added to the config both for the production and
> test source code:
> https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport
> Besides adding a new checkstyle rule it may be more convenient for those
> community members that are working with the code to reflect the same rule in
> the IDE's inspection profiles (if it's possible), thus using the 'optimize
> imports' will produce the same results on each execution as the checkstyle
> does.
> Summary:
> - add new checkstyle rule;
> - update IDE's appropriate built-in inspections configurations;
> - update development code-style web page and wiki;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[
https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18089:
Test and Documentation Plan:
The documentation must be updated once an agreement on this issue will be
reached.
To test do the following:
{code}
$ git fetch upstream pull/2041/head:cassandra-18089
$ ant checkstyle
$ ant checkstyle-test
{code}
was:
The documentation must be updated once an agreement on this issue will be
reached.
Test:
{{$ git fetch origin pull/ID/head:BRANCH_NAME}}
> The source code must obey the avoid star import checkstyle rule
> ---
>
> Key: CASSANDRA-18089
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18089
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Cassandra has the code style rules regarding the classes import order:
> [https://cassandra.apache.org/_/development/code_style.html]
> Importing all classes from a package or static members from a class leads to
> tight coupling between packages or classes and might lead to problems when a
> new library version introduces name clashes. The advantage of explicitly
> listing all imports from a package is that you can tell at a glance which
> class you meant to use, which does reading and refactoring the source code
> that much easier.
> The checkstyle that is already used for checking the source code has a such
> check and this check may be added to the config both for the production and
> test source code:
> https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport
> Besides adding a new checkstyle rule it may be more convenient for those
> community members that are working with the code to reflect the same rule in
> the IDE's inspection profiles (if it's possible), thus using the 'optimize
> imports' will produce the same results on each execution as the checkstyle
> does.
> Summary:
> - add new checkstyle rule;
> - update IDE's appropriate built-in inspections configurations;
> - update development code-style web page and wiki;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644031#comment-17644031 ] Maxim Muzafarov edited comment on CASSANDRA-18089 at 12/6/22 9:09 PM: -- [~smiklosovic], [~mck] Hello, I'd like to propose the patch [GitHub PullRequest: 2041|https://github.com/apache/cassandra/pull/2041/files] and ask for your review. Can you review it, please? Previously, there was a discussion about the import class order in the CASSANDRA-17925. From my point of view, it will be better to merge the removal of all-star imports first by implementing an appropriate checkstyle rule, thus I created this issue. The most significant changes in this patch are: - a new _AvoidStarImport_ rule added to checkstyle.xml and checkstyle_test.xml; - the codeStyleSettings.xml migrated to a new IntelliJ IDEA format. This configuration file is deprecated since IntelliJ IDEA 2017.3 and is not used anymore. All code style settings are located under _/.idea/codeStyles_ directory and consist of the following files: codeStyleConfig.xml, Project.xml; - we have to update the Code Style in IntelliJ IDEA configuration with __ and __ ; - the formatting is updated for NetBeans also with _auxiliary.org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.useSingleClassImport=true_ the NetBeans code style configuration will obey the checkstyle rule; - it seems to me that there is no code style configuration for the Eclipse IDE, thus no changes are required here (configurations are stored in the _.metadata_ directory, located in the _eclipse-workspace_ directory and out of the project's root); - all *.java files are updated to unwrap the star with full class name imports according to the new checkstyle rule; In addition, I've run: - _the build_ [https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/6/workflows/529ea119-0d5a-474a-baba-2aeb59a091ee/jobs/14] - _j8_unit_tests_ [https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/6/workflows/529ea119-0d5a-474a-baba-2aeb59a091ee/jobs/15] was (Author: mmuzaf): [~smiklosovic], [~mck] Hello, I'd like to propose the patch [GitHub PullRequest: 2041|https://github.com/apache/cassandra/pull/2041/files] and ask for your review. Can you review it, please? Previously, there was a discussion about the import class order in the CASSANDRA-17925. From my point of view, it will be better to merge the removal of all-star imports first by implementing an appropriate checkstyle rule, thus I created this issue. The most significant changes in this patch are: - a new _AvoidStarImport_ rule added to checkstyle.xml and checkstyle_test.xml; - the codeStyleSettings.xml migrated to a new IntelliJ IDEA format. This configuration file is deprecated since IntelliJ IDEA 2017.3 and is not used anymore. All code style settings are located under _/.idea/codeStyles _directory and consist of the following files: codeStyleConfig.xml, Project.xml; - we have to update the Code Style in IntelliJ IDEA configuration with __ and __ ; - the formatting is updated for NetBeans also with _auxiliary.org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.useSingleClassImport=true_ the NetBeans code style configuration will obey the checkstyle rule; - it seems to me that there is no code style configuration for the Eclipse IDE, thus no changes are required here (configurations are stored in the _.metadata_ directory, located in the _eclipse-workspace_ directory and out of the project's root); - all *.java files are updated to unwrap the star with full class name imports according to the new checkstyle rule; In addition, I've run: - _the build_ [https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/6/workflows/529ea119-0d5a-474a-baba-2aeb59a091ee/jobs/14] - _j8_unit_tests_ [https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/6/workflows/529ea119-0d5a-474a-baba-2aeb59a091ee/jobs/15] > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports
[jira] [Commented] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17644031#comment-17644031 ] Maxim Muzafarov commented on CASSANDRA-18089: - [~smiklosovic], [~mck] Hello, I'd like to propose the patch [GitHub PullRequest: 2041|https://github.com/apache/cassandra/pull/2041/files] and ask for your review. Can you review it, please? Previously, there was a discussion about the import class order in the CASSANDRA-17925. From my point of view, it will be better to merge the removal of all-star imports first by implementing an appropriate checkstyle rule, thus I created this issue. The most significant changes in this patch are: - a new _AvoidStarImport_ rule added to checkstyle.xml and checkstyle_test.xml; - the codeStyleSettings.xml migrated to a new IntelliJ IDEA format. This configuration file is deprecated since IntelliJ IDEA 2017.3 and is not used anymore. All code style settings are located under _/.idea/codeStyles _directory and consist of the following files: codeStyleConfig.xml, Project.xml; - we have to update the Code Style in IntelliJ IDEA configuration with __ and __ ; - the formatting is updated for NetBeans also with _auxiliary.org-netbeans-modules-editor-indent.text.x-java.CodeStyle.project.useSingleClassImport=true_ the NetBeans code style configuration will obey the checkstyle rule; - it seems to me that there is no code style configuration for the Eclipse IDE, thus no changes are required here (configurations are stored in the _.metadata_ directory, located in the _eclipse-workspace_ directory and out of the project's root); - all *.java files are updated to unwrap the star with full class name imports according to the new checkstyle rule; In addition, I've run: - _the build_ [https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/6/workflows/529ea119-0d5a-474a-baba-2aeb59a091ee/jobs/14] - _j8_unit_tests_ [https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/6/workflows/529ea119-0d5a-474a-baba-2aeb59a091ee/jobs/15] > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports from a package is that you can tell at a glance which > class you meant to use, which does reading and refactoring the source code > that much easier. > The checkstyle that is already used for checking the source code has a such > check and this check may be added to the config both for the production and > test source code: > https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport > Besides adding a new checkstyle rule it may be more convenient for those > community members that are working with the code to reflect the same rule in > the IDE's inspection profiles (if it's possible), thus using the 'optimize > imports' will produce the same results on each execution as the checkstyle > does. > Summary: > - add new checkstyle rule; > - update IDE's appropriate built-in inspections configurations; > - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18089: Test and Documentation Plan: The documentation must be updated once an agreement on this issue will be reached. Status: Patch Available (was: In Progress) > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports from a package is that you can tell at a glance which > class you meant to use, which does reading and refactoring the source code > that much easier. > The checkstyle that is already used for checking the source code has a such > check and this check may be added to the config both for the production and > test source code: > https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport > Besides adding a new checkstyle rule it may be more convenient for those > community members that are working with the code to reflect the same rule in > the IDE's inspection profiles (if it's possible), thus using the 'optimize > imports' will produce the same results on each execution as the checkstyle > does. > Summary: > - add new checkstyle rule; > - update IDE's appropriate built-in inspections configurations; > - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[ https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648597#comment-17648597 ] Maxim Muzafarov commented on CASSANDRA-17797: - [~e.dimitrova], [~smiklosovic] I'm not familiar with the Butler tool, however, I think I figured out how it works. Despite that, I've failed to find any documentation pages (on Google, or Apache Wiki) and sources. Do you have any links to share? Here is the link to the comparsion: [https://butler.cassandra.apache.org/?#/ci/upstream/compare/Cassandra-trunk/cassandra-17797] I've checked tests labelled with `rgrsn` locally and it seems those test fails are not related to my changes. I think despite the fact that the test flask they may start to fall with another error/stack trace - does the Butler cover this case? Nevertheless, I've checked them too for an errors related to system properties. This failing tests I've also re-run locally: [https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2103/testReport/] Sorry, if I've missed something. I didn't have and experience with this tool yet. > All system properties and environment variables should be accessed via the > new CassandraRelevantProperties and CassandraRelevantEnv classes > --- > > Key: CASSANDRA-17797 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17797 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Low > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Follow up ticket for CASSANDRA-15876 - > "Always access system properties and environment variables via the new > CassandraRelevantProperties and CassandraRelevantEnv classes" > As part of that ticket we moved to the two new classes only > properties/variables that were currently listed in System Properties Virtual > Table. > We have to move to those classes the rest of the properties around the code > and start using those classes to access all of them. > +Additional information for newcomers:+ > You might want to start by getting acquainted with > CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might > want to check what changes were done and how the first batch was transferred > to this new framework as part of > [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e] > We are interested into the properties accessed currently through > getProperties around the code. > As part of CASSANDRA-15876 relevant unit tests were added > (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure > that all tests Cassandra pass and also to think about potential update of the > mentioned test class. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-11994) Expose metrics via CQL interface
[ https://issues.apache.org/jira/browse/CASSANDRA-11994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov reassigned CASSANDRA-11994: --- Assignee: Maxim Muzafarov > Expose metrics via CQL interface > > > Key: CASSANDRA-11994 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11994 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Observability, Observability/Metrics >Reporter: Patrick McFadin >Assignee: Maxim Muzafarov >Priority: Normal > Labels: cql, operations > > This is an attempt to revive the concept introduced in CASSANDRA-3527. > Instead of specifically targeting JMX metrics, simplify by just exposing > metrics into CQL tables as a dynamic view. > Exposing these metrics will give operators vital insight without resorting to > anything more than what is installed with Apache Cassandra. > The scope of these tickets is only for reading metrics with a SELECT command. > The actual data model can be discussed in the comments below. > Some basic requirements I would propose: > - SELECT syntax should allow for single node or cluster wide statistics > - Aggregations should be supported (min, max, avg) > - Inside metric tables, future column additions should be automatically > created when new metrics are added to a family > - Large schema changes such as deletes should be postponed to a major > release -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Description:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
below shows how _CASSANDRA-*_ letters are turned on in the commit message to an
appropriate Cassandra Jira link:
{{!attachedimage.gif!}}
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
was:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
below shows how _CASSANDRA-*_ letters are turned on in the commit message to an
appropriate Cassandra Jira link:
!https://files.slack.com/files-pri/T4S1WH2J3-F04FW0ZCA02/image.png!
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
> Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
> ---
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Attachments: Cassandra Apache Jira Link.png
>
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example below shows how _CASSANDRA-*_ letters are turned on in
> the commit message to an appropriate Cassandra Jira link:
>
> {{!attachedimage.gif!}}
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update the {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Attachment: Cassandra Apache Jira Link.png
> Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
> ---
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Attachments: Cassandra Apache Jira Link.png
>
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example below shows how _CASSANDRA-*_ letters are turned on in
> the commit message to an appropriate Cassandra Jira link:
> !https://files.slack.com/files-pri/T4S1WH2J3-F04FW0ZCA02/image.png!
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update the {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18126) Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
Maxim Muzafarov created CASSANDRA-18126:
---
Summary: Add to the IntelliJ Git Window an issue navigation link
to Cassandra's Jira
Key: CASSANDRA-18126
URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
Project: Cassandra
Issue Type: Task
Reporter: Maxim Muzafarov
Assignee: Maxim Muzafarov
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
below shows how _CASSANDRA-*_ letters are turned on in the commit message to an
appropriate Cassandra Jira link:
!https://files.slack.com/files-pri/T4S1WH2J3-F04FW0ZCA02/image.png!
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Description:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
below shows how _CASSANDRA-*_ letters are turned on in the commit message to an
appropriate Cassandra Jira link:
!Cassandra Apache Jira Link.png|thumbnail!
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
was:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
below shows how _CASSANDRA-*_ letters are turned on in the commit message to an
appropriate Cassandra Jira link:
!Cassandra Apache Jira Link.png!
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
> Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
> ---
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Attachments: Cassandra Apache Jira Link.png
>
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example below shows how _CASSANDRA-*_ letters are turned on in
> the commit message to an appropriate Cassandra Jira link:
> !Cassandra Apache Jira Link.png|thumbnail!
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update the {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Description:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
below shows how _CASSANDRA-*_ letters are turned on in the commit message to an
appropriate Cassandra Jira link:
!Cassandra Apache Jira Link.png!
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
was:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
below shows how _CASSANDRA-*_ letters are turned on in the commit message to an
appropriate Cassandra Jira link:
{{!attachedimage.gif!}}
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
> Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
> ---
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Attachments: Cassandra Apache Jira Link.png
>
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example below shows how _CASSANDRA-*_ letters are turned on in
> the commit message to an appropriate Cassandra Jira link:
> !Cassandra Apache Jira Link.png!
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update the {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Description:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
in the attachments shows how _CASSANDRA-*_ letters are turned on in the commit
message to an appropriate Cassandra Jira link.
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
was:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
below shows how _CASSANDRA-*_ letters are turned on in the commit message to an
appropriate Cassandra Jira link:
!Cassandra Apache Jira Link.png|thumbnail!
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
> Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
> ---
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Attachments: Cassandra Apache Jira Link.png
>
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update the {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17649505#comment-17649505
]
Maxim Muzafarov commented on CASSANDRA-18126:
-
[~dcapwell]
Hello, please, take a look at my patch - [GitHub PullRequest:
2059|https://github.com/apache/cassandra/pull/2059/files].
I have not added any comments to the {{CHANGES.txt}} file since the changes are
not related to any Cassandra release.
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: NA
>
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Summary: Add to the IntelliJ Git Window issue navigation links to
Cassandra's Jira (was: Add to the IntelliJ Git Window an issue navigation link
to Cassandra's Jira)
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Description:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
in the attachments shows how _CASSANDRA-*_ letters are turned on in the commit
message to an appropriate Cassandra Jira link.
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update your {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
was:
It is possible to navigate from the IntelliJ IDEA Git window to a corresponding
Cassandra issue, the Apache Jira if mentioned in the git message. The example
in the attachments shows how _CASSANDRA-*_ letters are turned on in the commit
message to an appropriate Cassandra Jira link.
We should update the IntelliJ IDEA configuration and make this behaviour a
default for the {{ant generate-idea-files}} process.
To achieve this manually you can update the {{.idea/vcs.xml}} file in the
Cassandra project with the following:
{code:java}
https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
{code}
> Add to the IntelliJ Git Window an issue navigation link to Cassandra's Jira
> ---
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Fix Version/s: 4.x
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 4.x
>
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Fix Version/s: NA
(was: 4.x)
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: NA
>
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Test and Documentation Plan: Run {{ant generate-idea-files}} from the
command line in the Cassandra project.
Status: Patch Available (was: Open)
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: NA
>
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18126) Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
[
https://issues.apache.org/jira/browse/CASSANDRA-18126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18126:
Change Category: Code Clarity
Complexity: Low Hanging Fruit
Component/s: Build
Reviewers: David Capwell
Status: Open (was: Triage Needed)
> Add to the IntelliJ Git Window issue navigation links to Cassandra's Jira
> -
>
> Key: CASSANDRA-18126
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18126
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: NA
>
> Attachments: Cassandra Apache Jira Link.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is possible to navigate from the IntelliJ IDEA Git window to a
> corresponding Cassandra issue, the Apache Jira if mentioned in the git
> message. The example in the attachments shows how _CASSANDRA-*_ letters are
> turned on in the commit message to an appropriate Cassandra Jira link.
> We should update the IntelliJ IDEA configuration and make this behaviour a
> default for the {{ant generate-idea-files}} process.
> To achieve this manually you can update your {{.idea/vcs.xml}} file in the
> Cassandra project with the following:
> {code:java}
>
>
>
>
>
>
>
>
>
>
> name="linkRegexp"value="https://issues.apache.org/jira/browse/CASSANDRA-$1"/>
>
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[ https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-17797: Impacts: None,Docs (was: None) Test and Documentation Plan: The patch requires running all tests related to the CI part. Documentation is not required for now due to no new system properties were added. Status: Patch Available (was: In Progress) > All system properties and environment variables should be accessed via the > new CassandraRelevantProperties and CassandraRelevantEnv classes > --- > > Key: CASSANDRA-17797 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17797 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Low > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Follow up ticket for CASSANDRA-15876 - > "Always access system properties and environment variables via the new > CassandraRelevantProperties and CassandraRelevantEnv classes" > As part of that ticket we moved to the two new classes only > properties/variables that were currently listed in System Properties Virtual > Table. > We have to move to those classes the rest of the properties around the code > and start using those classes to access all of them. > +Additional information for newcomers:+ > You might want to start by getting acquainted with > CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might > want to check what changes were done and how the first batch was transferred > to this new framework as part of > [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e] > We are interested into the properties accessed currently through > getProperties around the code. > As part of CASSANDRA-15876 relevant unit tests were added > (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure > that all tests Cassandra pass and also to think about potential update of the > mentioned test class. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[
https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17646618#comment-17646618
]
Maxim Muzafarov commented on CASSANDRA-17797:
-
Hey,
[~mck], [~e.dimitrova]
Please, take a look at my pull request - [GitHub PullRequest:
2010|https://github.com/apache/cassandra/pull/2046/files]. As you mentioned
earlier, we will expose some added system properties (properties with
_cassandra._ prefix are already exposed) to the public API via a virtual table.
If we agree on this pull request in general I'll post a new message to the dev
list to share it with the community.
I think it may be a good idea to add a new column to the system properties
virtual table thus users will be able to see the impact of a particular
property on their production environment. The list properties are easy to
filter. To achieve this goal I've marked the properties related to the test
environment with the {_}TEST_{_} prefix. If we agree on this I can create a new
JIRA issue.
h3. The implementation notes
- the checkstyle rule added to force the CassandraRelevantProperties usage;
- the enum pattern that was used: upper-casing property name with replacing
{*}`{*}{_}.`{*}{*}{_} to *{_}`{_}`* _and removing _cassandra._ prefix;
- all newly added properties are sorted by their name;
- properties that are related to test/debug are marked with the {_}TEST{_}_
prefix;
- setInt(), setString() etc. now return the previous value for convenient
usage in the test source code;
h3. The public API changes
Newly production system properties added:
- io.netty.eventLoopThreads
- io.netty.transport.estimateSizeOnSubmit
- java.security.auth.login.config
- javax.rmi.ssl.client.enabledCipherSuites
- javax.rmi.ssl.client.enabledProtocols
- ssl.enable
- log4j2.disable.jmx
- log4j2.shutdownHookEnabled
- logback.configurationFile
Newly added and used for tests only:
- invalid-legacy-sstable-root
- legacy-sstable-root
- org.apache.cassandra.tools.UtilALLOW_TOOL_REINIT_FOR_TEST
- org.caffinitas.ohc.segmentCount
- suitename
- sun.stderr.encoding
- sun.stdout.encoding
- test.bbfailhelper.enabled
- write_survey
I've run some tests over my PR, but I'm not sure that I did everything
correctly since I have a lack of experience with the Cassandras test for now. I
will be very appreciative if you tell me what I should pay attention to first.
https://app.circleci.com/pipelines/github/Mmuzaf/cassandra/23/workflows/91bae849-8d91-47d0-8bc6-d9fc6ac7dd76
https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2100/
> All system properties and environment variables should be accessed via the
> new CassandraRelevantProperties and CassandraRelevantEnv classes
> ---
>
> Key: CASSANDRA-17797
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17797
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
>Reporter: Ekaterina Dimitrova
>Assignee: Maxim Muzafarov
>Priority: Low
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Follow up ticket for CASSANDRA-15876 -
> "Always access system properties and environment variables via the new
> CassandraRelevantProperties and CassandraRelevantEnv classes"
> As part of that ticket we moved to the two new classes only
> properties/variables that were currently listed in System Properties Virtual
> Table.
> We have to move to those classes the rest of the properties around the code
> and start using those classes to access all of them.
> +Additional information for newcomers:+
> You might want to start by getting acquainted with
> CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might
> want to check what changes were done and how the first batch was transferred
> to this new framework as part of
> [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e]
> We are interested into the properties accessed currently through
> getProperties around the code.
> As part of CASSANDRA-15876 relevant unit tests were added
> (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure
> that all tests Cassandra pass and also to think about potential update of the
> mentioned test class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
Maxim Muzafarov created CASSANDRA-18089: --- Summary: The source code must obey the avoid star import checkstyle rule Key: CASSANDRA-18089 URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 Project: Cassandra Issue Type: Improvement Reporter: Maxim Muzafarov Assignee: Maxim Muzafarov Cassandra has the code style rules regarding the classes import order: [https://cassandra.apache.org/_/development/code_style.html] Importing all classes from a package or static members from a class leads to tight coupling between packages or classes and might lead to problems when a new library version introduces name clashes. The advantage of explicitly listing all imports from a package is that you can tell at a glance which class you meant to use, which does reading and refactoring the source code that much easier. The checkstyle that is already used for checking the source code has a such check and this check may be added to the config both for the production and test source code: https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport Besides adding a new checkstyle rule it may be more convenient for those community members that are working with the code to reflect the same rule in the IDE's inspection profiles (if it's possible), thus using the 'optimize imports' will produce the same results on each execution as the checkstyle does. Summary: - add new checkstyle rule; - update IDE's appropriate built-in inspections configurations; - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Created] (CASSANDRA-18090) Expansion of automatic source code checking tools
Maxim Muzafarov created CASSANDRA-18090: --- Summary: Expansion of automatic source code checking tools Key: CASSANDRA-18090 URL: https://issues.apache.org/jira/browse/CASSANDRA-18090 Project: Cassandra Issue Type: Epic Reporter: Maxim Muzafarov This is an umbrella ticket that aggregates all activities related to improving code style guides as well as adding new tools for code analysis. Despite the fact that expanding the code style rules and adding such checks to the source code may take a long time, the main goals for this epic are: - add a static code analysis automatic checks support (SpotBug) to the build; - in terms of automatic code checking make GitHub pull requests more convenient; - update the checkstyle configuration; *Cassandra code style guide*: [https://cassandra.apache.org/_/development/code_style.html] https://cwiki.apache.org/confluence/display/CASSANDRA2/CodeStyle Discussion _Code style and static analysis_ on the dev list: [https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h] Discussion _Add SpotBugs to the build_ on the dev list: [https://lists.apache.org/thread/1ro1mvkpvt4vr24nw7dbpdlxo82mq3hz] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18090) Cassandra code style and static analysys
[ https://issues.apache.org/jira/browse/CASSANDRA-18090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18090: Summary: Cassandra code style and static analysys (was: Expansion of automatic source code checking tools) > Cassandra code style and static analysys > > > Key: CASSANDRA-18090 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18090 > Project: Cassandra > Issue Type: Epic >Reporter: Maxim Muzafarov >Priority: Normal > > This is an umbrella ticket that aggregates all activities related to > improving code style guides as well as adding new tools for code analysis. > Despite the fact that expanding the code style rules and adding such checks > to the source code may take a long time, the main goals for this epic are: > - add a static code analysis automatic checks support (SpotBug) to the build; > - in terms of automatic code checking make GitHub pull requests more > convenient; > - update the checkstyle configuration; > *Cassandra code style guide*: > [https://cassandra.apache.org/_/development/code_style.html] > https://cwiki.apache.org/confluence/display/CASSANDRA2/CodeStyle > Discussion _Code style and static analysis_ on the dev list: > [https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h] > Discussion _Add SpotBugs to the build_ on the dev list: > [https://lists.apache.org/thread/1ro1mvkpvt4vr24nw7dbpdlxo82mq3hz] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov reassigned CASSANDRA-17925:
---
Assignee: Maxim Muzafarov
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale: Importing all classes from a package or static
> members from a class leads to tight coupling between packages or classes and
> might lead to problems when a new version of a library introduces name
> clashes.
> This should be applied to test checktyle as well and the source code should
> be refactored on imports too.
> This should be done on cassandra-4.1 as well as for trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640746#comment-17640746
]
Maxim Muzafarov commented on CASSANDRA-17925:
-
I'm sorry for such seditious thoughts, but...
Is it possible to remove the
[ide|https://github.com/Mmuzaf/cassandra/tree/trunk/ide] directory from the VCS
at all?
It is very rarely updated (only a few commits for the last 7 years).
We can take the actual IDE configurations from the community members who
actually use these IDEs with Cassandra every day and put them in the project's
root folder (like it happened for the CI tools .jenkins, .circleci, .github
before). At the first glance, it may look weird, but it seems this is a common
practice for sharing IDE configurations as mentioned here [1]. One of the
biggest benefits of such change - community members will immediately be able to
use new updated code style profiles from the VCS once they are switched to the
trunk (no need to rebuild code style with ant). As another benefit, we can
remove the 'generate-idea-files' from the build.xml and simplify the ant file
even more.
As soon as the checkstyle configuration is filled with a large number of new
rules we will remove the IDE-specific directories (e.g. .idea) and make
checkstyle a single point for code style rules (keeping the wiki and web pages
as human-readable code style).
For the current issue it is better to split it into two commits:
1. remove star-imports from the source code in the trunk (and optional for
4.1), and add such checkstyle rule for production code as well as for tests;
2. agree on the import order with the community and add an appropriate
checkstyle rule;
The steps above will simplify solving merge conflicts if any occur.
[1]
https://www.jetbrains.com/help/objc/share-project-settings.html#share-global-settings
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale: Importing all classes from a package or static
> members from a class leads to tight coupling between packages or classes and
> might lead to problems when a new version of a library introduces name
> clashes.
> This should be applied to test checktyle as well and the source code should
> be refactored on imports too.
> This should be done on cassandra-4.1 as well as for trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17797) All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes
[ https://issues.apache.org/jira/browse/CASSANDRA-17797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677516#comment-17677516 ] Maxim Muzafarov commented on CASSANDRA-17797: - [~smiklosovic] , [~e.dimitrova] Hello, I've fixed all the comments in the PR: [#2046|https://github.com/apache/cassandra/pull/2046] The changes are also rebased on the top of the trunk branch. I've checked Jenkins and Butler below for any suspicious failures. Hopefully, all the failures were resolved by me. Can you take a final review of the PR? [https://ci-cassandra.apache.org/job/Cassandra-devbranch/2200/] [https://butler.cassandra.apache.org/?#/ci/upstream/compare/Cassandra-trunk/cassandra-17797] > All system properties and environment variables should be accessed via the > new CassandraRelevantProperties and CassandraRelevantEnv classes > --- > > Key: CASSANDRA-17797 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17797 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config >Reporter: Ekaterina Dimitrova >Assignee: Maxim Muzafarov >Priority: Low > Fix For: 4.x > > Time Spent: 13h 50m > Remaining Estimate: 0h > > Follow up ticket for CASSANDRA-15876 - > "Always access system properties and environment variables via the new > CassandraRelevantProperties and CassandraRelevantEnv classes" > As part of that ticket we moved to the two new classes only > properties/variables that were currently listed in System Properties Virtual > Table. > We have to move to those classes the rest of the properties around the code > and start using those classes to access all of them. > +Additional information for newcomers:+ > You might want to start by getting acquainted with > CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might > want to check what changes were done and how the first batch was transferred > to this new framework as part of > [CASSANDRA-15876|https://github.com/apache/cassandra/commit/7694c1d191531ac152db55e83bc0db6864a5441e] > We are interested into the properties accessed currently through > getProperties around the code. > As part of CASSANDRA-15876 relevant unit tests were added > (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure > that all tests Cassandra pass and also to think about potential update of the > mentioned test class. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679968#comment-17679968
]
Maxim Muzafarov commented on CASSANDRA-17925:
-
This is the discussion on the dev-list about the classes import order
[https://lists.apache.org/thread/d7wgg5hf4khzkwyd3hgnooowxl5b8dg1]
While preparing the code style configuration for the Eclipse IDE, I discovered
that there was no easy way to have complex grouping options for the set of
packages. So we need to add extra blank lines between each group of packages so
that all the configurations for Eclipse, NetBeans, IntelliJ IDEA and checkstyle
are aligned. I should have checked this earlier for sure, but I only did it for
static imports and some groups, my bad. The resultant configuration looks like
this:
{code:java}
java.*
[blank line]
javax.*
[blank line]
com.*
[blank line]
net.*
[blank line]
org.*
[blank line]
org.apache.cassandra.*
[blank line]
all other imports
[blank line]
static all other imports
{code}
The changes include:
* The AvoidStarImport and ImportOrder rules were added to checkstyle.xml and
checkstyle_test.xml;
* The codeStyleSettings.xml migrated to a new IntelliJ IDEA format. This
configuration file is deprecated since IntelliJ IDEA 2017.3 and is not used
anymore. All code style settings are located under
/.idea/codeStyles directory and consist of the following files:
codeStyleConfig.xml, Project.xml;
* The Eclipse code style configuration was added from the link mentioned in
the documentation pages: [https://github.com/tjake/cassandra-style-eclipse]
The pull request is here:
[GitHub PullRequest: 2108|https://github.com/apache/cassandra/pull/2108]
The configuration-related changes are placed in a dedicated commit, so it
should be easy to make a review:
[84e292ddc9671a0be76ceb9304b2b9a051c2d52a|https://github.com/apache/cassandra/pull/2108/commits/84e292ddc9671a0be76ceb9304b2b9a051c2d52a]
The Jenkins build is here:
[https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2215/]
Another important thing to mention is that the total amount of changes for
organising imports is really big (more than 2000 files!), so we need to decide
the right time to merge this PR. Although rebasing or merging changes to
development branches should become much easier ("Accept local" + "Organize
imports"), we still need to pay extra attention here to minimise the impact on
major patches for the next release.
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale:
[jira] [Updated] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-17925:
Test and Documentation Plan:
The documentation must be updated once an agreement on this issue will be
reached.
To test do the following:
{code:java}
$ git fetch upstream pull/2108/head:cassandra-17925
$ ant checkstyle
$ ant checkstyle-test{code}
Status: Patch Available (was: In Progress)
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale: Importing all classes from a package or static
> members from a class leads to tight coupling between packages or classes and
> might lead to problems when a new version of a library introduces name
> clashes.
> This should be applied to test checktyle as well and the source code should
> be refactored on imports too.
> This should be done on cassandra-4.1 as well as for trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-17925:
Fix Version/s: 4.x
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Fix For: 4.x
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale: Importing all classes from a package or static
> members from a class leads to tight coupling between packages or classes and
> might lead to problems when a new version of a library introduces name
> clashes.
> This should be applied to test checktyle as well and the source code should
> be refactored on imports too.
> This should be done on cassandra-4.1 as well as for trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679646#comment-17679646 ] Maxim Muzafarov commented on CASSANDRA-18089: - [~e.dimitrova] you're right. The work will be completed under CASSANDRA-17925 So, yes, probably the "duplicate" status is more correct here. > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports from a package is that you can tell at a glance which > class you meant to use, which does reading and refactoring the source code > that much easier. > The checkstyle that is already used for checking the source code has a such > check and this check may be added to the config both for the production and > test source code: > https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport > Besides adding a new checkstyle rule it may be more convenient for those > community members that are working with the code to reflect the same rule in > the IDE's inspection profiles (if it's possible), thus using the 'optimize > imports' will produce the same results on each execution as the checkstyle > does. > Summary: > - add new checkstyle rule; > - update IDE's appropriate built-in inspections configurations; > - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18089: Resolution: Won't Fix Status: Resolved (was: Open) I've cancelled the patch. According to the dev-list discussion we've decided to implement at once both of the checkstyle rules: AvoidStarImport and ImportOrder. This is the issue to reference to: CASSANDRA-17925 > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports from a package is that you can tell at a glance which > class you meant to use, which does reading and refactoring the source code > that much easier. > The checkstyle that is already used for checking the source code has a such > check and this check may be added to the config both for the production and > test source code: > https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport > Besides adding a new checkstyle rule it may be more convenient for those > community members that are working with the code to reflect the same rule in > the IDE's inspection profiles (if it's possible), thus using the 'optimize > imports' will produce the same results on each execution as the checkstyle > does. > Summary: > - add new checkstyle rule; > - update IDE's appropriate built-in inspections configurations; > - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18089) The source code must obey the avoid star import checkstyle rule
[ https://issues.apache.org/jira/browse/CASSANDRA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18089: Status: Open (was: Patch Available) > The source code must obey the avoid star import checkstyle rule > --- > > Key: CASSANDRA-18089 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18089 > Project: Cassandra > Issue Type: Improvement > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra has the code style rules regarding the classes import order: > [https://cassandra.apache.org/_/development/code_style.html] > Importing all classes from a package or static members from a class leads to > tight coupling between packages or classes and might lead to problems when a > new library version introduces name clashes. The advantage of explicitly > listing all imports from a package is that you can tell at a glance which > class you meant to use, which does reading and refactoring the source code > that much easier. > The checkstyle that is already used for checking the source code has a such > check and this check may be added to the config both for the production and > test source code: > https://checkstyle.sourceforge.io/config_imports.html#AvoidStaticImport > Besides adding a new checkstyle rule it may be more convenient for those > community members that are working with the code to reflect the same rule in > the IDE's inspection profiles (if it's possible), thus using the 'optimize > imports' will produce the same results on each execution as the checkstyle > does. > Summary: > - add new checkstyle rule; > - update IDE's appropriate built-in inspections configurations; > - update development code-style web page and wiki; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-17925) Java source code should have sorted imports as defined in the codestyle
[
https://issues.apache.org/jira/browse/CASSANDRA-17925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-17925:
Change Category: Code Clarity
Complexity: Normal
Component/s: Build
Status: Open (was: Triage Needed)
> Java source code should have sorted imports as defined in the codestyle
> ---
>
> Key: CASSANDRA-17925
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17925
> Project: Cassandra
> Issue Type: Improvement
> Components: Build
>Reporter: Stefan Miklosovic
>Assignee: Maxim Muzafarov
>Priority: Normal
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After we cleaned all unused imports in CASSANDRA-17876, there is one more
> task remaining to be done - to add checkstyle for imports order and enforce
> this on build time.
> When the project is imported into IDEA, there is a helper target on Ant
> called "generate-idea-files". ide/idea/codeStyleSettings.xml contains this:
> {code:java}
>
>
>
>
>
> static="false" />
> static="false" />
> static="false" />
> static="false" />
>
>
>
>
>
>
>
>
> {code}
> This code style is also mentioned in the web page here (minus some details
> which are present in above configuration snippet but not on the web page):
> [https://cassandra.apache.org/_/development/code_style.html] (at the very
> bottom).
> However, when one runs "Optimise imports" in the context menu after
> right-clicking on org.cassandra.apache package, it will refactor the imports
> and it results with hundreds of changes.
> This means that the source code, as-is, does not adhere to the self-imposed
> code style we ship for IDEA.
> If we fix this, we should add checkstyle for it like this:
> {code:java}
>
>value="/(^java\.|javax)/,/(com\.google\.common|org\.apache\.log4j|org\.apache\.commons|org\.cliffc\.high_scale_lib|org\.junit|org\.slf4j)/"/>
>
>
>
>
>
>
> {code}
> This checkstyle on import order will pass on the source code we run the
> import optimization in the context menu on.
> There is also no enforcement on "all star" imports (org.some.pkg.*).
> Checkstyle has specific module for this:
> [https://checkstyle.org/config_imports.html#AvoidStarImport]
> I propose we should stop to use all-star imports. Same argument holds as
> described there: Rationale: Importing all classes from a package or static
> members from a class leads to tight coupling between packages or classes and
> might lead to problems when a new version of a library introduces name
> clashes.
> This should be applied to test checktyle as well and the source code should
> be refactored on imports too.
> This should be done on cassandra-4.1 as well as for trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18077) Add SpotBugs to the build
[ https://issues.apache.org/jira/browse/CASSANDRA-18077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18077: Epic Link: CASSANDRA-18090 > Add SpotBugs to the build > - > > Key: CASSANDRA-18077 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18077 > Project: Cassandra > Issue Type: Improvement > Components: Build, CI >Reporter: David Capwell >Priority: Normal > Fix For: 5.x > > Attachments: spotbugs.html > > Time Spent: 50m > Remaining Estimate: 0h > > When working on CASSANDRA-17178 I found that several classes were being > reported by the Simulator for not defining serializer version when they are > Serializable; this may cause issues for the Simulator so felt it would be > best to detect these earlier on before merging new ones. > SpotBugs has a large set of checks, some more valuable than others for the > project; so we should maintain a curated list of issues to fail the build on, > and others to warn on. > This topic was discussed in the following mail threads: > * Should we add?: > https://lists.apache.org/thread/1ro1mvkpvt4vr24nw7dbpdlxo82mq3hz > * Should we fix UTF-8 issues? > https://lists.apache.org/thread/sokxf46s7hyoxr9q4wm7dv3q2nm19nt3 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Muzafarov updated CASSANDRA-18239:
Epic Link: CASSANDRA-18090
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698623#comment-17698623
]
Maxim Muzafarov commented on CASSANDRA-18239:
-
My guess is that we can use an IDE-agnostic tool to perform static code
analysis, so Checkstyle + Sonar is a very good choice. I was mentioning it here:
[https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h]
So we can remove the eclipse-warnings because they don't give us the expected
accuracy for source code checks, this will simplify the maintenance. I think it
will be better to have the shared Intellij code-style and inspections config as
I described it here CASSANDRA-18277 (we have almost everything for it).
Should we create an issue to configure Sonar's statistics updates on a commit
to the trunk (guess we can use GitHub Actions here)?
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-18277) Move the IntelliJ Idea code style and inspections configuration to the project's root .idea directory
[ https://issues.apache.org/jira/browse/CASSANDRA-18277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-18277: Epic Link: CASSANDRA-18090 > Move the IntelliJ Idea code style and inspections configuration to the > project's root .idea directory > - > > Key: CASSANDRA-18277 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18277 > Project: Cassandra > Issue Type: Task > Components: Build >Reporter: Maxim Muzafarov >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > > h4. Current State > Each IDE supported by Cassandra has its own configuration files, which we > store in a special 'ide' directory in the project root. idea - for the > IntelliJ IDEA configuration, nbproject - for the NetBeans, and there is > currently no directory for the Eclipse configuration exist. > We use ant tasks for initial project setup for a particular IDE: > * generate-idea-files > * generate-eclipse-files > For NetBeans you always choose the ide/nbproject directory as the root of the > project, so that the code style configuration for the NetBeans is always > shared between developers. > h4. The Issues With Current State > There are a few inconveniences we are currently facing that could be resolved > by sharing the IntelliJ IDEA code style settings through VCS: > # Once a new checkstyle lint is implemented, and the IDE's code style > configuration is updated they are not immediately available to a developer. > The developer must track the git history to use the latest code style changes > and manually copy the updated code style files into the .idea directory, or > re-run the generate-idea-files task which will erase any locally saved > settings (e.g. words dictionaries); > # The code style usually changes by adding new rules one by one, and new > checkstyle lints are implemented, so it may differ between release branches. > It is a common practice to keep the code style on the same branch so that > IntelliJ can use an appropriate configuration for the branch being checked > out. > # The IntelliJ IDEA code style configuration format that stored the > codeStyleSettings.xml file is outdated, from version 2017.3 the codeStyle > directory is used. This prevents us from updating the code style > configuration without a lot of tedious manual changes. > The share project settings through VCS approach is well described in the > documentation pages: > https://www.jetbrains.com/help/idea/configure-project-settings.html#share-project-through-vcs > h4. What To Do > # Migrate the IntelliJ code style configuration to the new format, assuming > nobody is using such an old version of IntelliJ IDEA; > # Move the code style configuration and inspections configuration files to > the project's root .idea directory to address the issues described above; > # Rely on the IntelliJ IDEA code style for backward compatibility instead of > supporting it ourselves; -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Comment Edited] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698623#comment-17698623
]
Maxim Muzafarov edited comment on CASSANDRA-18239 at 3/9/23 9:50 PM:
-
My guess is that we can use an IDE-agnostic tool to perform static code
analysis, so Checkstyle + SpotBug + Sonar is a very good choice. I was
mentioning it here:
[https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h]
So we can remove the eclipse-warnings because they don't give us the expected
accuracy for source code checks, this will simplify the maintenance. I think it
will be better to have the shared Intellij code-style and inspections config as
I described it here CASSANDRA-18277 (we have almost everything for it).
Should we create an issue to configure Sonar's statistics updates on a commit
to the trunk (guess we can use GitHub Actions here)?
was (Author: mmuzaf):
My guess is that we can use an IDE-agnostic tool to perform static code
analysis, so Checkstyle + Sonar is a very good choice. I was mentioning it here:
[https://lists.apache.org/thread/11j0hrv2bkx60xk7zvlgqgjwo982qv6h]
So we can remove the eclipse-warnings because they don't give us the expected
accuracy for source code checks, this will simplify the maintenance. I think it
will be better to have the shared Intellij code-style and inspections config as
I described it here CASSANDRA-18277 (we have almost everything for it).
Should we create an issue to configure Sonar's statistics updates on a commit
to the trunk (guess we can use GitHub Actions here)?
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[
https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700746#comment-17700746
]
Maxim Muzafarov commented on CASSANDRA-17971:
-
[~e.dimitrova],
Thank you, I missed that script.
Should the {{InterceptClasses#BYTECODE_VERSION = Opcodes.ASM7}} but updated
also, or am I missing something here too?
https://github.com/apache/cassandra/blob/trunk/test/simulator/asm/org/apache/cassandra/simulator/asm/InterceptClasses.java#L51
> Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
>
>
> Key: CASSANDRA-17971
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17971
> Project: Cassandra
> Issue Type: Task
> Components: Build, Dependencies, Feature/UDF
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.0
>
>
> In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we
> need to revise it again before we switch fro jdk8&11 to jdk11&17
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703801#comment-17703801 ] Maxim Muzafarov commented on CASSANDRA-14667: - Sure, this is good notice. I have found that version 3.1.5 is no longer maintained by Dropwizard, so it might cause some problems for us with JDK 17. The 4.2.17 seems to be OK according to the build matrix, so I decided to raise the PR with an upgrade https://github.com/dropwizard/metrics/blob/release/4.2.x/.github/workflows/maven.yml#L16 > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18239) Replace eclipse warnings based static code analysis with something better (Sonar)
[
https://issues.apache.org/jira/browse/CASSANDRA-18239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704649#comment-17704649
]
Maxim Muzafarov commented on CASSANDRA-18239:
-
[~jlewandowski], [~mck]
Hello,
As we already have Cassandra's project configured for the sonarcloud.io
INFRA-24196, I wonder if we will be able to release branches, trunk, and pull
requests to get analyzed by the SonarAnalyzer tool.
I have prepared changes to run the sonar analyzer with GA:
https://github.com/apache/cassandra/compare/trunk...Mmuzaf:cassandra:sonar
I have tested it locally (the ant tool part) with my SonarQube deployed locally
on http://localhost:9000 instance and it seems it works and analyses classes
correctly. However, I can't test in a real environment. At least we need to set
the right {{sonar.projectKey}} (the infra team should provide it), and the
{{SONARCLOUD_TOKEN}} is available for the project.
Can you take a look and help? :-)
> Replace eclipse warnings based static code analysis with something better
> (Sonar)
> -
>
> Key: CASSANDRA-18239
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18239
> Project: Cassandra
> Issue Type: Task
> Components: Build
>Reporter: Jacek Lewandowski
>Priority: Normal
>
> Eclipse warnings is used for static code analysis. However, it does not fit
> well into Cassandra code and practically we end up explicitly adding
> suppressions in many places just to satisfy that tool rather than fix the
> real issues.
> This is an incomplete list of reasons to remove it:
> - not closed resources are detected incorrectly
> - does not recognize custom utility methods used to close the resources,
> which use use heavily in the code, like {{Throwables.close}},
> {{FileUtils.close}}, {{closeQuietly}}...
> - because of the above, we cannot make important things like {{Ref}} to
> implement {{Closeable}} as it would make the tool to explode with tons of
> warnings
> - it complains about correct generics - something like "method X is not
> applicable for ..." when the code compiles successfully is not acceptable
> - it is old and not maintained
> There are better tools like IntelliJ inspections for example, which can also
> be run in headless mode
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Updated] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov updated CASSANDRA-14667: Fix Version/s: 5.x > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703767#comment-17703767 ] Maxim Muzafarov commented on CASSANDRA-14667: - [~smiklosovic] Thank you for helping with this, waiting for the build results. > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-14667) Upgrade Dropwizard Metrics to 4.x
[ https://issues.apache.org/jira/browse/CASSANDRA-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov reassigned CASSANDRA-14667: --- Assignee: Maxim Muzafarov > Upgrade Dropwizard Metrics to 4.x > - > > Key: CASSANDRA-14667 > URL: https://issues.apache.org/jira/browse/CASSANDRA-14667 > Project: Cassandra > Issue Type: Task > Components: Observability/Metrics >Reporter: Stig Rohde Døssing >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Cassandra currently uses Metrics 3.1.5. Version 4.0.0 added some fixes for > Java 9 compatibility. It would be good to upgrade the Metrics library as part > of the version of Cassandra that adds Java 9 compatibility > (https://issues.apache.org/jira/browse/CASSANDRA-9608). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-17971) Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
[
https://issues.apache.org/jira/browse/CASSANDRA-17971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700626#comment-17700626
]
Maxim Muzafarov commented on CASSANDRA-17971:
-
[~mck], [~e.dimitrova]
Hello, I have found that the NetBeans classpath should be updated as well,
right? It still points to 9.3 version instead of 9.4
{code:java}
..
${project.dir}/build/lib/jars/asm-9.3.jar:${project.dir}/build/test/lib/jars/asm-9.3.jar:${project.dir}/build/test/lib/jars/asm-analysis-9.3.jar:${project.dir}/build/test/lib/jars/asm-commons-9.3.jar:${project.dir}/build/test/lib/jars/asm-tree-9.3.jar:${project.dir}/build/test/lib/jars/asm-util-9.3.jar:${project.dir}/build/test/lib/jars/asm-xml-6.0.jar
{code}
> Opcodes.ASM7 to be updated when JDK17 support is added for Cassandra
>
>
> Key: CASSANDRA-17971
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17971
> Project: Cassandra
> Issue Type: Task
> Components: Build, Dependencies, Feature/UDF
>Reporter: Ekaterina Dimitrova
>Assignee: Michael Semb Wever
>Priority: Normal
> Fix For: 5.0
>
>
> In CASSANDRA-17873 we updated the ASM opcode inconsistencies for JDK11, we
> need to revise it again before we switch fro jdk8&11 to jdk11&17
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695757#comment-17695757 ] Maxim Muzafarov commented on CASSANDRA-15254: - [~dcapwell] It looks like we have reached a consensus on the dev@ and the design details of all the comments above here. I'll prepare the final PR shortly. > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Maxim Muzafarov >Priority: Normal > Attachments: Configuration Registry Diagram.png > > Time Spent: 40m > Remaining Estimate: 0h > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-15254) Allow UPDATE on settings virtual table to change running configurations
[ https://issues.apache.org/jira/browse/CASSANDRA-15254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695926#comment-17695926 ] Maxim Muzafarov commented on CASSANDRA-15254: - [~dcapwell] Everything you mentioned is correct and all these points will be covered by PR. I would add one concern to this list to address - since we are going to have two different APIs working with the same set of properties, we need to ensure thread safety when changing a property and calling the property's corresponding listeners (subsystem listening for a property change must mutate its internal state safely). > Allow UPDATE on settings virtual table to change running configurations > --- > > Key: CASSANDRA-15254 > URL: https://issues.apache.org/jira/browse/CASSANDRA-15254 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Virtual Tables >Reporter: Chris Lohfink >Assignee: Maxim Muzafarov >Priority: Normal > Attachments: Configuration Registry Diagram.png > > Time Spent: 40m > Remaining Estimate: 0h > > Allow using UPDATE on the system_views.settings virtual table to update > configs at runtime for the equivalent of the dispersed JMX > attributes/operations. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Assigned] (CASSANDRA-18131) LongBTreeTest times out after btree improvements from CASSANDRA-15510
[ https://issues.apache.org/jira/browse/CASSANDRA-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maxim Muzafarov reassigned CASSANDRA-18131: --- Assignee: Maxim Muzafarov > LongBTreeTest times out after btree improvements from CASSANDRA-15510 > - > > Key: CASSANDRA-18131 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18131 > Project: Cassandra > Issue Type: Bug > Components: Local/Memtable >Reporter: Michael Semb Wever >Assignee: Maxim Muzafarov >Priority: Normal > Fix For: 4.0.x, 4.1.x, 4.x > > > Happening in both ci-cassandra.a.o and circleci. > LongBTreeTest is timing out on 4.0, 4.1, trunk branches. > Started back in mid April > (https://github.com/apache/cassandra/commit/018c8e0d5e and > https://github.com/apache/cassandra/commit/596daeb7f08). > Nightlies shows when the failures started, evident by the > 'jdk=jdk_1.8_latest,label=cassandra,split=7/' subfolder missing in the > following… > - > https://nightlies.apache.org/cassandra/trunk/Cassandra-trunk-test-burn/1254/Cassandra-trunk-test-burn/ > - > https://nightlies.apache.org/cassandra/cassandra-4.0/Cassandra-4.0-test-burn/343/ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-18131) LongBTreeTest times out after btree improvements from CASSANDRA-15510
[ https://issues.apache.org/jira/browse/CASSANDRA-18131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693183#comment-17693183 ] Maxim Muzafarov commented on CASSANDRA-18131: - Hello everyone, I'll try to take a look at the cause. Please let me know if your vision has changed or if the issue is no longer relevant. > LongBTreeTest times out after btree improvements from CASSANDRA-15510 > - > > Key: CASSANDRA-18131 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18131 > Project: Cassandra > Issue Type: Bug > Components: Local/Memtable >Reporter: Michael Semb Wever >Priority: Normal > Fix For: 4.0.x, 4.1.x, 4.x > > > Happening in both ci-cassandra.a.o and circleci. > LongBTreeTest is timing out on 4.0, 4.1, trunk branches. > Started back in mid April > (https://github.com/apache/cassandra/commit/018c8e0d5e and > https://github.com/apache/cassandra/commit/596daeb7f08). > Nightlies shows when the failures started, evident by the > 'jdk=jdk_1.8_latest,label=cassandra,split=7/' subfolder missing in the > following… > - > https://nightlies.apache.org/cassandra/trunk/Cassandra-trunk-test-burn/1254/Cassandra-trunk-test-burn/ > - > https://nightlies.apache.org/cassandra/cassandra-4.0/Cassandra-4.0-test-burn/343/ -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
