Re: [darktable-dev] sharpen module

[Pascal Obry]

Hello Heiko,

> Looking at the code of the current unsharp mask method I realized that 
> the module uses its own implementation of a gaussian blur filter.  Is 
> there any reason not to employ the one in src/common/gaussian.[ch]?  Are 
> there any concerns against simplifying the sharpening module's 
> implementation and just calling the functions from 
> src/common/gaussian.[ch]?

I think this is the right way; Aurélien did notice lot of code
duplication while working on the GUI redesign.

We just need to be sure that the algorithm in src/common/gaussian.[ch]
is equivalent to the one in gaussian.[ch].

> The deconvolution method also needs to apply gaussian blur kernels and I 
> would prefer to use the ones in src/common/gaussian.[ch] only.

Let's go with that if we are sure the algo are equivalent. Code
duplication is not good in the long run.

Thanks,

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] HELP NEEDED - long gtk menu does not scroll

[Pascal Obry]

Le mercredi 17 avril 2019 à 19:46 +0200, Robert Rembold a écrit :
> It's a known issue which was introduced after 3.24.3 and should be solved in 
> 3.24.7: https://gitlab.gnome.org/GNOME/gtk/issues/1719

Great! Thanks for the pointer, too bad I spent some much time on this :)

I'll wait for 3.24.7 to be available and will test again.

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] HELP NEEDED - long gtk menu does not scroll

[David Vincent-Jones]

My normal font size now appears to look fine but there appears to be a 
great deal of misplaced bold font being used. I also not that the line 
spacing looks like it is set at 2 which is really extending the module 
lengths.


On 2019-04-17 10:46 a.m., Robert Rembold wrote:
It's a known issue which was introduced after 3.24.3 and should be 
solved in 3.24.7: https://gitlab.gnome.org/GNOME/gtk/issues/1719


Am 17.04.19 um 19:35 schrieb William Ferguson:

My gtk2 is 2.24.32, so only the gtk3 is different 3.22.30 vs 3.24.x

On Wed, Apr 17, 2019 at 1:24 PM Robert Rembold > wrote:


Hi Pascal,
Unfortunately, I also noticed the described issue here. You're
not alone ;)

My settings are as follows:
- Ubuntu 18.10 with Xfce
- 1920*1080 screen resolution
- gtk-2.24.32
- gtk-3.24.4
- built darktable from sources few days ago (if exact version
matters I
can check)

Best Regards,
Robert

Am 17.04.19 um 18:13 schrieb Pascal Obry:
> Hi Bill,
>
> Thanks for testing.
>
>> Did a pull yesterday and built from git last night.  Opened
the Canon
>> lens list and was able to scroll with the mouse wheel.  If I
move to
>> the top of the list it autoscrolls up and the same with the bottom
>> even though the arrow buttons(?) aren't visible. I'm on Ubuntu
>> 18.04.  I also checked 2.6.2, built from source, and it worked
fine
>> also, and the top and bottom arrow buttons(?) are visible.
> So that's on my side! Hum, what is your Gtk+ version? Maybe a
bug in my
> version. I'm using 3.24.5-1 on Debian (tested on 2 machines).
>

___
darktable developer mailing list
to unsubscribe send a mail to
darktable-dev+unsubscr...@lists.darktable.org



___ 
darktable developer mailing list to unsubscribe send a mail to 
darktable-dev+unsubscr...@lists.darktable.org




___ 
darktable developer mailing list to unsubscribe send a mail to 
darktable-dev+unsubscr...@lists.darktable.org


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] where to discuss big changes

[parafin]

I think we mix up 2 (or 3) different things in this topic. Let's say
a contributor wants to implement some feature:

First some discussion should probably happen, for example other
developers can help with pointers on how said feature can and should be
integrated into DT core. I don't see any need for this to be stored
anywhere or accessed by everyone else, because a lot of it will be
discarded ideas and just thoughts "out loud". Having to formulate them
carefully (as it's expected with mailing lists or forums) will just
impede communications at this stage. Historically IRC was used and I
think it's still the best tool, the only problem here is timezone
differences between developers.

Another issue is documenting the design of said feature. Right now such
documentation is basically absent in DT, but I think it would be very
useful. Something like wiki can be used for this purpose and DT actually
already had it for a long time:
https://redmine.darktable.org/projects/darktable/wiki
Of course nobody wants to write documentation, and my suggestions that
it should be done were already rejected for a couple of big features
recently merged into git master. I don't really see this changing just
because we choose some platform that currently is in fashion.

Somewhat separate issue are discussions about release planning and so
on. These I think concern only a limited number of people (specifically
developers with commit rights and package maintainers) and also
historically happened in IRC. Probably mailing list can be used also
for these, depending on the topic (if there's a lot to discuss it's
more efficient to have real-time communication though).

But all this of course is just idealisation, real life makes
corrections and compromises have to be taken. So I would suggest not to
overthink it with "pros" and "cons" of various technologies and just
make sure that necessary people are included in the loop of decision
making whatever way is actually possible.


On Wed, 17 Apr 2019 13:26:08 -0400
William Ferguson  wrote:

> We are facing the same issue, where to discuss things, with the lua-scripts
> repository.  We've thought about using github issues and discuss.pixls.us,
> but we still haven't come up with a solution.  I think I'm just going to
> try the github issues and see how it goes.
> 
> Bill
> 
> On Wed, Apr 17, 2019 at 1:22 PM Pascal Obry  wrote:
> 
> > Le mercredi 17 avril 2019 à 14:12 -0300, Moritz Moeller a écrit :  
> > > But I agree with parent that it is not the right tool to discuss big
> > > changes.
> > > IRC has no history. IRC has no message threads.
> > > That's why I mentioned NNTP.  
> >
> > My first best is GitHub Issues.
> >
> > You create an enhancement request there. It is discussed, we can add
> > some design notes...
> >
> > Then a PR is created for this and the PR can (should) reference the
> > issue number for tracking purpose. Then you'll end up with a commit
> > with a reference to the design.
> >
> > We can't do best :)
> >
> > --
> >   Pascal Obry /  Magny Les Hameaux (78)
> >
> >   The best way to travel is by means of imagination
> >
> >   http://www.obry.net
> >
> >   gpg --keyserver keys.gnupg.net --recv-key F949BD3B
> >
> > ___
> > darktable developer mailing list
> > to unsubscribe send a mail to
> > darktable-dev+unsubscr...@lists.darktable.org
> >
> >  
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

[darktable-dev] sharpen module

[Heiko Bauke]

Hi,

I just started to implement a simple (non-blind) deconvolution filter as 
an addition sharpening method.  I plan to add this as an additional mode 
for the sharpening module.


Looking at the code of the current unsharp mask method I realized that 
the module uses its own implementation of a gaussian blur filter.  Is 
there any reason not to employ the one in src/common/gaussian.[ch]?  Are 
there any concerns against simplifying the sharpening module's 
implementation and just calling the functions from 
src/common/gaussian.[ch]?


The deconvolution method also needs to apply gaussian blur kernels and I 
would prefer to use the ones in src/common/gaussian.[ch] only.



Heiko


--
-- Number Crunch Blog @ https://www.numbercrunch.de
--  Cluster Computing @ https://www.clustercomputing.de
--  Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] HELP NEEDED - long gtk menu does not scroll

[Robert Rembold]

It's a known issue which was introduced after 3.24.3 and should be 
solved in 3.24.7: https://gitlab.gnome.org/GNOME/gtk/issues/1719


Am 17.04.19 um 19:35 schrieb William Ferguson:

My gtk2 is 2.24.32, so only the gtk3 is different 3.22.30 vs 3.24.x

On Wed, Apr 17, 2019 at 1:24 PM Robert Rembold > wrote:


Hi Pascal,
Unfortunately, I also noticed the described issue here. You're not
alone ;)

My settings are as follows:
- Ubuntu 18.10 with Xfce
- 1920*1080 screen resolution
- gtk-2.24.32
- gtk-3.24.4
- built darktable from sources few days ago (if exact version
matters I
can check)

Best Regards,
Robert

Am 17.04.19 um 18:13 schrieb Pascal Obry:
> Hi Bill,
>
> Thanks for testing.
>
>> Did a pull yesterday and built from git last night. Opened the
Canon
>> lens list and was able to scroll with the mouse wheel.  If I
move to
>> the top of the list it autoscrolls up and the same with the bottom
>> even though the arrow buttons(?) aren't visible.  I'm on Ubuntu
>> 18.04.  I also checked 2.6.2, built from source, and it worked fine
>> also, and the top and bottom arrow buttons(?) are visible.
> So that's on my side! Hum, what is your Gtk+ version? Maybe a
bug in my
> version. I'm using 3.24.5-1 on Debian (tested on 2 machines).
>

___
darktable developer mailing list
to unsubscribe send a mail to
darktable-dev+unsubscr...@lists.darktable.org



___ 
darktable developer mailing list to unsubscribe send a mail to 
darktable-dev+unsubscr...@lists.darktable.org




___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] HELP NEEDED - long gtk menu does not scroll

[Robert Rembold]

Hi Pascal,
Unfortunately, I also noticed the described issue here. You're not alone ;)

My settings are as follows:
- Ubuntu 18.10 with Xfce
- 1920*1080 screen resolution
- gtk-2.24.32
- gtk-3.24.4
- built darktable from sources few days ago (if exact version matters I 
can check)


Best Regards,
Robert

Am 17.04.19 um 18:13 schrieb Pascal Obry:

Hi Bill,

Thanks for testing.


Did a pull yesterday and built from git last night.  Opened the Canon
lens list and was able to scroll with the mouse wheel.  If I move to
the top of the list it autoscrolls up and the same with the bottom
even though the arrow buttons(?) aren't visible.  I'm on Ubuntu
18.04.  I also checked 2.6.2, built from source, and it worked fine
also, and the top and bottom arrow buttons(?) are visible.

So that's on my side! Hum, what is your Gtk+ version? Maybe a bug in my
version. I'm using 3.24.5-1 on Debian (tested on 2 machines).



___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] where to discuss big changes

[Pascal Obry]

Le mercredi 17 avril 2019 à 14:12 -0300, Moritz Moeller a écrit :
> But I agree with parent that it is not the right tool to discuss big 
> changes.
> IRC has no history. IRC has no message threads.
> That's why I mentioned NNTP.

My first best is GitHub Issues.

You create an enhancement request there. It is discussed, we can add
some design notes...

Then a PR is created for this and the PR can (should) reference the
issue number for tracking purpose. Then you'll end up with a commit
with a reference to the design.

We can't do best :)

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] where to discuss big changes

[Moritz Moeller]

On 17.4.19 09:16, johannes hanika wrote:
i second the 'getting old' bit. and i really like IRC. 


Maybe you misunderstood my message's intend?
Yes, I too prefer IRC over any 'modern' chat client.

But I agree with parent that it is not the right tool to discuss big 
changes.

IRC has no history. IRC has no message threads.
That's why I mentioned NNTP.
E-mail is the 2nd best alternative.
IRC isn't one at all. IMHO.

Beers,

.mm
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] HELP NEEDED - long gtk menu does not scroll

[Pascal Obry]

Hi Bill,

Thanks for testing.

> Did a pull yesterday and built from git last night.  Opened the Canon
> lens list and was able to scroll with the mouse wheel.  If I move to
> the top of the list it autoscrolls up and the same with the bottom
> even though the arrow buttons(?) aren't visible.  I'm on Ubuntu
> 18.04.  I also checked 2.6.2, built from source, and it worked fine
> also, and the top and bottom arrow buttons(?) are visible.

So that's on my side! Hum, what is your Gtk+ version? Maybe a bug in my
version. I'm using 3.24.5-1 on Debian (tested on 2 machines).

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] HELP NEEDED - long gtk menu does not scroll

[William Ferguson]

Did a pull yesterday and built from git last night.  Opened the Canon lens
list and was able to scroll with the mouse wheel.  If I move to the top of
the list it autoscrolls up and the same with the bottom even though the
arrow buttons(?) aren't visible.  I'm on Ubuntu 18.04.  I also checked
2.6.2, built from source, and it worked fine also, and the top and bottom
arrow buttons(?) are visible.

Bill

On Wed, Apr 17, 2019 at 5:21 AM Pascal Obry  wrote:

>
> This is driving me crazy and I don't find a solution.
>
> Take the lens correction module, click on the camera to get a list.
> Select Nikon or Canon as there is a very long sub-menu. But in this
> sub-menu you cannot scroll. There is no arrows on top or bottom and the
> mouse scroll does nothing. This means that only the visible camera can
> be selected.
>
> This is already a problem on 2.6.2 and can be reproduced on master.
>
> While playing with CSS I had some time the chance to see the arrows and
> to have a scrollable window. But it worked only once!
>
> So looking for help if there is a Gtk+ expert around.
>
> Thanks,
>
> --
>   Pascal Obry /  Magny Les Hameaux (78)
>
>   The best way to travel is by means of imagination
>
>   http://www.obry.net
>
>   gpg --keyserver keys.gnupg.net --recv-key F949BD3B
>
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] where to discuss big changes

[Pascal Obry]

Le mercredi 17 avril 2019 à 08:47 -0400, Mark Feit a écrit :
> PRs shouldn't exist until there's code to be pulled.  Sometimes there's 
> discussion about a project before anyone writes a single line.

I just don't agree. Many nice dt features won't have been created
otherwise. Many people like dt, hack it to see if they can do something
and try to create something for their need first.

Then at some point the PR is created. But it is not because it is
created that it will be merged. I have recently closed many PR.

Remember dt coding must be fun. Too many rules and you'll just kill the
project. Actually that's how I see things happening and that's how I'll
drive the project as long as I have enough energy.

And what I said above do not mean that I don't want features discussed
before hand. Some contributor will probably want to do that either
because they are really not sure on how to do things at the design
level or because the new feature is complex to implement.

-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] where to discuss big changes

[Mark Feit]

On 4/16/19 1:51 PM, rawfiner wrote:


Using github by commenting directly on PRs


I'm in favor of this with some modifications with the mailing list as a 
second choice.  IRC is too ephemeral without logging and conversations 
can go on for days and end up intermixed with other topics, making it 
hard to pick through.


PRs shouldn't exist until there's code to be pulled.  Sometimes there's 
discussion about a project before anyone writes a single line.  These 
projects should be started as issues that we can organize using tags.



pros:
- we can comment directly near the code, and we can comment code details
- people can see the message when they want, and reply when they want, 
wherever they are on the planet

- we can have conversations organised by topics (PRs)


In addition to all of that, the commits can refer to the issues (e.g., 
"Overhaul of malloc() and free()  #1234") so anyone looking at the code 
has a near-direct path to the entire history of how it got there.


If a discussion takes place elsewhere (IRC or the mailing list), the 
conversation should be copied out and added to the issue or, if it 
persists, add a link to it.



cons:
- devs will have to check new PRs regularly to give their opinion, and 
a big-change PR may "hide" in between small ones. However, we could 
easily have a tag "big-change" to request devs to pay attention to 
particular PRs, or use the PRs names to indicate such big changes


This isn't any different than looking at the issues that get written for 
bugs, which makes a good case for using issues (or Redmine or anything 
similar).


- big changes should be discussed before making them. Yet, I think 
this drawback can be compensated by making PRs really early, which is 
already done by several of us (see PRs with [WIP] in the title)


Work-in-progress PRs lower the signal-to-noise ratio for those 
considering PRs.  If someone is working on a project, they should be 
doing it in their own GitHub space and requesting a pull when it's ready 
to be integrated.


As for the concerns about GitHub going away:  Everything the project has 
on GitHub can be backed up.  I do this twice a day for my own work and 
anything I depend on (darktable included): 
https://github.com/markfeit/github-backup.



Another way to have this discussion would be to come up with an 
agreeable workflow and then find the tools that fit it.


--Mark


___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] where to discuss big changes

[Šarūnas]

On 4/16/19 11:46 PM, Moritz Moeller wrote:
> There is this thing called 'a news server' which has all of below
> but has infinite history (for free) and you can actually see who
> replied to whom before even opening/deciding to read a message.
> 
> That feature alone makes a news server with a decent client (e.g. 
> Thunderbird) a thousand times superior to something like e.g. Slack.
> 
> And this stuff has been available since the 70's. For free. Maybe I'm
> just getting old. Just my two c.

+2¢ for NNTP. Good old clean tech.

-- 
Šarūnas Burdulis
math.dartmouth.edu/~sarunas



signature.asc
Description: OpenPGP digital signature

Re: [darktable-dev] where to discuss big changes

[johannes hanika]

i second the 'getting old' bit. and i really like IRC. i could never
get the hang of these fancy websites that force you to use a mouse.
for slack at least there used to be an IRC bridge. it seems mattermost
may be an alternative that does support IRC, for those of us who
insist on animated gifs for team comm.

i would not like to give away our main/official communication channel
to an untrusted third party that may shut it down without notice any
time.

fwiw our mailing list is archived:
https://www.mail-archive.com/darktable-dev@lists.darktable.org/

cheers,
 jo

On Wed, Apr 17, 2019 at 3:47 PM Moritz Moeller  wrote:
>
> There is this thing called 'a news server' which has all of below but
> has infinite history (for free) and you can actually see who replied to
> whom before even opening/deciding to read a message.
>
> That feature alone makes a news server with a decent client (e.g.
> Thunderbird) a thousand times superior to something like e.g. Slack.
>
> And this stuff has been available since the 70's. For free.
> Maybe I'm just getting old. Just my two c.
>
>
> Beers.
>
> .mm
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
>
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

[darktable-dev] HELP NEEDED - long gtk menu does not scroll

[Pascal Obry]

This is driving me crazy and I don't find a solution.

Take the lens correction module, click on the camera to get a list.
Select Nikon or Canon as there is a very long sub-menu. But in this
sub-menu you cannot scroll. There is no arrows on top or bottom and the
mouse scroll does nothing. This means that only the visible camera can
be selected.

This is already a problem on 2.6.2 and can be reproduced on master.

While playing with CSS I had some time the chance to see the arrows and
to have a scrollable window. But it worked only once!

So looking for help if there is a Gtk+ expert around.

Thanks,
 
-- 
  Pascal Obry /  Magny Les Hameaux (78)

  The best way to travel is by means of imagination

  http://www.obry.net

  gpg --keyserver keys.gnupg.net --recv-key F949BD3B

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] where to discuss big changes

[Heiko Bauke]

Hi,

Am 16.04.19 um 19:51 schrieb rawfiner:
Currently, the place where big changes should be discussed is IRC 
(according to houz, as I have not seen this information anywhere, which 
is problematic as new contributors may make big changes, so they have at 
least to be able to know where is the place to discuss things).

I think IRC is not convenient at all.

I would like to discuss why I think making these discussion on IRC is 
bad, and what alternatives we have.


rawfiner draws our attention to some very important issue here. 
Discussing darktable on very different channels is inefficient.  We 
should consolidate discussions about darktable development to a single 
channel.


I completely agree with the pros and cons mentioned by rafiner.  I do 
not use IRC for the reasons mentioned by rawfiner.  I do use, however, 
github, as it is the most convenient platform for me.  I would invest 
even more time to participate in discussions on github if this would be 
the commonly accepted platform for discussions on darktable development.


Nevertheless, I am also aware of the potential drawbacks of relaying too 
heavily on the github platform.  Possibly, we should redirect people to 
https://redmine.darktable.org/



Heiko

--
-- Number Crunch Blog @ https://www.numbercrunch.de
--  Cluster Computing @ https://www.clustercomputing.de
--  Social Networking @ https://www.researchgate.net/profile/Heiko_Bauke
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org